[GitHub] guacamole-website pull request #63: Add documentation for 1.0.0.
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-website/pull/63 Add documentation for 1.0.0. Documentation for the first RC per: http://guacamole.apache.org/release-procedures-part2/#upload-docs You can merge this pull request into a Git repository by running: $ git pull https://github.com/mike-jumper/guacamole-website doc-1.0.0 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/guacamole-website/pull/63.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #63 commit 044692cfe4a81b68c2dbe29c5c5e08b1da0645f2 Author: Michael Jumper Date: 2018-12-21T21:49:53Z Add documentation for 1.0.0. commit a5693fdfe4751554e6779fd6cd3c26dbd9bb0a4b Author: Michael Jumper Date: 2018-12-21T21:51:23Z Add Google Analytics tracking code to 1.0.0 documentation. ---
[GitHub] guacamole-client pull request #347: GUACAMOLE-682: docker build with optiona...
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/347#discussion_r243608567 --- Diff: guacamole-docker/bin/build-guacamole.sh --- @@ -53,7 +54,12 @@ mkdir -p "$DESTINATION" # cd "$BUILD_DIR" -mvn package + +if [ -z "$BUILD_PROFILE" ]; then + mvn package +else + mvn -P "$BUILD_PROFILE" package +fi --- End diff -- Please stick with accepted style of four-space indentations. ---
[GitHub] guacamole-client pull request #347: GUACAMOLE-682: docker build with optiona...
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/347#discussion_r243608670 --- Diff: guacamole-docker/bin/build-guacamole.sh --- @@ -107,3 +113,11 @@ tar -xzf extensions/guacamole-auth-ldap/target/*.tar.gz \ "*.jar" \ "*.ldif" +# +# Copy Radius auth extension if it was build +# + +if [ -f extensions/guacamole-auth-radius/target/guacamole-auth-radius*.jar ]; then + mkdir -p "$DESTINATION/radius" + cp extensions/guacamole-auth-radius/target/guacamole-auth-radius*.jar "$DESTINATION/radius" --- End diff -- As with above, four-space indentations, please ---