[GitHub] guacamole-client pull request #347: GUACAMOLE-682: docker build with optiona...

[mike-jumper]

Github user mike-jumper commented on a diff in the pull request:

https://github.com/apache/guacamole-client/pull/347#discussion_r243742443
  
--- Diff: guacamole-docker/bin/build-guacamole.sh ---
@@ -41,6 +41,7 @@
 
 BUILD_DIR="$1"
 DESTINATION="$2"
+BUILD_PROFILE="$3"
--- End diff --

This new `BUILD_PROFILE` parameter for `build-guacamole.sh` needs to be 
documented with an `@param` in the corresponding comment block (see the 
Doxygen-style block above covering this script and the other two parameters).


---

[GitHub] guacamole-client pull request #347: GUACAMOLE-682: docker build with optiona...

[jolentes]

Github user jolentes commented on a diff in the pull request:

https://github.com/apache/guacamole-client/pull/347#discussion_r243730984
  
--- Diff: guacamole-docker/bin/build-guacamole.sh ---
@@ -107,3 +113,11 @@ tar -xzf 
extensions/guacamole-auth-ldap/target/*.tar.gz \
 "*.jar" \
 "*.ldif"
 
+#
+# Copy Radius auth extension if it was build
+#
+
+if [ -f extensions/guacamole-auth-radius/target/guacamole-auth-radius*.jar 
]; then
+  mkdir -p "$DESTINATION/radius"
+  cp extensions/guacamole-auth-radius/target/guacamole-auth-radius*.jar 
"$DESTINATION/radius"
--- End diff --

corrected


---