[GitHub] guacamole-client pull request #273: GUACAMOLE-549: Migrate to localStorage f...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/guacamole-client/pull/273


---

[GitHub] guacamole-client pull request #273: GUACAMOLE-549: Migrate to localStorage f...

[mike-jumper]

GitHub user mike-jumper opened a pull request:

https://github.com/apache/guacamole-client/pull/273

GUACAMOLE-549: Migrate to localStorage for storage of auth token.

This change:

* Adds a new service, `localStorageService` / 
`localStorageServiceProvider`, which abstracts away handling of 
`window.localStorage` such that browser lack of support and lack of permission 
is handled transparently (falling back to temporary in-memory storage).
* Migrates storage of what used to be the `GUAC_AUTH` cookie to 
`localStorage` via the `localStorageService`.
* Migrates all previous direct use of `localStorage` (`guacHistory` and 
`preferenceService`) to `localStorageService`.
* Removes the dependency on "ngCookies" / "angular-cookies", as the webapp 
no longer makes use of client-side cookies whatsoever.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mike-jumper/guacamole-client 
localstorage-token

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/guacamole-client/pull/273.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #273


commit 11d356a70b83668d668af9fdecf337af0009ed81
Author: Michael Jumper 
Date:   2018-04-19T03:42:27Z

GUACAMOLE-549: Add service for manipulating items within localStorage.

commit 831e4e0989a96f304d848f67de2fb178e8d736f6
Author: Michael Jumper 
Date:   2018-04-19T03:43:04Z

GUACAMOLE-549: Migrate recent connection history to localStorageService.

commit 1686e6f149fb6d3ea80217ed18792d22ded45e6f
Author: Michael Jumper 
Date:   2018-04-19T03:43:30Z

GUACAMOLE-549: Migrate storage/retrieval of local preferences to 
localStorageService.

commit 884a9c0ee987f9cb49a69ceb17eb0e2267eed058
Author: Michael Jumper 
Date:   2018-04-19T03:44:08Z

GUACAMOLE-549: Store auth token within localStorage rather than cookie.




---