[GitHub] guacamole-server pull request #204: GUACAMOLE-354: Add Swiss-German keymap f...

2018-12-04 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/guacamole-server/pull/204


---


[GitHub] guacamole-server pull request #204: GUACAMOLE-354: Add Swiss-German keymap f...

2018-12-03 Thread andrin-jost
Github user andrin-jost commented on a diff in the pull request:

https://github.com/apache/guacamole-server/pull/204#discussion_r238549377
  
--- Diff: src/protocols/rdp/keymaps/de_ch_qwertz.keymap ---
@@ -0,0 +1,58 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+parent  "base"
+name"ch-de-qwertz"
--- End diff --

Oh, yes you're right


---


[GitHub] guacamole-server pull request #204: GUACAMOLE-354: Add Swiss-German keymap f...

2018-12-03 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request:

https://github.com/apache/guacamole-server/pull/204#discussion_r238316700
  
--- Diff: src/protocols/rdp/keymaps/de_ch_qwertz.keymap ---
@@ -0,0 +1,58 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+parent  "base"
+name"ch-de-qwertz"
--- End diff --

The keyboard name should be LANG-COUNTRY-VARIANT, same as the filename 
except with dashes instead of underscores. Is "de-ch-qwertz" correct here or 
"ch-de-qwertz"?


---


[GitHub] guacamole-server pull request #204: GUACAMOLE-354: Add Swiss-German keymap f...

2018-11-21 Thread andrin-jost
GitHub user andrin-jost opened a pull request:

https://github.com/apache/guacamole-server/pull/204

GUACAMOLE-354: Add Swiss-German keymap for RDP



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andrin-jost/guacamole-server de-ch-keymap

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/guacamole-server/pull/204.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #204


commit 9486ec7cc491514ba2acd59ccf286edd32d32ec2
Author: Andrin 
Date:   2018-11-20T13:10:36Z

GUACAMOLE-354: Add Swiss-German keymap for RDP




---