[GitHub] incubator-hawq pull request: HAWQ-444. The counter for increasing ...
Github user jiny2 closed the pull request at: https://github.com/apache/incubator-hawq/pull/379 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request: HAWQ-444. The counter for increasing ...
Github user yaoj2 commented on the pull request: https://github.com/apache/incubator-hawq/pull/379#issuecomment-18803 ï¼1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request: HAWQ-444. The counter for increasing ...
Github user linwen commented on the pull request: https://github.com/apache/incubator-hawq/pull/379#issuecomment-188029562 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request: HAWQ-444. The counter for increasing ...
GitHub user jiny2 opened a pull request: https://github.com/apache/incubator-hawq/pull/379 HAWQ-444. The counter for increasing and decreasing memory quota is not correctly subtracted This fix is to remove counter of increasing and decreasing memory quota. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jiny2/incubator-hawq HAWQ-444-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/379.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #379 commit db2fa31c5bc178eac8ed6cc96f46c4fbbadff9fb Author: YI JIN Date: 2016-02-24T02:42:04Z HAWQ-444. The counter for increasing and decreasing memory quota is not correctly subtracted --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request: HAWQ-444. The counter for increasing ...
Github user sansanichfb commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/376#discussion_r53856404 --- Diff: src/test/regress/pg_regress.c --- @@ -91,8 +91,8 @@ static intport = -1; static char *user = NULL; static char *srcdir = NULL; static _stringlist *extraroles = NULL; -char *initfile = NULL; -char *expected_statuses_file = NULL; +static char *initfile = "./init_file"; --- End diff -- Got it, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request: HAWQ-444. The counter for increasing ...
Github user jiny2 commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/376#discussion_r53856281 --- Diff: src/test/regress/pg_regress.c --- @@ -91,8 +91,8 @@ static intport = -1; static char *user = NULL; static char *srcdir = NULL; static _stringlist *extraroles = NULL; -char *initfile = NULL; -char *expected_statuses_file = NULL; +static char *initfile = "./init_file"; --- End diff -- Should be a error from git, another irrelevant commit is involved. This is why I close it at once. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request: HAWQ-444. The counter for increasing ...
Github user sansanichfb commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/376#discussion_r53855896 --- Diff: src/test/regress/pg_regress.c --- @@ -91,8 +91,8 @@ static intport = -1; static char *user = NULL; static char *srcdir = NULL; static _stringlist *extraroles = NULL; -char *initfile = NULL; -char *expected_statuses_file = NULL; +static char *initfile = "./init_file"; --- End diff -- Just curios, what is the reason of this change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request: HAWQ-444. The counter for increasing ...
Github user jiny2 closed the pull request at: https://github.com/apache/incubator-hawq/pull/376 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request: HAWQ-444. The counter for increasing ...
GitHub user jiny2 opened a pull request: https://github.com/apache/incubator-hawq/pull/376 HAWQ-444. The counter for increasing and decreasing memory quota is not correctly subtracted This code change is to remove the code for the two counters. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jiny2/incubator-hawq HAWQ-444 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/376.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #376 commit dbec949620be482c1dd0b5d2cb377e5cb8bd1a04 Author: hubertzhang Date: 2016-02-23T09:35:24Z HAWQ-440. Fix bug in pg_regress of commit HAWQ-432. commit b92758f43d75bfc494df5b5ac3a5f7cc6c1951e7 Author: YI JIN Date: 2016-02-23T21:43:11Z HAWQ-444. The counter for increasing and decreasing memory quota is not correctly subtracted --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---