[GitHub] incubator-hawq pull request: HAWQ-681. Removed hcatalog_enable GUC...

[sansanichfb]

Github user sansanichfb commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/621#discussion_r60287263
  
--- Diff: src/test/regress/input/hcatalog_lookup.source ---
@@ -2,16 +2,9 @@
 -- test hcatalog lookup
 -- --
 
--- Negative test with GUC disabled
-SET hcatalog_enable = false;
-SELECT * from hcatalog.db.t;
-
 SELECT * FROM pxf_get_item_fields('Hive', '*');
--- End diff --

@shivzone good to have, but not related to this JIRA


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request: HAWQ-681. Removed hcatalog_enable GUC...

[shivzone]

Github user shivzone commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/621#discussion_r60271390
  
--- Diff: src/test/regress/input/hcatalog_lookup.source ---
@@ -2,16 +2,9 @@
 -- test hcatalog lookup
 -- --
 
--- Negative test with GUC disabled
-SET hcatalog_enable = false;
-SELECT * from hcatalog.db.t;
-
 SELECT * FROM pxf_get_item_fields('Hive', '*');
--- End diff --

for each of the higher level use case. please add a one line comment on the 
type of test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request: HAWQ-681. Removed hcatalog_enable GUC...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-hawq/pull/621


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request: HAWQ-681. Removed hcatalog_enable GUC...

[kavinderd]

Github user kavinderd commented on the pull request:

https://github.com/apache/incubator-hawq/pull/621#issuecomment-211606168
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request: HAWQ-681. Removed hcatalog_enable GUC...

[sansanichfb]

GitHub user sansanichfb opened a pull request:

https://github.com/apache/incubator-hawq/pull/621

HAWQ-681. Removed hcatalog_enable GUC.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/incubator-hawq HAWQ-681

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/621.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #621


commit bf5e92dfe7cb7a1713ac42e6fe7e40106bcd5612
Author: Oleksandr Diachenko 
Date:   2016-04-15T21:40:24Z

HAWQ-681. Removed hcatalog_enable GUC.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---