[jira] [Created] (HBASE-17735) The usage of getTable() is different between AsyncConnection and Connection
CHIA-PING TSAI created HBASE-17735: -- Summary: The usage of getTable() is different between AsyncConnection and Connection Key: HBASE-17735 URL: https://issues.apache.org/jira/browse/HBASE-17735 Project: HBase Issue Type: Wish Reporter: CHIA-PING TSAI Priority: Minor I'm employing the AsyncConnection to rewrite our application. I find the AsyncConnection#getTable() and Connection#getTable() have some "slightly" differences. # Connection#getTable() throws IOException; # AsyncConnection#getTable() requires the pool; # AsyncTable doesn't need to be closed It may confuse the developers if they have no time to trace the source code (smile). May be we can unify them? Any suggestion is welcomed -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (HBASE-17734) guard against possibly coping the qualifier in the ScanDeleteTracker
CHIA-PING TSAI created HBASE-17734:
--
Summary: guard against possibly coping the qualifier in the
ScanDeleteTracker
Key: HBASE-17734
URL: https://issues.apache.org/jira/browse/HBASE-17734
Project: HBase
Issue Type: Improvement
Reporter: CHIA-PING TSAI
Priority: Minor
If the input cell is ByteBufferKeyValue, the
ByteBufferKeyValue#getQualifierArray will copy the qualifier bytes.
ScanDeleteTracker should keep the cell rather than qualifier array.
{noformat}
public void add(Cell cell) {
long timestamp = cell.getTimestamp();
byte type = cell.getTypeByte();
if (!hasFamilyStamp || timestamp > familyStamp) {
if (type == KeyValue.Type.DeleteFamily.getCode()) {
hasFamilyStamp = true;
familyStamp = timestamp;
return;
} else if (type == KeyValue.Type.DeleteFamilyVersion.getCode()) {
familyVersionStamps.add(timestamp);
return;
}
if (deleteBuffer != null && type < deleteType) {
// same column, so ignore less specific delete
if (CellUtil.matchingQualifier(cell, deleteBuffer, deleteOffset,
deleteLength)) {
return;
}
}
// new column, or more general delete type
deleteBuffer = cell.getQualifierArray();
deleteOffset = cell.getQualifierOffset();
deleteLength = cell.getQualifierLength();
deleteType = type;
deleteTimestamp = timestamp;
}
// missing else is never called.
}
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
Successful: HBase Generate Website
Build status: Successful
If successful, the website and docs have been generated. To update the live
site, follow the instructions below. If failed, skip to the bottom of this
email.
Use the following commands to download the patch and apply it to a clean branch
based on origin/asf-site. If you prefer to keep the hbase-site repo around
permanently, you can skip the clone step.
git clone https://git-wip-us.apache.org/repos/asf/hbase-site.git
cd hbase-site
wget -O-
https://builds.apache.org/job/hbase_generate_website/506/artifact/website.patch.zip
| funzip > 404a2883f2f68f0c2762c0df62a29aebeb7da151.patch
git fetch
git checkout -b asf-site-404a2883f2f68f0c2762c0df62a29aebeb7da151
origin/asf-site
git am --whitespace=fix 404a2883f2f68f0c2762c0df62a29aebeb7da151.patch
At this point, you can preview the changes by opening index.html or any of the
other HTML pages in your local
asf-site-404a2883f2f68f0c2762c0df62a29aebeb7da151 branch.
There are lots of spurious changes, such as timestamps and CSS styles in
tables, so a generic git diff is not very useful. To see a list of files that
have been added, deleted, renamed, changed type, or are otherwise interesting,
use the following command:
git diff --name-status --diff-filter=ADCRTXUB origin/asf-site
To see only files that had 100 or more lines changed:
git diff --stat origin/asf-site | grep -E '[1-9][0-9]{2,}'
When you are satisfied, publish your changes to origin/asf-site using these
commands:
git commit --allow-empty -m "Empty commit" # to work around a current ASF
INFRA bug
git push origin asf-site-404a2883f2f68f0c2762c0df62a29aebeb7da151:asf-site
git checkout asf-site
git branch -D asf-site-404a2883f2f68f0c2762c0df62a29aebeb7da151
Changes take a couple of minutes to be propagated. You can verify whether they
have been propagated by looking at the Last Published date at the bottom of
http://hbase.apache.org/. It should match the date in the index.html on the
asf-site branch in Git.
As a courtesy- reply-all to this email to let other committers know you pushed
the site.
If failed, see https://builds.apache.org/job/hbase_generate_website/506/console
