[jira] [Created] (HBASE-25080) Should not use AssignmentManager to test whether a table is enabled or not

2020-09-21 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25080:
-

 Summary: Should not use AssignmentManager to test whether a table 
is enabled or not
 Key: HBASE-25080
 URL: https://issues.apache.org/jira/browse/HBASE-25080
 Project: HBase
  Issue Type: Improvement
  Components: master
Reporter: Duo Zhang
Assignee: Duo Zhang


Now in our code base sometimes we use AssignmentManager to test whether a table 
is enabled or not, it is just a delegation to the TableStateManager. Let's use 
TableStateManager directly.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25079) Upgrade Bootstrap to 3.3.7

2020-09-21 Thread Andrew Kyle Purtell (Jira)
Andrew Kyle Purtell created HBASE-25079:
---

 Summary: Upgrade Bootstrap to 3.3.7
 Key: HBASE-25079
 URL: https://issues.apache.org/jira/browse/HBASE-25079
 Project: HBase
  Issue Type: Improvement
  Components: security, UI
 Environment: ad
Reporter: Andrew Kyle Purtell
Assignee: Andrew Kyle Purtell
 Fix For: 3.0.0-alpha-1, 2.3.3, 1.7.0, 2.4.0, 2.2.7


Our UI embeds Bootstrap 3.0.0. There are some reported security issues. 

Upgrade to Bootstrap 3.3.7. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[DISCUSS] allow create-release and hbase-vote on personal Apache resources?

2020-09-21 Thread Tak-Lon (Stephen) Wu
Hi Nick,

Moving this to a separate email to avoid spamming the release vote.

So, I'm interested in what you proposed that can use personal apache
resources for voting, I will see if I have time to help this week or next
week.

1. for hbase-vote script the problem is just about the `wget` command won't
create the `x.y.zRC#` directory during download (I checked that with
https://dist.apache.org/repos/dist/dev/hbase/2.3.2RC4/ , the directory
created fine ), not sure why that's the different yet.

2. for create-release (
https://github.com/apache/hbase/tree/master/dev-support/create-release), I
don't have much experience and need some time to rampup (maybe Viraj knew
something already ?)

-Stephen


On Mon, Sep 21, 2020 at 11:09 AM Nick Dimiduk  wrote:
>
> On Mon, Sep 21, 2020 at 10:02 AM Tak-Lon (Stephen) Wu 
> wrote:
>
> >
> > In addition, just a learning point about the base of URL is not
> > https://dist.apache.org/repos/dist/dev/hbase/, is it normal after RC1 ?
> >
>
> Hi Stephen.
>
> While there is nothing in our policy that requires the person who
assembles
> a release candidate to be a PMC member, in practice there are a couple
> restrictions in place that require PMC action. Uploading to
dist.apache.org
> is one of them. It's totally fine to host an RC on Apache resources
> available to committers, such as home/people.apache.org (back in the day,
> this used to be the common approach). It just happens that our automation
> scripts assume use of dist.a.o, which requires PMC credentials.
>
> If you have time and interest, I would be happy to review/test patches to
> our create-release and hbase-vote automation to support changes necessary
> for committers to publish an RC. I believe Viraj is cataloging issues with
> create-release through his experience with this release.
>
> Thanks for voting!
> Nick
>
> On Sun, Sep 20, 2020 at 10:51 AM Viraj Jasani  wrote:
> >
> > > Please vote on this Apache hbase release candidate,
> > > hbase-2.3.2RC4
> > >
> > > The VOTE will remain open for at least 72 hours.
> > >
> > > [ ] +1 Release this package as Apache hbase 2.3.2
> > > [ ] -1 Do not release this package because ...
> > >
> > > The tag to be voted on is 2.3.2RC4:
> > >
> > >   https://github.com/apache/hbase/tree/2.3.2RC4
> > >
> > > The release files, including signatures, digests, as well as
CHANGES.md
> > > and RELEASENOTES.md included in this RC can be found at:
> > >
> > >   http://home.apache.org/~vjasani/2.3.2RC4/
> > >
> > > Maven artifacts are available in a staging repository at:
> > >
> > >
> > https://repository.apache.org/content/repositories/orgapachehbase-1409/
> > >
> > > Artifacts were signed with the 1C8ADFD5 key which can be found in:
> > >
> > >   https://dist.apache.org/repos/dist/release/hbase/KEYS
> > >
> > > To learn more about Apache hbase, please see
> > >
> > >   http://hbase.apache.org/
> > >
> > > Thanks,
> > > Your HBase Release Manager
> > >
> >


[jira] [Created] (HBASE-25078) QuotaRefresherChore doesn't update the User RPC Throttle quota effectively

2020-09-21 Thread Pankaj Kumar (Jira)
Pankaj Kumar created HBASE-25078:


 Summary: QuotaRefresherChore doesn't update the User RPC Throttle 
quota effectively
 Key: HBASE-25078
 URL: https://issues.apache.org/jira/browse/HBASE-25078
 Project: HBase
  Issue Type: Improvement
  Components: Quotas
Reporter: Pankaj Kumar


Currently RegionServer record a user on their first RPC and trigger the 
QuotaCache refresh,


 
https://github.com/apache/hbase/blob/8a6299bb387aaedcdab05224a462e63cd121fbb0/hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaCache.java#L136


And QuotaRefresherChore refresh quota periodically for those users who are 
recorded by RegionServer on their first RPC, 


https://github.com/apache/hbase/blob/8a6299bb387aaedcdab05224a462e63cd121fbb0/hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaCache.java#L284

 

So even though user quota is set but it will be updated when user send RPC. 
Here each user will get 1 extra RPC in each RegionServer life and same will 
continue when got restarted. 

 

We can enhance this by doing narrow scan on quota table to get the user 
specific quota



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: [VOTE] Third HBase 2.3.2 release candidate (RC4) is available

2020-09-21 Thread Nick Dimiduk
On Mon, Sep 21, 2020 at 10:02 AM Tak-Lon (Stephen) Wu 
wrote:

>
> In addition, just a learning point about the base of URL is not
> https://dist.apache.org/repos/dist/dev/hbase/, is it normal after RC1 ?
>

Hi Stephen.

While there is nothing in our policy that requires the person who assembles
a release candidate to be a PMC member, in practice there are a couple
restrictions in place that require PMC action. Uploading to dist.apache.org
is one of them. It's totally fine to host an RC on Apache resources
available to committers, such as home/people.apache.org (back in the day,
this used to be the common approach). It just happens that our automation
scripts assume use of dist.a.o, which requires PMC credentials.

If you have time and interest, I would be happy to review/test patches to
our create-release and hbase-vote automation to support changes necessary
for committers to publish an RC. I believe Viraj is cataloging issues with
create-release through his experience with this release.

Thanks for voting!
Nick

On Sun, Sep 20, 2020 at 10:51 AM Viraj Jasani  wrote:
>
> > Please vote on this Apache hbase release candidate,
> > hbase-2.3.2RC4
> >
> > The VOTE will remain open for at least 72 hours.
> >
> > [ ] +1 Release this package as Apache hbase 2.3.2
> > [ ] -1 Do not release this package because ...
> >
> > The tag to be voted on is 2.3.2RC4:
> >
> >   https://github.com/apache/hbase/tree/2.3.2RC4
> >
> > The release files, including signatures, digests, as well as CHANGES.md
> > and RELEASENOTES.md included in this RC can be found at:
> >
> >   http://home.apache.org/~vjasani/2.3.2RC4/
> >
> > Maven artifacts are available in a staging repository at:
> >
> >
> https://repository.apache.org/content/repositories/orgapachehbase-1409/
> >
> > Artifacts were signed with the 1C8ADFD5 key which can be found in:
> >
> >   https://dist.apache.org/repos/dist/release/hbase/KEYS
> >
> > To learn more about Apache hbase, please see
> >
> >   http://hbase.apache.org/
> >
> > Thanks,
> > Your HBase Release Manager
> >
>


Re: [VOTE] Third HBase 2.3.2 release candidate (RC4) is available

2020-09-21 Thread Nick Dimiduk
On Sun, Sep 20, 2020 at 10:51 AM Viraj Jasani  wrote:

>
> The release files, including signatures, digests, as well as CHANGES.md
> and RELEASENOTES.md included in this RC can be found at:
>
>   http://home.apache.org/~vjasani/2.3.2RC4/


I'm syncing this version over to dist. Should be up in a few minutes.


[jira] [Resolved] (HBASE-25076) fix typo in MasterRegion java doc

2020-09-21 Thread Jan Hentschel (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel resolved HBASE-25076.
---
Fix Version/s: 3.0.0-alpha-1
 Hadoop Flags: Reviewed
   Resolution: Fixed

Pushed to master. Thanks [~niuyulin] for the contribution and [~zhangduo] for 
the review.

> fix typo in MasterRegion java doc
> -
>
> Key: HBASE-25076
> URL: https://issues.apache.org/jira/browse/HBASE-25076
> Project: HBase
>  Issue Type: Improvement
>Reporter: niuyulin
>Assignee: niuyulin
>Priority: Major
> Fix For: 3.0.0-alpha-1
>
>
> The archived HFile will be moved to the global HFile archived directory with 
> the \{@link MasterRegionParams#archivedWalSuffix()} suffix. The archived WAL 
> will be moved to the global WAL archived directory with the \{@link 
> MasterRegionParams#archivedHFileSuffix()} suffix



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: [VOTE] Third HBase 2.3.2 release candidate (RC4) is available

2020-09-21 Thread Tak-Lon (Stephen) Wu
+1 (non-binding)

ran the hbase-vote.sh (a small problem with the `pushd
"${HBASE_RC_VERSION}"`, I will try to another two vote and may file a JIRA
to fix it)

* Signature: ok
* Checksum : ok
* Rat check (1.8.0_212): ok
 - mvn clean apache-rat:check
* Built from source (1.8.0_212): ok
 - mvn clean install -DskipTests
* Unit tests pass (1.8.0_212): ok
 - mvn package -P runAllTests
* API compatibility report looks good

In addition, just a learning point about the base of URL is not
https://dist.apache.org/repos/dist/dev/hbase/, is it normal after RC1 ?

-Stephen

On Sun, Sep 20, 2020 at 10:51 AM Viraj Jasani  wrote:

> Please vote on this Apache hbase release candidate,
> hbase-2.3.2RC4
>
> The VOTE will remain open for at least 72 hours.
>
> [ ] +1 Release this package as Apache hbase 2.3.2
> [ ] -1 Do not release this package because ...
>
> The tag to be voted on is 2.3.2RC4:
>
>   https://github.com/apache/hbase/tree/2.3.2RC4
>
> The release files, including signatures, digests, as well as CHANGES.md
> and RELEASENOTES.md included in this RC can be found at:
>
>   http://home.apache.org/~vjasani/2.3.2RC4/
>
> Maven artifacts are available in a staging repository at:
>
>   https://repository.apache.org/content/repositories/orgapachehbase-1409/
>
> Artifacts were signed with the 1C8ADFD5 key which can be found in:
>
>   https://dist.apache.org/repos/dist/release/hbase/KEYS
>
> To learn more about Apache hbase, please see
>
>   http://hbase.apache.org/
>
> Thanks,
> Your HBase Release Manager
>


[jira] [Resolved] (HBASE-25075) Fix typo in ReplicationProtobufUtil

2020-09-21 Thread Jan Hentschel (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel resolved HBASE-25075.
---
Fix Version/s: 3.0.0-alpha-1
 Hadoop Flags: Reviewed
   Resolution: Fixed

Pushed to master. [~niuyulin] Thanks for the contributions and [~zghao] & 
[~zhangduo] for the reviews.

[~niuyulin] Mind adding a backport for branch-2? Your master patch does not 
apply cleanly to branch-2.

> Fix typo in ReplicationProtobufUtil
> ---
>
> Key: HBASE-25075
> URL: https://issues.apache.org/jira/browse/HBASE-25075
> Project: HBase
>  Issue Type: Improvement
>  Components: Replication
>Reporter: Duo Zhang
>Assignee: niuyulin
>Priority: Major
>  Labels: beginner, trivial
> Fix For: 3.0.0-alpha-1
>
>
> It is named as 'ReplicationProtbufUtil', missed an 'o'.
> It is IA.Private so it is safe to rename it directly.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25077) [HBCK2]hbck.jsp page loading fails, logs NPE in master log.

2020-09-21 Thread Ajeet Rai (Jira)
Ajeet Rai created HBASE-25077:
-

 Summary: [HBCK2]hbck.jsp page loading fails, logs NPE in master 
log.
 Key: HBASE-25077
 URL: https://issues.apache.org/jira/browse/HBASE-25077
 Project: HBase
  Issue Type: Bug
Affects Versions: 2.2.3
Reporter: Ajeet Rai


While testing with large data, it is observed that some time hbck page was not 
accessible and NPE was thrown in log.

 

【Test step】Excat Steps are not known. Observed this while executing below steps

1: Test data: 9K regions,~300 in my test setup

2: run list inconsistency with run option

3: run hbck_chore and catalogjanitor_run multiple times 

4: Also run balancer so that region movement is happening.

5: Observe that HBCK page not available

 

2020-09-21 20:05:31,706 WARN [qtp1698322791-94] server.HttpChannel: /hbck.jsp
java.lang.NullPointerException
 at 
org.apache.hadoop.hbase.generated.master.hbck_jsp.formatServerName(hbck_jsp.java:37)
 at 
org.apache.hadoop.hbase.generated.master.hbck_jsp._jspService(hbck_jsp.java:144)
 at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:111)
 at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
 at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:844)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-25013) Avoid reset the backup master root cache every time when syncing

2020-09-21 Thread Duo Zhang (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang resolved HBASE-25013.
---
Fix Version/s: HBASE-24950
 Hadoop Flags: Reviewed
   Resolution: Fixed

Merged to branch HBASE-24950.

Thanks [~zghao] for reviewing.

> Avoid reset the backup master root cache every time when syncing
> 
>
> Key: HBASE-25013
> URL: https://issues.apache.org/jira/browse/HBASE-25013
> Project: HBase
>  Issue Type: Sub-task
>  Components: master
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: HBASE-24950
>
>
> Improve the pull logic to not always reset the cache.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25076) fix typo in MasterRegion java doc

2020-09-21 Thread niuyulin (Jira)
niuyulin created HBASE-25076:


 Summary: fix typo in MasterRegion java doc
 Key: HBASE-25076
 URL: https://issues.apache.org/jira/browse/HBASE-25076
 Project: HBase
  Issue Type: Improvement
Reporter: niuyulin
Assignee: niuyulin






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25075) Fix typo in ReplicationProtobufUtil

2020-09-21 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25075:
-

 Summary: Fix typo in ReplicationProtobufUtil
 Key: HBASE-25075
 URL: https://issues.apache.org/jira/browse/HBASE-25075
 Project: HBase
  Issue Type: Improvement
Reporter: Duo Zhang


It is named as 'ReplicationProtbufUtil', missed an 'o'.

It is IA.Private so it is safe to rename it directly.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25074) Refactor ReplicationSinkManager: reduce code and make it easy to understand

2020-09-21 Thread Guanghao Zhang (Jira)
Guanghao Zhang created HBASE-25074:
--

 Summary: Refactor ReplicationSinkManager: reduce code and make it 
easy to understand
 Key: HBASE-25074
 URL: https://issues.apache.org/jira/browse/HBASE-25074
 Project: HBase
  Issue Type: Improvement
Reporter: Guanghao Zhang






--
This message was sent by Atlassian Jira
(v8.3.4#803005)