Re: [DISCUSS] About the SemVar change for protobuf

[Duo Zhang]

I've opened a PR to upgrade protobuf in hbase-thirdparty.

https://github.com/apache/hbase-thirdparty/pull/117

PTAL.

Thanks.

Andrew Purtell  于2024年4月5日周五 23:36写道：
>
> That makes sense.
>
> Their support for protobuf-java 3.x ends in one year from now, and that is 
> only for 3.25.x.
>
>
> > On Apr 5, 2024, at 5:47 AM, 张铎  wrote:
> >
> > When bumping dependency versions for hbase-thirdparty, I found that
> > the next version for 3.25.x is 4.26.x...
> >
> > After investigating, I found this
> >
> > https://protobuf.dev/support/version-support/
> >
> > There are some breaking changes to java
> >
> > https://github.com/protocolbuffers/protobuf/releases/tag/v26.0
> >
> > For me, since the shaded protobuf is internal, I think we are free to
> > bump it to the latest 4.26.x.
> >
> > And for branch-3+, we also let CPs depend on the shaded protobuf, so
> > it is better to bump to the newest version before the final release
> > for 3.0.0.
> >
> > Thoughts?
> >
> > Thanks.

Re: [DISCUSS] About the SemVar change for protobuf

[Andrew Purtell]

That makes sense.

Their support for protobuf-java 3.x ends in one year from now, and that is only 
for 3.25.x. 


> On Apr 5, 2024, at 5:47 AM, 张铎  wrote:
> 
> When bumping dependency versions for hbase-thirdparty, I found that
> the next version for 3.25.x is 4.26.x...
> 
> After investigating, I found this
> 
> https://protobuf.dev/support/version-support/
> 
> There are some breaking changes to java
> 
> https://github.com/protocolbuffers/protobuf/releases/tag/v26.0
> 
> For me, since the shaded protobuf is internal, I think we are free to
> bump it to the latest 4.26.x.
> 
> And for branch-3+, we also let CPs depend on the shaded protobuf, so
> it is better to bump to the newest version before the final release
> for 3.0.0.
> 
> Thoughts?
> 
> Thanks.

[DISCUSS] About the SemVar change for protobuf

[Duo Zhang]

When bumping dependency versions for hbase-thirdparty, I found that
the next version for 3.25.x is 4.26.x...

After investigating, I found this

https://protobuf.dev/support/version-support/

There are some breaking changes to java

https://github.com/protocolbuffers/protobuf/releases/tag/v26.0

For me, since the shaded protobuf is internal, I think we are free to
bump it to the latest 4.26.x.

And for branch-3+, we also let CPs depend on the shaded protobuf, so
it is better to bump to the newest version before the final release
for 3.0.0.

Thoughts?

Thanks.