Re: Nightly job for branch-2.2 is failing
The dockerfile on branch-2.3+ were rewritten in order to support multiple JDKs. These changes should be compatible with branch-2.2, other than they no longer set JAVA_HOME in the Dockerfiles itself. Backport with a little tweaking to the Dockerfiles or the build script should be fine. I'm not certain the dockerfiles on branch-2.3+ are immune to these kinds of breaks either, btw... On Tue, May 5, 2020 at 7:36 AM 张铎(Duo Zhang) wrote: > For branch-2.3+ we pinned all the dependencies with a specific version, > maybe we should backport the dockerfile to branch-2.2? > > Jan Hentschel 于2020年5月5日周二 下午9:58写道: > > > I thought we are already pinned the Rubocop version, but not sure about > > branch-2.2. > > > > From: Duo Zhang > > Reply-To: "dev@hbase.apache.org" > > Date: Tuesday, May 5, 2020 at 2:38 PM > > To: HBase Dev List > > Subject: Nightly job for branch-2.2 is failing > > > > Because of failing to build the dockerfile. > > > > The error message is > > > > *18:52:25* [91mERROR: Error installing rubocop:*18:52:25*rubocop > > requires Ruby version >= 2.4.0. > > > > > > IIRC we have discussed this before that we should keep the rubocop at a > > specific version to prevent it being upgraded accidentally? > > > > >
Re: Nightly job for branch-2.2 is failing
For branch-2.3+ we pinned all the dependencies with a specific version, maybe we should backport the dockerfile to branch-2.2? Jan Hentschel 于2020年5月5日周二 下午9:58写道: > I thought we are already pinned the Rubocop version, but not sure about > branch-2.2. > > From: Duo Zhang > Reply-To: "dev@hbase.apache.org" > Date: Tuesday, May 5, 2020 at 2:38 PM > To: HBase Dev List > Subject: Nightly job for branch-2.2 is failing > > Because of failing to build the dockerfile. > > The error message is > > *18:52:25* [91mERROR: Error installing rubocop:*18:52:25*rubocop > requires Ruby version >= 2.4.0. > > > IIRC we have discussed this before that we should keep the rubocop at a > specific version to prevent it being upgraded accidentally? > >
Re: Nightly job for branch-2.2 is failing
I thought we are already pinned the Rubocop version, but not sure about branch-2.2. From: Duo Zhang Reply-To: "dev@hbase.apache.org" Date: Tuesday, May 5, 2020 at 2:38 PM To: HBase Dev List Subject: Nightly job for branch-2.2 is failing Because of failing to build the dockerfile. The error message is *18:52:25* [91mERROR: Error installing rubocop:*18:52:25*rubocop requires Ruby version >= 2.4.0. IIRC we have discussed this before that we should keep the rubocop at a specific version to prevent it being upgraded accidentally?
Nightly job for branch-2.2 is failing
Because of failing to build the dockerfile. The error message is *18:52:25* [91mERROR: Error installing rubocop:*18:52:25*rubocop requires Ruby version >= 2.4.0. IIRC we have discussed this before that we should keep the rubocop at a specific version to prevent it being upgraded accidentally?