[GitHub] [httpcomponents-client] h0nIg commented on issue #210: re-add validateAfterInactivity to pool manager
h0nIg commented on issue #210: re-add validateAfterInactivity to pool manager URL: https://github.com/apache/httpcomponents-client/pull/210#issuecomment-585598359 @ok2c to restore the original 4.x behaviour as outlined in my comment. Please take a look at the links how it looked before This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
Re: [VOTE] Release HttpCore 5.0 based on RC1
+1 My review is based on the git tag. Apache RAT check OK. Builds OK with 'mvn -V clean package -P!use-toolchains' on: Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: C:\Java\apache-maven-3.6.3\bin\.. Java version: 1.8.0_241, vendor: Oracle Corporation, runtime: C:\Program Files\Java\jdk1.8.0_241\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" and: java version "1.8.0_241" Java(TM) SE Runtime Environment (build 1.8.0_241-b07) Java HotSpot(TM) 64-Bit Server VM (build 25.241-b07, mixed mode) java version "11.0.6" 2020-01-14 LTS Java(TM) SE Runtime Environment 18.9 (build 11.0.6+8-LTS) Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11.0.6+8-LTS, mixed mode) Gary On Wed, Feb 12, 2020 at 5:50 AM Oleg Kalnichevski wrote: > Please vote on releasing these packages as HttpCore 5.0. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes if at least > three binding +1 votes are cast and there are more +1 than -1 votes. > > Release notes: > > https://dist.apache.org/repos/dist/dev/httpcomponents/httpcore-5.0-RC1/RELEASE_NOTES-5.0.x.txt > > Maven artefacts: > > https://repository.apache.org/content/repositories/orgapachehttpcomponents-/org/apache/httpcomponents/core5/ > > Git Tag: 5.0-RC1 > https://github.com/apache/httpcomponents-core/tree/5.0-RC1 > > Packages: > https://dist.apache.org/repos/dist/dev/httpcomponents/httpcore-5.0-RC1 > revision 38008 > > Hashes: > > de8b13b23423c7a1bd4c788869666c658165e8bb3cd3a147fc2b34aafd3f4b4cbbf755628a741007d2dbb498209a662edc7f03f28b6f6dc7c7fffd7ec780 > httpcomponents-core-5.0-bin.tar.gz > > fcffb5e149154b547f9346b8d9bfeab92ffc87758d966defb0209559fa0de1b926f126015bd5bda172cc030cf0480d1bd86d0b29f92ab71e9dc7a4d2fbf7a4b4 > httpcomponents-core-5.0-src.zip > > c141dcd93432a95e4b913889ff8a258929ded918acc9ab8835f32c7cbd67bd0f271efab56103fa41183c66b25055be219a55f3982ae46f11d91de666023f1bdc > httpcomponents-core-5.0-src.tar.gz > > 38dc582d9b5b69c787535c6e91405160a3ae3603be1b25efd273554081de0e8c7d49e97cf24bb853611edc85f5d3b60f367b7ba6d764af3271af8607f8cc5d7f > httpcomponents-core-5.0-bin.zip > > Keys: > http://www.apache.org/dist/httpcomponents/httpcore/KEYS > > -- > Vote: HttpCore 5.0 release > [ ] +1 Release the packages as HttpCore 5.0. > [ ] -1 I am against releasing the packages (must include a reason). > > > - > To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org > For additional commands, e-mail: dev-h...@hc.apache.org > >
Re: [VOTE] Release HttpCore 5.0 based on RC1
+1 On Wed, Feb 12, 2020 at 2:50 AM Oleg Kalnichevski wrote: > Please vote on releasing these packages as HttpCore 5.0. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes if at least > three binding +1 votes are cast and there are more +1 than -1 votes. > > Release notes: > > https://dist.apache.org/repos/dist/dev/httpcomponents/httpcore-5.0-RC1/RELEASE_NOTES-5.0.x.txt > > Maven artefacts: > > https://repository.apache.org/content/repositories/orgapachehttpcomponents-/org/apache/httpcomponents/core5/ > > Git Tag: 5.0-RC1 > https://github.com/apache/httpcomponents-core/tree/5.0-RC1 > > Packages: > https://dist.apache.org/repos/dist/dev/httpcomponents/httpcore-5.0-RC1 > revision 38008 > > Hashes: > > de8b13b23423c7a1bd4c788869666c658165e8bb3cd3a147fc2b34aafd3f4b4cbbf755628a741007d2dbb498209a662edc7f03f28b6f6dc7c7fffd7ec780 > httpcomponents-core-5.0-bin.tar.gz > > fcffb5e149154b547f9346b8d9bfeab92ffc87758d966defb0209559fa0de1b926f126015bd5bda172cc030cf0480d1bd86d0b29f92ab71e9dc7a4d2fbf7a4b4 > httpcomponents-core-5.0-src.zip > > c141dcd93432a95e4b913889ff8a258929ded918acc9ab8835f32c7cbd67bd0f271efab56103fa41183c66b25055be219a55f3982ae46f11d91de666023f1bdc > httpcomponents-core-5.0-src.tar.gz > > 38dc582d9b5b69c787535c6e91405160a3ae3603be1b25efd273554081de0e8c7d49e97cf24bb853611edc85f5d3b60f367b7ba6d764af3271af8607f8cc5d7f > httpcomponents-core-5.0-bin.zip > > Keys: > http://www.apache.org/dist/httpcomponents/httpcore/KEYS > > -- > Vote: HttpCore 5.0 release > [ ] +1 Release the packages as HttpCore 5.0. > [ ] -1 I am against releasing the packages (must include a reason). > > > - > To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org > For additional commands, e-mail: dev-h...@hc.apache.org > >
Re: [httpcore5] should allow the ephemeral port?
On Wed, Feb 12, 2020 at 10:31 AM Gary Gregory
wrote:
> Hm, that won't work, now that I've debugged some.
>
> I can see that I need to/should create and set my own FixedPortStrategy(0)
> but that does not work since the port is set after the server is started,
> so I'll need a custom "EphemeralPortStrategy" or "AllPortStrategy" that
> accepts any port, but that's lame. How can I say "I am a SecurePortStrategy
> that only accepts the port this server was resolved from the ephemeral
> port"?
>
My current ugly workaround for which I'd hope for a cleaner
within-HC-solution to support ephemeral ports is:
asyncServerBootstrap
.setTlsStrategy(new BasicServerTlsStrategy(sslContext,
port == 0 ? AllSecurePortStrategy.INSTANCE : new FixedPortStrategy(new
int[] { port })));
and:
// HACK IMO
private static final class AllSecurePortStrategy implements
SecurePortStrategy {
static final AllSecurePortStrategy INSTANCE = new
AllSecurePortStrategy();
@Override
public boolean isSecure(SocketAddress localAddress) {
return true;
}
}
Gary
>
> Gary
>
> On Wed, Feb 12, 2020 at 10:09 AM Gary Gregory
> wrote:
>
>> Hi All:
>>
>> I am trying to fix tests at work that use the ephemeral port, but:
>>
>> org.apache.hc.core5.http2.impl.nio.bootstrap.H2ServerBootstrap.create()
>>
>> uses by default:
>>
>> new H2ServerTlsStrategy(443, 8443),
>>
>> What do you think about making this:
>>
>> new H2ServerTlsStrategy(0, 443, 8443),
>>
>> ?
>>
>> Gary
>>
>>
Re: [httpcore5] should allow the ephemeral port?
Hm, that won't work, now that I've debugged some. I can see that I need to/should create and set my own FixedPortStrategy(0) but that does not work since the port is set after the server is started, so I'll need a custom "EphemeralPortStrategy" or "AllPortStrategy" that accepts any port, but that's lame. How can I say "I am a SecurePortStrategy that only accepts the port this server was resolved from the ephemeral port"? Gary On Wed, Feb 12, 2020 at 10:09 AM Gary Gregory wrote: > Hi All: > > I am trying to fix tests at work that use the ephemeral port, but: > > org.apache.hc.core5.http2.impl.nio.bootstrap.H2ServerBootstrap.create() > > uses by default: > > new H2ServerTlsStrategy(443, 8443), > > What do you think about making this: > > new H2ServerTlsStrategy(0, 443, 8443), > > ? > > Gary > >
[httpcore5] should allow the ephemeral port?
Hi All: I am trying to fix tests at work that use the ephemeral port, but: org.apache.hc.core5.http2.impl.nio.bootstrap.H2ServerBootstrap.create() uses by default: new H2ServerTlsStrategy(443, 8443), What do you think about making this: new H2ServerTlsStrategy(0, 443, 8443), ? Gary
[GitHub] [httpcomponents-client] ok2c commented on issue #210: re-add validateAfterInactivity to pool manager
ok2c commented on issue #210: re-add validateAfterInactivity to pool manager URL: https://github.com/apache/httpcomponents-client/pull/210#issuecomment-585219463 @h0nIg Why? What is exactly the benefit of calling that method in the constructor? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] [httpcomponents-client] h0nIg opened a new pull request #210: re-add validateAfterInactivity to pool manager
h0nIg opened a new pull request #210: re-add validateAfterInactivity to pool manager URL: https://github.com/apache/httpcomponents-client/pull/210 It is really ugly that this setting was removed. This default value is responsible for checking bad connections and people will not notice this change if they upgrade, because it will not happen very frequently: https://github.com/apache/httpcomponents-client/blob/rel/v4.5.9/httpclient/src/main/java/org/apache/http/impl/conn/PoolingHttpClientConnectionManager.java#L182 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[VOTE] Release HttpCore 5.0 based on RC1
Please vote on releasing these packages as HttpCore 5.0. The vote is open for the at least 72 hours, and only votes from HttpComponents PMC members are binding. The vote passes if at least three binding +1 votes are cast and there are more +1 than -1 votes. Release notes: https://dist.apache.org/repos/dist/dev/httpcomponents/httpcore-5.0-RC1/RELEASE_NOTES-5.0.x.txt Maven artefacts: https://repository.apache.org/content/repositories/orgapachehttpcomponents-/org/apache/httpcomponents/core5/ Git Tag: 5.0-RC1 https://github.com/apache/httpcomponents-core/tree/5.0-RC1 Packages: https://dist.apache.org/repos/dist/dev/httpcomponents/httpcore-5.0-RC1 revision 38008 Hashes: de8b13b23423c7a1bd4c788869666c658165e8bb3cd3a147fc2b34aafd3f4b4cbbf755628a741007d2dbb498209a662edc7f03f28b6f6dc7c7fffd7ec780 httpcomponents-core-5.0-bin.tar.gz fcffb5e149154b547f9346b8d9bfeab92ffc87758d966defb0209559fa0de1b926f126015bd5bda172cc030cf0480d1bd86d0b29f92ab71e9dc7a4d2fbf7a4b4 httpcomponents-core-5.0-src.zip c141dcd93432a95e4b913889ff8a258929ded918acc9ab8835f32c7cbd67bd0f271efab56103fa41183c66b25055be219a55f3982ae46f11d91de666023f1bdc httpcomponents-core-5.0-src.tar.gz 38dc582d9b5b69c787535c6e91405160a3ae3603be1b25efd273554081de0e8c7d49e97cf24bb853611edc85f5d3b60f367b7ba6d764af3271af8607f8cc5d7f httpcomponents-core-5.0-bin.zip Keys: http://www.apache.org/dist/httpcomponents/httpcore/KEYS -- Vote: HttpCore 5.0 release [ ] +1 Release the packages as HttpCore 5.0. [ ] -1 I am against releasing the packages (must include a reason). - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
