[jira] [Commented] (HTTPCLIENT-2080) HttpRequestRetryStrategy doesn't delay the retry if IOException occurs

2020-05-11 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104703#comment-17104703
 ] 

Michael Osipov commented on HTTPCLIENT-2080:


[~olegk], it could be also a network issue on the client side. Nothing fancy.

 

[~hw873], do yo want to work out a PR for this? I think we could add this via 
{{ExtendedRedirectStrategy}} with a new method where the interface is instantly 
marked for removal in the next major version or even maybe with a Java 8 
interface default method.

> HttpRequestRetryStrategy doesn't delay the retry if IOException occurs
> --
>
> Key: HTTPCLIENT-2080
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2080
> Project: HttpComponents HttpClient
>  Issue Type: Improvement
>  Components: HttpClient (classic)
>Affects Versions: 5.0
>Reporter: Hendra
>Priority: Major
>
> In httpclient5, HttpRequestRetryStrategy has introduced a new feature 
> retryInterval which determines the interval between subsequent retries. In 
> case there are IOExceptions occur, the retry happens but without any delays.
>  
> There might be some bugs in HttpRequestRetryExec.class implementation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



[jira] [Commented] (HTTPCLIENT-2080) HttpRequestRetryStrategy doesn't delay the retry if IOException occurs

2020-05-11 Thread Oleg Kalnichevski (Jira)


[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104306#comment-17104306
 ] 

Oleg Kalnichevski commented on HTTPCLIENT-2080:
---

[~hw873] What makes you think that just pausing for extra seconds would somehow 
make the problem go away? The main reason for retrying i/o errors is to 
redirect the request to another live node in a cluster , in which case pausing 
the request re-execution makes no sense. If the server is unable to process the 
request due to excessive load it should respond with 503, not just drop the 
connection. 

[~michael-o] It is up to you to decide if you want to add support for a delay 
interval in case of I/O errors. I would just close this ticket as 
`not-an-issue`.

Oleg

> HttpRequestRetryStrategy doesn't delay the retry if IOException occurs
> --
>
> Key: HTTPCLIENT-2080
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2080
> Project: HttpComponents HttpClient
>  Issue Type: Improvement
>  Components: HttpClient (classic)
>Affects Versions: 5.0
>Reporter: Hendra
>Priority: Major
>
> In httpclient5, HttpRequestRetryStrategy has introduced a new feature 
> retryInterval which determines the interval between subsequent retries. In 
> case there are IOExceptions occur, the retry happens but without any delays.
>  
> There might be some bugs in HttpRequestRetryExec.class implementation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



[jira] [Commented] (HTTPCLIENT-2080) HttpRequestRetryStrategy doesn't delay the retry if IOException occurs

2020-05-11 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104305#comment-17104305
 ] 

Michael Osipov commented on HTTPCLIENT-2080:


We we could do is to introduce an extended interface to {{RedirectStrategy}} 
which handles this case. The default {{RedirectExec}} will be aware of, custom 
ones at ther discretion.

> HttpRequestRetryStrategy doesn't delay the retry if IOException occurs
> --
>
> Key: HTTPCLIENT-2080
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2080
> Project: HttpComponents HttpClient
>  Issue Type: Improvement
>  Components: HttpClient (classic)
>Affects Versions: 5.0
>Reporter: Hendra
>Priority: Major
>
> In httpclient5, HttpRequestRetryStrategy has introduced a new feature 
> retryInterval which determines the interval between subsequent retries. In 
> case there are IOExceptions occur, the retry happens but without any delays.
>  
> There might be some bugs in HttpRequestRetryExec.class implementation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org