[GitHub] [httpcomponents-client] ok2c commented on issue #210: re-add validateAfterInactivity to pool manager
ok2c commented on issue #210: re-add validateAfterInactivity to pool manager URL: https://github.com/apache/httpcomponents-client/pull/210#issuecomment-586875937 > @ok2c ok after looking at the code it is still not clear for me why you said it is inefficient. @h0nIg Because in reality socket timeout granularity of many JREs is about 10 ms or more. Therefore the stale connection check adds ~10 ms to each request execution time when activated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on issue #210: re-add validateAfterInactivity to pool manager
ok2c commented on issue #210: re-add validateAfterInactivity to pool manager URL: https://github.com/apache/httpcomponents-client/pull/210#issuecomment-585759167 @h0nIg The stale check is ineffective because the connection can go stale immediately after having passed the check. It can catch some stale connections but not all. It is also inefficient by being expensive in therms of execution overhead. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on issue #210: re-add validateAfterInactivity to pool manager
ok2c commented on issue #210: re-add validateAfterInactivity to pool manager URL: https://github.com/apache/httpcomponents-client/pull/210#issuecomment-585732292 @h0nIg The stale connection check is both ineffective and inefficient. A major release is the point when its application can be changed from having to opt-out to having to opt-in. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on issue #210: re-add validateAfterInactivity to pool manager
ok2c commented on issue #210: re-add validateAfterInactivity to pool manager URL: https://github.com/apache/httpcomponents-client/pull/210#issuecomment-585611409 @h0nIg The check _will_ get triggered if configured correctly. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on issue #210: re-add validateAfterInactivity to pool manager
ok2c commented on issue #210: re-add validateAfterInactivity to pool manager URL: https://github.com/apache/httpcomponents-client/pull/210#issuecomment-585601313 > @ok2c to restore the original 4.x behaviour as outlined in my comment. Please take a look at the links how it looked before @h0nIg And why would we do that exactly? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on issue #210: re-add validateAfterInactivity to pool manager
ok2c commented on issue #210: re-add validateAfterInactivity to pool manager URL: https://github.com/apache/httpcomponents-client/pull/210#issuecomment-585219463 @h0nIg Why? What is exactly the benefit of calling that method in the constructor? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
