[jira] [Commented] (HTTPCLIENT-2070) BasicAuthCache not to use object serialization
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17812631#comment-17812631 ] Alex Dettinger commented on HTTPCLIENT-2070: >From target version, probably it will be released in version 5.4. Many thanks for contribution Oleg, be sure it will have simplification impact on other projects, at least in Camel Quarkus we appreciate it :) > BasicAuthCache not to use object serialization > -- > > Key: HTTPCLIENT-2070 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2070 > Project: HttpComponents HttpClient > Issue Type: Improvement >Reporter: Alex Dettinger >Priority: Major > Labels: volunteers-wanted > Fix For: 5.4-alpha2 > > Time Spent: 50m > Remaining Estimate: 0h > > Today, BasicAuthCache is using object serialization in [put/get > methods|https://github.com/apache/httpcomponents-client/blob/master/httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/BasicAuthCache.java#L91..L93]. > However, object serialization is not supported with [quarkus native > mode|https://quarkus.io/guides/building-native-image] and folk ends up > removing this part. > Folks ends up removing serialization by [native code > override|https://github.com/quarkusio/quarkus/blob/master/extensions/elasticsearch-rest-client/runtime/src/main/java/io/quarkus/elasticsearch/restclient/runtime/graal/Substitute_RestClient.java#L93..L114]. > Would it be possible to have httpclient finding an implementation of put/get > not using object serialization ? > What is the consequence of removing the serialization/deserialization ? > Thread safety issue ? persistence issue ? -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-2070) BasicAuthCache not to use object serialization
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17812594#comment-17812594 ] ASF subversion and git services commented on HTTPCLIENT-2070: - Commit 23da984fb5e4f3ecce933c9d3dc8b5e87d06f91a in httpcomponents-client's branch refs/heads/master from Oleg Kalnichevski [ https://gitbox.apache.org/repos/asf?p=httpcomponents-client.git;h=23da984fb ] HTTPCLIENT-2070: Auth cache to no longer rely on Java serialization for auth state caching > BasicAuthCache not to use object serialization > -- > > Key: HTTPCLIENT-2070 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2070 > Project: HttpComponents HttpClient > Issue Type: Improvement >Reporter: Alex Dettinger >Priority: Major > Labels: volunteers-wanted > Fix For: 5.4-alpha2 > > Time Spent: 50m > Remaining Estimate: 0h > > Today, BasicAuthCache is using object serialization in [put/get > methods|https://github.com/apache/httpcomponents-client/blob/master/httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/BasicAuthCache.java#L91..L93]. > However, object serialization is not supported with [quarkus native > mode|https://quarkus.io/guides/building-native-image] and folk ends up > removing this part. > Folks ends up removing serialization by [native code > override|https://github.com/quarkusio/quarkus/blob/master/extensions/elasticsearch-rest-client/runtime/src/main/java/io/quarkus/elasticsearch/restclient/runtime/graal/Substitute_RestClient.java#L93..L114]. > Would it be possible to have httpclient finding an implementation of put/get > not using object serialization ? > What is the consequence of removing the serialization/deserialization ? > Thread safety issue ? persistence issue ? -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-2070) BasicAuthCache not to use object serialization
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17073837#comment-17073837 ] Oleg Kalnichevski commented on HTTPCLIENT-2070: --- > Would it be possible to have httpclient finding an implementation of put/get >not using object serialization ? Java object serialization was chosen for no reason other than its simplicity. There is nothing stopping us from removing in favor of something else (as long as it does not come at the expense of having a mandatory external dependency. Oleg > BasicAuthCache not to use object serialization > -- > > Key: HTTPCLIENT-2070 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2070 > Project: HttpComponents HttpClient > Issue Type: Improvement >Reporter: Alex Dettinger >Priority: Major > > Today, BasicAuthCache is using object serialization in [put/get > methods|https://github.com/apache/httpcomponents-client/blob/master/httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/BasicAuthCache.java#L91..L93]. > However, object serialization is not supported with [quarkus native > mode|https://quarkus.io/guides/building-native-image] and folk ends up > removing this part. > Folks ends up removing serialization by [native code > override|https://github.com/quarkusio/quarkus/blob/master/extensions/elasticsearch-rest-client/runtime/src/main/java/io/quarkus/elasticsearch/restclient/runtime/graal/Substitute_RestClient.java#L93..L114]. > Would it be possible to have httpclient finding an implementation of put/get > not using object serialization ? > What is the consequence of removing the serialization/deserialization ? > Thread safety issue ? persistence issue ? -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
