[jira] [Created] (HELIX-492) Task should be its own rebalance mode
Kanak Biscuitwala created HELIX-492: --- Summary: Task should be its own rebalance mode Key: HELIX-492 URL: https://issues.apache.org/jira/browse/HELIX-492 Project: Apache Helix Issue Type: Sub-task Reporter: Kanak Biscuitwala Assignee: Kanak Biscuitwala Right now the task framework creates a rebalancer with mode USER_DEFINED, where since it's built in, it's not really user-defined, but rather task-specific. There should be a new mode called TASK or similar. -- This message was sent by Atlassian JIRA (v6.2#6252)
Review Request 24190: [HELIX-376] Remove HelixConnection/HelixManager duplicate code
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24190/ --- Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna. Bugs: HELIX-376 Repository: helix-git Description --- Remove HelixConnection/HelixManager duplicate code Diffs - helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestHelixAdminScenariosRest.java 66065c3 helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestResetInstance.java b89a067 helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestResetPartitionState.java 8cd6f42 helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestResetResource.java 464edc4 helix-agent/src/test/java/org/apache/helix/agent/TestHelixAgent.java cbf0582 helix-core/src/main/java/org/apache/helix/HelixAdministrator.java PRE-CREATION helix-core/src/main/java/org/apache/helix/HelixConnection.java ff5f458 helix-core/src/main/java/org/apache/helix/HelixRole.java ffcb700 helix-core/src/main/java/org/apache/helix/HelixService.java 40e9bae helix-core/src/main/java/org/apache/helix/HelixSpectator.java PRE-CREATION helix-core/src/main/java/org/apache/helix/api/id/AdministratorId.java PRE-CREATION helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java 6f34953 helix-core/src/main/java/org/apache/helix/controller/stages/TaskAssignmentStage.java 9d6228e helix-core/src/main/java/org/apache/helix/manager/zk/HelixConnectionAdaptor.java ef17715 helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java f95f6ee helix-core/src/main/java/org/apache/helix/manager/zk/ZkCallbackHandler.java 5961fe3 helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixAdministrator.java PRE-CREATION helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixAutoController.java 1d4b225 helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixConnection.java bec6f5c helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixController.java f9529b7 helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixParticipant.java d3ee8d1 helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixSpectator.java PRE-CREATION helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java 0ac3b58 helix-core/src/test/java/org/apache/helix/TestHelper.java 8328a15 helix-core/src/test/java/org/apache/helix/ZkTestHelper.java 444c069 helix-core/src/test/java/org/apache/helix/api/TestNewStages.java b5d218d helix-core/src/test/java/org/apache/helix/controller/stages/TestRebalancePipeline.java 922dde6 helix-core/src/test/java/org/apache/helix/integration/IntegrationTest.java bb862f3 helix-core/src/test/java/org/apache/helix/integration/TestAddClusterV2.java 8dca7c8 helix-core/src/test/java/org/apache/helix/integration/TestAddNodeAfterControllerStart.java 01d760a helix-core/src/test/java/org/apache/helix/integration/TestAddStateModelFactoryAfterConnect.java 98e4294 helix-core/src/test/java/org/apache/helix/integration/TestAutoIsWithEmptyMap.java 8ae722b helix-core/src/test/java/org/apache/helix/integration/TestAutoRebalance.java 9802e1c helix-core/src/test/java/org/apache/helix/integration/TestAutoRebalancePartitionLimit.java eef3826 helix-core/src/test/java/org/apache/helix/integration/TestBasicSpectator.java 54dd97c helix-core/src/test/java/org/apache/helix/integration/TestBatchMessage.java 099d47f helix-core/src/test/java/org/apache/helix/integration/TestBatchMessageWrapper.java a1f2b4d helix-core/src/test/java/org/apache/helix/integration/TestBucketizedResource.java 0c97b13 helix-core/src/test/java/org/apache/helix/integration/TestCarryOverBadCurState.java aa0bf33 helix-core/src/test/java/org/apache/helix/integration/TestCleanupExternalView.java 521864b helix-core/src/test/java/org/apache/helix/integration/TestClusterStartsup.java afe35f5 helix-core/src/test/java/org/apache/helix/integration/TestCorrectnessOnConnectivityLoss.java dba7014 helix-core/src/test/java/org/apache/helix/integration/TestDisable.java ce88a34 helix-core/src/test/java/org/apache/helix/integration/TestDisableCustomCodeRunner.java 08ffd54 helix-core/src/test/java/org/apache/helix/integration/TestDisableResource.java 1419084 helix-core/src/test/java/org/apache/helix/integration/TestDistributedCMMain.java 0d7d33c helix-core/src/test/java/org/apache/helix/integration/TestDistributedClusterController.java cf7884a helix-core/src/test/java/org/apache/helix/integration/TestDriver.java 9660f10 helix-core/src/test/java/org/apache/helix/integration/TestDrop.java ac20652 helix-core/src/test/java/org/apache/helix/integration/TestDropResource.java d4faf84
Review Request 24193: [HELIX-492] Task should have its own rebalance mode
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24193/ --- Review request for helix, Zhen Zhang and Kishore Gopalakrishna. Bugs: HELIX-492 Repository: helix-git Description --- commit 2bdc82cf6a258dad3b364c5edab32f10238409ce Author: Kanak Biscuitwala ka...@apache.org Date: Fri Aug 1 13:00:26 2014 -0700 [HELIX-492] Task should have its own rebalance mode :100644 100644 706fd41... 9a9767e... M helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java :100644 100644 aa2d617... 89fdab7... M helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java :100644 100644 a209cd9... 46a8f22... M helix-core/src/main/java/org/apache/helix/model/IdealState.java :100644 100644 e4871b5... ab504cd... M helix-core/src/main/java/org/apache/helix/task/TaskDriver.java Diffs - helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java 706fd41 helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java aa2d617 helix-core/src/main/java/org/apache/helix/model/IdealState.java a209cd9 helix-core/src/main/java/org/apache/helix/task/TaskDriver.java e4871b5 Diff: https://reviews.apache.org/r/24193/diff/ Testing --- Existing tests pass. Thanks, Kanak Biscuitwala
Re: Review Request 24190: [HELIX-376] Remove HelixConnection/HelixManager duplicate code
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24190/#review49377 --- helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestHelixAdminScenariosRest.java https://reviews.apache.org/r/24190/#comment86387 MockMultiClusterController is better helix-core/src/main/java/org/apache/helix/HelixAdministrator.java https://reviews.apache.org/r/24190/#comment86388 Should this have getters/creators for HelixAdmin and ClusterAccessor? Alternatively, maybe make a default HelixRole implementation for the administrator adaptor. helix-core/src/main/java/org/apache/helix/HelixSpectator.java https://reviews.apache.org/r/24190/#comment86389 This should either support adding listeners, or just use a default HelixRole implementation. helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java https://reviews.apache.org/r/24190/#comment86390 It's unsafe to call HelixConnection#connect in a constructor. helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java https://reviews.apache.org/r/24190/#comment86392 This may be a good opportunity to remove getConfigAccessor since we deprecated it in an older version. helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java https://reviews.apache.org/r/24190/#comment86393 Remove TODO helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java https://reviews.apache.org/r/24190/#comment86396 log instead of printing, make message more descriptive helix-core/src/test/java/org/apache/helix/integration/IntegrationTest.java https://reviews.apache.org/r/24190/#comment86397 This class needs a more descriptive name. recipes/jobrunner-yarn/src/main/java/org/apache/helix/provisioning/yarn/example/JobRunnerMain.java https://reviews.apache.org/r/24190/#comment86402 Remove TODO - Kanak Biscuitwala On Aug. 1, 2014, 12:03 p.m., Zhen Zhang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24190/ --- (Updated Aug. 1, 2014, 12:03 p.m.) Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna. Bugs: HELIX-376 Repository: helix-git Description --- Remove HelixConnection/HelixManager duplicate code Diffs - helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestHelixAdminScenariosRest.java 66065c3 helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestResetInstance.java b89a067 helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestResetPartitionState.java 8cd6f42 helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestResetResource.java 464edc4 helix-agent/src/test/java/org/apache/helix/agent/TestHelixAgent.java cbf0582 helix-core/src/main/java/org/apache/helix/HelixAdministrator.java PRE-CREATION helix-core/src/main/java/org/apache/helix/HelixConnection.java ff5f458 helix-core/src/main/java/org/apache/helix/HelixRole.java ffcb700 helix-core/src/main/java/org/apache/helix/HelixService.java 40e9bae helix-core/src/main/java/org/apache/helix/HelixSpectator.java PRE-CREATION helix-core/src/main/java/org/apache/helix/api/id/AdministratorId.java PRE-CREATION helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java 6f34953 helix-core/src/main/java/org/apache/helix/controller/stages/TaskAssignmentStage.java 9d6228e helix-core/src/main/java/org/apache/helix/manager/zk/HelixConnectionAdaptor.java ef17715 helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java f95f6ee helix-core/src/main/java/org/apache/helix/manager/zk/ZkCallbackHandler.java 5961fe3 helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixAdministrator.java PRE-CREATION helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixAutoController.java 1d4b225 helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixConnection.java bec6f5c helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixController.java f9529b7 helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixParticipant.java d3ee8d1 helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixSpectator.java PRE-CREATION helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java 0ac3b58 helix-core/src/test/java/org/apache/helix/TestHelper.java 8328a15 helix-core/src/test/java/org/apache/helix/ZkTestHelper.java 444c069 helix-core/src/test/java/org/apache/helix/api/TestNewStages.java b5d218d helix-core/src/test/java/org/apache/helix/controller/stages/TestRebalancePipeline.java
[jira] [Created] (HELIX-493) REST API should have a removeResourceProperty on IdealState
Kanak Biscuitwala created HELIX-493: --- Summary: REST API should have a removeResourceProperty on IdealState Key: HELIX-493 URL: https://issues.apache.org/jira/browse/HELIX-493 Project: Apache Helix Issue Type: Bug Reporter: Kanak Biscuitwala The REST API has an addResourceProperty for adding tags and other things, but does not have the same for removal. This should be added. -- This message was sent by Atlassian JIRA (v6.2#6252)
