Re: Review Request 24190: [HELIX-376] Remove HelixConnection/HelixManager duplicate code
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24190/ --- (Updated Aug. 4, 2014, 8:10 p.m.) Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna. Bugs: HELIX-376 Repository: helix-git Description --- Remove HelixConnection/HelixManager duplicate code Diffs (updated) - helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ClusterResource.java b22d801 helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ConfigResource.java 3c384d4 helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ConstraintResource.java 675d0ec helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ControllerResource.java ea7be42 helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestHelixAdminScenariosRest.java 66065c3 helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestResetInstance.java b89a067 helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestResetPartitionState.java 8cd6f42 helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestResetResource.java 464edc4 helix-agent/src/test/java/org/apache/helix/agent/TestHelixAgent.java cbf0582 helix-core/src/main/java/org/apache/helix/ConfigAccessor.java 3589165 helix-core/src/main/java/org/apache/helix/ConfigChangeListener.java 1dbf2fe helix-core/src/main/java/org/apache/helix/HelixAutoController.java 91ec809 helix-core/src/main/java/org/apache/helix/HelixConnection.java ff5f458 helix-core/src/main/java/org/apache/helix/HelixManager.java 73313c0 helix-core/src/main/java/org/apache/helix/HelixMultiClusterController.java PRE-CREATION helix-core/src/main/java/org/apache/helix/HelixRole.java ffcb700 helix-core/src/main/java/org/apache/helix/HelixService.java 40e9bae helix-core/src/main/java/org/apache/helix/api/id/AdministratorId.java PRE-CREATION helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java 7bb214e helix-core/src/main/java/org/apache/helix/controller/HelixControllerMain.java b6c16b5 helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java 6f34953 helix-core/src/main/java/org/apache/helix/controller/stages/TaskAssignmentStage.java 9d6228e helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java 65fe2f9 helix-core/src/main/java/org/apache/helix/manager/zk/ControllerManagerHelper.java 9a817e3 helix-core/src/main/java/org/apache/helix/manager/zk/HelixConnectionAdaptor.java ef17715 helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java f95f6ee helix-core/src/main/java/org/apache/helix/manager/zk/ZkCallbackHandler.java 5961fe3 helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixAutoController.java 1d4b225 helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixConnection.java bec6f5c helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixController.java f9529b7 helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixMultiClusterController.java PRE-CREATION helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixParticipant.java d3ee8d1 helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixRoleDefaultImpl.java PRE-CREATION helix-core/src/main/java/org/apache/helix/messaging/DefaultMessagingService.java e799e38 helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java 0ac3b58 helix-core/src/main/java/org/apache/helix/model/ConfigScope.java 292ef0f helix-core/src/main/java/org/apache/helix/model/builder/ConfigScopeBuilder.java a8ce835 helix-core/src/main/java/org/apache/helix/participant/CustomCodeInvoker.java a736d71 helix-core/src/main/java/org/apache/helix/participant/GenericLeaderStandbyModel.java aa21ee3 helix-core/src/main/java/org/apache/helix/spectator/RoutingTableProvider.java 9bba660 helix-core/src/test/java/org/apache/helix/Mocks.java a3a6044 helix-core/src/test/java/org/apache/helix/TestConfigAccessor.java 3e69327 helix-core/src/test/java/org/apache/helix/TestHelper.java 8328a15 helix-core/src/test/java/org/apache/helix/TestZKCallback.java 50ed0df helix-core/src/test/java/org/apache/helix/ZkTestHelper.java 444c069 helix-core/src/test/java/org/apache/helix/api/TestNewStages.java b5d218d helix-core/src/test/java/org/apache/helix/controller/stages/DummyClusterManager.java 73ba122 helix-core/src/test/java/org/apache/helix/controller/stages/TestRebalancePipeline.java 922dde6 helix-core/src/test/java/org/apache/helix/integration/IntegrationTest.java bb862f3 helix-core/src/test/java/org/apache/helix/integration/TestAddClusterV2.java 8dca7c8 helix-core/src/test/java/org/apache/helix/integration/TestAddNodeAfterControllerStart.java 01d760a
Re: Review Request 24190: [HELIX-376] Remove HelixConnection/HelixManager duplicate code
On Aug. 1, 2014, 8:38 p.m., Kanak Biscuitwala wrote: helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java, line 195 https://reviews.apache.org/r/24190/diff/1/?file=648666#file648666line195 It's unsafe to call HelixConnection#connect in a constructor. have to do this; otherwise HelixManager.getStateMachineEngine().registerStateModelFactory() will through exception if helix-connection is not connected. On Aug. 1, 2014, 8:38 p.m., Kanak Biscuitwala wrote: helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestHelixAdminScenariosRest.java, line 335 https://reviews.apache.org/r/24190/diff/1/?file=648652#file648652line335 MockMultiClusterController is better fixed On Aug. 1, 2014, 8:38 p.m., Kanak Biscuitwala wrote: helix-core/src/main/java/org/apache/helix/HelixAdministrator.java, line 29 https://reviews.apache.org/r/24190/diff/1/?file=648657#file648657line29 Should this have getters/creators for HelixAdmin and ClusterAccessor? Alternatively, maybe make a default HelixRole implementation for the administrator adaptor. fixed On Aug. 1, 2014, 8:38 p.m., Kanak Biscuitwala wrote: helix-core/src/main/java/org/apache/helix/HelixSpectator.java, line 24 https://reviews.apache.org/r/24190/diff/1/?file=648661#file648661line24 This should either support adding listeners, or just use a default HelixRole implementation. fixed On Aug. 1, 2014, 8:38 p.m., Kanak Biscuitwala wrote: helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java, line 444 https://reviews.apache.org/r/24190/diff/1/?file=648666#file648666line444 This may be a good opportunity to remove getConfigAccessor since we deprecated it in an older version. undeprecated On Aug. 1, 2014, 8:38 p.m., Kanak Biscuitwala wrote: helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java, line 564 https://reviews.apache.org/r/24190/diff/1/?file=648666#file648666line564 Remove TODO removed On Aug. 1, 2014, 8:38 p.m., Kanak Biscuitwala wrote: helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java, line 663 https://reviews.apache.org/r/24190/diff/1/?file=648674#file648674line663 log instead of printing, make message more descriptive fixed On Aug. 1, 2014, 8:38 p.m., Kanak Biscuitwala wrote: recipes/jobrunner-yarn/src/main/java/org/apache/helix/provisioning/yarn/example/JobRunnerMain.java, line 114 https://reviews.apache.org/r/24190/diff/1/?file=648768#file648768line114 Remove TODO fixed - Zhen --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24190/#review49377 --- On Aug. 4, 2014, 8:10 p.m., Zhen Zhang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24190/ --- (Updated Aug. 4, 2014, 8:10 p.m.) Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna. Bugs: HELIX-376 Repository: helix-git Description --- Remove HelixConnection/HelixManager duplicate code Diffs - helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ClusterResource.java b22d801 helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ConfigResource.java 3c384d4 helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ConstraintResource.java 675d0ec helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ControllerResource.java ea7be42 helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestHelixAdminScenariosRest.java 66065c3 helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestResetInstance.java b89a067 helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestResetPartitionState.java 8cd6f42 helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestResetResource.java 464edc4 helix-agent/src/test/java/org/apache/helix/agent/TestHelixAgent.java cbf0582 helix-core/src/main/java/org/apache/helix/ConfigAccessor.java 3589165 helix-core/src/main/java/org/apache/helix/ConfigChangeListener.java 1dbf2fe helix-core/src/main/java/org/apache/helix/HelixAutoController.java 91ec809 helix-core/src/main/java/org/apache/helix/HelixConnection.java ff5f458 helix-core/src/main/java/org/apache/helix/HelixManager.java 73313c0 helix-core/src/main/java/org/apache/helix/HelixMultiClusterController.java PRE-CREATION helix-core/src/main/java/org/apache/helix/HelixRole.java ffcb700 helix-core/src/main/java/org/apache/helix/HelixService.java 40e9bae helix-core/src/main/java/org/apache/helix/api/id/AdministratorId.java PRE-CREATION
Re: Review Request 24193: [HELIX-492] Task should have its own rebalance mode
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24193/#review49513 --- Ship it! Ship It! - Zhen Zhang On Aug. 1, 2014, 8:01 p.m., Kanak Biscuitwala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24193/ --- (Updated Aug. 1, 2014, 8:01 p.m.) Review request for helix, Zhen Zhang and Kishore Gopalakrishna. Bugs: HELIX-492 Repository: helix-git Description --- commit 2bdc82cf6a258dad3b364c5edab32f10238409ce Author: Kanak Biscuitwala ka...@apache.org Date: Fri Aug 1 13:00:26 2014 -0700 [HELIX-492] Task should have its own rebalance mode :100644 100644 706fd41... 9a9767e... M helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java :100644 100644 aa2d617... 89fdab7... M helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java :100644 100644 a209cd9... 46a8f22... M helix-core/src/main/java/org/apache/helix/model/IdealState.java :100644 100644 e4871b5... ab504cd... M helix-core/src/main/java/org/apache/helix/task/TaskDriver.java Diffs - helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java 706fd41 helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java aa2d617 helix-core/src/main/java/org/apache/helix/model/IdealState.java a209cd9 helix-core/src/main/java/org/apache/helix/task/TaskDriver.java e4871b5 Diff: https://reviews.apache.org/r/24193/diff/ Testing --- Existing tests pass. Thanks, Kanak Biscuitwala
Review Request 24266: [HELIX-495] Make TestPreferenceListAsQueue non-flaky
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24266/ --- Review request for helix, Zhen Zhang and Kishore Gopalakrishna. Bugs: HELIX-495 Repository: helix-git Description --- commit 8ba16a8e26103ebddc04ab57cbac81b5226d6788 Author: Kanak Biscuitwala ka...@apache.org Date: Mon Aug 4 14:43:05 2014 -0700 [HELIX-495] Make TestPreferenceListAsQueue non-flaky :100644 100644 06a2b56... f9c2d47... M helix-core/src/test/java/org/apache/helix/integration/TestPreferenceListAsQueue.java Diffs - helix-core/src/test/java/org/apache/helix/integration/TestPreferenceListAsQueue.java 06a2b56 Diff: https://reviews.apache.org/r/24266/diff/ Testing --- Thanks, Kanak Biscuitwala
[jira] [Commented] (HELIX-376) Remove HelixConnection/HelixManager duplicate code
[ https://issues.apache.org/jira/browse/HELIX-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14085470#comment-14085470 ] Hudson commented on HELIX-376: -- SUCCESS: Integrated in helix #1277 (See [https://builds.apache.org/job/helix/1277/]) [HELIX-376] Remove HelixConnection/HelixManager duplicate code (zzhang: rev 02165c5203ffd226ad23d310ee3e027c9b761f65) * helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestResetClusterMetrics.java * helix-core/src/test/java/org/apache/helix/ZkTestHelper.java * helix-core/src/test/java/org/apache/helix/integration/task/TestTaskRebalancer.java * helix-core/src/test/java/org/apache/helix/tools/TestHelixAdminCli.java * helix-core/src/main/java/org/apache/helix/HelixAutoController.java * helix-core/src/test/java/org/apache/helix/integration/TestFullAutoNodeTagging.java * helix-core/src/test/java/org/apache/helix/integration/TestSessionExpiryInTransition.java * helix-core/src/test/java/org/apache/helix/participant/MockZKHelixManager.java * helix-core/src/test/java/org/apache/helix/integration/manager/TestDistributedControllerManager.java * helix-core/src/test/java/org/apache/helix/controller/stages/DummyClusterManager.java * helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ControllerResource.java * helix-core/src/test/java/org/apache/helix/integration/TestDisableResource.java * helix-core/src/test/java/org/apache/helix/integration/TestDisable.java * recipes/jobrunner-yarn/src/main/java/org/apache/helix/provisioning/yarn/example/MyTaskService.java * helix-core/src/main/java/org/apache/helix/HelixService.java * helix-core/src/test/java/org/apache/helix/TestHelper.java * helix-core/src/main/java/org/apache/helix/messaging/DefaultMessagingService.java * helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ConfigResource.java * helix-core/src/test/java/org/apache/helix/TestZKCallback.java * helix-core/src/test/java/org/apache/helix/monitoring/TestClusterStatusMonitorLifecycle.java * helix-core/src/test/java/org/apache/helix/integration/manager/TestParticipantManager.java * helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixController.java * helix-core/src/test/java/org/apache/helix/tools/TestClusterStateVerifier.java * helix-core/src/test/java/org/apache/helix/mock/controller/MockController.java * helix-core/src/test/java/org/apache/helix/integration/TestInvalidResourceRebalance.java * helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixConnection.java * helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ClusterResource.java * helix-core/src/test/java/org/apache/helix/integration/TestParticipantNameCollision.java * helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java * helix-core/src/test/java/org/apache/helix/integration/TestRestartParticipant.java * helix-core/src/test/java/org/apache/helix/integration/manager/MockParticipantManager.java * helix-core/src/test/java/org/apache/helix/integration/manager/ClusterDistributedController.java * helix-core/src/test/java/org/apache/helix/integration/TestSchemataSM.java * helix-core/src/test/java/org/apache/helix/manager/zk/MockController.java * helix-core/src/test/java/org/apache/helix/integration/TestCustomIdealState.java * helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java * helix-core/src/test/java/org/apache/helix/manager/zk/TestZkFlapping.java * helix-core/src/test/java/org/apache/helix/integration/TestResetInstance.java * helix-core/src/test/java/org/apache/helix/integration/manager/TestZkCallbackHandlerLeak.java * helix-core/src/test/java/org/apache/helix/integration/TestInvalidAutoIdealState.java * helix-core/src/test/java/org/apache/helix/integration/TestEnablePartitionDuringDisable.java * helix-core/src/main/java/org/apache/helix/controller/stages/TaskAssignmentStage.java * helix-core/src/test/java/org/apache/helix/integration/TestBatchMessage.java * helix-core/src/test/java/org/apache/helix/integration/TestDistributedClusterController.java * helix-core/src/test/java/org/apache/helix/integration/TestReelectedPipelineCorrectness.java * helix-core/src/test/java/org/apache/helix/integration/TestAutoRebalance.java * helix-core/src/test/java/org/apache/helix/manager/zk/MockParticipant.java * helix-core/src/test/java/org/apache/helix/integration/TestNonOfflineInitState.java * helix-core/src/test/java/org/apache/helix/manager/zk/TestZKLiveInstanceData.java * recipes/jobrunner-yarn/src/main/java/org/apache/helix/provisioning/yarn/example/JobRunnerMain.java * helix-core/src/test/java/org/apache/helix/integration/TestStandAloneCMMain.java * helix-core/src/test/java/org/apache/helix/manager/zk/MockMultiClusterController.java * helix-core/src/main/java/org/apache/helix/controller/HelixControllerMain.java * helix-core/src/test/java/org/apache/helix/integration/TestDisableCustomCodeRunner.java *
[jira] [Commented] (HELIX-492) Task should be its own rebalance mode
[ https://issues.apache.org/jira/browse/HELIX-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14085469#comment-14085469 ] Hudson commented on HELIX-492: -- SUCCESS: Integrated in helix #1277 (See [https://builds.apache.org/job/helix/1277/]) [HELIX-492] Task should be its own rebalance mode (kanak: rev dd8226b8365c59ab44aa49eec6fd116f757bfbd2) * helix-core/src/main/java/org/apache/helix/model/IdealState.java * helix-core/src/main/java/org/apache/helix/task/TaskDriver.java Task should be its own rebalance mode - Key: HELIX-492 URL: https://issues.apache.org/jira/browse/HELIX-492 Project: Apache Helix Issue Type: Sub-task Reporter: Kanak Biscuitwala Assignee: Kanak Biscuitwala Right now the task framework creates a rebalancer with mode USER_DEFINED, where since it's built in, it's not really user-defined, but rather task-specific. There should be a new mode called TASK or similar. -- This message was sent by Atlassian JIRA (v6.2#6252)
