RE: [VOTE] Apache Helix 0.6.5 Release

2015-03-17 Thread Kanak Biscuitwala
I see that the ivy has been updated in the code, but the release has not been 
updated. I'm not sure if that's allowed.


 Date: Tue, 17 Mar 2015 15:00:13 -0700
 Subject: Re: [VOTE] Apache Helix 0.6.5 Release
 From: nehzgn...@gmail.com
 To: dev@helix.apache.org

 I've fixed the ivy issue as well as updated the release notes:
 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12314020version=12328652

 Release Notes - Apache Helix - Version 0.6.5

 ** Bug
 * [HELIX-512] - add back HelixManager#getHealthReportCollector()
 interface to 0.6.x
 * [HELIX-514] - ZkBaseDataAccessor#set() should throw
 BadVersionException instead of return false in case of version mismatch
 * [HELIX-518] - Add integration tests to ensure helix tasks work as
 expected during master failover
 * [HELIX-519] - Add integration tests to ensure that kill-switch for
 Helix tasks work as expected
 * [HELIX-521] - Should not start
 GenericHelixController#ClusterEventProcessor in types other than CONTROLLER
 and CONTROLLER_PARTICIPANT
 * [HELIX-537] - org.apache.helix.task.TaskStateModel should have a
 shutdown method.
 * [HELIX-541] - Possible livelock in Helix controller
 * [HELIX-547] - AutoRebalancer may not converge in some rare situation
 * [HELIX-549] - Discarding Throwable exceptions makes threads
 unkillable.
 * [HELIX-550] - ZKHelixManager does not shutdown GenericHelixController
 threads.
 * [HELIX-552] - StateModelFactory#_stateModelMap should use both
 resourceName and partitionKey to map a state model
 * [HELIX-555] - ClusterStateVerifier leaks ZkClients.
 * [HELIX-559] - Helix web admin performance issues
 * [HELIX-562] - TaskRebalancer doesn't honor MaxAttemptsPerTask when
 FailureThreshold is larger than 0
 * [HELIX-563] - Throw more meaningful exceptions when
 AutoRebalanceStrategy#computePartitionAssignment inputs are invalid
 * [HELIX-572] - External view is recreated every time for bucketized
 resource
 * [HELIX-574] - fix bucketize resource bug in current state carryover
 * [HELIX-575] - Should not send FINALIZED callback when a bucketized
 resource is removed
 * [HELIX-579] - fix ivy files issue

 ** Improvement
 * [HELIX-524] - add getProgress() to Task interface
 * [HELIX-573] - Add support to compress/uncompress data on ZK
 * [HELIX-576] - Make StateModelFactory change backward compatible

 ** New Feature
 * [HELIX-546] - REST Admin APIs needed for helix job queue management
 * [HELIX-581] - Support deleting job from a job queue

 ** Task
 * [HELIX-539] - Add ivy file for helix-agent

 ** Test
 * [HELIX-580] - Fix test: TestBatchMessage#testSubMsgExecutionFail

 Thanks,
 Jason


 On Mon, Mar 16, 2015 at 11:22 PM, kishore g g.kish...@gmail.com wrote:

 Jason is working on the release notes. Does any one know if we have to re
 cut the release because of the ivy file?

 thanks,
 Kishore G

 On Mon, Mar 16, 2015 at 10:30 PM, Kanak Biscuitwala kana...@hotmail.com
 wrote:

 A couple things:


 1. Release notes are missing. You can just link to this page if you want
 to update the site later, but it's currently not up-to-date:

 https://issues.apache.org/jira/browse/HELIX/fixforversion/12328652/?selectedTab=com.atlassian.jira.jira-projects-plugin:version-summary-panel


 2. Rat is failing because of this file:
 helix-agent/helix-agent-0.6.5-SNAPSHOT.ivy


 
 Date: Mon, 16 Mar 2015 10:19:27 -0700
 Subject: Re: [VOTE] Apache Helix 0.6.5 Release
 From: nehzgn...@gmail.com
 To: dev@helix.apache.org

 +1

 On Mon, Mar 16, 2015 at 12:15 AM, kishore g g.kish...@gmail.com
 wrote:

 Hi,

 This is to call for a vote on releasing the following candidate as
 Apache
 Helix 0.6.5. This is the 8th release of Helix as an Apache project, as
 well
 as the 4th release as a top-level Apache project.

 Apache Helix is a generic cluster management framework that makes it
 easy
 to build partitioned and replicated, fault-tolerant and scalable
 distributed systems.

 Release notes:
 http://helix.apache.org/releasenotes/release-0.6.5.html

 Release artifacts:

 https://repository.apache.org/content/repositories/orgapachehelix-1004

 Distribution:
 * binaries:
 https://dist.apache.org/repos/dist/dev/helix/0.6.5/binaries/
 * sources:
 https://dist.apache.org/repos/dist/dev/helix/0.6.5/src/

 The 0.6.5 release tag:



 https://git-wip-us.apache.org/repos/asf?p=helix.git;a=tag;h=refs/tags/helix-0.6.5

 KEYS file available here:
 https://dist.apache.org/repos/dist/dev/helix/KEYS

 Please vote on the release. The vote will be open for at least 72
 hours.

 [+1] -- YES, release
 [0] -- No opinion
 [-1] -- NO, do not release

 Thanks,
 The Apache Helix Team




  

Review Request 32173: [HELIX-580] Fix test: TestBatchMessage#testSubMsgExecutionFail

2015-03-17 Thread Zhen Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32173/
---

Review request for helix and Shi Lu.


Repository: helix-git


Description
---

[HELIX-580] Fix test: TestBatchMessage#testSubMsgExecutionFail


Diffs
-

  helix-core/src/test/java/org/apache/helix/integration/TestBatchMessage.java 
03fc85b 

Diff: https://reviews.apache.org/r/32173/diff/


Testing
---


Thanks,

Zhen Zhang



Re: Review Request 31397: [HELIX-570] Add default state model definitions if not already exists when controller starts

2015-03-17 Thread Zhen Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31397/
---

(Updated March 17, 2015, 11:49 p.m.)


Review request for helix, Kishore Gopalakrishna and Shi Lu.


Bugs: 570


Repository: helix-git


Description
---

When controller starts, we can add missing default state model definitions to 
the cluster. This is useful for example, a legacy cluster is created without 
some new default state model definitions. Instead of building a tool to 
populate the new default state model definitions to existing clusters, 
controller can check this and add it if necessary.


Diffs (updated)
-

  helix-core/src/main/java/org/apache/helix/controller/HelixControllerMain.java 
b6c16b5 
  helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java 
3328279 
  helix-core/src/main/java/org/apache/helix/model/BuildInSMD.java e69de29 
  
helix-core/src/main/java/org/apache/helix/model/BuiltInStateModelDefinitions.java
 e69de29 
  helix-core/src/main/java/org/apache/helix/model/LeaderStandbySMD.java e69de29 
  helix-core/src/main/java/org/apache/helix/model/MasterSlaveSMD.java e69de29 
  helix-core/src/main/java/org/apache/helix/model/OnlineOfflineSMD.java e69de29 
  helix-core/src/main/java/org/apache/helix/model/ScheduledTaskSMD.java e69de29 
  helix-core/src/main/java/org/apache/helix/model/StateModelDefinition.java 
e99e173 
  helix-core/src/main/java/org/apache/helix/model/StorageSchemataSMD.java 
e69de29 
  helix-core/src/main/java/org/apache/helix/model/TaskSMD.java e69de29 
  helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java 40bc398 
  
helix-core/src/main/java/org/apache/helix/tools/StateModelConfigGenerator.java 
b8b3aeb 
  helix-core/src/test/java/org/apache/helix/integration/IntegrationTest.java 
bb862f3 
  
helix-core/src/test/java/org/apache/helix/manager/zk/TestAddBuiltInStateModelDef.java
 e69de29 
  
helix-core/src/test/java/org/apache/helix/manager/zk/TestAddDefaultStateModelDef.java
 e69de29 

Diff: https://reviews.apache.org/r/31397/diff/


Testing
---

mvn test


Thanks,

Zhen Zhang



Re: [VOTE] Apache Helix 0.6.5 Release

2015-03-17 Thread kishore g
I think we will have to re do the release. I wont be able to do this today.
Will have start tomorrow evening.

Varun, this means the release won't be available until Friday :(

thanks,
Kishore G

On Tue, Mar 17, 2015 at 9:58 PM, Kanak Biscuitwala kana...@hotmail.com
wrote:

 I see that the ivy has been updated in the code, but the release has not
 been updated. I'm not sure if that's allowed.

 
  Date: Tue, 17 Mar 2015 15:00:13 -0700
  Subject: Re: [VOTE] Apache Helix 0.6.5 Release
  From: nehzgn...@gmail.com
  To: dev@helix.apache.org
 
  I've fixed the ivy issue as well as updated the release notes:
 
 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12314020version=12328652
 
  Release Notes - Apache Helix - Version 0.6.5
 
  ** Bug
  * [HELIX-512] - add back HelixManager#getHealthReportCollector()
  interface to 0.6.x
  * [HELIX-514] - ZkBaseDataAccessor#set() should throw
  BadVersionException instead of return false in case of version mismatch
  * [HELIX-518] - Add integration tests to ensure helix tasks work as
  expected during master failover
  * [HELIX-519] - Add integration tests to ensure that kill-switch for
  Helix tasks work as expected
  * [HELIX-521] - Should not start
  GenericHelixController#ClusterEventProcessor in types other than
 CONTROLLER
  and CONTROLLER_PARTICIPANT
  * [HELIX-537] - org.apache.helix.task.TaskStateModel should have a
  shutdown method.
  * [HELIX-541] - Possible livelock in Helix controller
  * [HELIX-547] - AutoRebalancer may not converge in some rare situation
  * [HELIX-549] - Discarding Throwable exceptions makes threads
  unkillable.
  * [HELIX-550] - ZKHelixManager does not shutdown GenericHelixController
  threads.
  * [HELIX-552] - StateModelFactory#_stateModelMap should use both
  resourceName and partitionKey to map a state model
  * [HELIX-555] - ClusterStateVerifier leaks ZkClients.
  * [HELIX-559] - Helix web admin performance issues
  * [HELIX-562] - TaskRebalancer doesn't honor MaxAttemptsPerTask when
  FailureThreshold is larger than 0
  * [HELIX-563] - Throw more meaningful exceptions when
  AutoRebalanceStrategy#computePartitionAssignment inputs are invalid
  * [HELIX-572] - External view is recreated every time for bucketized
  resource
  * [HELIX-574] - fix bucketize resource bug in current state carryover
  * [HELIX-575] - Should not send FINALIZED callback when a bucketized
  resource is removed
  * [HELIX-579] - fix ivy files issue
 
  ** Improvement
  * [HELIX-524] - add getProgress() to Task interface
  * [HELIX-573] - Add support to compress/uncompress data on ZK
  * [HELIX-576] - Make StateModelFactory change backward compatible
 
  ** New Feature
  * [HELIX-546] - REST Admin APIs needed for helix job queue management
  * [HELIX-581] - Support deleting job from a job queue
 
  ** Task
  * [HELIX-539] - Add ivy file for helix-agent
 
  ** Test
  * [HELIX-580] - Fix test: TestBatchMessage#testSubMsgExecutionFail
 
  Thanks,
  Jason
 
 
  On Mon, Mar 16, 2015 at 11:22 PM, kishore g g.kish...@gmail.com wrote:
 
  Jason is working on the release notes. Does any one know if we have to
 re
  cut the release because of the ivy file?
 
  thanks,
  Kishore G
 
  On Mon, Mar 16, 2015 at 10:30 PM, Kanak Biscuitwala 
 kana...@hotmail.com
  wrote:
 
  A couple things:
 
 
  1. Release notes are missing. You can just link to this page if you
 want
  to update the site later, but it's currently not up-to-date:
 
 
 https://issues.apache.org/jira/browse/HELIX/fixforversion/12328652/?selectedTab=com.atlassian.jira.jira-projects-plugin:version-summary-panel
 
 
  2. Rat is failing because of this file:
  helix-agent/helix-agent-0.6.5-SNAPSHOT.ivy
 
 
  
  Date: Mon, 16 Mar 2015 10:19:27 -0700
  Subject: Re: [VOTE] Apache Helix 0.6.5 Release
  From: nehzgn...@gmail.com
  To: dev@helix.apache.org
 
  +1
 
  On Mon, Mar 16, 2015 at 12:15 AM, kishore g g.kish...@gmail.com
  wrote:
 
  Hi,
 
  This is to call for a vote on releasing the following candidate as
  Apache
  Helix 0.6.5. This is the 8th release of Helix as an Apache project,
 as
  well
  as the 4th release as a top-level Apache project.
 
  Apache Helix is a generic cluster management framework that makes it
  easy
  to build partitioned and replicated, fault-tolerant and scalable
  distributed systems.
 
  Release notes:
  http://helix.apache.org/releasenotes/release-0.6.5.html
 
  Release artifacts:
 
  https://repository.apache.org/content/repositories/orgapachehelix-1004
 
  Distribution:
  * binaries:
  https://dist.apache.org/repos/dist/dev/helix/0.6.5/binaries/
  * sources:
  https://dist.apache.org/repos/dist/dev/helix/0.6.5/src/
 
  The 0.6.5 release tag:
 
 
 
 
 https://git-wip-us.apache.org/repos/asf?p=helix.git;a=tag;h=refs/tags/helix-0.6.5
 
  KEYS file available here:
  https://dist.apache.org/repos/dist/dev/helix/KEYS
 
  Please vote on the release. The vote will be open for at least 72
 

[jira] [Created] (HELIX-582) NPE while deleting a job from a recurrent job queue

2015-03-17 Thread Xia Lei (JIRA)
Xia Lei created HELIX-582:
-

 Summary: NPE while deleting a job from a recurrent job queue
 Key: HELIX-582
 URL: https://issues.apache.org/jira/browse/HELIX-582
 Project: Apache Helix
  Issue Type: Bug
  Components: helix-core
Affects Versions: 0.6.4
Reporter: Xia Lei




Helix throws an NPE when we try to delete a job from recurrent job queue.

Partial stacktrace:

java.lang.NullPointerException
at org.apache.helix.task.TaskDriver.deleteJob(TaskDriver.java:295)

Helix is looking for workflow context's current state.

WorkflowContext wCtx = TaskUtil.getWorkflowContext(_propertyStore, queueName);
String workflowState =
(wCtx != null) ? wCtx.getWorkflowState().name() : TaskState.NOT_STARTED.name();

But for a recurring workflow, there is no state in the parent workflow's 
context. Only the scheduled workflows will have a state. Hence the NPE.

To ensure that queue is stopped, Helix should look at the context of 
last-scheduled-workflow instead of the parent workflow.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)