[jira] [Commented] (HELIX-536) IdealState should ignore null value for InstanceGroupTag.

[Xia Lei (JIRA)]

[ 
https://issues.apache.org/jira/browse/HELIX-536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14191154#comment-14191154
 ] 

Xia Lei commented on HELIX-536:
---

The case was found in Espresso, when Espresso does rebalance, it resets 
IdealState as:

 idealState.setInstanceGroupTag(idealState.getInstanceGroupTag()); 

which causes the problem when the InstanceGroup is not set before, it ends up 
shows InstanceTagGroup:null in IdealState which is not acceptable by 
Espresso.   

Espresso may need to verify whether getInstanceGroup() return null, but Helix 
should also check and ignore null value in case the caller does not check. 

 IdealState should ignore null value for InstanceGroupTag.
 -

 Key: HELIX-536
 URL: https://issues.apache.org/jira/browse/HELIX-536
 Project: Apache Helix
  Issue Type: Bug
Reporter: Xia Lei





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HELIX-536) IdealState should ignore null value for InstanceGroupTag.

[Kanak Biscuitwala (JIRA)]

[ 
https://issues.apache.org/jira/browse/HELIX-536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14191238#comment-14191238
 ] 

Kanak Biscuitwala commented on HELIX-536:
-

Alternatively, you could make setInstanceGroup(null) mean 
getRecord().getSimpleFields().remove(IdealStateProperty.INSTANCE_GROUP_TAG.name())
 rather than simply ignoring it.

 IdealState should ignore null value for InstanceGroupTag.
 -

 Key: HELIX-536
 URL: https://issues.apache.org/jira/browse/HELIX-536
 Project: Apache Helix
  Issue Type: Bug
Reporter: Xia Lei





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)