Re: [VOTE] Heron Release 0.20.0-incubating Candidate 4

2018-09-27 Thread Justin Mclean
Hi,

Dave asked me to take a look and I think the LICENSE and NOTICE file need a bit 
more work. I would probably vote -1 on this release if it come up on the IPMC 
and I reviewed it.

Here a list of (permissive) software that is bundled in the source release but 
is not mentioned in LICENSE:
glyphicons-halflings-regular.svg
d3-tip.min.0.6.3.js
d3.min.3.4.11.js
html5-trunk.js
jquery-ui-1.8.23.custom.min.js
list.min.1.1.1.js
moment.min.2.8.3.js
underscore-min.1.6.0.js
third_party/kashmir/*
third_party/libunwind/libunwind-1.1-cache.patch
third_party/python/cpplint/cpplint.py
normalize.css 
JSXTransformer.0.10.0.js (also included node.js, browser.js and a number if 
other pieces of code all under different licenses and owners)
javadoc.bzl
build_defs.bzl
autogen.sh
jarjar_rules.bzl
maven-pom-version.sh (and other files)
base_spout.py (and other files)
generate-zookeeper-config.sh
gtest.BUILD
cloudpickle.py (which may also incorrectly have an ASF header, not multiple 
copyright notices/licenses)

I’ve not checked if that any ALv2 bundled bits have NOTICE files, which could 
have an impact on your NOTICE file.

I can see jQuery is listed twice under two different licenses is that correct?

There some files incorrectly with "Copyright 2015 The Heron Authors.” in their 
headers.

Thanks,
Justin

P.S I’m not subscribed to your list so please CC me if you have any questions.

Re: [VOTE] Heron Release 0.20.0-incubating Candidate 4

2018-09-25 Thread Ning Wang
+1

My tests:

License check ok:
java -jar ~/Downloads/apache-rat-0.12.jar . -E .rat-excludes

Builds ok:
bazel build --compilation_mode=dbg --config=darwin heron/...
bazel build --compilation_mode=dbg --config=darwin scripts/packages:binpkgs
--verbose_failures

Unit tests and integration tests passed

CLI installed ok.

Started tracker/ui and deployed ExclamationTopology locally and it worked
and showed up in UI:
~/.heron/bin/heron submit local ~/.heron/examples/heron-api-examples.jar
org.apache.heron.examples.api.ExclamationTopology ExclamationTopology





On Mon, Sep 24, 2018 at 4:41 PM P. Taylor Goetz  wrote:

> Please keep release votes public. No need to cc private@. In fact,
> depending on order, including private@ can set the reply-to, as it did in
> this case.
>
> -Taylor
>
> > On Sep 24, 2018, at 5:18 PM, Neng Lu  wrote:
> >
> > Hi All,
> >
> > This is the 4th release candidate for Apache Heron, version
> 0.20.0-incubating. Thank Dave Fisher and Ning Wang for providing various
> feedback for the previous release candidates.
> >
> > It is the starting point of Heron and contains heron's main features,
> such as streaming
> > processing, stateful processing, streamlet API, API server, eco support,
> etc.
> >
> > The full list of changes and fixes are available:
> >
> https://github.com/apache/incubator-heron/compare/0.17.8...release/v-0.20.0-incubating
> >
> > *** Please download, test and vote on this release. This vote will stay
> open
> > for at least 72 hours ***
> >
> > Source files:
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.0-incubating-candidate-4/
> >
> > SHA-512 checksums:
> >
> b207bd181dc1960abc7393bb2af4f8c5428676174693cecd3b95216af1d3c6dcec76a07d5e91d0a1959f5523ca3fe79f310b8f9ad797252441d8e1be23aadca2
>
> > incubator-heron-v-0.20.0-incubating-candidate-4.tar.gz
> >
> > The tag to be voted upon:
> > v0.20.0-incubating-candidate-4 (a468699b180a44b411705172ae2ee4d981b3c162)
> >
> https://github.com/apache/incubator-heron/releases/tag/v-0.20.0-incubating-candidate-4
> >
> > Please download the source package, and follow the compiling guide(
> https://apache.github.io/incubator-heron/docs/developers/compiling/compiling/)
> to build and run the Heron locally.
> >
> > --
> > Best Regards,
> > Neng
>


Re: [VOTE] Heron Release 0.20.0-incubating Candidate 4

2018-09-24 Thread P. Taylor Goetz
Please keep release votes public. No need to cc private@. In fact, depending on 
order, including private@ can set the reply-to, as it did in this case.

-Taylor

> On Sep 24, 2018, at 5:18 PM, Neng Lu  wrote:
> 
> Hi All,
> 
> This is the 4th release candidate for Apache Heron, version 
> 0.20.0-incubating. Thank Dave Fisher and Ning Wang for providing various 
> feedback for the previous release candidates.
> 
> It is the starting point of Heron and contains heron's main features, such as 
> streaming
> processing, stateful processing, streamlet API, API server, eco support, etc.
> 
> The full list of changes and fixes are available:
> https://github.com/apache/incubator-heron/compare/0.17.8...release/v-0.20.0-incubating
> 
> *** Please download, test and vote on this release. This vote will stay open
> for at least 72 hours ***
> 
> Source files:
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.0-incubating-candidate-4/
> 
> SHA-512 checksums:
> b207bd181dc1960abc7393bb2af4f8c5428676174693cecd3b95216af1d3c6dcec76a07d5e91d0a1959f5523ca3fe79f310b8f9ad797252441d8e1be23aadca2
>   
> incubator-heron-v-0.20.0-incubating-candidate-4.tar.gz
> 
> The tag to be voted upon:
> v0.20.0-incubating-candidate-4 (a468699b180a44b411705172ae2ee4d981b3c162)
> https://github.com/apache/incubator-heron/releases/tag/v-0.20.0-incubating-candidate-4
> 
> Please download the source package, and follow the compiling 
> guide(https://apache.github.io/incubator-heron/docs/developers/compiling/compiling/)
>  to build and run the Heron locally.
> 
> -- 
> Best Regards,
> Neng


[VOTE] Heron Release 0.20.0-incubating Candidate 4

2018-09-24 Thread Neng Lu
Hi All,

This is the 4th release candidate for Apache Heron, version
0.20.0-incubating. Thank Dave Fisher and Ning Wang for providing various
feedback for the previous release candidates.

It is the starting point of Heron and contains heron's main features, such
as streaming
processing, stateful processing, streamlet API, API server, eco support,
etc.

The full list of changes and fixes are available:
https://github.com/apache/incubator-heron/compare/0.17.8...release/v-0.20.0-incubating

*** Please download, test and vote on this release. This vote will stay open
for at least 72 hours ***

Source files:
https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.0-incubating-candidate-4/

SHA-512 checksums:
b207bd181dc1960abc7393bb2af4f8c5428676174693cecd3b95216af1d3c6dcec76a07d5e91d0a1959f5523ca3fe79f310b8f9ad797252441d8e1be23aadca2
incubator-heron-v-0.20.0-incubating-candidate-4.tar.gz

The tag to be voted upon:
v0.20.0-incubating-candidate-4 (a468699b180a44b411705172ae2ee4d981b3c162)
https://github.com/apache/incubator-heron/releases/tag/v-0.20.0-incubating-candidate-4

Please download the source package, and follow the compiling guide(
https://apache.github.io/incubator-heron/docs/developers/compiling/compiling/)
to build and run the Heron locally.

-- 
Best Regards,
Neng