Re: Review Request: HIVE-1943
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/586/#review437 --- http://svn.apache.org/repos/asf/hive/trunk/metastore/build.xml https://reviews.apache.org/r/586/#comment851 Did not understand why this change is required? http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java https://reviews.apache.org/r/586/#comment850 change Table metadata to databse metadata? http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java https://reviews.apache.org/r/586/#comment849 change Table metadata to partition metadata? http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java https://reviews.apache.org/r/586/#comment848 change Table metadata to partition metadata? http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java https://reviews.apache.org/r/586/#comment845 Can this be changed to assert statement instead of throwing exception? http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java https://reviews.apache.org/r/586/#comment846 Can this be changed to assert statement instead of throwing exception? http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java https://reviews.apache.org/r/586/#comment847 Can we add the test for group writable also? - Amareshwari On 2011-04-12 22:12:32, Devaraj Das wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/586/ --- (Updated 2011-04-12 22:12:32) Review request for hive. Summary --- This is a patch to handle the issue described in HIVE-1943 This addresses bug HIVE-1943. https://issues.apache.org/jira/browse/HIVE-1943 Diffs - http://svn.apache.org/repos/asf/hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1090038 http://svn.apache.org/repos/asf/hive/trunk/conf/hive-default.xml 1090038 http://svn.apache.org/repos/asf/hive/trunk/metastore/build.xml 1090038 http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1090038 http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1090038 http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java 1090038 http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java PRE-CREATION http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java 1090038 http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20S/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java 1090038 http://svn.apache.org/repos/asf/hive/trunk/shims/src/common/java/org/apache/hadoop/hive/shims/HadoopShims.java 1090038 http://svn.apache.org/repos/asf/hive/trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1090038 Diff: https://reviews.apache.org/r/586/diff Testing --- Unit tests added. Thanks, Devaraj
Re: Review Request: HIVE-1943
On 2011-04-13 06:21:06, Amareshwari Sriramadasu wrote: http://svn.apache.org/repos/asf/hive/trunk/metastore/build.xml, lines 25-46 https://reviews.apache.org/r/586/diff/1/?file=15648#file15648line25 Did not understand why this change is required? Right. This is not needed (it was needed in an earlier version of the TestMetaStoreAuthorization). On 2011-04-13 06:21:06, Amareshwari Sriramadasu wrote: http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, line 649 https://reviews.apache.org/r/586/diff/1/?file=15649#file15649line649 change Table metadata to databse metadata? Copy-paste problem :( On 2011-04-13 06:21:06, Amareshwari Sriramadasu wrote: http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, line 1399 https://reviews.apache.org/r/586/diff/1/?file=15649#file15649line1399 change Table metadata to partition metadata? Copy-paste problem :( On 2011-04-13 06:21:06, Amareshwari Sriramadasu wrote: http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, line 1411 https://reviews.apache.org/r/586/diff/1/?file=15649#file15649line1411 change Table metadata to partition metadata? Copy-paste problem :( On 2011-04-13 06:21:06, Amareshwari Sriramadasu wrote: http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java, lines 63-65 https://reviews.apache.org/r/586/diff/1/?file=15652#file15652line63 Can this be changed to assert statement instead of throwing exception? Okay, will make it an assert. On 2011-04-13 06:21:06, Amareshwari Sriramadasu wrote: http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java, lines 67-69 https://reviews.apache.org/r/586/diff/1/?file=15652#file15652line67 Can this be changed to assert statement instead of throwing exception? Okay, will make it an assert. On 2011-04-13 06:21:06, Amareshwari Sriramadasu wrote: http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java, line 73 https://reviews.apache.org/r/586/diff/1/?file=15652#file15652line73 Can we add the test for group writable also? That's a bit tricky. The reason being that the test might give out false positives, since the isWritable call doesn't take any argument to signify for which entity (owner or group) we are doing the check. For example, isWritable(foo) will return true for both 570 and 750 permissions on foo. We really can't say whether the test passed because the check for the owner part returned true, or, the check for the group part returned true. If i break up the method isWritable to three methods that do checks on owner, group, and, others, respectively, i can do the tests for all three, but have a feeling that that will be an overkill.. Thoughts? - Devaraj --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/586/#review437 --- On 2011-04-12 22:12:32, Devaraj Das wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/586/ --- (Updated 2011-04-12 22:12:32) Review request for hive. Summary --- This is a patch to handle the issue described in HIVE-1943 This addresses bug HIVE-1943. https://issues.apache.org/jira/browse/HIVE-1943 Diffs - http://svn.apache.org/repos/asf/hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1090038 http://svn.apache.org/repos/asf/hive/trunk/conf/hive-default.xml 1090038 http://svn.apache.org/repos/asf/hive/trunk/metastore/build.xml 1090038 http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1090038 http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1090038 http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java 1090038 http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java PRE-CREATION http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java 1090038 http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20S/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java 1090038
[jira] [Commented] (HIVE-1943) Metastore operations (like drop_partition) could be improved in terms of maintaining consistency of metadata and data
[ https://issues.apache.org/jira/browse/HIVE-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13019232#comment-13019232 ] jirapos...@reviews.apache.org commented on HIVE-1943: - bq. On 2011-04-13 06:21:06, Amareshwari Sriramadasu wrote: bq. http://svn.apache.org/repos/asf/hive/trunk/metastore/build.xml, lines 25-46 bq. https://reviews.apache.org/r/586/diff/1/?file=15648#file15648line25 bq. bq. Did not understand why this change is required? Right. This is not needed (it was needed in an earlier version of the TestMetaStoreAuthorization). bq. On 2011-04-13 06:21:06, Amareshwari Sriramadasu wrote: bq. http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, line 649 bq. https://reviews.apache.org/r/586/diff/1/?file=15649#file15649line649 bq. bq. change Table metadata to databse metadata? Copy-paste problem :( bq. On 2011-04-13 06:21:06, Amareshwari Sriramadasu wrote: bq. http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, line 1399 bq. https://reviews.apache.org/r/586/diff/1/?file=15649#file15649line1399 bq. bq. change Table metadata to partition metadata? Copy-paste problem :( bq. On 2011-04-13 06:21:06, Amareshwari Sriramadasu wrote: bq. http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, line 1411 bq. https://reviews.apache.org/r/586/diff/1/?file=15649#file15649line1411 bq. bq. change Table metadata to partition metadata? Copy-paste problem :( bq. On 2011-04-13 06:21:06, Amareshwari Sriramadasu wrote: bq. http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java, lines 63-65 bq. https://reviews.apache.org/r/586/diff/1/?file=15652#file15652line63 bq. bq. Can this be changed to assert statement instead of throwing exception? Okay, will make it an assert. bq. On 2011-04-13 06:21:06, Amareshwari Sriramadasu wrote: bq. http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java, lines 67-69 bq. https://reviews.apache.org/r/586/diff/1/?file=15652#file15652line67 bq. bq. Can this be changed to assert statement instead of throwing exception? Okay, will make it an assert. bq. On 2011-04-13 06:21:06, Amareshwari Sriramadasu wrote: bq. http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java, line 73 bq. https://reviews.apache.org/r/586/diff/1/?file=15652#file15652line73 bq. bq. Can we add the test for group writable also? That's a bit tricky. The reason being that the test might give out false positives, since the isWritable call doesn't take any argument to signify for which entity (owner or group) we are doing the check. For example, isWritable(foo) will return true for both 570 and 750 permissions on foo. We really can't say whether the test passed because the check for the owner part returned true, or, the check for the group part returned true. If i break up the method isWritable to three methods that do checks on owner, group, and, others, respectively, i can do the tests for all three, but have a feeling that that will be an overkill.. Thoughts? - Devaraj --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/586/#review437 --- On 2011-04-12 22:12:32, Devaraj Das wrote: bq. bq. --- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/586/ bq. --- bq. bq. (Updated 2011-04-12 22:12:32) bq. bq. bq. Review request for hive. bq. bq. bq. Summary bq. --- bq. bq. This is a patch to handle the issue described in HIVE-1943 bq. bq. bq. This addresses bug HIVE-1943. bq. https://issues.apache.org/jira/browse/HIVE-1943 bq. bq. bq. Diffs bq. - bq. bq. http://svn.apache.org/repos/asf/hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1090038 bq.http://svn.apache.org/repos/asf/hive/trunk/conf/hive-default.xml 1090038 bq.http://svn.apache.org/repos/asf/hive/trunk/metastore/build.xml 1090038 bq. http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1090038 bq. http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1090038 bq.
[jira] [Updated] (HIVE-2098) Make couple of convenience methods in EximUtil public
[ https://issues.apache.org/jira/browse/HIVE-2098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated HIVE-2098: -- Resolution: Fixed Fix Version/s: 0.8.0 Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) I just committed this. Thanks Krishna! Make couple of convenience methods in EximUtil public - Key: HIVE-2098 URL: https://issues.apache.org/jira/browse/HIVE-2098 Project: Hive Issue Type: Bug Reporter: Krishna Kumar Assignee: Krishna Kumar Priority: Minor Fix For: 0.8.0 Attachments: HIVE.2098.patch.0.txt readMetaData() and createExportDump() to be public -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2033) A database's warehouse.dir is not used for tables created in it.
[
https://issues.apache.org/jira/browse/HIVE-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13019263#comment-13019263
]
Amareshwari Sriramadasu commented on HIVE-2033:
---
Do you want close this in favor of HIVE-1537?
A database's warehouse.dir is not used for tables created in it.
Key: HIVE-2033
URL: https://issues.apache.org/jira/browse/HIVE-2033
Project: Hive
Issue Type: Bug
Components: Clients, Metastore
Affects Versions: 0.7.0, 0.8.0
Reporter: Thiruvel Thirumoolan
Assignee: Thiruvel Thirumoolan
Fix For: 0.8.0
Attachments: HIVE-2033_prelim.patch
$ create database db with dbproperties ('hive.metastore.warehouse.dir' =
'loc');
$ use db;
$ create table test(name string);
Table 'test's location is not under 'loc'. Instead its under hive-site.xml's
warehouse dir.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Build failed in Jenkins: Hive-0.7.0-h0.20 #75
See https://hudson.apache.org/hudson/job/Hive-0.7.0-h0.20/75/ -- Started by timer Building remotely on ubuntu1 FATAL: cannot assign instance of hudson.model.StreamBuildListener to field hudson.scm.subversion.WorkspaceUpdater$UpdateTask.listener of type hudson.model.TaskListener in instance of hudson.scm.SubversionSCM$CheckOutTask java.lang.ClassCastException: cannot assign instance of hudson.model.StreamBuildListener to field hudson.scm.subversion.WorkspaceUpdater$UpdateTask.listener of type hudson.model.TaskListener in instance of hudson.scm.SubversionSCM$CheckOutTask at java.io.ObjectStreamClass$FieldReflector.setObjFieldValues(ObjectStreamClass.java:2056) at java.io.ObjectStreamClass.setObjFieldValues(ObjectStreamClass.java:1229) at java.io.ObjectInputStream.defaultReadFields(ObjectInputStream.java:1969) at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:1887) at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1770) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1346) at java.io.ObjectInputStream.defaultReadFields(ObjectInputStream.java:1963) at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:1887) at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1770) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1346) at java.io.ObjectInputStream.readObject(ObjectInputStream.java:368) at hudson.remoting.UserRequest.deserialize(UserRequest.java:178) at hudson.remoting.UserRequest.perform(UserRequest.java:98) at hudson.remoting.UserRequest.perform(UserRequest.java:48) at hudson.remoting.Request$2.run(Request.java:270) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334) at java.util.concurrent.FutureTask.run(FutureTask.java:166) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) at java.lang.Thread.run(Thread.java:636)
Build failed in Jenkins: Hive-trunk-h0.20 #669
See https://hudson.apache.org/hudson/job/Hive-trunk-h0.20/669/ -- Started by timer Building remotely on ubuntu1 FATAL: cannot assign instance of hudson.model.StreamBuildListener to field hudson.scm.subversion.WorkspaceUpdater$UpdateTask.listener of type hudson.model.TaskListener in instance of hudson.scm.SubversionSCM$CheckOutTask java.lang.ClassCastException: cannot assign instance of hudson.model.StreamBuildListener to field hudson.scm.subversion.WorkspaceUpdater$UpdateTask.listener of type hudson.model.TaskListener in instance of hudson.scm.SubversionSCM$CheckOutTask at java.io.ObjectStreamClass$FieldReflector.setObjFieldValues(ObjectStreamClass.java:2056) at java.io.ObjectStreamClass.setObjFieldValues(ObjectStreamClass.java:1229) at java.io.ObjectInputStream.defaultReadFields(ObjectInputStream.java:1969) at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:1887) at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1770) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1346) at java.io.ObjectInputStream.defaultReadFields(ObjectInputStream.java:1963) at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:1887) at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1770) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1346) at java.io.ObjectInputStream.readObject(ObjectInputStream.java:368) at hudson.remoting.UserRequest.deserialize(UserRequest.java:178) at hudson.remoting.UserRequest.perform(UserRequest.java:98) at hudson.remoting.UserRequest.perform(UserRequest.java:48) at hudson.remoting.Request$2.run(Request.java:270) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334) at java.util.concurrent.FutureTask.run(FutureTask.java:166) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) at java.lang.Thread.run(Thread.java:636)
[jira] [Commented] (HIVE-2109) No lock for some non-mapred tasks.
[ https://issues.apache.org/jira/browse/HIVE-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13019535#comment-13019535 ] He Yongqiang commented on HIVE-2109: It is not easy to add a testcase for it. So i manually tested it. No lock for some non-mapred tasks. -- Key: HIVE-2109 URL: https://issues.apache.org/jira/browse/HIVE-2109 Project: Hive Issue Type: Improvement Reporter: He Yongqiang Assignee: He Yongqiang Attachments: HIVE-2109.1.patch, HIVE-2109.2.patch do not do lock for some DDLTask or data move task. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2109) No lock for some non-mapred tasks.
[ https://issues.apache.org/jira/browse/HIVE-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] He Yongqiang updated HIVE-2109: --- Status: Patch Available (was: Open) No lock for some non-mapred tasks. -- Key: HIVE-2109 URL: https://issues.apache.org/jira/browse/HIVE-2109 Project: Hive Issue Type: Improvement Reporter: He Yongqiang Assignee: He Yongqiang Attachments: HIVE-2109.1.patch, HIVE-2109.2.patch do not do lock for some DDLTask or data move task. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HIVE-2112) Add more debugging information in LOCKs
[ https://issues.apache.org/jira/browse/HIVE-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Namit Jain reassigned HIVE-2112: Assignee: He Yongqiang Add more debugging information in LOCKs --- Key: HIVE-2112 URL: https://issues.apache.org/jira/browse/HIVE-2112 Project: Hive Issue Type: Improvement Reporter: Namit Jain Assignee: He Yongqiang It would be useful to log the processId, the hostName, the userName of the hive client which acquired the lock. Currently, only the queryId is logged, which makes it difficult for debugging. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HIVE-2112) Add more debugging information in LOCKs
Add more debugging information in LOCKs --- Key: HIVE-2112 URL: https://issues.apache.org/jira/browse/HIVE-2112 Project: Hive Issue Type: Improvement Reporter: Namit Jain It would be useful to log the processId, the hostName, the userName of the hive client which acquired the lock. Currently, only the queryId is logged, which makes it difficult for debugging. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2090) Add DROP DATABASE ... FORCE
[ https://issues.apache.org/jira/browse/HIVE-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13019621#comment-13019621 ] He Yongqiang commented on HIVE-2090: carl, can you help review and commit this patch? Add DROP DATABASE ... FORCE - Key: HIVE-2090 URL: https://issues.apache.org/jira/browse/HIVE-2090 Project: Hive Issue Type: New Feature Components: Metastore Reporter: Siying Dong Assignee: Siying Dong Priority: Minor Attachments: HIVE-2090.1.patch, HIVE-2090.2.patch, HIVE-2090.3.patch, HIVE-2090.4.patch, HIVE-2090.5.patch A DROP DATABASE ... FORCE will be useful, when we use a database for isolation when doing some tests. Being able to force cleaning up the database will make test cleaning up easier. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Review Request: HIVE-2090: Add DROP DATABASE ... FORCE
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/551/ --- (Updated 2011-04-14 00:17:09.44) Review request for hive. Changes --- Updating diff with https://issues.apache.org/jira/secure/attachment/12476199/HIVE-2090.5.patch Summary (updated) --- https://issues.apache.org/jira/secure/attachment/12476199/HIVE-2090.5.patch This addresses bug HIVE-2090. https://issues.apache.org/jira/browse/HIVE-2090 Diffs (updated) - trunk/metastore/if/hive_metastore.thrift 1091617 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1091617 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1091617 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1091617 trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1091617 trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1091617 trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1091617 trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1091617 trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1091617 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1091617 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1091617 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1091617 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1091617 trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1091617 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1091617 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1091617 trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DropDatabaseDesc.java 1091617 trunk/ql/src/test/queries/clientpositive/database.q 1091617 trunk/ql/src/test/results/clientpositive/database.q.out 1091617 Diff: https://reviews.apache.org/r/551/diff Testing --- Thanks, Carl
[jira] [Commented] (HIVE-2090) Add DROP DATABASE ... FORCE
[ https://issues.apache.org/jira/browse/HIVE-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13019622#comment-13019622 ] jirapos...@reviews.apache.org commented on HIVE-2090: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/551/ --- (Updated 2011-04-14 00:17:09.44) Review request for hive. Changes --- Updating diff with https://issues.apache.org/jira/secure/attachment/12476199/HIVE-2090.5.patch Summary (updated) --- https://issues.apache.org/jira/secure/attachment/12476199/HIVE-2090.5.patch This addresses bug HIVE-2090. https://issues.apache.org/jira/browse/HIVE-2090 Diffs (updated) - trunk/metastore/if/hive_metastore.thrift 1091617 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1091617 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1091617 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1091617 trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1091617 trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1091617 trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1091617 trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1091617 trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1091617 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1091617 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1091617 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1091617 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1091617 trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1091617 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1091617 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1091617 trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DropDatabaseDesc.java 1091617 trunk/ql/src/test/queries/clientpositive/database.q 1091617 trunk/ql/src/test/results/clientpositive/database.q.out 1091617 Diff: https://reviews.apache.org/r/551/diff Testing --- Thanks, Carl Add DROP DATABASE ... FORCE - Key: HIVE-2090 URL: https://issues.apache.org/jira/browse/HIVE-2090 Project: Hive Issue Type: New Feature Components: Metastore Reporter: Siying Dong Assignee: Siying Dong Priority: Minor Attachments: HIVE-2090.1.patch, HIVE-2090.2.patch, HIVE-2090.3.patch, HIVE-2090.4.patch, HIVE-2090.5.patch A DROP DATABASE ... FORCE will be useful, when we use a database for isolation when doing some tests. Being able to force cleaning up the database will make test cleaning up easier. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2090) Add DROP DATABASE ... FORCE
[ https://issues.apache.org/jira/browse/HIVE-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13019626#comment-13019626 ] Carl Steinbach commented on HIVE-2090: -- @Yongqiang: Will do. I updated the diff on reviewboard and will have comments ready by tomorrow. In the meantime, can we get an answer about the concerns I raised with modifying the Thrift IDL? I think adding a parameter to drop_database() breaks backwards compatibility with older versions since Thrift doesn't support method overloading. Can anyone confirm that this is accurate? Add DROP DATABASE ... FORCE - Key: HIVE-2090 URL: https://issues.apache.org/jira/browse/HIVE-2090 Project: Hive Issue Type: New Feature Components: Metastore Reporter: Siying Dong Assignee: Siying Dong Priority: Minor Attachments: HIVE-2090.1.patch, HIVE-2090.2.patch, HIVE-2090.3.patch, HIVE-2090.4.patch, HIVE-2090.5.patch A DROP DATABASE ... FORCE will be useful, when we use a database for isolation when doing some tests. Being able to force cleaning up the database will make test cleaning up easier. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2090) Add DROP DATABASE ... FORCE
[ https://issues.apache.org/jira/browse/HIVE-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13019641#comment-13019641 ] Siying Dong commented on HIVE-2090: --- Thrift should handle it automatically by adding a default value to missing parameter. I'll make change to make the new parameter optional anyway. I'll upload a new patch soon. Add DROP DATABASE ... FORCE - Key: HIVE-2090 URL: https://issues.apache.org/jira/browse/HIVE-2090 Project: Hive Issue Type: New Feature Components: Metastore Reporter: Siying Dong Assignee: Siying Dong Priority: Minor Attachments: HIVE-2090.1.patch, HIVE-2090.2.patch, HIVE-2090.3.patch, HIVE-2090.4.patch, HIVE-2090.5.patch A DROP DATABASE ... FORCE will be useful, when we use a database for isolation when doing some tests. Being able to force cleaning up the database will make test cleaning up easier. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2090) Add DROP DATABASE ... FORCE
[ https://issues.apache.org/jira/browse/HIVE-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13019644#comment-13019644 ] Carl Steinbach commented on HIVE-2090: -- So it sounds like downversion clients can talk to upversion servers, but what about the reverse? If the client sends a message that includes the force parameter, will a downversion server simply ignore the additional parameter? Add DROP DATABASE ... FORCE - Key: HIVE-2090 URL: https://issues.apache.org/jira/browse/HIVE-2090 Project: Hive Issue Type: New Feature Components: Metastore Reporter: Siying Dong Assignee: Siying Dong Priority: Minor Attachments: HIVE-2090.1.patch, HIVE-2090.2.patch, HIVE-2090.3.patch, HIVE-2090.4.patch, HIVE-2090.5.patch A DROP DATABASE ... FORCE will be useful, when we use a database for isolation when doing some tests. Being able to force cleaning up the database will make test cleaning up easier. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-1943) Metastore operations (like drop_partition) could be improved in terms of maintaining consistency of metadata and data
[ https://issues.apache.org/jira/browse/HIVE-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13019646#comment-13019646 ] jirapos...@reviews.apache.org commented on HIVE-1943: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/586/ --- (Updated 2011-04-14 00:57:35.688239) Review request for hive. Changes --- The new patch addresses Amareshwari's comments. The testcase is modified to do checks for write permissions for everyone in this patch (that will avoid the confusion that was created in the earlier patch where i was checking the owner write permissions only). Summary --- This is a patch to handle the issue described in HIVE-1943 This addresses bug HIVE-1943. https://issues.apache.org/jira/browse/HIVE-1943 Diffs (updated) - http://svn.apache.org/repos/asf/hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1091578 http://svn.apache.org/repos/asf/hive/trunk/conf/hive-default.xml 1091578 http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1091578 http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1091578 http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java 1091578 http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java PRE-CREATION http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java 1091578 http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20S/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java 1091578 http://svn.apache.org/repos/asf/hive/trunk/shims/src/common/java/org/apache/hadoop/hive/shims/HadoopShims.java 1091578 http://svn.apache.org/repos/asf/hive/trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1091578 Diff: https://reviews.apache.org/r/586/diff Testing --- Unit tests added. Thanks, Devaraj Metastore operations (like drop_partition) could be improved in terms of maintaining consistency of metadata and data - Key: HIVE-1943 URL: https://issues.apache.org/jira/browse/HIVE-1943 Project: Hive Issue Type: Bug Components: Metastore Reporter: Devaraj Das Assignee: Devaraj Das Currently, metastore operations with associated hdfs operations like drop_partition doesn't do a rollback if the hdfs operation fails. The metastore first updates the metadata, and then tries to do hdfs operation. If the hdfs operation fails for any reason, the data on the hdfs will be orphaned. We should improve the situation. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2090) Add DROP DATABASE ... FORCE
[ https://issues.apache.org/jira/browse/HIVE-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13019647#comment-13019647 ] Siying Dong commented on HIVE-2090: --- According to this doc: http://diwakergupta.github.com/thrift-missing-guide/ , adding an 'optional' keyword will solve the problem. However, when I tried to add it, it shows '[WARNING:/data/users/sdong/www/open-source-hive3/metastore/if/hive_metastore.thrift:212] optional keyword is ignored in argument lists.'. My guess is that it is automatically handled by Thrift. I'll double check with more people about it. Add DROP DATABASE ... FORCE - Key: HIVE-2090 URL: https://issues.apache.org/jira/browse/HIVE-2090 Project: Hive Issue Type: New Feature Components: Metastore Reporter: Siying Dong Assignee: Siying Dong Priority: Minor Attachments: HIVE-2090.1.patch, HIVE-2090.2.patch, HIVE-2090.3.patch, HIVE-2090.4.patch, HIVE-2090.5.patch A DROP DATABASE ... FORCE will be useful, when we use a database for isolation when doing some tests. Being able to force cleaning up the database will make test cleaning up easier. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2090) Add DROP DATABASE ... FORCE
[ https://issues.apache.org/jira/browse/HIVE-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13019651#comment-13019651 ] Siying Dong commented on HIVE-2090: --- I just checked with someone familiar with Thrift. For a higher version client calling RPC to a slower version server, the extra parameter will just be simply ignored. Add DROP DATABASE ... FORCE - Key: HIVE-2090 URL: https://issues.apache.org/jira/browse/HIVE-2090 Project: Hive Issue Type: New Feature Components: Metastore Reporter: Siying Dong Assignee: Siying Dong Priority: Minor Attachments: HIVE-2090.1.patch, HIVE-2090.2.patch, HIVE-2090.3.patch, HIVE-2090.4.patch, HIVE-2090.5.patch A DROP DATABASE ... FORCE will be useful, when we use a database for isolation when doing some tests. Being able to force cleaning up the database will make test cleaning up easier. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2090) Add DROP DATABASE ... FORCE
[ https://issues.apache.org/jira/browse/HIVE-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13019673#comment-13019673 ] Carl Steinbach commented on HIVE-2090: -- @Siying: The examples in that document seem only to apply to Thrift structs. It doesn't explicitly say that this also works with parameter lists. Can you try testing out the two scenarios (downversion client/upversion server and downversion server/upversion client) and let us know if they work? The section at the end that discusses Versioning/Compatibility talks about adding extra fields to structs, so maybe if this doesn't work we should try to transition to a Thrift API where each method takes a single struct as input, and just wrap the list of input parameters in that struct. Add DROP DATABASE ... FORCE - Key: HIVE-2090 URL: https://issues.apache.org/jira/browse/HIVE-2090 Project: Hive Issue Type: New Feature Components: Metastore Reporter: Siying Dong Assignee: Siying Dong Priority: Minor Attachments: HIVE-2090.1.patch, HIVE-2090.2.patch, HIVE-2090.3.patch, HIVE-2090.4.patch, HIVE-2090.5.patch A DROP DATABASE ... FORCE will be useful, when we use a database for isolation when doing some tests. Being able to force cleaning up the database will make test cleaning up easier. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HIVE-2113) In shell mode, local mode continues if a local-mode task throws exception in pre-hooks
In shell mode, local mode continues if a local-mode task throws exception in pre-hooks -- Key: HIVE-2113 URL: https://issues.apache.org/jira/browse/HIVE-2113 Project: Hive Issue Type: Bug Reporter: Siying Dong Assignee: Siying Dong In Driver.execute(), if exception is thrown in prehooks, the execution jumps to the exception handling logic and skips the step of ctx.restoreOriginalTracker(). As a result, the next query will be executed as local mode no matter input size since the job tracker setting is not reverted. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2113) In shell mode, local mode continues if a local-mode task throws exception in pre-hooks
[ https://issues.apache.org/jira/browse/HIVE-2113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siying Dong updated HIVE-2113: -- Attachment: HIVE-2113.1.patch In shell mode, local mode continues if a local-mode task throws exception in pre-hooks -- Key: HIVE-2113 URL: https://issues.apache.org/jira/browse/HIVE-2113 Project: Hive Issue Type: Bug Reporter: Siying Dong Assignee: Siying Dong Attachments: HIVE-2113.1.patch In Driver.execute(), if exception is thrown in prehooks, the execution jumps to the exception handling logic and skips the step of ctx.restoreOriginalTracker(). As a result, the next query will be executed as local mode no matter input size since the job tracker setting is not reverted. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2113) In shell mode, local mode continues if a local-mode task throws exception in pre-hooks
[ https://issues.apache.org/jira/browse/HIVE-2113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13019697#comment-13019697 ] Ning Zhang commented on HIVE-2113: -- +1 In shell mode, local mode continues if a local-mode task throws exception in pre-hooks -- Key: HIVE-2113 URL: https://issues.apache.org/jira/browse/HIVE-2113 Project: Hive Issue Type: Bug Reporter: Siying Dong Assignee: Siying Dong Attachments: HIVE-2113.1.patch In Driver.execute(), if exception is thrown in prehooks, the execution jumps to the exception handling logic and skips the step of ctx.restoreOriginalTracker(). As a result, the next query will be executed as local mode no matter input size since the job tracker setting is not reverted. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-1943) Metastore operations (like drop_partition) could be improved in terms of maintaining consistency of metadata and data
[ https://issues.apache.org/jira/browse/HIVE-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13019698#comment-13019698 ] jirapos...@reviews.apache.org commented on HIVE-1943: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/586/#review459 --- Ship it! +1 Please upload the patch to jira. - Amareshwari On 2011-04-14 00:57:35, Devaraj Das wrote: bq. bq. --- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/586/ bq. --- bq. bq. (Updated 2011-04-14 00:57:35) bq. bq. bq. Review request for hive. bq. bq. bq. Summary bq. --- bq. bq. This is a patch to handle the issue described in HIVE-1943 bq. bq. bq. This addresses bug HIVE-1943. bq. https://issues.apache.org/jira/browse/HIVE-1943 bq. bq. bq. Diffs bq. - bq. bq. http://svn.apache.org/repos/asf/hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1091578 bq.http://svn.apache.org/repos/asf/hive/trunk/conf/hive-default.xml 1091578 bq. http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1091578 bq. http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1091578 bq. http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java 1091578 bq. http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java PRE-CREATION bq. http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java 1091578 bq. http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20S/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java 1091578 bq. http://svn.apache.org/repos/asf/hive/trunk/shims/src/common/java/org/apache/hadoop/hive/shims/HadoopShims.java 1091578 bq. http://svn.apache.org/repos/asf/hive/trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1091578 bq. bq. Diff: https://reviews.apache.org/r/586/diff bq. bq. bq. Testing bq. --- bq. bq. Unit tests added. bq. bq. bq. Thanks, bq. bq. Devaraj bq. bq. Metastore operations (like drop_partition) could be improved in terms of maintaining consistency of metadata and data - Key: HIVE-1943 URL: https://issues.apache.org/jira/browse/HIVE-1943 Project: Hive Issue Type: Bug Components: Metastore Reporter: Devaraj Das Assignee: Devaraj Das Currently, metastore operations with associated hdfs operations like drop_partition doesn't do a rollback if the hdfs operation fails. The metastore first updates the metadata, and then tries to do hdfs operation. If the hdfs operation fails for any reason, the data on the hdfs will be orphaned. We should improve the situation. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-1943) Metastore operations (like drop_partition) could be improved in terms of maintaining consistency of metadata and data
[ https://issues.apache.org/jira/browse/HIVE-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devaraj Das updated HIVE-1943: -- Fix Version/s: 0.8.0 Metastore operations (like drop_partition) could be improved in terms of maintaining consistency of metadata and data - Key: HIVE-1943 URL: https://issues.apache.org/jira/browse/HIVE-1943 Project: Hive Issue Type: Bug Components: Metastore Reporter: Devaraj Das Assignee: Devaraj Das Fix For: 0.8.0 Attachments: hive-metastore-auth.patch Currently, metastore operations with associated hdfs operations like drop_partition doesn't do a rollback if the hdfs operation fails. The metastore first updates the metadata, and then tries to do hdfs operation. If the hdfs operation fails for any reason, the data on the hdfs will be orphaned. We should improve the situation. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-1943) Metastore operations (like drop_partition) could be improved in terms of maintaining consistency of metadata and data
[ https://issues.apache.org/jira/browse/HIVE-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devaraj Das updated HIVE-1943: -- Attachment: hive-metastore-auth.patch Attaching the patch that I uploaded last on reviewboard. Metastore operations (like drop_partition) could be improved in terms of maintaining consistency of metadata and data - Key: HIVE-1943 URL: https://issues.apache.org/jira/browse/HIVE-1943 Project: Hive Issue Type: Bug Components: Metastore Reporter: Devaraj Das Assignee: Devaraj Das Fix For: 0.8.0 Attachments: hive-metastore-auth.patch Currently, metastore operations with associated hdfs operations like drop_partition doesn't do a rollback if the hdfs operation fails. The metastore first updates the metadata, and then tries to do hdfs operation. If the hdfs operation fails for any reason, the data on the hdfs will be orphaned. We should improve the situation. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
