[jira] [Commented] (HIVE-2155) Improve error messages emitted during semantic analysis

2011-05-16 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034596#comment-13034596
 ] 

Hudson commented on HIVE-2155:
--

Integrated in Hive-trunk-h0.20 #732 (See 
[https://builds.apache.org/hudson/job/Hive-trunk-h0.20/732/])
HIVE-2155. Improve error messages emitted during semantic analysis
(Syed Albiz via jvs)


> Improve error messages emitted during semantic analysis
> ---
>
> Key: HIVE-2155
> URL: https://issues.apache.org/jira/browse/HIVE-2155
> Project: Hive
>  Issue Type: Improvement
>Reporter: Syed S. Albiz
>Assignee: Syed S. Albiz
> Fix For: 0.8.0
>
> Attachments: HIVE-2155.1.patch, HIVE-2155.2.patch, HIVE-2155.3.patch, 
> HIVE-2155.4.patch, HIVE-2155.5.patch
>
>
> Follow-up to HIVE-1731.
> A number of issues raised in HIVE-1731 were caused by SemanticAnalyzer not 
> reporting errors correctly.
> Specifically, the following issues need to be addressed:
> - Line numbers are not always provided and sometimes emitted as (0:-1), which 
> is useless
> - Insufficient or unclear context strings are provided
> Specific issues described in HIVE-1731:
> FAILED: Error in semantic analysis: Schema of both sides of union should 
> match: destinationid:_col1 _col2
> * No line/col numbers, context strings provide internal aliases instead of 
> actual column names
> FAILED: Error in semantic analysis: line 0:-1 Both Left and Right Aliases 
> Encountered in Join time
> * Incorrect line/col number info, no context strings to describe the aliases 
> encountered
> FAILED: Error in semantic analysis: AS clause has an invalid number of aliases
> * No line/col numbers, not context string to show the aliases encountered
> FAILED: Error in semantic analysis: line 1:94 Expression Not In Group By Key a
> * testcase: SELECT a.id, VAR(a.cnt) FROM mytable a
> * Context string is unhelpful, needs to provide the actual expression, not 
> just the table reference

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-2096) throw a error if the input is larger than a threshold for index input format

2011-05-16 Thread Wojciech Galuba (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HIVE-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wojciech Galuba updated HIVE-2096:
--

Attachment: HIVE-2096.4.patch.txt

Another SVN diff, now with all the files.

> throw a error if the input is larger than a threshold for index input format
> 
>
> Key: HIVE-2096
> URL: https://issues.apache.org/jira/browse/HIVE-2096
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 0.8.0
>Reporter: Namit Jain
> Attachments: HIVE-2096.1.patch.txt, HIVE-2096.2.patch.txt, 
> HIVE-2096.3.patch.txt, HIVE-2096.4.patch.txt
>
>
> This can hang for ever.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-1694) Accelerate GROUP BY execution using indexes

2011-05-16 Thread Prajakta Kalmegh (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034533#comment-13034533
 ] 

Prajakta Kalmegh commented on HIVE-1694:


That would be great. Thanks.

> Accelerate GROUP BY execution using indexes
> ---
>
> Key: HIVE-1694
> URL: https://issues.apache.org/jira/browse/HIVE-1694
> Project: Hive
>  Issue Type: New Feature
>  Components: Indexing, Query Processor
>Affects Versions: 0.7.0
>Reporter: Nikhil Deshpande
>Assignee: Prajakta Kalmegh
> Attachments: HIVE-1694.1.patch.txt, HIVE-1694.2.patch.txt, 
> HIVE-1694.3.patch.txt, HIVE-1694_2010-10-28.diff, demo_q1.hql, demo_q2.hql
>
>
> The index building patch (Hive-417) is checked into trunk, this JIRA issue 
> tracks supporting indexes in Hive compiler & execution engine for SELECT 
> queries.
> This is in ref. to John's comment at
> https://issues.apache.org/jira/browse/HIVE-417?focusedCommentId=12884869&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12884869
> on creating separate JIRA issue for tracking index usage in optimizer & query 
> execution.
> The aim of this effort is to use indexes to accelerate query execution (for 
> certain class of queries). E.g.
> - Filters and range scans (already being worked on by He Yongqiang as part of 
> HIVE-417?)
> - Joins (index based joins)
> - Group By, Order By and other misc cases
> The proposal is multi-step:
> 1. Building index based operators, compiler and execution engine changes
> 2. Optimizer enhancements (e.g. cost-based optimizer to compare and choose 
> between index scans, full table scans etc.)
> This JIRA initially focuses on the first step. This JIRA is expected to hold 
> the information about index based plans & operator implementations for above 
> mentioned cases. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-2096) throw a error if the input is larger than a threshold for index input format

2011-05-16 Thread Wojciech Galuba (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HIVE-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wojciech Galuba updated HIVE-2096:
--

Status: Patch Available  (was: Open)

The patch is now from svn diff.

> throw a error if the input is larger than a threshold for index input format
> 
>
> Key: HIVE-2096
> URL: https://issues.apache.org/jira/browse/HIVE-2096
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 0.8.0
>Reporter: Namit Jain
> Attachments: HIVE-2096.1.patch.txt, HIVE-2096.2.patch.txt, 
> HIVE-2096.3.patch.txt
>
>
> This can hang for ever.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-2096) throw a error if the input is larger than a threshold for index input format

2011-05-16 Thread Wojciech Galuba (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HIVE-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wojciech Galuba updated HIVE-2096:
--

Attachment: HIVE-2096.3.patch.txt

> throw a error if the input is larger than a threshold for index input format
> 
>
> Key: HIVE-2096
> URL: https://issues.apache.org/jira/browse/HIVE-2096
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 0.8.0
>Reporter: Namit Jain
> Attachments: HIVE-2096.1.patch.txt, HIVE-2096.2.patch.txt, 
> HIVE-2096.3.patch.txt
>
>
> This can hang for ever.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-1095) Hive in Maven

2011-05-16 Thread Amareshwari Sriramadasu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034518#comment-13034518
 ] 

Amareshwari Sriramadasu commented on HIVE-1095:
---

Thanks Carl. Will take a look at the patch.

> Hive in Maven
> -
>
> Key: HIVE-1095
> URL: https://issues.apache.org/jira/browse/HIVE-1095
> Project: Hive
>  Issue Type: Task
>  Components: Build Infrastructure
>Affects Versions: 0.6.0
>Reporter: Gerrit Jansen van Vuuren
>Priority: Minor
> Fix For: 0.7.1
>
> Attachments: HIVE-1095-trunk.patch, HIVE-1095.7.patch.txt, 
> HIVE-1095.v2.PATCH, HIVE-1095.v3.PATCH, HIVE-1095.v4.PATCH, 
> HIVE-1095.v5.PATCH, HIVE-1095.v6.patch, hiveReleasedToMaven.tar.gz, 
> make-maven.log
>
>
> Getting hive into maven main repositories
> Documentation on how to do this is on:
> http://maven.apache.org/guides/mini/guide-central-repository-upload.html

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-2155) Improve error messages emitted during semantic analysis

2011-05-16 Thread John Sichi (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HIVE-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Sichi updated HIVE-2155:
-

   Resolution: Fixed
Fix Version/s: 0.8.0
 Hadoop Flags: [Reviewed]
   Status: Resolved  (was: Patch Available)

Committed.  Thanks Syed!

> Improve error messages emitted during semantic analysis
> ---
>
> Key: HIVE-2155
> URL: https://issues.apache.org/jira/browse/HIVE-2155
> Project: Hive
>  Issue Type: Improvement
>Reporter: Syed S. Albiz
>Assignee: Syed S. Albiz
> Fix For: 0.8.0
>
> Attachments: HIVE-2155.1.patch, HIVE-2155.2.patch, HIVE-2155.3.patch, 
> HIVE-2155.4.patch, HIVE-2155.5.patch
>
>
> Follow-up to HIVE-1731.
> A number of issues raised in HIVE-1731 were caused by SemanticAnalyzer not 
> reporting errors correctly.
> Specifically, the following issues need to be addressed:
> - Line numbers are not always provided and sometimes emitted as (0:-1), which 
> is useless
> - Insufficient or unclear context strings are provided
> Specific issues described in HIVE-1731:
> FAILED: Error in semantic analysis: Schema of both sides of union should 
> match: destinationid:_col1 _col2
> * No line/col numbers, context strings provide internal aliases instead of 
> actual column names
> FAILED: Error in semantic analysis: line 0:-1 Both Left and Right Aliases 
> Encountered in Join time
> * Incorrect line/col number info, no context strings to describe the aliases 
> encountered
> FAILED: Error in semantic analysis: AS clause has an invalid number of aliases
> * No line/col numbers, not context string to show the aliases encountered
> FAILED: Error in semantic analysis: line 1:94 Expression Not In Group By Key a
> * testcase: SELECT a.id, VAR(a.cnt) FROM mytable a
> * Context string is unhelpful, needs to provide the actual expression, not 
> just the table reference

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-1095) Hive in Maven

2011-05-16 Thread Carl Steinbach (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HIVE-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carl Steinbach updated HIVE-1095:
-

Attachment: HIVE-1095.7.patch.txt

HIVE-1095.7.patch.txt:

* Remove LICENSE-2.0.txt
* Use Ivy to resolve maven-ant-tasks dependency.
* Move some of the new maven targets into build-common.xml
* Change the names of the user visible maven targets to "maven-build" and 
"maven-publish", and add descriptions for both.
* Fixed the module fields in each of the */ivy.xml files.

I verified that I can publish snapshots to the asf repo with this patch in 
place.

> Hive in Maven
> -
>
> Key: HIVE-1095
> URL: https://issues.apache.org/jira/browse/HIVE-1095
> Project: Hive
>  Issue Type: Task
>  Components: Build Infrastructure
>Affects Versions: 0.6.0
>Reporter: Gerrit Jansen van Vuuren
>Priority: Minor
> Fix For: 0.7.1
>
> Attachments: HIVE-1095-trunk.patch, HIVE-1095.7.patch.txt, 
> HIVE-1095.v2.PATCH, HIVE-1095.v3.PATCH, HIVE-1095.v4.PATCH, 
> HIVE-1095.v5.PATCH, HIVE-1095.v6.patch, hiveReleasedToMaven.tar.gz, 
> make-maven.log
>
>
> Getting hive into maven main repositories
> Documentation on how to do this is on:
> http://maven.apache.org/guides/mini/guide-central-repository-upload.html

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: Review Request: HIVE-1095 Hive in maven

2011-05-16 Thread Carl Steinbach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/740/#review668
---



trunk/LICENSE-2.0.txt


There's already a "LICENSE" file in the rootdir. This file should be 
removed.



trunk/ant/ivy.xml


Module name should be "hive-anttasks"



trunk/build.xml


We should resolve this dependency using Ivy.



trunk/build.xml


TAB



trunk/build.xml


This should probably go build-common.xml instead of here.



trunk/cli/ivy.xml


Module name should be "hive-cli". Same deal for all of the other */ivy.xml 
files.


- Carl


On 2011-05-13 06:33:44, Amareshwari Sriramadasu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/740/
> ---
> 
> (Updated 2011-05-13 06:33:44)
> 
> 
> Review request for hive and Carl Steinbach.
> 
> 
> Summary
> ---
> 
> 
> This addresses bug HIVE-1095.
> https://issues.apache.org/jira/browse/HIVE-1095
> 
> 
> Diffs
> -
> 
>   trunk/LICENSE-2.0.txt PRE-CREATION 
>   trunk/ant/ivy.xml 1095392 
>   trunk/build-common.xml 1095392 
>   trunk/build.xml 1095392 
>   trunk/cli/ivy.xml 1095392 
>   trunk/common/ivy.xml 1095392 
>   trunk/contrib/ivy.xml 1095392 
>   trunk/hbase-handler/ivy.xml 1095392 
>   trunk/hwi/ivy.xml 1095392 
>   trunk/ivy.xml 1095392 
>   trunk/jdbc/ivy.xml PRE-CREATION 
>   trunk/metastore/ivy.xml 1095392 
>   trunk/ql/ivy.xml 1095392 
>   trunk/serde/ivy.xml 1095392 
>   trunk/service/ivy.xml PRE-CREATION 
>   trunk/shims/ivy.xml 1095392 
> 
> Diff: https://reviews.apache.org/r/740/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Amareshwari
> 
>

[jira] [Commented] (HIVE-2155) Improve error messages emitted during semantic analysis

2011-05-16 Thread John Sichi (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034322#comment-13034322
 ] 

John Sichi commented on HIVE-2155:
--

+1.  Will commit when tests pass.


> Improve error messages emitted during semantic analysis
> ---
>
> Key: HIVE-2155
> URL: https://issues.apache.org/jira/browse/HIVE-2155
> Project: Hive
>  Issue Type: Improvement
>Reporter: Syed S. Albiz
>Assignee: Syed S. Albiz
> Attachments: HIVE-2155.1.patch, HIVE-2155.2.patch, HIVE-2155.3.patch, 
> HIVE-2155.4.patch, HIVE-2155.5.patch
>
>
> Follow-up to HIVE-1731.
> A number of issues raised in HIVE-1731 were caused by SemanticAnalyzer not 
> reporting errors correctly.
> Specifically, the following issues need to be addressed:
> - Line numbers are not always provided and sometimes emitted as (0:-1), which 
> is useless
> - Insufficient or unclear context strings are provided
> Specific issues described in HIVE-1731:
> FAILED: Error in semantic analysis: Schema of both sides of union should 
> match: destinationid:_col1 _col2
> * No line/col numbers, context strings provide internal aliases instead of 
> actual column names
> FAILED: Error in semantic analysis: line 0:-1 Both Left and Right Aliases 
> Encountered in Join time
> * Incorrect line/col number info, no context strings to describe the aliases 
> encountered
> FAILED: Error in semantic analysis: AS clause has an invalid number of aliases
> * No line/col numbers, not context string to show the aliases encountered
> FAILED: Error in semantic analysis: line 1:94 Expression Not In Group By Key a
> * testcase: SELECT a.id, VAR(a.cnt) FROM mytable a
> * Context string is unhelpful, needs to provide the actual expression, not 
> just the table reference

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-2029) MetaStore ConnectionURL updates need to trigger creation of Default DB if it doesn't exist

2011-05-16 Thread Ashutosh Chauhan (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034294#comment-13034294
 ] 

Ashutosh Chauhan commented on HIVE-2029:


My question didn't get any answers. So, let me ask another question. I think 
failover is present in datanucleus  3.0 and Hive is still on 2.x. So, that may 
be the reason that Hive implemented its own failover. If this is correct, shall 
we first upgrade Datanucleus version to 3.x and then switch to Datanucleus 
functionality instead of our own retrials. If there is an agreement then patch 
on this ticket can be committed as is and I will open tickets for followup 
work. 

> MetaStore ConnectionURL updates need to trigger creation of Default DB if it 
> doesn't exist
> --
>
> Key: HIVE-2029
> URL: https://issues.apache.org/jira/browse/HIVE-2029
> Project: Hive
>  Issue Type: Bug
>  Components: Metastore
>Affects Versions: 0.7.0
>Reporter: Carl Steinbach
> Attachments: hive_2029.patch
>
>
> HIVE-1219 defined the JDOConnectionURLHook plugin, and integrated this 
> feature into HiveMetaStore. On MetaStore operation failures, this plugin is 
> used to update the metastore ConnectionURL configuration property. Currently 
> this update triggers the reinitialization of the underlying JDO 
> PersistenceManager, but it does not trigger checks to see if the default 
> database exists, nor will it create the default database if it does not 
> exist. It needs to do both.
> This ticket also covers removing the 'hive.metastore.force.reload.conf' 
> property from HiveConf and HiveMetaStore. This property should not have been 
> added in the first place since its sole purpose is to facilitate testing of 
> the JDOConnectionURLHook mechanism by unnaturally forcing reinitialization of 
> the PersistenceManager.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-2155) Improve error messages emitted during semantic analysis

2011-05-16 Thread Syed S. Albiz (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HIVE-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Syed S. Albiz updated HIVE-2155:


Attachment: HIVE-2155.5.patch

Regenerate the TestParseNegative bucket, and modify the existing ugly testcases 
to use the new "Error encountered near" strings.

> Improve error messages emitted during semantic analysis
> ---
>
> Key: HIVE-2155
> URL: https://issues.apache.org/jira/browse/HIVE-2155
> Project: Hive
>  Issue Type: Improvement
>Reporter: Syed S. Albiz
>Assignee: Syed S. Albiz
> Attachments: HIVE-2155.1.patch, HIVE-2155.2.patch, HIVE-2155.3.patch, 
> HIVE-2155.4.patch, HIVE-2155.5.patch
>
>
> Follow-up to HIVE-1731.
> A number of issues raised in HIVE-1731 were caused by SemanticAnalyzer not 
> reporting errors correctly.
> Specifically, the following issues need to be addressed:
> - Line numbers are not always provided and sometimes emitted as (0:-1), which 
> is useless
> - Insufficient or unclear context strings are provided
> Specific issues described in HIVE-1731:
> FAILED: Error in semantic analysis: Schema of both sides of union should 
> match: destinationid:_col1 _col2
> * No line/col numbers, context strings provide internal aliases instead of 
> actual column names
> FAILED: Error in semantic analysis: line 0:-1 Both Left and Right Aliases 
> Encountered in Join time
> * Incorrect line/col number info, no context strings to describe the aliases 
> encountered
> FAILED: Error in semantic analysis: AS clause has an invalid number of aliases
> * No line/col numbers, not context string to show the aliases encountered
> FAILED: Error in semantic analysis: line 1:94 Expression Not In Group By Key a
> * testcase: SELECT a.id, VAR(a.cnt) FROM mytable a
> * Context string is unhelpful, needs to provide the actual expression, not 
> just the table reference

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-2155) Improve error messages emitted during semantic analysis

2011-05-16 Thread Syed S. Albiz (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HIVE-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Syed S. Albiz updated HIVE-2155:


Status: Patch Available  (was: Open)

> Improve error messages emitted during semantic analysis
> ---
>
> Key: HIVE-2155
> URL: https://issues.apache.org/jira/browse/HIVE-2155
> Project: Hive
>  Issue Type: Improvement
>Reporter: Syed S. Albiz
>Assignee: Syed S. Albiz
> Attachments: HIVE-2155.1.patch, HIVE-2155.2.patch, HIVE-2155.3.patch, 
> HIVE-2155.4.patch, HIVE-2155.5.patch
>
>
> Follow-up to HIVE-1731.
> A number of issues raised in HIVE-1731 were caused by SemanticAnalyzer not 
> reporting errors correctly.
> Specifically, the following issues need to be addressed:
> - Line numbers are not always provided and sometimes emitted as (0:-1), which 
> is useless
> - Insufficient or unclear context strings are provided
> Specific issues described in HIVE-1731:
> FAILED: Error in semantic analysis: Schema of both sides of union should 
> match: destinationid:_col1 _col2
> * No line/col numbers, context strings provide internal aliases instead of 
> actual column names
> FAILED: Error in semantic analysis: line 0:-1 Both Left and Right Aliases 
> Encountered in Join time
> * Incorrect line/col number info, no context strings to describe the aliases 
> encountered
> FAILED: Error in semantic analysis: AS clause has an invalid number of aliases
> * No line/col numbers, not context string to show the aliases encountered
> FAILED: Error in semantic analysis: line 1:94 Expression Not In Group By Key a
> * testcase: SELECT a.id, VAR(a.cnt) FROM mytable a
> * Context string is unhelpful, needs to provide the actual expression, not 
> just the table reference

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: Review Request: HIVE-2155 Improve error messages emitted during semantic analysis

2011-05-16 Thread Syed Albiz 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/731/
---

(Updated 2011-05-16 19:59:08.608664)


Review request for hive and John Sichi.


Changes
---

Updated more existing testcases to use new generateErrorMessage function to 
display the "Error encounted near " string.
Regenerated the TestParseNegative testcases as those were not updated in the 
last patch.


Summary
---

Attaches line/column number to the vast majority of SemanticExceptions thrown. 
In addition, the context strings for the error messages relating to UNION ALLs 
and GROUP BY keys have been changed to provide more meaningful context.


This addresses bug HIVE-2155.
https://issues.apache.org/jira/browse/HIVE-2155


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java dc96a1f 
  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 2fe37b6 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 4ddf5b9 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 9cb407c 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java bca37fd 
  ql/src/test/queries/clientnegative/union3.q PRE-CREATION 
  ql/src/test/results/clientnegative/analyze_view.q.out ef76106 
  ql/src/test/results/clientnegative/clusterbydistributeby.q.out 4c1ebfb 
  ql/src/test/results/clientnegative/clusterbysortby.q.out f76d4a7 
  ql/src/test/results/clientnegative/clustern3.q.out da71016 
  ql/src/test/results/clientnegative/clustern4.q.out 1519e48 
  ql/src/test/results/clientnegative/create_view_failure3.q.out 70e365a 
  ql/src/test/results/clientnegative/ctas.q.out a39fb7c 
  ql/src/test/results/clientnegative/ddltime.q.out 11d00c3 
  ql/src/test/results/clientnegative/drop_partition_failure.q.out 1a0ac10 
  ql/src/test/results/clientnegative/dyn_part2.q.out cc0cd3c 
  ql/src/test/results/clientnegative/dyn_part_merge.q.out cab97f7 
  ql/src/test/results/clientnegative/fileformat_void_input.q.out 5a7a05a 
  ql/src/test/results/clientnegative/groupby_key.q.out c6218a4 
  ql/src/test/results/clientnegative/input1.q.out 73f1657 
  ql/src/test/results/clientnegative/input2.q.out 0c460a6 
  ql/src/test/results/clientnegative/invalid_create_tbl1.q.out d091d8c 
  ql/src/test/results/clientnegative/invalid_t_alter1.q.out f7ae626 
  ql/src/test/results/clientnegative/invalid_t_alter2.q.out f7ae626 
  ql/src/test/results/clientnegative/invalid_t_create1.q.out d091d8c 
  ql/src/test/results/clientnegative/invalid_t_create2.q.out d091d8c 
  ql/src/test/results/clientnegative/invalid_t_create3.q.out d091d8c 
  ql/src/test/results/clientnegative/invalid_t_transform.q.out d091d8c 
  ql/src/test/results/clientnegative/invalidate_view1.q.out 9f61228 
  ql/src/test/results/clientnegative/joinneg.q.out d85d508 
  ql/src/test/results/clientnegative/line_terminator.q.out b672bd8 
  ql/src/test/results/clientnegative/load_part_nospec.q.out 251c7e1 
  ql/src/test/results/clientnegative/load_wrong_noof_part.q.out 4d8c8d8 
  ql/src/test/results/clientnegative/nopart_insert.q.out 42bca76 
  ql/src/test/results/clientnegative/nopart_load.q.out 31376c8 
  ql/src/test/results/clientnegative/notable_alias3.q.out d48d5e1 
  ql/src/test/results/clientnegative/orderbysortby.q.out 73b83a4 
  ql/src/test/results/clientnegative/regex_col_1.q.out 7547858 
  ql/src/test/results/clientnegative/regex_col_2.q.out f570010 
  ql/src/test/results/clientnegative/regex_col_groupby.q.out 8497718 
  ql/src/test/results/clientnegative/semijoin1.q.out 739931f 
  ql/src/test/results/clientnegative/semijoin2.q.out 2b418de 
  ql/src/test/results/clientnegative/semijoin3.q.out a803b50 
  ql/src/test/results/clientnegative/semijoin4.q.out 86a834b 
  ql/src/test/results/clientnegative/split_sample_out_of_range.q.out 0761955 
  ql/src/test/results/clientnegative/split_sample_wrong_format.q.out 19b1417 
  ql/src/test/results/clientnegative/strict_orderby.q.out 2d3ba6b 
  ql/src/test/results/clientnegative/subq_insert.q.out 8c3ce79 
  ql/src/test/results/clientnegative/udf_array_contains_wrong1.q.out d6b98b4 
  ql/src/test/results/clientnegative/udf_array_contains_wrong2.q.out 7b8dca6 
  ql/src/test/results/clientnegative/udf_case_type_wrong.q.out 75b9638 
  ql/src/test/results/clientnegative/udf_case_type_wrong2.q.out 126fa4e 
  ql/src/test/results/clientnegative/udf_case_type_wrong3.q.out fd62771 
  ql/src/test/results/clientnegative/udf_coalesce.q.out a5279f5 
  ql/src/test/results/clientnegative/udf_elt_wrong_args_len.q.out 22a085a 
  ql/src/test/results/clientnegative/udf_elt_wrong_type.q.out fc83f23 
  ql/src/test/results/clientnegative/udf_field_wrong_args_len.q.out 3bf97d9 
  ql/src/test/results/clientnegative/udf_field_wrong_type.q.out 2a2e944 
  ql/src/test/results/clientnegative/udf_if_not_bool.q.out a3c8902 
  ql/src/test/results/clientnegative/udf_if_wrong_args_len.q.out 8

[jira] [Assigned] (HIVE-2140) Return correct Major / Minor version numbers for Hive Driver

2011-05-16 Thread John Sichi (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HIVE-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Sichi reassigned HIVE-2140:


Assignee: Curtis Boyden

> Return correct Major / Minor version numbers for Hive Driver
> 
>
> Key: HIVE-2140
> URL: https://issues.apache.org/jira/browse/HIVE-2140
> Project: Hive
>  Issue Type: Sub-task
>  Components: JDBC
>Affects Versions: 0.6.0, 0.7.0
>Reporter: Curtis Boyden
>Assignee: Curtis Boyden
> Fix For: 0.7.1, 0.8.0
>
> Attachments: hive-0.6-driver-version.patch, 
> hive-0.7-driver-version.patch, hive-trunk-driver-version.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-1694) Accelerate GROUP BY execution using indexes

2011-05-16 Thread John Sichi (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034207#comment-13034207
 ] 

John Sichi commented on HIVE-1694:
--

Scheduled a meeting this Friday to take a look at this with some other FB folks 
and get you more feedback.

> Accelerate GROUP BY execution using indexes
> ---
>
> Key: HIVE-1694
> URL: https://issues.apache.org/jira/browse/HIVE-1694
> Project: Hive
>  Issue Type: New Feature
>  Components: Indexing, Query Processor
>Affects Versions: 0.7.0
>Reporter: Nikhil Deshpande
>Assignee: Prajakta Kalmegh
> Attachments: HIVE-1694.1.patch.txt, HIVE-1694.2.patch.txt, 
> HIVE-1694.3.patch.txt, HIVE-1694_2010-10-28.diff, demo_q1.hql, demo_q2.hql
>
>
> The index building patch (Hive-417) is checked into trunk, this JIRA issue 
> tracks supporting indexes in Hive compiler & execution engine for SELECT 
> queries.
> This is in ref. to John's comment at
> https://issues.apache.org/jira/browse/HIVE-417?focusedCommentId=12884869&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12884869
> on creating separate JIRA issue for tracking index usage in optimizer & query 
> execution.
> The aim of this effort is to use indexes to accelerate query execution (for 
> certain class of queries). E.g.
> - Filters and range scans (already being worked on by He Yongqiang as part of 
> HIVE-417?)
> - Joins (index based joins)
> - Group By, Order By and other misc cases
> The proposal is multi-step:
> 1. Building index based operators, compiler and execution engine changes
> 2. Optimizer enhancements (e.g. cost-based optimizer to compare and choose 
> between index scans, full table scans etc.)
> This JIRA initially focuses on the first step. This JIRA is expected to hold 
> the information about index based plans & operator implementations for above 
> mentioned cases. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-1694) Accelerate GROUP BY execution using indexes

2011-05-16 Thread John Sichi (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034181#comment-13034181
 ] 

John Sichi commented on HIVE-1694:
--

For the rebasing, you'll need to make your new handlers work with the 
refactored base classes.  HIVE-1803 copied some of your refactoring and took it 
further.

I'm going to ping Yongqiang again.


> Accelerate GROUP BY execution using indexes
> ---
>
> Key: HIVE-1694
> URL: https://issues.apache.org/jira/browse/HIVE-1694
> Project: Hive
>  Issue Type: New Feature
>  Components: Indexing, Query Processor
>Affects Versions: 0.7.0
>Reporter: Nikhil Deshpande
>Assignee: Prajakta Kalmegh
> Attachments: HIVE-1694.1.patch.txt, HIVE-1694.2.patch.txt, 
> HIVE-1694.3.patch.txt, HIVE-1694_2010-10-28.diff, demo_q1.hql, demo_q2.hql
>
>
> The index building patch (Hive-417) is checked into trunk, this JIRA issue 
> tracks supporting indexes in Hive compiler & execution engine for SELECT 
> queries.
> This is in ref. to John's comment at
> https://issues.apache.org/jira/browse/HIVE-417?focusedCommentId=12884869&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12884869
> on creating separate JIRA issue for tracking index usage in optimizer & query 
> execution.
> The aim of this effort is to use indexes to accelerate query execution (for 
> certain class of queries). E.g.
> - Filters and range scans (already being worked on by He Yongqiang as part of 
> HIVE-417?)
> - Joins (index based joins)
> - Group By, Order By and other misc cases
> The proposal is multi-step:
> 1. Building index based operators, compiler and execution engine changes
> 2. Optimizer enhancements (e.g. cost-based optimizer to compare and choose 
> between index scans, full table scans etc.)
> This JIRA initially focuses on the first step. This JIRA is expected to hold 
> the information about index based plans & operator implementations for above 
> mentioned cases. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-2155) Improve error messages emitted during semantic analysis

2011-05-16 Thread John Sichi (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034167#comment-13034167
 ] 

John Sichi commented on HIVE-2155:
--

I added *'s on a bunch of places that should be using the new "Encountered 
near" phrasing.

Also, the fugliness is still there for the GROUP BY stuff.  Those internal 
nodes should never be printed at all.  Did you look into trying to get it to 
print the column instead of the table?


> Improve error messages emitted during semantic analysis
> ---
>
> Key: HIVE-2155
> URL: https://issues.apache.org/jira/browse/HIVE-2155
> Project: Hive
>  Issue Type: Improvement
>Reporter: Syed S. Albiz
>Assignee: Syed S. Albiz
> Attachments: HIVE-2155.1.patch, HIVE-2155.2.patch, HIVE-2155.3.patch, 
> HIVE-2155.4.patch
>
>
> Follow-up to HIVE-1731.
> A number of issues raised in HIVE-1731 were caused by SemanticAnalyzer not 
> reporting errors correctly.
> Specifically, the following issues need to be addressed:
> - Line numbers are not always provided and sometimes emitted as (0:-1), which 
> is useless
> - Insufficient or unclear context strings are provided
> Specific issues described in HIVE-1731:
> FAILED: Error in semantic analysis: Schema of both sides of union should 
> match: destinationid:_col1 _col2
> * No line/col numbers, context strings provide internal aliases instead of 
> actual column names
> FAILED: Error in semantic analysis: line 0:-1 Both Left and Right Aliases 
> Encountered in Join time
> * Incorrect line/col number info, no context strings to describe the aliases 
> encountered
> FAILED: Error in semantic analysis: AS clause has an invalid number of aliases
> * No line/col numbers, not context string to show the aliases encountered
> FAILED: Error in semantic analysis: line 1:94 Expression Not In Group By Key a
> * testcase: SELECT a.id, VAR(a.cnt) FROM mytable a
> * Context string is unhelpful, needs to provide the actual expression, not 
> just the table reference

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: Review Request: HIVE-2155 Improve error messages emitted during semantic analysis

2011-05-16 Thread John Sichi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/731/#review674
---



ql/src/test/results/clientnegative/clusterbydistributeby.q.out


*




ql/src/test/results/clientnegative/clusterbysortby.q.out


*



ql/src/test/results/clientnegative/fileformat_void_input.q.out


*



ql/src/test/results/clientnegative/line_terminator.q.out


*



ql/src/test/results/clientnegative/orderbysortby.q.out


*



ql/src/test/results/clientnegative/strict_orderby.q.out


*



ql/src/test/results/compiler/errors/invalid_list_index.q.out


*



ql/src/test/results/compiler/errors/invalid_map_index.q.out


*



ql/src/test/results/compiler/errors/nonkey_groupby.q.out


This is still incredibly fugly.



ql/src/test/results/compiler/errors/wrong_distinct1.q.out


*


- John


On 2011-05-14 01:05:47, Syed Albiz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/731/
> ---
> 
> (Updated 2011-05-14 01:05:47)
> 
> 
> Review request for hive and John Sichi.
> 
> 
> Summary
> ---
> 
> Attaches line/column number to the vast majority of SemanticExceptions 
> thrown. In addition, the context strings for the error messages relating to 
> UNION ALLs and GROUP BY keys have been changed to provide more meaningful 
> context.
> 
> 
> This addresses bug HIVE-2155.
> https://issues.apache.org/jira/browse/HIVE-2155
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java dc96a1f 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 
> 2fe37b6 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 4ddf5b9 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 9cb407c 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 
> bca37fd 
>   ql/src/test/queries/clientnegative/union3.q PRE-CREATION 
>   ql/src/test/results/clientnegative/analyze_view.q.out ef76106 
>   ql/src/test/results/clientnegative/clusterbydistributeby.q.out 4c1ebfb 
>   ql/src/test/results/clientnegative/clusterbysortby.q.out f76d4a7 
>   ql/src/test/results/clientnegative/clustern3.q.out da71016 
>   ql/src/test/results/clientnegative/clustern4.q.out 1519e48 
>   ql/src/test/results/clientnegative/create_view_failure3.q.out 70e365a 
>   ql/src/test/results/clientnegative/ctas.q.out a39fb7c 
>   ql/src/test/results/clientnegative/ddltime.q.out 11d00c3 
>   ql/src/test/results/clientnegative/drop_partition_failure.q.out 1a0ac10 
>   ql/src/test/results/clientnegative/dyn_part2.q.out cc0cd3c 
>   ql/src/test/results/clientnegative/dyn_part_merge.q.out cab97f7 
>   ql/src/test/results/clientnegative/fileformat_void_input.q.out 5a7a05a 
>   ql/src/test/results/clientnegative/groupby_key.q.out c6218a4 
>   ql/src/test/results/clientnegative/input1.q.out 73f1657 
>   ql/src/test/results/clientnegative/input2.q.out 0c460a6 
>   ql/src/test/results/clientnegative/invalid_create_tbl1.q.out d091d8c 
>   ql/src/test/results/clientnegative/invalid_t_alter1.q.out f7ae626 
>   ql/src/test/results/clientnegative/invalid_t_alter2.q.out f7ae626 
>   ql/src/test/results/clientnegative/invalid_t_create1.q.out d091d8c 
>   ql/src/test/results/clientnegative/invalid_t_create2.q.out d091d8c 
>   ql/src/test/results/clientnegative/invalid_t_create3.q.out d091d8c 
>   ql/src/test/results/clientnegative/invalid_t_transform.q.out d091d8c 
>   ql/src/test/results/clientnegative/invalidate_view1.q.out 9f61228 
>   ql/src/test/results/clientnegative/joinneg.q.out d85d508 
>   ql/src/test/results/clientnegative/line_terminator.q.out b672bd8 
>   ql/src/test/results/clientnegative/load_part_nospec.q.out 251c7e1 
>   ql/src/test/results/clientnegative/load_wrong_noof_part.q.out 4d8c8d8 
>   ql/src/test/results/clientnegative/nopart_insert.q.out 42bca76 
>   ql/src/test/results/clientnegative/nopart_load.q.out 31376c8 
>   ql/src/test/results/clientnegative/notable_alias3.q.out d48d5e1 
>   ql/src/test/results/clientnegative/orderbysortby.q.out 73b83a4 
>   ql/src/test/results/clientnegative/regex_col_1.q.out 7547858 
>   ql/src/test/results/clientnegative/regex_col_2.q.out f570010 
>   ql/src/test/results/clientnegative/regex_col_groupby.q.out 8497718 
>   ql/src/test/results/clie

Re: Review Request: HIVE-243 - ^C breaks out of running query, but not whole CLI.

2011-05-16 Thread Ning Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/626/#review673
---

Ship it!


Looks good to me. George, can you rebase to the latest trunk and upload it to 
the JIRA? I'll start testing.


- Ning


On 2011-05-16 17:25:41, georgedj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/626/
> ---
> 
> (Updated 2011-05-16 17:25:41)
> 
> 
> Review request for hive.
> 
> 
> Summary
> ---
> 
> Fixed by adding INT signal hander that interrupts the CLI thread. The CLI 
> thread gets InterruptedException and it stops the current command.
> 
> 
> This addresses bug HIVE-243.
> https://issues.apache.org/jira/browse/HIVE-243
> 
> 
> Diffs
> -
> 
>   trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1100312 
>   
> trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptCallback.java
>  PRE-CREATION 
>   trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptUtils.java 
> PRE-CREATION 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java 
> 1100312 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1100312 
> 
> Diff: https://reviews.apache.org/r/626/diff
> 
> 
> Testing
> ---
> 
> Manual test Ctrl+C on bunch of command (show tables, select, etc)
> Tested interrupting the command on large data set in different stages of the 
> processing (JDO, MapReduce, building the input summary).
> example queries:
> explain select count(*) from xyz where ds = '2011-02-01';
> select count(*) from xyz where ds = '2011-02-01';
> 
> 
> Thanks,
> 
> georgedj
> 
>

Re: Review Request: HIVE-243 - ^C breaks out of running query, but not whole CLI.

2011-05-16 Thread djabarov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/626/
---

(Updated 2011-05-16 17:25:41.603093)


Review request for hive.


Changes
---

- Fixed function name typo.
- Updated inaccurate comment.
- Reverted all changes in ObjectStore.


Summary
---

Fixed by adding INT signal hander that interrupts the CLI thread. The CLI 
thread gets InterruptedException and it stops the current command.


This addresses bug HIVE-243.
https://issues.apache.org/jira/browse/HIVE-243


Diffs (updated)
-

  trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1100312 
  
trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptCallback.java 
PRE-CREATION 
  trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptUtils.java 
PRE-CREATION 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java 
1100312 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1100312 

Diff: https://reviews.apache.org/r/626/diff


Testing
---

Manual test Ctrl+C on bunch of command (show tables, select, etc)
Tested interrupting the command on large data set in different stages of the 
processing (JDO, MapReduce, building the input summary).
example queries:
explain select count(*) from xyz where ds = '2011-02-01';
select count(*) from xyz where ds = '2011-02-01';


Thanks,

georgedj

Re: Review Request: HIVE-243 - ^C breaks out of running query, but not whole CLI.

2011-05-16 Thread djabarov 


> On 2011-05-14 07:39:31, Ning Zhang wrote:
> > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java, 
> > line 1194
> > 
> >
> > We shouldn't check interrupt here since ObjectStore should be run at 
> > the metastore server side (if Hive is running non-local mode for 
> > metastore). So ^C on CLI won't be detected here. Instead we should check it 
> > in HiveMetaStoreClient.java. 
> > 
> > Since interrupting JDO is quite complicated, I suggest removing the 
> > interrupt handling for JDO completely in this JIRA and file a separate JIRA 
> > for that.

ok, reverting ObjectStore changes.


> On 2011-05-14 07:39:31, Ning Zhang wrote:
> > trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java, line 326
> > 
> >
> > Is this comment correct?

Nope, comment fixed.


- georgedj


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/626/#review670
---


On 2011-05-10 21:55:56, georgedj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/626/
> ---
> 
> (Updated 2011-05-10 21:55:56)
> 
> 
> Review request for hive.
> 
> 
> Summary
> ---
> 
> Fixed by adding INT signal hander that interrupts the CLI thread. The CLI 
> thread gets InterruptedException and it stops the current command.
> 
> 
> This addresses bug HIVE-243.
> https://issues.apache.org/jira/browse/HIVE-243
> 
> 
> Diffs
> -
> 
>   trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1100312 
>   
> trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptCallback.java
>  PRE-CREATION 
>   trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptUtils.java 
> PRE-CREATION 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 
> 1100312 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java 
> 1100312 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1100312 
> 
> Diff: https://reviews.apache.org/r/626/diff
> 
> 
> Testing
> ---
> 
> Manual test Ctrl+C on bunch of command (show tables, select, etc)
> Tested interrupting the command on large data set in different stages of the 
> processing (JDO, MapReduce, building the input summary).
> example queries:
> explain select count(*) from xyz where ds = '2011-02-01';
> select count(*) from xyz where ds = '2011-02-01';
> 
> 
> Thanks,
> 
> georgedj
> 
>

Re: Review Request: HIVE-243 - ^C breaks out of running query, but not whole CLI.

2011-05-16 Thread djabarov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/626/#review671
---



trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java


The loop wrongly assumes that calling Thread.currentThread().interrupt() 
will throw ThreadInterrupted while it only sets interrupted flag on the thread. 
The result is infinite loop with executionDone never set to true. The loop is 
actually not needed as executor.shutdown() does the same thing - waits for all 
queued jobs to complete.


- georgedj


On 2011-05-10 21:55:56, georgedj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/626/
> ---
> 
> (Updated 2011-05-10 21:55:56)
> 
> 
> Review request for hive.
> 
> 
> Summary
> ---
> 
> Fixed by adding INT signal hander that interrupts the CLI thread. The CLI 
> thread gets InterruptedException and it stops the current command.
> 
> 
> This addresses bug HIVE-243.
> https://issues.apache.org/jira/browse/HIVE-243
> 
> 
> Diffs
> -
> 
>   trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1100312 
>   
> trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptCallback.java
>  PRE-CREATION 
>   trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptUtils.java 
> PRE-CREATION 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 
> 1100312 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java 
> 1100312 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1100312 
> 
> Diff: https://reviews.apache.org/r/626/diff
> 
> 
> Testing
> ---
> 
> Manual test Ctrl+C on bunch of command (show tables, select, etc)
> Tested interrupting the command on large data set in different stages of the 
> processing (JDO, MapReduce, building the input summary).
> example queries:
> explain select count(*) from xyz where ds = '2011-02-01';
> select count(*) from xyz where ds = '2011-02-01';
> 
> 
> Thanks,
> 
> georgedj
> 
>

[jira] [Created] (HIVE-2167) Getting metadata after executing group by query is giving wrong meta data

2011-05-16 Thread Chinna Rao Lalam (JIRA) 
Getting metadata after executing group by query is giving wrong meta data
-

 Key: HIVE-2167
 URL: https://issues.apache.org/jira/browse/HIVE-2167
 Project: Hive
  Issue Type: Bug
  Components: Query Processor, Server Infrastructure
Affects Versions: 0.5.0, 0.8.0
 Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 
10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5).
Reporter: Chinna Rao Lalam


The following group by query returned wrong meta data

{noformat}

create table sampletable (key string,value string) PARTITIONED BY(dt STRING, 
country STRING) ROW FORMAT DELIMITED FIELDS TERMINATED BY '@';

LOAD DATA LOCAL INPATH '/home/data/details1.txt' OVERWRITE INTO TABLE 
sampletable partition (dt='21Oct',country='x');

select * from sampletable group by key,value;

"Meta Data :"+resutSet.getMetaData().getColumnName(1)+" --- Data 
:"+resutSet.getString(1)

{noformat}

*Ouput:*

"Meta Data :"+resutSet.getMetaData().getColumnName(1)+" --- Data 
:"+resutSet.getString(1)


Meta Data :(tok_table_or_col key)--- Data :122
Meta Data :(tok_table_or_col key)--- Data :123
Meta Data :(tok_table_or_col key)--- Data :124

*Expected Output:*

Meta Data : key --- Data :122
Meta Data : key --- Data :123
Meta Data : key --- Data :124

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-1694) Accelerate GROUP BY execution using indexes

2011-05-16 Thread Prajakta Kalmegh (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13033906#comment-13033906
 ] 

Prajakta Kalmegh commented on HIVE-1694:


Thanks John. Please let us know how to proceed on this. We are taking a look at 
the HIVE-1803 changes in the meanwhile.

> Accelerate GROUP BY execution using indexes
> ---
>
> Key: HIVE-1694
> URL: https://issues.apache.org/jira/browse/HIVE-1694
> Project: Hive
>  Issue Type: New Feature
>  Components: Indexing, Query Processor
>Affects Versions: 0.7.0
>Reporter: Nikhil Deshpande
>Assignee: Prajakta Kalmegh
> Attachments: HIVE-1694.1.patch.txt, HIVE-1694.2.patch.txt, 
> HIVE-1694.3.patch.txt, HIVE-1694_2010-10-28.diff, demo_q1.hql, demo_q2.hql
>
>
> The index building patch (Hive-417) is checked into trunk, this JIRA issue 
> tracks supporting indexes in Hive compiler & execution engine for SELECT 
> queries.
> This is in ref. to John's comment at
> https://issues.apache.org/jira/browse/HIVE-417?focusedCommentId=12884869&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12884869
> on creating separate JIRA issue for tracking index usage in optimizer & query 
> execution.
> The aim of this effort is to use indexes to accelerate query execution (for 
> certain class of queries). E.g.
> - Filters and range scans (already being worked on by He Yongqiang as part of 
> HIVE-417?)
> - Joins (index based joins)
> - Group By, Order By and other misc cases
> The proposal is multi-step:
> 1. Building index based operators, compiler and execution engine changes
> 2. Optimizer enhancements (e.g. cost-based optimizer to compare and choose 
> between index scans, full table scans etc.)
> This JIRA initially focuses on the first step. This JIRA is expected to hold 
> the information about index based plans & operator implementations for above 
> mentioned cases. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira