[jira] [Updated] (HIVE-2080) Few code improvements in the ql and serde packages.
[ https://issues.apache.org/jira/browse/HIVE-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinna Rao Lalam updated HIVE-2080: --- Attachment: HIVE-2183.2.patch Few code improvements in the ql and serde packages. --- Key: HIVE-2080 URL: https://issues.apache.org/jira/browse/HIVE-2080 Project: Hive Issue Type: Bug Components: Query Processor, Serializers/Deserializers Affects Versions: 0.7.0 Environment: Hadoop 0.20.1, Hive0.7.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5). Reporter: Chinna Rao Lalam Assignee: Chinna Rao Lalam Attachments: HIVE-2080.1.Patch, HIVE-2080.Patch, HIVE-2183.2.patch Few code improvements in the ql and serde packages. 1) Little performance Improvements 2) Null checks to avoid NPEs 3) Effective varaible management. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2080) Few code improvements in the ql and serde packages.
[ https://issues.apache.org/jira/browse/HIVE-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinna Rao Lalam updated HIVE-2080: --- Attachment: (was: HIVE-2183.2.patch) Few code improvements in the ql and serde packages. --- Key: HIVE-2080 URL: https://issues.apache.org/jira/browse/HIVE-2080 Project: Hive Issue Type: Bug Components: Query Processor, Serializers/Deserializers Affects Versions: 0.7.0 Environment: Hadoop 0.20.1, Hive0.7.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5). Reporter: Chinna Rao Lalam Assignee: Chinna Rao Lalam Attachments: HIVE-2080.1.Patch, HIVE-2080.2.Patch, HIVE-2080.Patch Few code improvements in the ql and serde packages. 1) Little performance Improvements 2) Null checks to avoid NPEs 3) Effective varaible management. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2080) Few code improvements in the ql and serde packages.
[ https://issues.apache.org/jira/browse/HIVE-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinna Rao Lalam updated HIVE-2080: --- Attachment: HIVE-2080.2.Patch Few code improvements in the ql and serde packages. --- Key: HIVE-2080 URL: https://issues.apache.org/jira/browse/HIVE-2080 Project: Hive Issue Type: Bug Components: Query Processor, Serializers/Deserializers Affects Versions: 0.7.0 Environment: Hadoop 0.20.1, Hive0.7.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5). Reporter: Chinna Rao Lalam Assignee: Chinna Rao Lalam Attachments: HIVE-2080.1.Patch, HIVE-2080.2.Patch, HIVE-2080.Patch Few code improvements in the ql and serde packages. 1) Little performance Improvements 2) Null checks to avoid NPEs 3) Effective varaible management. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Review Request: Few code improvements in the ql and serde packages.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1144/ --- (Updated 2011-07-28 06:11:18.101615) Review request for hive. Changes --- Patch rebased Summary --- Few code improvements in the ql and serde packages. 1) Little performance Improvements 2) Null checks to avoid NPEs 3) Effective varaible management. This addresses bug HIVE-2080. https://issues.apache.org/jira/browse/HIVE-2080 Diffs (updated) - trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java 1151731 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 1151731 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FilterOperator.java 1151731 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java 1151731 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 1151731 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java 1151731 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java 1151731 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java 1151731 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TaskFactory.java 1151731 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/UnionOperator.java 1151731 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ASTNode.java 1151731 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 1151731 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 1151731 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1151731 trunk/serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDeField.java 1151731 trunk/serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDeFieldType.java 1151731 trunk/serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDeFunction.java 1151731 Diff: https://reviews.apache.org/r/1144/diff Testing --- All unit test passed Thanks, chinna
[jira] [Commented] (HIVE-2080) Few code improvements in the ql and serde packages.
[ https://issues.apache.org/jira/browse/HIVE-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13072196#comment-13072196 ] jirapos...@reviews.apache.org commented on HIVE-2080: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1144/ --- (Updated 2011-07-28 06:11:18.101615) Review request for hive. Changes --- Patch rebased Summary --- Few code improvements in the ql and serde packages. 1) Little performance Improvements 2) Null checks to avoid NPEs 3) Effective varaible management. This addresses bug HIVE-2080. https://issues.apache.org/jira/browse/HIVE-2080 Diffs (updated) - trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java 1151731 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 1151731 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FilterOperator.java 1151731 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java 1151731 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 1151731 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java 1151731 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java 1151731 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java 1151731 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TaskFactory.java 1151731 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/UnionOperator.java 1151731 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ASTNode.java 1151731 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 1151731 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 1151731 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1151731 trunk/serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDeField.java 1151731 trunk/serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDeFieldType.java 1151731 trunk/serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDeFunction.java 1151731 Diff: https://reviews.apache.org/r/1144/diff Testing --- All unit test passed Thanks, chinna Few code improvements in the ql and serde packages. --- Key: HIVE-2080 URL: https://issues.apache.org/jira/browse/HIVE-2080 Project: Hive Issue Type: Bug Components: Query Processor, Serializers/Deserializers Affects Versions: 0.7.0 Environment: Hadoop 0.20.1, Hive0.7.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5). Reporter: Chinna Rao Lalam Assignee: Chinna Rao Lalam Attachments: HIVE-2080.1.Patch, HIVE-2080.2.Patch, HIVE-2080.Patch Few code improvements in the ql and serde packages. 1) Little performance Improvements 2) Null checks to avoid NPEs 3) Effective varaible management. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2183) In Task class and its subclasses logger is initialized in constructor
[ https://issues.apache.org/jira/browse/HIVE-2183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinna Rao Lalam updated HIVE-2183: --- Status: Patch Available (was: Open) In Task class and its subclasses logger is initialized in constructor - Key: HIVE-2183 URL: https://issues.apache.org/jira/browse/HIVE-2183 Project: Hive Issue Type: Bug Components: Query Processor Affects Versions: 0.5.0, 0.8.0 Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5) Reporter: Chinna Rao Lalam Assignee: Chinna Rao Lalam Priority: Minor Attachments: HIVE-2183.1.patch, HIVE-2183.2.patch, HIVE-2183.patch In Task class and its subclasses logger is initialized in constructor. Log object no need to initialize every time in the constructor, Log object can make it as static object. {noformat} Ex: public ExecDriver() { super(); LOG = LogFactory.getLog(this.getClass().getName()); console = new LogHelper(LOG); this.jobExecHelper = new HadoopJobExecHelper(job, console, this, this); } {noformat} Need to change like this {noformat} private static final Log LOG = LogFactory.getLog(ExecDriver.class); {noformat} -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HIVE-2319) Calling alter_table after changing partition comment throws an exception
Calling alter_table after changing partition comment throws an exception Key: HIVE-2319 URL: https://issues.apache.org/jira/browse/HIVE-2319 Project: Hive Issue Type: Bug Components: Metastore Reporter: Sohan Jain Altering a table's partition key comments raises an InvalidOperationException. The partition key name and type should not be mutable, but the comment should be able to get changed. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
Review Request: HIVE-2319: Calling alter_table after changing partition key comment throws an exception
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1213/ --- Review request for hive and Paul Yang. Summary --- Altering a table's partition key comments raises an InvalidOperationException. The partition key name and type should not be mutable, but the comment should be able to get changed. This addresses bug HIVE-2319. https://issues.apache.org/jira/browse/HIVE-2319 Diffs - trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1151219 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 1151219 Diff: https://reviews.apache.org/r/1213/diff Testing --- Added some test cases to HiveMetaStore that pass. Thanks, Sohan
[jira] [Commented] (HIVE-2319) Calling alter_table after changing partition comment throws an exception
[ https://issues.apache.org/jira/browse/HIVE-2319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13072215#comment-13072215 ] jirapos...@reviews.apache.org commented on HIVE-2319: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1213/ --- Review request for hive and Paul Yang. Summary --- Altering a table's partition key comments raises an InvalidOperationException. The partition key name and type should not be mutable, but the comment should be able to get changed. This addresses bug HIVE-2319. https://issues.apache.org/jira/browse/HIVE-2319 Diffs - trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1151219 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 1151219 Diff: https://reviews.apache.org/r/1213/diff Testing --- Added some test cases to HiveMetaStore that pass. Thanks, Sohan Calling alter_table after changing partition comment throws an exception Key: HIVE-2319 URL: https://issues.apache.org/jira/browse/HIVE-2319 Project: Hive Issue Type: Bug Components: Metastore Reporter: Sohan Jain Altering a table's partition key comments raises an InvalidOperationException. The partition key name and type should not be mutable, but the comment should be able to get changed. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Review Request: HIVE-2319: Calling alter_table after changing partition key comment throws an exception
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1213/ --- (Updated 2011-07-28 07:06:24.236980) Review request for hive and Paul Yang. Changes --- Fixed some of the test case logic. Summary --- Altering a table's partition key comments raises an InvalidOperationException. The partition key name and type should not be mutable, but the comment should be able to get changed. This addresses bug HIVE-2319. https://issues.apache.org/jira/browse/HIVE-2319 Diffs (updated) - trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1151219 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 1151219 Diff: https://reviews.apache.org/r/1213/diff Testing --- Added some test cases to HiveMetaStore that pass. Thanks, Sohan
[jira] [Commented] (HIVE-2319) Calling alter_table after changing partition comment throws an exception
[ https://issues.apache.org/jira/browse/HIVE-2319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13072219#comment-13072219 ] jirapos...@reviews.apache.org commented on HIVE-2319: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1213/ --- (Updated 2011-07-28 07:06:24.236980) Review request for hive and Paul Yang. Changes --- Fixed some of the test case logic. Summary --- Altering a table's partition key comments raises an InvalidOperationException. The partition key name and type should not be mutable, but the comment should be able to get changed. This addresses bug HIVE-2319. https://issues.apache.org/jira/browse/HIVE-2319 Diffs (updated) - trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1151219 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 1151219 Diff: https://reviews.apache.org/r/1213/diff Testing --- Added some test cases to HiveMetaStore that pass. Thanks, Sohan Calling alter_table after changing partition comment throws an exception Key: HIVE-2319 URL: https://issues.apache.org/jira/browse/HIVE-2319 Project: Hive Issue Type: Bug Components: Metastore Reporter: Sohan Jain Altering a table's partition key comments raises an InvalidOperationException. The partition key name and type should not be mutable, but the comment should be able to get changed. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2319) Calling alter_table after changing partition comment throws an exception
[ https://issues.apache.org/jira/browse/HIVE-2319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sohan Jain updated HIVE-2319: - Assignee: Sohan Jain Status: Patch Available (was: Open) Calling alter_table after changing partition comment throws an exception Key: HIVE-2319 URL: https://issues.apache.org/jira/browse/HIVE-2319 Project: Hive Issue Type: Bug Components: Metastore Reporter: Sohan Jain Assignee: Sohan Jain Attachments: HIVE-2319.2.patch Altering a table's partition key comments raises an InvalidOperationException. The partition key name and type should not be mutable, but the comment should be able to get changed. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2319) Calling alter_table after changing partition comment throws an exception
[ https://issues.apache.org/jira/browse/HIVE-2319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sohan Jain updated HIVE-2319: - Attachment: HIVE-2319.2.patch Calling alter_table after changing partition comment throws an exception Key: HIVE-2319 URL: https://issues.apache.org/jira/browse/HIVE-2319 Project: Hive Issue Type: Bug Components: Metastore Reporter: Sohan Jain Attachments: HIVE-2319.2.patch Altering a table's partition key comments raises an InvalidOperationException. The partition key name and type should not be mutable, but the comment should be able to get changed. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: eclipse formatting problem when using apache hive formatter
Ok, found the problem. *before* you start developing on the hive codebase go here: project - properties - java editor - save actions - additional actions - configure... and change the remove trailing whitespace from all lines to ignore empty lines. happy contributing, ido On Thu, Jul 28, 2011 at 10:47 AM, Ido Hadanny ido.hada...@gmail.com wrote: Hey, I'm using eclipse to edit the file /hive/jdbc/src/java/org/apache/hadoop/hive/jdbc/HivePreparedStatement.java. Whenever I'm saving it, eclipse changes every non-javadoc comment in that file. In each comment there's a line that contains only a *, then a blank space and then a LF. Eclipse changes it to a * immediately followed by a LF. I've double-checked, and my java code style-formatter settings are: - enable project specific settings - active profile = Unmanaged profile 'Apache Hive Formatter' What am I doing wrong?? Example of the problem (invisible, use your cursor to see the difference :) : Before save: /* * (non-Javadoc) * * @see java.sql.PreparedStatement#addBatch() */ After save: /* * (non-Javadoc) * * @see java.sql.PreparedStatement#addBatch() */
[jira] [Created] (HIVE-2320) Implement setCatalog()
Implement setCatalog() -- Key: HIVE-2320 URL: https://issues.apache.org/jira/browse/HIVE-2320 Project: Hive Issue Type: Sub-task Components: JDBC Affects Versions: 0.7.1 Reporter: Oren Lederman Priority: Minor Currently, the JDBC driver always use default as the schema/database. We should allow setting the active schema to another schema. 1. implement the setCatalog() method 2. modify HiveConnection constructor to take the schema from the URL and call setCatalog 3. change configureConnection() and execute use schema; statement See https://issues.apache.org/jira/browse/HIVE-675 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2009) Crtrl+D cause CLI throw NPE
[ https://issues.apache.org/jira/browse/HIVE-2009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13072277#comment-13072277 ] Wojciech Langiewicz commented on HIVE-2009: --- Also happens on CDH3u1 - hadoop-hive_0.7.1+42.4-2~lenny-cdh3_all.deb Crtrl+D cause CLI throw NPE --- Key: HIVE-2009 URL: https://issues.apache.org/jira/browse/HIVE-2009 Project: Hive Issue Type: Bug Components: CLI Affects Versions: 0.8.0 Environment: HIVE TRUNK,0.8-snapshot Hadoop 0.20.1+169.113 java version 1.6.0_22 Java(TM) SE Runtime Environment (build 1.6.0_22-b04) Java HotSpot(TM) 64-Bit Server VM (build 17.1-b03, mixed mode) linux 2.6.26-2-amd64 Reporter: zhaowei in HIVE CLI,enter Ctrl+D,it should exit the CLI,but throws NPE. hive Exception in thread main java.lang.NullPointerException at org.apache.hadoop.hive.cli.CliSessionState.close(CliSessionState.java:106) at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:523) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.hadoop.util.RunJar.main(RunJar.java:156) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-1850) alter table set serdeproperties bypasses regexps checks (leaves table in a non-recoverable state?)
[ https://issues.apache.org/jira/browse/HIVE-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated HIVE-1850: -- Status: Open (was: Patch Available) canceling patch as one of the tests is failing. alter table set serdeproperties bypasses regexps checks (leaves table in a non-recoverable state?) -- Key: HIVE-1850 URL: https://issues.apache.org/jira/browse/HIVE-1850 Project: Hive Issue Type: Bug Components: Serializers/Deserializers Affects Versions: 0.7.0 Environment: Trunk build from a few days ago, but seen once before with older version as well. Reporter: Terje Marthinussen Assignee: Amareshwari Sriramadasu Fix For: 0.8.0 Attachments: patch-1850.txt {code} create table aa ( test STRING ) ROW FORMAT SERDE 'org.apache.hadoop.hive.contrib.serde2.RegexSerDe' WITH SERDEPROPERTIES (input.regex = [^\\](.*), output.format.string = $1s); {code} This will fail. Great! {code} create table aa ( test STRING ) ROW FORMAT SERDE 'org.apache.hadoop.hive.contrib.serde2.RegexSerDe' WITH SERDEPROPERTIES (input.regex = (.*), output.format.string = $1s); {code} Works, no problem there. {code} alter table aa set serdeproperties (input.regex = [^\\](.*), output.format.string = $1s); {code} Wups... I can set that without any problems! {code} alter table aa set serdeproperties (input.regex = (.*), output.format.string = $1s); FAILED: Hive Internal Error: java.util.regex.PatternSyntaxException(Unclosed character class near index 7 [^\](.*) ^) java.util.regex.PatternSyntaxException: Unclosed character class near index 7 [^\](.*) ^ at java.util.regex.Pattern.error(Pattern.java:1713) at java.util.regex.Pattern.clazz(Pattern.java:2254) at java.util.regex.Pattern.sequence(Pattern.java:1818) at java.util.regex.Pattern.expr(Pattern.java:1752) at java.util.regex.Pattern.compile(Pattern.java:1460) at java.util.regex.Pattern.init(Pattern.java:1133) at java.util.regex.Pattern.compile(Pattern.java:847) at org.apache.hadoop.hive.contrib.serde2.RegexSerDe.initialize(RegexSerDe.java:101) at org.apache.hadoop.hive.metastore.MetaStoreUtils.getDeserializer(MetaStoreUtils.java:199) at org.apache.hadoop.hive.ql.metadata.Table.getDeserializer(Table.java:253) at org.apache.hadoop.hive.ql.metadata.Table.getCols(Table.java:484) at org.apache.hadoop.hive.ql.metadata.Table.checkValidity(Table.java:161) at org.apache.hadoop.hive.ql.metadata.Hive.getTable(Hive.java:803) at org.apache.hadoop.hive.ql.parse.DDLSemanticAnalyzer.analyzeAlterTableSerdeProps(DDLSemanticAnalyzer.java:558) at org.apache.hadoop.hive.ql.parse.DDLSemanticAnalyzer.analyzeInternal(DDLSemanticAnalyzer.java:232) at org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:238) at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:335) at org.apache.hadoop.hive.ql.Driver.run(Driver.java:686) at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:142) at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:216) at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:370) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.hadoop.util.RunJar.main(RunJar.java:156) {code} After this, all further commands on the table fails, including drop table :) 1. The alter table command should probably check the regexp just like the create table command does 2. Even though the regexp is bad, it should be possible to do things like set the regexp again or drop the table. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HIVE-2321) Jobs fail due to issues in regexp() based UDFs
Jobs fail due to issues in regexp() based UDFs -- Key: HIVE-2321 URL: https://issues.apache.org/jira/browse/HIVE-2321 Project: Hive Issue Type: Bug Components: UDF Affects Versions: 0.8.0 Reporter: Thiruvel Thirumoolan Assignee: Thiruvel Thirumoolan Priority: Minor Fix For: 0.8.0 Attachments: RegexpExtractBug.patch regexp_extract() fails when its not possible to extract the string. Its better to return NULL/empty string than to fail. Will also peek into similar UDFs if possible and fix/at-least enhance tests. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2321) Jobs fail due to issues in regexp() based UDFs
[ https://issues.apache.org/jira/browse/HIVE-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiruvel Thirumoolan updated HIVE-2321: --- Attachment: RegexpExtractBug.patch Prelim patch for regexp_extract(), no test cases. Jobs fail due to issues in regexp() based UDFs -- Key: HIVE-2321 URL: https://issues.apache.org/jira/browse/HIVE-2321 Project: Hive Issue Type: Bug Components: UDF Affects Versions: 0.8.0 Reporter: Thiruvel Thirumoolan Assignee: Thiruvel Thirumoolan Priority: Minor Fix For: 0.8.0 Attachments: RegexpExtractBug.patch regexp_extract() fails when its not possible to extract the string. Its better to return NULL/empty string than to fail. Will also peek into similar UDFs if possible and fix/at-least enhance tests. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2304) Support PreparedStatement.setObject
[ https://issues.apache.org/jira/browse/HIVE-2304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ido Hadanny updated HIVE-2304: -- Attachment: HIVE-2304.prepared_statement_set_object.1.patch Support PreparedStatement.setObject --- Key: HIVE-2304 URL: https://issues.apache.org/jira/browse/HIVE-2304 Project: Hive Issue Type: Sub-task Components: JDBC Affects Versions: 0.7.1 Reporter: Ido Hadanny Priority: Minor Fix For: 0.8.0 Attachments: HIVE-2304.prepared_statement_set_object.1.patch Original Estimate: 1h Remaining Estimate: 1h PreparedStatement.setObject is important for spring's jdbcTemplate support -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
eclipse formatting problem when using apache hive formatter
Hey, I'm using eclipse to edit the file /hive/jdbc/src/java/org/apache/hadoop/hive/jdbc/HivePreparedStatement.java. Whenever I'm saving it, eclipse changes every non-javadoc comment in that file. In each comment there's a line that contains only a *, then a blank space and then a LF. Eclipse changes it to a * immediately followed by a LF. I've double-checked, and my java code style-formatter settings are: - enable project specific settings - active profile = Unmanaged profile 'Apache Hive Formatter' What am I doing wrong?? Example of the problem (invisible, use your cursor to see the difference :) : Before save: /* * (non-Javadoc) * * @see java.sql.PreparedStatement#addBatch() */ After save: /* * (non-Javadoc) * * @see java.sql.PreparedStatement#addBatch() */
[jira] [Commented] (HIVE-2307) Schema creation scripts for PostgreSQL use bit(1) instead of boolean
[ https://issues.apache.org/jira/browse/HIVE-2307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13072454#comment-13072454 ] Carl Steinbach commented on HIVE-2307: -- +1 Schema creation scripts for PostgreSQL use bit(1) instead of boolean Key: HIVE-2307 URL: https://issues.apache.org/jira/browse/HIVE-2307 Project: Hive Issue Type: Bug Components: Configuration, Metastore Affects Versions: 0.5.0, 0.6.0, 0.7.0, 0.7.1 Reporter: Esteban Gutierrez Assignee: Esteban Gutierrez Labels: metastore, postgres Attachments: HIVE-2307.1.patch.txt The specified type for DEFERRED_REBUILD (IDXS) and IS_COMPRESSED (SDS) columns in the metastore is defined as bit(1) type which is not supported by PostgreSQL JDBC. hive create table test (id int); FAILED: Error in metadata: javax.jdo.JDODataStoreException: Insert of object org.apache.hadoop.hive.metastore.model.MStorageDescriptor@4f1adeb7 using statement INSERT INTO SDS (SD_ID,INPUT_FORMAT,OUTPUT_FORMAT,LOCATION,SERDE_ID,NUM_BUCKETS,IS_COMPRESSED) VALUES (?,?,?,?,?,?,?) failed : ERROR: column IS_COMPRESSED is of type bit but expression is of type boolean -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2307) Schema creation scripts for PostgreSQL use bit(1) instead of boolean
[ https://issues.apache.org/jira/browse/HIVE-2307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13072455#comment-13072455 ] Carl Steinbach commented on HIVE-2307: -- Committed to trunk. Thanks Esteban! Schema creation scripts for PostgreSQL use bit(1) instead of boolean Key: HIVE-2307 URL: https://issues.apache.org/jira/browse/HIVE-2307 Project: Hive Issue Type: Bug Components: Configuration, Metastore Affects Versions: 0.5.0, 0.6.0, 0.7.0, 0.7.1 Reporter: Esteban Gutierrez Assignee: Esteban Gutierrez Labels: metastore, postgres Attachments: HIVE-2307.1.patch.txt The specified type for DEFERRED_REBUILD (IDXS) and IS_COMPRESSED (SDS) columns in the metastore is defined as bit(1) type which is not supported by PostgreSQL JDBC. hive create table test (id int); FAILED: Error in metadata: javax.jdo.JDODataStoreException: Insert of object org.apache.hadoop.hive.metastore.model.MStorageDescriptor@4f1adeb7 using statement INSERT INTO SDS (SD_ID,INPUT_FORMAT,OUTPUT_FORMAT,LOCATION,SERDE_ID,NUM_BUCKETS,IS_COMPRESSED) VALUES (?,?,?,?,?,?,?) failed : ERROR: column IS_COMPRESSED is of type bit but expression is of type boolean -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Review Request: HIVE-2272: add TIMESTAMP data type
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1135/ --- (Updated 2011-07-28 19:17:59.868991) Review request for hive. Changes --- Decided to store timestamps as UTC on disk and add offsets (localize) if user needs through UDF. This simplifies use cases (compared to MySQL) where users from different time zones querying the same data would receive different results. Will file a follow up JIRA ticket to add table level timezone defaults. This would allow a user to import existing data that is already offset from UTC and write new data to the table with that offset. Summary: -Added config var for default timezone -Added GenericUDF for converting from UTC to localized timezone (either default, or supplied from list of Java timezones) Ex: utc_to_localized_timestamp(timestamp) OR utc_to_localized_timestamp(timestamp, America/Chicago) -Fixed DateDiff bug I introduced Summary --- Adds TIMESTAMP type to serde2 with both string (LazySimple) and binary (LazyBinary) serialization. Supports SQL style jdbc timestamps of the format with nanosecond precision -MM-DD HH:MM:SS[.fff...] This addresses bug HIVE-2272. https://issues.apache.org/jira/browse/HIVE-2272 Diffs (updated) - trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1151571 trunk/conf/hive-default.xml 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDate.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateAdd.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateDiff.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateSub.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDayOfMonth.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFHour.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFMinute.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFMonth.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSecond.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToBoolean.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToByte.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToDouble.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToFloat.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToInteger.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToLong.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToShort.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToString.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFUnixTimeStamp.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFWeekOfYear.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFYear.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFAverage.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFContextNGrams.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCorrelation.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCovariance.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCovarianceSample.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFHistogramNumeric.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFPercentileApprox.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFStd.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFStdSample.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFVariance.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFVarianceSample.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFnGrams.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTimestamp.java PRE-CREATION trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUtcToLocalizedTimestamp.java PRE-CREATION trunk/ql/src/test/queries/clientnegative/invalid_t_create3.q 1151571
[jira] [Commented] (HIVE-2272) add TIMESTAMP data type
[ https://issues.apache.org/jira/browse/HIVE-2272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13072494#comment-13072494 ] jirapos...@reviews.apache.org commented on HIVE-2272: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1135/ --- (Updated 2011-07-28 19:17:59.868991) Review request for hive. Changes --- Decided to store timestamps as UTC on disk and add offsets (localize) if user needs through UDF. This simplifies use cases (compared to MySQL) where users from different time zones querying the same data would receive different results. Will file a follow up JIRA ticket to add table level timezone defaults. This would allow a user to import existing data that is already offset from UTC and write new data to the table with that offset. Summary: -Added config var for default timezone -Added GenericUDF for converting from UTC to localized timezone (either default, or supplied from list of Java timezones) Ex: utc_to_localized_timestamp(timestamp) OR utc_to_localized_timestamp(timestamp, America/Chicago) -Fixed DateDiff bug I introduced Summary --- Adds TIMESTAMP type to serde2 with both string (LazySimple) and binary (LazyBinary) serialization. Supports SQL style jdbc timestamps of the format with nanosecond precision -MM-DD HH:MM:SS[.fff...] This addresses bug HIVE-2272. https://issues.apache.org/jira/browse/HIVE-2272 Diffs (updated) - trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1151571 trunk/conf/hive-default.xml 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDate.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateAdd.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateDiff.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateSub.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDayOfMonth.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFHour.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFMinute.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFMonth.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSecond.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToBoolean.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToByte.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToDouble.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToFloat.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToInteger.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToLong.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToShort.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToString.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFUnixTimeStamp.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFWeekOfYear.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFYear.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFAverage.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFContextNGrams.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCorrelation.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCovariance.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCovarianceSample.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFHistogramNumeric.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFPercentileApprox.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFStd.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFStdSample.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFVariance.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFVarianceSample.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFnGrams.java 1151571
Re: Review Request: HIVE-2272: add TIMESTAMP data type
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1135/ --- (Updated 2011-07-28 20:51:48.675604) Review request for hive, Yongqiang He, Ning Zhang, and Siying Dong. Summary --- Adds TIMESTAMP type to serde2 with both string (LazySimple) and binary (LazyBinary) serialization. Supports SQL style jdbc timestamps of the format with nanosecond precision -MM-DD HH:MM:SS[.fff...] This addresses bug HIVE-2272. https://issues.apache.org/jira/browse/HIVE-2272 Diffs - trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1151571 trunk/conf/hive-default.xml 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDate.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateAdd.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateDiff.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateSub.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDayOfMonth.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFHour.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFMinute.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFMonth.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSecond.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToBoolean.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToByte.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToDouble.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToFloat.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToInteger.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToLong.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToShort.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToString.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFUnixTimeStamp.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFWeekOfYear.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFYear.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFAverage.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFContextNGrams.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCorrelation.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCovariance.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCovarianceSample.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFHistogramNumeric.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFPercentileApprox.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFStd.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFStdSample.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFVariance.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFVarianceSample.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFnGrams.java 1151571 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTimestamp.java PRE-CREATION trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUtcToLocalizedTimestamp.java PRE-CREATION trunk/ql/src/test/queries/clientnegative/invalid_t_create3.q 1151571 trunk/ql/src/test/queries/clientpositive/timestamp_1.q PRE-CREATION trunk/ql/src/test/queries/clientpositive/timestamp_2.q PRE-CREATION trunk/ql/src/test/queries/clientpositive/timestamp_3.q PRE-CREATION trunk/ql/src/test/queries/clientpositive/timestamp_comparison.q PRE-CREATION trunk/ql/src/test/queries/clientpositive/timestamp_udf.q PRE-CREATION trunk/ql/src/test/results/clientnegative/invalid_create_tbl1.q.out 1151571 trunk/ql/src/test/results/clientnegative/invalid_t_alter1.q.out 1151571 trunk/ql/src/test/results/clientnegative/invalid_t_alter2.q.out 1151571 trunk/ql/src/test/results/clientnegative/invalid_t_create1.q.out 1151571 trunk/ql/src/test/results/clientnegative/invalid_t_create2.q.out 1151571
[jira] [Created] (HIVE-2322) Add ColumnarSerDe to the list of native SerDes
Add ColumnarSerDe to the list of native SerDes -- Key: HIVE-2322 URL: https://issues.apache.org/jira/browse/HIVE-2322 Project: Hive Issue Type: Bug Components: Metastore, Serializers/Deserializers Reporter: Sohan Jain Assignee: Sohan Jain We store metadata about ColumnarSerDes in the metastore, so it should be considered a native SerDe. Then, column information can be retrieved from the metastore instead of from deserialization. Currently, for non-native SerDes, column comments are only shown as from deserializer. Adding ColumnarSerDe to the list of native SerDes will persist column comments. See HIVE-2171 for persisting the column comments of custom SerDes. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2305) UNION ALL on different types throws runtime exception
[ https://issues.apache.org/jira/browse/HIVE-2305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Franklin Hu updated HIVE-2305: -- Attachment: hive-2305.3.patch -Added getCommonClassForUnion (needed since getCommonClass returns null for complex types) -Added unit text -Fixed changed existing unit test output UNION ALL on different types throws runtime exception - Key: HIVE-2305 URL: https://issues.apache.org/jira/browse/HIVE-2305 Project: Hive Issue Type: Bug Affects Versions: 0.7.1 Reporter: Franklin Hu Assignee: Franklin Hu Attachments: hive-2305.1.patch, hive-2305.2.patch, hive-2305.3.patch Ex: SELECT * (SELECT 123 FROM ... UNION ALL SELECT '123' FROM ..) t; Unioning columns of different types currently throws runtime exceptions. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2322) Add ColumnarSerDe to the list of native SerDes
[ https://issues.apache.org/jira/browse/HIVE-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sohan Jain updated HIVE-2322: - Attachment: HIVE-2322.1.patch Add ColumnarSerDe to the list of native SerDes -- Key: HIVE-2322 URL: https://issues.apache.org/jira/browse/HIVE-2322 Project: Hive Issue Type: Bug Components: Metastore, Serializers/Deserializers Reporter: Sohan Jain Assignee: Sohan Jain Attachments: HIVE-2322.1.patch We store metadata about ColumnarSerDes in the metastore, so it should be considered a native SerDe. Then, column information can be retrieved from the metastore instead of from deserialization. Currently, for non-native SerDes, column comments are only shown as from deserializer. Adding ColumnarSerDe to the list of native SerDes will persist column comments. See HIVE-2171 for persisting the column comments of custom SerDes. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
Review Request: Add ColumnarSerDe to the list of native SerDes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1215/ --- Review request for hive and Paul Yang. Summary --- We store metadata about ColumnarSerDes in the metastore, so it should be considered a native SerDe. Then, column information can be retrieved from the metastore instead of from deserialization. This addresses bug HIVE-2322. https://issues.apache.org/jira/browse/HIVE-2322 Diffs - trunk/serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java 1151219 Diff: https://reviews.apache.org/r/1215/diff Testing --- describe formatted tmp_tbl_name; now returns the column's comments instead of from deserializer Thanks, Sohan
[jira] [Updated] (HIVE-2276) Fix Inconsistency between RB and JIRA patches for HIVE-2194
[ https://issues.apache.org/jira/browse/HIVE-2276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carl Steinbach updated HIVE-2276: - Component/s: Metastore Fix Inconsistency between RB and JIRA patches for HIVE-2194 --- Key: HIVE-2276 URL: https://issues.apache.org/jira/browse/HIVE-2276 Project: Hive Issue Type: Bug Components: Metastore Reporter: Sohan Jain Assignee: Sohan Jain Fix For: 0.8.0 Attachments: HIVE-2276.1.patch The RB and JIRA patches for HIVE-2194 were out of sync. An outdated patch for HIVE-2194 was committed. This patch updates that patch to include the changes from RB. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2276) Fix Inconsistency between RB and JIRA patches for HIVE-2194
[ https://issues.apache.org/jira/browse/HIVE-2276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carl Steinbach updated HIVE-2276: - Resolution: Fixed Fix Version/s: 0.8.0 Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) Committed to trunk. Thanks Sohan! Fix Inconsistency between RB and JIRA patches for HIVE-2194 --- Key: HIVE-2276 URL: https://issues.apache.org/jira/browse/HIVE-2276 Project: Hive Issue Type: Bug Components: Metastore Reporter: Sohan Jain Assignee: Sohan Jain Fix For: 0.8.0 Attachments: HIVE-2276.1.patch The RB and JIRA patches for HIVE-2194 were out of sync. An outdated patch for HIVE-2194 was committed. This patch updates that patch to include the changes from RB. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2318) Support multiple file systems
[ https://issues.apache.org/jira/browse/HIVE-2318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13072544#comment-13072544 ] Carl Steinbach commented on HIVE-2318: -- @Vaibav: Is this patch ready for review? If so, please attach the patch to this ticket and click Submit Patch. Thanks. Support multiple file systems - Key: HIVE-2318 URL: https://issues.apache.org/jira/browse/HIVE-2318 Project: Hive Issue Type: New Feature Reporter: Vaibhav Aggarwal Assignee: Vaibhav Aggarwal Currently some of the Hive tasks like MoveTask, ConditionalMergeResolver assume that the data is being copied or moved on the same file system. These operators file if the source table is in one filesystem (like HDFS) and destination table is in another file system (like s3). This patch aims at: 1. Support moving data between different file systems. 2. Add support for file systems which do not support 'move' operation like s3. 3. Remove redundant operations like moving data from and to the same location. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2266) Fix compression parameters
[ https://issues.apache.org/jira/browse/HIVE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13072546#comment-13072546 ] Carl Steinbach commented on HIVE-2266: -- @Vaibav: Is this patch ready for review? If so, please attach the patch to this ticket and click Submit Patch. Thanks. Fix compression parameters -- Key: HIVE-2266 URL: https://issues.apache.org/jira/browse/HIVE-2266 Project: Hive Issue Type: Bug Reporter: Vaibhav Aggarwal Assignee: Vaibhav Aggarwal There are a number of places where compression values are not set correctly in FileSinkOperator. This results in uncompressed files. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2020) Create a separate namespace for Hive variables
[ https://issues.apache.org/jira/browse/HIVE-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13072545#comment-13072545 ] Carl Steinbach commented on HIVE-2020: -- @Vaibav: Is this patch ready for review? If so, please attach the patch to this ticket and click Submit Patch. Thanks. Create a separate namespace for Hive variables -- Key: HIVE-2020 URL: https://issues.apache.org/jira/browse/HIVE-2020 Project: Hive Issue Type: Improvement Components: Query Processor Reporter: Carl Steinbach Assignee: Vaibhav Aggarwal Support for variable substitution was added in HIVE-1096. However, variable substitution was implemented by reusing the HiveConf namespace, so there is no separation between Hive configuration properties and Hive variables. This ticket encompasses the following enhancements: * Create a separate namespace for managing Hive variables. * Add support for setting variables on the command line via '-hivevar x=y' * Add support for setting variables through the CLI via 'var x=y' * Add support for referencing variables in statements using either '${hivevar:var_name}' or '${var_name}' * Provide a means for differentiating between hiveconf, hivevar, system, and environment properties in the output of 'set -v' -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Review Request: HIVE-1694: Accelerate GROUP BY execution using indexes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1194/#review1212 --- ql/src/java/org/apache/hadoop/hive/ql/index/AggregateIndexHandler.java https://reviews.apache.org/r/1194/#comment2711 Please run ant checkstyle and fix all the formatting discrepancies it reports for your new files. ql/src/java/org/apache/hadoop/hive/ql/index/AggregateIndexHandler.java https://reviews.apache.org/r/1194/#comment2695 Don't you need to reuse the compact implementation here so that the index can be used for WHERE (not just GROUP BY)? ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java https://reviews.apache.org/r/1194/#comment2696 This method is redundant now. ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteCanApplyCtx.java https://reviews.apache.org/r/1194/#comment2698 I can't think of a case where it would be worse. ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteCanApplyProcFactory.java https://reviews.apache.org/r/1194/#comment2699 Actually group-by is now preserved in all cases. ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteGBUsingIndex.java https://reviews.apache.org/r/1194/#comment2700 Please use HTML bullet syntax for Javadoc (otherwise it all gets run together into one line when rendered). ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteGBUsingIndex.java https://reviews.apache.org/r/1194/#comment2701 indentation ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndex.java https://reviews.apache.org/r/1194/#comment2703 Shouldn't this be BIGINT? Also, I think you're supposed to use a TypeInfoFactory for this purpose. ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndex.java https://reviews.apache.org/r/1194/#comment2702 indentation ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndex.java https://reviews.apache.org/r/1194/#comment2704 typo: Repace ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java https://reviews.apache.org/r/1194/#comment2707 Not sure why this new constructor is needed...after using it, all you do is get the table out of it. ql/src/test/queries/clientpositive/ql_rewrite_gbtoidx.q https://reviews.apache.org/r/1194/#comment2709 This should *not* be using the index, since the index is built on count(l_shipdate), and l_shipdate may contain nulls, whereas the query is referencing count(1), which is insensitive to nulls. ql/src/test/queries/clientpositive/ql_rewrite_gbtoidx.q https://reviews.apache.org/r/1194/#comment2710 Need additional tests to verify all the cases where the optimization should *not* be used: * when configuration disables it * when index partitions do not cover table partitions (I still don't see the code for this case) * ... all the other conditions checked for in the code ... - John On 2011-07-26 14:44:01, Prajakta Kalmegh wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1194/ --- (Updated 2011-07-26 14:44:01) Review request for hive and John Sichi. Summary --- This patch has defined a new AggregateIndexHandler which is used to optimize the query plan for groupby queries. This addresses bug HIVE-1694. https://issues.apache.org/jira/browse/HIVE-1694 Diffs - common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b46976f ql/src/java/org/apache/hadoop/hive/ql/index/AggregateIndexHandler.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndex.java 591c9ff ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 2ca63b3 ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 590d69a ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteCanApplyCtx.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteCanApplyProcFactory.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteGBUsingIndex.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteParseContextGenerator.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndex.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 77a6dc6 ql/src/test/queries/clientpositive/ql_rewrite_gbtoidx.q PRE-CREATION ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out PRE-CREATION
[jira] [Updated] (HIVE-2266) Fix compression parameters
[ https://issues.apache.org/jira/browse/HIVE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vaibhav Aggarwal updated HIVE-2266: --- Status: Patch Available (was: Open) Fix compression parameters -- Key: HIVE-2266 URL: https://issues.apache.org/jira/browse/HIVE-2266 Project: Hive Issue Type: Bug Reporter: Vaibhav Aggarwal Assignee: Vaibhav Aggarwal Attachments: HIVE-2266.patch There are a number of places where compression values are not set correctly in FileSinkOperator. This results in uncompressed files. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2266) Fix compression parameters
[ https://issues.apache.org/jira/browse/HIVE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vaibhav Aggarwal updated HIVE-2266: --- Attachment: HIVE-2266.patch Fix compression parameters -- Key: HIVE-2266 URL: https://issues.apache.org/jira/browse/HIVE-2266 Project: Hive Issue Type: Bug Reporter: Vaibhav Aggarwal Assignee: Vaibhav Aggarwal Attachments: HIVE-2266.patch There are a number of places where compression values are not set correctly in FileSinkOperator. This results in uncompressed files. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2020) Create a separate namespace for Hive variables
[ https://issues.apache.org/jira/browse/HIVE-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vaibhav Aggarwal updated HIVE-2020: --- Attachment: HIVE-2020.patch Create a separate namespace for Hive variables -- Key: HIVE-2020 URL: https://issues.apache.org/jira/browse/HIVE-2020 Project: Hive Issue Type: Improvement Components: Query Processor Reporter: Carl Steinbach Assignee: Vaibhav Aggarwal Attachments: HIVE-2020.patch Support for variable substitution was added in HIVE-1096. However, variable substitution was implemented by reusing the HiveConf namespace, so there is no separation between Hive configuration properties and Hive variables. This ticket encompasses the following enhancements: * Create a separate namespace for managing Hive variables. * Add support for setting variables on the command line via '-hivevar x=y' * Add support for setting variables through the CLI via 'var x=y' * Add support for referencing variables in statements using either '${hivevar:var_name}' or '${var_name}' * Provide a means for differentiating between hiveconf, hivevar, system, and environment properties in the output of 'set -v' -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2318) Support multiple file systems
[ https://issues.apache.org/jira/browse/HIVE-2318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vaibhav Aggarwal updated HIVE-2318: --- Status: Patch Available (was: Open) Support multiple file systems - Key: HIVE-2318 URL: https://issues.apache.org/jira/browse/HIVE-2318 Project: Hive Issue Type: New Feature Reporter: Vaibhav Aggarwal Assignee: Vaibhav Aggarwal Attachments: HIVE-2318.patch Currently some of the Hive tasks like MoveTask, ConditionalMergeResolver assume that the data is being copied or moved on the same file system. These operators file if the source table is in one filesystem (like HDFS) and destination table is in another file system (like s3). This patch aims at: 1. Support moving data between different file systems. 2. Add support for file systems which do not support 'move' operation like s3. 3. Remove redundant operations like moving data from and to the same location. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2266) Fix compression parameters
[ https://issues.apache.org/jira/browse/HIVE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13072549#comment-13072549 ] Vaibhav Aggarwal commented on HIVE-2266: Carl, I have attached the patch. Fix compression parameters -- Key: HIVE-2266 URL: https://issues.apache.org/jira/browse/HIVE-2266 Project: Hive Issue Type: Bug Reporter: Vaibhav Aggarwal Assignee: Vaibhav Aggarwal Attachments: HIVE-2266.patch There are a number of places where compression values are not set correctly in FileSinkOperator. This results in uncompressed files. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2318) Support multiple file systems
[ https://issues.apache.org/jira/browse/HIVE-2318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vaibhav Aggarwal updated HIVE-2318: --- Attachment: HIVE-2318.patch Support multiple file systems - Key: HIVE-2318 URL: https://issues.apache.org/jira/browse/HIVE-2318 Project: Hive Issue Type: New Feature Reporter: Vaibhav Aggarwal Assignee: Vaibhav Aggarwal Attachments: HIVE-2318.patch Currently some of the Hive tasks like MoveTask, ConditionalMergeResolver assume that the data is being copied or moved on the same file system. These operators file if the source table is in one filesystem (like HDFS) and destination table is in another file system (like s3). This patch aims at: 1. Support moving data between different file systems. 2. Add support for file systems which do not support 'move' operation like s3. 3. Remove redundant operations like moving data from and to the same location. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-1694) Accelerate GROUP BY execution using indexes
[ https://issues.apache.org/jira/browse/HIVE-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13072550#comment-13072550 ] jirapos...@reviews.apache.org commented on HIVE-1694: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1194/#review1212 --- ql/src/java/org/apache/hadoop/hive/ql/index/AggregateIndexHandler.java https://reviews.apache.org/r/1194/#comment2711 Please run ant checkstyle and fix all the formatting discrepancies it reports for your new files. ql/src/java/org/apache/hadoop/hive/ql/index/AggregateIndexHandler.java https://reviews.apache.org/r/1194/#comment2695 Don't you need to reuse the compact implementation here so that the index can be used for WHERE (not just GROUP BY)? ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java https://reviews.apache.org/r/1194/#comment2696 This method is redundant now. ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteCanApplyCtx.java https://reviews.apache.org/r/1194/#comment2698 I can't think of a case where it would be worse. ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteCanApplyProcFactory.java https://reviews.apache.org/r/1194/#comment2699 Actually group-by is now preserved in all cases. ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteGBUsingIndex.java https://reviews.apache.org/r/1194/#comment2700 Please use HTML bullet syntax for Javadoc (otherwise it all gets run together into one line when rendered). ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteGBUsingIndex.java https://reviews.apache.org/r/1194/#comment2701 indentation ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndex.java https://reviews.apache.org/r/1194/#comment2703 Shouldn't this be BIGINT? Also, I think you're supposed to use a TypeInfoFactory for this purpose. ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndex.java https://reviews.apache.org/r/1194/#comment2702 indentation ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndex.java https://reviews.apache.org/r/1194/#comment2704 typo: Repace ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java https://reviews.apache.org/r/1194/#comment2707 Not sure why this new constructor is needed...after using it, all you do is get the table out of it. ql/src/test/queries/clientpositive/ql_rewrite_gbtoidx.q https://reviews.apache.org/r/1194/#comment2709 This should *not* be using the index, since the index is built on count(l_shipdate), and l_shipdate may contain nulls, whereas the query is referencing count(1), which is insensitive to nulls. ql/src/test/queries/clientpositive/ql_rewrite_gbtoidx.q https://reviews.apache.org/r/1194/#comment2710 Need additional tests to verify all the cases where the optimization should *not* be used: * when configuration disables it * when index partitions do not cover table partitions (I still don't see the code for this case) * ... all the other conditions checked for in the code ... - John On 2011-07-26 14:44:01, Prajakta Kalmegh wrote: bq. bq. --- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/1194/ bq. --- bq. bq. (Updated 2011-07-26 14:44:01) bq. bq. bq. Review request for hive and John Sichi. bq. bq. bq. Summary bq. --- bq. bq. This patch has defined a new AggregateIndexHandler which is used to optimize the query plan for groupby queries. bq. bq. bq. This addresses bug HIVE-1694. bq. https://issues.apache.org/jira/browse/HIVE-1694 bq. bq. bq. Diffs bq. - bq. bq.common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b46976f bq.ql/src/java/org/apache/hadoop/hive/ql/index/AggregateIndexHandler.java PRE-CREATION bq.ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndex.java 591c9ff bq.ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 2ca63b3 bq.ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 590d69a bq. ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteCanApplyCtx.java PRE-CREATION bq. ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteCanApplyProcFactory.java PRE-CREATION bq. ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteGBUsingIndex.java PRE-CREATION bq. ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteParseContextGenerator.java PRE-CREATION bq.
[jira] [Updated] (HIVE-2020) Create a separate namespace for Hive variables
[ https://issues.apache.org/jira/browse/HIVE-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vaibhav Aggarwal updated HIVE-2020: --- Status: Patch Available (was: Open) Create a separate namespace for Hive variables -- Key: HIVE-2020 URL: https://issues.apache.org/jira/browse/HIVE-2020 Project: Hive Issue Type: Improvement Components: Query Processor Reporter: Carl Steinbach Assignee: Vaibhav Aggarwal Attachments: HIVE-2020.patch Support for variable substitution was added in HIVE-1096. However, variable substitution was implemented by reusing the HiveConf namespace, so there is no separation between Hive configuration properties and Hive variables. This ticket encompasses the following enhancements: * Create a separate namespace for managing Hive variables. * Add support for setting variables on the command line via '-hivevar x=y' * Add support for setting variables through the CLI via 'var x=y' * Add support for referencing variables in statements using either '${hivevar:var_name}' or '${var_name}' * Provide a means for differentiating between hiveconf, hivevar, system, and environment properties in the output of 'set -v' -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Review Request: HIVE-2319: Calling alter_table after changing partition key comment throws an exception
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1213/#review1215 --- trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java https://reviews.apache.org/r/1213/#comment2712 Actually, we can't allow for a different ordering because that would imply a different directory structure. We should just make sure that everything but the comments are equal. trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java https://reviews.apache.org/r/1213/#comment2713 Message should say - it was able to change when it shouldn't have? - Paul On 2011-07-28 07:06:24, Sohan Jain wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1213/ --- (Updated 2011-07-28 07:06:24) Review request for hive and Paul Yang. Summary --- Altering a table's partition key comments raises an InvalidOperationException. The partition key name and type should not be mutable, but the comment should be able to get changed. This addresses bug HIVE-2319. https://issues.apache.org/jira/browse/HIVE-2319 Diffs - trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1151219 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 1151219 Diff: https://reviews.apache.org/r/1213/diff Testing --- Added some test cases to HiveMetaStore that pass. Thanks, Sohan
Re: Review Request: HIVE-2272: add TIMESTAMP data type
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1135/ --- (Updated 2011-07-28 21:59:38.146393) Review request for hive, Yongqiang He, Ning Zhang, and Siying Dong. Changes --- Add corresponding UDF for converting to UTC from a localized timestamp Summary --- Adds TIMESTAMP type to serde2 with both string (LazySimple) and binary (LazyBinary) serialization. Supports SQL style jdbc timestamps of the format with nanosecond precision -MM-DD HH:MM:SS[.fff...] This addresses bug HIVE-2272. https://issues.apache.org/jira/browse/HIVE-2272 Diffs (updated) - trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1152003 trunk/conf/hive-default.xml 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDate.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateAdd.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateDiff.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateSub.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDayOfMonth.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFHour.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFMinute.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFMonth.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSecond.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToBoolean.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToByte.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToDouble.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToFloat.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToInteger.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToLong.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToShort.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToString.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFUnixTimeStamp.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFWeekOfYear.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFYear.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFAverage.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFContextNGrams.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCorrelation.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCovariance.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCovarianceSample.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFHistogramNumeric.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFPercentileApprox.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFStd.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFStdSample.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFVariance.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFVarianceSample.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFnGrams.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFromUtcTimestamp.java PRE-CREATION trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTimestamp.java PRE-CREATION trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToUtcTimestamp.java PRE-CREATION trunk/ql/src/test/queries/clientnegative/invalid_t_create3.q 1152003 trunk/ql/src/test/queries/clientpositive/timestamp_1.q PRE-CREATION trunk/ql/src/test/queries/clientpositive/timestamp_2.q PRE-CREATION trunk/ql/src/test/queries/clientpositive/timestamp_3.q PRE-CREATION trunk/ql/src/test/queries/clientpositive/timestamp_comparison.q PRE-CREATION trunk/ql/src/test/queries/clientpositive/timestamp_udf.q PRE-CREATION trunk/ql/src/test/results/clientnegative/invalid_create_tbl1.q.out 1152003 trunk/ql/src/test/results/clientnegative/invalid_t_alter1.q.out 1152003 trunk/ql/src/test/results/clientnegative/invalid_t_alter2.q.out
[jira] [Commented] (HIVE-2272) add TIMESTAMP data type
[ https://issues.apache.org/jira/browse/HIVE-2272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13072553#comment-13072553 ] jirapos...@reviews.apache.org commented on HIVE-2272: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1135/ --- (Updated 2011-07-28 21:59:38.146393) Review request for hive, Yongqiang He, Ning Zhang, and Siying Dong. Changes --- Add corresponding UDF for converting to UTC from a localized timestamp Summary --- Adds TIMESTAMP type to serde2 with both string (LazySimple) and binary (LazyBinary) serialization. Supports SQL style jdbc timestamps of the format with nanosecond precision -MM-DD HH:MM:SS[.fff...] This addresses bug HIVE-2272. https://issues.apache.org/jira/browse/HIVE-2272 Diffs (updated) - trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1152003 trunk/conf/hive-default.xml 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDate.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateAdd.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateDiff.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateSub.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDayOfMonth.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFHour.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFMinute.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFMonth.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSecond.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToBoolean.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToByte.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToDouble.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToFloat.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToInteger.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToLong.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToShort.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToString.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFUnixTimeStamp.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFWeekOfYear.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFYear.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFAverage.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFContextNGrams.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCorrelation.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCovariance.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCovarianceSample.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFHistogramNumeric.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFPercentileApprox.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFStd.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFStdSample.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFVariance.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFVarianceSample.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFnGrams.java 1152003 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFromUtcTimestamp.java PRE-CREATION trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTimestamp.java PRE-CREATION trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToUtcTimestamp.java PRE-CREATION trunk/ql/src/test/queries/clientnegative/invalid_t_create3.q 1152003 trunk/ql/src/test/queries/clientpositive/timestamp_1.q PRE-CREATION trunk/ql/src/test/queries/clientpositive/timestamp_2.q PRE-CREATION trunk/ql/src/test/queries/clientpositive/timestamp_3.q PRE-CREATION trunk/ql/src/test/queries/clientpositive/timestamp_comparison.q PRE-CREATION
[jira] [Commented] (HIVE-2322) Add ColumnarSerDe to the list of native SerDes
[ https://issues.apache.org/jira/browse/HIVE-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13072565#comment-13072565 ] Paul Yang commented on HIVE-2322: - +1 Will test and commit Add ColumnarSerDe to the list of native SerDes -- Key: HIVE-2322 URL: https://issues.apache.org/jira/browse/HIVE-2322 Project: Hive Issue Type: Bug Components: Metastore, Serializers/Deserializers Reporter: Sohan Jain Assignee: Sohan Jain Attachments: HIVE-2322.1.patch We store metadata about ColumnarSerDes in the metastore, so it should be considered a native SerDe. Then, column information can be retrieved from the metastore instead of from deserialization. Currently, for non-native SerDes, column comments are only shown as from deserializer. Adding ColumnarSerDe to the list of native SerDes will persist column comments. See HIVE-2171 for persisting the column comments of custom SerDes. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Review Request: HIVE-2319: Calling alter_table after changing partition key comment throws an exception
On 2011-07-28 21:51:59, Paul Yang wrote: trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java, lines 232-233 https://reviews.apache.org/r/1213/diff/2/?file=28094#file28094line232 Actually, we can't allow for a different ordering because that would imply a different directory structure. We should just make sure that everything but the comments are equal. Ok cool, that cleans up the code quite a bit. The previous implementation only checked if the partition key lists were of the same size, and one contained all elements of the other. That is, it did not ensure ordering. On 2011-07-28 21:51:59, Paul Yang wrote: trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java, line 1036 https://reviews.apache.org/r/1213/diff/2/?file=28095#file28095line1036 Message should say - it was able to change when it shouldn't have? Fixed - Sohan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1213/#review1215 --- On 2011-07-28 07:06:24, Sohan Jain wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1213/ --- (Updated 2011-07-28 07:06:24) Review request for hive and Paul Yang. Summary --- Altering a table's partition key comments raises an InvalidOperationException. The partition key name and type should not be mutable, but the comment should be able to get changed. This addresses bug HIVE-2319. https://issues.apache.org/jira/browse/HIVE-2319 Diffs - trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1151219 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 1151219 Diff: https://reviews.apache.org/r/1213/diff Testing --- Added some test cases to HiveMetaStore that pass. Thanks, Sohan
Re: Review Request: HIVE-2319: Calling alter_table after changing partition key comment throws an exception
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1213/ --- (Updated 2011-07-28 23:26:15.868719) Review request for hive and Paul Yang. Changes --- -made changes based on Paul's comments Summary --- Altering a table's partition key comments raises an InvalidOperationException. The partition key name and type should not be mutable, but the comment should be able to get changed. This addresses bug HIVE-2319. https://issues.apache.org/jira/browse/HIVE-2319 Diffs (updated) - trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1152020 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 1152020 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1152020 Diff: https://reviews.apache.org/r/1213/diff Testing --- Added some test cases to HiveMetaStore that pass. Thanks, Sohan
[jira] [Updated] (HIVE-2298) Fix UDAFPercentile to tolerate null percentiles
[ https://issues.apache.org/jira/browse/HIVE-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vaibhav Aggarwal updated HIVE-2298: --- Attachment: HIVE-2259-2.patch Fix UDAFPercentile to tolerate null percentiles --- Key: HIVE-2298 URL: https://issues.apache.org/jira/browse/HIVE-2298 Project: Hive Issue Type: Bug Components: UDF Affects Versions: 0.7.0 Reporter: Vaibhav Aggarwal Assignee: Vaibhav Aggarwal Attachments: HIVE-2259-2.patch, HIVE-2298.patch UDAFPercentile when passed null percentile list will throw a null pointer exception. Submitting a small fix for that. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2307) Schema creation scripts for PostgreSQL use bit(1) instead of boolean
[ https://issues.apache.org/jira/browse/HIVE-2307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13072633#comment-13072633 ] Hudson commented on HIVE-2307: -- Integrated in Hive-trunk-h0.21 #857 (See [https://builds.apache.org/job/Hive-trunk-h0.21/857/]) HIVE-2307. Schema creation scripts for PostgreSQL use bit(1) instead of boolean (Esteban Gutierrez via cws) cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1151949 Files : * /hive/trunk/metastore/scripts/upgrade/postgres/hive-schema-0.7.0.postgres.sql * /hive/trunk/metastore/scripts/upgrade/postgres/hive-schema-0.4.1.postgres.sql * /hive/trunk/metastore/scripts/upgrade/postgres/hive-schema-0.5.0.postgres.sql * /hive/trunk/metastore/scripts/upgrade/postgres/hive-schema-0.4.0.postgres.sql * /hive/trunk/metastore/scripts/upgrade/postgres/upgrade-0.6.0-to-0.7.0.postgres.sql * /hive/trunk/metastore/scripts/upgrade/postgres/hive-schema-0.3.0.postgres.sql Schema creation scripts for PostgreSQL use bit(1) instead of boolean Key: HIVE-2307 URL: https://issues.apache.org/jira/browse/HIVE-2307 Project: Hive Issue Type: Bug Components: Configuration, Metastore Affects Versions: 0.5.0, 0.6.0, 0.7.0, 0.7.1 Reporter: Esteban Gutierrez Assignee: Esteban Gutierrez Labels: metastore, postgres Fix For: 0.8.0 Attachments: HIVE-2307.1.patch.txt The specified type for DEFERRED_REBUILD (IDXS) and IS_COMPRESSED (SDS) columns in the metastore is defined as bit(1) type which is not supported by PostgreSQL JDBC. hive create table test (id int); FAILED: Error in metadata: javax.jdo.JDODataStoreException: Insert of object org.apache.hadoop.hive.metastore.model.MStorageDescriptor@4f1adeb7 using statement INSERT INTO SDS (SD_ID,INPUT_FORMAT,OUTPUT_FORMAT,LOCATION,SERDE_ID,NUM_BUCKETS,IS_COMPRESSED) VALUES (?,?,?,?,?,?,?) failed : ERROR: column IS_COMPRESSED is of type bit but expression is of type boolean -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2194) Add actions for alter table and alter partition events for metastore event listeners
[ https://issues.apache.org/jira/browse/HIVE-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13072676#comment-13072676 ] Hudson commented on HIVE-2194: -- Integrated in Hive-trunk-h0.21 #858 (See [https://builds.apache.org/job/Hive-trunk-h0.21/858/]) HIVE-2276. Fix Inconsistency between RB and JIRA patches for HIVE-2194 (Sohan Jain via cws) cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1152007 Files : * /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java Add actions for alter table and alter partition events for metastore event listeners Key: HIVE-2194 URL: https://issues.apache.org/jira/browse/HIVE-2194 Project: Hive Issue Type: Improvement Components: Metastore Reporter: Sohan Jain Assignee: Sohan Jain Fix For: 0.8.0 Attachments: HIVE-2194.1.patch, HIVE-2194.3.patch, HIVE-2194.4.patch HIVE-2038 introduced the MetaStoreEventListener abstract class that defines actions to be performed after particular events on a metastore. Improve upon that class by adding events to be performed on alter table and alter partition actions. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2276) Fix Inconsistency between RB and JIRA patches for HIVE-2194
[ https://issues.apache.org/jira/browse/HIVE-2276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13072675#comment-13072675 ] Hudson commented on HIVE-2276: -- Integrated in Hive-trunk-h0.21 #858 (See [https://builds.apache.org/job/Hive-trunk-h0.21/858/]) HIVE-2276. Fix Inconsistency between RB and JIRA patches for HIVE-2194 (Sohan Jain via cws) cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1152007 Files : * /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java Fix Inconsistency between RB and JIRA patches for HIVE-2194 --- Key: HIVE-2276 URL: https://issues.apache.org/jira/browse/HIVE-2276 Project: Hive Issue Type: Bug Components: Metastore Reporter: Sohan Jain Assignee: Sohan Jain Fix For: 0.8.0 Attachments: HIVE-2276.1.patch The RB and JIRA patches for HIVE-2194 were out of sync. An outdated patch for HIVE-2194 was committed. This patch updates that patch to include the changes from RB. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira