Re: Review Request 31152: HIVE-9582: HCatalog should use IMetaStoreClient interface
On Feb. 26, 2015, 10:12 p.m., Thejas Nair wrote: hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TempletonControllerJob.java, line 176 https://reviews.apache.org/r/31152/diff/1/?file=867387#file867387line176 shouldn't this be client.getDelegationToken(c.getUser(), u) ? Thanks Thejas, I will check on the first set of comments and update the patch. - Thiruvel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31152/#review74374 --- On Feb. 18, 2015, 6:58 a.m., Thiruvel Thirumoolan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31152/ --- (Updated Feb. 18, 2015, 6:58 a.m.) Review request for hive. Repository: hive-git Description --- HIVE-9582: HCatalog should use IMetaStoreClient interface Diffs - hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HCatUtil.java 63909b893b4be32647a0d91e58bc0dca86bcabd9 hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HiveClientCache.java a001252faaf9949b6d2f0e3110c2b343b9648a91 hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/DefaultOutputCommitterContainer.java cead40d6eb7df285987c92b58021246e888dc502 hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FileOutputCommitterContainer.java bf2ba5a1c9135bb99cb12b4111e60e2b0a2ea10f hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FileOutputFormatContainer.java 1cd5306aafb9b3ec61c31fb6504c8082b47ed2ae hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/HCatOutputFormat.java 694739821a202780818924d54d10edb707cfbcfa hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/InitializeInput.java 1980ef50af42499e0fed8863b6ff7a45f926d9fc hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/Security.java 39ef86e4c3d521b310f9b2dc2f154ae5a555ab06 hcatalog/core/src/test/java/org/apache/hive/hcatalog/common/TestHiveClientCache.java 63a55482f7e9115f5626c5cde036597248459118 hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestPassProperties.java f8a0af14e3d0b9dc5005f1c2f390f4e2dc054145 hcatalog/hcatalog-pig-adapter/src/main/java/org/apache/hive/hcatalog/pig/PigHCatUtil.java 48a40b1c11d44c6d53d8f58b7ea91f090e72920f hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/AbstractRecordWriter.java 8c4bca02abeda7eb89ea0deacdfb2e06c9fda7f8 hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java a08f2f97e4e297873250ac8d16c7679c2de901f0 hcatalog/webhcat/java-client/src/main/java/org/apache/hive/hcatalog/api/HCatClientHMSImpl.java cd05254f4e138b7c1ec7d9424c90416b25f93462 hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/CompleteDelegator.java 1b9663d2d0e2e0d94b520ed6760415be441c7ab4 hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/SecureProxySupport.java 8ae61a1e330b56037dd7440fa888e431c65fc158 hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TempletonControllerJob.java 53eecfa990bcaab247ae8bc4df221742bd166081 metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 0aa0f515d9d15d442d31e32a63586d119c30494e Diff: https://reviews.apache.org/r/31152/diff/ Testing --- All hcatalog unit tests pass. Thanks, Thiruvel Thirumoolan
[jira] [Created] (HIVE-9809) Fix FindBugs found bugs in hive-exec
Alexander Pivovarov created HIVE-9809: - Summary: Fix FindBugs found bugs in hive-exec Key: HIVE-9809 URL: https://issues.apache.org/jira/browse/HIVE-9809 Project: Hive Issue Type: Bug Reporter: Alexander Pivovarov Assignee: Alexander Pivovarov FindBugs finds several bugs in hive-exec project -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-9808) LLAP: Push work into daemons instead of the current pull
Siddharth Seth created HIVE-9808: Summary: LLAP: Push work into daemons instead of the current pull Key: HIVE-9808 URL: https://issues.apache.org/jira/browse/HIVE-9808 Project: Hive Issue Type: Sub-task Reporter: Siddharth Seth Assignee: Siddharth Seth Fix For: llap -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [ANNOUNCE] New Hive PMC Member - Sergey Shelukhin
Congratulations and keep up the great work! +Vinod On Feb 25, 2015, at 8:43 AM, Carl Steinbach c...@apache.org wrote: I am pleased to announce that Sergey Shelukhin has been elected to the Hive Project Management Committee. Please join me in congratulating Sergey! Thanks. - Carl
Re: Review Request 31404: HIVE-9744 Move common arguments validation and value extraction code to GenericUDF
On Feb. 26, 2015, 10:37 p.m., Jason Dere wrote: ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java, line 459 https://reviews.apache.org/r/31404/diff/1-2/?file=875138#file875138line459 Not a fan of these timestamp-related changes. It's causing you to have to create 2 new arrays of Converters which seems awkward. I was going to suggest simply using a DateConverter, but I see that the original behavior also allowed timestamp format strings (really, it allowed anything after the '-mm-dd' part). Rather than have 2 different converters, maybe just go back to what you had before, use a single converter to string, and then just apply whatever format logic you are going to apply to the string value. Sure I can use SimpleDateFormat(-MM-dd) to convert short and long strings to Date. That was the original behaviour in last_day, next_day, add_months. methods (obtainDateConvertor and getDateValue) I also noticed that GenericUDFFromUtcTimestamp uses TimestampConverter for all input types. To support this behaviour I created 2 methods (obtainTimestampConvertor and getTimestampValue) On Feb. 26, 2015, 10:37 p.m., Jason Dere wrote: ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFNextDay.java, line 80 https://reviews.apache.org/r/31404/diff/2/?file=878682#file878682line80 So this is actually an example of something that used to be valid input, but no longer works due to the change from SimpleDateFormat to Timestamp/Date converter. This would be ok for the UDFs you've changed since they are new ones, but I don't know if this kind of change in behavior would be something that would be a concern if we were to apply this same refactoring to some of the other date-related UDFs. fixed this. all selects in last_day, next_day, add_months q files return what they originally returned now - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31404/#review74371 --- On Feb. 26, 2015, 9:16 p.m., Alexander Pivovarov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31404/ --- (Updated Feb. 26, 2015, 9:16 p.m.) Review request for hive, Jason Dere and Thejas Nair. Bugs: HIVE-9744 https://issues.apache.org/jira/browse/HIVE-9744 Repository: hive-git Description --- HIVE-9744 Move common arguments validation and value extraction code to GenericUDF Diffs - ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java 8a0f573648c51c4945be8ffec4a0b06dfa7061c8 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddMonths.java c5968835a74195bea6b31a5c7b7346907fed5ce0 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInitCap.java 406fcd608a13fadb8902bf273932acb05a0f3bbe ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLastDay.java 3a43c571ae3a83924a00413181a62ce6f4408125 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLevenstein.java de41793ba3925aa9e1ad9623d92881c57791f047 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFNextDay.java 38f08b74609a4018221ca3f5b92cf33799604d60 ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFAddMonths.java 4ccae97a227257294d69f728426f425d060ef0c7 ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFLastDay.java 4b233a6966bbdf6902c53f2aaf53cc0eb422b205 ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFLevenshtein.java e674d9f38cf7b5cdffcad6eca07dba74ff1e834b ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFNextDay.java e2ec551d4ae39d521680ee93c791f14f27811270 ql/src/test/queries/clientpositive/udf_next_day.q db821f00c39b84c4bc59ea70b0cc0aacf69cbd18 ql/src/test/results/clientnegative/udf_add_months_error_1.q.out 8226ac6fe89c38fcc14edeea215cd5cce7258683 ql/src/test/results/clientnegative/udf_add_months_error_2.q.out f00949e9a12285cc91032215372975753c1f3b4a ql/src/test/results/clientnegative/udf_last_day_error_1.q.out 6e718a0c15e84d89b1cfe7f36231e472ff03c37f ql/src/test/results/clientnegative/udf_last_day_error_2.q.out dc8e3d14f14205ce65355cd53a95cfc788f45fe0 ql/src/test/results/clientnegative/udf_next_day_error_1.q.out c67b9c42f7e7fdf20caa34d028b02fd4819e8343 ql/src/test/results/clientnegative/udf_next_day_error_2.q.out e3cb6a447bf7bd9f09648e46ace1bcba4da55339 ql/src/test/results/clientpositive/udf_add_months.q.out 8c37fc282a25e350435ff6a4b39e02fc2d4f17df ql/src/test/results/clientpositive/udf_last_day.q.out 2d39e3897625c7651b110779b89652f0d785bc92 Diff:
Review Request 31488: HIVE-9797 Need update some spark tests for java 8
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31488/ --- Review request for hive and Brock Noland. Bugs: HIVE-9797 https://issues.apache.org/jira/browse/HIVE-9797 Repository: hive-git Description --- Updated spark unit tests for java 8 Diffs - ql/src/test/queries/clientpositive/vector_cast_constant.q c2b81bffc2fbf55b78bd5cc721f6e595b4c68fa2 ql/src/test/results/clientpositive/spark/list_bucket_dml_10.q.java1.8.out PRE-CREATION ql/src/test/results/clientpositive/spark/outer_join_ppr.q.java1.8.out PRE-CREATION ql/src/test/results/clientpositive/spark/vector_cast_constant.q.java1.7.out PRE-CREATION ql/src/test/results/clientpositive/spark/vector_cast_constant.q.java1.8.out PRE-CREATION ql/src/test/results/clientpositive/vector_cast_constant.q.java1.7.out PRE-CREATION ql/src/test/results/clientpositive/vector_cast_constant.q.java1.8.out PRE-CREATION Diff: https://reviews.apache.org/r/31488/diff/ Testing --- Thanks, Sergio Pena
[jira] [Created] (HIVE-9797) Need update some spark tests for java 8
Sergio Peña created HIVE-9797: - Summary: Need update some spark tests for java 8 Key: HIVE-9797 URL: https://issues.apache.org/jira/browse/HIVE-9797 Project: Hive Issue Type: Bug Affects Versions: 1.2.0 Reporter: Sergio Peña Assignee: Sergio Peña The following tests fail on a java 8 environment: TestMiniSparkOnYarnCliDriver.list_bucket_dml_10 TestSparkCliDriver.outer_join_ppr TestSparkCliDriver.vector_cast_constant -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 31452: HIVE-9781 Utilize spark.kryo.classesToRegister [Spark Branch]
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31452/#review74273 --- ql/src/java/org/apache/hadoop/hive/ql/exec/spark/RemoteHiveSparkClient.java https://reviews.apache.org/r/31452/#comment120817 Could we rename this variable for better readability? - Xuefu Zhang On Feb. 26, 2015, 1:42 a.m., Jimmy Xiang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31452/ --- (Updated Feb. 26, 2015, 1:42 a.m.) Review request for hive, Brock Noland and Xuefu Zhang. Bugs: HIVE-9781 https://issues.apache.org/jira/browse/HIVE-9781 Repository: hive-git Description --- Now, Spark RSC can use setting spark.kryo.classesToRegister. Reference checking is still needed since there are loops. Diffs - ql/src/java/org/apache/hadoop/hive/ql/exec/spark/KryoSerializer.java 76a4fd1 ql/src/java/org/apache/hadoop/hive/ql/exec/spark/RemoteHiveSparkClient.java f1d65ea Diff: https://reviews.apache.org/r/31452/diff/ Testing --- Tested it on a yarn cluster with spark.kryo.classesToRegister set. Thanks, Jimmy Xiang
[jira] [Created] (HIVE-9796) CBO (Calcite Return Path): Add field nullable check to HiveJoinAddNotNullRule [CBO branch]
Jesus Camacho Rodriguez created HIVE-9796: - Summary: CBO (Calcite Return Path): Add field nullable check to HiveJoinAddNotNullRule [CBO branch] Key: HIVE-9796 URL: https://issues.apache.org/jira/browse/HIVE-9796 Project: Hive Issue Type: Sub-task Reporter: Jesus Camacho Rodriguez Assignee: Jesus Camacho Rodriguez -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-9795) Add rule to insert not null filtering on join keys
Jesus Camacho Rodriguez created HIVE-9795: - Summary: Add rule to insert not null filtering on join keys Key: HIVE-9795 URL: https://issues.apache.org/jira/browse/HIVE-9795 Project: Hive Issue Type: Bug Reporter: Jesus Camacho Rodriguez Assignee: Jesus Camacho Rodriguez Adding a Calcite rule that introduces _not null_ filtering on join keys. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [ANNOUNCE] New Hive PMC Member - Sergey Shelukhin
Congrats Sergey! On Thu, Feb 26, 2015 at 9:22 AM, Nick Dimiduk ndimi...@gmail.com wrote: Nice work Sergey! On Wednesday, February 25, 2015, Carl Steinbach c...@apache.org wrote: I am pleased to announce that Sergey Shelukhin has been elected to the Hive Project Management Committee. Please join me in congratulating Sergey! Thanks. - Carl
Re: Review Request 31452: HIVE-9781 Utilize spark.kryo.classesToRegister [Spark Branch]
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31452/ --- (Updated Feb. 26, 2015, 5:39 p.m.) Review request for hive, Brock Noland and Xuefu Zhang. Bugs: HIVE-9781 https://issues.apache.org/jira/browse/HIVE-9781 Repository: hive-git Description --- Now, Spark RSC can use setting spark.kryo.classesToRegister. Reference checking is still needed since there are loops. Diffs (updated) - ql/src/java/org/apache/hadoop/hive/ql/exec/spark/KryoSerializer.java 76a4fd1 ql/src/java/org/apache/hadoop/hive/ql/exec/spark/RemoteHiveSparkClient.java f1d65ea Diff: https://reviews.apache.org/r/31452/diff/ Testing --- Tested it on a yarn cluster with spark.kryo.classesToRegister set. Thanks, Jimmy Xiang
Re: [ANNOUNCE] New Hive PMC Member - Sergey Shelukhin
Congrats Sergey! On Thu, Feb 26, 2015 at 12:22 AM, Lefty Leverenz leftylever...@gmail.com wrote: Way to go Sergey! -- Lefty On Wed, Feb 25, 2015 at 4:19 PM, Sergey Shelukhin ser...@hortonworks.com wrote: Thanks guys! On 15/2/25, 16:02, Xiaobing Zhou xz...@hortonworks.com wrote: Congrats Sergey! On Feb 25, 2015, at 1:56 PM, Prasanth Jayachandran pjayachand...@hortonworks.com wrote: Congrats Sergey! On Feb 25, 2015, at 1:50 PM, Alexander Pivovarov apivova...@gmail.commailto:apivova...@gmail.com wrote: Congrats! On Wed, Feb 25, 2015 at 12:33 PM, Vaibhav Gumashta vgumas...@hortonworks.commailto:vgumas...@hortonworks.com wrote: Congrats Sergey! On 2/25/15, 9:06 AM, Vikram Dixit vik...@hortonworks.commailto:vik...@hortonworks.com wrote: Congrats Sergey! On 2/25/15, 8:43 AM, Carl Steinbach c...@apache.orgmailto:c...@apache.org wrote: I am pleased to announce that Sergey Shelukhin has been elected to the Hive Project Management Committee. Please join me in congratulating Sergey! Thanks. - Carl
Re: Review Request 31452: HIVE-9781 Utilize spark.kryo.classesToRegister [Spark Branch]
On Feb. 26, 2015, 2:53 p.m., Xuefu Zhang wrote: ql/src/java/org/apache/hadoop/hive/ql/exec/spark/RemoteHiveSparkClient.java, line 152 https://reviews.apache.org/r/31452/diff/1/?file=877054#file877054line152 Could we rename this variable for better readability? Sure. - Jimmy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31452/#review74273 --- On Feb. 26, 2015, 1:42 a.m., Jimmy Xiang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31452/ --- (Updated Feb. 26, 2015, 1:42 a.m.) Review request for hive, Brock Noland and Xuefu Zhang. Bugs: HIVE-9781 https://issues.apache.org/jira/browse/HIVE-9781 Repository: hive-git Description --- Now, Spark RSC can use setting spark.kryo.classesToRegister. Reference checking is still needed since there are loops. Diffs - ql/src/java/org/apache/hadoop/hive/ql/exec/spark/KryoSerializer.java 76a4fd1 ql/src/java/org/apache/hadoop/hive/ql/exec/spark/RemoteHiveSparkClient.java f1d65ea Diff: https://reviews.apache.org/r/31452/diff/ Testing --- Tested it on a yarn cluster with spark.kryo.classesToRegister set. Thanks, Jimmy Xiang
Re: [ANNOUNCE] New Hive PMC Member - Sergey Shelukhin
Nice work Sergey! On Wednesday, February 25, 2015, Carl Steinbach c...@apache.org wrote: I am pleased to announce that Sergey Shelukhin has been elected to the Hive Project Management Committee. Please join me in congratulating Sergey! Thanks. - Carl
Re: [ANNOUNCE] New Hive PMC Member - Sergey Shelukhin
Well done Sergey! From: Jimmy Xiang jxi...@cloudera.com Sent: Thursday, February 26, 2015 9:26 AM To: u...@hive.apache.org Cc: dev@hive.apache.org; ser...@apache.org Subject: Re: [ANNOUNCE] New Hive PMC Member - Sergey Shelukhin Congrats Sergey! On Thu, Feb 26, 2015 at 9:22 AM, Nick Dimiduk ndimi...@gmail.com wrote: Nice work Sergey! On Wednesday, February 25, 2015, Carl Steinbach c...@apache.org wrote: I am pleased to announce that Sergey Shelukhin has been elected to the Hive Project Management Committee. Please join me in congratulating Sergey! Thanks. - Carl
[jira] [Created] (HIVE-9798) Slash character in HDFS file is displayed as double Slash in Hive
Anitha created HIVE-9798: Summary: Slash character in HDFS file is displayed as double Slash in Hive Key: HIVE-9798 URL: https://issues.apache.org/jira/browse/HIVE-9798 Project: Hive Issue Type: Bug Reporter: Anitha Single slash character in source is displayed as double slash in HIVE. Example: Oracle Source: BOB RICHARD TOY\N AUGUSTA Hive = BOB RICHARD TOY\\N AUGUSTA Note: HDFS file has correct data, single slash only. Also, Impala displays the data correctly, issue is with Hive display only. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 31222: HIVE-9738 create SOUNDEX udf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31222/#review74348 --- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSoundex.java https://reviews.apache.org/r/31222/#comment120919 Looks like Soundex.soundex() can return IllegalArgumentException for some unmapped characters - perhaps return null in this case to avoid aborting the entire query on this error. - Jason Dere On Feb. 20, 2015, 7:19 a.m., Alexander Pivovarov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31222/ --- (Updated Feb. 20, 2015, 7:19 a.m.) Review request for hive, Alan Gates and Jason Dere. Bugs: HIVE-9738 https://issues.apache.org/jira/browse/HIVE-9738 Repository: hive-git Description --- HIVE-9738 create SOUNDEX udf Diffs - ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java bfeb33c9edf79071bf106a3780e1c6bc21be3753 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSoundex.java PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFSoundex.java PRE-CREATION ql/src/test/queries/clientpositive/udf_soundex.q PRE-CREATION ql/src/test/results/clientpositive/show_functions.q.out d4b06507f2356cc58ff7312ff78261406f3ceb4f ql/src/test/results/clientpositive/udf_soundex.q.out PRE-CREATION Diff: https://reviews.apache.org/r/31222/diff/ Testing --- Thanks, Alexander Pivovarov
Re: Review Request 30335: Build UDF TRUNC to implement FIRST_DAY as compared with LAST_DAY
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30335/#review74315 --- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTrunc.java https://reviews.apache.org/r/30335/#comment120885 Can you remove this commented code from the patch? - Jason Dere On Feb. 25, 2015, 11:35 p.m., XIAOBING ZHOU wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30335/ --- (Updated Feb. 25, 2015, 11:35 p.m.) Review request for hive. Repository: hive-git Description --- Hive already supports LAST_DAY UDF, in some cases, FIRST_DAY is necessary to do date/timestamp related computation. This JIRA is to track such an implementation. https://issues.apache.org/jira/browse/HIVE-9480 Diffs - ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java bfeb33c ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTrunc.java PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFTrunc.java PRE-CREATION ql/src/test/queries/clientnegative/udf_trunc_error1.q PRE-CREATION ql/src/test/queries/clientnegative/udf_trunc_error2.q PRE-CREATION ql/src/test/queries/clientpositive/udf_trunc.q PRE-CREATION ql/src/test/results/clientnegative/udf_trunc_error1.q.out PRE-CREATION ql/src/test/results/clientnegative/udf_trunc_error2.q.out PRE-CREATION ql/src/test/results/clientpositive/show_functions.q.out d4b0650 ql/src/test/results/clientpositive/udf_trunc.q.out PRE-CREATION Diff: https://reviews.apache.org/r/30335/diff/ Testing --- Unit tests done in ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFFirstDay.java Thanks, XIAOBING ZHOU
Re: Review Request 31249: Refactor MetaStoreDirectSql constructor by removing DB queries out of critical section
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31249/ --- (Updated Feb. 26, 2015, 8:53 p.m.) Review request for hive. Changes --- added doDbSpecificInitializationsBeforeQuery in runTestQuery Repository: hive-git Description --- MetaStoreDirectSql constructor is querying DB to determine dbType, which leads to too many DB queries to make megastore slow as ObjectStore.setConf might be called frequently. Moreover, ObjectStore.setConf begins/ends with lock acquire/release, if the underlying DB hangs somehow, lock is never released and all hereafter incoming requests are blocked. Two points: 1. Using getProductName based JDBC driver to get dbType info. 2. Since metastore auto-creaton is disabled by default, it'd better bypass ensureDbInit() and runTestQuery() in order to avoid DB queries within critical section of setConf. Here’s stack trace: MetaStoreDirectSql.determineDbType(...) MetaStoreDirectSql.MetaStoreDirectSql(...) ObjectStore.initialize(...) ObjectStore.setConf(…) https://issues.apache.org/jira/browse/HIVE-9741 Diffs (updated) - metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 574141c Diff: https://reviews.apache.org/r/31249/diff/ Testing --- Thanks, XIAOBING ZHOU
Re: Not getting some JIRA resolution messages
I think you get subsequent messages only if you're a watcher. You become a watcher after you comment or make changes for a JIRA. Is this your case? On Thu, Feb 26, 2015 at 1:05 PM, Lefty Leverenz leftylever...@gmail.com wrote: Is it just me, or has JIRA email been flaky since the issues mailing list went into effect? For example, although I got a commit message for HIVE-9731 https://issues.apache.org/jira/browse/HIVE-9731 on the commits@hive mailing list, I didn't get either the change of Resolution or the comment about the commit -- not on dev@hive nor on issues@hive. However I did get two subsequent messages on issues@hive when I added a TODOC1.2 label and doc comment. Another example: for HIVE-9509 https://issues.apache.org/jira/browse/HIVE-9509 I got the commit comment and Fix Version change for branch-1.0.1 on the issues@hive list but not the prior commit comment and Resolved - Fix Version for 1.2.0. Does anyone else have this problem? -- Lefty
[jira] [Created] (HIVE-9799) LLAP: config not passed to daemon init
Sergey Shelukhin created HIVE-9799: -- Summary: LLAP: config not passed to daemon init Key: HIVE-9799 URL: https://issues.apache.org/jira/browse/HIVE-9799 Project: Hive Issue Type: Sub-task Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Priority: Trivial -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Not getting some JIRA resolution messages
Is it just me, or has JIRA email been flaky since the issues mailing list went into effect? For example, although I got a commit message for HIVE-9731 https://issues.apache.org/jira/browse/HIVE-9731 on the commits@hive mailing list, I didn't get either the change of Resolution or the comment about the commit -- not on dev@hive nor on issues@hive. However I did get two subsequent messages on issues@hive when I added a TODOC1.2 label and doc comment. Another example: for HIVE-9509 https://issues.apache.org/jira/browse/HIVE-9509 I got the commit comment and Fix Version change for branch-1.0.1 on the issues@hive list but not the prior commit comment and Resolved - Fix Version for 1.2.0. Does anyone else have this problem? -- Lefty
Re: Review Request 31404: HIVE-9744 Move common arguments validation and value extraction code to GenericUDF
On Feb. 26, 2015, 7:46 a.m., Jason Dere wrote: ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java, line 383 https://reviews.apache.org/r/31404/diff/1/?file=875138#file875138line383 Why go away from using the formatter as it was doing before? Are there any ramifications here to switching to Timestamp.valueOf()? I think Timestamp.valueOf() is probably less forgiving when checking the format. Instead of Timestamp.valueOf and SimpleDateFormat.parse I'm going to use PrimitiveObjectInspectorConverter.DateConverters and TimestempConverters to convert string to Date/Timestamp. Internally converters use Date.valueOf (PrimitiveObjectInspectorUtils lines 999, 1008) and Timestamp.valueOf (PrimitiveObjectInspectorUtils line 1099). Timestamp.valueOf supports optional milliseconds part (from 1 to 9 digits) On Feb. 26, 2015, 7:46 a.m., Jason Dere wrote: ql/src/test/results/clientpositive/udf_last_day.q.out, line 67 https://reviews.apache.org/r/31404/diff/1/?file=875155#file875155line67 What's the cause of the output difference here? I use ObjectInspectorConverters.getConverter to get DateConverters and TimestempConverters to convert string to Date/Timestamp. I noticed that DateConverter can convert 2014-02-30 to non-null Date but 2014-02-32 is converted to null. In this particular case the function deals with 2014-01-34. DateConverter converts it to null (which is right because 2014-01-34 is not valid date). - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31404/#review74226 --- On Feb. 25, 2015, 3:57 a.m., Alexander Pivovarov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31404/ --- (Updated Feb. 25, 2015, 3:57 a.m.) Review request for hive, Jason Dere and Thejas Nair. Bugs: HIVE-9744 https://issues.apache.org/jira/browse/HIVE-9744 Repository: hive-git Description --- HIVE-9744 Move common arguments validation and value extraction code to GenericUDF Diffs - ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java 8a0f573648c51c4945be8ffec4a0b06dfa7061c8 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddMonths.java c5968835a74195bea6b31a5c7b7346907fed5ce0 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInitCap.java 406fcd608a13fadb8902bf273932acb05a0f3bbe ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLastDay.java 3a43c571ae3a83924a00413181a62ce6f4408125 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLevenstein.java de41793ba3925aa9e1ad9623d92881c57791f047 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFNextDay.java 38f08b74609a4018221ca3f5b92cf33799604d60 ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFAddMonths.java 4ccae97a227257294d69f728426f425d060ef0c7 ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFLevenshtein.java e674d9f38cf7b5cdffcad6eca07dba74ff1e834b ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFNextDay.java e2ec551d4ae39d521680ee93c791f14f27811270 ql/src/test/queries/clientpositive/udf_next_day.q db821f00c39b84c4bc59ea70b0cc0aacf69cbd18 ql/src/test/results/clientnegative/udf_add_months_error_1.q.out 8226ac6fe89c38fcc14edeea215cd5cce7258683 ql/src/test/results/clientnegative/udf_add_months_error_2.q.out f00949e9a12285cc91032215372975753c1f3b4a ql/src/test/results/clientnegative/udf_last_day_error_1.q.out 6e718a0c15e84d89b1cfe7f36231e472ff03c37f ql/src/test/results/clientnegative/udf_last_day_error_2.q.out dc8e3d14f14205ce65355cd53a95cfc788f45fe0 ql/src/test/results/clientnegative/udf_next_day_error_1.q.out c67b9c42f7e7fdf20caa34d028b02fd4819e8343 ql/src/test/results/clientnegative/udf_next_day_error_2.q.out e3cb6a447bf7bd9f09648e46ace1bcba4da55339 ql/src/test/results/clientpositive/udf_add_months.q.out 8c37fc282a25e350435ff6a4b39e02fc2d4f17df ql/src/test/results/clientpositive/udf_last_day.q.out 2d39e3897625c7651b110779b89652f0d785bc92 ql/src/test/results/clientpositive/udf_next_day.q.out 37f5640fde267f1635d72f23e76fa89de6403ab5 Diff: https://reviews.apache.org/r/31404/diff/ Testing --- Thanks, Alexander Pivovarov
Re: Review Request 31404: HIVE-9744 Move common arguments validation and value extraction code to GenericUDF
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31404/ --- (Updated Feb. 26, 2015, 9:16 p.m.) Review request for hive, Jason Dere and Thejas Nair. Bugs: HIVE-9744 https://issues.apache.org/jira/browse/HIVE-9744 Repository: hive-git Description --- HIVE-9744 Move common arguments validation and value extraction code to GenericUDF Diffs (updated) - ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java 8a0f573648c51c4945be8ffec4a0b06dfa7061c8 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddMonths.java c5968835a74195bea6b31a5c7b7346907fed5ce0 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInitCap.java 406fcd608a13fadb8902bf273932acb05a0f3bbe ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLastDay.java 3a43c571ae3a83924a00413181a62ce6f4408125 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLevenstein.java de41793ba3925aa9e1ad9623d92881c57791f047 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFNextDay.java 38f08b74609a4018221ca3f5b92cf33799604d60 ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFAddMonths.java 4ccae97a227257294d69f728426f425d060ef0c7 ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFLastDay.java 4b233a6966bbdf6902c53f2aaf53cc0eb422b205 ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFLevenshtein.java e674d9f38cf7b5cdffcad6eca07dba74ff1e834b ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFNextDay.java e2ec551d4ae39d521680ee93c791f14f27811270 ql/src/test/queries/clientpositive/udf_next_day.q db821f00c39b84c4bc59ea70b0cc0aacf69cbd18 ql/src/test/results/clientnegative/udf_add_months_error_1.q.out 8226ac6fe89c38fcc14edeea215cd5cce7258683 ql/src/test/results/clientnegative/udf_add_months_error_2.q.out f00949e9a12285cc91032215372975753c1f3b4a ql/src/test/results/clientnegative/udf_last_day_error_1.q.out 6e718a0c15e84d89b1cfe7f36231e472ff03c37f ql/src/test/results/clientnegative/udf_last_day_error_2.q.out dc8e3d14f14205ce65355cd53a95cfc788f45fe0 ql/src/test/results/clientnegative/udf_next_day_error_1.q.out c67b9c42f7e7fdf20caa34d028b02fd4819e8343 ql/src/test/results/clientnegative/udf_next_day_error_2.q.out e3cb6a447bf7bd9f09648e46ace1bcba4da55339 ql/src/test/results/clientpositive/udf_add_months.q.out 8c37fc282a25e350435ff6a4b39e02fc2d4f17df ql/src/test/results/clientpositive/udf_last_day.q.out 2d39e3897625c7651b110779b89652f0d785bc92 Diff: https://reviews.apache.org/r/31404/diff/ Testing --- Thanks, Alexander Pivovarov
Re: Review Request 29807: HIVE-9253: MetaStore server should support timeout for long running requests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29807/#review74365 --- This looks great to me! We can do the check in more places in a follow-on jira. I just had one thought about the property name and then I think let's commit! Nice work Dong!! common/src/java/org/apache/hadoop/hive/conf/HiveConf.java https://reviews.apache.org/r/29807/#comment120931 I don't feel it makes any sense to have a smaller long running timeout than hive.metastore.client.socket.timeout or any larger. Thus as opposed to creating a new config I feel like we should re-use hive.metastore.client.socket.timeout. - Brock Noland On Feb. 26, 2015, 8:51 a.m., Dong Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29807/ --- (Updated Feb. 26, 2015, 8:51 a.m.) Review request for hive. Repository: hive-git Description --- HIVE-9253: MetaStore server should support timeout for long running requests Diffs - common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8e072f7 metastore/src/java/org/apache/hadoop/hive/metastore/Deadline.java PRE-CREATION metastore/src/java/org/apache/hadoop/hive/metastore/DeadlineException.java PRE-CREATION metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java ab011fc metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 574141c metastore/src/java/org/apache/hadoop/hive/metastore/RetryingHMSHandler.java 01ad36a metastore/src/java/org/apache/hadoop/hive/metastore/SessionPropertiesListener.java PRE-CREATION metastore/src/test/org/apache/hadoop/hive/metastore/TestDeadline.java PRE-CREATION metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTimeout.java PRE-CREATION Diff: https://reviews.apache.org/r/29807/diff/ Testing --- UT passed Thanks, Dong Chen
Re: Review Request 31452: HIVE-9781 Utilize spark.kryo.classesToRegister [Spark Branch]
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31452/ --- (Updated Feb. 26, 2015, 9:38 p.m.) Review request for hive, Brock Noland and Xuefu Zhang. Changes --- Instead of using spark.kryo.classesToRegister, we register those used classes, per Xuefu's suggestion. Bugs: HIVE-9781 https://issues.apache.org/jira/browse/HIVE-9781 Repository: hive-git Description --- Now, Spark RSC can use setting spark.kryo.classesToRegister. Reference checking is still needed since there are loops. Diffs (updated) - ql/src/java/org/apache/hadoop/hive/ql/exec/spark/KryoSerializer.java 76a4fd1 ql/src/java/org/apache/hadoop/hive/ql/exec/spark/RemoteHiveSparkClient.java f1d65ea Diff: https://reviews.apache.org/r/31452/diff/ Testing --- Tested it on a yarn cluster with spark.kryo.classesToRegister set. Thanks, Jimmy Xiang
[jira] [Created] (HIVE-9800) Create scripts to do metastore upgrade tests on Jenkins
Sergio Peña created HIVE-9800: - Summary: Create scripts to do metastore upgrade tests on Jenkins Key: HIVE-9800 URL: https://issues.apache.org/jira/browse/HIVE-9800 Project: Hive Issue Type: Improvement Reporter: Sergio Peña Assignee: Sergio Peña In order to have a better quality code for Hive Metastore, we need to create some upgrade scripts that can run on Jenkins nightly or everytime a patch is added to the ticket that makes structural changes on the database. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 31222: HIVE-9738 create SOUNDEX udf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31222/ --- (Updated Feb. 26, 2015, 9:50 p.m.) Review request for hive, Alan Gates and Jason Dere. Bugs: HIVE-9738 https://issues.apache.org/jira/browse/HIVE-9738 Repository: hive-git Description --- HIVE-9738 create SOUNDEX udf Diffs (updated) - ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java bfeb33c9edf79071bf106a3780e1c6bc21be3753 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSoundex.java PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFSoundex.java PRE-CREATION ql/src/test/queries/clientpositive/udf_soundex.q PRE-CREATION ql/src/test/results/clientpositive/show_functions.q.out d4b06507f2356cc58ff7312ff78261406f3ceb4f ql/src/test/results/clientpositive/udf_soundex.q.out PRE-CREATION Diff: https://reviews.apache.org/r/31222/diff/ Testing --- Thanks, Alexander Pivovarov
Re: Review Request 31222: HIVE-9738 create SOUNDEX udf
On Feb. 26, 2015, 7:58 p.m., Jason Dere wrote: ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSoundex.java, line 77 https://reviews.apache.org/r/31222/diff/1/?file=870136#file870136line77 Looks like Soundex.soundex() can return IllegalArgumentException for some unmapped characters - perhaps return null in this case to avoid aborting the entire query on this error. good catch. fixed and added unit test - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31222/#review74348 --- On Feb. 26, 2015, 9:50 p.m., Alexander Pivovarov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31222/ --- (Updated Feb. 26, 2015, 9:50 p.m.) Review request for hive, Alan Gates and Jason Dere. Bugs: HIVE-9738 https://issues.apache.org/jira/browse/HIVE-9738 Repository: hive-git Description --- HIVE-9738 create SOUNDEX udf Diffs - ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java bfeb33c9edf79071bf106a3780e1c6bc21be3753 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSoundex.java PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFSoundex.java PRE-CREATION ql/src/test/queries/clientpositive/udf_soundex.q PRE-CREATION ql/src/test/results/clientpositive/show_functions.q.out d4b06507f2356cc58ff7312ff78261406f3ceb4f ql/src/test/results/clientpositive/udf_soundex.q.out PRE-CREATION Diff: https://reviews.apache.org/r/31222/diff/ Testing --- Thanks, Alexander Pivovarov
Re: Review Request 31452: HIVE-9781 Utilize spark.kryo.classesToRegister [Spark Branch]
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31452/#review74370 --- Ship it! Ship It! - Xuefu Zhang On Feb. 26, 2015, 9:38 p.m., Jimmy Xiang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31452/ --- (Updated Feb. 26, 2015, 9:38 p.m.) Review request for hive, Brock Noland and Xuefu Zhang. Bugs: HIVE-9781 https://issues.apache.org/jira/browse/HIVE-9781 Repository: hive-git Description --- Now, Spark RSC can use setting spark.kryo.classesToRegister. Reference checking is still needed since there are loops. Diffs - ql/src/java/org/apache/hadoop/hive/ql/exec/spark/KryoSerializer.java 76a4fd1 ql/src/java/org/apache/hadoop/hive/ql/exec/spark/RemoteHiveSparkClient.java f1d65ea Diff: https://reviews.apache.org/r/31452/diff/ Testing --- Tested it on a yarn cluster with spark.kryo.classesToRegister set. Thanks, Jimmy Xiang
Review Request 31497: HIVE-9800 Create scripts to do metastore upgrade tests on Jenkins
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31497/ --- Review request for hive and Brock Noland. Bugs: HIVE-9800 https://issues.apache.org/jira/browse/HIVE-9800 Repository: hive-git Description --- This script downloads a metastore upgrade script, and run all the upgrade tests in an specific db server. Another jenkins scripts is used to create LXC containers where to run these tests. Diffs - dev-support/tests/upgrade/jenkins-upgrade-test.sh PRE-CREATION dev-support/tests/upgrade/metastore-upgrade-test.sh PRE-CREATION dev-support/tests/upgrade/servers/mysql/execute.sh PRE-CREATION dev-support/tests/upgrade/servers/mysql/prepare.sh PRE-CREATION Diff: https://reviews.apache.org/r/31497/diff/ Testing --- Thanks, Sergio Pena
Re: Review Request 29807: HIVE-9253: MetaStore server should support timeout for long running requests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29807/ --- (Updated Feb. 26, 2015, 8:51 a.m.) Review request for hive. Changes --- Address comments from Mohit. Repository: hive-git Description --- HIVE-9253: MetaStore server should support timeout for long running requests Diffs (updated) - common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8e072f7 metastore/src/java/org/apache/hadoop/hive/metastore/Deadline.java PRE-CREATION metastore/src/java/org/apache/hadoop/hive/metastore/DeadlineException.java PRE-CREATION metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java ab011fc metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 574141c metastore/src/java/org/apache/hadoop/hive/metastore/RetryingHMSHandler.java 01ad36a metastore/src/java/org/apache/hadoop/hive/metastore/SessionPropertiesListener.java PRE-CREATION metastore/src/test/org/apache/hadoop/hive/metastore/TestDeadline.java PRE-CREATION metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTimeout.java PRE-CREATION Diff: https://reviews.apache.org/r/29807/diff/ Testing --- UT passed Thanks, Dong Chen
Re: [ANNOUNCE] New Hive PMC Member - Sergey Shelukhin
Way to go Sergey! -- Lefty On Wed, Feb 25, 2015 at 4:19 PM, Sergey Shelukhin ser...@hortonworks.com wrote: Thanks guys! On 15/2/25, 16:02, Xiaobing Zhou xz...@hortonworks.com wrote: Congrats Sergey! On Feb 25, 2015, at 1:56 PM, Prasanth Jayachandran pjayachand...@hortonworks.com wrote: Congrats Sergey! On Feb 25, 2015, at 1:50 PM, Alexander Pivovarov apivova...@gmail.commailto:apivova...@gmail.com wrote: Congrats! On Wed, Feb 25, 2015 at 12:33 PM, Vaibhav Gumashta vgumas...@hortonworks.commailto:vgumas...@hortonworks.com wrote: Congrats Sergey! On 2/25/15, 9:06 AM, Vikram Dixit vik...@hortonworks.commailto:vik...@hortonworks.com wrote: Congrats Sergey! On 2/25/15, 8:43 AM, Carl Steinbach c...@apache.orgmailto:c...@apache.org wrote: I am pleased to announce that Sergey Shelukhin has been elected to the Hive Project Management Committee. Please join me in congratulating Sergey! Thanks. - Carl
Re: Review Request 29807: HIVE-9253: MetaStore server should support timeout for long running requests
On Feb. 12, 2015, 8:42 a.m., Mohit Sabharwal wrote: metastore/src/java/org/apache/hadoop/hive/metastore/Deadline.java, line 45 https://reviews.apache.org/r/29807/diff/4/?file=838557#file838557line45 Why do we need to store the method name of the HMS method we are timing ? Is it just so we can print it in the exception message ? Instead of storing it here, maybe we can log the method name when the DeadlineException is caught in HMS ? It is a good idea to log the method name when the DeadlineException is caught in HMS. I added it in new patch. How about we still keep the method name in the exception message? Since after logging the exception, it is re-thrown. Maybe upper caller or client side want to know the method info from the exception. On Feb. 12, 2015, 8:42 a.m., Mohit Sabharwal wrote: metastore/src/java/org/apache/hadoop/hive/metastore/Deadline.java, line 110 https://reviews.apache.org/r/29807/diff/4/?file=838557#file838557line110 do we really need to record the method ? As discussed above, if client side want to know method info from the exception, this maybe need to be record. - Dong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29807/#review72119 --- On Jan. 28, 2015, 8:58 a.m., Dong Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29807/ --- (Updated Jan. 28, 2015, 8:58 a.m.) Review request for hive. Repository: hive-git Description --- HIVE-9253: MetaStore server should support timeout for long running requests Diffs - common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 66f436b metastore/src/java/org/apache/hadoop/hive/metastore/Deadline.java PRE-CREATION metastore/src/java/org/apache/hadoop/hive/metastore/DeadlineException.java PRE-CREATION metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java fc6f067 metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 574141c metastore/src/java/org/apache/hadoop/hive/metastore/RetryingHMSHandler.java 01ad36a metastore/src/java/org/apache/hadoop/hive/metastore/SessionPropertiesListener.java PRE-CREATION metastore/src/test/org/apache/hadoop/hive/metastore/TestDeadline.java PRE-CREATION metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTimeout.java PRE-CREATION Diff: https://reviews.apache.org/r/29807/diff/ Testing --- UT passed Thanks, Dong Chen
Re: Review Request 31222: HIVE-9738 create SOUNDEX udf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31222/#review74399 --- Ship it! Ship It! - Jason Dere On Feb. 26, 2015, 9:50 p.m., Alexander Pivovarov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31222/ --- (Updated Feb. 26, 2015, 9:50 p.m.) Review request for hive, Alan Gates and Jason Dere. Bugs: HIVE-9738 https://issues.apache.org/jira/browse/HIVE-9738 Repository: hive-git Description --- HIVE-9738 create SOUNDEX udf Diffs - ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java bfeb33c9edf79071bf106a3780e1c6bc21be3753 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSoundex.java PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFSoundex.java PRE-CREATION ql/src/test/queries/clientpositive/udf_soundex.q PRE-CREATION ql/src/test/results/clientpositive/show_functions.q.out d4b06507f2356cc58ff7312ff78261406f3ceb4f ql/src/test/results/clientpositive/udf_soundex.q.out PRE-CREATION Diff: https://reviews.apache.org/r/31222/diff/ Testing --- Thanks, Alexander Pivovarov
[jira] [Created] (HIVE-9802) Refactor HBaseReadWrite to allow different implementations underneath
Alan Gates created HIVE-9802: Summary: Refactor HBaseReadWrite to allow different implementations underneath Key: HIVE-9802 URL: https://issues.apache.org/jira/browse/HIVE-9802 Project: Hive Issue Type: Sub-task Components: Metastore Affects Versions: hbase-metastore-branch Reporter: Alan Gates Assignee: Alan Gates We need transactions for HBase metastore. All the options I've seen have some variation on using or redefining HTableInterface. We need to refactor HBaseReadWrite to put HTableInterface calls behind an interface so we can switch between vanilla HBase, Tephra, ... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-9801) LLAP: need counter for cache hit ratio
Gunther Hagleitner created HIVE-9801: Summary: LLAP: need counter for cache hit ratio Key: HIVE-9801 URL: https://issues.apache.org/jira/browse/HIVE-9801 Project: Hive Issue Type: Sub-task Reporter: Gunther Hagleitner -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 31497: HIVE-9800 Create scripts to do metastore upgrade tests on Jenkins
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31497/ --- (Updated Feb. 26, 2015, 11:07 p.m.) Review request for hive and Brock Noland. Bugs: HIVE-9800 https://issues.apache.org/jira/browse/HIVE-9800 Repository: hive-git Description --- This script downloads a metastore upgrade script, and run all the upgrade tests in an specific db server. Another jenkins scripts is used to create LXC containers where to run these tests. Diffs (updated) - dev-support/tests/metastore-upgrade/jenkins-upgrade-test.sh PRE-CREATION dev-support/tests/metastore-upgrade/metastore-upgrade-test.sh PRE-CREATION dev-support/tests/metastore-upgrade/servers/mysql/execute.sh PRE-CREATION dev-support/tests/metastore-upgrade/servers/mysql/prepare.sh PRE-CREATION Diff: https://reviews.apache.org/r/31497/diff/ Testing --- Thanks, Sergio Pena
Re: Review Request 31152: HIVE-9582: HCatalog should use IMetaStoreClient interface
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31152/#review74374 --- hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java https://reviews.apache.org/r/31152/#comment120940 Its better to include the actual error message in the exception. That way user does not need to go find it from the stack trace. ie Error connecting to Hive Metastore URI: + endPoint.metaStoreUri + : + e.getMessage, e); hcatalog/webhcat/java-client/src/main/java/org/apache/hive/hcatalog/api/HCatClientHMSImpl.java https://reviews.apache.org/r/31152/#comment120942 same comment as above, can you please + e.getMessage() . ( i know you are following the pattern followed currently in the above catch) hcatalog/webhcat/java-client/src/main/java/org/apache/hive/hcatalog/api/HCatClientHMSImpl.java https://reviews.apache.org/r/31152/#comment120943 + e.getMessage() . hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/SecureProxySupport.java https://reviews.apache.org/r/31152/#comment120937 shouldn't this be client.getDelegationToken(c.getUser(), u) ? hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TempletonControllerJob.java https://reviews.apache.org/r/31152/#comment120936 shouldn't this be client.getDelegationToken(c.getUser(), u) ? - Thejas Nair On Feb. 18, 2015, 6:58 a.m., Thiruvel Thirumoolan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31152/ --- (Updated Feb. 18, 2015, 6:58 a.m.) Review request for hive. Repository: hive-git Description --- HIVE-9582: HCatalog should use IMetaStoreClient interface Diffs - hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HCatUtil.java 63909b893b4be32647a0d91e58bc0dca86bcabd9 hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HiveClientCache.java a001252faaf9949b6d2f0e3110c2b343b9648a91 hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/DefaultOutputCommitterContainer.java cead40d6eb7df285987c92b58021246e888dc502 hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FileOutputCommitterContainer.java bf2ba5a1c9135bb99cb12b4111e60e2b0a2ea10f hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FileOutputFormatContainer.java 1cd5306aafb9b3ec61c31fb6504c8082b47ed2ae hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/HCatOutputFormat.java 694739821a202780818924d54d10edb707cfbcfa hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/InitializeInput.java 1980ef50af42499e0fed8863b6ff7a45f926d9fc hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/Security.java 39ef86e4c3d521b310f9b2dc2f154ae5a555ab06 hcatalog/core/src/test/java/org/apache/hive/hcatalog/common/TestHiveClientCache.java 63a55482f7e9115f5626c5cde036597248459118 hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestPassProperties.java f8a0af14e3d0b9dc5005f1c2f390f4e2dc054145 hcatalog/hcatalog-pig-adapter/src/main/java/org/apache/hive/hcatalog/pig/PigHCatUtil.java 48a40b1c11d44c6d53d8f58b7ea91f090e72920f hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/AbstractRecordWriter.java 8c4bca02abeda7eb89ea0deacdfb2e06c9fda7f8 hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java a08f2f97e4e297873250ac8d16c7679c2de901f0 hcatalog/webhcat/java-client/src/main/java/org/apache/hive/hcatalog/api/HCatClientHMSImpl.java cd05254f4e138b7c1ec7d9424c90416b25f93462 hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/CompleteDelegator.java 1b9663d2d0e2e0d94b520ed6760415be441c7ab4 hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/SecureProxySupport.java 8ae61a1e330b56037dd7440fa888e431c65fc158 hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TempletonControllerJob.java 53eecfa990bcaab247ae8bc4df221742bd166081 metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 0aa0f515d9d15d442d31e32a63586d119c30494e Diff: https://reviews.apache.org/r/31152/diff/ Testing --- All hcatalog unit tests pass. Thanks, Thiruvel Thirumoolan
Re: Review Request 31404: HIVE-9744 Move common arguments validation and value extraction code to GenericUDF
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31404/#review74371 --- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java https://reviews.apache.org/r/31404/#comment120934 Not a fan of these timestamp-related changes. It's causing you to have to create 2 new arrays of Converters which seems awkward. I was going to suggest simply using a DateConverter, but I see that the original behavior also allowed timestamp format strings (really, it allowed anything after the '-mm-dd' part). Rather than have 2 different converters, maybe just go back to what you had before, use a single converter to string, and then just apply whatever format logic you are going to apply to the string value. ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFNextDay.java https://reviews.apache.org/r/31404/#comment120945 So this is actually an example of something that used to be valid input, but no longer works due to the change from SimpleDateFormat to Timestamp/Date converter. This would be ok for the UDFs you've changed since they are new ones, but I don't know if this kind of change in behavior would be something that would be a concern if we were to apply this same refactoring to some of the other date-related UDFs. - Jason Dere On Feb. 26, 2015, 9:16 p.m., Alexander Pivovarov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31404/ --- (Updated Feb. 26, 2015, 9:16 p.m.) Review request for hive, Jason Dere and Thejas Nair. Bugs: HIVE-9744 https://issues.apache.org/jira/browse/HIVE-9744 Repository: hive-git Description --- HIVE-9744 Move common arguments validation and value extraction code to GenericUDF Diffs - ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java 8a0f573648c51c4945be8ffec4a0b06dfa7061c8 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddMonths.java c5968835a74195bea6b31a5c7b7346907fed5ce0 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInitCap.java 406fcd608a13fadb8902bf273932acb05a0f3bbe ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLastDay.java 3a43c571ae3a83924a00413181a62ce6f4408125 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLevenstein.java de41793ba3925aa9e1ad9623d92881c57791f047 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFNextDay.java 38f08b74609a4018221ca3f5b92cf33799604d60 ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFAddMonths.java 4ccae97a227257294d69f728426f425d060ef0c7 ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFLastDay.java 4b233a6966bbdf6902c53f2aaf53cc0eb422b205 ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFLevenshtein.java e674d9f38cf7b5cdffcad6eca07dba74ff1e834b ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFNextDay.java e2ec551d4ae39d521680ee93c791f14f27811270 ql/src/test/queries/clientpositive/udf_next_day.q db821f00c39b84c4bc59ea70b0cc0aacf69cbd18 ql/src/test/results/clientnegative/udf_add_months_error_1.q.out 8226ac6fe89c38fcc14edeea215cd5cce7258683 ql/src/test/results/clientnegative/udf_add_months_error_2.q.out f00949e9a12285cc91032215372975753c1f3b4a ql/src/test/results/clientnegative/udf_last_day_error_1.q.out 6e718a0c15e84d89b1cfe7f36231e472ff03c37f ql/src/test/results/clientnegative/udf_last_day_error_2.q.out dc8e3d14f14205ce65355cd53a95cfc788f45fe0 ql/src/test/results/clientnegative/udf_next_day_error_1.q.out c67b9c42f7e7fdf20caa34d028b02fd4819e8343 ql/src/test/results/clientnegative/udf_next_day_error_2.q.out e3cb6a447bf7bd9f09648e46ace1bcba4da55339 ql/src/test/results/clientpositive/udf_add_months.q.out 8c37fc282a25e350435ff6a4b39e02fc2d4f17df ql/src/test/results/clientpositive/udf_last_day.q.out 2d39e3897625c7651b110779b89652f0d785bc92 Diff: https://reviews.apache.org/r/31404/diff/ Testing --- Thanks, Alexander Pivovarov
Re: Not getting some JIRA resolution messages
Being a watcher could explain why I got the last two messages for HIVE-9731 https://issues.apache.org/jira/browse/HIVE-9731 (TODOC1.2, doc comment) but then why did I get all the messages before the commit, when I wasn't a watcher yet? And I'm not a watcher for HIVE-9509 https://issues.apache.org/jira/browse/HIVE-9509 although I got all the messages up to Ashutosh's +1. This is something I can work around, but if others have the same problem we might need to figure it out and get it fixed. -- Lefty On Thu, Feb 26, 2015 at 1:12 PM, Xuefu Zhang xzh...@cloudera.com wrote: I think you get subsequent messages only if you're a watcher. You become a watcher after you comment or make changes for a JIRA. Is this your case? On Thu, Feb 26, 2015 at 1:05 PM, Lefty Leverenz leftylever...@gmail.com wrote: Is it just me, or has JIRA email been flaky since the issues mailing list went into effect? For example, although I got a commit message for HIVE-9731 https://issues.apache.org/jira/browse/HIVE-9731 on the commits@hive mailing list, I didn't get either the change of Resolution or the comment about the commit -- not on dev@hive nor on issues@hive. However I did get two subsequent messages on issues@hive when I added a TODOC1.2 label and doc comment. Another example: for HIVE-9509 https://issues.apache.org/jira/browse/HIVE-9509 I got the commit comment and Fix Version change for branch-1.0.1 on the issues@hive list but not the prior commit comment and Resolved - Fix Version for 1.2.0. Does anyone else have this problem? -- Lefty
Re: Review Request 31404: HIVE-9744 Move common arguments validation and value extraction code to GenericUDF
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31404/ --- (Updated Feb. 27, 2015, 12:11 a.m.) Review request for hive, Jason Dere and Thejas Nair. Bugs: HIVE-9744 https://issues.apache.org/jira/browse/HIVE-9744 Repository: hive-git Description --- HIVE-9744 Move common arguments validation and value extraction code to GenericUDF Diffs (updated) - ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java 8a0f573648c51c4945be8ffec4a0b06dfa7061c8 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddMonths.java c5968835a74195bea6b31a5c7b7346907fed5ce0 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInitCap.java 406fcd608a13fadb8902bf273932acb05a0f3bbe ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLastDay.java 3a43c571ae3a83924a00413181a62ce6f4408125 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLevenstein.java de41793ba3925aa9e1ad9623d92881c57791f047 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFNextDay.java 38f08b74609a4018221ca3f5b92cf33799604d60 ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFAddMonths.java 4ccae97a227257294d69f728426f425d060ef0c7 ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFLastDay.java 4b233a6966bbdf6902c53f2aaf53cc0eb422b205 ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFLevenshtein.java e674d9f38cf7b5cdffcad6eca07dba74ff1e834b ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFNextDay.java e2ec551d4ae39d521680ee93c791f14f27811270 ql/src/test/results/clientnegative/udf_add_months_error_1.q.out 8226ac6fe89c38fcc14edeea215cd5cce7258683 ql/src/test/results/clientnegative/udf_add_months_error_2.q.out f00949e9a12285cc91032215372975753c1f3b4a ql/src/test/results/clientnegative/udf_last_day_error_1.q.out 6e718a0c15e84d89b1cfe7f36231e472ff03c37f ql/src/test/results/clientnegative/udf_last_day_error_2.q.out dc8e3d14f14205ce65355cd53a95cfc788f45fe0 ql/src/test/results/clientnegative/udf_next_day_error_1.q.out c67b9c42f7e7fdf20caa34d028b02fd4819e8343 ql/src/test/results/clientnegative/udf_next_day_error_2.q.out e3cb6a447bf7bd9f09648e46ace1bcba4da55339 Diff: https://reviews.apache.org/r/31404/diff/ Testing --- Thanks, Alexander Pivovarov
[jira] [Created] (HIVE-9803) SparkClientImpl should not attempt impersonation in CLI mode [Spark Branch]
Brock Noland created HIVE-9803: -- Summary: SparkClientImpl should not attempt impersonation in CLI mode [Spark Branch] Key: HIVE-9803 URL: https://issues.apache.org/jira/browse/HIVE-9803 Project: Hive Issue Type: Bug Components: Hive Affects Versions: spark-branch Reporter: Brock Noland Assignee: Brock Noland My bad. In CLI mode we attempt to impersonate oursevles. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-9806) Support partition locator for custom directory hierarchy
Navis created HIVE-9806: --- Summary: Support partition locator for custom directory hierarchy Key: HIVE-9806 URL: https://issues.apache.org/jira/browse/HIVE-9806 Project: Hive Issue Type: Improvement Components: Query Processor Reporter: Navis Assignee: Navis Priority: Minor Currently, relative partition directory should be same with partition name, which is not always applicable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-9805) LLAP: consider specialized transient metadata cache
Sergey Shelukhin created HIVE-9805: -- Summary: LLAP: consider specialized transient metadata cache Key: HIVE-9805 URL: https://issues.apache.org/jira/browse/HIVE-9805 Project: Hive Issue Type: Sub-task Reporter: Sergey Shelukhin Fix For: llap Due to the nature of cache now (metadata cache + disk cache), when data is read from ORC, whole bunch of processing is still done with metadata, columns, streams, contexts, offsets, etc. to get the data that is in cache. Essentially only the disk reads are eliminated, everything else is as if we are reading an unknown file. We could have a better metadata representation that is saved during first read - for example, (file, stripe) - DiskRange[] (incl. cache buffers that are not locked) + multi-dimensional array per column per stream per RG pointing to offsets in DiskRange array. That way if such structure is found in cache, reader can avoid all the calculation and just do dumb conversion into results to pass to decoder plus disk reading for missing parts. This java cache cannot figure in the main data eviction policy so it should be small. With java objects no cache locking is needed, we can evict while someone is still using the structure, and it will be GCed -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 31497: HIVE-9800 Create scripts to do metastore upgrade tests on Jenkins
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31497/#review74420 --- dev-support/tests/metastore-upgrade/jenkins-upgrade-test.sh https://reviews.apache.org/r/31497/#comment120991 AFAIK, Jenkins does not run as root. Will this still work? - Lenni Kuff On Feb. 26, 2015, 11:07 p.m., Sergio Pena wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31497/ --- (Updated Feb. 26, 2015, 11:07 p.m.) Review request for hive and Brock Noland. Bugs: HIVE-9800 https://issues.apache.org/jira/browse/HIVE-9800 Repository: hive-git Description --- This script downloads a metastore upgrade script, and run all the upgrade tests in an specific db server. Another jenkins scripts is used to create LXC containers where to run these tests. Diffs - dev-support/tests/metastore-upgrade/jenkins-upgrade-test.sh PRE-CREATION dev-support/tests/metastore-upgrade/metastore-upgrade-test.sh PRE-CREATION dev-support/tests/metastore-upgrade/servers/mysql/execute.sh PRE-CREATION dev-support/tests/metastore-upgrade/servers/mysql/prepare.sh PRE-CREATION Diff: https://reviews.apache.org/r/31497/diff/ Testing --- Thanks, Sergio Pena
Re: Review Request 29807: HIVE-9253: MetaStore server should support timeout for long running requests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29807/ --- (Updated Feb. 27, 2015, 1:48 a.m.) Review request for hive. Changes --- Re-use the conf property hive.metastore.client.socket.timeout Repository: hive-git Description --- HIVE-9253: MetaStore server should support timeout for long running requests Diffs (updated) - common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8e072f7 metastore/src/java/org/apache/hadoop/hive/metastore/Deadline.java PRE-CREATION metastore/src/java/org/apache/hadoop/hive/metastore/DeadlineException.java PRE-CREATION metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java ab011fc metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 574141c metastore/src/java/org/apache/hadoop/hive/metastore/RetryingHMSHandler.java 01ad36a metastore/src/java/org/apache/hadoop/hive/metastore/SessionPropertiesListener.java PRE-CREATION metastore/src/test/org/apache/hadoop/hive/metastore/TestDeadline.java PRE-CREATION metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTimeout.java PRE-CREATION Diff: https://reviews.apache.org/r/29807/diff/ Testing --- UT passed Thanks, Dong Chen
[jira] [Created] (HIVE-9804) Turn on some kryo settings by default for Spark
Jimmy Xiang created HIVE-9804: - Summary: Turn on some kryo settings by default for Spark Key: HIVE-9804 URL: https://issues.apache.org/jira/browse/HIVE-9804 Project: Hive Issue Type: Improvement Reporter: Jimmy Xiang Assignee: Jimmy Xiang Disable referrence checking, set classesToRegiser for Spark can boost the performance. We should do so by default. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Not getting some JIRA resolution messages
The issues list should be getting all JIRA notifications except CREATE, you shouldn't need to watch it. You can go look at the mail archives to see if the issue is with the list or on your end. If they aren't all showing up in the list we should file an INFRA JIRA. Alan. Lefty Leverenz mailto:leftylever...@gmail.com February 26, 2015 at 14:03 Being a watcher could explain why I got the last two messages for HIVE-9731 https://issues.apache.org/jira/browse/HIVE-9731 (TODOC1.2, doc comment) but then why did I get all the messages before the commit, when I wasn't a watcher yet? And I'm not a watcher for HIVE-9509 https://issues.apache.org/jira/browse/HIVE-9509 although I got all the messages up to Ashutosh's +1. This is something I can work around, but if others have the same problem we might need to figure it out and get it fixed. -- Lefty Xuefu Zhang mailto:xzh...@cloudera.com February 26, 2015 at 13:12 I think you get subsequent messages only if you're a watcher. You become a watcher after you comment or make changes for a JIRA. Is this your case? On Thu, Feb 26, 2015 at 1:05 PM, Lefty Leverenz leftylever...@gmail.com Lefty Leverenz mailto:leftylever...@gmail.com February 26, 2015 at 13:05 Is it just me, or has JIRA email been flaky since the issues mailing list went into effect? For example, although I got a commit message for HIVE-9731 https://issues.apache.org/jira/browse/HIVE-9731 on the commits@hive mailing list, I didn't get either the change of Resolution or the comment about the commit -- not on dev@hive nor on issues@hive. However I did get two subsequent messages on issues@hive when I added a TODOC1.2 label and doc comment. Another example: for HIVE-9509 https://issues.apache.org/jira/browse/HIVE-9509 I got the commit comment and Fix Version change for branch-1.0.1 on the issues@hive list but not the prior commit comment and Resolved - Fix Version for 1.2.0. Does anyone else have this problem? -- Lefty
[jira] [Created] (HIVE-9807) LLAP: Add event logging for execution elements
Siddharth Seth created HIVE-9807: Summary: LLAP: Add event logging for execution elements Key: HIVE-9807 URL: https://issues.apache.org/jira/browse/HIVE-9807 Project: Hive Issue Type: Sub-task Reporter: Siddharth Seth Assignee: Siddharth Seth For analysis of runtimes, interleaving etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
