Review Request 33937: HIVE-10641 create CRC32 UDF

[Alexander Pivovarov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33937/
---

Review request for hive and Jason Dere.


Bugs: HIVE-10641
https://issues.apache.org/jira/browse/HIVE-10641


Repository: hive-git


Description
---

HIVE-10641 create CRC32 UDF


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 
02a604ff0a4ed92dfd94b199e8b539f636b66f77 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFCrc32.java PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFCrc32.java PRE-CREATION 
  ql/src/test/queries/clientpositive/udf_crc32.q PRE-CREATION 
  ql/src/test/results/clientpositive/show_functions.q.out 
a422760400c62d026324dd667e4a632bfbe01b82 
  ql/src/test/results/clientpositive/udf_crc32.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/33937/diff/


Testing
---


Thanks,

Alexander Pivovarov

[jira] [Created] (HIVE-10641) create CRC32 UDF

[Alexander Pivovarov (JIRA)]

Alexander Pivovarov created HIVE-10641:
--

 Summary: create CRC32 UDF
 Key: HIVE-10641
 URL: https://issues.apache.org/jira/browse/HIVE-10641
 Project: Hive
  Issue Type: Improvement
  Components: UDF
Reporter: Alexander Pivovarov
Assignee: Alexander Pivovarov


CRC32 computes a cyclic redundancy check value for string or binary argument 
and returns bigint value. The result is NULL if the argument is NULL.

MySQL has similar function 
https://dev.mysql.com/doc/refman/5.0/en/mathematical-functions.html#function_crc32



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Review Request 33931: HIVE-10624 Update the initial script to make beeline bucked cli as default and allow user choose old hive cli by env

[cheng xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33931/
---

Review request for hive, Xuefu Zhang and Xuefu Zhang.


Bugs: HIVE-10624
https://issues.apache.org/jira/browse/HIVE-10624


Repository: hive-git


Description
---

update the script to redirect the new beeline bucked cli


Diffs
-

  bin/ext/cli.sh 914aae3 
  bin/ext/util/execHiveCmd.sh 167cc40 

Diff: https://reviews.apache.org/r/33931/diff/


Testing
---

Test on the local cluster


Thanks,

cheng xu

Review Request 33927: HIVE-10639 create SHA1 UDF

[Alexander Pivovarov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33927/
---

Review request for hive and Jason Dere.


Bugs: HIVE-10639
https://issues.apache.org/jira/browse/HIVE-10639


Repository: hive-git


Description
---

HIVE-10639 create SHA1 UDF


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 
02a604ff0a4ed92dfd94b199e8b539f636b66f77 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSha1.java PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFSha1.java PRE-CREATION 
  ql/src/test/queries/clientpositive/udf_sha1.q PRE-CREATION 
  ql/src/test/results/clientpositive/show_functions.q.out 
a422760400c62d026324dd667e4a632bfbe01b82 
  ql/src/test/results/clientpositive/udf_sha1.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/33927/diff/


Testing
---


Thanks,

Alexander Pivovarov

Re: Review Request 33890: HIVE-10435: Make HiveSession implementation pluggable through configuration

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33890/#review82789
---



common/src/java/org/apache/hadoop/hive/conf/HiveConf.java


Can you add the new properties in 
./build/dist/conf/hive-default.xml.template with description ?



service/src/java/org/apache/hive/service/cli/session/SessionManager.java


Can we pass all the params passed for HiveSessionImplwithUGI here as well ?



service/src/java/org/apache/hive/service/cli/session/SessionManager.java


Same as above, Can we all params passed for HiveSessionImpl here as well?

It is fine if implementations want to ignore some, but passing less will be 
a gap.



service/src/test/org/apache/hive/service/cli/session/TestPluggableHiveSessionImpl.java


Can you get the session object from service and assert it is an instance of 
TestHiveSessionImpl ?



service/src/test/org/apache/hive/service/cli/session/TestPluggableHiveSessionImpl.java


I dont see the constructor added with params expected, are you sure the 
test is passing fine?


- Amareshwari Sriramadasu


On May 6, 2015, 12:29 p.m., Akshay Goyal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33890/
> ---
> 
> (Updated May 6, 2015, 12:29 p.m.)
> 
> 
> Review request for hive and Amareshwari Sriramadasu.
> 
> 
> Bugs: HIVE-10435
> https://issues.apache.org/jira/browse/HIVE-10435
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> SessionManager in CLIService creates and keeps track of HiveSession. 
> Right now, it creates HiveSessionImpl which is one implementation of 
> HiveSession. This improvement request is to make it pluggable through a 
> configuration so that other implementations can be passed.
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 69fda45 
>   service/src/java/org/apache/hive/service/cli/session/SessionManager.java 
> 36a30b1 
>   
> service/src/test/org/apache/hive/service/cli/session/TestPluggableHiveSessionImpl.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33890/diff/
> 
> 
> Testing
> ---
> 
> Newly added unit test passed.
> 
> 
> Thanks,
> 
> Akshay Goyal
> 
>

[jira] [Created] (HIVE-10640) Vectorized query with NULL constant throws "Unsuported vector output type: void" error

[Matt McCline (JIRA)]

Matt McCline created HIVE-10640:
---

 Summary: Vectorized query with NULL constant  throws "Unsuported 
vector output type: void" error
 Key: HIVE-10640
 URL: https://issues.apache.org/jira/browse/HIVE-10640
 Project: Hive
  Issue Type: Bug
  Components: Hive
Affects Versions: 1.2.0
Reporter: Matt McCline
Assignee: Matt McCline
Priority: Critical
 Fix For: 1.2.0, 1.3.0



This query from join_nullsafe.q when vectorized throws "Unsuported vector 
output type: void" during execution...

{noformat}
select * from myinput1 a join myinput1 b on a.key<=>b.value AND a.key is NULL;
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HIVE-10639) create SHA1 UDF

[Alexander Pivovarov (JIRA)]

Alexander Pivovarov created HIVE-10639:
--

 Summary: create SHA1 UDF
 Key: HIVE-10639
 URL: https://issues.apache.org/jira/browse/HIVE-10639
 Project: Hive
  Issue Type: Improvement
  Components: UDF
Reporter: Alexander Pivovarov
Assignee: Alexander Pivovarov


Calculates an SHA-1 160-bit checksum for the string, as described in RFC 3174 
(Secure Hash Algorithm). The value is returned as a string of 40 hex digits, or 
NULL if the argument was NULL.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 33816: HIVE-10597: Relative path doesn't work with CREATE TABLE LOCATION 'relative/path'

[cheng xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33816/#review82781
---



metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java


Will this patch work with relative path? Seems only a check added.


- cheng xu


On May 5, 2015, 3:14 p.m., Reuben Kuhnert wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33816/
> ---
> 
> (Updated May 5, 2015, 3:14 p.m.)
> 
> 
> Review request for hive and Sergio Pena.
> 
> 
> Bugs: HIVE-10597
> https://issues.apache.org/jira/browse/HIVE-10597
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Allow warehouse to work with relative locations.
> 
> 
> Diffs
> -
> 
>   metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java 
> 25119abf97382df7c0615edbaff29ba20624a137 
>   metastore/src/test/org/apache/hadoop/hive/metastore/TestWarehouse.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33816/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Reuben Kuhnert
> 
>

[jira] [Created] (HIVE-10638) HIVE-9736 introduces issues with Hadoop23Shims.checkFileAccess

[Sushanth Sowmyan (JIRA)]

Sushanth Sowmyan created HIVE-10638:
---

 Summary: HIVE-9736 introduces issues with 
Hadoop23Shims.checkFileAccess
 Key: HIVE-10638
 URL: https://issues.apache.org/jira/browse/HIVE-10638
 Project: Hive
  Issue Type: Bug
Reporter: Sushanth Sowmyan


Copy-pasting [~spena]'s comment in HIVE-9736:

Hi [~mithun]

This patch is causing the above tests to fail due to the change on 
{{Hadoop23Shims.checkFileAccess(FileSystem fs, Iterator statuses, 
EnumSet actions)}}. 

The line that fails is {{accessMethod.invoke(fs, statuses.next(), 
combine(actions));}}

I an running hadoop 2.6.0, and the FileSystem.access() object accepts a Path 
and FsAction. When I run the code that checks patch permissions, I get this 
error: 
{noformat}
hive> explain select * from a join b on a.id = b.id;
FAILED: SemanticException Unable to determine if 
hdfs://localhost:9000/user/hive/warehouse/a is read only: 
java.lang.IllegalArgumentException: argument type mismatch
{noformat}

Is there a follow-up jira for this error?








--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 33909: HIVE-8696: HCatClientHMSImpl doesn't use a Retrying-HiveMetastoreClient

[Thiruvel Thirumoolan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33909/
---

(Updated May 6, 2015, 11:30 p.m.)


Review request for hive.


Repository: hive-git


Description
---

HIVE-8696: HCatClientHMSImpl doesn't use a Retrying-HiveMetastoreClient


Diffs (updated)
-

  
hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HiveClientCache.java
 578b6ea 
  
hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestPassProperties.java
 735ab5f 
  
metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java
 1b6487a 

Diff: https://reviews.apache.org/r/33909/diff/


Testing
---


Thanks,

Thiruvel Thirumoolan

[jira] [Created] (HIVE-10637) Cleanup TestPassProperties changes introduced due to HIVE-8696

[Thiruvel Thirumoolan (JIRA)]

Thiruvel Thirumoolan created HIVE-10637:
---

 Summary: Cleanup TestPassProperties changes introduced due to 
HIVE-8696
 Key: HIVE-10637
 URL: https://issues.apache.org/jira/browse/HIVE-10637
 Project: Hive
  Issue Type: Test
  Components: HCatalog, Tests
Reporter: Thiruvel Thirumoolan
Assignee: Thiruvel Thirumoolan
Priority: Trivial


Follow up JIRA to cleanup the test case as per recommendations from Sushanth.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 33816: HIVE-10597: Relative path doesn't work with CREATE TABLE LOCATION 'relative/path'

[Sergio Pena]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33816/#review82749
---


Can you add a q-test file where you test this scenario?

- Sergio Pena


On May 5, 2015, 3:14 p.m., Reuben Kuhnert wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33816/
> ---
> 
> (Updated May 5, 2015, 3:14 p.m.)
> 
> 
> Review request for hive and Sergio Pena.
> 
> 
> Bugs: HIVE-10597
> https://issues.apache.org/jira/browse/HIVE-10597
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Allow warehouse to work with relative locations.
> 
> 
> Diffs
> -
> 
>   metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java 
> 25119abf97382df7c0615edbaff29ba20624a137 
>   metastore/src/test/org/apache/hadoop/hive/metastore/TestWarehouse.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33816/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Reuben Kuhnert
> 
>

[jira] [Created] (HIVE-10636) CASE comparison operator rotation optimization

[Ashutosh Chauhan (JIRA)]

Ashutosh Chauhan created HIVE-10636:
---

 Summary: CASE comparison operator rotation optimization
 Key: HIVE-10636
 URL: https://issues.apache.org/jira/browse/HIVE-10636
 Project: Hive
  Issue Type: New Feature
  Components: Logical Optimizer
Affects Versions: 1.0.0, 0.14.0, 1.2.0, 1.1.0
Reporter: Ashutosh Chauhan


Step 1 as outlined in description of HIVE-9644



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 33814: Fold case udf

[Ashutosh Chauhan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33814/
---

(Updated May 6, 2015, 10:11 p.m.)


Review request for hive and Gopal V.


Changes
---

Updated patch.


Bugs: HIVE-9644
https://issues.apache.org/jira/browse/HIVE-9644


Repository: hive-git


Description
---

CASE comparison operator rotation optimization


Diffs (updated)
-

  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java
 e9436e5 
  ql/src/test/queries/clientpositive/fold_case.q PRE-CREATION 
  ql/src/test/queries/clientpositive/fold_when.q PRE-CREATION 
  ql/src/test/results/clientpositive/fold_case.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/fold_when.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/ql_rewrite_gbtoidx_cbo_2.q.out 6340a75 

Diff: https://reviews.apache.org/r/33814/diff/


Testing
---

New tests added.


Thanks,

Ashutosh Chauhan

Re: Review Request 33814: Fold case udf

[Ashutosh Chauhan]

> On May 6, 2015, 9:35 a.m., Gopal V wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java,
> >  line 96
> > 
> >
> > stray import?

will remove.


> On May 6, 2015, 9:35 a.m., Gopal V wrote:
> > ql/src/test/results/clientpositive/ql_rewrite_gbtoidx_cbo_2.q.out, line 3817
> > 
> >
> > This seems rather strange, since the rows are still being read (i.e 
> > select 1 from lineitem_ix will return 3024 rows).
> > 
> > Is this a stats mismatch due to this patch?

It is not due to this patch, but we have hit a corner case in stats annotation 
which we should track & fix seprately. My hunch is what happened here is column 
pruner pruned all columns (since constant value emerging from select operator 
is independent of value of any column) and then stats annotation code thought 
since no columns are referenced, it is outputting zero rows.
This is relatively a corner case where query is projecting only constants 
(i.e., dont need to make use of any table data). It will be good if stats 
annotation code can handle such a case.


- Ashutosh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33814/#review82652
---


On May 6, 2015, 6:35 a.m., Ashutosh Chauhan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33814/
> ---
> 
> (Updated May 6, 2015, 6:35 a.m.)
> 
> 
> Review request for hive and Gopal V.
> 
> 
> Bugs: HIVE-9644
> https://issues.apache.org/jira/browse/HIVE-9644
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> CASE comparison operator rotation optimization
> 
> 
> Diffs
> -
> 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java
>  e9436e5 
>   ql/src/test/queries/clientpositive/fold_case.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/fold_when.q PRE-CREATION 
>   ql/src/test/results/clientpositive/fold_case.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/fold_when.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/ql_rewrite_gbtoidx_cbo_2.q.out 6340a75 
> 
> Diff: https://reviews.apache.org/r/33814/diff/
> 
> 
> Testing
> ---
> 
> New tests added.
> 
> 
> Thanks,
> 
> Ashutosh Chauhan
> 
>

[jira] [Created] (HIVE-10635) Redo HIVE-7018 in a schematool compatible manner

[Hari Sankar Sivarama Subramaniyan (JIRA)]

Hari Sankar Sivarama Subramaniyan created HIVE-10635:


 Summary: Redo HIVE-7018 in a schematool compatible manner
 Key: HIVE-10635
 URL: https://issues.apache.org/jira/browse/HIVE-10635
 Project: Hive
  Issue Type: Bug
Reporter: Hari Sankar Sivarama Subramaniyan


In HIVE-10614, we had to revert HIVE-7018 because it was not schematool 
compatible and it would prevent upgrade from 0.14.0 to 1.3.0 when run via 
schematool.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Review Request 33909: HIVE-8696: HCatClientHMSImpl doesn't use a Retrying-HiveMetastoreClient

[Thiruvel Thirumoolan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33909/
---

Review request for hive.


Repository: hive-git


Description
---

HIVE-8696: HCatClientHMSImpl doesn't use a Retrying-HiveMetastoreClient


Diffs
-

  
hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HiveClientCache.java
 578b6ea589069022d1d5f72c582e823822f1d529 
  
metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java
 1b6487af748202d1d0411ac23a7507a9fbd7f251 

Diff: https://reviews.apache.org/r/33909/diff/


Testing
---


Thanks,

Thiruvel Thirumoolan

[jira] [Created] (HIVE-10634) The HMS upgrade test script on LXC is exiting with error even if the test were run successfuly

[JIRA]

Sergio Peña created HIVE-10634:
--

 Summary: The HMS upgrade test script on LXC is exiting with error 
even if the test were run successfuly
 Key: HIVE-10634
 URL: https://issues.apache.org/jira/browse/HIVE-10634
 Project: Hive
  Issue Type: Bug
  Components: Testing Infrastructure
Reporter: Sergio Peña
Assignee: Sergio Peña


The execute-test-on-lxc.sh script is exiting with '1' error code after the 
tests were executed even if the test did not fail.

This is causing that PreCommit-HIVE-METASTORE-Test publishes invalid results to 
Jira.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HIVE-10633) LLAP: remove GC setting from runLlapDaemon

[Sergey Shelukhin (JIRA)]

Sergey Shelukhin created HIVE-10633:
---

 Summary: LLAP: remove GC setting from runLlapDaemon
 Key: HIVE-10633
 URL: https://issues.apache.org/jira/browse/HIVE-10633
 Project: Hive
  Issue Type: Bug
Reporter: Sergey Shelukhin






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HIVE-10632) Make sure TXN_COMPONENTS gets cleaned up if table is dropped before compaction.

[Eugene Koifman (JIRA)]

Eugene Koifman created HIVE-10632:
-

 Summary: Make sure TXN_COMPONENTS gets cleaned up if table is 
dropped before compaction.
 Key: HIVE-10632
 URL: https://issues.apache.org/jira/browse/HIVE-10632
 Project: Hive
  Issue Type: Bug
  Components: Metastore, Transactions
Affects Versions: 1.0.0
Reporter: Eugene Koifman


The compaction process will clean up entries in  TXNS, 
COMPLETED_TXN_COMPONENTS, TXN_COMPONENTS.  If the table/partition is dropped 
before compaction is complete there will be data left in these tables.  Need to 
investigate if there are other situations where this may happen and address it.

see HIVE-10595 for additional info



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HIVE-10631) create_table_core method has invalid update for Fast Stats

[Dongwook Kwon (JIRA)]

Dongwook Kwon created HIVE-10631:


 Summary: create_table_core method has invalid update for Fast Stats
 Key: HIVE-10631
 URL: https://issues.apache.org/jira/browse/HIVE-10631
 Project: Hive
  Issue Type: Bug
  Components: Metastore
Affects Versions: 1.0.0, 0.13.0
Reporter: Dongwook Kwon
Priority: Minor


HiveMetaStore.create_table_core method calls 
MetaStoreUtils.updateUnpartitionedTableStatsFast when hive.stats.autogather is 
on, however for partitioned table, this updateUnpartitionedTableStatsFast call 
scanning warehouse dir and doesn't seem to use it. 

"Fast Stats" was implemented by HIVE-3959

https://github.com/apache/hive/blob/branch-1.0/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L1363

>From create_table_core method
{code}
if (HiveConf.getBoolVar(hiveConf, 
HiveConf.ConfVars.HIVESTATSAUTOGATHER) &&
!MetaStoreUtils.isView(tbl)) {
  if (tbl.getPartitionKeysSize() == 0)  { // Unpartitioned table
MetaStoreUtils.updateUnpartitionedTableStatsFast(db, tbl, wh, 
madeDir);
  } else { // Partitioned table with no partitions.
MetaStoreUtils.updateUnpartitionedTableStatsFast(db, tbl, wh, true);
  }
}
{code}

Particularly Line 1363: // Partitioned table with no partitions.
{code}
MetaStoreUtils.updateUnpartitionedTableStatsFast(db, tbl, wh, true);
{code}

This call ends up calling Warehouse.getFileStatusesForUnpartitionedTable and do 
nothing in MetaStoreUtils.updateUnpartitionedTableStatsFast method due to 
newDir flag is always true

Impact of this bug is minor with HDFS warehouse 
location(hive.metastore.warehouse.dir), it could be big with S3 warehouse 
location especially for large existing partitions.
Also the impact is heighten with HIVE-6727 when warehouse location is S3, 
basically it could scan wrong S3 directory recursively and do nothing with it. 
I will add more detail of cases in comments



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HIVE-10630) Renaming tables across encryption zones renames table even though the operation throws error

[Deepesh Khandelwal (JIRA)]

Deepesh Khandelwal created HIVE-10630:
-

 Summary: Renaming tables across encryption zones renames table 
even though the operation throws error
 Key: HIVE-10630
 URL: https://issues.apache.org/jira/browse/HIVE-10630
 Project: Hive
  Issue Type: Sub-task
  Components: Security
Reporter: Deepesh Khandelwal


Create a table with data in an encrypted zone 1 and then rename it to encrypted 
zone 2.
{noformat}
hive> alter table encdb1.testtbl rename to encdb2.testtbl;
FAILED: Execution Error, return code 1 from 
org.apache.hadoop.hive.ql.exec.DDLTask. Unable to alter table. Unable to access 
old location 
hdfs://node-1.example.com:8020/apps/hive/warehouse/encdb1.db/testtbl for table 
encdb1.testtbl
{noformat}
Even though the command errors out the table is renamed. I think the right 
behavior should be to not rename the table at all including the metadata.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 33816: HIVE-10597: Relative path doesn't work with CREATE TABLE LOCATION 'relative/path'

[Reuben Kuhnert]

> On May 4, 2015, 9:03 p.m., Sergio Pena wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java, line 141
> > 
> >
> > does this line handle the relative path correctly?

This code works correctly.


- Reuben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33816/#review82440
---


On May 5, 2015, 3:14 p.m., Reuben Kuhnert wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33816/
> ---
> 
> (Updated May 5, 2015, 3:14 p.m.)
> 
> 
> Review request for hive and Sergio Pena.
> 
> 
> Bugs: HIVE-10597
> https://issues.apache.org/jira/browse/HIVE-10597
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Allow warehouse to work with relative locations.
> 
> 
> Diffs
> -
> 
>   metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java 
> 25119abf97382df7c0615edbaff29ba20624a137 
>   metastore/src/test/org/apache/hadoop/hive/metastore/TestWarehouse.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33816/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Reuben Kuhnert
> 
>

[jira] [Created] (HIVE-10629) Dropping table in an encrypted zone does not drop warehouse directory

[Deepesh Khandelwal (JIRA)]

Deepesh Khandelwal created HIVE-10629:
-

 Summary: Dropping table in an encrypted zone does not drop 
warehouse directory
 Key: HIVE-10629
 URL: https://issues.apache.org/jira/browse/HIVE-10629
 Project: Hive
  Issue Type: Sub-task
  Components: Security
Reporter: Deepesh Khandelwal


Drop table in an encrypted zone removes the table but not its data. The client 
sees the following on Hive CLI:
{noformat}
hive> drop table testtbl;
OK
Time taken: 0.158 seconds
{noformat}
On the Hive Metastore log following error is thrown:
{noformat}
2015-05-05 08:55:27,665 ERROR [pool-6-thread-142]: hive.log 
(MetaStoreUtils.java:logAndThrowMetaException(1200)) - Got exception: 
java.io.IOException Failed to move to trash: 
hdfs://node-1.example.com:8020/apps/hive/warehouse/encdb1.db/testtbl
java.io.IOException: Failed to move to trash: 
hdfs://node-1.example.com:8020/apps/hive/warehouse/encdb1.db/testtbl
at 
org.apache.hadoop.fs.TrashPolicyDefault.moveToTrash(TrashPolicyDefault.java:160)
at org.apache.hadoop.fs.Trash.moveToTrash(Trash.java:114)
at org.apache.hadoop.fs.Trash.moveToAppropriateTrash(Trash.java:95)
at 
org.apache.hadoop.hive.shims.Hadoop23Shims.moveToAppropriateTrash(Hadoop23Shims.java:270)
at 
org.apache.hadoop.hive.metastore.HiveMetaStoreFsImpl.deleteDir(HiveMetaStoreFsImpl.java:47)
at 
org.apache.hadoop.hive.metastore.Warehouse.deleteDir(Warehouse.java:229)
at 
org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.deleteTableData(HiveMetaStore.java:1584)
at 
org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.drop_table_core(HiveMetaStore.java:1552)
at 
org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.drop_table_with_environment_context(HiveMetaStore.java:1705)
at sun.reflect.GeneratedMethodAccessor57.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
org.apache.hadoop.hive.metastore.RetryingHMSHandler.invoke(RetryingHMSHandler.java:107)
at com.sun.proxy.$Proxy13.drop_table_with_environment_context(Unknown 
Source)
at 
org.apache.hadoop.hive.metastore.api.ThriftHiveMetastore$Processor$drop_table_with_environment_context.getResult(ThriftHiveMetastore.java:9256)

{noformat}
The client should throw the error and maybe fail the drop table call. To delete 
the table data one currently has to use {{drop table testtbl purge}} which 
basically remove the table data permanently skipping trash.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HIVE-10628) Incorrect result when vectorized native mapjoin is enabled

[Matt McCline (JIRA)]

Matt McCline created HIVE-10628:
---

 Summary: Incorrect result when vectorized native mapjoin is enabled
 Key: HIVE-10628
 URL: https://issues.apache.org/jira/browse/HIVE-10628
 Project: Hive
  Issue Type: Bug
  Components: Hive
Affects Versions: 1.2.0
Reporter: Matt McCline
Assignee: Matt McCline
Priority: Critical
 Fix For: 1.2.0, 1.3.0



Incorrect results for this query:

{noformat}
select count(*) from store_sales ss join store_returns sr on (sr.sr_item_sk <=> 
ss.ss_item_sk and sr.sr_customer_sk <=> ss.ss_customer_sk and sr.sr_item_sk <=> 
ss.ss_item_sk) where ss.ss_net_paid > 1000;
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 33861: HIVE-10608 Fix useless 'if' stamement in RetryingMetaStoreClient (135)

[Alexander Pivovarov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33861/#review82703
---

Ship it!


Ship It!

- Alexander Pivovarov


On May 5, 2015, 8:19 p.m., Alexander Pivovarov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33861/
> ---
> 
> (Updated May 5, 2015, 8:19 p.m.)
> 
> 
> Review request for hive and Szehon Ho.
> 
> 
> Bugs: HIVE-10608
> https://issues.apache.org/jira/browse/HIVE-10608
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-10608 Fix useless 'if' stamement in RetryingMetaStoreClient (135)
> 
> 
> Diffs
> -
> 
>   
> metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java
>  1b6487af748202d1d0411ac23a7507a9fbd7f251 
> 
> Diff: https://reviews.apache.org/r/33861/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Pivovarov
> 
>

Re: Review Request 33880: HIVE-10621 serde typeinfo equals methods are not symmetric

[Alexander Pivovarov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33880/#review82702
---

Ship it!


Ship It!

- Alexander Pivovarov


On May 6, 2015, 4:59 a.m., Alexander Pivovarov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33880/
> ---
> 
> (Updated May 6, 2015, 4:59 a.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-10621
> https://issues.apache.org/jira/browse/HIVE-10621
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-10621 serde typeinfo equals methods are not symmetric
> 
> 
> Diffs
> -
> 
>   serde/src/java/org/apache/hadoop/hive/serde2/io/HiveDecimalWritable.java 
> 6ab64e56c37f127551bbf21213ff4d4a98803c43 
>   serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/CharTypeInfo.java 
> 610818e21be3b376b1d40f3d16bf8bf7fc47adf3 
>   serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/DecimalTypeInfo.java 
> cbe48029307a370d229d8e444ec6542e093e959a 
>   
> serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/PrimitiveTypeInfo.java 
> a66b50a6a224b75d5c0f5dac5ec07eab44128c12 
>   serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/VarcharTypeInfo.java 
> 5ac2b46ac9ef3d6ddbf4496b23f43ff410a10e2f 
> 
> Diff: https://reviews.apache.org/r/33880/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Pivovarov
> 
>

[jira] [Created] (HIVE-10627) Queries fail with Failed to breakup Windowing invocations into Groups

[Jesus Camacho Rodriguez (JIRA)]

Jesus Camacho Rodriguez created HIVE-10627:
--

 Summary: Queries fail with Failed to breakup Windowing invocations 
into Groups
 Key: HIVE-10627
 URL: https://issues.apache.org/jira/browse/HIVE-10627
 Project: Hive
  Issue Type: Bug
Reporter: Jesus Camacho Rodriguez
Assignee: Jesus Camacho Rodriguez


TPC-DS queries 51 fails with Failed to breakup Windowing invocations into 
Groups. At least 1 group must only depend on input columns. Also check for 
circular dependencies.

{code}
explain  
WITH web_v1 as (
select
  ws_item_sk item_sk, d_date, sum(ws_sales_price),
  sum(sum(ws_sales_price))
  over (partition by ws_item_sk order by d_date rows between unbounded 
preceding and current row) cume_sales
from web_sales
,date_dim
where ws_sold_date_sk=d_date_sk
  and d_month_seq between 1193 and 1193+11
  and ws_item_sk is not NULL
group by ws_item_sk, d_date),
store_v1 as (
select
  ss_item_sk item_sk, d_date, sum(ss_sales_price),
  sum(sum(ss_sales_price))
  over (partition by ss_item_sk order by d_date rows between unbounded 
preceding and current row) cume_sales
from store_sales
,date_dim
where ss_sold_date_sk=d_date_sk
  and d_month_seq between 1193 and 1193+11
  and ss_item_sk is not NULL
group by ss_item_sk, d_date)
 select  *
from (select item_sk
 ,d_date
 ,web_sales
 ,store_sales
 ,max(web_sales)
 over (partition by item_sk order by d_date rows between unbounded 
preceding and current row) web_cumulative
 ,max(store_sales)
 over (partition by item_sk order by d_date rows between unbounded 
preceding and current row) store_cumulative
 from (select case when web.item_sk is not null then web.item_sk else 
store.item_sk end item_sk
 ,case when web.d_date is not null then web.d_date else 
store.d_date end d_date
 ,web.cume_sales web_sales
 ,store.cume_sales store_sales
   from web_v1 web full outer join store_v1 store on (web.item_sk = 
store.item_sk
  and web.d_date = 
store.d_date)
  )x )y
where web_cumulative > store_cumulative
order by item_sk
,d_date
limit 100;
{code}

Exception 
{code}
org.apache.hadoop.hive.ql.parse.SemanticException: Failed to breakup Windowing 
invocations into Groups. At least 1 group must only depend on input columns. 
Also check for circular dependencies.   
Underlying error: org.apache.hadoop.hive.ql.parse.SemanticException: Line 0:-1 
Invalid column reference '$f2'   
at 
org.apache.hadoop.hive.ql.parse.WindowingComponentizer.next(WindowingComponentizer.java:94)
at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genWindowingPlan(SemanticAnalyzer.java:11538)
at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genPostGroupByBodyPlan(SemanticAnalyzer.java:8514)
at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genBodyPlan(SemanticAnalyzer.java:8472)
at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genPlan(SemanticAnalyzer.java:9304)
at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genPlan(SemanticAnalyzer.java:9189)
at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genPlan(SemanticAnalyzer.java:9210)
at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genPlan(SemanticAnalyzer.java:9189)
at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genPlan(SemanticAnalyzer.java:9210)
at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genPlan(SemanticAnalyzer.java:9189)
at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genPlan(SemanticAnalyzer.java:9210)
at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genPlan(SemanticAnalyzer.java:9189)
at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genPlan(SemanticAnalyzer.java:9210)
at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genPlan(SemanticAnalyzer.java:9189)
at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genPlan(SemanticAnalyzer.java:9210)
at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.analyzeInternal(SemanticAnalyzer.java:9592)
at 
org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:208)
at 
org.apache.hadoop.hive.ql.parse.ExplainSemanticAnalyzer.analyzeInternal(ExplainSemanticAnalyzer.java:74)
at 
org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:208)
at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:414)
at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:310)
at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1005)
at org.apache.hadoop.hive.ql.Driver.runInternal(Driver.java:1070)
at org.apache.hadoop.hive.ql.Driver.run(Driver.java:942)
at org.apache.hadoop.hive.ql.Driver.run(Driver.java:932)
 

[jira] [Created] (HIVE-10626) Spark paln need to be updated [Spark Branch]

[Chinna Rao Lalam (JIRA)]

Chinna Rao Lalam created HIVE-10626:
---

 Summary: Spark paln need to be updated [Spark Branch]
 Key: HIVE-10626
 URL: https://issues.apache.org/jira/browse/HIVE-10626
 Project: Hive
  Issue Type: Bug
  Components: Spark
Affects Versions: spark-branch
Reporter: Chinna Rao Lalam
Assignee: Chinna Rao Lalam


[HIVE-8858] basic patch was committed, latest patch need to be committed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Review Request 33890: HIVE-10435: Make HiveSession implementation pluggable through configuration

[Akshay Goyal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33890/
---

Review request for hive and Amareshwari Sriramadasu.


Bugs: HIVE-10435
https://issues.apache.org/jira/browse/HIVE-10435


Repository: hive-git


Description
---

SessionManager in CLIService creates and keeps track of HiveSession. 
Right now, it creates HiveSessionImpl which is one implementation of 
HiveSession. This improvement request is to make it pluggable through a 
configuration so that other implementations can be passed.


Diffs
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 69fda45 
  service/src/java/org/apache/hive/service/cli/session/SessionManager.java 
36a30b1 
  
service/src/test/org/apache/hive/service/cli/session/TestPluggableHiveSessionImpl.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/33890/diff/


Testing
---

Newly added unit test passed.


Thanks,

Akshay Goyal

Re: Why SQL Standards Based Authorization is implemented on HiveServer2 side only?

[Sergey Tryuber]

Thanks, Alan

Of course, I do no suggest to move out SSBA completely to Metastore. As you
pointed out, it depends on query processing engine in some (but not all)
cases. I was thinking about movement of as much functionality as can be
moved and, finally, have two different SSBA covering both Metastore and HS2.

Re HDFS files - yes, the group has to be defined by HDFS admins and it is
very simple. Again, by having SSBA in both Metastore and HS2 we avoiding
necessity of tiresome Storage Based Authorization for secured production
deployments. Just having a group of trusted system users for different
frameworks is enough.

Re backward compatibility and having only one place of access granting -
that's only an additional option. So let's keep it apart of the discussion
for now.

Most probably I'll have to examine the source code to strengthen my points.
I'II do it in the second part of May.
On May 5, 2015 7:04 PM, "Alan Gates"  wrote:

> The issue is that security checks are done in the client.  In order to
> fully do them in the metastore we would have been forced to move
> significant amounts of functionality out of the client and into the
> metastore.  Query parsing and planning would have had to be moved to the
> metastore, basically making it HS2.  A few more comments inline:
>
>   Sergey Tryuber 
>  May 4, 2015 at 12:56
> Hi Guys,
>
> My understanding is that there are two safe ways of usage of SQL Standards
> Based Authorization (SSBA):
>
> 1. Hide Hive Metastore from the world by embedding it into HiveServer2.
> *MetaStoreAuthzAPIAuthorizerEmbedOnly* configuration for Metastore is
> only a half-protection since everyone can change tables-specific metadata.
> 2. Have "two Metastores", but Public one should be additionally
> protected by Storage Based Authorization
>
> Option #2 is much more demanded, since there are too many frameworks in
> Hadoop ecosystem which use Hive Metastore. But necessity to keep both SQL
> and HDFS ACLs in sync is an administration nightmare (especially taking
> into account that "doAs" option is false in SSBA mode).
>
> *Why isn't it possible to add SSBA-like authorizer to Hive Metastore as
> well?* The authorizer could check if a user has permissions to update
> table-specific metadata according to his role and username. I could even
> imagine following layout:
>
> 1. All the files in Hive tables can be accessed only by few system users
> (hive, spark-sql, impala, etc)
>
> How would you accomplish this?  Hive's files are stored in HDFS and thus
> must work with HDFS file permissions.  You could construct a group that
> contained those users and make the files accessible to that group, but each
> cluster admin would have to do that.
>
>  2. There is only a single place of granting permissions - through SQL
> standards and all SQL-like frameworks around the metastore should use it
>
> We can't break backwards compatibility, so we could make this an option
> but we couldn't enforce it.
>
>  3. Additional HDFS permissions configuration would be needed only for
> rare cases of data access from non-impersonated execution pipelines (Spark
> Core, etc)
> 4. No necessity to have embedded into HiveServer2 metastore, no strange
> configuration options, easier for understanding and documentation
>
> May be I've missed something in my understanding... So, please, point me to
> my mistake in this case.
>
>

[jira] [Created] (HIVE-10625) Handle Authorization for 'select ' hive queries in SQL Standard Authorization

[Nemon Lou (JIRA)]

Nemon Lou created HIVE-10625:


 Summary: Handle Authorization for  'select ' hive queries in 
 SQL Standard Authorization
 Key: HIVE-10625
 URL: https://issues.apache.org/jira/browse/HIVE-10625
 Project: Hive
  Issue Type: Bug
  Components: Authorization, SQLStandardAuthorization
Affects Versions: 1.1.0
Reporter: Nemon Lou


Hive internally rewrites this 'select ' query into 'select 
 from _dummy_database._dummy_table', where these dummy db and table 
are temp entities for the current query.
The SQL Standard Authorization  need to handle these special objects.

Typing "select reverse("123");" in beeline : 
,will get this error :
{code}
Error: Error while compiling statement: FAILED: HiveAuthzPluginException Error 
getting object from metastore for Object [type=TABLE_OR_VIEW, 
name=_dummy_database._dummy_table] (state=42000,code=4)
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 33814: Fold case udf

[Gopal V]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33814/#review82652
---



ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java


stray import?



ql/src/test/results/clientpositive/ql_rewrite_gbtoidx_cbo_2.q.out


This seems rather strange, since the rows are still being read (i.e select 
1 from lineitem_ix will return 3024 rows).

Is this a stats mismatch due to this patch?


- Gopal V


On May 6, 2015, 6:35 a.m., Ashutosh Chauhan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33814/
> ---
> 
> (Updated May 6, 2015, 6:35 a.m.)
> 
> 
> Review request for hive and Gopal V.
> 
> 
> Bugs: HIVE-9644
> https://issues.apache.org/jira/browse/HIVE-9644
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> CASE comparison operator rotation optimization
> 
> 
> Diffs
> -
> 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java
>  e9436e5 
>   ql/src/test/queries/clientpositive/fold_case.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/fold_when.q PRE-CREATION 
>   ql/src/test/results/clientpositive/fold_case.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/fold_when.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/ql_rewrite_gbtoidx_cbo_2.q.out 6340a75 
> 
> Diff: https://reviews.apache.org/r/33814/diff/
> 
> 
> Testing
> ---
> 
> New tests added.
> 
> 
> Thanks,
> 
> Ashutosh Chauhan
> 
>

[jira] [Created] (HIVE-10624) Update the initial script to make beeline bucked cli as default and allow user choose old hive cli by env

[Ferdinand Xu (JIRA)]

Ferdinand Xu created HIVE-10624:
---

 Summary: Update the initial script to make beeline bucked cli as 
default and allow user choose old hive cli by env
 Key: HIVE-10624
 URL: https://issues.apache.org/jira/browse/HIVE-10624
 Project: Hive
  Issue Type: Sub-task
Reporter: Ferdinand Xu
Assignee: Ferdinand Xu


As discussed in the dev-list, we should update the script to make new beeline 
bucked cli default and allow user to change to old cli by environment variable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Review Request 33882: Speed-up count(distinct c1)

[Ashutosh Chauhan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33882/
---

Review request for hive and John Pullokkaran.


Bugs: HIVE-10568
https://issues.apache.org/jira/browse/HIVE-10568


Repository: hive-git


Description
---

Speed-up count(distinct c1)


Diffs
-

  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveExpandDistinctAggregatesRule.java
 PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 49ad6ad 
  ql/src/test/results/clientpositive/tez/limit_pushdown.q.out 7038b4d 
  ql/src/test/results/clientpositive/tez/mrr.q.out ac5ac5c 
  ql/src/test/results/clientpositive/tez/vector_count_distinct.q.out f1da471 
  ql/src/test/results/clientpositive/tez/vectorization_limit.q.out d815938 
  ql/src/test/results/clientpositive/tez/vectorized_distinct_gby.q.out 90c9934 

Diff: https://reviews.apache.org/r/33882/diff/


Testing
---

Existing tests.


Thanks,

Ashutosh Chauhan