Review Request 43412: Migrate Column Stats Extrapolation and UniformDistribution to HBaseStore

2016-02-09 Thread pengcheng xiong

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43412/
---

Review request for hive, Ashutosh Chauhan and John Pullokkaran.


Repository: hive-git


Description
---

HIVE-12960 and HIVE-12961


Diffs
-

  metastore/src/java/org/apache/hadoop/hive/metastore/StatObjectConverter.java 
b3ceff1 
  metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseUtils.java 
d6d01bd 
  metastore/src/java/org/apache/hadoop/hive/metastore/hbase/StatsCache.java 
f1d2e50 
  
metastore/src/java/org/apache/hadoop/hive/metastore/hbase/stats/BinaryColumnStatsAggregator.java
 40340dd 
  
metastore/src/java/org/apache/hadoop/hive/metastore/hbase/stats/BooleanColumnStatsAggregator.java
 735d965 
  
metastore/src/java/org/apache/hadoop/hive/metastore/hbase/stats/ColumnStatsAggregator.java
 694e53b 
  
metastore/src/java/org/apache/hadoop/hive/metastore/hbase/stats/ColumnStatsAggregatorFactory.java
 8eb127b 
  
metastore/src/java/org/apache/hadoop/hive/metastore/hbase/stats/DecimalColumnStatsAggregator.java
 50f4325 
  
metastore/src/java/org/apache/hadoop/hive/metastore/hbase/stats/DoubleColumnStatsAggregator.java
 d945ec2 
  
metastore/src/java/org/apache/hadoop/hive/metastore/hbase/stats/IExtrapolatePartStatus.java
 PRE-CREATION 
  
metastore/src/java/org/apache/hadoop/hive/metastore/hbase/stats/LongColumnStatsAggregator.java
 068dd00 
  
metastore/src/java/org/apache/hadoop/hive/metastore/hbase/stats/StringColumnStatsAggregator.java
 aeb6c39 
  
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsExtrapolation.java
 PRE-CREATION 
  
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsNDVUniformDist.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/43412/diff/


Testing
---


Thanks,

pengcheng xiong



Review Request 43408: HIVE-13034 : Add jdeb plugin to build debian

2016-02-09 Thread Arshad Matin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43408/
---

Review request for hive.


Repository: hive-git


Description
---

HIVE-13034 : Add jdeb plugin to build debian


Diffs
-

  packaging/pom.xml e7feb62 
  packaging/src/deb/control/control PRE-CREATION 

Diff: https://reviews.apache.org/r/43408/diff/


Testing
---


Thanks,

Arshad Matin



[jira] [Created] (HIVE-13034) Add jdeb plugin to build debian

2016-02-09 Thread Arshad Matin (JIRA)
Arshad Matin created HIVE-13034:
---

 Summary: Add jdeb plugin to build debian
 Key: HIVE-13034
 URL: https://issues.apache.org/jira/browse/HIVE-13034
 Project: Hive
  Issue Type: Improvement
Reporter: Arshad Matin






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[VOTE] Apache Hive 2.0.0 Release Candidate 3

2016-02-09 Thread Sergey Shelukhin
Another day, another release candidate... this time fixing the logging
issue.

Apache Hive 2.0.0 Release Candidate 3 is available here:

http://people.apache.org/~sershe/hive-2.0.0-rc3/

Maven artifacts are at

https://repository.apache.org/content/repositories/orgapachehive-1046/


Source tag for RC3 (github mirror) is:
https://github.com/apache/hive/releases/tag/release-2.0.0-rc3


Voting will conclude in 72 hours.

Hive PMC Members: Please test and vote.


Thanks.




[jira] [Created] (HIVE-13033) SPDO unnecessarily duplicates columns in key & value of mapper output

2016-02-09 Thread Ashutosh Chauhan (JIRA)
Ashutosh Chauhan created HIVE-13033:
---

 Summary: SPDO unnecessarily duplicates columns in key & value of 
mapper output
 Key: HIVE-13033
 URL: https://issues.apache.org/jira/browse/HIVE-13033
 Project: Hive
  Issue Type: Improvement
  Components: Logical Optimizer
Affects Versions: 2.0.0
Reporter: Ashutosh Chauhan
Assignee: Ashutosh Chauhan






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [VOTE] Apache Hive 2.0.0 Release Candidate 2

2016-02-09 Thread Prasanth Jayachandran
I think we might need another RC. Found another issue with logging that could 
affect hive services. When I ran “hive —service metastore” logging was not 
initialized. This can affect other services as well.

Filed https://issues.apache.org/jira/browse/HIVE-13032 for the same.

I am -1 on this RC (will take back my initial +1).

Thanks
Prasanth

> On Feb 9, 2016, at 2:40 PM, Sergey Shelukhin  wrote:
> 
> Yes, that is expected as per https://issues.apache.org/jira/browse/HIVE-1841
> Hence the improved message instead of 1 lines of callstack ;)
> 
> From: Xuefu Zhang mailto:xzh...@cloudera.com>>
> Reply-To: "dev@hive.apache.org" 
> mailto:dev@hive.apache.org>>
> Date: Tuesday, February 9, 2016 at 10:37
> To: "dev@hive.apache.org" 
> mailto:dev@hive.apache.org>>
> Subject: Re: [VOTE] Apache Hive 2.0.0 Release Candidate 2
> 
> Some trouble I met:
> 
> 1. downloaded source and build Hive with -Pdist.
> 2. try to run Hive CLI and get the following error:
> 
> Exception in thread "main" java.lang.RuntimeException: Hive metastore 
> database is not initialized. Please use schematool (e.g. ./schematool 
> -initSchema -dbType ...) to create the schema. If needed, don't forget to 
> include the option to auto-create the underlying database in your JDBC 
> connection string (e.g. ?createDatabaseIfNotExist=true for mysql)
> 
> 
> Is this expected? This used to work out of box with embedded metastore 
> created automatcially.
> 
> Thanks,
> Xuefu
> 
> On Tue, Feb 9, 2016 at 10:15 AM, Alan Gates 
> mailto:alanfga...@gmail.com>> wrote:
> FYI the URL for the candidate returns 404, the correct URL is 
> http://people.apache.org/~sershe/hive-2.0.0-rc2/
> 
> +1, checks signatures, did a build with a brand new maven repo, and ran a 
> quick smoke test.
> 
> Alan.
> 
> [cid:part1.08070200.09010904@gmail.com]
> Sergey Shelukhin
> February 8, 2016 at 18:29
> Apache Hive 2.0.0 Release Candidate 2 is available here:
> 
> http://people.apache.org/~sershe/hive-2.0.0-RC2/
> 
> 
> Maven artifacts are at
> 
> https://repository.apache.org/content/repositories/orgapachehive-1044/
> 
> 
> Source tag for RC2 (github mirror) is:
> https://github.com/apache/hive/releases/tag/release-2.0.0-rc2
> (https://github.com/apache/hive/commit/ecccdda845a0a45de24463669847ddf37ad3
> c220)
> 
> Voting will conclude in 72 hours.
> 
> Hive PMC Members: Please test and vote.
> 
> 
> 
> Thanks.
> 
> 
> 



Re: Review Request 43115: HIVE-12924 CBO: Calcite Operator To Hive Operator (Calcite Return Path): TestCliDriver groupby_ppr_multi_distinct.q failure

2016-02-09 Thread Hari Sankar Sivarama Subramaniyan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43115/
---

(Updated Feb. 10, 2016, 12:12 a.m.)


Review request for hive, Jesús Camacho Rodríguez and John Pullokkaran.


Repository: hive-git


Description
---

CBO: Calcite Operator To Hive Operator (Calcite Return Path): TestCliDriver 
groupby_ppr_multi_distinct.q failure


Diffs (updated)
-

  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveGBOpConvUtil.java
 7fbf8cd 
  
ql/src/test/results/clientpositive/cbo_rp_groupby3_noskew_multi_distinct.q.out 
95233b0 

Diff: https://reviews.apache.org/r/43115/diff/


Testing
---

Precommit runs


Thanks,

Hari Sankar Sivarama Subramaniyan



Re: Review Request 43343: HIVE-12857 LLAP: modify the decider to allow using LLAP with whitelisted UDFs

2016-02-09 Thread Jason Dere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43343/#review118492
---




ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java (line 147)


Are you supposed to re-throw t here?



ql/src/test/queries/clientpositive/llap_udf.q (line 6)


Does this setting only get checked during query compilation time- in which 
case anyone can override this setting before running their query?

Or is this also enforced on the daemon side?



ql/src/test/queries/clientpositive/llap_udf.q (line 38)


If this was expected to fail, shouldn't this be in a negative CLIDriver?


- Jason Dere


On Feb. 8, 2016, 10:54 p.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43343/
> ---
> 
> (Updated Feb. 8, 2016, 10:54 p.m.)
> 
> 
> Review request for hive and Jason Dere.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   bin/hive 52433ec 
>   itests/qtest/pom.xml 292e562 
>   itests/src/test/resources/testconfiguration.properties b46b160 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java e0e030f 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java 77f11b9 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java 16c8c8f 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LlapDecider.java 
> ae64749 
>   ql/src/test/queries/clientpositive/llap_udf.q PRE-CREATION 
>   ql/src/test/results/clientpositive/llap/llap_udf.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43343/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>



[jira] [Created] (HIVE-13032) Hive services need HADOOP_CLIENT_OPTS for proper log4j2 initialization

2016-02-09 Thread Prasanth Jayachandran (JIRA)
Prasanth Jayachandran created HIVE-13032:


 Summary: Hive services need HADOOP_CLIENT_OPTS for proper log4j2 
initialization
 Key: HIVE-13032
 URL: https://issues.apache.org/jira/browse/HIVE-13032
 Project: Hive
  Issue Type: Bug
Affects Versions: 2.0.0, 2.1.0
Reporter: Prasanth Jayachandran
Assignee: Prasanth Jayachandran


HIVE-12497 removed HADOOP_CLIENT_OPTS as it slowed down cli launch time. But it 
leads to log4j2 not being initialized when using services other than CLI. Other 
services like metastore, schematool etc. rely on log4j to initialize the 
logging based on the presence of log4j2.properties file in the classpath. If we 
use the standard name for log4j configuration file (log4j2.properties) then 
automatic initialization will happen. If not, we have to tell log4j to look for 
specific properties file. This is done via -Dlog4j.configurationFile system 
property. If we pass this system property via HADOOP_CLIENT_OPTS then all hive 
services will have logging initialized properly. 

In HIVE-12497, the problem was we had HADOOP_CLIENT_OPTS at the top of the 
script. As a result, hadoop and hbase commands tries to initialize logging 
which took long time slowing down the startup time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 43176: HIVE-12965: Insert overwrite local directory should perserve the overwritten directory permission

2016-02-09 Thread Xuefu Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43176/#review118462
---


Ship it!




Ship It!

- Xuefu Zhang


On Feb. 9, 2016, 8:55 p.m., Chaoyu Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43176/
> ---
> 
> (Updated Feb. 9, 2016, 8:55 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan, Szehon Ho, and Xuefu Zhang.
> 
> 
> Bugs: HIVE-12965
> https://issues.apache.org/jira/browse/HIVE-12965
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> In Hive, "insert overwrite local directory" first deletes the overwritten 
> directory if exists, recreate a new one, then copy the files from src 
> directory to the new local directory. This process sometimes changes the 
> permissions of the to-be-overwritten local directory, therefore causing some 
> applications no more to be able to access its content.
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java e9cd450 
> 
> Diff: https://reviews.apache.org/r/43176/diff/
> 
> 
> Testing
> ---
> 
> Manual tests
> Precommit tests
> 
> 
> Thanks,
> 
> Chaoyu Tang
> 
>



Re: Review Request 43176: HIVE-12965: Insert overwrite local directory should perserve the overwritten directory permission

2016-02-09 Thread Chaoyu Tang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43176/
---

(Updated Feb. 9, 2016, 8:55 p.m.)


Review request for hive, Ashutosh Chauhan, Szehon Ho, and Xuefu Zhang.


Changes
---

Revised patch based on Xuefu's comments.


Bugs: HIVE-12965
https://issues.apache.org/jira/browse/HIVE-12965


Repository: hive-git


Description
---

In Hive, "insert overwrite local directory" first deletes the overwritten 
directory if exists, recreate a new one, then copy the files from src directory 
to the new local directory. This process sometimes changes the permissions of 
the to-be-overwritten local directory, therefore causing some applications no 
more to be able to access its content.


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java e9cd450 

Diff: https://reviews.apache.org/r/43176/diff/


Testing
---

Manual tests
Precommit tests


Thanks,

Chaoyu Tang



Re: [VOTE] Apache Hive 2.0.0 Release Candidate 2

2016-02-09 Thread Sergey Shelukhin
Yes, that is expected as per https://issues.apache.org/jira/browse/HIVE-1841
Hence the improved message instead of 1 lines of callstack ;)

From: Xuefu Zhang mailto:xzh...@cloudera.com>>
Reply-To: "dev@hive.apache.org" 
mailto:dev@hive.apache.org>>
Date: Tuesday, February 9, 2016 at 10:37
To: "dev@hive.apache.org" 
mailto:dev@hive.apache.org>>
Subject: Re: [VOTE] Apache Hive 2.0.0 Release Candidate 2

Some trouble I met:

1. downloaded source and build Hive with -Pdist.
2. try to run Hive CLI and get the following error:

Exception in thread "main" java.lang.RuntimeException: Hive metastore database 
is not initialized. Please use schematool (e.g. ./schematool -initSchema 
-dbType ...) to create the schema. If needed, don't forget to include the 
option to auto-create the underlying database in your JDBC connection string 
(e.g. ?createDatabaseIfNotExist=true for mysql)


Is this expected? This used to work out of box with embedded metastore created 
automatcially.

Thanks,
Xuefu

On Tue, Feb 9, 2016 at 10:15 AM, Alan Gates 
mailto:alanfga...@gmail.com>> wrote:
FYI the URL for the candidate returns 404, the correct URL is 
http://people.apache.org/~sershe/hive-2.0.0-rc2/

+1, checks signatures, did a build with a brand new maven repo, and ran a quick 
smoke test.

Alan.

[cid:part1.08070200.09010904@gmail.com]
Sergey Shelukhin
February 8, 2016 at 18:29
Apache Hive 2.0.0 Release Candidate 2 is available here:

http://people.apache.org/~sershe/hive-2.0.0-RC2/


Maven artifacts are at

https://repository.apache.org/content/repositories/orgapachehive-1044/


Source tag for RC2 (github mirror) is:
https://github.com/apache/hive/releases/tag/release-2.0.0-rc2
(https://github.com/apache/hive/commit/ecccdda845a0a45de24463669847ddf37ad3
c220)

Voting will conclude in 72 hours.

Hive PMC Members: Please test and vote.



Thanks.





Re: Review Request 43332: HIVE-9534: incorrect result set for query that projects a windowed aggregate

2016-02-09 Thread Aihua Xu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43332/
---

(Updated Feb. 9, 2016, 8:01 p.m.)


Review request for hive, Chaoyu Tang, Szehon Ho, Xuefu Zhang, and Yongzhi Chen.


Changes
---

Fix unit test issue.


Repository: hive-git


Description
---

HIVE-9534: incorrect result set for query that projects a windowed aggregate


Diffs (updated)
-

  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/functions/CanAggregateDistinct.java
 PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/functions/HiveSqlCountAggFunction.java
 58191e5 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/functions/HiveSqlSumAggFunction.java
 498cd0e 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java
 19aa414 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFAverage.java 
cd2449f 
  ql/src/test/queries/clientpositive/windowing_distinct.q 9f6ddfd 
  ql/src/test/results/clientpositive/windowing_distinct.q.out 0858f0f 

Diff: https://reviews.apache.org/r/43332/diff/


Testing
---


Thanks,

Aihua Xu



Re: Review Request 43176: HIVE-12965: Insert overwrite local directory should perserve the overwritten directory permission

2016-02-09 Thread Xuefu Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43176/#review118442
---




ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java (line 120)


Do we need returned boolean? I don't see it's used.



ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java (line 171)


could we use FS.exists() to detect this instead of relying on exception 
handling? See below exmaple when checking the sourcePath.


- Xuefu Zhang


On Feb. 9, 2016, 6:54 p.m., Chaoyu Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43176/
> ---
> 
> (Updated Feb. 9, 2016, 6:54 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan, Szehon Ho, and Xuefu Zhang.
> 
> 
> Bugs: HIVE-12965
> https://issues.apache.org/jira/browse/HIVE-12965
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> In Hive, "insert overwrite local directory" first deletes the overwritten 
> directory if exists, recreate a new one, then copy the files from src 
> directory to the new local directory. This process sometimes changes the 
> permissions of the to-be-overwritten local directory, therefore causing some 
> applications no more to be able to access its content.
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java e9cd450 
> 
> Diff: https://reviews.apache.org/r/43176/diff/
> 
> 
> Testing
> ---
> 
> Manual tests
> Precommit tests
> 
> 
> Thanks,
> 
> Chaoyu Tang
> 
>



Re: [VOTE] Apache Hive 2.0.0 Release Candidate 2

2016-02-09 Thread Prasanth Jayachandran
+1

Verified signature
Verified checksum
Verified source compilation and binary
Ran smoke tests on LLAP

Thanks
Prasanth

On Feb 9, 2016, at 1:10 PM, Alan Gates 
mailto:alanfga...@gmail.com>> wrote:

It is expected, you now have to run SchemaTool manually, as the error message 
indicates.  See https://issues.apache.org/jira/browse/HIVE-1841

Alan.

[cid:part1.03060309.08020103@gmail.com]
Xuefu Zhang
February 9, 2016 at 10:37
Some trouble I met:

1. downloaded source and build Hive with -Pdist.
2. try to run Hive CLI and get the following error:

Exception in thread "main" java.lang.RuntimeException: Hive metastore database 
is not initialized. Please use schematool (e.g. ./schematool -initSchema 
-dbType ...) to create the schema. If needed, don't forget to include the 
option to auto-create the underlying database in your JDBC connection string 
(e.g. ?createDatabaseIfNotExist=true for mysql)


Is this expected? This used to work out of box with embedded metastore created 
automatcially.

Thanks,
Xuefu


[cid:part1.03060309.08020103@gmail.com]
Sergey Shelukhin
February 8, 2016 at 18:29
Apache Hive 2.0.0 Release Candidate 2 is available here:

http://people.apache.org/~sershe/hive-2.0.0-RC2/


Maven artifacts are at

https://repository.apache.org/content/repositories/orgapachehive-1044/


Source tag for RC2 (github mirror) is:
https://github.com/apache/hive/releases/tag/release-2.0.0-rc2
(https://github.com/apache/hive/commit/ecccdda845a0a45de24463669847ddf37ad3
c220)

Voting will conclude in 72 hours.

Hive PMC Members: Please test and vote.



Thanks.





Re: [VOTE] Apache Hive 2.0.0 Release Candidate 2

2016-02-09 Thread Alan Gates
It is expected, you now have to run SchemaTool manually, as the error 
message indicates.  See https://issues.apache.org/jira/browse/HIVE-1841


Alan.


Xuefu Zhang 
February 9, 2016 at 10:37
Some trouble I met:

1. downloaded source and build Hive with -Pdist.
2. try to run Hive CLI and get the following error:

Exception in thread "main" java.lang.RuntimeException: Hive metastore 
database is not initialized. Please use schematool (e.g. ./schematool 
-initSchema -dbType ...) to create the schema. If needed, don't forget 
to include the option to auto-create the underlying database in your 
JDBC connection string (e.g. ?createDatabaseIfNotExist=true for mysql)



Is this expected? This used to work out of box with embedded metastore 
created automatcially.


Thanks,
Xuefu


Sergey Shelukhin 
February 8, 2016 at 18:29
Apache Hive 2.0.0 Release Candidate 2 is available here:

http://people.apache.org/~sershe/hive-2.0.0-RC2/


Maven artifacts are at

https://repository.apache.org/content/repositories/orgapachehive-1044/


Source tag for RC2 (github mirror) is:
https://github.com/apache/hive/releases/tag/release-2.0.0-rc2
(https://github.com/apache/hive/commit/ecccdda845a0a45de24463669847ddf37ad3
c220)

Voting will conclude in 72 hours.

Hive PMC Members: Please test and vote.



Thanks.




Re: Review Request 43176: HIVE-12965: Insert overwrite local directory should perserve the overwritten directory permission

2016-02-09 Thread Chaoyu Tang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43176/
---

(Updated Feb. 9, 2016, 6:54 p.m.)


Review request for hive, Ashutosh Chauhan, Szehon Ho, and Xuefu Zhang.


Changes
---

Update the patch based on the review.


Bugs: HIVE-12965
https://issues.apache.org/jira/browse/HIVE-12965


Repository: hive-git


Description
---

In Hive, "insert overwrite local directory" first deletes the overwritten 
directory if exists, recreate a new one, then copy the files from src directory 
to the new local directory. This process sometimes changes the permissions of 
the to-be-overwritten local directory, therefore causing some applications no 
more to be able to access its content.


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java e9cd450 

Diff: https://reviews.apache.org/r/43176/diff/


Testing
---

Manual tests
Precommit tests


Thanks,

Chaoyu Tang



Re: [VOTE] Apache Hive 2.0.0 Release Candidate 2

2016-02-09 Thread Xuefu Zhang
Some trouble I met:

1. downloaded source and build Hive with -Pdist.
2. try to run Hive CLI and get the following error:

Exception in thread "main" java.lang.RuntimeException: Hive metastore
database is not initialized. Please use schematool (e.g. ./schematool
-initSchema -dbType ...) to create the schema. If needed, don't forget to
include the option to auto-create the underlying database in your JDBC
connection string (e.g. ?createDatabaseIfNotExist=true for mysql)


Is this expected? This used to work out of box with embedded metastore
created automatcially.

Thanks,
Xuefu

On Tue, Feb 9, 2016 at 10:15 AM, Alan Gates  wrote:

> FYI the URL for the candidate returns 404, the correct URL is
> http://people.apache.org/~sershe/hive-2.0.0-rc2/
>
> +1, checks signatures, did a build with a brand new maven repo, and ran a
> quick smoke test.
>
> Alan.
>
> Sergey Shelukhin 
> February 8, 2016 at 18:29
> Apache Hive 2.0.0 Release Candidate 2 is available here:
>
> http://people.apache.org/~sershe/hive-2.0.0-RC2/
>
>
> Maven artifacts are at
>
> https://repository.apache.org/content/repositories/orgapachehive-1044/
>
>
> Source tag for RC2 (github mirror) is:
> https://github.com/apache/hive/releases/tag/release-2.0.0-rc2
> (
> https://github.com/apache/hive/commit/ecccdda845a0a45de24463669847ddf37ad3
> c220)
>
> Voting will conclude in 72 hours.
>
> Hive PMC Members: Please test and vote.
>
>
>
> Thanks.
>
>
>


Re: [VOTE] Apache Hive 2.0.0 Release Candidate 2

2016-02-09 Thread Alan Gates
FYI the URL for the candidate returns 404, the correct URL is 
http://people.apache.org/~sershe/hive-2.0.0-rc2/


+1, checks signatures, did a build with a brand new maven repo, and ran 
a quick smoke test.


Alan.


Sergey Shelukhin 
February 8, 2016 at 18:29
Apache Hive 2.0.0 Release Candidate 2 is available here:

http://people.apache.org/~sershe/hive-2.0.0-RC2/


Maven artifacts are at

https://repository.apache.org/content/repositories/orgapachehive-1044/


Source tag for RC2 (github mirror) is:
https://github.com/apache/hive/releases/tag/release-2.0.0-rc2
(https://github.com/apache/hive/commit/ecccdda845a0a45de24463669847ddf37ad3
c220)

Voting will conclude in 72 hours.

Hive PMC Members: Please test and vote.



Thanks.




[jira] [Created] (HIVE-13031) List object type with database object

2016-02-09 Thread Todd Wilson (JIRA)
Todd Wilson created HIVE-13031:
--

 Summary: List object type with database object
 Key: HIVE-13031
 URL: https://issues.apache.org/jira/browse/HIVE-13031
 Project: Hive
  Issue Type: Improvement
  Components: ODBC
Reporter: Todd Wilson


SHOW TABLES IN  will currently list tables and views.  It would be 
helpful to also have the table type or object type returned with the list of 
object names so that a DESCRIBE command doesn't need to be run on each object.  
Our application uses object type quite frequently and to be able to pull this 
information at one time during a SHOW TABLE EXTENDED for example would be 
preferred over having to run DESCRIBE for each object in the database.  We're 
using the Hive ODBC driver to connect.  Thanks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 43176: HIVE-12965: Insert overwrite local directory should perserve the overwritten directory permission

2016-02-09 Thread Xuefu Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43176/#review118398
---




ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java (line 135)


I think the existance of a file/dir can be checked by calling FS.exists(). 
I usually avoid depending on exception to do something useful other than 
handling exception itself. However, it's up to you.



ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java (line 160)


it seems fs didn't get closed in all paths. However, I understand that the 
problem was there before.


- Xuefu Zhang


On Feb. 4, 2016, 4:07 a.m., Chaoyu Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43176/
> ---
> 
> (Updated Feb. 4, 2016, 4:07 a.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan, Szehon Ho, and Xuefu Zhang.
> 
> 
> Bugs: HIVE-12965
> https://issues.apache.org/jira/browse/HIVE-12965
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> In Hive, "insert overwrite local directory" first deletes the overwritten 
> directory if exists, recreate a new one, then copy the files from src 
> directory to the new local directory. This process sometimes changes the 
> permissions of the to-be-overwritten local directory, therefore causing some 
> applications no more to be able to access its content.
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java e9cd450 
> 
> Diff: https://reviews.apache.org/r/43176/diff/
> 
> 
> Testing
> ---
> 
> Manual tests
> Precommit tests
> 
> 
> Thanks,
> 
> Chaoyu Tang
> 
>



Re: Review Request 43145: HIVE-12994

2016-02-09 Thread Jesús Camacho Rodríguez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43145/
---

(Updated Feb. 9, 2016, 10:42 a.m.)


Review request for hive and John Pullokkaran.


Bugs: HIVE-12994
https://issues.apache.org/jira/browse/HIVE-12994


Repository: hive-git


Description
---

Implement support for NULLS FIRST/NULLS LAST


Diffs (updated)
-

  itests/src/test/resources/testconfiguration.properties 
b46b1605e585224b8c4bc177180b5dd68d14c97e 
  metastore/if/hive_metastore.thrift 9d8c092ef8ab2d081e014fb84242451e69a37ad8 
  metastore/scripts/upgrade/derby/033-HIVE-12994.derby.sql PRE-CREATION 
  metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 
660a85a4ab464bd69336d99b231edc47a6657850 
  metastore/scripts/upgrade/derby/upgrade-2.0.0-to-2.1.0.derby.sql 
30de00bf034b5bc4470b4f515cd953586fd93658 
  
metastore/src/gen/protobuf/gen-java/org/apache/hadoop/hive/metastore/Metastore.java
 416ae9d68d99110a2d9c2524e4156a43aac18ea6 
  
metastore/src/gen/protobuf/gen-java/org/apache/hadoop/hive/metastore/hbase/HbaseMetastoreProto.java
 3b2d7b5db638dc6b35f968279d6b5129977e6f1d 
  metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h 
c501ac0eb1ed8ced83a557e4843b2c52d7464602 
  metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp 
81577b612282f75e09a5a4a3b036fc03b0808ffb 
  
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Order.java
 cc0e2dd027d2e909ea4a39a742b33218c3f8411f 
  metastore/src/gen/thrift/gen-php/metastore/Types.php 
57d1dafcc75f734000f9c8fcd26f54bdcfc2a808 
  metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py 
77dd9a6fcdaeea31b1d1bc58d370463a1d46 
  metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb 
2cf433bff38ca69d8f13350c205e51fd51dab9a1 
  metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 
6da295e246e2259647e32d8ba33c783b28d41550 
  metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 
b8087287446ef243045a017768008829b5c4eb66 
  metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseUtils.java 
d6d01bdbb879397d1b28675f5dfaa345d9b1066f 
  metastore/src/model/org/apache/hadoop/hive/metastore/model/MOrder.java 
1fa82a4fde9d315d4955ee5698796f58ce8a0921 
  
metastore/src/protobuf/org/apache/hadoop/hive/metastore/hbase/hbase_metastore_proto.proto
 466fdf9dc0b0e9d1c58c9b44977896780963e2ac 
  metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStore.java 
29d5a64154fdb9ab9586fb919fbeae7106b1a874 
  
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStoreBitVector.java
 b0d76620b94b25c66b8e0857100e6a8c8343 
  
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestSharedStorageDescriptor.java
 e0d8ce4dede474ad1b752794379342993bf89fa4 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 
be6ea63fca44bf2bfbdc4368adc26c3d1448561d 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java 
91b5ca769f88b04c379f38bad3518d36958f1c71 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 
e9cd450276511c36ecbdd0098c083871273f361d 
  
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/HybridHashTableContainer.java
 fdc1dfffd977ef3a71fcf56da19a3b2b91538921 
  
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinBytesTableContainer.java
 5c2ff9276b575f93a3df0fd2da378b85f7074a22 
  ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinKey.java 
cfb9abc380880da2cefe6968fd81dc3b974ec1ed 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DynamicPartitionPruner.java 
1510fdd555223514786dfd9137103c1339c4fc2a 
  
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkCommonOperator.java
 7bdd11a1e46ac41f16fe26abebe8371fd1e41275 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 
75d2519479fcdc00782049958207e11860ed78f4 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractSMBJoinProc.java 
b57dc77c23767f46c27fad0c5761bd2a79489f18 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketingSortingReduceSinkOptimizer.java
 d5f3057a5c070a22786d3151132dc59d38a0ebb4 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkMapJoinProc.java 
c38c6d7f7b8503fed45ad9034b45064bbe3100dd 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedDynPartitionOptimizer.java
 27b04570b0fc2af41aaa41e83198e640ffc17e80 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java 
02db680c51f7767cd1369bff3b202eaa2367c481 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java
 3f2267dc7926243b82d69cc65400b5b536081e53 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ExprNodeConverter.java
 b42e78f796fb91b2bff3443972ad7512b18d68ee 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverter.java
 a0e374c744c880c6980a8abc7667d36c8ccba7e1 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/

[jira] [Created] (HIVE-13030) Javadocs issue: Hive HCatalog build failed with IBM JDK 1.8 during Maven release

2016-02-09 Thread Devendra Vishwakarma (JIRA)
Devendra Vishwakarma created HIVE-13030:
---

 Summary: Javadocs issue: Hive HCatalog build failed with IBM JDK 
1.8 during Maven release
 Key: HIVE-13030
 URL: https://issues.apache.org/jira/browse/HIVE-13030
 Project: Hive
  Issue Type: Bug
  Components: HCatalog, Hive, WebHCat
Affects Versions: 1.2.1
 Environment: Hive 1.2.1 + IBM JDK 1.8 + s390x architecture
Reporter: Devendra Vishwakarma
Assignee: Devendra Vishwakarma
 Fix For: 1.2.1


When building Hive with IBM JDK1.8, the maven release build is failing because 
of missing javadocs in Hive HCatolog webhcat  module.

All the errors are related to missing javadocs-
10:55:17 [INFO] [INFO] Hive HCatalog Webhcat . 
FAILURE [12.229s]
10:55:17 [INFO] [INFO] Hive HCatalog Streaming ... 
SKIPPED
10:55:17 [INFO] [INFO] Hive HWI .. 
SKIPPED
10:55:17 [INFO] [INFO] Hive ODBC . 
SKIPPED
10:55:17 [INFO] [INFO] Hive Shims Aggregator . 
SKIPPED
10:55:17 [INFO] [INFO] Hive TestUtils  
SKIPPED
10:55:17 [INFO] [INFO] Hive Packaging  
SKIPPED
10:55:17 [INFO] [INFO] 

10:55:17 [INFO] [INFO] BUILD FAILURE
10:55:17 [INFO] [INFO] 

10:55:17 [INFO] [INFO] Total time: 4:10.477s
10:55:17 [INFO] [INFO] Finished at: Wed Feb 03 10:55:18 PST 2016
10:55:17 [INFO] [INFO] Final Memory: 79M/377M
10:55:17 [INFO] [INFO] 

10:55:17 [INFO] [ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-javadoc-plugin:2.4:jar (attach-javadocs) on 
project hive-webhcat: Error while creating archive:Exit code: 1 - 
/a/workspace//hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/AppConfig.java:353:
 warning: no @return
10:55:17 [INFO] [ERROR] public Collection hiveProps() {
10:55:17 [INFO] [ERROR] ^
.
.
.
.
.

There are lots of such errors coming in HCatlog package.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)