date:20160428

Re: Review Request 46755: JDBC: Support query timeout for jdbc

2016-04-28 Thread Thejas Nair


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46755/#review131001
---




service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java (line 
382)


I think we should call this on any terminal state , except for TIMEOUT.


- Thejas Nair


On April 27, 2016, 11:14 p.m., Vaibhav Gumashta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46755/
> ---
> 
> (Updated April 27, 2016, 11:14 p.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-4924
> https://issues.apache.org/jira/browse/HIVE-4924
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/HIVE-4924
> 
> 
> Diffs
> -
> 
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 
> 965627f 
>   
> itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestHiveSessionImpl.java
>  4d763d2 
>   jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java 3cc6b74 
>   ql/src/java/org/apache/hadoop/hive/ql/Driver.java dad43fb 
>   ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistoryImpl.java 0234fd9 
>   service-rpc/if/TCLIService.thrift 92bcf77 
>   service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 9f937ca 
>   service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp 66f5e8c 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TExecuteStatementReq.java
>  2eb4d09 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TOperationState.java
>  3fa49b0 
>   service-rpc/src/gen/thrift/gen-php/Types.php 7f1f99f 
>   service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py 3bb20b8 
>   service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 7208bae 
>   service/src/java/org/apache/hive/service/cli/CLIService.java 4a83e38 
>   service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 
> 79e0024 
>   service/src/java/org/apache/hive/service/cli/ICLIService.java e4aef96 
>   service/src/java/org/apache/hive/service/cli/OperationState.java 6a67a1d 
>   
> service/src/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java
>  b3d9b52 
>   
> service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java
>  f18dc67 
>   
> service/src/java/org/apache/hive/service/cli/operation/MetadataOperation.java 
> 77228fa 
>   service/src/java/org/apache/hive/service/cli/operation/Operation.java 
> 63b1a48 
>   
> service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 
> 52e4b4d 
>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 
> 01dd48c 
>   service/src/java/org/apache/hive/service/cli/session/HiveSession.java 
> 9ea643b 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
> 0cfec7a 
>   
> service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java
>  b2e0e9e 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 
> 6ede1d7 
>   
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java
>  098aea6 
>   
> service/src/test/org/apache/hive/service/cli/thrift/ThriftCLIServiceTest.java 
> 1740079 
>   
> service/src/test/org/apache/hive/service/cli/thrift/ThriftCliServiceTestWithCookie.java
>  a1ef1fc 
> 
> Diff: https://reviews.apache.org/r/46755/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>

[jira] [Created] (HIVE-13651) LlapBaseInputFormat: figure out where credentials come from

2016-04-28 Thread Jason Dere (JIRA)

Jason Dere created HIVE-13651:
-

 Summary: LlapBaseInputFormat: figure out where credentials come 
from
 Key: HIVE-13651
 URL: https://issues.apache.org/jira/browse/HIVE-13651
 Project: Hive
  Issue Type: Sub-task
  Components: llap
Reporter: Jason Dere


todo in LlapBaseInputFormat.constructSubmitWorkRequestProto()
{code}
// TODO Figure out where credentials will come from. Normally Hive sets up
// URLs on the tez dag, for which Tez acquires credentials.

//taskCredentials.addAll(getContext().getCredentials());

//
Preconditions.checkState(currentQueryIdentifierProto.getDagIdentifier() ==
//
taskSpec.getTaskAttemptID().getTaskID().getVertexID().getDAGId().getId());
//ByteBuffer credentialsBinary = 
credentialMap.get(currentQueryIdentifierProto);
//if (credentialsBinary == null) {
//  credentialsBinary = 
serializeCredentials(getContext().getCredentials());
//  credentialMap.putIfAbsent(currentQueryIdentifierProto, 
credentialsBinary.duplicate());
//} else {
//  credentialsBinary = credentialsBinary.duplicate();
//}
//builder.setCredentialsBinary(ByteString.copyFrom(credentialsBinary));
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HIVE-13650) LLAP: Other todo items in LlapTaskUmbilicalExternalClient

2016-04-28 Thread Jason Dere (JIRA)

Jason Dere created HIVE-13650:
-

 Summary: LLAP: Other todo items in LlapTaskUmbilicalExternalClient
 Key: HIVE-13650
 URL: https://issues.apache.org/jira/browse/HIVE-13650
 Project: Hive
  Issue Type: Sub-task
  Components: llap
Reporter: Jason Dere


Other TODOs from LlapTaskUmbilicalExternalClient:

- From submitWork():
{code}
//// TODO Also send out information saying that the fragment is finishable 
- if that is not already included in the main fragment.
//// This entire call is only required if we're doing more than scans. 
MRInput has no dependencies and is always finishable
//QueryIdentifierProto queryIdentifier = QueryIdentifierProto
//.newBuilder()
//
.setAppIdentifier(submitWorkRequestProto.getApplicationIdString()).setDagIdentifier(submitWorkRequestProto.getFragmentSpec().getDagId())
//.build();
//LlapDaemonProtocolProtos.SourceStateUpdatedRequestProto 
sourceStateUpdatedRequest =
//
LlapDaemonProtocolProtos.SourceStateUpdatedRequestProto.newBuilder().setQueryIdentifier(queryIdentifier).setState(
//LlapDaemonProtocolProtos.SourceStateProto.S_SUCCEEDED).
//setSrcName(TODO)
//
communicator.sendSourceStateUpdate(LlapDaemonProtocolProtos.SourceStateUpdatedRequestProto.newBuilder().setQueryIdentifier(submitWorkRequestProto.getFragmentSpec().getFragmentIdentifierString()).set);
{code}

- HeartbeatCheckTask.run(): If the heartbeat times out and we abandon the LLAP 
task, we may want to notify the LLAP daemon that we are no longer interested in 
this task.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HIVE-13649) LLAP: Work out the details of LlapTaskUmbilicalExternalClient tokenIdentifier

2016-04-28 Thread Jason Dere (JIRA)

Jason Dere created HIVE-13649:
-

 Summary: LLAP: Work out the details of 
LlapTaskUmbilicalExternalClient tokenIdentifier
 Key: HIVE-13649
 URL: https://issues.apache.org/jira/browse/HIVE-13649
 Project: Hive
  Issue Type: Sub-task
  Components: llap
Reporter: Jason Dere


Creating new task for TODO in LlapTaskUmbilicalExternalClient:
{code}
  // TODO KKK Work out the details of the tokenIdentifier, and the session 
token.
  // It may just be possible to create one here - since Shuffle is not 
involved, and this is only used
  // for communication from LLAP-Daemons to the server. It will need to be sent 
in as part
  // of the job submission request.
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Review Request 46809: HIVE-13442 LLAP: refactor submit API to be amenable to signing

2016-04-28 Thread Sergey Shelukhin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46809/
---

Review request for hive and Siddharth Seth.


Repository: hive-git


Description
---

see jira


Diffs
-

  llap-common/src/java/org/apache/hadoop/hive/llap/tez/Converters.java ec6e439 
  llap-common/src/protobuf/LlapDaemonProtocol.proto 944c96c 
  llap-common/src/test/org/apache/hadoop/hive/llap/tez/TestConverters.java 
d4cdac1 
  
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java
 3d45c7a 
  
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryFragmentInfo.java
 480a394 
  llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryInfo.java 
64c2b58 
  
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryTracker.java 
14657e6 
  
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java
 f621af2 
  
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskRunnerCallable.java
 fcfa940 
  
llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorTestHelpers.java
 24f4442 
  
llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/comparator/TestFirstInFirstOutComparator.java
 08ee769 
  
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java
 a4f5d4d 

Diff: https://reviews.apache.org/r/46809/diff/


Testing
---


Thanks,

Sergey Shelukhin

[jira] [Created] (HIVE-13648) Look at ORC data type conversion edge cases (CHAR, VARCHAR, DECIMAL)

2016-04-28 Thread Matt McCline (JIRA)

Matt McCline created HIVE-13648:
---

 Summary: Look at ORC data type conversion edge cases (CHAR, 
VARCHAR, DECIMAL)
 Key: HIVE-13648
 URL: https://issues.apache.org/jira/browse/HIVE-13648
 Project: Hive
  Issue Type: Bug
Reporter: Matt McCline
Assignee: Matt McCline
Priority: Critical


New ORC data type conversion has some edges cases like CHAR/VAR different max 
lengths and DECIMAL different scale/precision that need attention.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 46715: HIVE-13596 HS2 should be able to get UDFs on demand from metastore

2016-04-28 Thread Lefty Leverenz


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46715/#review131017
---




common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines 2324 - 2326)


Edits:

"Whether enable" --> "Whether to enable"
"HS2" --> "HiveServer2"

Nice use of semicolon.  ;)


- Lefty Leverenz


On April 28, 2016, 12:20 a.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46715/
> ---
> 
> (Updated April 28, 2016, 12:20 a.m.)
> 
> 
> Review request for hive and Jason Dere.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 49d748c 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java d5f4a37 
>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 672df63 
> 
> Diff: https://reviews.apache.org/r/46715/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Question about PreCommit patch testing

2016-04-28 Thread Thejas Nair

there were some issues last week around precommit tests, you might
want to try attaching a new copy of the file

On Thu, Apr 28, 2016 at 8:14 AM, Svetozar Ivanov
 wrote:
> Hello all,
>
> I need some help as my patch HIVE-13584-branch-2.0.patch in issue
> https://issues.apache.org/jira/browse/HIVE-11233 is not picked up by
> PreCommit patch testing job. From my perspective everything described on
> page
> https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-PrecommitTestsbyHiveQA
> was already done. Would appreciate any ideas, thanks!
>
> Best regards,
> Svetozar Ivanov

[jira] [Created] (HIVE-13647) named_struct changes the column to lowercase

2016-04-28 Thread Sivashankar (JIRA)

Sivashankar created HIVE-13647:
--

 Summary: named_struct changes the column to lowercase
 Key: HIVE-13647
 URL: https://issues.apache.org/jira/browse/HIVE-13647
 Project: Hive
  Issue Type: Bug
Affects Versions: 0.14.0
Reporter: Sivashankar
Assignee: Sivashankar
Priority: Trivial






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HIVE-13646) make hive.optimize.sort.dynamic.partition compatible with ACID tables

2016-04-28 Thread Eugene Koifman (JIRA)

Eugene Koifman created HIVE-13646:
-

 Summary: make hive.optimize.sort.dynamic.partition compatible with 
ACID tables
 Key: HIVE-13646
 URL: https://issues.apache.org/jira/browse/HIVE-13646
 Project: Hive
  Issue Type: Bug
  Components: Transactions
Affects Versions: 1.0.0
Reporter: Eugene Koifman
Priority: Critical


HIVE-8875 disabled hive.optimize.sort.dynamic.partition for ACID queries.
dynamic inserts are common in ACID and this leaves users with few options if 
they are seeing OutOfMemory errors due to too many writers.

hive.optimize.sort.dynamic.partition sorts data by partition col/bucket 
col/sort col to ensure each reducer only needs 1 writer.

Acid requires data in each bucket file to be sorted by ROW__ID and thus doesn't 
allow end user to determine sorting.

So we should be able to support hive.optimize.sort.dynamic.partition with
sort on partition col/bucket col/ROW__ID 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 46755: JDBC: Support query timeout for jdbc

2016-04-28 Thread Thejas Nair


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46755/#review130981
---




service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java (line 
163)


this doesn't seem right. The shutdownNow is happening in a task, which the 
shutdown know will attempt to stop.
I am worried that this could result in wierd behavior/bugs.
How about calling shutdown instead ? That seems like a safe option



service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java (line 
225)


use isTerminal() here ?



service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java (line 
390)


it seems like a valid thing to call close after a cancel.
Can you make sure that the cleanups are idempotent ?


- Thejas Nair


On April 27, 2016, 11:14 p.m., Vaibhav Gumashta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46755/
> ---
> 
> (Updated April 27, 2016, 11:14 p.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-4924
> https://issues.apache.org/jira/browse/HIVE-4924
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/HIVE-4924
> 
> 
> Diffs
> -
> 
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 
> 965627f 
>   
> itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestHiveSessionImpl.java
>  4d763d2 
>   jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java 3cc6b74 
>   ql/src/java/org/apache/hadoop/hive/ql/Driver.java dad43fb 
>   ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistoryImpl.java 0234fd9 
>   service-rpc/if/TCLIService.thrift 92bcf77 
>   service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 9f937ca 
>   service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp 66f5e8c 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TExecuteStatementReq.java
>  2eb4d09 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TOperationState.java
>  3fa49b0 
>   service-rpc/src/gen/thrift/gen-php/Types.php 7f1f99f 
>   service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py 3bb20b8 
>   service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 7208bae 
>   service/src/java/org/apache/hive/service/cli/CLIService.java 4a83e38 
>   service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 
> 79e0024 
>   service/src/java/org/apache/hive/service/cli/ICLIService.java e4aef96 
>   service/src/java/org/apache/hive/service/cli/OperationState.java 6a67a1d 
>   
> service/src/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java
>  b3d9b52 
>   
> service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java
>  f18dc67 
>   
> service/src/java/org/apache/hive/service/cli/operation/MetadataOperation.java 
> 77228fa 
>   service/src/java/org/apache/hive/service/cli/operation/Operation.java 
> 63b1a48 
>   
> service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 
> 52e4b4d 
>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 
> 01dd48c 
>   service/src/java/org/apache/hive/service/cli/session/HiveSession.java 
> 9ea643b 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
> 0cfec7a 
>   
> service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java
>  b2e0e9e 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 
> 6ede1d7 
>   
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java
>  098aea6 
>   
> service/src/test/org/apache/hive/service/cli/thrift/ThriftCLIServiceTest.java 
> 1740079 
>   
> service/src/test/org/apache/hive/service/cli/thrift/ThriftCliServiceTestWithCookie.java
>  a1ef1fc 
> 
> Diff: https://reviews.apache.org/r/46755/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>

[jira] [Created] (HIVE-13645) Beeline needs null-guard around hiveVars and hiveConfVars read

2016-04-28 Thread Sushanth Sowmyan (JIRA)

Sushanth Sowmyan created HIVE-13645:
---

 Summary: Beeline needs null-guard around hiveVars and hiveConfVars 
read
 Key: HIVE-13645
 URL: https://issues.apache.org/jira/browse/HIVE-13645
 Project: Hive
  Issue Type: Bug
  Components: Beeline
Affects Versions: 2.1.0
Reporter: Sushanth Sowmyan
Assignee: Sushanth Sowmyan


Beeline has a bug wherein if a user does a !save ever, then on next load, if 
beeline.hiveVariables or beeline.hiveconfvariables are empty, i.e. \{\} or 
unspecified, then it loads it as null, and then, on next connect, there is no 
null-check on these variables leading to an NPE.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Question about PreCommit patch testing

2016-04-28 Thread Svetozar Ivanov


Hello all,

I need some help as my patch HIVE-13584-branch-2.0.patch in issue 
https://issues.apache.org/jira/browse/HIVE-11233 is not picked up by 
PreCommit patch testing job. From my perspective everything described on 
page 
https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-PrecommitTestsbyHiveQA 
was already done. Would appreciate any ideas, thanks!


Best regards,
Svetozar Ivanov

Re: Review Request 46755: JDBC: Support query timeout for jdbc

2016-04-28 Thread Thejas Nair


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46755/#review130966
---




itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java (line 
2408)


can you also add a test where query timeout is not met ?
ie set large value of query timeout and run a quick query ('show tables' 
?), and make sure it completes without errors



ql/src/java/org/apache/hadoop/hive/ql/Driver.java (line 1729)


s/of/if/



service-rpc/if/TCLIService.thrift (line 705)


I was debating with myself if we should use i32 to match with jdbc api spec.
However, looks like the ODBC spec uses 64bit here.
SQLSetStmtAttr in odbc sets SQL_ATTR_QUERY_TIMEOUT using SQLULEN, with is 
64 bit.



service/src/java/org/apache/hive/service/cli/OperationState.java (line 36)


isnt timed out state a terminal state ?



service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 
(line 255)


should we check for if(ipState.isTerminal() ) instead ?
I don't think UNKOWN needs to be in this list. We never set anything to 
UNKNOWN .


- Thejas Nair


On April 27, 2016, 11:14 p.m., Vaibhav Gumashta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46755/
> ---
> 
> (Updated April 27, 2016, 11:14 p.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-4924
> https://issues.apache.org/jira/browse/HIVE-4924
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/HIVE-4924
> 
> 
> Diffs
> -
> 
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 
> 965627f 
>   
> itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestHiveSessionImpl.java
>  4d763d2 
>   jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java 3cc6b74 
>   ql/src/java/org/apache/hadoop/hive/ql/Driver.java dad43fb 
>   ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistoryImpl.java 0234fd9 
>   service-rpc/if/TCLIService.thrift 92bcf77 
>   service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 9f937ca 
>   service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp 66f5e8c 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TExecuteStatementReq.java
>  2eb4d09 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TOperationState.java
>  3fa49b0 
>   service-rpc/src/gen/thrift/gen-php/Types.php 7f1f99f 
>   service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py 3bb20b8 
>   service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 7208bae 
>   service/src/java/org/apache/hive/service/cli/CLIService.java 4a83e38 
>   service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 
> 79e0024 
>   service/src/java/org/apache/hive/service/cli/ICLIService.java e4aef96 
>   service/src/java/org/apache/hive/service/cli/OperationState.java 6a67a1d 
>   
> service/src/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java
>  b3d9b52 
>   
> service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java
>  f18dc67 
>   
> service/src/java/org/apache/hive/service/cli/operation/MetadataOperation.java 
> 77228fa 
>   service/src/java/org/apache/hive/service/cli/operation/Operation.java 
> 63b1a48 
>   
> service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 
> 52e4b4d 
>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 
> 01dd48c 
>   service/src/java/org/apache/hive/service/cli/session/HiveSession.java 
> 9ea643b 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
> 0cfec7a 
>   
> service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java
>  b2e0e9e 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 
> 6ede1d7 
>   
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java
>  098aea6 
>   
> service/src/test/org/apache/hive/service/cli/thrift/ThriftCLIServiceTest.java 
> 1740079 
>   
> service/src/test/org/apache/hive/service/cli/thrift/ThriftCliServiceTestWithCookie.java
>  a1ef1fc 
> 
> Diff: https://reviews.apache.org/r/46755/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>

Re: Review Request 46755: JDBC: Support query timeout for jdbc

2016-04-28 Thread Thejas Nair


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46755/#review130963
---




itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java (line 
2416)


use System.err instead of System.out for 'logging' ? There might be other 
parts writing to err, so it would then appear in sequence.
(also in lines below)



itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java (line 
2428)


Change to print e in fail, so it shows prominently in error. Also print 
stack trace to stderr
ie - 
fail("Expecting SQLTimeoutException, but got SQLException" + e);
 e.printStackTrace();



jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java (line 795)


the api doesn't seem to say if this call on running queries should be 
allowed or not.
For now, how about allowing it in if the value is 0 ? just so that we don't 
break any applications.


- Thejas Nair


On April 27, 2016, 11:14 p.m., Vaibhav Gumashta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46755/
> ---
> 
> (Updated April 27, 2016, 11:14 p.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-4924
> https://issues.apache.org/jira/browse/HIVE-4924
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/HIVE-4924
> 
> 
> Diffs
> -
> 
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 
> 965627f 
>   
> itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestHiveSessionImpl.java
>  4d763d2 
>   jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java 3cc6b74 
>   ql/src/java/org/apache/hadoop/hive/ql/Driver.java dad43fb 
>   ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistoryImpl.java 0234fd9 
>   service-rpc/if/TCLIService.thrift 92bcf77 
>   service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 9f937ca 
>   service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp 66f5e8c 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TExecuteStatementReq.java
>  2eb4d09 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TOperationState.java
>  3fa49b0 
>   service-rpc/src/gen/thrift/gen-php/Types.php 7f1f99f 
>   service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py 3bb20b8 
>   service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 7208bae 
>   service/src/java/org/apache/hive/service/cli/CLIService.java 4a83e38 
>   service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 
> 79e0024 
>   service/src/java/org/apache/hive/service/cli/ICLIService.java e4aef96 
>   service/src/java/org/apache/hive/service/cli/OperationState.java 6a67a1d 
>   
> service/src/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java
>  b3d9b52 
>   
> service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java
>  f18dc67 
>   
> service/src/java/org/apache/hive/service/cli/operation/MetadataOperation.java 
> 77228fa 
>   service/src/java/org/apache/hive/service/cli/operation/Operation.java 
> 63b1a48 
>   
> service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 
> 52e4b4d 
>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 
> 01dd48c 
>   service/src/java/org/apache/hive/service/cli/session/HiveSession.java 
> 9ea643b 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
> 0cfec7a 
>   
> service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java
>  b2e0e9e 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 
> 6ede1d7 
>   
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java
>  098aea6 
>   
> service/src/test/org/apache/hive/service/cli/thrift/ThriftCLIServiceTest.java 
> 1740079 
>   
> service/src/test/org/apache/hive/service/cli/thrift/ThriftCliServiceTestWithCookie.java
>  a1ef1fc 
> 
> Diff: https://reviews.apache.org/r/46755/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>

new HiveQA jenkins queue doesn't have JIRA numbers

2016-04-28 Thread Sergey Shelukhin

Subj. Is it a limitation of the new Jenkins instance, or can it be enabled
again? The JIRA number associated with the run used to be shown for the
pending items in the left column.

Review Request 46790: HIVE-13644: Remove hardcoded groovy.grape.report.downloads=true from DependencyResolver

2016-04-28 Thread Anthony Hsu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46790/
---

Review request for hive, Carl Steinbach, Mark Wagner, and Ratandeep Ratti.


Bugs: HIVE-13644
https://issues.apache.org/jira/browse/HIVE-13644


Repository: hive-git


Description
---

HIVE-13644: Remove hardcoded groovy.grape.report.downloads=true from 
DependencyResolver


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/util/DependencyResolver.java 
3891e59a274e6449c5f50eea51e4f23762efcbc0 

Diff: https://reviews.apache.org/r/46790/diff/


Testing
---

Tested manually.


Thanks,

Anthony Hsu

[jira] [Created] (HIVE-13644) Remove hardcoded groovy.grape.report.downloads=true from DependencyResolver

2016-04-28 Thread Anthony Hsu (JIRA)

Anthony Hsu created HIVE-13644:
--

 Summary: Remove hardcoded groovy.grape.report.downloads=true from 
DependencyResolver
 Key: HIVE-13644
 URL: https://issues.apache.org/jira/browse/HIVE-13644
 Project: Hive
  Issue Type: Improvement
Reporter: Anthony Hsu
Assignee: Anthony Hsu


Currently, in Hive's 
[DependencyResolver.java|https://github.com/apache/hive/blob/8dd1d1966f2f0b86604b4e991ebc865224f42b41/ql/src/java/org/apache/hadoop/hive/ql/util/DependencyResolver.java#L176],
 the system property {{groovy.grape.report.downloads}} is hardcoded to {{true}} 
and there is no way to override it and disable the logging. We should remove 
this hardcoded value and allow users to configure it as they see fit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HIVE-13643) Various enhancements to llap cli tools

2016-04-28 Thread Siddharth Seth (JIRA)

Siddharth Seth created HIVE-13643:
-

 Summary: Various enhancements to llap cli tools
 Key: HIVE-13643
 URL: https://issues.apache.org/jira/browse/HIVE-13643
 Project: Hive
  Issue Type: Improvement
Reporter: Siddharth Seth
Assignee: Siddharth Seth


- BUG - llapstatus does not always produce output (PrintWriter.close)
- llapstatus should parse hiveconf
- package llap-cli-log4j2.template
- Log at the start and end of the script to include parameters
- Generate logs to a file different from hive.log
- hive --service llap --name does not propagate the name to the daemons



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HIVE-13642) Update GUESS_FIELDS option in .reviewboardrc to support current version of RBTools.

2016-04-28 Thread Takuma Wakamori (JIRA)

Takuma Wakamori created HIVE-13642:
--

 Summary: Update GUESS_FIELDS option in .reviewboardrc to support 
current version of RBTools.
 Key: HIVE-13642
 URL: https://issues.apache.org/jira/browse/HIVE-13642
 Project: Hive
  Issue Type: Bug
Reporter: Takuma Wakamori
Assignee: Takuma Wakamori
Priority: Trivial


According to the instruction of using [Review 
Board|https://cwiki.apache.org/confluence/display/Hive/Review+Board], we can 
create a review request by running the following command:
{code}
$ rbt post
{code}
However, if we use current version of RBTools (0.7.6), above command doesn't 
work because the values accepted to the option "--guess-fields" was updated 
since 0.6.
{code}
$ rbt --version
RBTools 0.7.6
$ rbt post
ERROR: Invalid value "true" for argument "--guess-fields"
{code}
It is better to update the value of GUESS_FIELDS option in .reviewboardrc to 
avoid this error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 46766: HiveServer2: Suppress showing stack trace when throwing NoViableAltException.

2016-04-28 Thread Takuma Wakamori


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46766/
---

(Updated 4月 28, 2016, 7:41 p.m.)


Review request for hive.


Bugs: HIVE-13635
https://issues.apache.org/jira/browse/HIVE-13635


Repository: hive-git


Description
---

HiveServer2: Suppress showing stack trace when throwing NoViableAltException.


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/parse/ParseDriver.java 
4ab5c4750eb723ca6a908c25cd78b70c1c47bf54 

Diff: https://reviews.apache.org/r/46766/diff/


Testing
---


Thanks,

Takuma Wakamori

Review Request 46766: HiveServer2: Suppress showing stack trace when throwing NoViableAltException.

2016-04-28 Thread Takuma Wakamori


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46766/
---

Review request for hive.


Repository: hive-git


Description
---

HiveServer2: Suppress showing stack trace when throwing NoViableAltException.


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/parse/ParseDriver.java 
4ab5c4750eb723ca6a908c25cd78b70c1c47bf54 

Diff: https://reviews.apache.org/r/46766/diff/


Testing
---


Thanks,

Takuma Wakamori

[jira] [Created] (HIVE-13641) LLAP fails to start if llap.io.enabled is set to true, and cache size is set to 0

2016-04-28 Thread Siddharth Seth (JIRA)

Siddharth Seth created HIVE-13641:
-

 Summary: LLAP fails to start if llap.io.enabled is set to true, 
and cache size is set to 0
 Key: HIVE-13641
 URL: https://issues.apache.org/jira/browse/HIVE-13641
 Project: Hive
  Issue Type: Bug
Reporter: Siddharth Seth
Assignee: Sergey Shelukhin


With this configuration - I'd expect the cache to be automatically disabled / 
or just the elevator used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 45733: HIVE-13421: Propagate job progress in operation status

2016-04-28 Thread Rajat Khandelwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45733/
---

(Updated April 28, 2016, 3:06 p.m.)


Review request for hive, Amareshwari Sriramadasu and Szehon Ho.


Bugs: HIVE-13421
https://issues.apache.org/jira/browse/HIVE-13421


Repository: hive-git


Description
---


Diffs (updated)
-

  
itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestQueryDisplay.java
 98581e0e09c20b30eafd6aae99068fddf1596d8e 
  ql/src/java/org/apache/hadoop/hive/ql/Driver.java 
dad43fbbab0359711320a5c4656d67fda6fb73f4 
  ql/src/java/org/apache/hadoop/hive/ql/QueryDisplay.java 
d582bc063fc150002a01d63451ae6632fca29ac1 
  ql/src/java/org/apache/hadoop/hive/ql/QueryPlan.java 
ef0923d555ba662b4ed30ef45a3d72760cdfad52 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ConditionalTask.java 
c96c8135a344049e57167559c4d760b876a42ca5 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java 
897af5e8c3e876f7b4f6a7aa5d462f8115a4e238 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 
639b0da6c8da2a0eec018ce57c12e21637f1c0de 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHelper.java 
760ba6c8f5afb2d3e8c533ffce8be5f73d13a9e2 
  service/src/test/org/apache/hive/service/cli/CLIServiceTest.java 
ff7e9a4e1c1ec61454fed173aaab0c344d1241d4 

Diff: https://reviews.apache.org/r/45733/diff/


Testing
---


Thanks,

Rajat Khandelwal

[jira] [Created] (HIVE-13640) Disable Hive PartitionConditionRemover optimizer when CBO has optimized the plan

2016-04-28 Thread Jesus Camacho Rodriguez (JIRA)

Jesus Camacho Rodriguez created HIVE-13640:
--

 Summary: Disable Hive PartitionConditionRemover optimizer when CBO 
has optimized the plan
 Key: HIVE-13640
 URL: https://issues.apache.org/jira/browse/HIVE-13640
 Project: Hive
  Issue Type: Sub-task
  Components: CBO
Affects Versions: 2.1.0
Reporter: Jesus Camacho Rodriguez
Assignee: Jesus Camacho Rodriguez


We should bring PartitionConditionRemover to CBO and disable it in Hive. This 
should allow us to fold expressions in CBO more tight.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HIVE-13639) CBO rule to pull up constants through Union

2016-04-28 Thread Jesus Camacho Rodriguez (JIRA)

Jesus Camacho Rodriguez created HIVE-13639:
--

 Summary: CBO rule to pull up constants through Union
 Key: HIVE-13639
 URL: https://issues.apache.org/jira/browse/HIVE-13639
 Project: Hive
  Issue Type: Sub-task
  Components: CBO
Affects Versions: 2.1.0
Reporter: Jesus Camacho Rodriguez
Assignee: Jesus Camacho Rodriguez


After HIVE-13068 goes in, we need to pull up constants through Union operator, 
as it was done previously by ConstantPropagate in Hive.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HIVE-13638) CBO rule to pull up constants through Limit

2016-04-28 Thread Jesus Camacho Rodriguez (JIRA)

Jesus Camacho Rodriguez created HIVE-13638:
--

 Summary: CBO rule to pull up constants through Limit
 Key: HIVE-13638
 URL: https://issues.apache.org/jira/browse/HIVE-13638
 Project: Hive
  Issue Type: Sub-task
  Components: CBO
Affects Versions: 2.1.0
Reporter: Jesus Camacho Rodriguez
Assignee: Jesus Camacho Rodriguez


After HIVE-13068 goes in, we need to pull up constants through Limit operator, 
as it was done previously by ConstantPropagate in Hive.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HIVE-13637) Fold CASE into NVL when CBO optimized the plan

2016-04-28 Thread Jesus Camacho Rodriguez (JIRA)

Jesus Camacho Rodriguez created HIVE-13637:
--

 Summary: Fold CASE into NVL when CBO optimized the plan
 Key: HIVE-13637
 URL: https://issues.apache.org/jira/browse/HIVE-13637
 Project: Hive
  Issue Type: Sub-task
  Components: CBO
Affects Versions: 2.1.0
Reporter: Jesus Camacho Rodriguez
Assignee: Jesus Camacho Rodriguez


After HIVE-13068 goes in, folding CASE into NVL got disabled when CBO has 
optimized the plan, as it was done by ConstantPropagate in Hive. We need to 
enable it back.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 46690: HIVE-13068

2016-04-28 Thread Jesús Camacho Rodríguez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46690/
---

(Updated April 28, 2016, 9:06 a.m.)


Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-13068
https://issues.apache.org/jira/browse/HIVE-13068


Repository: hive-git


Description
---

HIVE-13068


Diffs (updated)
-

  hbase-handler/src/test/results/positive/hbase_ppd_key_range.q.out 
27446b41db80ee98d56a4101a87f76be7f6dea2f 
  hbase-handler/src/test/results/positive/hbase_pushdown.q.out 
a42e36f0132457d22240d3ef4b8a52375a14fe34 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/NonBlockingOpDeDupProc.java 
37dbe32008685ba22e5dae1e4bfbfe090c5bfe9f 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 
55c71ddd2ab16f2a1c50a704556a1ee9092d0941 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedDynPartitionOptimizer.java
 adfbb6705d4cc861167536768e6c74190a8b7ccb 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java 
0cfd5298899ea8dd16c073b26546c40de4451271 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRexUtil.java 
2f309f3de6acfac09b7b0d84cbb9d4275e317aeb 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAggregatePullUpConstantsRule.java
 PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveProjectFilterPullUpConstantsRule.java
 PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsRule.java
 9006f45784359ff22075bac61f4d92a51309301c 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/JoinTypeCheckCtx.java
 dccd1d95aec281e3b7e4c38ab569b50d1e0850ab 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java
 ee4f4ead6066a29e867cf51582c45d3dc69b1880 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java
 0b76bffb42d88204f486278a12bbf24d1b7fc274 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/TypeConverter.java
 2825f7787de4d42e9532bfb2642f4f95ba8f8b83 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
8e00e0b140d7d40f25299e10be26c6eaf0231745 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
cfe4497684caaa5fb317e87c779733fda8f435e2 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckCtx.java 
de1c043cb4914bf39d9086569e6e3cd802ee79dc 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 
da236d5b6889621097e3403ec7e8783b2704dbc6 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java 
c6f89074457e1ed4e61d52c01d9cc515fe1a6f09 
  ql/src/test/queries/clientpositive/join_view.q 
16b6816f0c8618691ba7a28f4ca467d7526d6e13 
  ql/src/test/results/clientpositive/annotate_stats_filter.q.out 
ba0419e461a5b5649bd7d4c67602b8cb747961ea 
  ql/src/test/results/clientpositive/archive_excludeHadoop20.q.out 
c2b98727d21f4990ae7496a0a8fa9ac16598f4c0 
  ql/src/test/results/clientpositive/archive_multi.q.out 
0ad29d122153bd4adf4d19064188b0c4f94e05ab 
  ql/src/test/results/clientpositive/auto_join8.q.out 
324f95d550add0ead3215bbdd0933ddd6456f9c9 
  ql/src/test/results/clientpositive/bucket_groupby.q.out 
d1414fefd01312510e96391c1180d2ae5e2046a3 
  ql/src/test/results/clientpositive/cbo_rp_join1.q.out 
f3982b8866d44dd0b4c01bf1f75e44c861f85756 
  ql/src/test/results/clientpositive/constantPropWhen.q.out 
650cbc77fc5a0145a5cc7b5ec69ec05a7bd6743d 
  ql/src/test/results/clientpositive/constprog_semijoin.q.out 
35d062d7a534c9cf9705fda44eaf81fa97e92229 
  ql/src/test/results/clientpositive/cp_sel.q.out 
f42ec84dc6f147278da93c33375500a48bb0e008 
  ql/src/test/results/clientpositive/cte_5.q.out 
96a65438f0fe0f5189e0a257c4fd71290bdb0804 
  ql/src/test/results/clientpositive/cte_mat_1.q.out 
b7d5f7d1f6cde1990c56803fc8e7c566dacd1ba8 
  ql/src/test/results/clientpositive/cte_mat_2.q.out 
b7d5f7d1f6cde1990c56803fc8e7c566dacd1ba8 
  ql/src/test/results/clientpositive/dynamic_rdd_cache.q.out 
9a09c4c205f18a1033742bc61c7d624dcf81c0b8 
  ql/src/test/results/clientpositive/dynpart_sort_optimization.q.out 
13383fb41cd3f086f722915dbc5550b25b40f9a0 
  ql/src/test/results/clientpositive/dynpart_sort_optimization2.q.out 
3b24a2e3fb85b1bb2ccfb1456ce00c4e3962eec7 
  ql/src/test/results/clientpositive/filter_cond_pushdown.q.out 
132b590230d2fba13d77a004b5bb5041999fc497 
  ql/src/test/results/clientpositive/fold_case.q.out 
53139da206481bb04db865819c30ec3775452449 
  ql/src/test/results/clientpositive/fold_eq_with_case_when.q.out 
106ad6b836b6c2dbf43e236c488621ef21bae47b 
  ql/src/test/results/clientpositive/fold_when.q.out 
5b684089c0bdfd9be3e05241ac5af22c1f16eca3 
  ql/src/test/results/clientpositive/folder_predicate.q.out 
7fcc1722d87a9e2734b3467fe1a5f320af0a422c 
  ql/src/test/results/clientpositive/groupby_ppd.q.out 
c63acd32a62540a96d22a0d29ac69212e4cb0dee

[jira] [Created] (HIVE-13636) Exception using Postgres as metastore with ACID transanctions enabled

2016-04-28 Thread Marco Gaido (JIRA)

Marco Gaido created HIVE-13636:
--

 Summary: Exception using Postgres as metastore with ACID 
transanctions enabled
 Key: HIVE-13636
 URL: https://issues.apache.org/jira/browse/HIVE-13636
 Project: Hive
  Issue Type: Bug
  Components: Metastore, Transactions
Affects Versions: 1.2.1
 Environment: HDP 2.3.2
Reporter: Marco Gaido


We are using Postgres as metastore and we enabled ACID transactions. Once we 
have done this, we started facing this error:

FATAL [DeadTxnReaper-0]: txn.AcidHouseKeeperService 
(AcidHouseKeeperService.java:run(92)) - Serious error in DeadTxnReaper-0: 
Method org/postgresql/jdbc3/Jdbc3ResultSet.isClosed()Z is abstract

java.lang.AbstractMethodError: Method 
org/postgresql/jdbc3/Jdbc3ResultSet.isClosed()Z is abstract

at org.postgresql.jdbc3.Jdbc3ResultSet.isClosed(Jdbc3ResultSet.java)

at 
org.apache.hadoop.hive.metastore.txn.TxnHandler.close(TxnHandler.java:934)

at 
org.apache.hadoop.hive.metastore.txn.TxnHandler.close(TxnHandler.java:947)

at 
org.apache.hadoop.hive.metastore.txn.TxnHandler.performTimeOuts(TxnHandler.java:1933)

at 
org.apache.hadoop.hive.ql.txn.AcidHouseKeeperService$TimedoutTxnReaper.run(AcidHouseKeeperService.java:87)

at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)

at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)

at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)

at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)

at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)

at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)

at java.lang.Thread.run(Thread.java:745)

Looking at the code of the class TxnHandler, in the method close is actually 
used the isClosed() method on the ResultSet class, which is not implemented in 
Jdbc3ResultSet Postgres driver's class.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HIVE-13635) HiveServer2 shows stack trace when parsing invalid inputs

2016-04-28 Thread Takuma Wakamori (JIRA)

Takuma Wakamori created HIVE-13635:
--

 Summary: HiveServer2 shows stack trace when parsing invalid inputs
 Key: HIVE-13635
 URL: https://issues.apache.org/jira/browse/HIVE-13635
 Project: Hive
  Issue Type: Bug
  Components: HiveServer2
Reporter: Takuma Wakamori
Assignee: Takuma Wakamori
Priority: Trivial


HiveServer2 shows stack trace when parsing invalid syntax.

How to reproduce:
{code}
Input:
hostA$ hiveserver2
hostB$ beeline -u jdbc:hive2://localhost:1 -n user -p pass -e "invalid 
syntax;"

Output:
hostA$ NoViableAltException(26@[])  
  
[0/1248]
at 
org.apache.hadoop.hive.ql.parse.HiveParser.statement(HiveParser.java:1108)
at 
org.apache.hadoop.hive.ql.parse.ParseDriver.parse(ParseDriver.java:204)
at 
org.apache.hadoop.hive.ql.parse.ParseDriver.parse(ParseDriver.java:166)
at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:444)
at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:319)
at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1199)
at org.apache.hadoop.hive.ql.Driver.compileAndRespond(Driver.java:1186)
at 
org.apache.hive.service.cli.operation.SQLOperation.prepare(SQLOperation.java:146)
at 
org.apache.hive.service.cli.operation.SQLOperation.runInternal(SQLOperation.java:218)
...
FAILED: ParseException line 1:0 cannot recognize input near 'invalid' 'syntax' 
''

hostB$ Error: Error while compiling statement: FAILED: ParseException line 1:0 
cannot recognize input near 'invalid' 'syntax' '' (state=42000,code=4)
{code}

This issue is related to the post of Hive developer mailing list:
http://mail-archives.apache.org/mod_mbox/hive-dev/201604.mbox/%3CCAOLfT9AaKZ8Nt77QnvrNcxWrQ_1htaj9C0UOsnN5HheoTzM6DQ%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 46755: JDBC: Support query timeout for jdbc

[jira] [Created] (HIVE-13651) LlapBaseInputFormat: figure out where credentials come from

[jira] [Created] (HIVE-13650) LLAP: Other todo items in LlapTaskUmbilicalExternalClient

[jira] [Created] (HIVE-13649) LLAP: Work out the details of LlapTaskUmbilicalExternalClient tokenIdentifier

Review Request 46809: HIVE-13442 LLAP: refactor submit API to be amenable to signing

[jira] [Created] (HIVE-13648) Look at ORC data type conversion edge cases (CHAR, VARCHAR, DECIMAL)

Re: Review Request 46715: HIVE-13596 HS2 should be able to get UDFs on demand from metastore

Re: Question about PreCommit patch testing

[jira] [Created] (HIVE-13647) named_struct changes the column to lowercase

[jira] [Created] (HIVE-13646) make hive.optimize.sort.dynamic.partition compatible with ACID tables

Re: Review Request 46755: JDBC: Support query timeout for jdbc

[jira] [Created] (HIVE-13645) Beeline needs null-guard around hiveVars and hiveConfVars read

Question about PreCommit patch testing

Re: Review Request 46755: JDBC: Support query timeout for jdbc

Re: Review Request 46755: JDBC: Support query timeout for jdbc

new HiveQA jenkins queue doesn't have JIRA numbers

Review Request 46790: HIVE-13644: Remove hardcoded groovy.grape.report.downloads=true from DependencyResolver

[jira] [Created] (HIVE-13644) Remove hardcoded groovy.grape.report.downloads=true from DependencyResolver

[jira] [Created] (HIVE-13643) Various enhancements to llap cli tools

[jira] [Created] (HIVE-13642) Update GUESS_FIELDS option in .reviewboardrc to support current version of RBTools.

Re: Review Request 46766: HiveServer2: Suppress showing stack trace when throwing NoViableAltException.

Review Request 46766: HiveServer2: Suppress showing stack trace when throwing NoViableAltException.

[jira] [Created] (HIVE-13641) LLAP fails to start if llap.io.enabled is set to true, and cache size is set to 0

Re: Review Request 45733: HIVE-13421: Propagate job progress in operation status

[jira] [Created] (HIVE-13640) Disable Hive PartitionConditionRemover optimizer when CBO has optimized the plan

[jira] [Created] (HIVE-13639) CBO rule to pull up constants through Union

[jira] [Created] (HIVE-13638) CBO rule to pull up constants through Limit

[jira] [Created] (HIVE-13637) Fold CASE into NVL when CBO optimized the plan

Re: Review Request 46690: HIVE-13068

[jira] [Created] (HIVE-13636) Exception using Postgres as metastore with ACID transanctions enabled

[jira] [Created] (HIVE-13635) HiveServer2 shows stack trace when parsing invalid inputs

31 matches

Site Navigation

Mail list logo

Footer information