Review Request 50650: Data size may be estimated as 0 if no columns are being projected after an operator

2016-07-31 Thread Ashutosh Chauhan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50650/
---

Review request for hive and Jesús Camacho Rodríguez.


Bugs: HIVE-14378
https://issues.apache.org/jira/browse/HIVE-14378


Repository: hive-git


Description
---

Data size may be estimated as 0 if no columns are being projected after an 
operator


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java 7a15904 
  ql/src/test/results/clientpositive/annotate_stats_part.q.out 50fc633 
  ql/src/test/results/clientpositive/cbo_rp_auto_join1.q.out 934eb5d 
  ql/src/test/results/clientpositive/columnStatsUpdateForStatsOptimizer_1.q.out 
00f3776 
  ql/src/test/results/clientpositive/constant_prop_1.q.out 96f6606 
  ql/src/test/results/clientpositive/input30.q.out c4848a1 
  ql/src/test/results/clientpositive/lateral_view.q.out d21e285 
  ql/src/test/results/clientpositive/lateral_view_explode2.q.out ef6e4c7 
  ql/src/test/results/clientpositive/lateral_view_noalias.q.out 3532737 
  ql/src/test/results/clientpositive/lateral_view_onview.q.out a5e2dcd 
  ql/src/test/results/clientpositive/list_bucket_dml_13.q.out 93ebef0 
  ql/src/test/results/clientpositive/load_dyn_part14.q.out 57c4287 
  ql/src/test/results/clientpositive/optimize_nullscan.q.out fb63a71 
  ql/src/test/results/clientpositive/spark/lateral_view_explode2.q.out 407d851 
  ql/src/test/results/clientpositive/spark/load_dyn_part14.q.out 1940561 
  ql/src/test/results/clientpositive/spark/optimize_nullscan.q.out 67730a3 
  ql/src/test/results/clientpositive/spark/stats_only_null.q.out ec65619 
  ql/src/test/results/clientpositive/spark/union16.q.out 8e5ac4d 
  ql/src/test/results/clientpositive/spark/union2.q.out 7b0cbe7 
  ql/src/test/results/clientpositive/spark/union3.q.out e518c4e 
  ql/src/test/results/clientpositive/spark/union9.q.out 1ccee40 
  ql/src/test/results/clientpositive/stats_only_null.q.out b47fe64 
  ql/src/test/results/clientpositive/stats_partial_size.q.out ee9040d 
  ql/src/test/results/clientpositive/tez/explainuser_1.q.out b8383fd 
  ql/src/test/results/clientpositive/tez/optimize_nullscan.q.out e382802 
  ql/src/test/results/clientpositive/tez/stats_only_null.q.out 8c17509 
  ql/src/test/results/clientpositive/tez/union2.q.out 05b5ece 
  ql/src/test/results/clientpositive/tez/union3.q.out 9d324ff 
  ql/src/test/results/clientpositive/tez/union9.q.out c9eae39 
  ql/src/test/results/clientpositive/tez/unionDistinct_1.q.out ee33086 
  ql/src/test/results/clientpositive/udtf_explode.q.out 4f8bd5e 
  ql/src/test/results/clientpositive/udtf_stack.q.out 95433a3 
  ql/src/test/results/clientpositive/union16.q.out 1d7897b 
  ql/src/test/results/clientpositive/union2.q.out 6499676 
  ql/src/test/results/clientpositive/union3.q.out 0130677 
  ql/src/test/results/clientpositive/union9.q.out 73b2e32 
  ql/src/test/results/clientpositive/unionDistinct_1.q.out 0330133 

Diff: https://reviews.apache.org/r/50650/diff/


Testing
---


Thanks,

Ashutosh Chauhan



[jira] [Created] (HIVE-14396) CBO: Calcite Operator To Hive Operator (Calcite Return Path): TestCliDriver count.q failure

2016-07-31 Thread Vineet Garg (JIRA)
Vineet Garg created HIVE-14396:
--

 Summary: CBO: Calcite Operator To Hive Operator (Calcite Return 
Path): TestCliDriver count.q failure
 Key: HIVE-14396
 URL: https://issues.apache.org/jira/browse/HIVE-14396
 Project: Hive
  Issue Type: Sub-task
  Components: CBO
Reporter: Vineet Garg
Assignee: Vineet Garg


Currently there are three different failures

Set hive.cbo.returnpath.hiveop=true for all cases.

1) First case is wrong result for following query

{code:title=failure 1 Wrong result}
explain select count(1), count(*), count(a), count(b), count(c), count(d), 
count(distinct a), count(distinct b), count(distinct c), count(distinct d), 
count(distinct a,b), count(distinct b,c), count(distinct c,d), count(distinct 
a,d), count(distinct a,c), count(distinct b,d), count(distinct a,b,c), 
count(distinct b,c,d), count(distinct a,c,d), count(distinct a,b,d), 
count(distinct a,b,c,d) from abcd;
{code}

This occurs due to a bug in HiveCalciteUtil.getExprNodes. While looking for 
corresponding expression for a aggregate function's argument wrong index is 
being used.

2) Out of bound exception for following
{code}
set hive.map.aggr=false
explain select count(1), count(*), count(a), count(b), count(c), count(d), 
count(distinct a), count(distinct b), count(distinct c), count(distinct d), 
count(distinct a,b), count(distinct b,c), count(distinct c,d), count(distinct 
a,d), count(distinct a,c), count(distinct b,d), count(distinct a,b,c), 
count(distinct b,c,d), count(distinct a,c,d), count(distinct a,b,d), 
count(distinct a,b,c,d) from abcd;
{code}

The above happens while converting Calcite Aggregation to Hive's group by 
operator.

3) Once the above case with exception is fixed same query with 
hive.map.aggr=false give wrong results. Problem in this case is that while 
creating expression for aggregate function's argument we end up with wrong 
column info from underlying reduce sink operator. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HIVE-14395) Add the missing data files to Avro union tests (HIVE-14205 addendum)

2016-07-31 Thread Chaoyu Tang (JIRA)
Chaoyu Tang created HIVE-14395:
--

 Summary: Add the missing data files to Avro union tests 
(HIVE-14205 addendum)
 Key: HIVE-14395
 URL: https://issues.apache.org/jira/browse/HIVE-14395
 Project: Hive
  Issue Type: Bug
  Components: Test
Reporter: Chaoyu Tang
Assignee: Chaoyu Tang
Priority: Trivial


The union_non_nullable.txt & union_nullable.txt were not checked in for 
HIVE-14205. It was my mistake.
It is the reason that testCliDriver_avro_nullable_union & 
testNegativeCliDriver_avro_non_nullable_union are failing in current pre-commit 
build.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HIVE-14394) Reduce excessive INFO level logging

2016-07-31 Thread Sushanth Sowmyan (JIRA)
Sushanth Sowmyan created HIVE-14394:
---

 Summary: Reduce excessive INFO level logging
 Key: HIVE-14394
 URL: https://issues.apache.org/jira/browse/HIVE-14394
 Project: Hive
  Issue Type: Bug
Reporter: Sushanth Sowmyan
Assignee: Sushanth Sowmyan


We need to cull down on the number of logs we generate in HMS and HS2 that are 
not needed.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Permission to edit wiki

2016-07-31 Thread Lefty Leverenz
Done.  Welcome to the Hive wiki team, Peter!

-- Lefty

On Sat, Jul 30, 2016 at 4:26 AM, Peter Vary  wrote:

> Sorry, I forgot the username. It is pvary.
>
> Thanks,
> Peter
>
> 2016. júl. 30. 13:25 ezt írta ("Peter Vary" ):
>
> > Hi,
> >
> > I would like to be granted permissions to edit the wiki page so that I
> can
> > document the configuration changes there.
> >
> > Thanks in advance,
> > Peter
> >
>