[jira] [Created] (HIVE-16197) Incremental insert into a partitioned table doesn't get replicated.

2017-03-13 Thread Sankar Hariappan (JIRA)
Sankar Hariappan created HIVE-16197:
---

 Summary: Incremental insert into a partitioned table doesn't get 
replicated.
 Key: HIVE-16197
 URL: https://issues.apache.org/jira/browse/HIVE-16197
 Project: Hive
  Issue Type: Sub-task
  Components: repl
Reporter: Sankar Hariappan
Assignee: Sankar Hariappan


Insert to a partitioned table doesn't replicate properly in case of incremental 
dump/load. Few key points to be noted.
1. If insert command itself created the new partition, then the inserted row is 
replicated. But the subsequent inserts into the same table doesn't get 
replicated.
2. If the partition is created using ALTER TABLE command, then none of the 
inserted rows to this partition is getting replicated. However, the partition 
metadata is getting replicated.




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Re: Review Request 57518: HIVE-16091 Support subqueries in select

2017-03-13 Thread Vineet Garg

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57518/
---

(Updated March 14, 2017, 5:05 a.m.)


Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-16091
https://issues.apache.org/jira/browse/HIVE-16091


Repository: hive-git


Description
---

Support for subqueries in select statement (with limitations)
Wiki: https://cwiki.apache.org/confluence/display/Hive/Subqueries+in+SELECT


Diffs (updated)
-

  itests/src/test/resources/testconfiguration.properties 2a7627a 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveFilter.java
 b7b16b8 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSubQueryRemoveRule.java
 c1768f4 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java bf0a11b 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryUtils.java f0165dd 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java 6c10704 
  ql/src/test/queries/clientnegative/subquery_in_select.q 1365389 
  ql/src/test/queries/clientnegative/subquery_select_aggregate.q PRE-CREATION 
  ql/src/test/queries/clientnegative/subquery_select_complex_expr.q 
PRE-CREATION 
  ql/src/test/queries/clientnegative/subquery_select_distinct.q PRE-CREATION 
  ql/src/test/queries/clientnegative/subquery_select_distinct2.q PRE-CREATION 
  ql/src/test/queries/clientnegative/subquery_select_udf.q PRE-CREATION 
  ql/src/test/queries/clientpositive/subquery_select.q PRE-CREATION 
  ql/src/test/results/clientnegative/subquery_in_select.q.out 5c69690 
  ql/src/test/results/clientnegative/subquery_select_aggregate.q.out 
PRE-CREATION 
  ql/src/test/results/clientnegative/subquery_select_distinct.q.out 
PRE-CREATION 
  ql/src/test/results/clientnegative/subquery_select_distinct2.q.out 
PRE-CREATION 
  ql/src/test/results/clientnegative/subquery_select_udf.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/llap/subquery_select.q.out PRE-CREATION 


Diff: https://reviews.apache.org/r/57518/diff/3/

Changes: https://reviews.apache.org/r/57518/diff/2-3/


Testing
---

Added new tests
Done pre-commit testing
Pending: More tests


Thanks,

Vineet Garg



[jira] [Created] (HIVE-16196) UDFJson having thread-safety issues

2017-03-13 Thread Xuefu Zhang (JIRA)
Xuefu Zhang created HIVE-16196:
--

 Summary: UDFJson having thread-safety issues
 Key: HIVE-16196
 URL: https://issues.apache.org/jira/browse/HIVE-16196
 Project: Hive
  Issue Type: Bug
  Components: UDF
Affects Versions: 1.1.0
Reporter: Xuefu Zhang
Assignee: Xuefu Zhang


Followup for HIVE-16183, there seems to be some concurrency issues in 
UDFJson.java, especially around static class variables.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Review Request 57586: HIVE-16183: Fix potential thread safety issues with static variables

2017-03-13 Thread Xuefu Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57586/
---

Review request for hive and Chao Sun.


Bugs: HIVE-16183
https://issues.apache.org/jira/browse/HIVE-16183


Repository: hive-git


Description
---

Please see JIRA description


Diffs
-

  beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 7e6846d 
  beeline/src/java/org/apache/hive/beeline/HiveSchemaHelper.java 181f0d2 
  cli/src/java/org/apache/hadoop/hive/cli/RCFileCat.java f1806a0 
  cli/src/test/org/apache/hadoop/hive/cli/TestRCFileCat.java 11ceb31 
  common/src/java/org/apache/hadoop/hive/common/LogUtils.java c2a0d9a 
  common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java 926b4a6 
  metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java 
9c30ee7 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ArchiveUtils.java 6381a21 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 4ac25c2 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 6693134 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 
5b0c2bf 
  
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CuckooSetBytes.java
 6383e8a 
  
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTable.java
 9030e5f 
  ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistoryImpl.java 6582cdd 
  ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndex.java a1408e9 
  ql/src/java/org/apache/hadoop/hive/ql/io/HiveFileFormatUtils.java 7727114 
  ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 4995bdf 
  ql/src/java/org/apache/hadoop/hive/ql/io/RCFile.java d391164 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 369584b 
  ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/stats/PartialScanTask.java 
90b1dff 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/VirtualColumn.java 044d64c 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 0e67ea6 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/listbucketingpruner/ListBucketingPrunerUtils.java
 4d3e74e 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/GenMRSkewJoinProcessor.java
 93202c3 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 
50eda15 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/VectorizerReason.java 
e0a6198 
  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 36009bf 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java f175663 
  ql/src/java/org/apache/hadoop/hive/ql/parse/WindowingSpec.java 01b5559 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AbstractVectorDesc.java e85a418 
  ql/src/java/org/apache/hadoop/hive/ql/plan/GroupByDesc.java 0b49294 
  ql/src/java/org/apache/hadoop/hive/ql/plan/MapJoinDesc.java ca69697 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ReduceSinkDesc.java 9ae30ab 
  ql/src/java/org/apache/hadoop/hive/ql/plan/VectorAppMasterEventDesc.java 
2e11321 
  ql/src/java/org/apache/hadoop/hive/ql/plan/VectorFileSinkDesc.java 325ac91 
  ql/src/java/org/apache/hadoop/hive/ql/plan/VectorFilterDesc.java 6feed84 
  ql/src/java/org/apache/hadoop/hive/ql/plan/VectorGroupByDesc.java f8554e2 
  ql/src/java/org/apache/hadoop/hive/ql/plan/VectorLimitDesc.java c9bc45a 
  ql/src/java/org/apache/hadoop/hive/ql/plan/VectorMapJoinDesc.java 3aa65d3 
  ql/src/java/org/apache/hadoop/hive/ql/plan/VectorMapJoinInfo.java 9429785 
  ql/src/java/org/apache/hadoop/hive/ql/plan/VectorPartitionDesc.java 4078c7d 
  ql/src/java/org/apache/hadoop/hive/ql/plan/VectorReduceSinkDesc.java 2eb44b8 
  ql/src/java/org/apache/hadoop/hive/ql/plan/VectorReduceSinkInfo.java 8c35415 
  ql/src/java/org/apache/hadoop/hive/ql/plan/VectorSMBJoinDesc.java 031f11e 
  ql/src/java/org/apache/hadoop/hive/ql/plan/VectorSelectDesc.java c2c9450 
  ql/src/java/org/apache/hadoop/hive/ql/plan/VectorSparkHashTableSinkDesc.java 
7fb59db 
  
ql/src/java/org/apache/hadoop/hive/ql/plan/VectorSparkPartitionPruningSinkDesc.java
 c0bc7e4 
  ql/src/java/org/apache/hadoop/hive/ql/plan/VectorTableScanDesc.java 6e5ebe4 
  ql/src/java/org/apache/hadoop/hive/ql/processors/HiveCommand.java 145808b 
  
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInternalInterval.java
 fcf291a 
  
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/CheckFastRowHashMap.java
 638ccc5 
  
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/CommonFastHashTable.java
 90e8f33 
  serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java 6802a05 
  serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java 
88c3da9 
  
serde/src/java/org/apache/hadoop/hive/serde2/lazy/fast/LazySimpleDeserializeRead.java
 3b35baf 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/fast/StringToDouble.java 
f50b4fd 
  serde/src/java/org/apache/hadoop/hive/ser

[jira] [Created] (HIVE-16195) MM tables: mm_conversions test is broken

2017-03-13 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-16195:
---

 Summary: MM tables: mm_conversions test is broken
 Key: HIVE-16195
 URL: https://issues.apache.org/jira/browse/HIVE-16195
 Project: Hive
  Issue Type: Sub-task
Reporter: Sergey Shelukhin


It worked at some point (per the current .out file), but now bunch of 
conversions produce incorrect results. Needs to be fixed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (HIVE-16194) MM tables: most of the the parquet tests fail (w/o MM enabled)

2017-03-13 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-16194:
---

 Summary: MM tables: most of the the parquet tests fail (w/o MM 
enabled)
 Key: HIVE-16194
 URL: https://issues.apache.org/jira/browse/HIVE-16194
 Project: Hive
  Issue Type: Bug
Reporter: Sergey Shelukhin


See HIVE-15212, most of the parquet tests in CliDriver and 
MiniLlapLocalCliDriver fail with this or similar stack
{noformat}
2017-03-13T17:51:41,820 DEBUG [a12774a2-0e25-4453-84a8-4965debd6fb5 main] 
parquet.MapredParquetInputFormat: Using row-mode record reader
2017-03-13T17:51:41,821 ERROR [a12774a2-0e25-4453-84a8-4965debd6fb5 main] 
CliDriver: Failed with exception java.io.IOException:java.io.IOException: 
cannot find dir = 
file:/Users/sergey/git/hivegit/itests/qtest/target/localfs/warehouse/tbl_pred 
in pathToPartitionInfo: []
java.io.IOException: java.io.IOException: cannot find dir = 
file:/Users/sergey/git/hivegit/itests/qtest/target/localfs/warehouse/tbl_pred 
in pathToPartitionInfo: []
at 
org.apache.hadoop.hive.ql.exec.FetchOperator.getNextRow(FetchOperator.java:563)
at 
org.apache.hadoop.hive.ql.exec.FetchOperator.pushRow(FetchOperator.java:470)
at org.apache.hadoop.hive.ql.exec.FetchTask.fetch(FetchTask.java:148)
at org.apache.hadoop.hive.ql.Driver.getResults(Driver.java:2262)
at 
org.apache.hadoop.hive.cli.CliDriver.processLocalCmd(CliDriver.java:253)
{noformat}

These parts did change on the branch, but they should have changed towards 
finding more stuff, not less stuff. Need to investigate.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (HIVE-16193) Hive show compactions not reflecting the status of the application

2017-03-13 Thread Kavan Suresh (JIRA)
Kavan Suresh created HIVE-16193:
---

 Summary: Hive show compactions not reflecting the status of the 
application
 Key: HIVE-16193
 URL: https://issues.apache.org/jira/browse/HIVE-16193
 Project: Hive
  Issue Type: Bug
Reporter: Kavan Suresh


In a test for [HIVE-13354|https://issues.apache.org/jira/browse/HIVE-13354], we 
set properties to make the compaction fail. Recently show compactions indicates 
that compactions have been succeeding on the tables though the corresponding 
application gets killed as expected. 





--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (HIVE-16192) QTestUtil doesn't correctly set the last command when running "test" commands

2017-03-13 Thread Sahil Takiar (JIRA)
Sahil Takiar created HIVE-16192:
---

 Summary: QTestUtil doesn't correctly set the last command when 
running "test" commands 
 Key: HIVE-16192
 URL: https://issues.apache.org/jira/browse/HIVE-16192
 Project: Hive
  Issue Type: Bug
Reporter: Sahil Takiar
Assignee: Sahil Takiar


{{QTestUtil}} has some logic to execute "test" commands, these are typically 
"crypto" commands. These "test" commands, aren't valid HiveQL, but can be run 
in qtests.

The "crypto" commands are used to setup encryption keys and zones for the 
{{TestEncryptedHDFSCliDriver}}

When debugging HIVE-15991 I noticed that the command printed out in 
{{QTestUtil.failed}} is incorrect. It's printing out the last Hive command run, 
even if a more recent "test" command has been run. This can be very misleading 
when debugging qtest failures.

The attached patch updates the {{QTestUtil.executeTestCommand}} method so that 
is correctly sets the last executed "test" command.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (HIVE-16191) simplify thread usage in TaskExecutorService I

2017-03-13 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-16191:
---

 Summary: simplify thread usage in TaskExecutorService I
 Key: HIVE-16191
 URL: https://issues.apache.org/jira/browse/HIVE-16191
 Project: Hive
  Issue Type: Bug
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin






--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (HIVE-16190) Support expression in merge statement

2017-03-13 Thread Pengcheng Xiong (JIRA)
Pengcheng Xiong created HIVE-16190:
--

 Summary: Support expression in merge statement
 Key: HIVE-16190
 URL: https://issues.apache.org/jira/browse/HIVE-16190
 Project: Hive
  Issue Type: Bug
Reporter: Pengcheng Xiong
Assignee: Pengcheng Xiong


Right now, we only support atomExpression, rather than expression in values in 
MergeStatement.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Re: Review Request 57405: HIVE-16104 LLAP: preemption may be too aggressive if the pre-empted task doesn't die immediately

2017-03-13 Thread Sergey Shelukhin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57405/
---

(Updated March 13, 2017, 9:23 p.m.)


Review request for hive and Siddharth Seth.


Repository: hive-git


Description
---

see jira


Diffs (updated)
-

  llap-server/pom.xml fc392fb 
  
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java
 2a69d6a 
  
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java
 c1f6c96 
  
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskRunnerCallable.java
 18f0db9 
  
llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorTestHelpers.java
 259e383 
  
llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestTaskExecutorService.java
 bf7d1d8 


Diff: https://reviews.apache.org/r/57405/diff/7/

Changes: https://reviews.apache.org/r/57405/diff/6-7/


Testing
---


Thanks,

Sergey Shelukhin



Re: Review Request 57566: HIVE-16189: Table column stats might be invalidated in a failed table rename

2017-03-13 Thread Chaoyu Tang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57566/
---

(Updated March 13, 2017, 8:46 p.m.)


Review request for hive.


Bugs: HIVE-16189
https://issues.apache.org/jira/browse/HIVE-16189


Repository: hive-git


Description
---

If the table rename does not succeed due to its failure in moving the data to 
the new renamed table folder, the changes in TAB_COL_STATS are not rolled back 
which leads to invalid column stats.

This patch changes the order of metadata update and data move in alter table 
rename operation, which makes it easier to roll back metadata changes when 
moving data fails in rename a table.


Diffs (updated)
-

  metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 
bae39ac 


Diff: https://reviews.apache.org/r/57566/diff/3/

Changes: https://reviews.apache.org/r/57566/diff/2-3/


Testing
---


Thanks,

Chaoyu Tang



Re: Review Request 57566: HIVE-16189: Table column stats might be invalidated in a failed table rename

2017-03-13 Thread Chaoyu Tang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57566/
---

(Updated March 13, 2017, 8:33 p.m.)


Review request for hive.


Bugs: HIVE-16189
https://issues.apache.org/jira/browse/HIVE-16189


Repository: hive-git


Description
---

If the table rename does not succeed due to its failure in moving the data to 
the new renamed table folder, the changes in TAB_COL_STATS are not rolled back 
which leads to invalid column stats.

This patch changes the order of metadata update and data move in alter table 
rename operation, which makes it easier to roll back metadata changes when 
moving data fails in rename a table.


Diffs (updated)
-

  metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 
bae39ac 


Diff: https://reviews.apache.org/r/57566/diff/2/

Changes: https://reviews.apache.org/r/57566/diff/1-2/


Testing
---


Thanks,

Chaoyu Tang



Review Request 57568: HIVE-15978 Support regr_* functions

2017-03-13 Thread Zoltan Haindrich

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57568/
---

Review request for hive.


Bugs: HIVE-15978
https://issues.apache.org/jira/browse/HIVE-15978


Repository: hive-git


Description
---

all aggregators have been implemented by using some existing aggregator


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 
4ac25c24eb1becf1640d35f5b79965e4aefc5421 
  
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFBinarySetFunctions.java
 PRE-CREATION 
  
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDAFBinarySetFunctions.java
 PRE-CREATION 
  ql/src/test/queries/clientpositive/udaf_binarysetfunctions.q PRE-CREATION 
  ql/src/test/results/clientpositive/show_functions.q.out 
1361b9322199bbee5a97b402253e204004bcbfb9 
  ql/src/test/results/clientpositive/udaf_binarysetfunctions.q.out PRE-CREATION 


Diff: https://reviews.apache.org/r/57568/diff/1/


Testing
---


Thanks,

Zoltan Haindrich



Review Request 57566: HIVE-16189: Table column stats might be invalidated in a failed table rename

2017-03-13 Thread Chaoyu Tang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57566/
---

Review request for hive.


Bugs: HIVE-16189
https://issues.apache.org/jira/browse/HIVE-16189


Repository: hive-git


Description
---

If the table rename does not succeed due to its failure in moving the data to 
the new renamed table folder, the changes in TAB_COL_STATS are not rolled back 
which leads to invalid column stats.

This patch changes the order of metadata update and data move in alter table 
rename operation, which makes it easier to roll back metadata changes when 
moving data fails in rename a table.


Diffs
-

  metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 
bae39ac 


Diff: https://reviews.apache.org/r/57566/diff/1/


Testing
---


Thanks,

Chaoyu Tang



Re: Green unit test results

2017-03-13 Thread Siddharth Seth
There's far too many flaky tests to enforce a clean test run prior to
commit.
However, there also needs to be a very conscious effort to fix flaky tests
- otherwise, we're not going to reach the state where this can be enforced.
I'm also not sure whether this is just flaky tests, or whether there are
real problems. Maybe a few volunteers could drive the test fixes, and as an
artifact of this, come up with guidelines on writing tests (avoid stats
comparisons in qfiles, skip lines which may be environment specific,
introduce a new compare mechanism for lines which may be in a different
order based on internal structures, etc).

On Thu, Mar 9, 2017 at 2:39 PM, Ashutosh Chauhan 
wrote:

> I went through all the builds of last 24 hours and though there are couple
> of green runs, we still have quite a bit of flakiness in our tests. Most of
> that is captured via jiras on :
> https://issues.apache.org/jira/browse/HIVE-15058 Till we have that
> flakiness I am not sure if we can enforce no commit on test failures
> policy. Once flakiness is straightened out then this discussion will become
> moot anyways.
> Towards that I think this flaky detector job is a step in right direction.
>
>
> On Thu, Mar 9, 2017 at 11:38 AM, Sergio Pena 
> wrote:
>
> > - Probably avoiding committing a patch if a flaky test is shown on the
> test
> > results?
> > - Should we add a jenkins job that checks for flaky tests like the hbase
> > project did?
> > https://builds.apache.org/view/H-L/view/HBase/job/HBase-
> Find-Flaky-Tests/
> >
> > On Thu, Mar 9, 2017 at 10:21 AM, Ashutosh Chauhan 
> > wrote:
> >
> > > Great news! Thanks to everyone who contributed in getting our tests and
> > > test infra sorted out.
> > > We would definitely want to keep the status either green or blue
> > definitely
> > > not red :) All our previous efforts in keeping builds green didn't bear
> > > fruit.
> > > So, I think we need to make some changes here.
> > >
> > > Any ideas what we can do to ensure green builds going forward?
> > >
> > > Thanks,
> > > Ashutosh
> > >
> > > On Thu, Mar 9, 2017 at 8:07 AM, Sergio Pena 
> > > wrote:
> > >
> > > > It's actually blue Peter :).
> > > >
> > > > But good job, I see that the console output is:
> > > >
> > > > {color:red}ERROR:{color} -1 due to no test(s) being added or
> modified.
> > > >
> > > > {color:green}SUCCESS:{color} +1 due to 10336 tests passed
> > > >
> > > >
> > > > On Thu, Mar 9, 2017 at 8:12 AM, Peter Vary 
> wrote:
> > > >
> > > > > Hi,
> > > > >
> > > > > Congratulations for everyone who have helped taking care of the
> unit
> > > test
> > > > > failures!
> > > > > I have got my first green run! :)
> > > > >
> > > > > If any of you interested in:
> > > > > https://builds.apache.org/job/PreCommit-HIVE-Build/4049/
> testReport/
> > <
> > > > > https://builds.apache.org/job/PreCommit-HIVE-Build/4049/
> testReport/>
> > > :)
> > > > >
> > > > > Great day, and again thanks everyone!
> > > > >
> > > > > Peter
> > > >
> > >
> >
>


[jira] [Created] (HIVE-16189) Table column stats might be invalidated in a failed table rename

2017-03-13 Thread Chaoyu Tang (JIRA)
Chaoyu Tang created HIVE-16189:
--

 Summary: Table column stats might be invalidated in a failed table 
rename
 Key: HIVE-16189
 URL: https://issues.apache.org/jira/browse/HIVE-16189
 Project: Hive
  Issue Type: Bug
Reporter: Chaoyu Tang
Assignee: Chaoyu Tang


If the table rename does not succeed due to its failure in moving the data to 
the new renamed table folder, the changes in TAB_COL_STATS are not rolled back 
which leads to invalid column stats.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (HIVE-16188) beeline should block the connection if given invalid database name.

2017-03-13 Thread Pavas Garg (JIRA)
Pavas Garg created HIVE-16188:
-

 Summary: beeline should block the connection if given invalid 
database name.
 Key: HIVE-16188
 URL: https://issues.apache.org/jira/browse/HIVE-16188
 Project: Hive
  Issue Type: Bug
  Components: Hive
Reporter: Pavas Garg
Priority: Minor


When using beeline shell to connect to HS2 or impalaD as below -
beeline -u 
"jdbc:hive2://impalad-host-name.com:21050/XXX;principal=impala/impalad-host-name@domain.example.com"
 

Providing a invalid database name as XXX - the connection is made.

It should ideally stop the connection to be successfull.
Even though, the beeline tool does not allow to move forward, unless you 
provide a valid DB name, like
Use ;




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (HIVE-16187) Flaky Tests:TestHostAffinitySplitLocationProvider#testConsistentHashingFallback usually timed out

2017-03-13 Thread Fei Hui (JIRA)
Fei Hui created HIVE-16187:
--

 Summary: Flaky 
Tests:TestHostAffinitySplitLocationProvider#testConsistentHashingFallback 
usually timed out
 Key: HIVE-16187
 URL: https://issues.apache.org/jira/browse/HIVE-16187
 Project: Hive
  Issue Type: Bug
  Components: Tests
Affects Versions: 2.2.0
 Environment: cpu : 2 cores
mem : 4G
Reporter: Fei Hui


This test usually time out, elapsed time nears 10s even if it sucesses.
{quote}
---
 T E S T S
---
OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=256M; support was 
removed in 8.0
Running org.apache.hadoop.hive.ql.exec.tez.TestHostAffinitySplitLocationProvider
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.361 sec - in 
org.apache.hadoop.hive.ql.exec.tez.TestHostAffinitySplitLocationProvider

Results :

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0

---
 T E S T S
---
OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=256M; support was 
removed in 8.0
Running org.apache.hadoop.hive.ql.exec.tez.TestHostAffinitySplitLocationProvider
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 11.354 sec <<< 
FAILURE! - in 
org.apache.hadoop.hive.ql.exec.tez.TestHostAffinitySplitLocationProvider
testConsistentHashingFallback(org.apache.hadoop.hive.ql.exec.tez.TestHostAffinitySplitLocationProvider)
  Time elapsed: 10.019 sec  <<< ERROR!
java.lang.Exception: test timed out after 1 milliseconds
at java.lang.String.intern(Native Method)
at java.lang.Class.searchFields(Class.java:2956)
at java.lang.Class.getDeclaredField(Class.java:2068)
at 
org.mockito.internal.creation.cglib.CGLIBHacker.reflectOnCreateInfo(CGLIBHacker.java:44)
at 
org.mockito.internal.creation.cglib.CGLIBHacker.setMockitoNamingPolicy(CGLIBHacker.java:20)
at 
org.mockito.internal.creation.MethodInterceptorFilter.intercept(MethodInterceptorFilter.java:45)
at 
$java.util.List$$EnhancerByMockitoWithCGLIB$$4eb99852.size()
at 
org.apache.hadoop.hive.ql.exec.tez.HostAffinitySplitLocationProvider.determineLocation(HostAffinitySplitLocationProvider.java:79)
at 
org.apache.hadoop.hive.ql.exec.tez.TestHostAffinitySplitLocationProvider.testHashDistribution(TestHostAffinitySplitLocationProvider.java:216)
at 
org.apache.hadoop.hive.ql.exec.tez.TestHostAffinitySplitLocationProvider.testConsistentHashingFallback(TestHostAffinitySplitLocationProvider.java:181)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at 
org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)


Results :

Tests in error:
  
TestHostAffinitySplitLocationProvider.testConsistentHashingFallback:181->testHashDistribution:216
 ยป

{quote}

Maybe we should enlarge the timeout for this test. 

After enlarging the timeout, this test always passed

{quote}
---
 T E S T S
---
OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=256M; support was 
removed in 8.0
Running org.apache.hadoop.hive.ql.exec.tez.TestHostAffinitySplitLocationProvider
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.697 sec - in 
org.apache.hadoop.hive.ql.exec.tez.TestHostAffinitySplitLocationProvider

Results :

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0

---
 T E S T S
---
OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=256M; support was 
removed in 8.0
Running org.apache.hadoop.hive.ql.exec.tez.TestHostAffinitySplitLocationProvider
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.332 sec - in 
org.apache.hadoop.hive.ql.exec.tez.TestHostAffinitySplitLocationProvider

Results :

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
{quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Re: Review Request 55846: HIVE-15604: Improve contents of qfile test output

2017-03-13 Thread Barna Zsombor Klara

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55846/
---

(Updated March 13, 2017, 10:08 a.m.)


Review request for hive.


Changes
---

Addressed comments form the jira.


Repository: hive-git


Description
---

HIVE-15604: Improve contents of qfile test output


Diffs (updated)
-

  
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestLocationQueries.java
 06888467ec70eb1780e11969dafe2bff2c432d9d 
  
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/AbstractCoreBlobstoreCliDriver.java
 9c97c318ee89f598515d7b2e14f7f8184dc1119d 
  
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreAccumuloCliDriver.java
 3e4b3732cf49c1ac14baa58b65731f407f2b1dcd 
  
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreCliDriver.java 
a735346c062684eb6069565e7354b875cde44bd7 
  
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreCompareCliDriver.java
 71a02bca0b416c264beb00e95d2c3ab8da30b5c1 
  
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreHBaseCliDriver.java
 956a42d2711296061aa09f79596885af475ce6e6 
  
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreHBaseNegativeCliDriver.java
 6225180a0735e41f5eee2c32e5b05c674e2edbdd 
  
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreNegativeCliDriver.java
 65b2ce71d3797823c6c14002384857cb2a61749a 
  
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CorePerfCliDriver.java
 8620cde37894aa5f15a4f7850c6f62c9ac8bf6d1 
  
itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestProcessExecResult.java 
PRE-CREATION 
  itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 
0b223f42f4ce2926b104b3066944421bafa1d275 
  
itests/util/src/main/java/org/apache/hadoop/hive/ql/parse/CoreParseNegative.java
 8dba0bb9d5288240414a59f9468d3adae4dd8ef1 


Diff: https://reviews.apache.org/r/55846/diff/3/

Changes: https://reviews.apache.org/r/55846/diff/2-3/


Testing
---

Ran qtests manually and checked the error messages.
Checked that for diff failures we now have the output captured from the diff 
process in the error message of the failed test.
Checkout how multiple tests, all with failures, look on the console to make 
sure that the results are still readeable/easy to follow.


Thanks,

Barna Zsombor Klara



[jira] [Created] (HIVE-16186) REPL DUMP always dump all events in the given range even if we use LIMIT.

2017-03-13 Thread Sankar Hariappan (JIRA)
Sankar Hariappan created HIVE-16186:
---

 Summary: REPL DUMP always dump all events in the given range even 
if we use LIMIT.
 Key: HIVE-16186
 URL: https://issues.apache.org/jira/browse/HIVE-16186
 Project: Hive
  Issue Type: Sub-task
  Components: repl
Reporter: Sankar Hariappan
Assignee: Sankar Hariappan


Looks like LIMIT option doesn't work well with REPL DUMP.

0: jdbc:hive2://localhost:10001/default> REPL DUMP default FROM 170 LIMIT 1;
+--+---+
| dump_dir | last_repl_id  |
+--+---+
| /tmp/dump/1489395053411  | 195   |
+--+---+



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)