[jira] [Created] (HIVE-18561) Vectorization: Current vector PTF doesn't work under GroupBy and is designed for reduce-shuffle input

2018-01-27 Thread Matt McCline (JIRA)
Matt McCline created HIVE-18561:
---

 Summary: Vectorization: Current vector PTF doesn't work under 
GroupBy and is designed for reduce-shuffle input
 Key: HIVE-18561
 URL: https://issues.apache.org/jira/browse/HIVE-18561
 Project: Hive
  Issue Type: Bug
  Components: Hive
Reporter: Matt McCline
Assignee: Matt McCline


Need to add validation check in Vectorizer that doesn't vectorize unless PTF is 
under reduce-shuffle (with optional SELECT in-between).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (HIVE-18560) qtests: QTestUtil refactor/split

2018-01-27 Thread Laszlo Bodor (JIRA)
Laszlo Bodor created HIVE-18560:
---

 Summary: qtests: QTestUtil refactor/split
 Key: HIVE-18560
 URL: https://issues.apache.org/jira/browse/HIVE-18560
 Project: Hive
  Issue Type: Task
Reporter: Laszlo Bodor
Assignee: Laszlo Bodor


QTestUtil needs some refactoring, as it has become a large, hard-to-maintain, 
hard-to-test class with a bunch of responsibilities:
 * running qtests
 * parsing/evaluating results
 * masking/processing results

First, I would extract a processing class from it (e.g. QOutProcessor or 
something like that), which should be capable of being tested easily, and 
contains all the logic what's needed to make the final q.out results from the 
original q.out file. 
This processing class shall remain untouched in case the testing infrastructure 
(QTestUtil) is replaced or changed in some ways.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 65219: HIVE-18486: Create tests to cover methods for adding Partitions

2018-01-27 Thread Marta Kuczora via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65219/
---

(Updated Jan. 27, 2018, 10:01 a.m.)


Review request for hive, Peter Vary and Adam Szita.


Changes
---

Fixed the failing TestAddPartitions.testAddPartitionsOneInvalid test. This test 
was failing due to a concurrency issue. There is already a TODO about this 
issue, so now just commented out the problematic check and investigate this 
issue in an other Jira.


Bugs: HIVE-18486
https://issues.apache.org/jira/browse/HIVE-18486


Repository: hive-git


Description
---

The following methods of IMetaStoreClient are covered by this test.
- Partition add_partition(Partition)
- int add_partitions(List)
- List add_partitions(List, boolean, boolean)


The test covers not just the happy pathes, but the edge cases as well.


Diffs (updated)
-

  
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitions.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/65219/diff/3/

Changes: https://reviews.apache.org/r/65219/diff/2-3/


Testing
---

Run the tests


Thanks,

Marta Kuczora