Re: Review Request 71044: ACID: explore how we can avoid a move step during inserts/compaction

2019-07-12 Thread Vaibhav Gumashta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71044/
---

(Updated July 12, 2019, 9:40 p.m.)


Review request for hive and Gopal V.


Bugs: HIVE-21164
https://issues.apache.org/jira/browse/HIVE-21164


Repository: hive-git


Description
---

https://jira.apache.org/jira/browse/HIVE-21164


Diffs (updated)
-

  
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/history/TestHiveHistory.java
 5fd0ef9161 
  
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCrudCompactorOnTez.java
 d59cfe51e9 
  ql/src/java/org/apache/hadoop/hive/ql/exec/AbstractFileMergeOperator.java 
bb89f803d5 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 9ad4e71482 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 695d08bbe2 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 437266355a 
  ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 295fe7cbd0 
  ql/src/java/org/apache/hadoop/hive/ql/io/RecordUpdater.java 737e6774b7 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcOutputFormat.java c4c56f8477 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcRecordUpdater.java 3fa61d3560 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 691f3ee2e9 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 
5d6143d6a4 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java d47457857c 
  ql/src/java/org/apache/hadoop/hive/ql/parse/spark/GenSparkUtils.java 
757cb7af4d 
  ql/src/java/org/apache/hadoop/hive/ql/plan/FileSinkDesc.java 61ea28a5f5 
  ql/src/java/org/apache/hadoop/hive/ql/plan/LoadTableDesc.java bed05819b5 
  ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java 78f25856a4 
  ql/src/test/org/apache/hadoop/hive/ql/exec/TestFileSinkOperator.java 
a75103d60d 
  ql/src/test/results/clientpositive/acid_subquery.q.out 1dc1775557 
  ql/src/test/results/clientpositive/create_transactional_full_acid.q.out 
e324d5ec43 
  
ql/src/test/results/clientpositive/encrypted/encryption_insert_partition_dynamic.q.out
 61b0057adb 
  ql/src/test/results/clientpositive/llap/acid_no_buckets.q.out ae1d97fa21 
  ql/src/test/results/clientpositive/llap/insert_overwrite.q.out fbc3326b39 
  ql/src/test/results/clientpositive/llap/mm_all.q.out 6cb34e2c79 
  ql/src/test/results/clientpositive/mm_all.q.out 2c0247a539 


Diff: https://reviews.apache.org/r/71044/diff/4/

Changes: https://reviews.apache.org/r/71044/diff/3-4/


Testing
---


Thanks,

Vaibhav Gumashta



[jira] [Created] (HIVE-21990) ACID: remove any difference between an mm table insert and full acid table insert

2019-07-12 Thread Vaibhav Gumashta (JIRA)
Vaibhav Gumashta created HIVE-21990:
---

 Summary: ACID: remove any difference between an mm table insert 
and full acid table insert
 Key: HIVE-21990
 URL: https://issues.apache.org/jira/browse/HIVE-21990
 Project: Hive
  Issue Type: Bug
  Components: Transactions
Affects Versions: 4.0.0
Reporter: Vaibhav Gumashta


HIVE-21164 makes acid insert work like mm-table insert by writing directly to 
the destination and using manifest files to track committed files in a task and 
the job. After that, while there should be no difference in the insert code 
paths, there may be some cases where the difference remains (e.g. HIVE-17695). 
This jira will investigate any such issues and fix it.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


Re: Review Request 71044: ACID: explore how we can avoid a move step during inserts/compaction

2019-07-12 Thread Vaibhav Gumashta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71044/
---

(Updated July 12, 2019, 10:58 a.m.)


Review request for hive and Gopal V.


Bugs: HIVE-21164
https://issues.apache.org/jira/browse/HIVE-21164


Repository: hive-git


Description
---

https://jira.apache.org/jira/browse/HIVE-21164


Diffs (updated)
-

  
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/history/TestHiveHistory.java
 5fd0ef9161 
  
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCrudCompactorOnTez.java
 d59cfe51e9 
  ql/src/java/org/apache/hadoop/hive/ql/exec/AbstractFileMergeOperator.java 
bb89f803d5 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 9ad4e71482 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 695d08bbe2 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 437266355a 
  ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 295fe7cbd0 
  ql/src/java/org/apache/hadoop/hive/ql/io/RecordUpdater.java 737e6774b7 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcOutputFormat.java c4c56f8477 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcRecordUpdater.java 3fa61d3560 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 691f3ee2e9 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 
5d6143d6a4 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java d47457857c 
  ql/src/java/org/apache/hadoop/hive/ql/parse/spark/GenSparkUtils.java 
757cb7af4d 
  ql/src/java/org/apache/hadoop/hive/ql/plan/FileSinkDesc.java 61ea28a5f5 
  ql/src/java/org/apache/hadoop/hive/ql/plan/LoadTableDesc.java bed05819b5 
  ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java 78f25856a4 
  ql/src/test/org/apache/hadoop/hive/ql/exec/TestFileSinkOperator.java 
a75103d60d 


Diff: https://reviews.apache.org/r/71044/diff/3/

Changes: https://reviews.apache.org/r/71044/diff/2-3/


Testing
---


Thanks,

Vaibhav Gumashta