Review Request 71571: HIVE-22240

2019-10-01 Thread Krisztian Kasa

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71571/
---

Review request for hive, Jesús Camacho Rodríguez, Zoltan Haindrich, and Vineet 
Garg.


Bugs: HIVE-22240
https://issues.apache.org/jira/browse/HIVE-22240


Repository: hive-git


Description
---

Function percentile_cont fails when array parameter passed
==
The method `GenericUDAFPercentileCont.iterate` expect a `HiveDecimalWritable` 
parameter. However array parameters are converted to  
`ArrayList` before they passed. This leads to a 
`ClassCastException`.


Diffs
-

  
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFPercentileCont.java
 e7e4fda6ea 
  
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFPercentileDisc.java
 d7c295cb11 
  ql/src/test/queries/clientpositive/udaf_percentile_cont.q 7a1ac5c968 
  ql/src/test/queries/clientpositive/udaf_percentile_disc.q 6d93b3418a 
  ql/src/test/results/clientpositive/udaf_percentile_cont.q.out a2dae4a06e 
  ql/src/test/results/clientpositive/udaf_percentile_disc.q.out 3ef0cf9874 


Diff: https://reviews.apache.org/r/71571/diff/1/


Testing
---

Existing q tests are extended with calling percentile_cont/disc with array 
parameters


Thanks,

Krisztian Kasa



[jira] [Created] (HIVE-22278) Upgrade log4j to 2.12.1

2019-10-01 Thread David Lavati (Jira)
David Lavati created HIVE-22278:
---

 Summary: Upgrade log4j to 2.12.1
 Key: HIVE-22278
 URL: https://issues.apache.org/jira/browse/HIVE-22278
 Project: Hive
  Issue Type: Improvement
Reporter: David Lavati
Assignee: David Lavati


Hive's currently using log4j 2.10.0 and according to HIVE-21273, a number of 
issues are present in it, which can be resolved by upgrading to 2.12.1:

Curly braces in parameters are treated as placeholders
 affectsVersions:2.8.2;2.9.0;2.10.0
 
[https://issues.apache.org/jira/projects/LOG4J2/issues/LOG4J2-2032?filter=allopenissues]
 Remove Log4J API dependency on Management APIs
 affectsVersions:2.9.1;2.10.0
 
[https://issues.apache.org/jira/projects/LOG4J2/issues/LOG4J2-2126?filter=allopenissues]
 Log4j2 throws NoClassDefFoundError in Java 9
 affectsVersions:2.10.0;2.11.0
 
[https://issues.apache.org/jira/projects/LOG4J2/issues/LOG4J2-2129?filter=allopenissues]
 ThreadContext map is cleared => entries are only available for one log event
 affectsVersions:2.10.0
 
[https://issues.apache.org/jira/projects/LOG4J2/issues/LOG4J2-2158?filter=allopenissues]
 Objects held in SortedArrayStringMap cannot be filtered during serialization
 affectsVersions:2.10.0
 
[https://issues.apache.org/jira/projects/LOG4J2/issues/LOG4J2-2163?filter=allopenissues]
 NullPointerException at 
org.apache.logging.log4j.util.Activator.loadProvider(Activator.java:81) in 
log4j 2.10.0
 affectsVersions:2.10.0
 
[https://issues.apache.org/jira/projects/LOG4J2/issues/LOG4J2-2182?filter=allopenissues]
 MarkerFilter onMismatch invalid attribute in .properties
 affectsVersions:2.10.0
 
[https://issues.apache.org/jira/projects/LOG4J2/issues/LOG4J2-2202?filter=allopenissues]
 Configuration builder classes should look for "onMismatch"; not "onMisMatch".
 affectsVersions:2.4;2.4.1;2.5;2.6;2.6.1;2.6.2;2.7;2.8;2.8.1;2.8.2;2.9.0;2.10.0
 
[https://issues.apache.org/jira/projects/LOG4J2/issues/LOG4J2-2219?filter=allopenissues]
 Empty Automatic-Module-Name Header
 affectsVersions:2.10.0;2.11.0;3.0.0
 
[https://issues.apache.org/jira/projects/LOG4J2/issues/LOG4J2-2254?filter=allopenissues]
 ConcurrentModificationException from 
org.apache.logging.log4j.status.StatusLogger.(StatusLogger.java:71)
 affectsVersions:2.10.0
 
[https://issues.apache.org/jira/projects/LOG4J2/issues/LOG4J2-2276?filter=allopenissues]
 Allow SystemPropertiesPropertySource to run with a SecurityManager that 
rejects system property access
 affectsVersions:2.10.0
 
[https://issues.apache.org/jira/projects/LOG4J2/issues/LOG4J2-2279?filter=allopenissues]
 ParserConfigurationException when using Log4j with 
oracle.xml.jaxp.JXDocumentBuilderFactory
 affectsVersions:2.10.0
 
[https://issues.apache.org/jira/projects/LOG4J2/issues/LOG4J2-2283?filter=allopenissues]
 Log4j 2.10+not working with SLF4J 1.8 in OSGI environment
 affectsVersions:2.10.0;2.11.0
 
[https://issues.apache.org/jira/projects/LOG4J2/issues/LOG4J2-2305?filter=allopenissues]
 fix the CacheEntry map in ThrowableProxy#toExtendedStackTrace to be put and 
gotten with same key
 affectsVersions:2.6.2;2.7;2.8;2.8.1;2.8.2;2.9.0;2.9.1;2.10.0;2.11.0
 
[https://issues.apache.org/jira/projects/LOG4J2/issues/LOG4J2-2389?filter=allopenissues]
 NullPointerException when closing never used RollingRandomAccessFileAppender
 affectsVersions:2.10.0;2.11.1
 
[https://issues.apache.org/jira/projects/LOG4J2/issues/LOG4J2-2418?filter=allopenissues]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


ApacheCon North America 2020, project participation

2019-10-01 Thread Rich Bowen
Hi, folks,

(Note: You're receiving this email because you're on the dev@ list for
one or more Apache Software Foundation projects.)

For ApacheCon North America 2019, we asked projects to participate in
the creation of project/topic specific tracks. This was very successful,
with about 15 projects stepping up to curate the content for their
track/summit/event.

We need to know if you're going to do the same for 2020. This informs
how large a venue we book for the event, how long the event runs, and
many other considerations.

If you intend to participate again in 2020, we need to hear from you on
the plann...@apachecon.com mailing list. This is not a firm commitment,
but we need to know if you're, say, 75% confident that you'll be
participating.

And, no, we do not have any details at all, but assume that it will be
in roughly the same calendar space as this year's event, ie, somewhere
in the August-October timeframe.

Thanks.

-- 
Rich Bowen
VP Conferences
The Apache Software Foundation
@apachecon


Re: Review Request 71555: Incompatible java.util.ArrayList for java 11

2019-10-01 Thread j . prasanth . j

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71555/#review218010
---


Ship it!




Ship It!

- Prasanth_J


On Sept. 30, 2019, 7:23 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71555/
> ---
> 
> (Updated Sept. 30, 2019, 7:23 a.m.)
> 
> 
> Review request for hive, Laszlo Bodor, Ashutosh Chauhan, and Prasanth_J.
> 
> 
> Bugs: HIVE-22097
> https://issues.apache.org/jira/browse/HIVE-22097
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> The following exceptions come when running a query on Java 11:
> 
> java.lang.RuntimeException: java.lang.NoSuchFieldException: parentOffset
>   at 
> org.apache.hadoop.hive.ql.exec.SerializationUtilities$ArrayListSubListSerializer.(SerializationUtilities.java:390)
>   at 
> org.apache.hadoop.hive.ql.exec.SerializationUtilities$1.create(SerializationUtilities.java:235)
>   at 
> org.apache.hive.com.esotericsoftware.kryo.pool.KryoPoolQueueImpl.borrow(KryoPoolQueueImpl.java:48)
>   at 
> org.apache.hadoop.hive.ql.exec.SerializationUtilities.borrowKryo(SerializationUtilities.java:280)
>   at 
> org.apache.hadoop.hive.ql.exec.Utilities.setBaseWork(Utilities.java:595)
>   at 
> org.apache.hadoop.hive.ql.exec.Utilities.setMapWork(Utilities.java:587)
>   at 
> org.apache.hadoop.hive.ql.exec.Utilities.setMapRedWork(Utilities.java:579)
>   at 
> org.apache.hadoop.hive.ql.exec.mr.ExecDriver.execute(ExecDriver.java:357)
>   at 
> org.apache.hadoop.hive.ql.exec.mr.MapRedTask.execute(MapRedTask.java:159)
>   at org.apache.hadoop.hive.ql.exec.Task.executeTask(Task.java:212)
>   at 
> org.apache.hadoop.hive.ql.exec.TaskRunner.runSequential(TaskRunner.java:103)
>   at org.apache.hadoop.hive.ql.Driver.launchTask(Driver.java:2317)
>   at org.apache.hadoop.hive.ql.Driver.execute(Driver.java:1969)
>   at org.apache.hadoop.hive.ql.Driver.runInternal(Driver.java:1636)
>   at org.apache.hadoop.hive.ql.Driver.run(Driver.java:1396)
>   at org.apache.hadoop.hive.ql.Driver.run(Driver.java:1390)
>   at 
> org.apache.hadoop.hive.ql.reexec.ReExecDriver.run(ReExecDriver.java:162)
>   at 
> org.apache.hadoop.hive.ql.reexec.ReExecDriver.run(ReExecDriver.java:223)
>   at 
> org.apache.hadoop.hive.cli.CliDriver.processLocalCmd(CliDriver.java:242)
>   at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:189)
>   at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:408)
>   at 
> org.apache.hadoop.hive.cli.CliDriver.executeDriver(CliDriver.java:838)
>   at org.apache.hadoop.hive.cli.CliDriver.run(CliDriver.java:777)
>   at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:696)
>   at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.base/java.lang.reflect.Method.invoke(Method.java:566)
>   at org.apache.hadoop.util.RunJar.run(RunJar.java:323)
>   at org.apache.hadoop.util.RunJar.main(RunJar.java:236)
> Caused by: java.lang.NoSuchFieldException: parentOffset
>   at java.base/java.lang.Class.getDeclaredField(Class.java:2412)
>   at 
> org.apache.hadoop.hive.ql.exec.SerializationUtilities$ArrayListSubListSerializer.(SerializationUtilities.java:384)
>   ... 29 more
> 
> The internal structure of ArrayList$SubList changed and our serializer fails. 
> This serialzier comes from kryo-serializers package where they already 
> updated the code. This patch does the some.
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/SerializationUtilities.java 
> e4d33e82168 
> 
> 
> Diff: https://reviews.apache.org/r/71555/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on a real cluster with Java 11.
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>



Re: Review Request 71555: Incompatible java.util.ArrayList for java 11

2019-10-01 Thread Laszlo Bodor

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71555/#review218004
---


Ship it!




Ship It!

- Laszlo Bodor


On Sept. 30, 2019, 7:23 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71555/
> ---
> 
> (Updated Sept. 30, 2019, 7:23 a.m.)
> 
> 
> Review request for hive, Laszlo Bodor, Ashutosh Chauhan, and Prasanth_J.
> 
> 
> Bugs: HIVE-22097
> https://issues.apache.org/jira/browse/HIVE-22097
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> The following exceptions come when running a query on Java 11:
> 
> java.lang.RuntimeException: java.lang.NoSuchFieldException: parentOffset
>   at 
> org.apache.hadoop.hive.ql.exec.SerializationUtilities$ArrayListSubListSerializer.(SerializationUtilities.java:390)
>   at 
> org.apache.hadoop.hive.ql.exec.SerializationUtilities$1.create(SerializationUtilities.java:235)
>   at 
> org.apache.hive.com.esotericsoftware.kryo.pool.KryoPoolQueueImpl.borrow(KryoPoolQueueImpl.java:48)
>   at 
> org.apache.hadoop.hive.ql.exec.SerializationUtilities.borrowKryo(SerializationUtilities.java:280)
>   at 
> org.apache.hadoop.hive.ql.exec.Utilities.setBaseWork(Utilities.java:595)
>   at 
> org.apache.hadoop.hive.ql.exec.Utilities.setMapWork(Utilities.java:587)
>   at 
> org.apache.hadoop.hive.ql.exec.Utilities.setMapRedWork(Utilities.java:579)
>   at 
> org.apache.hadoop.hive.ql.exec.mr.ExecDriver.execute(ExecDriver.java:357)
>   at 
> org.apache.hadoop.hive.ql.exec.mr.MapRedTask.execute(MapRedTask.java:159)
>   at org.apache.hadoop.hive.ql.exec.Task.executeTask(Task.java:212)
>   at 
> org.apache.hadoop.hive.ql.exec.TaskRunner.runSequential(TaskRunner.java:103)
>   at org.apache.hadoop.hive.ql.Driver.launchTask(Driver.java:2317)
>   at org.apache.hadoop.hive.ql.Driver.execute(Driver.java:1969)
>   at org.apache.hadoop.hive.ql.Driver.runInternal(Driver.java:1636)
>   at org.apache.hadoop.hive.ql.Driver.run(Driver.java:1396)
>   at org.apache.hadoop.hive.ql.Driver.run(Driver.java:1390)
>   at 
> org.apache.hadoop.hive.ql.reexec.ReExecDriver.run(ReExecDriver.java:162)
>   at 
> org.apache.hadoop.hive.ql.reexec.ReExecDriver.run(ReExecDriver.java:223)
>   at 
> org.apache.hadoop.hive.cli.CliDriver.processLocalCmd(CliDriver.java:242)
>   at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:189)
>   at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:408)
>   at 
> org.apache.hadoop.hive.cli.CliDriver.executeDriver(CliDriver.java:838)
>   at org.apache.hadoop.hive.cli.CliDriver.run(CliDriver.java:777)
>   at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:696)
>   at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.base/java.lang.reflect.Method.invoke(Method.java:566)
>   at org.apache.hadoop.util.RunJar.run(RunJar.java:323)
>   at org.apache.hadoop.util.RunJar.main(RunJar.java:236)
> Caused by: java.lang.NoSuchFieldException: parentOffset
>   at java.base/java.lang.Class.getDeclaredField(Class.java:2412)
>   at 
> org.apache.hadoop.hive.ql.exec.SerializationUtilities$ArrayListSubListSerializer.(SerializationUtilities.java:384)
>   ... 29 more
> 
> The internal structure of ArrayList$SubList changed and our serializer fails. 
> This serialzier comes from kryo-serializers package where they already 
> updated the code. This patch does the some.
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/SerializationUtilities.java 
> e4d33e82168 
> 
> 
> Diff: https://reviews.apache.org/r/71555/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on a real cluster with Java 11.
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>



[jira] [Created] (HIVE-22277) TestBuddyAllocator.testMTT[2] is flaky

2019-10-01 Thread Jira
László Bodor created HIVE-22277:
---

 Summary: TestBuddyAllocator.testMTT[2] is flaky
 Key: HIVE-22277
 URL: https://issues.apache.org/jira/browse/HIVE-22277
 Project: Hive
  Issue Type: Bug
Reporter: László Bodor






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HIVE-22276) Break up DDLSemanticAnalyzer - extract View related analyzers

2019-10-01 Thread Miklos Gergely (Jira)
Miklos Gergely created HIVE-22276:
-

 Summary: Break up DDLSemanticAnalyzer - extract View related 
analyzers
 Key: HIVE-22276
 URL: https://issues.apache.org/jira/browse/HIVE-22276
 Project: Hive
  Issue Type: Sub-task
Reporter: Miklos Gergely
Assignee: Miklos Gergely


DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal is to 
refactor it in order to have everything cut into more handleable classes under 
the package  org.apache.hadoop.hive.ql.exec.ddl:
 * have a separate class for each analyzers
 * have a package for each operation, containing an analyzer, a description, 
and an operation, so the amount of classes under a package is more manageable

Step #5: extract all the workload management related analyzers from 
DDLSemanticAnalyzer, and move them under the new package.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)