+1 to having this in Hive repo. Or easier, we can just add a section in the
README.md at the top level.
On Fri, Feb 5, 2021 at 1:54 AM Stamatis Zampetakis
wrote:
> I think https://cwiki.apache.org/confluence/display/Hive/HowToContribute
> is
> also relevant for this kind of info.
>
> How about moving this kind of guidelines to the Hive repo as
> contributing.md so that it is visible to everybody creating/merging pull
> requests?
>
> Best,
> Stamatis
>
> On Fri, Feb 5, 2021 at 10:40 AM Zoltan Haindrich wrote:
>
> > Hey All!
> >
> > Thank you Stamatis for providing those pointers - I also had in mind the
> > icla stuff and that it will really become a challenge to identify who is
> > the real contributor :D
> >
> > Cameron: thank you for your understanding - I'm happy that you and Zhou
> > are contributing to the project! But it's important to be able to
> identify
> > the individual for the
> > contributions they make.
> >
> > Vihang: Its great to know about that they are contributing those
> > improvements, I haven't seen this doc before! I totally agree that we
> > should improve on our documentation -
> > I've just taken a look and not sure where it should be extended - I'll
> > keep looking :)
> >
> > cheers,
> > Zoltan
> >
> >
> > On 2/5/21 12:31 AM, Stamatis Zampetakis wrote:
> > > Apache requires signing an ICLA [1] for committers and clear intention
> of
> > > contributing from contributors [2].
> > > From the above, I would say that it is important to know who
> > (individual)
> > > is the one contributing the code and Zoltan did well to raise awareness
> > > around this topic.
> > > Of course, not everyone is familiar with these processes so as Vihang
> > > pointed out it would be good to improve the documentation and point
> > people
> > > to that when necessary.
> > >
> > > Best,
> > > Stamatis
> > >
> > > [1] https://www.apache.org/licenses/icla.pdf
> > > [2] https://apetro.ghost.io/apache-contributors-no-cla/
> > >
> > > On Thu, Feb 4, 2021 at 9:12 PM Vihang Karajgaonkar <
> vihan...@apache.org>
> > > wrote:
> > >
> > >> Thanks Zoltan for your email.
> > >>
> > >> Just to give some context, dataproc-metastore is Google's metastore
> > >> compatible cloud service. The good news is that they are happy and
> > willing
> > >> to contribute any improvements/fixes to Apache Hive (metastore
> > >> specifically) instead of forking out the repository.
> > >> They also contributed their proposed changes here:
> > >>
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158869886
> > >>
> > >> I think it makes sense to have individual users contribute the PR so
> > that
> > >> we can attribute the patch accordingly. When I merged their PR I asked
> > them
> > >> offline who is the end user for this PR and they mentioned they are
> > still
> > >> figuring out who is going to be the point of contact for the
> open-source
> > >> contributions. While merging the PR, github suggested the author name
> > and I
> > >> used that.
> > >>
> > >> I was a bit angry because of the above; so I've closed it.
> > >>>
> > >> I feel this is a bit against the spirit of open-source hive and it
> > would be
> > >> great to have a wiki page for commit guidelines and ask them to refer
> to
> > >> it. The only wiki that I find about commit guidelines is
> > >> https://cwiki.apache.org/confluence/display/Hive/HowToCommit which
> > >> definitely needs an update.
> > >>
> > >> On Thu, Feb 4, 2021 at 1:02 AM Zoltan Haindrich wrote:
> > >>
> > >>> Hey All!
> > >>>
> > >>> It seems to me that someone have opened a "dataproc-metastore"
> account
> > on
> > >>> github and is contributing to Hive thru that user.
> > >>> I personally don't like that the account is not a real person - it
> > looks
> > >>> more like a team or group inside Google.
> > >>>
> > >>> This account already has a commit which is very confusing:
> > >>> * the github account is https://github.com/dataproc-metastore
> > >>> * the jira is assigned to Cameron Moberg
> > >>> https://issues.apache.org/jira/browse/HIVE-24470
> > >>> * the actual commits in the PR were made by Zhou Fang
> > >>> https://github.com/coufon
> > >>> * the commit is attributed to "Zhou Fang" -
> > >>>
> > >>
> >
> https://github.com/apache/hive/commit/b0309b7f023d9785c3a842d70d0fc471252101bf
> > >>> * the jira is still open...but that's not really relevant - that can
> be
> > >>> fixed in no time :D
> > >>>
> > >>> I think we should stop merging PRs from sources like this (or is it
> too
> > >>> much to ask that the user should have a matching github account)?
> > >>>
> > >>> This "dataproc-metastore" user had one more PR open - I was a bit
> angry
> > >>> because of the above; so I've closed it.
> > >>>
> > >>> Let me know what you think!
> > >>>
> > >>> cheers,
> > >>> Zoltan
> > >>>
> > >>
> > >
> >
>
