[jira] [Commented] (HIVE-8152) Update with expression in set fails
[
https://issues.apache.org/jira/browse/HIVE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14143274#comment-14143274
]
Alan Gates commented on HIVE-8152:
--
In UpdateDeleteSemanticAnalyzer:
It looks like you have a added an unused import (antlr.collections.AST)
At line 347, adding the null check for columnsAccessInfo. I think if this is
null we should create it rather than ignore adding the columns, as is done for
the update columns above. [~thejas]?
Update with expression in set fails
---
Key: HIVE-8152
URL: https://issues.apache.org/jira/browse/HIVE-8152
Project: Hive
Issue Type: Bug
Components: Query Processor
Affects Versions: 0.14.0
Reporter: Alan Gates
Assignee: Eugene Koifman
Priority: Critical
Attachments: HIVE-8152.1.patch, HIVE-8152.2.patch, HIVE-8152.patch
Doing: {{update orctabsmall set age = age + 1;}} results in {{FAILED:
ParseException line 1:33 missing EOF at '+' near 'age'}}
We should be able to handle simple expressions in set clauses.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-8152) Update with expression in set fails
[
https://issues.apache.org/jira/browse/HIVE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14143275#comment-14143275
]
Alan Gates commented on HIVE-8152:
--
Also, test failure is not related. That test fails ~50% of the time.
Update with expression in set fails
---
Key: HIVE-8152
URL: https://issues.apache.org/jira/browse/HIVE-8152
Project: Hive
Issue Type: Bug
Components: Query Processor
Affects Versions: 0.14.0
Reporter: Alan Gates
Assignee: Eugene Koifman
Priority: Critical
Attachments: HIVE-8152.1.patch, HIVE-8152.2.patch, HIVE-8152.patch
Doing: {{update orctabsmall set age = age + 1;}} results in {{FAILED:
ParseException line 1:33 missing EOF at '+' near 'age'}}
We should be able to handle simple expressions in set clauses.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-8152) Update with expression in set fails
[
https://issues.apache.org/jira/browse/HIVE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14143313#comment-14143313
]
Alan Gates commented on HIVE-8152:
--
Right, I forgot the columnsAccessInfo will be null if no columns are referenced
from the input table.
+1 then. The unused import can be removed at check in.
Update with expression in set fails
---
Key: HIVE-8152
URL: https://issues.apache.org/jira/browse/HIVE-8152
Project: Hive
Issue Type: Bug
Components: Query Processor
Affects Versions: 0.14.0
Reporter: Alan Gates
Assignee: Eugene Koifman
Priority: Critical
Attachments: HIVE-8152.1.patch, HIVE-8152.2.patch, HIVE-8152.patch
Doing: {{update orctabsmall set age = age + 1;}} results in {{FAILED:
ParseException line 1:33 missing EOF at '+' near 'age'}}
We should be able to handle simple expressions in set clauses.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8201) Remove hardwiring to HiveInputFormat in acid qfile tests
[ https://issues.apache.org/jira/browse/HIVE-8201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-8201: - Status: Patch Available (was: Open) Remove hardwiring to HiveInputFormat in acid qfile tests Key: HIVE-8201 URL: https://issues.apache.org/jira/browse/HIVE-8201 Project: Hive Issue Type: Bug Affects Versions: 0.14.0 Reporter: Alan Gates Assignee: Alan Gates Attachments: HIVE-8201.2.patch, HIVE-8201.patch Now that HIVE-7812 is checked in we should remove the hardwiring to HiveInputFormat for the qfile tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8201) Remove hardwiring to HiveInputFormat in acid qfile tests
[ https://issues.apache.org/jira/browse/HIVE-8201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-8201: - Status: Open (was: Patch Available) Patch no longer applies. Remove hardwiring to HiveInputFormat in acid qfile tests Key: HIVE-8201 URL: https://issues.apache.org/jira/browse/HIVE-8201 Project: Hive Issue Type: Bug Affects Versions: 0.14.0 Reporter: Alan Gates Assignee: Alan Gates Attachments: HIVE-8201.2.patch, HIVE-8201.patch Now that HIVE-7812 is checked in we should remove the hardwiring to HiveInputFormat for the qfile tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8201) Remove hardwiring to HiveInputFormat in acid qfile tests
[ https://issues.apache.org/jira/browse/HIVE-8201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-8201: - Attachment: HIVE-8201.2.patch Remove hardwiring to HiveInputFormat in acid qfile tests Key: HIVE-8201 URL: https://issues.apache.org/jira/browse/HIVE-8201 Project: Hive Issue Type: Bug Affects Versions: 0.14.0 Reporter: Alan Gates Assignee: Alan Gates Attachments: HIVE-8201.2.patch, HIVE-8201.patch Now that HIVE-7812 is checked in we should remove the hardwiring to HiveInputFormat for the qfile tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8105) booleans and nulls not handled properly in insert/values
[ https://issues.apache.org/jira/browse/HIVE-8105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-8105: - Resolution: Fixed Fix Version/s: 0.14.0 Status: Resolved (was: Patch Available) Patch 3 committed, with commented as requested by Eugene. Thanks Eugene for the review. booleans and nulls not handled properly in insert/values Key: HIVE-8105 URL: https://issues.apache.org/jira/browse/HIVE-8105 Project: Hive Issue Type: Bug Components: Query Processor Affects Versions: 0.14.0 Reporter: Alan Gates Assignee: Alan Gates Priority: Critical Fix For: 0.14.0 Attachments: HIVE-8105.2.patch, HIVE-8105.2.patch, HIVE-8105.3.patch, HIVE-8105.patch Doing an insert/values with a boolean always results in a value of true, regardless of whether true or false is given in the query. Doing an insert/values with a null for a column value results in a semantic error. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-5317) Implement insert, update, and delete in Hive with full ACID support
[ https://issues.apache.org/jira/browse/HIVE-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14142013#comment-14142013 ] Alan Gates commented on HIVE-5317: -- The discussion of when to branch for this has been going on on dev@hive.apache.org for a bit now, see http://mail-archives.apache.org/mod_mbox/hive-dev/201408.mbox/%3CCAKjA-pyhnHhxjaCYhWibX3o-RfQ7g2Sk9fyLYBN%3DFx6UofJ33A%40mail.gmail.com%3E The summary is, any day now. Once we branch it's usually ~4 weeks for stabilization and release mechanics before the release. Implement insert, update, and delete in Hive with full ACID support --- Key: HIVE-5317 URL: https://issues.apache.org/jira/browse/HIVE-5317 Project: Hive Issue Type: New Feature Reporter: Owen O'Malley Assignee: Owen O'Malley Attachments: InsertUpdatesinHive.pdf Many customers want to be able to insert, update and delete rows from Hive tables with full ACID support. The use cases are varied, but the form of the queries that should be supported are: * INSERT INTO tbl SELECT … * INSERT INTO tbl VALUES ... * UPDATE tbl SET … WHERE … * DELETE FROM tbl WHERE … * MERGE INTO tbl USING src ON … WHEN MATCHED THEN ... WHEN NOT MATCHED THEN ... * SET TRANSACTION LEVEL … * BEGIN/END TRANSACTION Use Cases * Once an hour, a set of inserts and updates (up to 500k rows) for various dimension tables (eg. customer, inventory, stores) needs to be processed. The dimension tables have primary keys and are typically bucketed and sorted on those keys. * Once a day a small set (up to 100k rows) of records need to be deleted for regulatory compliance. * Once an hour a log of transactions is exported from a RDBS and the fact tables need to be updated (up to 1m rows) to reflect the new data. The transactions are a combination of inserts, updates, and deletes. The table is partitioned and bucketed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8149) hive.optimize.reducededuplication should be set to false for IUD ops
[ https://issues.apache.org/jira/browse/HIVE-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-8149: - Resolution: Fixed Fix Version/s: 0.14.0 Status: Resolved (was: Patch Available) Test FileSinkOperator failures are unrelated and have been resolved by HIVE-6936. Patch checked in. Thank you Eugene for the review. hive.optimize.reducededuplication should be set to false for IUD ops Key: HIVE-8149 URL: https://issues.apache.org/jira/browse/HIVE-8149 Project: Hive Issue Type: Bug Components: Query Processor Affects Versions: 0.14.0 Reporter: Eugene Koifman Assignee: Alan Gates Fix For: 0.14.0 Attachments: HIVE-8149.patch this optimizer causes both old and new rows to show up in a select after update (for tables involving few rows) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7689) Enable Postgres as METASTORE back-end
[ https://issues.apache.org/jira/browse/HIVE-7689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14140707#comment-14140707 ] Alan Gates commented on HIVE-7689: -- All these calls to getEscape make the code hard to read. If postgres requires lower case table and column names I'd prefer to change the postgres version of hive-txn-schema.sql to create the tables and columns with lower case names. Wouldn't that be easier? Enable Postgres as METASTORE back-end - Key: HIVE-7689 URL: https://issues.apache.org/jira/browse/HIVE-7689 Project: Hive Issue Type: Improvement Components: Metastore Affects Versions: 0.14.0 Reporter: Damien Carol Assignee: Damien Carol Priority: Minor Labels: metastore, postgres Fix For: 0.14.0 Attachments: HIVE-7689.5.patch, HIVE-7689.6.patch, HIVE-7689.7.patch, HIVE-7689.8.patch, HIVE-7889.1.patch, HIVE-7889.2.patch, HIVE-7889.3.patch, HIVE-7889.4.patch I maintain few patches to make Metastore works with Postgres back end in our production environment. The main goal of this JIRA is to push upstream these patches. This patch enable LOCKS, COMPACTION and fix error in STATS on postgres metastore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-7883) DBTxnManager trying to close already closed metastore client connection
[
https://issues.apache.org/jira/browse/HIVE-7883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Gates updated HIVE-7883:
-
Attachment: HIVE-7883.patch
The real question is why is DbTxnManager creating its own HiveMetastoreClient
rather than using the existing one. The attached patch fixes that, and removes
the close.
DBTxnManager trying to close already closed metastore client connection
---
Key: HIVE-7883
URL: https://issues.apache.org/jira/browse/HIVE-7883
Project: Hive
Issue Type: Bug
Components: Metastore, Transactions
Affects Versions: 0.14.0
Reporter: Mostafa Mokhtar
Assignee: Alan Gates
Attachments: HIVE-7883.patch
You will find following log message :
{code}
ERROR hive.metastore: Unable to shutdown local metastore client
org.apache.thrift.transport.TTransportException: Cannot write to null
outputStream
at
org.apache.thrift.transport.TIOStreamTransport.write(TIOStreamTransport.java:142)
at
org.apache.thrift.protocol.TBinaryProtocol.writeI32(TBinaryProtocol.java:163)
at
org.apache.thrift.protocol.TBinaryProtocol.writeMessageBegin(TBinaryProtocol.java:91)
at org.apache.thrift.TServiceClient.sendBase(TServiceClient.java:62)
at
com.facebook.fb303.FacebookService$Client.send_shutdown(FacebookService.java:431)
at
com.facebook.fb303.FacebookService$Client.shutdown(FacebookService.java:425)
at
org.apache.hadoop.hive.metastore.HiveMetaStoreClient.close(HiveMetaStoreClient.java:435)
at
org.apache.hadoop.hive.ql.lockmgr.DbTxnManager.destruct(DbTxnManager.java:304)
at
org.apache.hadoop.hive.ql.lockmgr.HiveTxnManagerImpl.finalize(HiveTxnManagerImpl.java:44)
at java.lang.ref.Finalizer.invokeFinalizeMethod(Native Method)
at java.lang.ref.Finalizer.runFinalizer(Finalizer.java:101)
at java.lang.ref.Finalizer.access$100(Finalizer.java:32)
at java.lang.ref.Finalizer$FinalizerThread.run(Finalizer.java:190)
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-7883) DBTxnManager trying to close already closed metastore client connection
[
https://issues.apache.org/jira/browse/HIVE-7883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Gates updated HIVE-7883:
-
Status: Patch Available (was: Open)
DBTxnManager trying to close already closed metastore client connection
---
Key: HIVE-7883
URL: https://issues.apache.org/jira/browse/HIVE-7883
Project: Hive
Issue Type: Bug
Components: Metastore, Transactions
Affects Versions: 0.14.0
Reporter: Mostafa Mokhtar
Assignee: Alan Gates
Attachments: HIVE-7883.patch
You will find following log message :
{code}
ERROR hive.metastore: Unable to shutdown local metastore client
org.apache.thrift.transport.TTransportException: Cannot write to null
outputStream
at
org.apache.thrift.transport.TIOStreamTransport.write(TIOStreamTransport.java:142)
at
org.apache.thrift.protocol.TBinaryProtocol.writeI32(TBinaryProtocol.java:163)
at
org.apache.thrift.protocol.TBinaryProtocol.writeMessageBegin(TBinaryProtocol.java:91)
at org.apache.thrift.TServiceClient.sendBase(TServiceClient.java:62)
at
com.facebook.fb303.FacebookService$Client.send_shutdown(FacebookService.java:431)
at
com.facebook.fb303.FacebookService$Client.shutdown(FacebookService.java:425)
at
org.apache.hadoop.hive.metastore.HiveMetaStoreClient.close(HiveMetaStoreClient.java:435)
at
org.apache.hadoop.hive.ql.lockmgr.DbTxnManager.destruct(DbTxnManager.java:304)
at
org.apache.hadoop.hive.ql.lockmgr.HiveTxnManagerImpl.finalize(HiveTxnManagerImpl.java:44)
at java.lang.ref.Finalizer.invokeFinalizeMethod(Native Method)
at java.lang.ref.Finalizer.runFinalizer(Finalizer.java:101)
at java.lang.ref.Finalizer.access$100(Finalizer.java:32)
at java.lang.ref.Finalizer$FinalizerThread.run(Finalizer.java:190)
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (HIVE-8191) Update and delete on tables with non Acid output formats gives runtime error
Alan Gates created HIVE-8191:
Summary: Update and delete on tables with non Acid output formats
gives runtime error
Key: HIVE-8191
URL: https://issues.apache.org/jira/browse/HIVE-8191
Project: Hive
Issue Type: Bug
Components: Query Processor
Affects Versions: 0.14.0
Reporter: Alan Gates
Assignee: Alan Gates
Priority: Critical
{code}
create table not_an_acid_table(a int, b varchar(128));
insert into table not_an_acid_table select cint, cast(cstring1 as varchar(128))
from alltypesorc where cint is not null order by cint limit 10;
delete from not_an_acid_table where b = '0ruyd6Y50JpdGRf6HqD';
{code}
This generates a runtime error. It should get a compile error instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8191) Update and delete on tables with non Acid output formats gives runtime error
[
https://issues.apache.org/jira/browse/HIVE-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Gates updated HIVE-8191:
-
Attachment: HIVE-8191.patch
Added a check when updating and deleting that the table is acid compliant.
Update and delete on tables with non Acid output formats gives runtime error
Key: HIVE-8191
URL: https://issues.apache.org/jira/browse/HIVE-8191
Project: Hive
Issue Type: Bug
Components: Query Processor
Affects Versions: 0.14.0
Reporter: Alan Gates
Assignee: Alan Gates
Priority: Critical
Attachments: HIVE-8191.patch
{code}
create table not_an_acid_table(a int, b varchar(128));
insert into table not_an_acid_table select cint, cast(cstring1 as
varchar(128)) from alltypesorc where cint is not null order by cint limit 10;
delete from not_an_acid_table where b = '0ruyd6Y50JpdGRf6HqD';
{code}
This generates a runtime error. It should get a compile error instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8191) Update and delete on tables with non Acid output formats gives runtime error
[
https://issues.apache.org/jira/browse/HIVE-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Gates updated HIVE-8191:
-
Status: Patch Available (was: Open)
Update and delete on tables with non Acid output formats gives runtime error
Key: HIVE-8191
URL: https://issues.apache.org/jira/browse/HIVE-8191
Project: Hive
Issue Type: Bug
Components: Query Processor
Affects Versions: 0.14.0
Reporter: Alan Gates
Assignee: Alan Gates
Priority: Critical
Attachments: HIVE-8191.patch
{code}
create table not_an_acid_table(a int, b varchar(128));
insert into table not_an_acid_table select cint, cast(cstring1 as
varchar(128)) from alltypesorc where cint is not null order by cint limit 10;
delete from not_an_acid_table where b = '0ruyd6Y50JpdGRf6HqD';
{code}
This generates a runtime error. It should get a compile error instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8105) booleans and nulls not handled properly in insert/values
[ https://issues.apache.org/jira/browse/HIVE-8105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-8105: - Status: Open (was: Patch Available) booleans and nulls not handled properly in insert/values Key: HIVE-8105 URL: https://issues.apache.org/jira/browse/HIVE-8105 Project: Hive Issue Type: Bug Components: Query Processor Affects Versions: 0.14.0 Reporter: Alan Gates Assignee: Alan Gates Priority: Critical Attachments: HIVE-8105.2.patch, HIVE-8105.2.patch, HIVE-8105.patch Doing an insert/values with a boolean always results in a value of true, regardless of whether true or false is given in the query. Doing an insert/values with a null for a column value results in a semantic error. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8105) booleans and nulls not handled properly in insert/values
[ https://issues.apache.org/jira/browse/HIVE-8105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-8105: - Attachment: HIVE-8105.3.patch Re-attaching the patch to get a new run. I'm 90% sure Owen's checkin of HIVE-6936 will fix this, but want to re-run the tests to be sure. booleans and nulls not handled properly in insert/values Key: HIVE-8105 URL: https://issues.apache.org/jira/browse/HIVE-8105 Project: Hive Issue Type: Bug Components: Query Processor Affects Versions: 0.14.0 Reporter: Alan Gates Assignee: Alan Gates Priority: Critical Attachments: HIVE-8105.2.patch, HIVE-8105.2.patch, HIVE-8105.3.patch, HIVE-8105.patch Doing an insert/values with a boolean always results in a value of true, regardless of whether true or false is given in the query. Doing an insert/values with a null for a column value results in a semantic error. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8105) booleans and nulls not handled properly in insert/values
[ https://issues.apache.org/jira/browse/HIVE-8105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-8105: - Status: Patch Available (was: Open) booleans and nulls not handled properly in insert/values Key: HIVE-8105 URL: https://issues.apache.org/jira/browse/HIVE-8105 Project: Hive Issue Type: Bug Components: Query Processor Affects Versions: 0.14.0 Reporter: Alan Gates Assignee: Alan Gates Priority: Critical Attachments: HIVE-8105.2.patch, HIVE-8105.2.patch, HIVE-8105.3.patch, HIVE-8105.patch Doing an insert/values with a boolean always results in a value of true, regardless of whether true or false is given in the query. Doing an insert/values with a null for a column value results in a semantic error. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-8104) Insert statements against ACID tables NPE when vectorization is on
[ https://issues.apache.org/jira/browse/HIVE-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141501#comment-14141501 ] Alan Gates commented on HIVE-8104: -- [~leftylev] yes, it should be documented. When I get to writing up the acid changes for the wiki (hopefully this weekend) I'll include this. Insert statements against ACID tables NPE when vectorization is on -- Key: HIVE-8104 URL: https://issues.apache.org/jira/browse/HIVE-8104 Project: Hive Issue Type: Bug Components: Query Processor, Vectorization Affects Versions: 0.14.0 Reporter: Alan Gates Assignee: Alan Gates Priority: Critical Fix For: 0.14.0 Attachments: HIVE-8104.2.patch, HIVE-8104.patch Doing an insert against a table that is using ACID format with the transaction manager set to DbTxnManager and vectorization turned on results in an NPE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-8201) Remove hardwiring to HiveInputFormat in acid qfile tests
Alan Gates created HIVE-8201: Summary: Remove hardwiring to HiveInputFormat in acid qfile tests Key: HIVE-8201 URL: https://issues.apache.org/jira/browse/HIVE-8201 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.14.0 Reporter: Alan Gates Assignee: Alan Gates Now that HIVE-7812 is checked in we should remove the hardwiring to HiveInputFormat for the qfile tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8201) Remove hardwiring to HiveInputFormat in acid qfile tests
[ https://issues.apache.org/jira/browse/HIVE-8201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-8201: - Component/s: (was: Tests) Turns out this is more than just a testing issue. A small change was needed to OrcInputFormat to handle the case when an update or delete is being done to a table in non-acid format. Remove hardwiring to HiveInputFormat in acid qfile tests Key: HIVE-8201 URL: https://issues.apache.org/jira/browse/HIVE-8201 Project: Hive Issue Type: Bug Affects Versions: 0.14.0 Reporter: Alan Gates Assignee: Alan Gates Now that HIVE-7812 is checked in we should remove the hardwiring to HiveInputFormat for the qfile tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8201) Remove hardwiring to HiveInputFormat in acid qfile tests
[ https://issues.apache.org/jira/browse/HIVE-8201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-8201: - Status: Patch Available (was: Open) [~owen.omalley] could you take a look at the changes to OrcInputFormat and make sure they look right? Remove hardwiring to HiveInputFormat in acid qfile tests Key: HIVE-8201 URL: https://issues.apache.org/jira/browse/HIVE-8201 Project: Hive Issue Type: Bug Affects Versions: 0.14.0 Reporter: Alan Gates Assignee: Alan Gates Attachments: HIVE-8201.patch Now that HIVE-7812 is checked in we should remove the hardwiring to HiveInputFormat for the qfile tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8201) Remove hardwiring to HiveInputFormat in acid qfile tests
[ https://issues.apache.org/jira/browse/HIVE-8201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-8201: - Attachment: HIVE-8201.patch Remove hardwiring to HiveInputFormat in acid qfile tests Key: HIVE-8201 URL: https://issues.apache.org/jira/browse/HIVE-8201 Project: Hive Issue Type: Bug Affects Versions: 0.14.0 Reporter: Alan Gates Assignee: Alan Gates Attachments: HIVE-8201.patch Now that HIVE-7812 is checked in we should remove the hardwiring to HiveInputFormat for the qfile tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-8203) ACID operations result in NPE when run through HS2
Alan Gates created HIVE-8203: Summary: ACID operations result in NPE when run through HS2 Key: HIVE-8203 URL: https://issues.apache.org/jira/browse/HIVE-8203 Project: Hive Issue Type: Bug Components: Transactions Affects Versions: 0.14.0 Reporter: Alan Gates Assignee: Alan Gates Priority: Critical When accessing Hive via HS2, any operation requiring the DbTxnManager results in an NPE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-8203) ACID operations result in NPE when run through HS2
[
https://issues.apache.org/jira/browse/HIVE-8203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141630#comment-14141630
]
Alan Gates commented on HIVE-8203:
--
An example stack:
{noformat}
org.apache.hive.service.cli.HiveSQLException: Error while compiling statement:
FAILED: NullPointerException null
at
org.apache.hive.service.cli.operation.Operation.toSQLException(Operation.java:314)
at
org.apache.hive.service.cli.operation.SQLOperation.prepare(SQLOperation.java:102)
at
org.apache.hive.service.cli.operation.SQLOperation.runInternal(SQLOperation.java:171)
at
org.apache.hive.service.cli.operation.Operation.run(Operation.java:256)
at
org.apache.hive.service.cli.session.HiveSessionImpl.executeStatementInternal(HiveSessionImpl.java:372)
at
org.apache.hive.service.cli.session.HiveSessionImpl.executeStatementAsync(HiveSessionImpl.java:359)
at
org.apache.hive.service.cli.CLIService.executeStatementAsync(CLIService.java:243)
at
org.apache.hive.service.cli.thrift.ThriftCLIService.ExecuteStatement(ThriftCLIService.java:339)
at
org.apache.hive.service.cli.thrift.TCLIService$Processor$ExecuteStatement.getResult(TCLIService.java:1313)
at
org.apache.hive.service.cli.thrift.TCLIService$Processor$ExecuteStatement.getResult(TCLIService.java:1298)
at org.apache.thrift.ProcessFunction.process(ProcessFunction.java:39)
at org.apache.thrift.TBaseProcessor.process(TBaseProcessor.java:39)
at
org.apache.hive.service.auth.TSetIpAddressProcessor.process(TSetIpAddressProcessor.java:57)
at
org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:206)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.NullPointerException
at
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.getAcidType(SemanticAnalyzer.java:11925)
at
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genFileSinkPlan(SemanticAnalyzer.java:5867)
at
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genPostGroupByBodyPlan(SemanticAnalyzer.java:8728)
at
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genBodyPlan(SemanticAnalyzer.java:8619)
at
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genPlan(SemanticAnalyzer.java:9449)
at
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.analyzeInternal(SemanticAnalyzer.java:9702)
at
org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:217)
at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:407)
at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:303)
at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1058)
at org.apache.hadoop.hive.ql.Driver.compileAndRespond(Driver.java:1052)
at
org.apache.hive.service.cli.operation.SQLOperation.prepare(SQLOperation.java:100)
... 15 more
{noformat}
ACID operations result in NPE when run through HS2
--
Key: HIVE-8203
URL: https://issues.apache.org/jira/browse/HIVE-8203
Project: Hive
Issue Type: Bug
Components: Transactions
Affects Versions: 0.14.0
Reporter: Alan Gates
Assignee: Alan Gates
Priority: Critical
When accessing Hive via HS2, any operation requiring the DbTxnManager results
in an NPE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-7790) Update privileges to check for update and delete
[ https://issues.apache.org/jira/browse/HIVE-7790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14139165#comment-14139165 ] Alan Gates commented on HIVE-7790: -- Fixed minor nit for testing. None of the unit test failures are related. Update privileges to check for update and delete Key: HIVE-7790 URL: https://issues.apache.org/jira/browse/HIVE-7790 Project: Hive Issue Type: Sub-task Reporter: Alan Gates Assignee: Alan Gates Attachments: HIVE-7790.2.patch, HIVE-7790.3.patch, HIVE-7790.patch In the new SQLStdAuth scheme, we need to add UPDATE and DELETE as operations and add ability check for them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-7790) Update privileges to check for update and delete
[ https://issues.apache.org/jira/browse/HIVE-7790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-7790: - Resolution: Fixed Fix Version/s: 0.14.0 Status: Resolved (was: Patch Available) Patch 3 committed. Thank you Thejas for all of the reviews and feedback. Update privileges to check for update and delete Key: HIVE-7790 URL: https://issues.apache.org/jira/browse/HIVE-7790 Project: Hive Issue Type: Sub-task Reporter: Alan Gates Assignee: Alan Gates Fix For: 0.14.0 Attachments: HIVE-7790.2.patch, HIVE-7790.3.patch, HIVE-7790.patch In the new SQLStdAuth scheme, we need to add UPDATE and DELETE as operations and add ability check for them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-8169) Windows: alter table ..set location from hcatalog failed with NullPointerException
[ https://issues.apache.org/jira/browse/HIVE-8169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14139228#comment-14139228 ] Alan Gates commented on HIVE-8169: -- Change looks fine. Is there a way to add a unit test for this? Windows: alter table ..set location from hcatalog failed with NullPointerException -- Key: HIVE-8169 URL: https://issues.apache.org/jira/browse/HIVE-8169 Project: Hive Issue Type: Bug Components: HCatalog Affects Versions: 0.14.0 Environment: Windows Server 2008 R2 Reporter: Xiaobing Zhou Assignee: Xiaobing Zhou Attachments: HIVE-8169.1.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-8169) Windows: alter table ..set location from hcatalog failed with NullPointerException
[ https://issues.apache.org/jira/browse/HIVE-8169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14139260#comment-14139260 ] Alan Gates commented on HIVE-8169: -- Do you mean it failed to catch this case? If so, it isn't testing this. Windows: alter table ..set location from hcatalog failed with NullPointerException -- Key: HIVE-8169 URL: https://issues.apache.org/jira/browse/HIVE-8169 Project: Hive Issue Type: Bug Components: HCatalog Affects Versions: 0.14.0 Environment: Windows Server 2008 R2 Reporter: Xiaobing Zhou Assignee: Xiaobing Zhou Attachments: HIVE-8169.1.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8107) Bad error message for non-existent table in update and delete
[
https://issues.apache.org/jira/browse/HIVE-8107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Gates updated HIVE-8107:
-
Resolution: Fixed
Fix Version/s: 0.14.0
Status: Resolved (was: Patch Available)
Patch checked in. Thank you Eugene for the review.
Bad error message for non-existent table in update and delete
-
Key: HIVE-8107
URL: https://issues.apache.org/jira/browse/HIVE-8107
Project: Hive
Issue Type: Bug
Components: Query Processor
Affects Versions: 0.14.0
Reporter: Alan Gates
Assignee: Alan Gates
Fix For: 0.14.0
Attachments: HIVE-8107.patch
update no_such_table set x = 3;
produces an error message like:
{noformat}
2014-09-12 19:45:00,138 ERROR [main]: ql.Driver
(SessionState.java:printError(824)) - FAILED: SemanticException [Error
10290]: Encountered parse error while parsing rewritten update or delete query
org.apache.hadoop.hive.ql.parse.SemanticException: Encountered parse error
while parsing rewritten update or delete query
at
org.apache.hadoop.hive.ql.parse.UpdateDeleteSemanticAnalyzer.reparseAndSuperAnalyze(UpdateDeleteSemanticAnalyzer.java:130)
at
org.apache.hadoop.hive.ql.parse.UpdateDeleteSemanticAnalyzer.analyzeDelete(UpdateDeleteSemanticAnalyzer.java:97)
at
org.apache.hadoop.hive.ql.parse.UpdateDeleteSemanticAnalyzer.analyzeInternal(UpdateDeleteSemanticAnalyzer.java:66)
at
org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:217)
at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:406)
at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:302)
at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1051)
at org.apache.hadoop.hive.ql.Driver.runInternal(Driver.java:1121)
at org.apache.hadoop.hive.ql.Driver.run(Driver.java:988)
at org.apache.hadoop.hive.ql.Driver.run(Driver.java:978)
at
org.apache.hadoop.hive.cli.CliDriver.processLocalCmd(CliDriver.java:246)
at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:198)
at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:408)
at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:344)
at
org.apache.hadoop.hive.cli.CliDriver.processReader(CliDriver.java:441)
at org.apache.hadoop.hive.cli.CliDriver.processFile(CliDriver.java:457)
at
org.apache.hadoop.hive.cli.CliDriver.executeDriver(CliDriver.java:737)
at org.apache.hadoop.hive.cli.CliDriver.run(CliDriver.java:675)
at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:614)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.apache.hadoop.util.RunJar.run(RunJar.java:221)
at org.apache.hadoop.util.RunJar.main(RunJar.java:136)
Caused by: org.apache.hadoop.hive.ql.metadata.InvalidTableException: Table
not found no_such_table
at org.apache.hadoop.hive.ql.metadata.Hive.getTable(Hive.java:1008)
at org.apache.hadoop.hive.ql.metadata.Hive.getTable(Hive.java:978)
at
org.apache.hadoop.hive.ql.parse.UpdateDeleteSemanticAnalyzer.reparseAndSuperAnalyze(UpdateDeleteSemanticAnalyzer.java:128)
... 24 more
{noformat}
It should give something much cleaner, or at least push the Table not found
message to the top rather than bury it in an exception stack.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8149) hive.optimize.reducededuplication should be set to false for IUD ops
[ https://issues.apache.org/jira/browse/HIVE-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-8149: - Status: Patch Available (was: Open) hive.optimize.reducededuplication should be set to false for IUD ops Key: HIVE-8149 URL: https://issues.apache.org/jira/browse/HIVE-8149 Project: Hive Issue Type: Bug Components: Query Processor Affects Versions: 0.14.0 Reporter: Eugene Koifman Assignee: Alan Gates Attachments: HIVE-8149.patch this optimizer causes both old and new rows to show up in a select after update (for tables involving few rows) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8149) hive.optimize.reducededuplication should be set to false for IUD ops
[ https://issues.apache.org/jira/browse/HIVE-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-8149: - Attachment: HIVE-8149.patch hive.optimize.reducededuplication should be set to false for IUD ops Key: HIVE-8149 URL: https://issues.apache.org/jira/browse/HIVE-8149 Project: Hive Issue Type: Bug Components: Query Processor Affects Versions: 0.14.0 Reporter: Eugene Koifman Assignee: Alan Gates Attachments: HIVE-8149.patch this optimizer causes both old and new rows to show up in a select after update (for tables involving few rows) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8105) booleans and nulls not handled properly in insert/values
[ https://issues.apache.org/jira/browse/HIVE-8105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-8105: - Status: Patch Available (was: Open) booleans and nulls not handled properly in insert/values Key: HIVE-8105 URL: https://issues.apache.org/jira/browse/HIVE-8105 Project: Hive Issue Type: Bug Components: Query Processor Affects Versions: 0.14.0 Reporter: Alan Gates Assignee: Alan Gates Priority: Critical Attachments: HIVE-8105.2.patch, HIVE-8105.2.patch, HIVE-8105.patch Doing an insert/values with a boolean always results in a value of true, regardless of whether true or false is given in the query. Doing an insert/values with a null for a column value results in a semantic error. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8105) booleans and nulls not handled properly in insert/values
[ https://issues.apache.org/jira/browse/HIVE-8105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-8105: - Attachment: HIVE-8105.2.patch Turns out the right thing to do for null in text format is \N, not (thanks to [~owen.omalley] for pointing this out). A new patch that properly encodes the nulls. booleans and nulls not handled properly in insert/values Key: HIVE-8105 URL: https://issues.apache.org/jira/browse/HIVE-8105 Project: Hive Issue Type: Bug Components: Query Processor Affects Versions: 0.14.0 Reporter: Alan Gates Assignee: Alan Gates Priority: Critical Attachments: HIVE-8105.2.patch, HIVE-8105.2.patch, HIVE-8105.patch Doing an insert/values with a boolean always results in a value of true, regardless of whether true or false is given in the query. Doing an insert/values with a null for a column value results in a semantic error. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8103) Read ACID tables with FetchOperator returns no rows
[
https://issues.apache.org/jira/browse/HIVE-8103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Gates updated HIVE-8103:
-
Resolution: Fixed
Fix Version/s: 0.14.0
Status: Resolved (was: Patch Available)
Patch checked in. Thank you Ashutosh for the review.
Read ACID tables with FetchOperator returns no rows
---
Key: HIVE-8103
URL: https://issues.apache.org/jira/browse/HIVE-8103
Project: Hive
Issue Type: Bug
Affects Versions: 0.14.0
Reporter: Alan Gates
Assignee: Alan Gates
Priority: Critical
Fix For: 0.14.0
Attachments: HIVE-8103.patch
After inserting records into a table that uses OrcOutputFormat with the
transaction manager set to DbTxnManager, {{select count ( * )}} will return
the number of rows inserted, while {{select *}} returns nothing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8105) booleans and nulls not handled properly in insert/values
[ https://issues.apache.org/jira/browse/HIVE-8105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-8105: - Status: Open (was: Patch Available) booleans and nulls not handled properly in insert/values Key: HIVE-8105 URL: https://issues.apache.org/jira/browse/HIVE-8105 Project: Hive Issue Type: Bug Components: Query Processor Affects Versions: 0.14.0 Reporter: Alan Gates Assignee: Alan Gates Priority: Critical Attachments: HIVE-8105.2.patch, HIVE-8105.patch Doing an insert/values with a boolean always results in a value of true, regardless of whether true or false is given in the query. Doing an insert/values with a null for a column value results in a semantic error. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-8105) booleans and nulls not handled properly in insert/values
[ https://issues.apache.org/jira/browse/HIVE-8105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14137320#comment-14137320 ] Alan Gates commented on HIVE-8105: -- I thought it was just boolean that wouldn't handle null properly here. But you're right, string doesn't either. So I agree we should disable the null handling for now. I'll rework this patch to just fix the true/false issue and file a separate JIRA to fix the null issue later. booleans and nulls not handled properly in insert/values Key: HIVE-8105 URL: https://issues.apache.org/jira/browse/HIVE-8105 Project: Hive Issue Type: Bug Components: Query Processor Affects Versions: 0.14.0 Reporter: Alan Gates Assignee: Alan Gates Priority: Critical Attachments: HIVE-8105.2.patch, HIVE-8105.patch Doing an insert/values with a boolean always results in a value of true, regardless of whether true or false is given in the query. Doing an insert/values with a null for a column value results in a semantic error. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-8104) Insert statements against ACID tables NPE when vectorization is on
[ https://issues.apache.org/jira/browse/HIVE-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14138284#comment-14138284 ] Alan Gates commented on HIVE-8104: -- TestOrcHCatLoader test issues are not related to this patch. Insert statements against ACID tables NPE when vectorization is on -- Key: HIVE-8104 URL: https://issues.apache.org/jira/browse/HIVE-8104 Project: Hive Issue Type: Bug Components: Query Processor, Vectorization Affects Versions: 0.14.0 Reporter: Alan Gates Assignee: Alan Gates Priority: Critical Attachments: HIVE-8104.2.patch, HIVE-8104.patch Doing an insert against a table that is using ACID format with the transaction manager set to DbTxnManager and vectorization turned on results in an NPE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8104) Insert statements against ACID tables NPE when vectorization is on
[ https://issues.apache.org/jira/browse/HIVE-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-8104: - Resolution: Fixed Fix Version/s: 0.14.0 Status: Resolved (was: Patch Available) Patch checked in. Thanks Eugene for the review. Insert statements against ACID tables NPE when vectorization is on -- Key: HIVE-8104 URL: https://issues.apache.org/jira/browse/HIVE-8104 Project: Hive Issue Type: Bug Components: Query Processor, Vectorization Affects Versions: 0.14.0 Reporter: Alan Gates Assignee: Alan Gates Priority: Critical Fix For: 0.14.0 Attachments: HIVE-8104.2.patch, HIVE-8104.patch Doing an insert against a table that is using ACID format with the transaction manager set to DbTxnManager and vectorization turned on results in an NPE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-7790) Update privileges to check for update and delete
[ https://issues.apache.org/jira/browse/HIVE-7790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-7790: - Status: Open (was: Patch Available) Canceling patch to address Thejas' second round of comments. Update privileges to check for update and delete Key: HIVE-7790 URL: https://issues.apache.org/jira/browse/HIVE-7790 Project: Hive Issue Type: Sub-task Reporter: Alan Gates Assignee: Alan Gates Attachments: HIVE-7790.2.patch, HIVE-7790.patch In the new SQLStdAuth scheme, we need to add UPDATE and DELETE as operations and add ability check for them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-7790) Update privileges to check for update and delete
[ https://issues.apache.org/jira/browse/HIVE-7790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-7790: - Attachment: HIVE-7790.3.patch New patch with latest round of comments addressed. Update privileges to check for update and delete Key: HIVE-7790 URL: https://issues.apache.org/jira/browse/HIVE-7790 Project: Hive Issue Type: Sub-task Reporter: Alan Gates Assignee: Alan Gates Attachments: HIVE-7790.2.patch, HIVE-7790.3.patch, HIVE-7790.patch In the new SQLStdAuth scheme, we need to add UPDATE and DELETE as operations and add ability check for them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8105) booleans and nulls not handled properly in insert/values
[ https://issues.apache.org/jira/browse/HIVE-8105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-8105: - Status: Open (was: Patch Available) Forgot to regenerate results for tez qfile test. booleans and nulls not handled properly in insert/values Key: HIVE-8105 URL: https://issues.apache.org/jira/browse/HIVE-8105 Project: Hive Issue Type: Bug Components: Query Processor Affects Versions: 0.14.0 Reporter: Alan Gates Assignee: Alan Gates Priority: Critical Attachments: HIVE-8105.2.patch, HIVE-8105.patch Doing an insert/values with a boolean always results in a value of true, regardless of whether true or false is given in the query. Doing an insert/values with a null for a column value results in a semantic error. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8105) booleans and nulls not handled properly in insert/values
[ https://issues.apache.org/jira/browse/HIVE-8105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-8105: - Attachment: HIVE-8105.2.patch New patch with new tez qfile expected results. booleans and nulls not handled properly in insert/values Key: HIVE-8105 URL: https://issues.apache.org/jira/browse/HIVE-8105 Project: Hive Issue Type: Bug Components: Query Processor Affects Versions: 0.14.0 Reporter: Alan Gates Assignee: Alan Gates Priority: Critical Attachments: HIVE-8105.2.patch, HIVE-8105.patch Doing an insert/values with a boolean always results in a value of true, regardless of whether true or false is given in the query. Doing an insert/values with a null for a column value results in a semantic error. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8105) booleans and nulls not handled properly in insert/values
[ https://issues.apache.org/jira/browse/HIVE-8105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-8105: - Status: Patch Available (was: Open) booleans and nulls not handled properly in insert/values Key: HIVE-8105 URL: https://issues.apache.org/jira/browse/HIVE-8105 Project: Hive Issue Type: Bug Components: Query Processor Affects Versions: 0.14.0 Reporter: Alan Gates Assignee: Alan Gates Priority: Critical Attachments: HIVE-8105.2.patch, HIVE-8105.patch Doing an insert/values with a boolean always results in a value of true, regardless of whether true or false is given in the query. Doing an insert/values with a null for a column value results in a semantic error. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8104) Insert statements against ACID tables NPE when vectorization is on
[ https://issues.apache.org/jira/browse/HIVE-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-8104: - Status: Open (was: Patch Available) Insert statements against ACID tables NPE when vectorization is on -- Key: HIVE-8104 URL: https://issues.apache.org/jira/browse/HIVE-8104 Project: Hive Issue Type: Bug Components: Query Processor, Vectorization Affects Versions: 0.14.0 Reporter: Alan Gates Assignee: Alan Gates Priority: Critical Attachments: HIVE-8104.patch Doing an insert against a table that is using ACID format with the transaction manager set to DbTxnManager and vectorization turned on results in an NPE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-8104) Insert statements against ACID tables NPE when vectorization is on
[ https://issues.apache.org/jira/browse/HIVE-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14136218#comment-14136218 ] Alan Gates commented on HIVE-8104: -- I'm 90% certain that these failures are unrelated to my patch. Looking at the error logs it appears the tests lost connectivity to Derby for a bit. The tests pass for me on Linux and Mac. But, as these tests don't usually fail and they are in the same general area I'm going to cancel the patch and reload the same patch to get a new run. Insert statements against ACID tables NPE when vectorization is on -- Key: HIVE-8104 URL: https://issues.apache.org/jira/browse/HIVE-8104 Project: Hive Issue Type: Bug Components: Query Processor, Vectorization Affects Versions: 0.14.0 Reporter: Alan Gates Assignee: Alan Gates Priority: Critical Attachments: HIVE-8104.patch Doing an insert against a table that is using ACID format with the transaction manager set to DbTxnManager and vectorization turned on results in an NPE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8104) Insert statements against ACID tables NPE when vectorization is on
[ https://issues.apache.org/jira/browse/HIVE-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-8104: - Attachment: HIVE-8104.2.patch Same patch as the first one, just reloading for a re-run. Insert statements against ACID tables NPE when vectorization is on -- Key: HIVE-8104 URL: https://issues.apache.org/jira/browse/HIVE-8104 Project: Hive Issue Type: Bug Components: Query Processor, Vectorization Affects Versions: 0.14.0 Reporter: Alan Gates Assignee: Alan Gates Priority: Critical Attachments: HIVE-8104.2.patch, HIVE-8104.patch Doing an insert against a table that is using ACID format with the transaction manager set to DbTxnManager and vectorization turned on results in an NPE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8104) Insert statements against ACID tables NPE when vectorization is on
[ https://issues.apache.org/jira/browse/HIVE-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-8104: - Status: Patch Available (was: Open) Insert statements against ACID tables NPE when vectorization is on -- Key: HIVE-8104 URL: https://issues.apache.org/jira/browse/HIVE-8104 Project: Hive Issue Type: Bug Components: Query Processor, Vectorization Affects Versions: 0.14.0 Reporter: Alan Gates Assignee: Alan Gates Priority: Critical Attachments: HIVE-8104.2.patch, HIVE-8104.patch Doing an insert against a table that is using ACID format with the transaction manager set to DbTxnManager and vectorization turned on results in an NPE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-8107) Bad error message for non-existent table in update and delete
[
https://issues.apache.org/jira/browse/HIVE-8107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14136222#comment-14136222
]
Alan Gates commented on HIVE-8107:
--
I don't believe this test failure is related to my patch. It's in a completely
different area of the code, and this test fails for me in trunk.
Bad error message for non-existent table in update and delete
-
Key: HIVE-8107
URL: https://issues.apache.org/jira/browse/HIVE-8107
Project: Hive
Issue Type: Bug
Components: Query Processor
Affects Versions: 0.14.0
Reporter: Alan Gates
Assignee: Alan Gates
Attachments: HIVE-8107.patch
update no_such_table set x = 3;
produces an error message like:
{noformat}
2014-09-12 19:45:00,138 ERROR [main]: ql.Driver
(SessionState.java:printError(824)) - FAILED: SemanticException [Error
10290]: Encountered parse error while parsing rewritten update or delete query
org.apache.hadoop.hive.ql.parse.SemanticException: Encountered parse error
while parsing rewritten update or delete query
at
org.apache.hadoop.hive.ql.parse.UpdateDeleteSemanticAnalyzer.reparseAndSuperAnalyze(UpdateDeleteSemanticAnalyzer.java:130)
at
org.apache.hadoop.hive.ql.parse.UpdateDeleteSemanticAnalyzer.analyzeDelete(UpdateDeleteSemanticAnalyzer.java:97)
at
org.apache.hadoop.hive.ql.parse.UpdateDeleteSemanticAnalyzer.analyzeInternal(UpdateDeleteSemanticAnalyzer.java:66)
at
org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:217)
at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:406)
at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:302)
at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1051)
at org.apache.hadoop.hive.ql.Driver.runInternal(Driver.java:1121)
at org.apache.hadoop.hive.ql.Driver.run(Driver.java:988)
at org.apache.hadoop.hive.ql.Driver.run(Driver.java:978)
at
org.apache.hadoop.hive.cli.CliDriver.processLocalCmd(CliDriver.java:246)
at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:198)
at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:408)
at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:344)
at
org.apache.hadoop.hive.cli.CliDriver.processReader(CliDriver.java:441)
at org.apache.hadoop.hive.cli.CliDriver.processFile(CliDriver.java:457)
at
org.apache.hadoop.hive.cli.CliDriver.executeDriver(CliDriver.java:737)
at org.apache.hadoop.hive.cli.CliDriver.run(CliDriver.java:675)
at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:614)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.apache.hadoop.util.RunJar.run(RunJar.java:221)
at org.apache.hadoop.util.RunJar.main(RunJar.java:136)
Caused by: org.apache.hadoop.hive.ql.metadata.InvalidTableException: Table
not found no_such_table
at org.apache.hadoop.hive.ql.metadata.Hive.getTable(Hive.java:1008)
at org.apache.hadoop.hive.ql.metadata.Hive.getTable(Hive.java:978)
at
org.apache.hadoop.hive.ql.parse.UpdateDeleteSemanticAnalyzer.reparseAndSuperAnalyze(UpdateDeleteSemanticAnalyzer.java:128)
... 24 more
{noformat}
It should give something much cleaner, or at least push the Table not found
message to the top rather than bury it in an exception stack.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-7790) Update privileges to check for update and delete
[ https://issues.apache.org/jira/browse/HIVE-7790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-7790: - Status: Patch Available (was: Open) Update privileges to check for update and delete Key: HIVE-7790 URL: https://issues.apache.org/jira/browse/HIVE-7790 Project: Hive Issue Type: Sub-task Reporter: Alan Gates Assignee: Alan Gates Attachments: HIVE-7790.2.patch, HIVE-7790.3.patch, HIVE-7790.patch In the new SQLStdAuth scheme, we need to add UPDATE and DELETE as operations and add ability check for them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-8152) Update with expression in set fails
Alan Gates created HIVE-8152:
Summary: Update with expression in set fails
Key: HIVE-8152
URL: https://issues.apache.org/jira/browse/HIVE-8152
Project: Hive
Issue Type: Bug
Components: Query Processor
Affects Versions: 0.14.0
Reporter: Alan Gates
Assignee: Eugene Koifman
Priority: Critical
Doing: {{update orctabsmall set age = age + 1;}} results in {{FAILED:
ParseException line 1:33 missing EOF at '+' near 'age'}}
We should be able to handle simple expressions in set clauses.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (HIVE-8103) Read ACID tables with FetchOperator returns no rows
Alan Gates created HIVE-8103:
Summary: Read ACID tables with FetchOperator returns no rows
Key: HIVE-8103
URL: https://issues.apache.org/jira/browse/HIVE-8103
Project: Hive
Issue Type: Bug
Affects Versions: 0.14.0
Reporter: Alan Gates
Assignee: Alan Gates
Priority: Critical
After inserting records into a table that uses OrcOutputFormat with the
transaction manager set to DbTxnManager, {{select count ( * )}} will return the
number of rows inserted, while {{select *}} returns nothing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-8103) Read ACID tables with FetchOperator returns no rows
[
https://issues.apache.org/jira/browse/HIVE-8103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14134166#comment-14134166
]
Alan Gates commented on HIVE-8103:
--
The issue is in FetchOperator not understanding that it needs to read ACID
compliant directories recursively.
Read ACID tables with FetchOperator returns no rows
---
Key: HIVE-8103
URL: https://issues.apache.org/jira/browse/HIVE-8103
Project: Hive
Issue Type: Bug
Affects Versions: 0.14.0
Reporter: Alan Gates
Assignee: Alan Gates
Priority: Critical
After inserting records into a table that uses OrcOutputFormat with the
transaction manager set to DbTxnManager, {{select count ( * )}} will return
the number of rows inserted, while {{select *}} returns nothing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8103) Read ACID tables with FetchOperator returns no rows
[
https://issues.apache.org/jira/browse/HIVE-8103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Gates updated HIVE-8103:
-
Attachment: HIVE-8103.patch
This patch fixes FetchOperator to always read files recursively if the
directory is in ACID format.
This steals some code from HIVE-7812, since I needed the new AcidUtils.isAcid
method that was added in that patch. If that patch is committed before this
one this patch will need to be rebased.
Read ACID tables with FetchOperator returns no rows
---
Key: HIVE-8103
URL: https://issues.apache.org/jira/browse/HIVE-8103
Project: Hive
Issue Type: Bug
Affects Versions: 0.14.0
Reporter: Alan Gates
Assignee: Alan Gates
Priority: Critical
Attachments: HIVE-8103.patch
After inserting records into a table that uses OrcOutputFormat with the
transaction manager set to DbTxnManager, {{select count ( * )}} will return
the number of rows inserted, while {{select *}} returns nothing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8103) Read ACID tables with FetchOperator returns no rows
[
https://issues.apache.org/jira/browse/HIVE-8103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Gates updated HIVE-8103:
-
Status: Patch Available (was: Open)
Read ACID tables with FetchOperator returns no rows
---
Key: HIVE-8103
URL: https://issues.apache.org/jira/browse/HIVE-8103
Project: Hive
Issue Type: Bug
Affects Versions: 0.14.0
Reporter: Alan Gates
Assignee: Alan Gates
Priority: Critical
Attachments: HIVE-8103.patch
After inserting records into a table that uses OrcOutputFormat with the
transaction manager set to DbTxnManager, {{select count ( * )}} will return
the number of rows inserted, while {{select *}} returns nothing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (HIVE-8104) Insert statements against ACID tables NPE when vectorization is on
Alan Gates created HIVE-8104: Summary: Insert statements against ACID tables NPE when vectorization is on Key: HIVE-8104 URL: https://issues.apache.org/jira/browse/HIVE-8104 Project: Hive Issue Type: Bug Components: Query Processor, Vectorization Affects Versions: 0.14.0 Reporter: Alan Gates Assignee: Alan Gates Priority: Critical Doing an insert against a table that is using ACID format with the transaction manager set to DbTxnManager and vectorization turned on results in an NPE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-8105) booleans and nulls not handled properly in insert/values
Alan Gates created HIVE-8105: Summary: booleans and nulls not handled properly in insert/values Key: HIVE-8105 URL: https://issues.apache.org/jira/browse/HIVE-8105 Project: Hive Issue Type: Bug Components: Query Processor Affects Versions: 0.14.0 Reporter: Alan Gates Assignee: Alan Gates Priority: Critical Doing an insert/values with a boolean always results in a value of true, regardless of whether true or false is given in the query. Doing an insert/values with a null for a column value results in a semantic error. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8105) booleans and nulls not handled properly in insert/values
[ https://issues.apache.org/jira/browse/HIVE-8105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-8105: - Status: Patch Available (was: Open) booleans and nulls not handled properly in insert/values Key: HIVE-8105 URL: https://issues.apache.org/jira/browse/HIVE-8105 Project: Hive Issue Type: Bug Components: Query Processor Affects Versions: 0.14.0 Reporter: Alan Gates Assignee: Alan Gates Priority: Critical Attachments: HIVE-8105.patch Doing an insert/values with a boolean always results in a value of true, regardless of whether true or false is given in the query. Doing an insert/values with a null for a column value results in a semantic error. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8105) booleans and nulls not handled properly in insert/values
[ https://issues.apache.org/jira/browse/HIVE-8105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-8105: - Attachment: HIVE-8105.patch Changes to SemanticAnalyzer to handle boolean and nulls properly, and changes to tests to confirm the fix. booleans and nulls not handled properly in insert/values Key: HIVE-8105 URL: https://issues.apache.org/jira/browse/HIVE-8105 Project: Hive Issue Type: Bug Components: Query Processor Affects Versions: 0.14.0 Reporter: Alan Gates Assignee: Alan Gates Priority: Critical Attachments: HIVE-8105.patch Doing an insert/values with a boolean always results in a value of true, regardless of whether true or false is given in the query. Doing an insert/values with a null for a column value results in a semantic error. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-8105) booleans and nulls not handled properly in insert/values
[ https://issues.apache.org/jira/browse/HIVE-8105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14134362#comment-14134362 ] Alan Gates commented on HIVE-8105: -- insert into table T values ... works by first writing the values to a file, casting a temp table over that file, and then rewriting the query to insert into table T select * from temp_table. As all of the values coming in are strings, the default Hive casting mechanisms kick in. The Hive rule for casting from boolean to string is that any string that has length 0 is true, while a zero length string is false. (See UDFToBoolean.evaluate(Text)). The ideal solution here is we need an input format that can handle these sorts of things as well as simple expressions. For example, in the current implementation we cannot handle casts or arithmetic like insert into T values (3 + 4); So yes, this is a stop gap. booleans and nulls not handled properly in insert/values Key: HIVE-8105 URL: https://issues.apache.org/jira/browse/HIVE-8105 Project: Hive Issue Type: Bug Components: Query Processor Affects Versions: 0.14.0 Reporter: Alan Gates Assignee: Alan Gates Priority: Critical Attachments: HIVE-8105.patch Doing an insert/values with a boolean always results in a value of true, regardless of whether true or false is given in the query. Doing an insert/values with a null for a column value results in a semantic error. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-8107) Bad error message for non-existent table in update and delete
Alan Gates created HIVE-8107:
Summary: Bad error message for non-existent table in update and
delete
Key: HIVE-8107
URL: https://issues.apache.org/jira/browse/HIVE-8107
Project: Hive
Issue Type: Bug
Components: Query Processor
Affects Versions: 0.14.0
Reporter: Alan Gates
Assignee: Alan Gates
update no_such_table set x = 3;
produces an error message like:
{noformat}
2014-09-12 19:45:00,138 ERROR [main]: ql.Driver
(SessionState.java:printError(824)) - FAILED: SemanticException [Error 10290]:
Encountered parse error while parsing rewritten update or delete query
org.apache.hadoop.hive.ql.parse.SemanticException: Encountered parse error
while parsing rewritten update or delete query
at
org.apache.hadoop.hive.ql.parse.UpdateDeleteSemanticAnalyzer.reparseAndSuperAnalyze(UpdateDeleteSemanticAnalyzer.java:130)
at
org.apache.hadoop.hive.ql.parse.UpdateDeleteSemanticAnalyzer.analyzeDelete(UpdateDeleteSemanticAnalyzer.java:97)
at
org.apache.hadoop.hive.ql.parse.UpdateDeleteSemanticAnalyzer.analyzeInternal(UpdateDeleteSemanticAnalyzer.java:66)
at
org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:217)
at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:406)
at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:302)
at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1051)
at org.apache.hadoop.hive.ql.Driver.runInternal(Driver.java:1121)
at org.apache.hadoop.hive.ql.Driver.run(Driver.java:988)
at org.apache.hadoop.hive.ql.Driver.run(Driver.java:978)
at
org.apache.hadoop.hive.cli.CliDriver.processLocalCmd(CliDriver.java:246)
at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:198)
at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:408)
at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:344)
at
org.apache.hadoop.hive.cli.CliDriver.processReader(CliDriver.java:441)
at org.apache.hadoop.hive.cli.CliDriver.processFile(CliDriver.java:457)
at
org.apache.hadoop.hive.cli.CliDriver.executeDriver(CliDriver.java:737)
at org.apache.hadoop.hive.cli.CliDriver.run(CliDriver.java:675)
at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:614)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.apache.hadoop.util.RunJar.run(RunJar.java:221)
at org.apache.hadoop.util.RunJar.main(RunJar.java:136)
Caused by: org.apache.hadoop.hive.ql.metadata.InvalidTableException: Table not
found no_such_table
at org.apache.hadoop.hive.ql.metadata.Hive.getTable(Hive.java:1008)
at org.apache.hadoop.hive.ql.metadata.Hive.getTable(Hive.java:978)
at
org.apache.hadoop.hive.ql.parse.UpdateDeleteSemanticAnalyzer.reparseAndSuperAnalyze(UpdateDeleteSemanticAnalyzer.java:128)
... 24 more
{noformat}
It should give something much cleaner, or at least push the Table not found
message to the top rather than bury it in an exception stack.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8107) Bad error message for non-existent table in update and delete
[
https://issues.apache.org/jira/browse/HIVE-8107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Gates updated HIVE-8107:
-
Status: Patch Available (was: Open)
Bad error message for non-existent table in update and delete
-
Key: HIVE-8107
URL: https://issues.apache.org/jira/browse/HIVE-8107
Project: Hive
Issue Type: Bug
Components: Query Processor
Affects Versions: 0.14.0
Reporter: Alan Gates
Assignee: Alan Gates
Attachments: HIVE-8107.patch
update no_such_table set x = 3;
produces an error message like:
{noformat}
2014-09-12 19:45:00,138 ERROR [main]: ql.Driver
(SessionState.java:printError(824)) - FAILED: SemanticException [Error
10290]: Encountered parse error while parsing rewritten update or delete query
org.apache.hadoop.hive.ql.parse.SemanticException: Encountered parse error
while parsing rewritten update or delete query
at
org.apache.hadoop.hive.ql.parse.UpdateDeleteSemanticAnalyzer.reparseAndSuperAnalyze(UpdateDeleteSemanticAnalyzer.java:130)
at
org.apache.hadoop.hive.ql.parse.UpdateDeleteSemanticAnalyzer.analyzeDelete(UpdateDeleteSemanticAnalyzer.java:97)
at
org.apache.hadoop.hive.ql.parse.UpdateDeleteSemanticAnalyzer.analyzeInternal(UpdateDeleteSemanticAnalyzer.java:66)
at
org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:217)
at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:406)
at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:302)
at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1051)
at org.apache.hadoop.hive.ql.Driver.runInternal(Driver.java:1121)
at org.apache.hadoop.hive.ql.Driver.run(Driver.java:988)
at org.apache.hadoop.hive.ql.Driver.run(Driver.java:978)
at
org.apache.hadoop.hive.cli.CliDriver.processLocalCmd(CliDriver.java:246)
at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:198)
at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:408)
at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:344)
at
org.apache.hadoop.hive.cli.CliDriver.processReader(CliDriver.java:441)
at org.apache.hadoop.hive.cli.CliDriver.processFile(CliDriver.java:457)
at
org.apache.hadoop.hive.cli.CliDriver.executeDriver(CliDriver.java:737)
at org.apache.hadoop.hive.cli.CliDriver.run(CliDriver.java:675)
at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:614)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.apache.hadoop.util.RunJar.run(RunJar.java:221)
at org.apache.hadoop.util.RunJar.main(RunJar.java:136)
Caused by: org.apache.hadoop.hive.ql.metadata.InvalidTableException: Table
not found no_such_table
at org.apache.hadoop.hive.ql.metadata.Hive.getTable(Hive.java:1008)
at org.apache.hadoop.hive.ql.metadata.Hive.getTable(Hive.java:978)
at
org.apache.hadoop.hive.ql.parse.UpdateDeleteSemanticAnalyzer.reparseAndSuperAnalyze(UpdateDeleteSemanticAnalyzer.java:128)
... 24 more
{noformat}
It should give something much cleaner, or at least push the Table not found
message to the top rather than bury it in an exception stack.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8107) Bad error message for non-existent table in update and delete
[
https://issues.apache.org/jira/browse/HIVE-8107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Gates updated HIVE-8107:
-
Attachment: HIVE-8107.patch
Bad error message for non-existent table in update and delete
-
Key: HIVE-8107
URL: https://issues.apache.org/jira/browse/HIVE-8107
Project: Hive
Issue Type: Bug
Components: Query Processor
Affects Versions: 0.14.0
Reporter: Alan Gates
Assignee: Alan Gates
Attachments: HIVE-8107.patch
update no_such_table set x = 3;
produces an error message like:
{noformat}
2014-09-12 19:45:00,138 ERROR [main]: ql.Driver
(SessionState.java:printError(824)) - FAILED: SemanticException [Error
10290]: Encountered parse error while parsing rewritten update or delete query
org.apache.hadoop.hive.ql.parse.SemanticException: Encountered parse error
while parsing rewritten update or delete query
at
org.apache.hadoop.hive.ql.parse.UpdateDeleteSemanticAnalyzer.reparseAndSuperAnalyze(UpdateDeleteSemanticAnalyzer.java:130)
at
org.apache.hadoop.hive.ql.parse.UpdateDeleteSemanticAnalyzer.analyzeDelete(UpdateDeleteSemanticAnalyzer.java:97)
at
org.apache.hadoop.hive.ql.parse.UpdateDeleteSemanticAnalyzer.analyzeInternal(UpdateDeleteSemanticAnalyzer.java:66)
at
org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:217)
at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:406)
at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:302)
at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1051)
at org.apache.hadoop.hive.ql.Driver.runInternal(Driver.java:1121)
at org.apache.hadoop.hive.ql.Driver.run(Driver.java:988)
at org.apache.hadoop.hive.ql.Driver.run(Driver.java:978)
at
org.apache.hadoop.hive.cli.CliDriver.processLocalCmd(CliDriver.java:246)
at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:198)
at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:408)
at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:344)
at
org.apache.hadoop.hive.cli.CliDriver.processReader(CliDriver.java:441)
at org.apache.hadoop.hive.cli.CliDriver.processFile(CliDriver.java:457)
at
org.apache.hadoop.hive.cli.CliDriver.executeDriver(CliDriver.java:737)
at org.apache.hadoop.hive.cli.CliDriver.run(CliDriver.java:675)
at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:614)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.apache.hadoop.util.RunJar.run(RunJar.java:221)
at org.apache.hadoop.util.RunJar.main(RunJar.java:136)
Caused by: org.apache.hadoop.hive.ql.metadata.InvalidTableException: Table
not found no_such_table
at org.apache.hadoop.hive.ql.metadata.Hive.getTable(Hive.java:1008)
at org.apache.hadoop.hive.ql.metadata.Hive.getTable(Hive.java:978)
at
org.apache.hadoop.hive.ql.parse.UpdateDeleteSemanticAnalyzer.reparseAndSuperAnalyze(UpdateDeleteSemanticAnalyzer.java:128)
... 24 more
{noformat}
It should give something much cleaner, or at least push the Table not found
message to the top rather than bury it in an exception stack.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8104) Insert statements against ACID tables NPE when vectorization is on
[ https://issues.apache.org/jira/browse/HIVE-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-8104: - Status: Patch Available (was: Open) Insert statements against ACID tables NPE when vectorization is on -- Key: HIVE-8104 URL: https://issues.apache.org/jira/browse/HIVE-8104 Project: Hive Issue Type: Bug Components: Query Processor, Vectorization Affects Versions: 0.14.0 Reporter: Alan Gates Assignee: Alan Gates Priority: Critical Attachments: HIVE-8104.patch Doing an insert against a table that is using ACID format with the transaction manager set to DbTxnManager and vectorization turned on results in an NPE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8104) Insert statements against ACID tables NPE when vectorization is on
[ https://issues.apache.org/jira/browse/HIVE-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-8104: - Attachment: HIVE-8104.patch This patch turns off vectorization when an acid operation is being performed. Insert statements against ACID tables NPE when vectorization is on -- Key: HIVE-8104 URL: https://issues.apache.org/jira/browse/HIVE-8104 Project: Hive Issue Type: Bug Components: Query Processor, Vectorization Affects Versions: 0.14.0 Reporter: Alan Gates Assignee: Alan Gates Priority: Critical Attachments: HIVE-8104.patch Doing an insert against a table that is using ACID format with the transaction manager set to DbTxnManager and vectorization turned on results in an NPE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-7790) Update privileges to check for update and delete
[ https://issues.apache.org/jira/browse/HIVE-7790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-7790: - Status: Open (was: Patch Available) Canceling patch for now as I need to rework update and delete to also require select privileges, per Thejas' comments. Update privileges to check for update and delete Key: HIVE-7790 URL: https://issues.apache.org/jira/browse/HIVE-7790 Project: Hive Issue Type: Sub-task Reporter: Alan Gates Assignee: Alan Gates Attachments: HIVE-7790.patch In the new SQLStdAuth scheme, we need to add UPDATE and DELETE as operations and add ability check for them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-7790) Update privileges to check for update and delete
[ https://issues.apache.org/jira/browse/HIVE-7790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-7790: - Attachment: HIVE-7790.2.patch New patch that adds requirement for select privilege for update and delete. Update privileges to check for update and delete Key: HIVE-7790 URL: https://issues.apache.org/jira/browse/HIVE-7790 Project: Hive Issue Type: Sub-task Reporter: Alan Gates Assignee: Alan Gates Attachments: HIVE-7790.2.patch, HIVE-7790.patch In the new SQLStdAuth scheme, we need to add UPDATE and DELETE as operations and add ability check for them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-7790) Update privileges to check for update and delete
[ https://issues.apache.org/jira/browse/HIVE-7790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-7790: - Status: Patch Available (was: Open) Update privileges to check for update and delete Key: HIVE-7790 URL: https://issues.apache.org/jira/browse/HIVE-7790 Project: Hive Issue Type: Sub-task Reporter: Alan Gates Assignee: Alan Gates Attachments: HIVE-7790.2.patch, HIVE-7790.patch In the new SQLStdAuth scheme, we need to add UPDATE and DELETE as operations and add ability check for them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7790) Update privileges to check for update and delete
[ https://issues.apache.org/jira/browse/HIVE-7790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14133402#comment-14133402 ] Alan Gates commented on HIVE-7790: -- Responses to comments on review board. One thing I think we need to clarify. It seems from your comments that you are expecting update and delete to also check for read permissions on the table, since you are wanting to check that the user has permissions on the input columns as well as the output columns. I have implemented this such that the user only needs to have update or delete permissions. If we think the user should also have read permissions, I need to make some changes. Update privileges to check for update and delete Key: HIVE-7790 URL: https://issues.apache.org/jira/browse/HIVE-7790 Project: Hive Issue Type: Sub-task Reporter: Alan Gates Assignee: Alan Gates Attachments: HIVE-7790.patch In the new SQLStdAuth scheme, we need to add UPDATE and DELETE as operations and add ability check for them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7788) Generate plans for insert, update, and delete
[ https://issues.apache.org/jira/browse/HIVE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14132700#comment-14132700 ] Alan Gates commented on HIVE-7788: -- I see these 7 tests failing on trunk as well, so I'm guessing they aren't related to this patch. Generate plans for insert, update, and delete - Key: HIVE-7788 URL: https://issues.apache.org/jira/browse/HIVE-7788 Project: Hive Issue Type: Sub-task Components: Query Processor Reporter: Alan Gates Assignee: Alan Gates Attachments: HIVE-7788.2.patch, HIVE-7788.3.patch, HIVE-7788.4.patch, HIVE-7788.WIP.patch, HIVE-7788.patch Insert plans needs to be generated differently for ACID tables, plus we need to be able to generate plans in the semantic analyzer for update and delete. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-8093) Seeing failures in tez qfile tests on trunk
Alan Gates created HIVE-8093: Summary: Seeing failures in tez qfile tests on trunk Key: HIVE-8093 URL: https://issues.apache.org/jira/browse/HIVE-8093 Project: Hive Issue Type: Bug Components: Tez Affects Versions: 0.14.0 Reporter: Alan Gates Priority: Critical We are seeing the following tests fail on trunk and in every Hive QA run: org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_metadataonly1 org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_optimize_nullscan org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_orc_merge1 org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_orc_merge5 org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_orc_merge6 org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_orc_merge7 org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_select_dummy_source -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (HIVE-8093) Seeing failures in tez qfile tests on trunk
[ https://issues.apache.org/jira/browse/HIVE-8093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates resolved HIVE-8093. -- Resolution: Duplicate Seeing failures in tez qfile tests on trunk --- Key: HIVE-8093 URL: https://issues.apache.org/jira/browse/HIVE-8093 Project: Hive Issue Type: Bug Components: Tez Affects Versions: 0.14.0 Reporter: Alan Gates Priority: Critical We are seeing the following tests fail on trunk and in every Hive QA run: org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_metadataonly1 org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_optimize_nullscan org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_orc_merge1 org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_orc_merge5 org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_orc_merge6 org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_orc_merge7 org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_select_dummy_source -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-8088) HIVE-7812 makes TestMiniTezCliDriver tests to fail
[ https://issues.apache.org/jira/browse/HIVE-8088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14132907#comment-14132907 ] Alan Gates commented on HIVE-8088: -- org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_orc_merge1 org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_orc_merge5 org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_orc_merge6 org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_orc_merge7 Also now failing. HIVE-7812 makes TestMiniTezCliDriver tests to fail -- Key: HIVE-8088 URL: https://issues.apache.org/jira/browse/HIVE-8088 Project: Hive Issue Type: Bug Affects Versions: 0.14.0 Reporter: Prasanth J Assignee: Owen O'Malley HIVE-7812 makes the following test fail in trunk org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_metadataonly1 org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_optimize_nullscan org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_select_dummy_source -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-7788) Generate plans for insert, update, and delete
[ https://issues.apache.org/jira/browse/HIVE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-7788: - Resolution: Fixed Fix Version/s: 0.14.0 Status: Resolved (was: Patch Available) Patch 4 checked in. Thank you Thejas, Eugene, and Brock for the reviews. Generate plans for insert, update, and delete - Key: HIVE-7788 URL: https://issues.apache.org/jira/browse/HIVE-7788 Project: Hive Issue Type: Sub-task Components: Query Processor Reporter: Alan Gates Assignee: Alan Gates Fix For: 0.14.0 Attachments: HIVE-7788.2.patch, HIVE-7788.3.patch, HIVE-7788.4.patch, HIVE-7788.WIP.patch, HIVE-7788.patch Insert plans needs to be generated differently for ACID tables, plus we need to be able to generate plans in the semantic analyzer for update and delete. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-7790) Update privileges to check for update and delete
[ https://issues.apache.org/jira/browse/HIVE-7790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-7790: - Status: Patch Available (was: Open) Update privileges to check for update and delete Key: HIVE-7790 URL: https://issues.apache.org/jira/browse/HIVE-7790 Project: Hive Issue Type: Sub-task Reporter: Alan Gates Assignee: Alan Gates Attachments: HIVE-7790.patch In the new SQLStdAuth scheme, we need to add UPDATE and DELETE as operations and add ability check for them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-7790) Update privileges to check for update and delete
[ https://issues.apache.org/jira/browse/HIVE-7790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-7790: - Attachment: HIVE-7790.patch Attaching a patch that adds update and delete as action and adds checks for authorization during update and delete. Also adds passing of updated columns in case authorizer wishes to check them. Update privileges to check for update and delete Key: HIVE-7790 URL: https://issues.apache.org/jira/browse/HIVE-7790 Project: Hive Issue Type: Sub-task Reporter: Alan Gates Assignee: Alan Gates Attachments: HIVE-7790.patch In the new SQLStdAuth scheme, we need to add UPDATE and DELETE as operations and add ability check for them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7790) Update privileges to check for update and delete
[ https://issues.apache.org/jira/browse/HIVE-7790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14133077#comment-14133077 ] Alan Gates commented on HIVE-7790: -- Added review https://reviews.apache.org/r/25616/ Update privileges to check for update and delete Key: HIVE-7790 URL: https://issues.apache.org/jira/browse/HIVE-7790 Project: Hive Issue Type: Sub-task Reporter: Alan Gates Assignee: Alan Gates Attachments: HIVE-7790.patch In the new SQLStdAuth scheme, we need to add UPDATE and DELETE as operations and add ability check for them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-7788) Generate plans for insert, update, and delete
[ https://issues.apache.org/jira/browse/HIVE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-7788: - Status: Open (was: Patch Available) Canceling patch as I need to fix the failing tests. Generate plans for insert, update, and delete - Key: HIVE-7788 URL: https://issues.apache.org/jira/browse/HIVE-7788 Project: Hive Issue Type: Sub-task Components: Query Processor Reporter: Alan Gates Assignee: Alan Gates Attachments: HIVE-7788.2.patch, HIVE-7788.3.patch, HIVE-7788.WIP.patch, HIVE-7788.patch Insert plans needs to be generated differently for ACID tables, plus we need to be able to generate plans in the semantic analyzer for update and delete. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-7788) Generate plans for insert, update, and delete
[ https://issues.apache.org/jira/browse/HIVE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-7788: - Attachment: HIVE-7788.4.patch Backed out the change where I used isAssignedFrom instead of equals to check whether an output format was an acid output format, as it incorrectly said all output formats were acid. Generate plans for insert, update, and delete - Key: HIVE-7788 URL: https://issues.apache.org/jira/browse/HIVE-7788 Project: Hive Issue Type: Sub-task Components: Query Processor Reporter: Alan Gates Assignee: Alan Gates Attachments: HIVE-7788.2.patch, HIVE-7788.3.patch, HIVE-7788.4.patch, HIVE-7788.WIP.patch, HIVE-7788.patch Insert plans needs to be generated differently for ACID tables, plus we need to be able to generate plans in the semantic analyzer for update and delete. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-7788) Generate plans for insert, update, and delete
[ https://issues.apache.org/jira/browse/HIVE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-7788: - Status: Patch Available (was: Open) Generate plans for insert, update, and delete - Key: HIVE-7788 URL: https://issues.apache.org/jira/browse/HIVE-7788 Project: Hive Issue Type: Sub-task Components: Query Processor Reporter: Alan Gates Assignee: Alan Gates Attachments: HIVE-7788.2.patch, HIVE-7788.3.patch, HIVE-7788.4.patch, HIVE-7788.WIP.patch, HIVE-7788.patch Insert plans needs to be generated differently for ACID tables, plus we need to be able to generate plans in the semantic analyzer for update and delete. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7788) Generate plans for insert, update, and delete
[ https://issues.apache.org/jira/browse/HIVE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14131968#comment-14131968 ] Alan Gates commented on HIVE-7788: -- Patch updated on review board. Generate plans for insert, update, and delete - Key: HIVE-7788 URL: https://issues.apache.org/jira/browse/HIVE-7788 Project: Hive Issue Type: Sub-task Components: Query Processor Reporter: Alan Gates Assignee: Alan Gates Attachments: HIVE-7788.2.patch, HIVE-7788.3.patch, HIVE-7788.4.patch, HIVE-7788.WIP.patch, HIVE-7788.patch Insert plans needs to be generated differently for ACID tables, plus we need to be able to generate plans in the semantic analyzer for update and delete. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-8041) Hadoop-2 build is broken with JDK6
[
https://issues.apache.org/jira/browse/HIVE-8041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14130037#comment-14130037
]
Alan Gates commented on HIVE-8041:
--
FWIW, it builds on my mac with JDK6. Which JDK are you seeing this with?
Hadoop-2 build is broken with JDK6
--
Key: HIVE-8041
URL: https://issues.apache.org/jira/browse/HIVE-8041
Project: Hive
Issue Type: Bug
Components: Build Infrastructure
Affects Versions: 0.14.0
Reporter: Xuefu Zhang
{code}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile)
on project hive-exec: Compilation failure
[ERROR]
/home/xzhang/apache/hive7/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFIf.java:[81,1]
illegal start of expression
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-7788) Generate plans for insert, update, and delete
[ https://issues.apache.org/jira/browse/HIVE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-7788: - Status: Open (was: Patch Available) Generate plans for insert, update, and delete - Key: HIVE-7788 URL: https://issues.apache.org/jira/browse/HIVE-7788 Project: Hive Issue Type: Sub-task Components: Query Processor Reporter: Alan Gates Assignee: Alan Gates Attachments: HIVE-7788.2.patch, HIVE-7788.WIP.patch, HIVE-7788.patch Insert plans needs to be generated differently for ACID tables, plus we need to be able to generate plans in the semantic analyzer for update and delete. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-7788) Generate plans for insert, update, and delete
[ https://issues.apache.org/jira/browse/HIVE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-7788: - Attachment: HIVE-7788.3.patch New version of the patch that addresses many of Eugene's and Thejas' comments. Generate plans for insert, update, and delete - Key: HIVE-7788 URL: https://issues.apache.org/jira/browse/HIVE-7788 Project: Hive Issue Type: Sub-task Components: Query Processor Reporter: Alan Gates Assignee: Alan Gates Attachments: HIVE-7788.2.patch, HIVE-7788.3.patch, HIVE-7788.WIP.patch, HIVE-7788.patch Insert plans needs to be generated differently for ACID tables, plus we need to be able to generate plans in the semantic analyzer for update and delete. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-7788) Generate plans for insert, update, and delete
[ https://issues.apache.org/jira/browse/HIVE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-7788: - Status: Patch Available (was: Open) Generate plans for insert, update, and delete - Key: HIVE-7788 URL: https://issues.apache.org/jira/browse/HIVE-7788 Project: Hive Issue Type: Sub-task Components: Query Processor Reporter: Alan Gates Assignee: Alan Gates Attachments: HIVE-7788.2.patch, HIVE-7788.3.patch, HIVE-7788.WIP.patch, HIVE-7788.patch Insert plans needs to be generated differently for ACID tables, plus we need to be able to generate plans in the semantic analyzer for update and delete. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-7470) Wrong Thrift declaration for {{ShowCompactResponseElement}}
[
https://issues.apache.org/jira/browse/HIVE-7470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Gates updated HIVE-7470:
-
Resolution: Fixed
Status: Resolved (was: Patch Available)
Patch checked in. Thanks Damien for fixing this.
Wrong Thrift declaration for {{ShowCompactResponseElement}}
---
Key: HIVE-7470
URL: https://issues.apache.org/jira/browse/HIVE-7470
Project: Hive
Issue Type: Bug
Components: Metastore, Thrift API
Affects Versions: 0.14.0
Reporter: Damien Carol
Assignee: Damien Carol
Priority: Minor
Labels: metastore, thrift
Fix For: 0.14.0
Attachments: HIVE-7470.1.patch, HIVE-7470.2.patch
Prerequiste :
1. Remote metastore
2. Activate ACID and compactions
3. Launch ALTER TABLE foo COMPACT 'bar'
4. Call {{show_compact()}} on remote metastore
This use case throws exception in Thrift stack.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-7689) Enable Postgres as METASTORE back-end
[ https://issues.apache.org/jira/browse/HIVE-7689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128404#comment-14128404 ] Alan Gates commented on HIVE-7689: -- Are you 100% certain? The TestCompactor uses the transaction tables in the metastore. Enable Postgres as METASTORE back-end - Key: HIVE-7689 URL: https://issues.apache.org/jira/browse/HIVE-7689 Project: Hive Issue Type: Improvement Components: Metastore Affects Versions: 0.14.0 Reporter: Damien Carol Assignee: Damien Carol Priority: Minor Labels: metastore, postgres Fix For: 0.14.0 Attachments: HIVE-7689.5.patch, HIVE-7689.6.patch, HIVE-7689.7.patch, HIVE-7889.1.patch, HIVE-7889.2.patch, HIVE-7889.3.patch, HIVE-7889.4.patch I maintain few patches to make Metastore works with Postgres back end in our production environment. The main goal of this JIRA is to push upstream these patches. This patch enable LOCKS, COMPACTION and fix error in STATS on postgres metastore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-8033) StorageBasedAuthorizationProvider too restrictive on insert/select
Alan Gates created HIVE-8033:
Summary: StorageBasedAuthorizationProvider too restrictive on
insert/select
Key: HIVE-8033
URL: https://issues.apache.org/jira/browse/HIVE-8033
Project: Hive
Issue Type: Bug
Components: Authorization
Affects Versions: 0.13.1
Reporter: Alan Gates
When doing
{code}
insert into table foo select * from bar
{code}
StorageBasedAuth checks that the user has write permissions on bar. It only
needs read permission on bar for this operation.
To reproduce:
# As user1, create a table bar with file permissions set to world readable but
not writable.
# As user2, create table foo.
# Confirm that user2 can read from bar: select count(*) from bar;
# As user2: insert into foo select * from bar;
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-7689) Enable Postgres as METASTORE back-end
[ https://issues.apache.org/jira/browse/HIVE-7689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14126182#comment-14126182 ] Alan Gates commented on HIVE-7689: -- I haven't looked into it, but I'm guessing the failed TestWorker tests are real failures, as the compactor uses the transaction tables. Enable Postgres as METASTORE back-end - Key: HIVE-7689 URL: https://issues.apache.org/jira/browse/HIVE-7689 Project: Hive Issue Type: Improvement Components: Metastore Affects Versions: 0.14.0 Reporter: Damien Carol Assignee: Damien Carol Priority: Minor Labels: metastore, postgres Fix For: 0.14.0 Attachments: HIVE-7689.5.patch, HIVE-7889.1.patch, HIVE-7889.2.patch, HIVE-7889.3.patch, HIVE-7889.4.patch I maintain few patches to make Metastore works with Postgres back end in our production environment. The main goal of this JIRA is to push upstream these patches. This patch enable LOCKS, COMPACTION and fix error in STATS on postgres metastore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-7788) Generate plans for insert, update, and delete
[ https://issues.apache.org/jira/browse/HIVE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-7788: - Status: Open (was: Patch Available) Generate plans for insert, update, and delete - Key: HIVE-7788 URL: https://issues.apache.org/jira/browse/HIVE-7788 Project: Hive Issue Type: Sub-task Components: Query Processor Reporter: Alan Gates Assignee: Alan Gates Attachments: HIVE-7788.WIP.patch, HIVE-7788.patch Insert plans needs to be generated differently for ACID tables, plus we need to be able to generate plans in the semantic analyzer for update and delete. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-7788) Generate plans for insert, update, and delete
[ https://issues.apache.org/jira/browse/HIVE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-7788: - Attachment: HIVE-7788.2.patch New version of the patch that addresses the broken unit tests. Generate plans for insert, update, and delete - Key: HIVE-7788 URL: https://issues.apache.org/jira/browse/HIVE-7788 Project: Hive Issue Type: Sub-task Components: Query Processor Reporter: Alan Gates Assignee: Alan Gates Attachments: HIVE-7788.2.patch, HIVE-7788.WIP.patch, HIVE-7788.patch Insert plans needs to be generated differently for ACID tables, plus we need to be able to generate plans in the semantic analyzer for update and delete. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-7788) Generate plans for insert, update, and delete
[ https://issues.apache.org/jira/browse/HIVE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-7788: - Status: Patch Available (was: Open) Generate plans for insert, update, and delete - Key: HIVE-7788 URL: https://issues.apache.org/jira/browse/HIVE-7788 Project: Hive Issue Type: Sub-task Components: Query Processor Reporter: Alan Gates Assignee: Alan Gates Attachments: HIVE-7788.2.patch, HIVE-7788.WIP.patch, HIVE-7788.patch Insert plans needs to be generated differently for ACID tables, plus we need to be able to generate plans in the semantic analyzer for update and delete. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7470) Wrong Thrift declaration for {{ShowCompactResponseElement}}
[
https://issues.apache.org/jira/browse/HIVE-7470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14126370#comment-14126370
]
Alan Gates commented on HIVE-7470:
--
+1. I do not believe the schemeAuthority test failure is related.
Wrong Thrift declaration for {{ShowCompactResponseElement}}
---
Key: HIVE-7470
URL: https://issues.apache.org/jira/browse/HIVE-7470
Project: Hive
Issue Type: Bug
Components: Metastore, Thrift API
Affects Versions: 0.14.0
Reporter: Damien Carol
Assignee: Damien Carol
Priority: Minor
Labels: metastore, thrift
Fix For: 0.14.0
Attachments: HIVE-7470.1.patch, HIVE-7470.2.patch
Prerequiste :
1. Remote metastore
2. Activate ACID and compactions
3. Launch ALTER TABLE foo COMPACT 'bar'
4. Call {{show_compact()}} on remote metastore
This use case throws exception in Thrift stack.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-7863) Potential null reference in TxnDbUtil#prepareDb()
[
https://issues.apache.org/jira/browse/HIVE-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Gates updated HIVE-7863:
-
Resolution: Fixed
Fix Version/s: 0.14.0
Status: Resolved (was: Patch Available)
Patch checked in. Thanks Lars.
Potential null reference in TxnDbUtil#prepareDb()
-
Key: HIVE-7863
URL: https://issues.apache.org/jira/browse/HIVE-7863
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: Lars Francke
Priority: Minor
Fix For: 0.14.0
Attachments: HIVE-7863.1.patch
Here is related code:
{code}
Connection conn = null;
boolean committed = false;
try {
conn = getConnection();
...
} finally {
if (!committed) conn.rollback();
conn.close();
}
{code}
If getConnection() throws exception, conn.rollback() would be called -
leading to NPE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-7223) Support generic PartitionSpecs in Metastore partition-functions
[
https://issues.apache.org/jira/browse/HIVE-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Gates updated HIVE-7223:
-
Fix Version/s: 0.14.0
Support generic PartitionSpecs in Metastore partition-functions
---
Key: HIVE-7223
URL: https://issues.apache.org/jira/browse/HIVE-7223
Project: Hive
Issue Type: Improvement
Components: HCatalog, Metastore
Affects Versions: 0.12.0, 0.13.0
Reporter: Mithun Radhakrishnan
Assignee: Mithun Radhakrishnan
Fix For: 0.14.0
Attachments: HIVE-7223.1.patch, HIVE-7223.2.patch, HIVE-7223.3.patch,
HIVE-7223.4.patch, HIVE-7223.5.patch
Currently, the functions in the HiveMetaStore API that handle multiple
partitions do so using ListPartition. E.g.
{code}
public ListPartition listPartitions(String db_name, String tbl_name, short
max_parts);
public ListPartition listPartitionsByFilter(String db_name, String
tbl_name, String filter, short max_parts);
public int add_partitions(ListPartition new_parts);
{code}
Partition objects are fairly heavyweight, since each Partition carries its
own copy of a StorageDescriptor, partition-values, etc. Tables with tens of
thousands of partitions take so long to have their partitions listed that the
client times out with default hive.metastore.client.socket.timeout. There is
the additional expense of serializing and deserializing metadata for large
sets of partitions, w.r.t time and heap-space. Reducing the thrift traffic
should help in this regard.
In a date-partitioned table, all sub-partitions for a particular date are
*likely* (but not expected) to have:
# The same base directory (e.g. {{/feeds/search/20140601/}})
# Similar directory structure (e.g. {{/feeds/search/20140601/[US,UK,IN]}})
# The same SerDe/StorageHandler/IOFormat classes
# Sorting/Bucketing/SkewInfo settings
In this “most likely” scenario (henceforth termed “normal”), it’s possible to
represent the partition-list (for a date) in a more condensed form: a list of
LighterPartition instances, all sharing a common StorageDescriptor whose
location points to the root directory.
We can go one better for the {{add_partitions()}} case: When adding all
partitions for a given date, the “normal” case affords us the ability to
specify the top-level date-directory, where sub-partitions can be inferred
from the HDFS directory-path.
These extensions are hard to introduce at the metastore-level, since
partition-functions explicitly specify {{ListPartition}} arguments. I
wonder if a {{PartitionSpec}} interface might help:
{code}
public PartitionSpec listPartitions(db_name, tbl_name, max_parts) throws ...
;
public int add_partitions( PartitionSpec new_parts ) throws … ;
{code}
where the PartitionSpec looks like:
{code}
public interface PartitionSpec {
public ListPartition getPartitions();
public ListString getPartNames();
public IteratorPartition getPartitionIter();
public IteratorString getPartNameIter();
}
{code}
For addPartitions(), an {{HDFSDirBasedPartitionSpec}} class could implement
{{PartitionSpec}}, store a top-level directory, and return Partition
instances from sub-directory names, while storing a single StorageDescriptor
for all of them.
Similarly, list_partitions() could return a ListPartitionSpec, where each
PartitionSpec corresponds to a set or partitions that can share a
StorageDescriptor.
By exposing iterator semantics, neither the client nor the metastore need
instantiate all partitions at once. That should help with memory requirements.
In case no smart grouping is possible, we could just fall back on a
{{DefaultPartitionSpec}} which composes {{ListPartition}}, and is no worse
than status quo.
PartitionSpec abstracts away how a set of partitions may be represented. A
tighter representation allows us to communicate metadata for a larger number
of Partitions, with less Thrift traffic.
Given that Thrift doesn’t support polymorphism, we’d have to implement the
PartitionSpec as a Thrift Union of supported implementations. (We could
convert from the Thrift PartitionSpec to the appropriate Java PartitionSpec
sub-class.)
Thoughts?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-7223) Support generic PartitionSpecs in Metastore partition-functions
[
https://issues.apache.org/jira/browse/HIVE-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14125148#comment-14125148
]
Alan Gates commented on HIVE-7223:
--
Is there a section of the wiki just on the thrift interface? In my opinion we
should be encouraging users to come through CLI, HS2, or WebHCat, not directly
through thrift since that by passes a lot of security.
Support generic PartitionSpecs in Metastore partition-functions
---
Key: HIVE-7223
URL: https://issues.apache.org/jira/browse/HIVE-7223
Project: Hive
Issue Type: Improvement
Components: HCatalog, Metastore
Affects Versions: 0.12.0, 0.13.0
Reporter: Mithun Radhakrishnan
Assignee: Mithun Radhakrishnan
Fix For: 0.14.0
Attachments: HIVE-7223.1.patch, HIVE-7223.2.patch, HIVE-7223.3.patch,
HIVE-7223.4.patch, HIVE-7223.5.patch
Currently, the functions in the HiveMetaStore API that handle multiple
partitions do so using ListPartition. E.g.
{code}
public ListPartition listPartitions(String db_name, String tbl_name, short
max_parts);
public ListPartition listPartitionsByFilter(String db_name, String
tbl_name, String filter, short max_parts);
public int add_partitions(ListPartition new_parts);
{code}
Partition objects are fairly heavyweight, since each Partition carries its
own copy of a StorageDescriptor, partition-values, etc. Tables with tens of
thousands of partitions take so long to have their partitions listed that the
client times out with default hive.metastore.client.socket.timeout. There is
the additional expense of serializing and deserializing metadata for large
sets of partitions, w.r.t time and heap-space. Reducing the thrift traffic
should help in this regard.
In a date-partitioned table, all sub-partitions for a particular date are
*likely* (but not expected) to have:
# The same base directory (e.g. {{/feeds/search/20140601/}})
# Similar directory structure (e.g. {{/feeds/search/20140601/[US,UK,IN]}})
# The same SerDe/StorageHandler/IOFormat classes
# Sorting/Bucketing/SkewInfo settings
In this “most likely” scenario (henceforth termed “normal”), it’s possible to
represent the partition-list (for a date) in a more condensed form: a list of
LighterPartition instances, all sharing a common StorageDescriptor whose
location points to the root directory.
We can go one better for the {{add_partitions()}} case: When adding all
partitions for a given date, the “normal” case affords us the ability to
specify the top-level date-directory, where sub-partitions can be inferred
from the HDFS directory-path.
These extensions are hard to introduce at the metastore-level, since
partition-functions explicitly specify {{ListPartition}} arguments. I
wonder if a {{PartitionSpec}} interface might help:
{code}
public PartitionSpec listPartitions(db_name, tbl_name, max_parts) throws ...
;
public int add_partitions( PartitionSpec new_parts ) throws … ;
{code}
where the PartitionSpec looks like:
{code}
public interface PartitionSpec {
public ListPartition getPartitions();
public ListString getPartNames();
public IteratorPartition getPartitionIter();
public IteratorString getPartNameIter();
}
{code}
For addPartitions(), an {{HDFSDirBasedPartitionSpec}} class could implement
{{PartitionSpec}}, store a top-level directory, and return Partition
instances from sub-directory names, while storing a single StorageDescriptor
for all of them.
Similarly, list_partitions() could return a ListPartitionSpec, where each
PartitionSpec corresponds to a set or partitions that can share a
StorageDescriptor.
By exposing iterator semantics, neither the client nor the metastore need
instantiate all partitions at once. That should help with memory requirements.
In case no smart grouping is possible, we could just fall back on a
{{DefaultPartitionSpec}} which composes {{ListPartition}}, and is no worse
than status quo.
PartitionSpec abstracts away how a set of partitions may be represented. A
tighter representation allows us to communicate metadata for a larger number
of Partitions, with less Thrift traffic.
Given that Thrift doesn’t support polymorphism, we’d have to implement the
PartitionSpec as a Thrift Union of supported implementations. (We could
convert from the Thrift PartitionSpec to the appropriate Java PartitionSpec
sub-class.)
Thoughts?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-7470) Wrong Thrift declaration for {{ShowCompactResponseElement}}
[
https://issues.apache.org/jira/browse/HIVE-7470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14124503#comment-14124503
]
Alan Gates commented on HIVE-7470:
--
Patch looks good. Please rebase and I'll get it committed. Sorry for missing
this earlier.
Wrong Thrift declaration for {{ShowCompactResponseElement}}
---
Key: HIVE-7470
URL: https://issues.apache.org/jira/browse/HIVE-7470
Project: Hive
Issue Type: Bug
Components: Metastore, Thrift API
Affects Versions: 0.14.0
Reporter: Damien Carol
Assignee: Damien Carol
Priority: Minor
Labels: metastore, thrift
Fix For: 0.14.0
Attachments: HIVE-7470.1.patch
Prerequiste :
1. Remote metastore
2. Activate ACID and compactions
3. Launch ALTER TABLE foo COMPACT 'bar'
4. Call {{show_compact()}} on remote metastore
This use case throws exception in Thrift stack.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-8009) show compactions fails when a table with no partitions is being compacted
[
https://issues.apache.org/jira/browse/HIVE-8009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14124504#comment-14124504
]
Alan Gates commented on HIVE-8009:
--
[~damien.carol] thanks for pointing this out. Please do rebase that one and
I'll review and commit.
show compactions fails when a table with no partitions is being compacted
-
Key: HIVE-8009
URL: https://issues.apache.org/jira/browse/HIVE-8009
Project: Hive
Issue Type: Bug
Components: Transactions
Affects Versions: 0.13.1
Reporter: Alan Gates
Assignee: Alan Gates
When a table with no partitions is being compacted and the user does show
compactions it fails. The message from the logs is:
{quote}
org.apache.thrift.protocol.TProtocolException: Required field 'partitionname'
is unset! Struct:ShowCompactResponseElement(dbname:default, tablename:orctab,
partitionname:null, type:MAJOR, state:initiated, workerid:null, start:0,
runAs:null)
{quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-7470) Wrong Thrift declaration for {{ShowCompactResponseElement}}
[
https://issues.apache.org/jira/browse/HIVE-7470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Gates updated HIVE-7470:
-
Status: Open (was: Patch Available)
Patch looks good but needs rebased.
Wrong Thrift declaration for {{ShowCompactResponseElement}}
---
Key: HIVE-7470
URL: https://issues.apache.org/jira/browse/HIVE-7470
Project: Hive
Issue Type: Bug
Components: Metastore, Thrift API
Affects Versions: 0.14.0
Reporter: Damien Carol
Assignee: Damien Carol
Priority: Minor
Labels: metastore, thrift
Fix For: 0.14.0
Attachments: HIVE-7470.1.patch
Prerequiste :
1. Remote metastore
2. Activate ACID and compactions
3. Launch ALTER TABLE foo COMPACT 'bar'
4. Call {{show_compact()}} on remote metastore
This use case throws exception in Thrift stack.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-7863) Potential null reference in TxnDbUtil#prepareDb()
[
https://issues.apache.org/jira/browse/HIVE-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14124511#comment-14124511
]
Alan Gates commented on HIVE-7863:
--
+1. The HS2 unit test failure is unrelated.
Potential null reference in TxnDbUtil#prepareDb()
-
Key: HIVE-7863
URL: https://issues.apache.org/jira/browse/HIVE-7863
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: Lars Francke
Priority: Minor
Attachments: HIVE-7863.1.patch
Here is related code:
{code}
Connection conn = null;
boolean committed = false;
try {
conn = getConnection();
...
} finally {
if (!committed) conn.rollback();
conn.close();
}
{code}
If getConnection() throws exception, conn.rollback() would be called -
leading to NPE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
