[jira] [Commented] (HIVE-6952) Hive 0.13 HiveOutputFormat breaks backwards compatibility
[ https://issues.apache.org/jira/browse/HIVE-6952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13978038#comment-13978038 ] Costin Leau commented on HIVE-6952: --- Can't comment on the entire commit but the HiveOutputFormat seems to be fixed now (it's the same as before). Do you have any ETA for 0.13.1? Cause as it stands right now 0.13 is unusable and the more 0.13.1 is postpone, the more likely the breakage will be propagated into the various Hadoop distros out there. Thanks, > Hive 0.13 HiveOutputFormat breaks backwards compatibility > - > > Key: HIVE-6952 > URL: https://issues.apache.org/jira/browse/HIVE-6952 > Project: Hive > Issue Type: Bug > Components: File Formats, Serializers/Deserializers >Affects Versions: 0.13.0 >Reporter: Costin Leau >Assignee: Ashutosh Chauhan >Priority: Blocker > Attachments: HIVE-6952.patch > > > Hive 0.13 changed the signature of HiveOutputFormat (through commit r1527149) > breaking backwards compatibility with previous releases; the return type of > getHiveRecordWriter has been changed from RecordWriter to FSRecordWriter. > FSRecordWriter introduces one new method on top of RecordWriter however it > does not extend the previous interface and it lives in a completely new > package. > Thus code running fine on Hive 0.12 breaks on Hive 0.13. After the upgrade, > code running on HIve 0.13, will break on anything lower than this. > This could have easily been avoided by extending the existing interface or > introducing a new one that RecordWriter could have extended going forward. By > changing the signature, the existing contract (and compatibility) has been > voided. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-6952) Hive 0.13 HiveOutputFormat breaks backwards compatibility
[ https://issues.apache.org/jira/browse/HIVE-6952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976591#comment-13976591 ] Costin Leau commented on HIVE-6952: --- Actually taking a closer look indicates that FSRecordWriter and RecordWriter are identical - they both implement the same two methods, with the _exact_ same signature which makes the breaking change even more puzzling. > Hive 0.13 HiveOutputFormat breaks backwards compatibility > - > > Key: HIVE-6952 > URL: https://issues.apache.org/jira/browse/HIVE-6952 > Project: Hive > Issue Type: Bug > Components: File Formats, Serializers/Deserializers >Affects Versions: 0.13.0 >Reporter: Costin Leau >Priority: Blocker > > Hive 0.13 changed the signature of HiveOutputFormat (through commit r1527149) > breaking backwards compatibility with previous releases; the return type of > getHiveRecordWriter has been changed from RecordWriter to FSRecordWriter. > FSRecordWriter introduces one new method on top of RecordWriter however it > does not extend the previous interface and it lives in a completely new > package. > Thus code running fine on Hive 0.12 breaks on Hive 0.13. After the upgrade, > code running on HIve 0.13, will break on anything lower than this. > This could have easily been avoided by extending the existing interface or > introducing a new one that RecordWriter could have extended going forward. By > changing the signature, the existing contract (and compatibility) has been > voided. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (HIVE-6952) Hive 0.13 HiveOutputFormat breaks backwards compatibility
Costin Leau created HIVE-6952: - Summary: Hive 0.13 HiveOutputFormat breaks backwards compatibility Key: HIVE-6952 URL: https://issues.apache.org/jira/browse/HIVE-6952 Project: Hive Issue Type: Bug Components: File Formats, Serializers/Deserializers Affects Versions: 0.13.0 Reporter: Costin Leau Priority: Blocker Hive 0.13 changed the signature of HiveOutputFormat (through commit r1527149) breaking backwards compatibility with previous releases; the return type of getHiveRecordWriter has been changed from RecordWriter to FSRecordWriter. FSRecordWriter introduces one new method on top of RecordWriter however it does not extend the previous interface and it lives in a completely new package. Thus code running fine on Hive 0.12 breaks on Hive 0.13. After the upgrade, code running on HIve 0.13, will break on anything lower than this. This could have easily been avoided by extending the existing interface or introducing a new one that RecordWriter could have extended going forward. By changing the signature, the existing contract (and compatibility) has been voided. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (HIVE-6951) Hive 0.13 HiveOutputFormat breaks backwards compatibility
Costin Leau created HIVE-6951: - Summary: Hive 0.13 HiveOutputFormat breaks backwards compatibility Key: HIVE-6951 URL: https://issues.apache.org/jira/browse/HIVE-6951 Project: Hive Issue Type: Bug Components: File Formats, Serializers/Deserializers Affects Versions: 0.13.0 Reporter: Costin Leau Priority: Blocker Hive 0.13 changed the signature of HiveOutputFormat (through commit r1527149) breaking backwards compatibility with previous releases; the return type of getHiveRecordWriter has been changed from RecordWriter to FSRecordWriter. FSRecordWriter introduces one new method on top of RecordWriter however it does not extend the previous interface and it lives in a completely new package. Thus code running fine on Hive 0.12 breaks on Hive 0.13. After the upgrade, code running on HIve 0.13, will break on anything lower than this. This could have easily been avoided by extending the existing interface or introducing a new one that RecordWriter could have extended going forward. By changing the signature, the existing contract (and compatibility) has been voided. -- This message was sent by Atlassian JIRA (v6.2#6252)