[jira] [Commented] (HIVE-3092) Hive tests should load Hive classes from build directory, not Ivy cache
[ https://issues.apache.org/jira/browse/HIVE-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13536061#comment-13536061 ] Kanna Karanam commented on HIVE-3092: - Hello, I am out of office on vacation and will return on Wed, Jan 2nd. For any urgent issues, please contact my manager. - Kanna Hive tests should load Hive classes from build directory, not Ivy cache --- Key: HIVE-3092 URL: https://issues.apache.org/jira/browse/HIVE-3092 Project: Hive Issue Type: Bug Components: Testing Infrastructure, Tests Reporter: Jakob Homan Assignee: Kevin Wilfong Fix For: 0.10.0 Attachments: HIVE-3092.1.patch.txt, HIVE-3092.2.patch.txt As discussed in HIVE-895, currently the tests pull in jars for other components rather from Ivy rather than using the built classes and jars in the build directory (bit.ly/LzndQU). This means that absent a very-clean, one is testing against a previous version of the code and cross-component tests are invalid. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3664) Avoid to create a symlink for hive-contrib.jar file in dist\lib folder.
[ https://issues.apache.org/jira/browse/HIVE-3664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13496780#comment-13496780 ] Kanna Karanam commented on HIVE-3664: - @Ashutosh - Can you please commit these changes if there are no UT failures? Thanks Avoid to create a symlink for hive-contrib.jar file in dist\lib folder. --- Key: HIVE-3664 URL: https://issues.apache.org/jira/browse/HIVE-3664 Project: Hive Issue Type: Bug Components: Build Infrastructure Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3664.1.patch.txt It forces us to enumerate all the jars except this jar on Windows instead of directly referencing the “dist\lib\*.jar” folder in the class path. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3664) Avoid to create a symlink for hive-contrib.jar file in dist\lib folder.
[ https://issues.apache.org/jira/browse/HIVE-3664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13493485#comment-13493485 ] Kanna Karanam commented on HIVE-3664: - Thanks Ashutosh - In Windows, When we specify the class path as “HIVE_DIR\Dist\Lib\*” instead of enumerating individual jars (because of 8k limitation on environment variable), JAVA is trying to load the “hive-contrib.jar” as regular jar and failing. Based on the comments in HIVE-3092, I think it is safe to remove them. If not, I can conditionally skip this on Windows. udf-compile: [echo] *** Compiling UDFs *** [javac] Compiling 25 source files to c:\Jenkins\workspace\windows.hive.20.unsecure\datateamtest\hcatalog\udfs\java\build [javac] error: error reading C:\Hadoop\hive-0.9.0\lib\hive_contrib.jar; error in opening zip file [javac] 1 error On clicking C:\Hadoop\hive-0.9.0\lib\hive_contrib.jar, I get an error message Invalid or corrupt jarfile C:\Hadoop\hive-0.9.0\lib\hive_contrib.jar C:\Hadoop\hive-0.9.0\libls -l hive_contrib.jar -rw-r--r--1 Administ Administ 58 Aug 30 00:41 hive_contrib.jar C:\Hadoop\hive-0.9.0\libjar -tvf hive_contrib.jar java.util.zip.ZipException: error in opening zip file at java.util.zip.ZipFile.open(Native Method) at java.util.zip.ZipFile.init(ZipFile.java:127) at java.util.zip.ZipFile.init(ZipFile.java:88) at sun.tools.jar.Main.list(Main.java:979) at sun.tools.jar.Main.run(Main.java:224) at sun.tools.jar.Main.main(Main.java:1149) Avoid to create a symlink for hive-contrib.jar file in dist\lib folder. --- Key: HIVE-3664 URL: https://issues.apache.org/jira/browse/HIVE-3664 Project: Hive Issue Type: Bug Components: Build Infrastructure Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3664.1.patch.txt It forces us to enumerate all the jars except this jar on Windows instead of directly referencing the “dist\lib\*.jar” folder in the class path. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HIVE-3658) Unable to run the Hbase related unit tests on Windows
Kanna Karanam created HIVE-3658: --- Summary: Unable to run the Hbase related unit tests on Windows Key: HIVE-3658 URL: https://issues.apache.org/jira/browse/HIVE-3658 Project: Hive Issue Type: Bug Components: Testing Infrastructure Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 Requires to escape the “\” on windows to make it compile. So make sure to use the escaped path in the VM templates instead of actual path. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (HIVE-3658) Unable to run the Hbase related unit tests on Windows
[ https://issues.apache.org/jira/browse/HIVE-3658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HIVE-3658 started by Kanna Karanam. Unable to run the Hbase related unit tests on Windows - Key: HIVE-3658 URL: https://issues.apache.org/jira/browse/HIVE-3658 Project: Hive Issue Type: Bug Components: Testing Infrastructure Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Fix For: 0.10.0, 0.9.1 Requires to escape the “\” on windows to make it compile. So make sure to use the escaped path in the VM templates instead of actual path. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3658) Unable to run the Hbase related unit tests on Windows
[ https://issues.apache.org/jira/browse/HIVE-3658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3658: Attachment: HIVE-3658.1.patch.txt Please find the code review request at https://reviews.apache.org/r/7833/ Unable to run the Hbase related unit tests on Windows - Key: HIVE-3658 URL: https://issues.apache.org/jira/browse/HIVE-3658 Project: Hive Issue Type: Bug Components: Testing Infrastructure Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3658.1.patch.txt Requires to escape the “\” on windows to make it compile. So make sure to use the escaped path in the VM templates instead of actual path. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3658) Unable to generate the Hbase related unit tests using velocity templates on Windows
[ https://issues.apache.org/jira/browse/HIVE-3658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3658: Summary: Unable to generate the Hbase related unit tests using velocity templates on Windows (was: Unable to run the Hbase related unit tests on Windows) Unable to generate the Hbase related unit tests using velocity templates on Windows --- Key: HIVE-3658 URL: https://issues.apache.org/jira/browse/HIVE-3658 Project: Hive Issue Type: Bug Components: Testing Infrastructure Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3658.1.patch.txt Requires to escape the “\” on windows to make it compile. So make sure to use the escaped path in the VM templates instead of actual path. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3658) Unable to run the Hbase related unit tests on Windows
[ https://issues.apache.org/jira/browse/HIVE-3658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3658: Status: Patch Available (was: In Progress) Unable to run the Hbase related unit tests on Windows - Key: HIVE-3658 URL: https://issues.apache.org/jira/browse/HIVE-3658 Project: Hive Issue Type: Bug Components: Testing Infrastructure Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3658.1.patch.txt Requires to escape the “\” on windows to make it compile. So make sure to use the escaped path in the VM templates instead of actual path. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (HIVE-3659) TestHiveHistory::testQueryloglocParentDirNotExist Test fails on Windows because of some resource leaks in ZK
[ https://issues.apache.org/jira/browse/HIVE-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HIVE-3659 started by Kanna Karanam. TestHiveHistory::testQueryloglocParentDirNotExist Test fails on Windows because of some resource leaks in ZK Key: HIVE-3659 URL: https://issues.apache.org/jira/browse/HIVE-3659 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3659.1.patch.txt Hive uses ZK for locking. In some test cases, ZK is not behaving well. In thread dumps, I saw it is waiting for locks to be released but they were not getting released. Hive tries to release locks but keeps failing, it eventually times out for its release attempts, which in default settings takes 10 mins. This is also the cause of why some queries take extra-ordinarily long to run. I suggest to disable ZK locking till ZK is certified for windows. In this test case, I don’t see a requirement to use ZK so I am disabling the HiveConf.ConfVars.HIVE_SUPPORT_CONCURRENCY to work around the issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3659) TestHiveHistory::testQueryloglocParentDirNotExist Test fails on Windows because of some resource leaks in ZK
[ https://issues.apache.org/jira/browse/HIVE-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3659: Attachment: HIVE-3659.1.patch.txt Please find the code review request at https://reviews.apache.org/r/7835/ TestHiveHistory::testQueryloglocParentDirNotExist Test fails on Windows because of some resource leaks in ZK Key: HIVE-3659 URL: https://issues.apache.org/jira/browse/HIVE-3659 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3659.1.patch.txt Hive uses ZK for locking. In some test cases, ZK is not behaving well. In thread dumps, I saw it is waiting for locks to be released but they were not getting released. Hive tries to release locks but keeps failing, it eventually times out for its release attempts, which in default settings takes 10 mins. This is also the cause of why some queries take extra-ordinarily long to run. I suggest to disable ZK locking till ZK is certified for windows. In this test case, I don’t see a requirement to use ZK so I am disabling the HiveConf.ConfVars.HIVE_SUPPORT_CONCURRENCY to work around the issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3659) TestHiveHistory::testQueryloglocParentDirNotExist Test fails on Windows because of some resource leaks in ZK
[ https://issues.apache.org/jira/browse/HIVE-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3659: Status: Patch Available (was: In Progress) TestHiveHistory::testQueryloglocParentDirNotExist Test fails on Windows because of some resource leaks in ZK Key: HIVE-3659 URL: https://issues.apache.org/jira/browse/HIVE-3659 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3659.1.patch.txt Hive uses ZK for locking. In some test cases, ZK is not behaving well. In thread dumps, I saw it is waiting for locks to be released but they were not getting released. Hive tries to release locks but keeps failing, it eventually times out for its release attempts, which in default settings takes 10 mins. This is also the cause of why some queries take extra-ordinarily long to run. I suggest to disable ZK locking till ZK is certified for windows. In this test case, I don’t see a requirement to use ZK so I am disabling the HiveConf.ConfVars.HIVE_SUPPORT_CONCURRENCY to work around the issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HIVE-3661) Remove the Windows specific “=” related swizzle path changes from Proxy FileSystems
Kanna Karanam created HIVE-3661: --- Summary: Remove the Windows specific “=” related swizzle path changes from Proxy FileSystems Key: HIVE-3661 URL: https://issues.apache.org/jira/browse/HIVE-3661 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 Because of this special conversion, Some other unit tests are failing on Windows. After some other investigation, We noticed that “=” is a valid character that can be included in the Windows paths. So I am reverting back “=” related changes from the swizzle path. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (HIVE-3661) Remove the Windows specific “=” related swizzle path changes from Proxy FileSystems
[ https://issues.apache.org/jira/browse/HIVE-3661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HIVE-3661 started by Kanna Karanam. Remove the Windows specific “=” related swizzle path changes from Proxy FileSystems --- Key: HIVE-3661 URL: https://issues.apache.org/jira/browse/HIVE-3661 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Fix For: 0.10.0, 0.9.1 Because of this special conversion, Some other unit tests are failing on Windows. After some other investigation, We noticed that “=” is a valid character that can be included in the Windows paths. So I am reverting back “=” related changes from the swizzle path. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3661) Remove the Windows specific “=” related swizzle path changes from Proxy FileSystems
[ https://issues.apache.org/jira/browse/HIVE-3661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3661: Attachment: HIVE-3661.1.patch.txt Please find the code review request at https://reviews.apache.org/r/7836/ Remove the Windows specific “=” related swizzle path changes from Proxy FileSystems --- Key: HIVE-3661 URL: https://issues.apache.org/jira/browse/HIVE-3661 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3661.1.patch.txt Because of this special conversion, Some other unit tests are failing on Windows. After some other investigation, We noticed that “=” is a valid character that can be included in the Windows paths. So I am reverting back “=” related changes from the swizzle path. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3661) Remove the Windows specific “=” related swizzle path changes from Proxy FileSystems
[ https://issues.apache.org/jira/browse/HIVE-3661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3661: Status: Patch Available (was: In Progress) Remove the Windows specific “=” related swizzle path changes from Proxy FileSystems --- Key: HIVE-3661 URL: https://issues.apache.org/jira/browse/HIVE-3661 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3661.1.patch.txt Because of this special conversion, Some other unit tests are failing on Windows. After some other investigation, We noticed that “=” is a valid character that can be included in the Windows paths. So I am reverting back “=” related changes from the swizzle path. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HIVE-3662) TestHiveServer: testScratchDirShouldClearWhileStartup is failing on Windows
Kanna Karanam created HIVE-3662: --- Summary: TestHiveServer: testScratchDirShouldClearWhileStartup is failing on Windows Key: HIVE-3662 URL: https://issues.apache.org/jira/browse/HIVE-3662 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Fix For: 0.10.0, 0.9.1 Test case is attempting to delete the ScratchDir but it is failing on Windows because one of the subfolders (local scratchdir) in use. So change the location of the local scratch directory. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3662) TestHiveServer: testScratchDirShouldClearWhileStartup is failing on Windows
[ https://issues.apache.org/jira/browse/HIVE-3662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3662: Attachment: HIVE-3662.1.patch.txt Please find the code review request at https://reviews.apache.org/r/7837/ TestHiveServer: testScratchDirShouldClearWhileStartup is failing on Windows --- Key: HIVE-3662 URL: https://issues.apache.org/jira/browse/HIVE-3662 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Labels: Windows Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3662.1.patch.txt Test case is attempting to delete the ScratchDir but it is failing on Windows because one of the subfolders (local scratchdir) in use. So change the location of the local scratch directory. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3662) TestHiveServer: testScratchDirShouldClearWhileStartup is failing on Windows
[ https://issues.apache.org/jira/browse/HIVE-3662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3662: Status: Patch Available (was: Open) TestHiveServer: testScratchDirShouldClearWhileStartup is failing on Windows --- Key: HIVE-3662 URL: https://issues.apache.org/jira/browse/HIVE-3662 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Labels: Windows Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3662.1.patch.txt Test case is attempting to delete the ScratchDir but it is failing on Windows because one of the subfolders (local scratchdir) in use. So change the location of the local scratch directory. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HIVE-3663) Unable to display the MR Job file path on Windows in case of MR job failures.
Kanna Karanam created HIVE-3663: --- Summary: Unable to display the MR Job file path on Windows in case of MR job failures. Key: HIVE-3663 URL: https://issues.apache.org/jira/browse/HIVE-3663 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 Because of this bunch of CLI negative tests are failing on windows. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (HIVE-3663) Unable to display the MR Job file path on Windows in case of MR job failures.
[ https://issues.apache.org/jira/browse/HIVE-3663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HIVE-3663 started by Kanna Karanam. Unable to display the MR Job file path on Windows in case of MR job failures. - Key: HIVE-3663 URL: https://issues.apache.org/jira/browse/HIVE-3663 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Fix For: 0.10.0, 0.9.1 Because of this bunch of CLI negative tests are failing on windows. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3663) Unable to display the MR Job file path on Windows in case of MR job failures.
[ https://issues.apache.org/jira/browse/HIVE-3663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3663: Attachment: HIVE-3663.1.patch.txt Please find the code review request at https://reviews.apache.org/r/7839/ Unable to display the MR Job file path on Windows in case of MR job failures. - Key: HIVE-3663 URL: https://issues.apache.org/jira/browse/HIVE-3663 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3663.1.patch.txt Because of this bunch of CLI negative tests are failing on windows. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3663) Unable to display the MR Job file path on Windows in case of MR job failures.
[ https://issues.apache.org/jira/browse/HIVE-3663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3663: Status: Patch Available (was: In Progress) Unable to display the MR Job file path on Windows in case of MR job failures. - Key: HIVE-3663 URL: https://issues.apache.org/jira/browse/HIVE-3663 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3663.1.patch.txt Because of this bunch of CLI negative tests are failing on windows. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HIVE-3664) Avoid to create the symlink for hive-contrib.jar file in dist\lib folder.
Kanna Karanam created HIVE-3664: --- Summary: Avoid to create the symlink for hive-contrib.jar file in dist\lib folder. Key: HIVE-3664 URL: https://issues.apache.org/jira/browse/HIVE-3664 Project: Hive Issue Type: Bug Components: Build Infrastructure Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 It forces us to enumerate all the jars except this jar on Windows instead of directly referencing the “dist\lib\*.jar” folder in the class path. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3664) Avoid to create a symlink for hive-contrib.jar file in dist\lib folder.
[ https://issues.apache.org/jira/browse/HIVE-3664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3664: Summary: Avoid to create a symlink for hive-contrib.jar file in dist\lib folder. (was: Avoid to create the symlink for hive-contrib.jar file in dist\lib folder.) Avoid to create a symlink for hive-contrib.jar file in dist\lib folder. --- Key: HIVE-3664 URL: https://issues.apache.org/jira/browse/HIVE-3664 Project: Hive Issue Type: Bug Components: Build Infrastructure Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Fix For: 0.10.0, 0.9.1 It forces us to enumerate all the jars except this jar on Windows instead of directly referencing the “dist\lib\*.jar” folder in the class path. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3664) Avoid to create a symlink for hive-contrib.jar file in dist\lib folder.
[ https://issues.apache.org/jira/browse/HIVE-3664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3664: Attachment: HIVE-3664.1.patch.txt Please find the code review request at https://reviews.apache.org/r/7840/ Avoid to create a symlink for hive-contrib.jar file in dist\lib folder. --- Key: HIVE-3664 URL: https://issues.apache.org/jira/browse/HIVE-3664 Project: Hive Issue Type: Bug Components: Build Infrastructure Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3664.1.patch.txt It forces us to enumerate all the jars except this jar on Windows instead of directly referencing the “dist\lib\*.jar” folder in the class path. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3664) Avoid to create a symlink for hive-contrib.jar file in dist\lib folder.
[ https://issues.apache.org/jira/browse/HIVE-3664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3664: Status: Patch Available (was: Open) Avoid to create a symlink for hive-contrib.jar file in dist\lib folder. --- Key: HIVE-3664 URL: https://issues.apache.org/jira/browse/HIVE-3664 Project: Hive Issue Type: Bug Components: Build Infrastructure Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3664.1.patch.txt It forces us to enumerate all the jars except this jar on Windows instead of directly referencing the “dist\lib\*.jar” folder in the class path. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3480) Resource leak: Fix the file handle leaks in Symbolic Symlink related input formats.
[ https://issues.apache.org/jira/browse/HIVE-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3480: Attachment: HIVE-3480.1.patch.txt Please find the code review request at https://reviews.apache.org/r/7841/ Resource leak: Fix the file handle leaks in Symbolic Symlink related input formats. --- Key: HIVE-3480 URL: https://issues.apache.org/jira/browse/HIVE-3480 Project: Hive Issue Type: Bug Components: CLI, Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3480.1.patch.txt Noticed these file handle leaks while fixing the Symlink related unit test failures on Windows. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3480) Resource leak: Fix the file handle leaks in Symbolic Symlink related input formats.
[ https://issues.apache.org/jira/browse/HIVE-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3480: Status: Patch Available (was: In Progress) Resource leak: Fix the file handle leaks in Symbolic Symlink related input formats. --- Key: HIVE-3480 URL: https://issues.apache.org/jira/browse/HIVE-3480 Project: Hive Issue Type: Bug Components: CLI, Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3480.1.patch.txt Noticed these file handle leaks while fixing the Symlink related unit test failures on Windows. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3662) TestHiveServer: testScratchDirShouldClearWhileStartup is failing on Windows
[ https://issues.apache.org/jira/browse/HIVE-3662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3662: Assignee: Kanna Karanam TestHiveServer: testScratchDirShouldClearWhileStartup is failing on Windows --- Key: HIVE-3662 URL: https://issues.apache.org/jira/browse/HIVE-3662 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3662.1.patch.txt Test case is attempting to delete the ScratchDir but it is failing on Windows because one of the subfolders (local scratchdir) in use. So change the location of the local scratch directory. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HIVE-3494) Some of the JDBC test cases are failing on Windows because of the longer class path.
Kanna Karanam created HIVE-3494: --- Summary: Some of the JDBC test cases are failing on Windows because of the longer class path. Key: HIVE-3494 URL: https://issues.apache.org/jira/browse/HIVE-3494 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 If the class path size is more than 8K then we can’t set the environment variable so some of the test cases are failing on Windows. Remove the duplicate JAR entries from the class path to reduce the chance of exceeding the 8K limit. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (HIVE-3494) Some of the JDBC test cases are failing on Windows because of the longer class path.
[ https://issues.apache.org/jira/browse/HIVE-3494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HIVE-3494 started by Kanna Karanam. Some of the JDBC test cases are failing on Windows because of the longer class path. Key: HIVE-3494 URL: https://issues.apache.org/jira/browse/HIVE-3494 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 If the class path size is more than 8K then we can’t set the environment variable so some of the test cases are failing on Windows. Remove the duplicate JAR entries from the class path to reduce the chance of exceeding the 8K limit. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3494) Some of the JDBC test cases are failing on Windows because of the longer class path.
[ https://issues.apache.org/jira/browse/HIVE-3494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3494: Attachment: HIVE-3494.1.patch.txt Some of the JDBC test cases are failing on Windows because of the longer class path. Key: HIVE-3494 URL: https://issues.apache.org/jira/browse/HIVE-3494 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3494.1.patch.txt If the class path size is more than 8K then we can’t set the environment variable so some of the test cases are failing on Windows. Remove the duplicate JAR entries from the class path to reduce the chance of exceeding the 8K limit. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3494) Some of the JDBC test cases are failing on Windows because of the longer class path.
[ https://issues.apache.org/jira/browse/HIVE-3494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3494: Status: Patch Available (was: In Progress) Please find the review request at https://reviews.apache.org/r/7196/ . Thanks Some of the JDBC test cases are failing on Windows because of the longer class path. Key: HIVE-3494 URL: https://issues.apache.org/jira/browse/HIVE-3494 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3494.1.patch.txt If the class path size is more than 8K then we can’t set the environment variable so some of the test cases are failing on Windows. Remove the duplicate JAR entries from the class path to reduce the chance of exceeding the 8K limit. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HIVE-3487) Some of the Metastore unit tests failing on Windows because of the static variables initialization problem in HiveConf class.
Kanna Karanam created HIVE-3487: --- Summary: Some of the Metastore unit tests failing on Windows because of the static variables initialization problem in HiveConf class. Key: HIVE-3487 URL: https://issues.apache.org/jira/browse/HIVE-3487 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 Following unit tests are failing on windows because of the problem with static variables initialization. TestMarkPartition TestMarkRemotePartition TestMetastoreEventListener Reason – Static variables on outer class static variables are not getting initialized when we reference nested public static class variables on windows. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (HIVE-3487) Some of the Metastore unit tests failing on Windows because of the static variables initialization problem in HiveConf class.
[ https://issues.apache.org/jira/browse/HIVE-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HIVE-3487 started by Kanna Karanam. Some of the Metastore unit tests failing on Windows because of the static variables initialization problem in HiveConf class. - Key: HIVE-3487 URL: https://issues.apache.org/jira/browse/HIVE-3487 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 Following unit tests are failing on windows because of the problem with static variables initialization. TestMarkPartition TestMarkRemotePartition TestMetastoreEventListener Reason – Static variables on outer class static variables are not getting initialized when we reference nested public static class variables on windows. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3487) Some of the Metastore unit tests failing on Windows because of the static variables initialization problem in HiveConf class.
[ https://issues.apache.org/jira/browse/HIVE-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3487: Attachment: HIVE-3487.1.patch.txt Some of the Metastore unit tests failing on Windows because of the static variables initialization problem in HiveConf class. - Key: HIVE-3487 URL: https://issues.apache.org/jira/browse/HIVE-3487 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3487.1.patch.txt Following unit tests are failing on windows because of the problem with static variables initialization. TestMarkPartition TestMarkRemotePartition TestMetastoreEventListener Reason – Static variables on outer class static variables are not getting initialized when we reference nested public static class variables on windows. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3487) Some of the Metastore unit tests failing on Windows because of the static variables initialization problem in HiveConf class.
[ https://issues.apache.org/jira/browse/HIVE-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13458470#comment-13458470 ] Kanna Karanam commented on HIVE-3487: - Please find the review request at https://reviews.apache.org/r/7155/ thanks. Some of the Metastore unit tests failing on Windows because of the static variables initialization problem in HiveConf class. - Key: HIVE-3487 URL: https://issues.apache.org/jira/browse/HIVE-3487 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3487.1.patch.txt Following unit tests are failing on windows because of the problem with static variables initialization. TestMarkPartition TestMarkRemotePartition TestMetastoreEventListener Reason – Static variables on outer class static variables are not getting initialized when we reference nested public static class variables on windows. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3487) Some of the Metastore unit tests failing on Windows because of the static variables initialization problem in HiveConf class.
[ https://issues.apache.org/jira/browse/HIVE-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3487: Release Note: (was: Please find the review request at https://reviews.apache.org/r/7155/ thanks.) Some of the Metastore unit tests failing on Windows because of the static variables initialization problem in HiveConf class. - Key: HIVE-3487 URL: https://issues.apache.org/jira/browse/HIVE-3487 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3487.1.patch.txt Following unit tests are failing on windows because of the problem with static variables initialization. TestMarkPartition TestMarkRemotePartition TestMetastoreEventListener Reason – Static variables on outer class static variables are not getting initialized when we reference nested public static class variables on windows. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3487) Some of the Metastore unit tests failing on Windows because of the static variables initialization problem in HiveConf class.
[ https://issues.apache.org/jira/browse/HIVE-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3487: Release Note: Please find the review request at https://reviews.apache.org/r/7155/ thanks. Status: Patch Available (was: In Progress) Some of the Metastore unit tests failing on Windows because of the static variables initialization problem in HiveConf class. - Key: HIVE-3487 URL: https://issues.apache.org/jira/browse/HIVE-3487 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3487.1.patch.txt Following unit tests are failing on windows because of the problem with static variables initialization. TestMarkPartition TestMarkRemotePartition TestMetastoreEventListener Reason – Static variables on outer class static variables are not getting initialized when we reference nested public static class variables on windows. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HIVE-3478) Remove the specialized logic to handle the file schemas in windows vs unix from build.xml
Kanna Karanam created HIVE-3478: --- Summary: Remove the specialized logic to handle the file schemas in windows vs unix from build.xml Key: HIVE-3478 URL: https://issues.apache.org/jira/browse/HIVE-3478 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 After more testing, I realized that this special check can be removed by changing the “\\” with “\\\” to work on both platforms -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (HIVE-3478) Remove the specialized logic to handle the file schemas in windows vs unix from build.xml
[ https://issues.apache.org/jira/browse/HIVE-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HIVE-3478 started by Kanna Karanam. Remove the specialized logic to handle the file schemas in windows vs unix from build.xml - Key: HIVE-3478 URL: https://issues.apache.org/jira/browse/HIVE-3478 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 After more testing, I realized that this special check can be removed by changing the “\\” with “\\\” to work on both platforms -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HIVE-3479) Bug fix: Return the child JVM exit code to the parent process to handle the error conditions
Kanna Karanam created HIVE-3479: --- Summary: Bug fix: Return the child JVM exit code to the parent process to handle the error conditions Key: HIVE-3479 URL: https://issues.apache.org/jira/browse/HIVE-3479 Project: Hive Issue Type: Bug Components: Testing Infrastructure Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 It is a bug in the script and noticed it while fixing some of the Negative CLI test failures -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (HIVE-3479) Bug fix: Return the child JVM exit code to the parent process to handle the error conditions
[ https://issues.apache.org/jira/browse/HIVE-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HIVE-3479 started by Kanna Karanam. Bug fix: Return the child JVM exit code to the parent process to handle the error conditions Key: HIVE-3479 URL: https://issues.apache.org/jira/browse/HIVE-3479 Project: Hive Issue Type: Bug Components: Testing Infrastructure Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 It is a bug in the script and noticed it while fixing some of the Negative CLI test failures -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HIVE-3480) Resource leak: Fix the file handle leaks in Symbolic Symlink related input formats.
Kanna Karanam created HIVE-3480: --- Summary: Resource leak: Fix the file handle leaks in Symbolic Symlink related input formats. Key: HIVE-3480 URL: https://issues.apache.org/jira/browse/HIVE-3480 Project: Hive Issue Type: Bug Components: CLI, Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 Noticed these file handle leaks while fixing the Symlink related unit test failures on Windows. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (HIVE-3480) Resource leak: Fix the file handle leaks in Symbolic Symlink related input formats.
[ https://issues.apache.org/jira/browse/HIVE-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HIVE-3480 started by Kanna Karanam. Resource leak: Fix the file handle leaks in Symbolic Symlink related input formats. --- Key: HIVE-3480 URL: https://issues.apache.org/jira/browse/HIVE-3480 Project: Hive Issue Type: Bug Components: CLI, Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 Noticed these file handle leaks while fixing the Symlink related unit test failures on Windows. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HIVE-3481) Resource leak: Hiveserver is not closing the existing driver handle before executing the next command. It results in to file handle leaks.
Kanna Karanam created HIVE-3481: --- Summary: Resource leak: Hiveserver is not closing the existing driver handle before executing the next command. It results in to file handle leaks. Key: HIVE-3481 URL: https://issues.apache.org/jira/browse/HIVE-3481 Project: Hive Issue Type: Bug Components: JDBC, ODBC, Server Infrastructure Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 Close the driver object if it exists before creating another driver object. Bunch of HiveServer JDBC related unit tests are failing because of these file handle leaks. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (HIVE-3481) Resource leak: Hiveserver is not closing the existing driver handle before executing the next command. It results in to file handle leaks.
[ https://issues.apache.org/jira/browse/HIVE-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HIVE-3481 started by Kanna Karanam. Resource leak: Hiveserver is not closing the existing driver handle before executing the next command. It results in to file handle leaks. Key: HIVE-3481 URL: https://issues.apache.org/jira/browse/HIVE-3481 Project: Hive Issue Type: Bug Components: JDBC, ODBC, Server Infrastructure Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 Close the driver object if it exists before creating another driver object. Bunch of HiveServer JDBC related unit tests are failing because of these file handle leaks. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3479) Bug fix: Return the child JVM exit code to the parent process to handle the error conditions
[ https://issues.apache.org/jira/browse/HIVE-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3479: Attachment: HIVE-3479.1.patch.txt Attached the patch Bug fix: Return the child JVM exit code to the parent process to handle the error conditions Key: HIVE-3479 URL: https://issues.apache.org/jira/browse/HIVE-3479 Project: Hive Issue Type: Bug Components: Testing Infrastructure Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3479.1.patch.txt It is a bug in the script and noticed it while fixing some of the Negative CLI test failures -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3479) Bug fix: Return the child JVM exit code to the parent process to handle the error conditions
[ https://issues.apache.org/jira/browse/HIVE-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3479: Status: Patch Available (was: In Progress) Bug fix: Return the child JVM exit code to the parent process to handle the error conditions Key: HIVE-3479 URL: https://issues.apache.org/jira/browse/HIVE-3479 Project: Hive Issue Type: Bug Components: Testing Infrastructure Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3479.1.patch.txt It is a bug in the script and noticed it while fixing some of the Negative CLI test failures -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3481) Resource leak: Hiveserver is not closing the existing driver handle before executing the next command. It results in to file handle leaks.
[ https://issues.apache.org/jira/browse/HIVE-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3481: Attachment: HIVE-3481.1.patch.txt Attached the patch Resource leak: Hiveserver is not closing the existing driver handle before executing the next command. It results in to file handle leaks. Key: HIVE-3481 URL: https://issues.apache.org/jira/browse/HIVE-3481 Project: Hive Issue Type: Bug Components: JDBC, ODBC, Server Infrastructure Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3481.1.patch.txt Close the driver object if it exists before creating another driver object. Bunch of HiveServer JDBC related unit tests are failing because of these file handle leaks. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3481) Resource leak: Hiveserver is not closing the existing driver handle before executing the next command. It results in to file handle leaks.
[ https://issues.apache.org/jira/browse/HIVE-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3481: Status: Patch Available (was: In Progress) Resource leak: Hiveserver is not closing the existing driver handle before executing the next command. It results in to file handle leaks. Key: HIVE-3481 URL: https://issues.apache.org/jira/browse/HIVE-3481 Project: Hive Issue Type: Bug Components: JDBC, ODBC, Server Infrastructure Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3481.1.patch.txt Close the driver object if it exists before creating another driver object. Bunch of HiveServer JDBC related unit tests are failing because of these file handle leaks. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3478) Remove the specialized logic to handle the file schemas in windows vs unix from build.xml
[ https://issues.apache.org/jira/browse/HIVE-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3478: Attachment: HIVE-3478.1.patch.txt Attached the patch. Remove the specialized logic to handle the file schemas in windows vs unix from build.xml - Key: HIVE-3478 URL: https://issues.apache.org/jira/browse/HIVE-3478 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3478.1.patch.txt After more testing, I realized that this special check can be removed by changing the “\\” with “\\\” to work on both platforms -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3478) Remove the specialized logic to handle the file schemas in windows vs unix from build.xml
[ https://issues.apache.org/jira/browse/HIVE-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3478: Status: Patch Available (was: In Progress) Remove the specialized logic to handle the file schemas in windows vs unix from build.xml - Key: HIVE-3478 URL: https://issues.apache.org/jira/browse/HIVE-3478 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3478.1.patch.txt After more testing, I realized that this special check can be removed by changing the “\\” with “\\\” to work on both platforms -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3478) Remove the specialized logic to handle the file schemas in windows vs unix from build.xml
[ https://issues.apache.org/jira/browse/HIVE-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13458297#comment-13458297 ] Kanna Karanam commented on HIVE-3478: - Please find the review request at https://reviews.apache.org/r/7150/ Remove the specialized logic to handle the file schemas in windows vs unix from build.xml - Key: HIVE-3478 URL: https://issues.apache.org/jira/browse/HIVE-3478 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3478.1.patch.txt After more testing, I realized that this special check can be removed by changing the “\\” with “\\\” to work on both platforms -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3481) Resource leak: Hiveserver is not closing the existing driver handle before executing the next command. It results in to file handle leaks.
[ https://issues.apache.org/jira/browse/HIVE-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13458303#comment-13458303 ] Kanna Karanam commented on HIVE-3481: - Please find the review request at https://reviews.apache.org/r/7151/. Thanks. Resource leak: Hiveserver is not closing the existing driver handle before executing the next command. It results in to file handle leaks. Key: HIVE-3481 URL: https://issues.apache.org/jira/browse/HIVE-3481 Project: Hive Issue Type: Bug Components: JDBC, ODBC, Server Infrastructure Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3481.1.patch.txt Close the driver object if it exists before creating another driver object. Bunch of HiveServer JDBC related unit tests are failing because of these file handle leaks. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3479) Bug fix: Return the child JVM exit code to the parent process to handle the error conditions
[ https://issues.apache.org/jira/browse/HIVE-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13458307#comment-13458307 ] Kanna Karanam commented on HIVE-3479: - Please find the review request at https://reviews.apache.org/r/7152/. Thanks Bug fix: Return the child JVM exit code to the parent process to handle the error conditions Key: HIVE-3479 URL: https://issues.apache.org/jira/browse/HIVE-3479 Project: Hive Issue Type: Bug Components: Testing Infrastructure Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3479.1.patch.txt It is a bug in the script and noticed it while fixing some of the Negative CLI test failures -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HIVE-3327) Remove the Unix specific absolute path of “Cat” utility in several .q files to make them run on Windows with CygWin in path.
Kanna Karanam created HIVE-3327: --- Summary: Remove the Unix specific absolute path of “Cat” utility in several .q files to make them run on Windows with CygWin in path. Key: HIVE-3327 URL: https://issues.apache.org/jira/browse/HIVE-3327 Project: Hive Issue Type: Sub-task Components: Tests, Windows Affects Versions: 0.9.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 Several .q files have Unix absolute paths for Cat utility so all of them are failing on Windows even with CygWin support. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3327) Remove the Unix specific absolute path of “Cat” utility in several .q files to make them run on Windows with CygWin in path.
[ https://issues.apache.org/jira/browse/HIVE-3327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3327: Attachment: HIVE-3327.1.patch.txt Attached the patch. CR is available at https://reviews.apache.org/r/6313/ . Thanks Remove the Unix specific absolute path of “Cat” utility in several .q files to make them run on Windows with CygWin in path. Key: HIVE-3327 URL: https://issues.apache.org/jira/browse/HIVE-3327 Project: Hive Issue Type: Sub-task Components: Tests, Windows Affects Versions: 0.9.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3327.1.patch.txt Several .q files have Unix absolute paths for Cat utility so all of them are failing on Windows even with CygWin support. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3327) Remove the Unix specific absolute path of “Cat” utility in several .q files to make them run on Windows with CygWin in path.
[ https://issues.apache.org/jira/browse/HIVE-3327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3327: Status: Patch Available (was: Open) Remove the Unix specific absolute path of “Cat” utility in several .q files to make them run on Windows with CygWin in path. Key: HIVE-3327 URL: https://issues.apache.org/jira/browse/HIVE-3327 Project: Hive Issue Type: Sub-task Components: Tests, Windows Affects Versions: 0.9.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3327.1.patch.txt Several .q files have Unix absolute paths for Cat utility so all of them are failing on Windows even with CygWin support. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HIVE-3317) Fix “TestDosToUnix” unit tests on Windows by closing the leaking file handle in DosToUnix.java.
Kanna Karanam created HIVE-3317: --- Summary: Fix “TestDosToUnix” unit tests on Windows by closing the leaking file handle in DosToUnix.java. Key: HIVE-3317 URL: https://issues.apache.org/jira/browse/HIVE-3317 Project: Hive Issue Type: Sub-task Components: Import/Export, Windows Affects Versions: 0.10.0, 0.9.1 Environment: Windows Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 Windows can’t delete the files if there are any open file handles on it so it is required to close them properly after completing the validation in DosToUnix utilities. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3317) Fix “TestDosToUnix” unit tests on Windows by closing the leaking file handle in DosToUnix.java.
[ https://issues.apache.org/jira/browse/HIVE-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3317: Attachment: HIVE-3317.1.patch.txt Attached the patch. Code review request is at https://reviews.apache.org/r/6213/ Fix “TestDosToUnix” unit tests on Windows by closing the leaking file handle in DosToUnix.java. --- Key: HIVE-3317 URL: https://issues.apache.org/jira/browse/HIVE-3317 Project: Hive Issue Type: Sub-task Components: Import/Export, Windows Affects Versions: 0.10.0, 0.9.1 Environment: Windows Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3317.1.patch.txt Windows can’t delete the files if there are any open file handles on it so it is required to close them properly after completing the validation in DosToUnix utilities. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3317) Fix “TestDosToUnix” unit tests on Windows by closing the leaking file handle in DosToUnix.java.
[ https://issues.apache.org/jira/browse/HIVE-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3317: Status: Patch Available (was: Open) Fix “TestDosToUnix” unit tests on Windows by closing the leaking file handle in DosToUnix.java. --- Key: HIVE-3317 URL: https://issues.apache.org/jira/browse/HIVE-3317 Project: Hive Issue Type: Sub-task Components: Import/Export, Windows Affects Versions: 0.10.0, 0.9.1 Environment: Windows Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3317.1.patch.txt Windows can’t delete the files if there are any open file handles on it so it is required to close them properly after completing the validation in DosToUnix utilities. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HIVE-3319) Fix the “TestHiveHistory”, “TestHiveConf”, “TestExecDriver” unit tests on Windows by fixing the path related issues.
Kanna Karanam created HIVE-3319: --- Summary: Fix the “TestHiveHistory”, “TestHiveConf”, “TestExecDriver” unit tests on Windows by fixing the path related issues. Key: HIVE-3319 URL: https://issues.apache.org/jira/browse/HIVE-3319 Project: Hive Issue Type: Sub-task Components: Tests, Windows Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam TestHiveConf : Location of the “hive-site.xml” path on Unix is different from Windows so need to compare the paths after generating the OS independent URI path. TestHiveHistory: Generate the testFileDirectory from URI object instead of manually constructing it to make it work on Unix as well as on Windows TestExecDriver: 1) Generate the testFileDirectory from URI object instead of manually constructing it to make it work on Unix as well as on Windows 2) change the absolute path to relative path of the “Cat” utility to make it work on windows with CygWin tools in the Windows Path. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3319) Fix the “TestHiveHistory”, “TestHiveConf”, “TestExecDriver” unit tests on Windows by fixing the path related issues.
[ https://issues.apache.org/jira/browse/HIVE-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3319: Status: Patch Available (was: Open) Fix the “TestHiveHistory”, “TestHiveConf”, “TestExecDriver” unit tests on Windows by fixing the path related issues. -- Key: HIVE-3319 URL: https://issues.apache.org/jira/browse/HIVE-3319 Project: Hive Issue Type: Sub-task Components: Tests, Windows Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Attachments: HIVE-3319.1.patch.txt TestHiveConf : Location of the “hive-site.xml” path on Unix is different from Windows so need to compare the paths after generating the OS independent URI path. TestHiveHistory: Generate the testFileDirectory from URI object instead of manually constructing it to make it work on Unix as well as on Windows TestExecDriver: 1) Generate the testFileDirectory from URI object instead of manually constructing it to make it work on Unix as well as on Windows 2) change the absolute path to relative path of the “Cat” utility to make it work on windows with CygWin tools in the Windows Path. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3319) Fix the “TestHiveHistory”, “TestHiveConf”, “TestExecDriver” unit tests on Windows by fixing the path related issues.
[ https://issues.apache.org/jira/browse/HIVE-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3319: Attachment: HIVE-3319.1.patch.txt Attached the patch. CR is available at https://reviews.apache.org/r/6214/. Thanks Fix the “TestHiveHistory”, “TestHiveConf”, “TestExecDriver” unit tests on Windows by fixing the path related issues. -- Key: HIVE-3319 URL: https://issues.apache.org/jira/browse/HIVE-3319 Project: Hive Issue Type: Sub-task Components: Tests, Windows Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Attachments: HIVE-3319.1.patch.txt TestHiveConf : Location of the “hive-site.xml” path on Unix is different from Windows so need to compare the paths after generating the OS independent URI path. TestHiveHistory: Generate the testFileDirectory from URI object instead of manually constructing it to make it work on Unix as well as on Windows TestExecDriver: 1) Generate the testFileDirectory from URI object instead of manually constructing it to make it work on Unix as well as on Windows 2) change the absolute path to relative path of the “Cat” utility to make it work on windows with CygWin tools in the Windows Path. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3319) Fix the “TestHiveHistory”, “TestHiveConf”, “TestExecDriver” unit tests on Windows by fixing the path related issues.
[ https://issues.apache.org/jira/browse/HIVE-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13425042#comment-13425042 ] Kanna Karanam commented on HIVE-3319: - @Edward – These unit tests are failing on Windows even with CygWin support because of the Unix absolute paths. We are taking dependency on “Cat, TR” Cygwin utilities to run the unit tests on windows. (We are using them as part of Script Descriptor) Thanks Fix the “TestHiveHistory”, “TestHiveConf”, “TestExecDriver” unit tests on Windows by fixing the path related issues. -- Key: HIVE-3319 URL: https://issues.apache.org/jira/browse/HIVE-3319 Project: Hive Issue Type: Sub-task Components: Tests, Windows Affects Versions: 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Attachments: HIVE-3319.1.patch.txt TestHiveConf : Location of the “hive-site.xml” path on Unix is different from Windows so need to compare the paths after generating the OS independent URI path. TestHiveHistory: Generate the testFileDirectory from URI object instead of manually constructing it to make it work on Unix as well as on Windows TestExecDriver: 1) Generate the testFileDirectory from URI object instead of manually constructing it to make it work on Unix as well as on Windows 2) change the absolute path to relative path of the “Cat” utility to make it work on windows with CygWin tools in the Windows Path. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3317) Fix “TestDosToUnix” unit tests on Windows by closing the leaking file handle in DosToUnix.java.
[ https://issues.apache.org/jira/browse/HIVE-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3317: Attachment: HIVE-3317.2.patch.txt Thanks Edward. Attached the patch with updated comment. Thanks. Fix “TestDosToUnix” unit tests on Windows by closing the leaking file handle in DosToUnix.java. --- Key: HIVE-3317 URL: https://issues.apache.org/jira/browse/HIVE-3317 Project: Hive Issue Type: Sub-task Components: Import/Export, Windows Affects Versions: 0.10.0, 0.9.1 Environment: Windows Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3317.1.patch.txt, HIVE-3317.2.patch.txt Windows can’t delete the files if there are any open file handles on it so it is required to close them properly after completing the validation in DosToUnix utilities. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HIVE-3320) Handle “CRLF” line endings to avoid the extra spacing in generated test outputs in Windows. (Utilities.Java :: readColumn)
Kanna Karanam created HIVE-3320: --- Summary: Handle “CRLF” line endings to avoid the extra spacing in generated test outputs in Windows. (Utilities.Java :: readColumn) Key: HIVE-3320 URL: https://issues.apache.org/jira/browse/HIVE-3320 Project: Hive Issue Type: Sub-task Components: CLI, Tests, Windows Reporter: Kanna Karanam Assignee: Kanna Karanam Existing functionality in Hive is looking for the “LF” character to extract the lines from generated output before writing to the streaming object. Whereas in Windows, the line endings are “CRLF” characters so it is leaving the “CR” character before writing each line to the streaming object. This CR is introducing the extra empty lines in the generated test output and causing several test cases to fail on Windows. Attached the generated output for one of the unit test failures with extra space. (bucket1.q) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3320) Handle “CRLF” line endings to avoid the extra spacing in generated test outputs in Windows. (Utilities.Java :: readColumn)
[ https://issues.apache.org/jira/browse/HIVE-3320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3320: Attachment: bucket1.q.out.patch.txt Attached the sample output file for one of the test failures. Handle “CRLF” line endings to avoid the extra spacing in generated test outputs in Windows. (Utilities.Java :: readColumn) -- Key: HIVE-3320 URL: https://issues.apache.org/jira/browse/HIVE-3320 Project: Hive Issue Type: Sub-task Components: CLI, Tests, Windows Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Attachments: bucket1.q.out.patch.txt Existing functionality in Hive is looking for the “LF” character to extract the lines from generated output before writing to the streaming object. Whereas in Windows, the line endings are “CRLF” characters so it is leaving the “CR” character before writing each line to the streaming object. This CR is introducing the extra empty lines in the generated test output and causing several test cases to fail on Windows. Attached the generated output for one of the unit test failures with extra space. (bucket1.q) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3320) Handle “CRLF” line endings to avoid the extra spacing in generated test outputs in Windows. (Utilities.Java :: readColumn)
[ https://issues.apache.org/jira/browse/HIVE-3320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3320: Attachment: HIVE-3320.1.patch.txt Attached the patch. CR is available at https://reviews.apache.org/r/6215/ . Thanks Handle “CRLF” line endings to avoid the extra spacing in generated test outputs in Windows. (Utilities.Java :: readColumn) -- Key: HIVE-3320 URL: https://issues.apache.org/jira/browse/HIVE-3320 Project: Hive Issue Type: Sub-task Components: CLI, Tests, Windows Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Attachments: HIVE-3320.1.patch.txt, bucket1.q.out.patch.txt Existing functionality in Hive is looking for the “LF” character to extract the lines from generated output before writing to the streaming object. Whereas in Windows, the line endings are “CRLF” characters so it is leaving the “CR” character before writing each line to the streaming object. This CR is introducing the extra empty lines in the generated test output and causing several test cases to fail on Windows. Attached the generated output for one of the unit test failures with extra space. (bucket1.q) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3126) Generate build the velocity based Hive tests on windows by fixing the path issues
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13421569#comment-13421569 ] Kanna Karanam commented on HIVE-3126: - @Carl, @Ashutosh - can you please review the updated diff? Thanks. Generate build the velocity based Hive tests on windows by fixing the path issues --- Key: HIVE-3126 URL: https://issues.apache.org/jira/browse/HIVE-3126 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.9.0, 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows, test Fix For: 0.10.0 Attachments: HIVE-3126.1.patch.txt, HIVE-3126.10.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt, HIVE-3126.6.patch.txt, HIVE-3126.7.patch.txt, HIVE-3126.8.patch.txt, HIVE-3126.9.patch.txt 1)Escape the backward slash in Canonical Path if unit test runs on windows. 2)Diff comparison – a. Ignore the extra spacing on windows b. Ignore the different line endings on windows Unix c. Convert the file paths to windows specific. (Handle spaces etc..) 3)Set the right file scheme class path separators while invoking the junit task from -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3126) Generate build the velocity based Hive tests on windows by fixing the path issues
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13421947#comment-13421947 ] Kanna Karanam commented on HIVE-3126: - Thanks Ashutosh, Carl. This JIRA helps developers to build, develop , debug hive on windows. I am not done yet until I fix all other unit test failures but it helps the community to play on windows. Generate build the velocity based Hive tests on windows by fixing the path issues --- Key: HIVE-3126 URL: https://issues.apache.org/jira/browse/HIVE-3126 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.9.0, 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows, test Fix For: 0.10.0 Attachments: HIVE-3126.1.patch.txt, HIVE-3126.10.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt, HIVE-3126.6.patch.txt, HIVE-3126.7.patch.txt, HIVE-3126.8.patch.txt, HIVE-3126.9.patch.txt 1)Escape the backward slash in Canonical Path if unit test runs on windows. 2)Diff comparison – a. Ignore the extra spacing on windows b. Ignore the different line endings on windows Unix c. Convert the file paths to windows specific. (Handle spaces etc..) 3)Set the right file scheme class path separators while invoking the junit task from -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3126) Generate build the velocity based Hive tests on windows by fixing the path issues
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3126: Attachment: HIVE-3126.10.patch.txt Updated the patch with latest source fixed the windows path related issue to make more unit tests run on windows. Generate build the velocity based Hive tests on windows by fixing the path issues --- Key: HIVE-3126 URL: https://issues.apache.org/jira/browse/HIVE-3126 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.9.0, 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows, test Fix For: 0.10.0 Attachments: HIVE-3126.1.patch.txt, HIVE-3126.10.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt, HIVE-3126.6.patch.txt, HIVE-3126.7.patch.txt, HIVE-3126.8.patch.txt, HIVE-3126.9.patch.txt 1)Escape the backward slash in Canonical Path if unit test runs on windows. 2)Diff comparison – a. Ignore the extra spacing on windows b. Ignore the different line endings on windows Unix c. Convert the file paths to windows specific. (Handle spaces etc..) 3)Set the right file scheme class path separators while invoking the junit task from -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3126) Generate build the velocity based Hive tests on windows by fixing the path issues
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3126: Attachment: HIVE-3126.9.patch.txt Thanks Carl. Can you please review the update diff. Generate build the velocity based Hive tests on windows by fixing the path issues --- Key: HIVE-3126 URL: https://issues.apache.org/jira/browse/HIVE-3126 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.9.0, 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows, test Fix For: 0.10.0 Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt, HIVE-3126.6.patch.txt, HIVE-3126.7.patch.txt, HIVE-3126.8.patch.txt, HIVE-3126.9.patch.txt 1)Escape the backward slash in Canonical Path if unit test runs on windows. 2)Diff comparison – a. Ignore the extra spacing on windows b. Ignore the different line endings on windows Unix c. Convert the file paths to windows specific. (Handle spaces etc..) 3)Set the right file scheme class path separators while invoking the junit task from -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3126) Generate build the velocity based Hive tests on windows by fixing the path issues
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3126: Status: Patch Available (was: Open) Generate build the velocity based Hive tests on windows by fixing the path issues --- Key: HIVE-3126 URL: https://issues.apache.org/jira/browse/HIVE-3126 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.9.0, 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows, test Fix For: 0.10.0 Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt, HIVE-3126.6.patch.txt, HIVE-3126.7.patch.txt, HIVE-3126.8.patch.txt, HIVE-3126.9.patch.txt 1)Escape the backward slash in Canonical Path if unit test runs on windows. 2)Diff comparison – a. Ignore the extra spacing on windows b. Ignore the different line endings on windows Unix c. Convert the file paths to windows specific. (Handle spaces etc..) 3)Set the right file scheme class path separators while invoking the junit task from -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3126) Generate build the velocity based Hive tests on windows by fixing the path issues
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13418816#comment-13418816 ] Kanna Karanam commented on HIVE-3126: - @Carl – I added some follow up comments. can you please look into them? Generate build the velocity based Hive tests on windows by fixing the path issues --- Key: HIVE-3126 URL: https://issues.apache.org/jira/browse/HIVE-3126 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.9.0, 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows, test Fix For: 0.10.0 Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt, HIVE-3126.6.patch.txt, HIVE-3126.7.patch.txt, HIVE-3126.8.patch.txt 1)Escape the backward slash in Canonical Path if unit test runs on windows. 2)Diff comparison – a. Ignore the extra spacing on windows b. Ignore the different line endings on windows Unix c. Convert the file paths to windows specific. (Handle spaces etc..) 3)Set the right file scheme class path separators while invoking the junit task from -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3126) Generate build the velocity based Hive tests on windows by fixing the path issues
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3126: Attachment: HIVE-3126.8.patch.txt Thanks Carl. Updated the diff with some of your suggestions. Generate build the velocity based Hive tests on windows by fixing the path issues --- Key: HIVE-3126 URL: https://issues.apache.org/jira/browse/HIVE-3126 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.9.0, 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows, test Fix For: 0.10.0 Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt, HIVE-3126.6.patch.txt, HIVE-3126.7.patch.txt, HIVE-3126.8.patch.txt 1)Escape the backward slash in Canonical Path if unit test runs on windows. 2)Diff comparison – a. Ignore the extra spacing on windows b. Ignore the different line endings on windows Unix c. Convert the file paths to windows specific. (Handle spaces etc..) 3)Set the right file scheme class path separators while invoking the junit task from -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3126) Generate build the velocity based Hive tests on windows by fixing the path issues
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3126: Status: Patch Available (was: Open) Generate build the velocity based Hive tests on windows by fixing the path issues --- Key: HIVE-3126 URL: https://issues.apache.org/jira/browse/HIVE-3126 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.9.0, 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows, test Fix For: 0.10.0 Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt, HIVE-3126.6.patch.txt, HIVE-3126.7.patch.txt, HIVE-3126.8.patch.txt 1)Escape the backward slash in Canonical Path if unit test runs on windows. 2)Diff comparison – a. Ignore the extra spacing on windows b. Ignore the different line endings on windows Unix c. Convert the file paths to windows specific. (Handle spaces etc..) 3)Set the right file scheme class path separators while invoking the junit task from -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3126) Generate build the velocity based Hive tests on windows by fixing the path issues
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3126: Attachment: HIVE-3126.7.patch.txt Addressed Ashutosh’s review comments and updated the diff file. Thanks Generate build the velocity based Hive tests on windows by fixing the path issues --- Key: HIVE-3126 URL: https://issues.apache.org/jira/browse/HIVE-3126 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.9.0, 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows, test Fix For: 0.10.0 Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt, HIVE-3126.6.patch.txt, HIVE-3126.7.patch.txt 1)Escape the backward slash in Canonical Path if unit test runs on windows. 2)Diff comparison – a. Ignore the extra spacing on windows b. Ignore the different line endings on windows Unix c. Convert the file paths to windows specific. (Handle spaces etc..) 3)Set the right file scheme class path separators while invoking the junit task from -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3204) Windows: Fix the unit tests which contains “!cmd” commands (Unix shell commands)
[ https://issues.apache.org/jira/browse/HIVE-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3204: Attachment: HIVE-3204.2.patch.txt Thanks Ashutosh. Please find more info below. 1)If I understand correctly, the intent of this delete is to avoid the cascading failures. If one test fails before cleaning up the directory, then rest of the tests which are depending on this directory will fail automatically so we may want to keep this logic to avoid this cascading affect. 2)ls with no optional arguments in Unix will display just file names. (these are 1, 2, 4). But when it comes to DFS -ls, it displays file names along with their attributes. (Permissions, Creation time, last modified time etc..) and these attributes are non-deterministic so we are masking them. 3)Removed the white space changes and uploaded the new patch. Thnaks Windows: Fix the unit tests which contains “!cmd” commands (Unix shell commands) -- Key: HIVE-3204 URL: https://issues.apache.org/jira/browse/HIVE-3204 Project: Hive Issue Type: Sub-task Components: Tests, Windows Affects Versions: 0.10.0 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0 Attachments: HIVE-3204.1.patch.txt, HIVE-3204.2.patch.txt Possible solution 1: (Preferred one) !Unix cmd | Windows cmd = Keeping the same syntax. Hive uses Java runtime to launch the shell command so any attempt to run windows commands on Unix will fail and vice versa. To deal with unit tests. Unix commands in each .q file will be modified as shown below. I will filter out the !commands which can’t be run on the current . Original entry in.q file: !rm -rf ../build/ql/test/data/exports/exim_department; It will be replaced with the following entries. UNIX::!rm -rf ../build/ql/test/data/exports/exim_department; WINDOWS::!del ../build/ql/test/data/exports/exim_department Possible solution 2: Provide a Shell UDF library(JAVA Based code)to support platform independent shell functionality Cons – 1) Difficult to provide full shell functionality 2) Takes long time 3) Difficult to manage -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3242) Fix cascade_dbdrop.q when building hive on hadoop0.23
[ https://issues.apache.org/jira/browse/HIVE-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13409052#comment-13409052 ] Kanna Karanam commented on HIVE-3242: - @Zhenxiao - if possible, can you please update TestHBaseCliDriver.vm with the same changes to keep all VM files in sync for better maintenance. Thanks Fix cascade_dbdrop.q when building hive on hadoop0.23 - Key: HIVE-3242 URL: https://issues.apache.org/jira/browse/HIVE-3242 Project: Hive Issue Type: Bug Reporter: Zhenxiao Luo Assignee: Zhenxiao Luo Attachments: HIVE-3242.1.patch.txt, HIVE-3242.2.patch.txt cascade_dbdrop.q is failing when building hive on hadoop0.23: Failing with the following diff: -Command failed with exit code = -1 +Command failed with exit code = 1 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3240) Fix non-deterministic results in newline.q and timestamp_lazy.q
[ https://issues.apache.org/jira/browse/HIVE-3240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13409137#comment-13409137 ] Kanna Karanam commented on HIVE-3240: - Thanks Zhenxiao. These are good changes. Instead of selecting all rows and then displaying them in order, can we just go with displaying the count of records in the table so that it works on Unix as well as on Windows (Windows has a problem with extra white spacing.. in this case they are new line records) Fix non-deterministic results in newline.q and timestamp_lazy.q --- Key: HIVE-3240 URL: https://issues.apache.org/jira/browse/HIVE-3240 Project: Hive Issue Type: Bug Components: Tests Reporter: Zhenxiao Luo Assignee: Zhenxiao Luo Attachments: HIVE-3240.1.patch.txt newline.q and timestamp_lazy.q have non-deterministic results, which make them fail on MapReduce2 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3242) Fix cascade_dbdrop.q when building hive on hadoop0.23
[ https://issues.apache.org/jira/browse/HIVE-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13409140#comment-13409140 ] Kanna Karanam commented on HIVE-3242: - Thanks Zhenxiao. The changes look good to me but I am not 100% sure with forking of .q files for different Hadoop versions. I will leave it for experts to comment. Fix cascade_dbdrop.q when building hive on hadoop0.23 - Key: HIVE-3242 URL: https://issues.apache.org/jira/browse/HIVE-3242 Project: Hive Issue Type: Bug Reporter: Zhenxiao Luo Assignee: Zhenxiao Luo Attachments: HIVE-3242.1.patch.txt, HIVE-3242.2.patch.txt, HIVE-3242.3.patch.txt cascade_dbdrop.q is failing when building hive on hadoop0.23: Failing with the following diff: -Command failed with exit code = -1 +Command failed with exit code = 1 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3240) Fix non-deterministic results in newline.q and timestamp_lazy.q
[ https://issues.apache.org/jira/browse/HIVE-3240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3240: Attachment: Windows_alter1.q.out.patch.txt @Edward – I do agree with you. Unit test shouldn’t restrict us on what to test and what not. Apart from the differences in new line characters, “ToString()” on some objects are introducing extra lines/spaces at the end on Windows compare to Unix and it is causing some tests fail. Here is the diff for “alter1.q” on windows. (Note: I trimmed the CR characters to minimize the patch) Coming to this Jira – timestamp_lazy.q is passing with no issues. I couldn’t run newline/q test yet on windows because of some Path/Perl related issue. Fix non-deterministic results in newline.q and timestamp_lazy.q --- Key: HIVE-3240 URL: https://issues.apache.org/jira/browse/HIVE-3240 Project: Hive Issue Type: Bug Components: Tests Reporter: Zhenxiao Luo Assignee: Zhenxiao Luo Attachments: HIVE-3240.1.patch.txt, Windows_alter1.q.out.patch.txt newline.q and timestamp_lazy.q have non-deterministic results, which make them fail on MapReduce2 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3240) Fix non-deterministic results in newline.q and timestamp_lazy.q
[ https://issues.apache.org/jira/browse/HIVE-3240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13409179#comment-13409179 ] Kanna Karanam commented on HIVE-3240: - Corrected: ToString()” on some objects are introducing differences in white lines/spaces on Windows compare to Unix and it is causing some tests fail Fix non-deterministic results in newline.q and timestamp_lazy.q --- Key: HIVE-3240 URL: https://issues.apache.org/jira/browse/HIVE-3240 Project: Hive Issue Type: Bug Components: Tests Reporter: Zhenxiao Luo Assignee: Zhenxiao Luo Attachments: HIVE-3240.1.patch.txt, Windows_alter1.q.out.patch.txt newline.q and timestamp_lazy.q have non-deterministic results, which make them fail on MapReduce2 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2485) LOAD DATA LOCAL Leaves Files Hanging Open
[ https://issues.apache.org/jira/browse/HIVE-2485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13408750#comment-13408750 ] Kanna Karanam commented on HIVE-2485: - @Edward - I fixed one resource leak in Hadoop sequence file constructor (HADOOP-8486). It may be related to this issue. Thanks LOAD DATA LOCAL Leaves Files Hanging Open - Key: HIVE-2485 URL: https://issues.apache.org/jira/browse/HIVE-2485 Project: Hive Issue Type: Bug Components: CLI Affects Versions: 0.7.1 Environment: Linux - Hadoop 0.20.204 Hive 0.7.0, Hive 0.7.1, Hive 0.8.0, trunk Reporter: J. Chris Folsom Attachments: CopyTask.java When loading multiple files using the statement: DROP TABLE partition_test; CREATE TABLE partition_test (key INT, value STRING) PARTITIONED BY (ts STRING) STORED AS TEXTFILE; LOAD DATA LOCAL INPATH 'file:/myfile.txt' OVERWRITE INTO TABLE partition_test PARTITION(ts='1'); LOAD DATA LOCAL INPATH 'file:/myfile2.txt' OVERWRITE INTO TABLE partition_test PARTITION(ts='2'); LOAD DATA LOCAL INPATH 'file:/myfile3.txt' OVERWRITE INTO TABLE partition_test PARTITION(ts='3'); etc. up to 250... Hive CLI fails with error: Failed with exception null hive.log: 2011-10-05 15:07:11,899 WARN hdfs.DFSClient (DFSClient.java:processDatanodeError(2667)) - Error Recovery for block blk_-7990368440974156305_1721 bad datanode[0] nodes == null 2011-10-05 15:07:11,899 WARN hdfs.DFSClient (DFSClient.java:processDatanodeError(2695)) - Could not get block locations. Source file /tmp/hive-cfolsom/hive_2011-10-05_15-06-47_812_4664863850423838867/-ext-1/kv1.txt - Aborting... 2011-10-05 15:07:11,900 ERROR exec.Task (SessionState.java:printError(365)) - Failed with exception null java.io.EOFException at java.io.DataInputStream.readShort(DataInputStream.java:298) at org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.createBlockOutputStream(DFSClient.java:3065) at org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.nextBlockOutputStream(DFSClient.java:2988) at org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.access$2000(DFSClient.java:2260) at org.apache.hadoop.hdfs.DFSClient$DFSOutputStream$DataStreamer.run(DFSClient.java:2451) 2011-10-05 15:07:11,901 ERROR hdfs.DFSClient (DFSClient.java:close(1125)) - Exception closing file /tmp/hive-cfolsom/hive_2011-10-05_15-06-47_812_4664863850423838867/-ext-1/kv1.txt : java.io.EOFException java.io.EOFException at java.io.DataInputStream.readShort(DataInputStream.java:298) at org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.createBlockOutputStream(DFSClient.java:3065) at org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.nextBlockOutputStream(DFSClient.java:2988) at org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.access$2000(DFSClient.java:2260) at org.apache.hadoop.hdfs.DFSClient$DFSOutputStream$DataStreamer.run(DFSClient.java:2451) 2011-10-05 15:07:12,002 ERROR ql.Driver (SessionState.java:printError(365)) - FAILED: Execution Error, return code 1 from org.apache.hadoop.hive.ql.exec.CopyTask Hadoop datanode log: there are too many open files: java.io.FileNotFoundException: /tmp/hadoop-hadoop/dfs/data/current/subdir4/blk_207900366872942737 (Too many open files) at java.io.RandomAccessFile.open(Native Method) at java.io.RandomAccessFile.init(RandomAccessFile.java:212) at org.apache.hadoop.hdfs.server.datanode.FSDataset.getBlockInputStream(FSDataset.java:862) at org.apache.hadoop.hdfs.server.datanode.BlockSender.init(BlockSender.java:166) at org.apache.hadoop.hdfs.server.datanode.DataXceiver.readBlock(DataXceiver.java:189) at org.apache.hadoop.hdfs.server.datanode.DataXceiver.run(DataXceiver.java:99) at java.lang.Thread.run(Thread.java:619) 2011-10-05 15:06:14,532 ERROR org.apache.hadoop.hdfs.server.datanode.DataNode: DatanodeRegistration(127.0.0.1:50010, storageID=DS-1718046113-127.0.0.1-50010-1317838257821, infoPort=50075, ipcPort=50020):DataXceiver java.io.FileNotFoundException: /tmp/hadoop-hadoop/dfs/data/current/subdir4/blk_207900366872942737 (Too many open files) at java.io.RandomAccessFile.open(Native Method) at java.io.RandomAccessFile.init(RandomAccessFile.java:212) at org.apache.hadoop.hdfs.server.datanode.FSDataset.getBlockInputStream(FSDataset.java:862) at org.apache.hadoop.hdfs.server.datanode.BlockSender.init(BlockSender.java:166) at org.apache.hadoop.hdfs.server.datanode.DataXceiver.readBlock(DataXceiver.java:189) at org.apache.hadoop.hdfs.server.datanode.DataXceiver.run(DataXceiver.java:99) at java.lang.Thread.run(Thread.java:619)
[jira] [Commented] (HIVE-2485) LOAD DATA LOCAL Leaves Files Hanging Open
[ https://issues.apache.org/jira/browse/HIVE-2485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13408841#comment-13408841 ] Kanna Karanam commented on HIVE-2485: - I noticed this problem with MoveTask::execute (Not with Copy Task) at the following code. While checking the file format, we are attempting to create the SequenceFile to validate the file format. If the given file is not a valid sequence file then it is resulting into a resource leak with Hadoop v1.x or lower. if (HiveConf.getBoolVar(conf, HiveConf.ConfVars.HIVECHECKFILEFORMAT)) { // Check if the file format of the file matches that of the table. boolean flag = HiveFileFormatUtils.checkInputFormat( Thanks LOAD DATA LOCAL Leaves Files Hanging Open - Key: HIVE-2485 URL: https://issues.apache.org/jira/browse/HIVE-2485 Project: Hive Issue Type: Bug Components: CLI Affects Versions: 0.7.1 Environment: Linux - Hadoop 0.20.204 Hive 0.7.0, Hive 0.7.1, Hive 0.8.0, trunk Reporter: J. Chris Folsom Attachments: CopyTask.java When loading multiple files using the statement: DROP TABLE partition_test; CREATE TABLE partition_test (key INT, value STRING) PARTITIONED BY (ts STRING) STORED AS TEXTFILE; LOAD DATA LOCAL INPATH 'file:/myfile.txt' OVERWRITE INTO TABLE partition_test PARTITION(ts='1'); LOAD DATA LOCAL INPATH 'file:/myfile2.txt' OVERWRITE INTO TABLE partition_test PARTITION(ts='2'); LOAD DATA LOCAL INPATH 'file:/myfile3.txt' OVERWRITE INTO TABLE partition_test PARTITION(ts='3'); etc. up to 250... Hive CLI fails with error: Failed with exception null hive.log: 2011-10-05 15:07:11,899 WARN hdfs.DFSClient (DFSClient.java:processDatanodeError(2667)) - Error Recovery for block blk_-7990368440974156305_1721 bad datanode[0] nodes == null 2011-10-05 15:07:11,899 WARN hdfs.DFSClient (DFSClient.java:processDatanodeError(2695)) - Could not get block locations. Source file /tmp/hive-cfolsom/hive_2011-10-05_15-06-47_812_4664863850423838867/-ext-1/kv1.txt - Aborting... 2011-10-05 15:07:11,900 ERROR exec.Task (SessionState.java:printError(365)) - Failed with exception null java.io.EOFException at java.io.DataInputStream.readShort(DataInputStream.java:298) at org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.createBlockOutputStream(DFSClient.java:3065) at org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.nextBlockOutputStream(DFSClient.java:2988) at org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.access$2000(DFSClient.java:2260) at org.apache.hadoop.hdfs.DFSClient$DFSOutputStream$DataStreamer.run(DFSClient.java:2451) 2011-10-05 15:07:11,901 ERROR hdfs.DFSClient (DFSClient.java:close(1125)) - Exception closing file /tmp/hive-cfolsom/hive_2011-10-05_15-06-47_812_4664863850423838867/-ext-1/kv1.txt : java.io.EOFException java.io.EOFException at java.io.DataInputStream.readShort(DataInputStream.java:298) at org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.createBlockOutputStream(DFSClient.java:3065) at org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.nextBlockOutputStream(DFSClient.java:2988) at org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.access$2000(DFSClient.java:2260) at org.apache.hadoop.hdfs.DFSClient$DFSOutputStream$DataStreamer.run(DFSClient.java:2451) 2011-10-05 15:07:12,002 ERROR ql.Driver (SessionState.java:printError(365)) - FAILED: Execution Error, return code 1 from org.apache.hadoop.hive.ql.exec.CopyTask Hadoop datanode log: there are too many open files: java.io.FileNotFoundException: /tmp/hadoop-hadoop/dfs/data/current/subdir4/blk_207900366872942737 (Too many open files) at java.io.RandomAccessFile.open(Native Method) at java.io.RandomAccessFile.init(RandomAccessFile.java:212) at org.apache.hadoop.hdfs.server.datanode.FSDataset.getBlockInputStream(FSDataset.java:862) at org.apache.hadoop.hdfs.server.datanode.BlockSender.init(BlockSender.java:166) at org.apache.hadoop.hdfs.server.datanode.DataXceiver.readBlock(DataXceiver.java:189) at org.apache.hadoop.hdfs.server.datanode.DataXceiver.run(DataXceiver.java:99) at java.lang.Thread.run(Thread.java:619) 2011-10-05 15:06:14,532 ERROR org.apache.hadoop.hdfs.server.datanode.DataNode: DatanodeRegistration(127.0.0.1:50010, storageID=DS-1718046113-127.0.0.1-50010-1317838257821, infoPort=50075, ipcPort=50020):DataXceiver java.io.FileNotFoundException: /tmp/hadoop-hadoop/dfs/data/current/subdir4/blk_207900366872942737 (Too many open files) at java.io.RandomAccessFile.open(Native Method) at java.io.RandomAccessFile.init(RandomAccessFile.java:212) at
[jira] [Updated] (HIVE-3204) Windows: Fix the unit tests which contains “!cmd” commands (Unix shell commands)
[ https://issues.apache.org/jira/browse/HIVE-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3204: Attachment: HIVE-3204.1.patch.txt Attached the patch. Replaced all “!cmd with DFS commands to run unit tests on Unix as well as Windows. Known Issue: Didn’t fix the ddltime.q unit test failure on windows yet. It has a “!sleep 1” command and I couldn’t invoke a simple java method to sleep for 1 sec. I will address this as a separate Jira as it requires more changes. SELECT java_method(java.lang.Thread, sleep, 1000) FROM src LIMIT 1; Windows: Fix the unit tests which contains “!cmd” commands (Unix shell commands) -- Key: HIVE-3204 URL: https://issues.apache.org/jira/browse/HIVE-3204 Project: Hive Issue Type: Sub-task Components: Tests, Windows Affects Versions: 0.10.0 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0 Attachments: HIVE-3204.1.patch.txt Possible solution 1: (Preferred one) !Unix cmd | Windows cmd = Keeping the same syntax. Hive uses Java runtime to launch the shell command so any attempt to run windows commands on Unix will fail and vice versa. To deal with unit tests. Unix commands in each .q file will be modified as shown below. I will filter out the !commands which can’t be run on the current . Original entry in.q file: !rm -rf ../build/ql/test/data/exports/exim_department; It will be replaced with the following entries. UNIX::!rm -rf ../build/ql/test/data/exports/exim_department; WINDOWS::!del ../build/ql/test/data/exports/exim_department Possible solution 2: Provide a Shell UDF library(JAVA Based code)to support platform independent shell functionality Cons – 1) Difficult to provide full shell functionality 2) Takes long time 3) Difficult to manage -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3204) Windows: Fix the unit tests which contains “!cmd” commands (Unix shell commands)
[ https://issues.apache.org/jira/browse/HIVE-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3204: Status: Patch Available (was: Open) Windows: Fix the unit tests which contains “!cmd” commands (Unix shell commands) -- Key: HIVE-3204 URL: https://issues.apache.org/jira/browse/HIVE-3204 Project: Hive Issue Type: Sub-task Components: Tests, Windows Affects Versions: 0.10.0 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0 Attachments: HIVE-3204.1.patch.txt Possible solution 1: (Preferred one) !Unix cmd | Windows cmd = Keeping the same syntax. Hive uses Java runtime to launch the shell command so any attempt to run windows commands on Unix will fail and vice versa. To deal with unit tests. Unix commands in each .q file will be modified as shown below. I will filter out the !commands which can’t be run on the current . Original entry in.q file: !rm -rf ../build/ql/test/data/exports/exim_department; It will be replaced with the following entries. UNIX::!rm -rf ../build/ql/test/data/exports/exim_department; WINDOWS::!del ../build/ql/test/data/exports/exim_department Possible solution 2: Provide a Shell UDF library(JAVA Based code)to support platform independent shell functionality Cons – 1) Difficult to provide full shell functionality 2) Takes long time 3) Difficult to manage -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3126) Generate build the velocity based Hive tests on windows by fixing the path issues
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3126: Attachment: HIVE-3126.5.patch.txt Updated the patch with latest OSS source. Generate build the velocity based Hive tests on windows by fixing the path issues --- Key: HIVE-3126 URL: https://issues.apache.org/jira/browse/HIVE-3126 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.9.0, 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows, test Fix For: 0.10.0 Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt 1)Escape the backward slash in Canonical Path if unit test runs on windows. 2)Diff comparison – a. Ignore the extra spacing on windows b. Ignore the different line endings on windows Unix c. Convert the file paths to windows specific. (Handle spaces etc..) 3)Set the right file scheme class path separators while invoking the junit task from -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3126) Generate build the velocity based Hive tests on windows by fixing the path issues
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3126: Attachment: HIVE-3126.6.patch.txt Updated with the correct patch. Generate build the velocity based Hive tests on windows by fixing the path issues --- Key: HIVE-3126 URL: https://issues.apache.org/jira/browse/HIVE-3126 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.9.0, 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows, test Fix For: 0.10.0 Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt, HIVE-3126.6.patch.txt 1)Escape the backward slash in Canonical Path if unit test runs on windows. 2)Diff comparison – a. Ignore the extra spacing on windows b. Ignore the different line endings on windows Unix c. Convert the file paths to windows specific. (Handle spaces etc..) 3)Set the right file scheme class path separators while invoking the junit task from -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HIVE-3232) Resource Leak: Fix the File handle leak in EximUtil.java
Kanna Karanam created HIVE-3232: --- Summary: Resource Leak: Fix the File handle leak in EximUtil.java Key: HIVE-3232 URL: https://issues.apache.org/jira/browse/HIVE-3232 Project: Hive Issue Type: Bug Components: Import/Export, Windows Affects Versions: 0.9.0, 0.8.1, 0.8.0, 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Fix For: 0.10.0, 0.9.1 1) Not closing the file handle EximUtil after reading the metadata from the file. 2) Nit: Get the path from URI to handle the Windows paths. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3232) Resource Leak: Fix the File handle leak in EximUtil.java
[ https://issues.apache.org/jira/browse/HIVE-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3232: Attachment: HIVE-3232.1.patch.txt Attached the patch Resource Leak: Fix the File handle leak in EximUtil.java Key: HIVE-3232 URL: https://issues.apache.org/jira/browse/HIVE-3232 Project: Hive Issue Type: Bug Components: Import/Export, Windows Affects Versions: 0.8.0, 0.8.1, 0.9.0, 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3232.1.patch.txt 1) Not closing the file handle EximUtil after reading the metadata from the file. 2) Nit: Get the path from URI to handle the Windows paths. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3232) Resource Leak: Fix the File handle leak in EximUtil.java
[ https://issues.apache.org/jira/browse/HIVE-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3232: Status: Patch Available (was: Open) Code review request is at https://reviews.apache.org/r/5777/ Resource Leak: Fix the File handle leak in EximUtil.java Key: HIVE-3232 URL: https://issues.apache.org/jira/browse/HIVE-3232 Project: Hive Issue Type: Bug Components: Import/Export, Windows Affects Versions: 0.9.0, 0.8.1, 0.8.0, 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Fix For: 0.10.0, 0.9.1 Attachments: HIVE-3232.1.patch.txt 1) Not closing the file handle EximUtil after reading the metadata from the file. 2) Nit: Get the path from URI to handle the Windows paths. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3126) Generate build the velocity based Hive tests on windows by fixing the path issues
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407492#comment-13407492 ] Kanna Karanam commented on HIVE-3126: - @Carl. Please let me know if you have any additional comments. Generate build the velocity based Hive tests on windows by fixing the path issues --- Key: HIVE-3126 URL: https://issues.apache.org/jira/browse/HIVE-3126 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.9.0, 0.10.0, 0.9.1 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows, test Fix For: 0.10.0 Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt 1)Escape the backward slash in Canonical Path if unit test runs on windows. 2)Diff comparison – a. Ignore the extra spacing on windows b. Ignore the different line endings on windows Unix c. Convert the file paths to windows specific. (Handle spaces etc..) 3)Set the right file scheme class path separators while invoking the junit task from -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3146) Support external hive tables whose data are stored in Azure blob store/Azure Storage Volumes (ASV)
[ https://issues.apache.org/jira/browse/HIVE-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3146: Attachment: HIVE-3146.3.patch.txt Updated the patch. Addressed the Ashutosh code review comments. Support external hive tables whose data are stored in Azure blob store/Azure Storage Volumes (ASV) -- Key: HIVE-3146 URL: https://issues.apache.org/jira/browse/HIVE-3146 Project: Hive Issue Type: Sub-task Components: Windows Affects Versions: 0.10.0 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Fix For: 0.10.0 Attachments: HIVE-3146.1.patch.txt, HIVE-3146.2.patch.txt, HIVE-3146.3.patch.txt Support external hive tables whose data are stored in Azure blob store/Azure Storage Volumes (ASV) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3146) Support external hive tables whose data are stored in Azure blob store/Azure Storage Volumes (ASV)
[ https://issues.apache.org/jira/browse/HIVE-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3146: Status: Patch Available (was: Open) Support external hive tables whose data are stored in Azure blob store/Azure Storage Volumes (ASV) -- Key: HIVE-3146 URL: https://issues.apache.org/jira/browse/HIVE-3146 Project: Hive Issue Type: Sub-task Components: Windows Affects Versions: 0.10.0 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Fix For: 0.10.0 Attachments: HIVE-3146.1.patch.txt, HIVE-3146.2.patch.txt, HIVE-3146.3.patch.txt Support external hive tables whose data are stored in Azure blob store/Azure Storage Volumes (ASV) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3146) Support external hive tables whose data are stored in Azure blob store/Azure Storage Volumes (ASV)
[ https://issues.apache.org/jira/browse/HIVE-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13405467#comment-13405467 ] Kanna Karanam commented on HIVE-3146: - Thanks Ashutosh. Support external hive tables whose data are stored in Azure blob store/Azure Storage Volumes (ASV) -- Key: HIVE-3146 URL: https://issues.apache.org/jira/browse/HIVE-3146 Project: Hive Issue Type: Sub-task Components: Windows Affects Versions: 0.10.0 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Fix For: 0.10.0 Attachments: HIVE-3146.1.patch.txt, HIVE-3146.2.patch.txt, HIVE-3146.3.patch.txt Support external hive tables whose data are stored in Azure blob store/Azure Storage Volumes (ASV) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3146) Support external hive tables whose data are stored in Azure blob store/Azure Storage Volumes (ASV)
[ https://issues.apache.org/jira/browse/HIVE-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3146: Attachment: HIVE-3146.2.patch.txt Attached the patch. Code review request for this patch is https://reviews.apache.org/r/5687/ Support external hive tables whose data are stored in Azure blob store/Azure Storage Volumes (ASV) -- Key: HIVE-3146 URL: https://issues.apache.org/jira/browse/HIVE-3146 Project: Hive Issue Type: Sub-task Components: Windows Affects Versions: 0.10.0 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Fix For: 0.10.0 Attachments: HIVE-3146.1.patch.txt, HIVE-3146.2.patch.txt Support external hive tables whose data are stored in Azure blob store/Azure Storage Volumes (ASV) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3146) Support external hive tables whose data are stored in Azure blob store/Azure Storage Volumes (ASV)
[ https://issues.apache.org/jira/browse/HIVE-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kanna Karanam updated HIVE-3146: Status: Patch Available (was: Open) Support external hive tables whose data are stored in Azure blob store/Azure Storage Volumes (ASV) -- Key: HIVE-3146 URL: https://issues.apache.org/jira/browse/HIVE-3146 Project: Hive Issue Type: Sub-task Components: Windows Affects Versions: 0.10.0 Reporter: Kanna Karanam Assignee: Kanna Karanam Labels: Windows Fix For: 0.10.0 Attachments: HIVE-3146.1.patch.txt, HIVE-3146.2.patch.txt Support external hive tables whose data are stored in Azure blob store/Azure Storage Volumes (ASV) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira