[jira] [Resolved] (HIVE-7185) KeyWrapperFactory#TextKeyWrapper#equals() extracts Text incorrectly when isCopy is false
[
https://issues.apache.org/jira/browse/HIVE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE resolved HIVE-7185.
--
Resolution: Won't Fix
KeyWrapperFactory#TextKeyWrapper#equals() extracts Text incorrectly when
isCopy is false
Key: HIVE-7185
URL: https://issues.apache.org/jira/browse/HIVE-7185
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-7185.patch
{code}
} else {
t1 = soi_new.getPrimitiveWritableObject(key);
t2 = soi_copy.getPrimitiveWritableObject(obj);
{code}
t2 should be assigned soi_new.getPrimitiveWritableObject(obj)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (HIVE-7754) Potential null pointer dereference in ColumnTruncateMapper#jobClose()
[
https://issues.apache.org/jira/browse/HIVE-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE resolved HIVE-7754.
--
Resolution: Fixed
Potential null pointer dereference in ColumnTruncateMapper#jobClose()
-
Key: HIVE-7754
URL: https://issues.apache.org/jira/browse/HIVE-7754
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
{code}
Utilities.mvFileToFinalPath(outputPath, job, success, LOG, dynPartCtx,
null,
reporter);
{code}
null is passed to Utilities.mvFileToFinalPath() which gets passed to
createEmptyBuckets() where:
{code}
boolean isCompressed = conf.getCompressed();
TableDesc tableInfo = conf.getTableInfo();
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8177) Wrong parameter order in ExplainTask#getJSONLogicalPlan()
[
https://issues.apache.org/jira/browse/HIVE-8177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-8177:
-
Attachment: (was: HIVE-8177.patch)
Wrong parameter order in ExplainTask#getJSONLogicalPlan()
-
Key: HIVE-8177
URL: https://issues.apache.org/jira/browse/HIVE-8177
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-8177.patch
{code}
JSONObject jsonPlan = outputMap(work.getParseContext().getTopOps(),
true,
out, jsonOutput, work.getExtended(), 0);
{code}
The order of 4th and 5th parameters is reverted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8177) Wrong parameter order in ExplainTask#getJSONLogicalPlan()
[
https://issues.apache.org/jira/browse/HIVE-8177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-8177:
-
Attachment: HIVE-8177.patch
Wrong parameter order in ExplainTask#getJSONLogicalPlan()
-
Key: HIVE-8177
URL: https://issues.apache.org/jira/browse/HIVE-8177
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-8177.patch
{code}
JSONObject jsonPlan = outputMap(work.getParseContext().getTopOps(),
true,
out, jsonOutput, work.getExtended(), 0);
{code}
The order of 4th and 5th parameters is reverted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8176) Close of FSDataOutputStream in OrcRecordUpdater ctor should be in finally clause
[
https://issues.apache.org/jira/browse/HIVE-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-8176:
-
Attachment: HIVE-8176.patch
Close of FSDataOutputStream in OrcRecordUpdater ctor should be in finally
clause
Key: HIVE-8176
URL: https://issues.apache.org/jira/browse/HIVE-8176
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-8176.patch, HIVE-8176.patch
{code}
try {
FSDataOutputStream strm = fs.create(new Path(path, ACID_FORMAT), false);
strm.writeInt(ORC_ACID_VERSION);
strm.close();
} catch (IOException ioe) {
{code}
If strm.writeInt() throws IOE, strm would be left unclosed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-7672) Potential resource leak in EximUtil#createExportDump()
[
https://issues.apache.org/jira/browse/HIVE-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-7672:
-
Attachment: HIVE-7672.patch
Potential resource leak in EximUtil#createExportDump()
--
Key: HIVE-7672
URL: https://issues.apache.org/jira/browse/HIVE-7672
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-7672.patch, HIVE-7672.patch
Here is related code:
{code}
OutputStream out = fs.create(metadataPath);
out.write(jsonContainer.toString().getBytes(UTF-8));
out.close();
{code}
If out.write() throws exception, out would be left unclosed.
out.close() should be enclosed in finally block.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-7672) Potential resource leak in EximUtil#createExportDump()
[
https://issues.apache.org/jira/browse/HIVE-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-7672:
-
Attachment: (was: HIVE-7672.patch)
Potential resource leak in EximUtil#createExportDump()
--
Key: HIVE-7672
URL: https://issues.apache.org/jira/browse/HIVE-7672
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-7672.patch
Here is related code:
{code}
OutputStream out = fs.create(metadataPath);
out.write(jsonContainer.toString().getBytes(UTF-8));
out.close();
{code}
If out.write() throws exception, out would be left unclosed.
out.close() should be enclosed in finally block.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-7598) Potential null pointer dereference in MergeTask#closeJob()
[
https://issues.apache.org/jira/browse/HIVE-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-7598:
-
Attachment: HIVE-7598.patch
Potential null pointer dereference in MergeTask#closeJob()
--
Key: HIVE-7598
URL: https://issues.apache.org/jira/browse/HIVE-7598
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-7598.patch
Call to Utilities.mvFileToFinalPath() passes null as second last parameter,
conf.
null gets passed to createEmptyBuckets() which dereferences conf directly:
{code}
boolean isCompressed = conf.getCompressed();
TableDesc tableInfo = conf.getTableInfo();
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-7598) Potential null pointer dereference in MergeTask#closeJob()
[
https://issues.apache.org/jira/browse/HIVE-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-7598:
-
Attachment: (was: HIVE-7598.patch)
Potential null pointer dereference in MergeTask#closeJob()
--
Key: HIVE-7598
URL: https://issues.apache.org/jira/browse/HIVE-7598
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-7598.patch
Call to Utilities.mvFileToFinalPath() passes null as second last parameter,
conf.
null gets passed to createEmptyBuckets() which dereferences conf directly:
{code}
boolean isCompressed = conf.getCompressed();
TableDesc tableInfo = conf.getTableInfo();
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8176) Close of FSDataOutputStream in OrcRecordUpdater ctor should be in finally clause
[
https://issues.apache.org/jira/browse/HIVE-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-8176:
-
Attachment: (was: HIVE-8176.patch)
Close of FSDataOutputStream in OrcRecordUpdater ctor should be in finally
clause
Key: HIVE-8176
URL: https://issues.apache.org/jira/browse/HIVE-8176
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-8176.patch
{code}
try {
FSDataOutputStream strm = fs.create(new Path(path, ACID_FORMAT), false);
strm.writeInt(ORC_ACID_VERSION);
strm.close();
} catch (IOException ioe) {
{code}
If strm.writeInt() throws IOE, strm would be left unclosed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-8176) Close of FSDataOutputStream in OrcRecordUpdater ctor should be in finally clause
[
https://issues.apache.org/jira/browse/HIVE-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145693#comment-14145693
]
SUYEON LEE commented on HIVE-8176:
--
i don't know why the test(testParse_union) always is failed? (Not only this
issue. i tried others)
Does anyone know about this? plz help me what to do.
Close of FSDataOutputStream in OrcRecordUpdater ctor should be in finally
clause
Key: HIVE-8176
URL: https://issues.apache.org/jira/browse/HIVE-8176
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-8176.patch
{code}
try {
FSDataOutputStream strm = fs.create(new Path(path, ACID_FORMAT), false);
strm.writeInt(ORC_ACID_VERSION);
strm.close();
} catch (IOException ioe) {
{code}
If strm.writeInt() throws IOE, strm would be left unclosed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (HIVE-8177) Wrong parameter order in ExplainTask#getJSONLogicalPlan()
[
https://issues.apache.org/jira/browse/HIVE-8177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE reassigned HIVE-8177:
Assignee: SUYEON LEE
Wrong parameter order in ExplainTask#getJSONLogicalPlan()
-
Key: HIVE-8177
URL: https://issues.apache.org/jira/browse/HIVE-8177
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
{code}
JSONObject jsonPlan = outputMap(work.getParseContext().getTopOps(),
true,
out, jsonOutput, work.getExtended(), 0);
{code}
The order of 4th and 5th parameters is reverted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8177) Wrong parameter order in ExplainTask#getJSONLogicalPlan()
[
https://issues.apache.org/jira/browse/HIVE-8177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-8177:
-
Attachment: HIVE-8177.patch
it has to change 4th, 5th parameter.
Wrong parameter order in ExplainTask#getJSONLogicalPlan()
-
Key: HIVE-8177
URL: https://issues.apache.org/jira/browse/HIVE-8177
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-8177.patch
{code}
JSONObject jsonPlan = outputMap(work.getParseContext().getTopOps(),
true,
out, jsonOutput, work.getExtended(), 0);
{code}
The order of 4th and 5th parameters is reverted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8177) Wrong parameter order in ExplainTask#getJSONLogicalPlan()
[
https://issues.apache.org/jira/browse/HIVE-8177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-8177:
-
Status: Patch Available (was: Open)
Wrong parameter order in ExplainTask#getJSONLogicalPlan()
-
Key: HIVE-8177
URL: https://issues.apache.org/jira/browse/HIVE-8177
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-8177.patch
{code}
JSONObject jsonPlan = outputMap(work.getParseContext().getTopOps(),
true,
out, jsonOutput, work.getExtended(), 0);
{code}
The order of 4th and 5th parameters is reverted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (HIVE-8176) Close of FSDataOutputStream in OrcRecordUpdater ctor should be in finally clause
[
https://issues.apache.org/jira/browse/HIVE-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE reassigned HIVE-8176:
Assignee: SUYEON LEE
Close of FSDataOutputStream in OrcRecordUpdater ctor should be in finally
clause
Key: HIVE-8176
URL: https://issues.apache.org/jira/browse/HIVE-8176
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
{code}
try {
FSDataOutputStream strm = fs.create(new Path(path, ACID_FORMAT), false);
strm.writeInt(ORC_ACID_VERSION);
strm.close();
} catch (IOException ioe) {
{code}
If strm.writeInt() throws IOE, strm would be left unclosed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8176) Close of FSDataOutputStream in OrcRecordUpdater ctor should be in finally clause
[
https://issues.apache.org/jira/browse/HIVE-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-8176:
-
Attachment: HIVE-8176.patch
i added finally statement that enclosed strm.close().
Close of FSDataOutputStream in OrcRecordUpdater ctor should be in finally
clause
Key: HIVE-8176
URL: https://issues.apache.org/jira/browse/HIVE-8176
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-8176.patch
{code}
try {
FSDataOutputStream strm = fs.create(new Path(path, ACID_FORMAT), false);
strm.writeInt(ORC_ACID_VERSION);
strm.close();
} catch (IOException ioe) {
{code}
If strm.writeInt() throws IOE, strm would be left unclosed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8176) Close of FSDataOutputStream in OrcRecordUpdater ctor should be in finally clause
[
https://issues.apache.org/jira/browse/HIVE-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-8176:
-
Status: Patch Available (was: Open)
Close of FSDataOutputStream in OrcRecordUpdater ctor should be in finally
clause
Key: HIVE-8176
URL: https://issues.apache.org/jira/browse/HIVE-8176
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-8176.patch
{code}
try {
FSDataOutputStream strm = fs.create(new Path(path, ACID_FORMAT), false);
strm.writeInt(ORC_ACID_VERSION);
strm.close();
} catch (IOException ioe) {
{code}
If strm.writeInt() throws IOE, strm would be left unclosed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8177) Wrong parameter order in ExplainTask#getJSONLogicalPlan()
[
https://issues.apache.org/jira/browse/HIVE-8177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-8177:
-
Attachment: HIVE-8177.patch
Wrong parameter order in ExplainTask#getJSONLogicalPlan()
-
Key: HIVE-8177
URL: https://issues.apache.org/jira/browse/HIVE-8177
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-8177.patch, HIVE-8177.patch
{code}
JSONObject jsonPlan = outputMap(work.getParseContext().getTopOps(),
true,
out, jsonOutput, work.getExtended(), 0);
{code}
The order of 4th and 5th parameters is reverted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8176) Close of FSDataOutputStream in OrcRecordUpdater ctor should be in finally clause
[
https://issues.apache.org/jira/browse/HIVE-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-8176:
-
Attachment: HIVE-8176.patch
Close of FSDataOutputStream in OrcRecordUpdater ctor should be in finally
clause
Key: HIVE-8176
URL: https://issues.apache.org/jira/browse/HIVE-8176
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-8176.patch, HIVE-8176.patch
{code}
try {
FSDataOutputStream strm = fs.create(new Path(path, ACID_FORMAT), false);
strm.writeInt(ORC_ACID_VERSION);
strm.close();
} catch (IOException ioe) {
{code}
If strm.writeInt() throws IOE, strm would be left unclosed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8177) Wrong parameter order in ExplainTask#getJSONLogicalPlan()
[
https://issues.apache.org/jira/browse/HIVE-8177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-8177:
-
Attachment: (was: HIVE-8177.patch)
Wrong parameter order in ExplainTask#getJSONLogicalPlan()
-
Key: HIVE-8177
URL: https://issues.apache.org/jira/browse/HIVE-8177
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
{code}
JSONObject jsonPlan = outputMap(work.getParseContext().getTopOps(),
true,
out, jsonOutput, work.getExtended(), 0);
{code}
The order of 4th and 5th parameters is reverted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8177) Wrong parameter order in ExplainTask#getJSONLogicalPlan()
[
https://issues.apache.org/jira/browse/HIVE-8177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-8177:
-
Attachment: (was: HIVE-8177.patch)
Wrong parameter order in ExplainTask#getJSONLogicalPlan()
-
Key: HIVE-8177
URL: https://issues.apache.org/jira/browse/HIVE-8177
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
{code}
JSONObject jsonPlan = outputMap(work.getParseContext().getTopOps(),
true,
out, jsonOutput, work.getExtended(), 0);
{code}
The order of 4th and 5th parameters is reverted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8177) Wrong parameter order in ExplainTask#getJSONLogicalPlan()
[
https://issues.apache.org/jira/browse/HIVE-8177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-8177:
-
Attachment: HIVE-8177.patch
Wrong parameter order in ExplainTask#getJSONLogicalPlan()
-
Key: HIVE-8177
URL: https://issues.apache.org/jira/browse/HIVE-8177
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-8177.patch
{code}
JSONObject jsonPlan = outputMap(work.getParseContext().getTopOps(),
true,
out, jsonOutput, work.getExtended(), 0);
{code}
The order of 4th and 5th parameters is reverted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8176) Close of FSDataOutputStream in OrcRecordUpdater ctor should be in finally clause
[
https://issues.apache.org/jira/browse/HIVE-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-8176:
-
Attachment: (was: HIVE-8176.patch)
Close of FSDataOutputStream in OrcRecordUpdater ctor should be in finally
clause
Key: HIVE-8176
URL: https://issues.apache.org/jira/browse/HIVE-8176
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-8176.patch
{code}
try {
FSDataOutputStream strm = fs.create(new Path(path, ACID_FORMAT), false);
strm.writeInt(ORC_ACID_VERSION);
strm.close();
} catch (IOException ioe) {
{code}
If strm.writeInt() throws IOE, strm would be left unclosed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8176) Close of FSDataOutputStream in OrcRecordUpdater ctor should be in finally clause
[
https://issues.apache.org/jira/browse/HIVE-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-8176:
-
Attachment: HIVE-8176.patch
Close of FSDataOutputStream in OrcRecordUpdater ctor should be in finally
clause
Key: HIVE-8176
URL: https://issues.apache.org/jira/browse/HIVE-8176
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-8176.patch
{code}
try {
FSDataOutputStream strm = fs.create(new Path(path, ACID_FORMAT), false);
strm.writeInt(ORC_ACID_VERSION);
strm.close();
} catch (IOException ioe) {
{code}
If strm.writeInt() throws IOE, strm would be left unclosed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8176) Close of FSDataOutputStream in OrcRecordUpdater ctor should be in finally clause
[
https://issues.apache.org/jira/browse/HIVE-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-8176:
-
Attachment: (was: HIVE-8176.patch)
Close of FSDataOutputStream in OrcRecordUpdater ctor should be in finally
clause
Key: HIVE-8176
URL: https://issues.apache.org/jira/browse/HIVE-8176
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-8176.patch
{code}
try {
FSDataOutputStream strm = fs.create(new Path(path, ACID_FORMAT), false);
strm.writeInt(ORC_ACID_VERSION);
strm.close();
} catch (IOException ioe) {
{code}
If strm.writeInt() throws IOE, strm would be left unclosed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-7672) Potential resource leak in EximUtil#createExportDump()
[
https://issues.apache.org/jira/browse/HIVE-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-7672:
-
Attachment: HIVE-7672.patch
Potential resource leak in EximUtil#createExportDump()
--
Key: HIVE-7672
URL: https://issues.apache.org/jira/browse/HIVE-7672
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-7672.patch
Here is related code:
{code}
OutputStream out = fs.create(metadataPath);
out.write(jsonContainer.toString().getBytes(UTF-8));
out.close();
{code}
If out.write() throws exception, out would be left unclosed.
out.close() should be enclosed in finally block.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-7672) Potential resource leak in EximUtil#createExportDump()
[
https://issues.apache.org/jira/browse/HIVE-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-7672:
-
Attachment: (was: HIVE-7672.patch)
Potential resource leak in EximUtil#createExportDump()
--
Key: HIVE-7672
URL: https://issues.apache.org/jira/browse/HIVE-7672
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-7672.patch
Here is related code:
{code}
OutputStream out = fs.create(metadataPath);
out.write(jsonContainer.toString().getBytes(UTF-8));
out.close();
{code}
If out.write() throws exception, out would be left unclosed.
out.close() should be enclosed in finally block.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-7598) Potential null pointer dereference in MergeTask#closeJob()
[
https://issues.apache.org/jira/browse/HIVE-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-7598:
-
Attachment: HIVE-7598.patch
Potential null pointer dereference in MergeTask#closeJob()
--
Key: HIVE-7598
URL: https://issues.apache.org/jira/browse/HIVE-7598
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-7598.patch
Call to Utilities.mvFileToFinalPath() passes null as second last parameter,
conf.
null gets passed to createEmptyBuckets() which dereferences conf directly:
{code}
boolean isCompressed = conf.getCompressed();
TableDesc tableInfo = conf.getTableInfo();
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-7598) Potential null pointer dereference in MergeTask#closeJob()
[
https://issues.apache.org/jira/browse/HIVE-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-7598:
-
Attachment: (was: HIVE-7598.patch)
Potential null pointer dereference in MergeTask#closeJob()
--
Key: HIVE-7598
URL: https://issues.apache.org/jira/browse/HIVE-7598
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-7598.patch
Call to Utilities.mvFileToFinalPath() passes null as second last parameter,
conf.
null gets passed to createEmptyBuckets() which dereferences conf directly:
{code}
boolean isCompressed = conf.getCompressed();
TableDesc tableInfo = conf.getTableInfo();
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-7672) Potential resource leak in EximUtil#createExportDump()
[
https://issues.apache.org/jira/browse/HIVE-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-7672:
-
Status: Open (was: Patch Available)
Potential resource leak in EximUtil#createExportDump()
--
Key: HIVE-7672
URL: https://issues.apache.org/jira/browse/HIVE-7672
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-7672.patch
Here is related code:
{code}
OutputStream out = fs.create(metadataPath);
out.write(jsonContainer.toString().getBytes(UTF-8));
out.close();
{code}
If out.write() throws exception, out would be left unclosed.
out.close() should be enclosed in finally block.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HIVE-7672) Potential resource leak in EximUtil#createExportDump()
[
https://issues.apache.org/jira/browse/HIVE-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-7672:
-
Status: Patch Available (was: Open)
Potential resource leak in EximUtil#createExportDump()
--
Key: HIVE-7672
URL: https://issues.apache.org/jira/browse/HIVE-7672
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-7672.patch
Here is related code:
{code}
OutputStream out = fs.create(metadataPath);
out.write(jsonContainer.toString().getBytes(UTF-8));
out.close();
{code}
If out.write() throws exception, out would be left unclosed.
out.close() should be enclosed in finally block.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HIVE-7598) Potential null pointer dereference in MergeTask#closeJob()
[
https://issues.apache.org/jira/browse/HIVE-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-7598:
-
Attachment: (was: HIVE-7598.patch)
Potential null pointer dereference in MergeTask#closeJob()
--
Key: HIVE-7598
URL: https://issues.apache.org/jira/browse/HIVE-7598
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-7598.patch
Call to Utilities.mvFileToFinalPath() passes null as second last parameter,
conf.
null gets passed to createEmptyBuckets() which dereferences conf directly:
{code}
boolean isCompressed = conf.getCompressed();
TableDesc tableInfo = conf.getTableInfo();
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HIVE-7598) Potential null pointer dereference in MergeTask#closeJob()
[
https://issues.apache.org/jira/browse/HIVE-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-7598:
-
Attachment: HIVE-7598.patch
Potential null pointer dereference in MergeTask#closeJob()
--
Key: HIVE-7598
URL: https://issues.apache.org/jira/browse/HIVE-7598
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-7598.patch
Call to Utilities.mvFileToFinalPath() passes null as second last parameter,
conf.
null gets passed to createEmptyBuckets() which dereferences conf directly:
{code}
boolean isCompressed = conf.getCompressed();
TableDesc tableInfo = conf.getTableInfo();
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Assigned] (HIVE-7754) Potential null pointer dereference in ColumnTruncateMapper#jobClose()
[
https://issues.apache.org/jira/browse/HIVE-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE reassigned HIVE-7754:
Assignee: SUYEON LEE
Potential null pointer dereference in ColumnTruncateMapper#jobClose()
-
Key: HIVE-7754
URL: https://issues.apache.org/jira/browse/HIVE-7754
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
{code}
Utilities.mvFileToFinalPath(outputPath, job, success, LOG, dynPartCtx,
null,
reporter);
{code}
null is passed to Utilities.mvFileToFinalPath() which gets passed to
createEmptyBuckets() where:
{code}
boolean isCompressed = conf.getCompressed();
TableDesc tableInfo = conf.getTableInfo();
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Assigned] (HIVE-7754) Potential null pointer dereference in ColumnTruncateMapper#jobClose()
[
https://issues.apache.org/jira/browse/HIVE-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE reassigned HIVE-7754:
Assignee: SUYEON LEE (was: KangHS)
Potential null pointer dereference in ColumnTruncateMapper#jobClose()
-
Key: HIVE-7754
URL: https://issues.apache.org/jira/browse/HIVE-7754
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
{code}
Utilities.mvFileToFinalPath(outputPath, job, success, LOG, dynPartCtx,
null,
reporter);
{code}
null is passed to Utilities.mvFileToFinalPath() which gets passed to
createEmptyBuckets() where:
{code}
boolean isCompressed = conf.getCompressed();
TableDesc tableInfo = conf.getTableInfo();
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HIVE-7672) Potential resource leak in EximUtil#createExportDump()
[
https://issues.apache.org/jira/browse/HIVE-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-7672:
-
Attachment: (was: HIVE-7672.patch)
Potential resource leak in EximUtil#createExportDump()
--
Key: HIVE-7672
URL: https://issues.apache.org/jira/browse/HIVE-7672
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-7672.patch
Here is related code:
{code}
OutputStream out = fs.create(metadataPath);
out.write(jsonContainer.toString().getBytes(UTF-8));
out.close();
{code}
If out.write() throws exception, out would be left unclosed.
out.close() should be enclosed in finally block.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HIVE-7672) Potential resource leak in EximUtil#createExportDump()
[
https://issues.apache.org/jira/browse/HIVE-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-7672:
-
Attachment: HIVE-7672.patch
I have changed the patch file. There was errors on previous file.
Potential resource leak in EximUtil#createExportDump()
--
Key: HIVE-7672
URL: https://issues.apache.org/jira/browse/HIVE-7672
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-7672.patch
Here is related code:
{code}
OutputStream out = fs.create(metadataPath);
out.write(jsonContainer.toString().getBytes(UTF-8));
out.close();
{code}
If out.write() throws exception, out would be left unclosed.
out.close() should be enclosed in finally block.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HIVE-7598) Potential null pointer dereference in MergeTask#closeJob()
[
https://issues.apache.org/jira/browse/HIVE-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-7598:
-
Attachment: HIVE-7598.patch
I have changed patch. There were errors on previous patch.
Potential null pointer dereference in MergeTask#closeJob()
--
Key: HIVE-7598
URL: https://issues.apache.org/jira/browse/HIVE-7598
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-7598.patch
Call to Utilities.mvFileToFinalPath() passes null as second last parameter,
conf.
null gets passed to createEmptyBuckets() which dereferences conf directly:
{code}
boolean isCompressed = conf.getCompressed();
TableDesc tableInfo = conf.getTableInfo();
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HIVE-7598) Potential null pointer dereference in MergeTask#closeJob()
[
https://issues.apache.org/jira/browse/HIVE-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-7598:
-
Attachment: (was: HIVE-7598.patch)
Potential null pointer dereference in MergeTask#closeJob()
--
Key: HIVE-7598
URL: https://issues.apache.org/jira/browse/HIVE-7598
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-7598.patch
Call to Utilities.mvFileToFinalPath() passes null as second last parameter,
conf.
null gets passed to createEmptyBuckets() which dereferences conf directly:
{code}
boolean isCompressed = conf.getCompressed();
TableDesc tableInfo = conf.getTableInfo();
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Work started] (HIVE-7754) Potential null pointer dereference in ColumnTruncateMapper#jobClose()
[
https://issues.apache.org/jira/browse/HIVE-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HIVE-7754 started by SUYEON LEE.
Potential null pointer dereference in ColumnTruncateMapper#jobClose()
-
Key: HIVE-7754
URL: https://issues.apache.org/jira/browse/HIVE-7754
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
{code}
Utilities.mvFileToFinalPath(outputPath, job, success, LOG, dynPartCtx,
null,
reporter);
{code}
null is passed to Utilities.mvFileToFinalPath() which gets passed to
createEmptyBuckets() where:
{code}
boolean isCompressed = conf.getCompressed();
TableDesc tableInfo = conf.getTableInfo();
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-7754) Potential null pointer dereference in ColumnTruncateMapper#jobClose()
[
https://issues.apache.org/jira/browse/HIVE-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14104959#comment-14104959
]
SUYEON LEE commented on HIVE-7754:
--
I already made patch for HIVE-7598. and I think this issue came from same
code(Utilities#createEmptyBuckets).
Check if patch i made is right or not.
Potential null pointer dereference in ColumnTruncateMapper#jobClose()
-
Key: HIVE-7754
URL: https://issues.apache.org/jira/browse/HIVE-7754
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
{code}
Utilities.mvFileToFinalPath(outputPath, job, success, LOG, dynPartCtx,
null,
reporter);
{code}
null is passed to Utilities.mvFileToFinalPath() which gets passed to
createEmptyBuckets() where:
{code}
boolean isCompressed = conf.getCompressed();
TableDesc tableInfo = conf.getTableInfo();
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Assigned] (HIVE-7672) Potential resource leak in EximUtil#createExportDump()
[
https://issues.apache.org/jira/browse/HIVE-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE reassigned HIVE-7672:
Assignee: SUYEON LEE
Potential resource leak in EximUtil#createExportDump()
--
Key: HIVE-7672
URL: https://issues.apache.org/jira/browse/HIVE-7672
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Here is related code:
{code}
OutputStream out = fs.create(metadataPath);
out.write(jsonContainer.toString().getBytes(UTF-8));
out.close();
{code}
If out.write() throws exception, out would be left unclosed.
out.close() should be enclosed in finally block.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HIVE-7672) Potential resource leak in EximUtil#createExportDump()
[
https://issues.apache.org/jira/browse/HIVE-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-7672:
-
Status: Patch Available (was: Open)
Potential resource leak in EximUtil#createExportDump()
--
Key: HIVE-7672
URL: https://issues.apache.org/jira/browse/HIVE-7672
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-7672.patch
Here is related code:
{code}
OutputStream out = fs.create(metadataPath);
out.write(jsonContainer.toString().getBytes(UTF-8));
out.close();
{code}
If out.write() throws exception, out would be left unclosed.
out.close() should be enclosed in finally block.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HIVE-7672) Potential resource leak in EximUtil#createExportDump()
[
https://issues.apache.org/jira/browse/HIVE-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-7672:
-
Attachment: HIVE-7672.patch
Potential resource leak in EximUtil#createExportDump()
--
Key: HIVE-7672
URL: https://issues.apache.org/jira/browse/HIVE-7672
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-7672.patch
Here is related code:
{code}
OutputStream out = fs.create(metadataPath);
out.write(jsonContainer.toString().getBytes(UTF-8));
out.close();
{code}
If out.write() throws exception, out would be left unclosed.
out.close() should be enclosed in finally block.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Assigned] (HIVE-7598) Potential null pointer dereference in MergeTask#closeJob()
[
https://issues.apache.org/jira/browse/HIVE-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE reassigned HIVE-7598:
Assignee: SUYEON LEE
Potential null pointer dereference in MergeTask#closeJob()
--
Key: HIVE-7598
URL: https://issues.apache.org/jira/browse/HIVE-7598
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Call to Utilities.mvFileToFinalPath() passes null as second last parameter,
conf.
null gets passed to createEmptyBuckets() which dereferences conf directly:
{code}
boolean isCompressed = conf.getCompressed();
TableDesc tableInfo = conf.getTableInfo();
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HIVE-7598) Potential null pointer dereference in MergeTask#closeJob()
[
https://issues.apache.org/jira/browse/HIVE-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-7598:
-
Status: Patch Available (was: Open)
Potential null pointer dereference in MergeTask#closeJob()
--
Key: HIVE-7598
URL: https://issues.apache.org/jira/browse/HIVE-7598
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Call to Utilities.mvFileToFinalPath() passes null as second last parameter,
conf.
null gets passed to createEmptyBuckets() which dereferences conf directly:
{code}
boolean isCompressed = conf.getCompressed();
TableDesc tableInfo = conf.getTableInfo();
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HIVE-7598) Potential null pointer dereference in MergeTask#closeJob()
[
https://issues.apache.org/jira/browse/HIVE-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-7598:
-
Attachment: HIVE-7598.patch
i think it has to check where null or not, before using conf variable.
so i changed the source like i attached.
Potential null pointer dereference in MergeTask#closeJob()
--
Key: HIVE-7598
URL: https://issues.apache.org/jira/browse/HIVE-7598
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-7598.patch
Call to Utilities.mvFileToFinalPath() passes null as second last parameter,
conf.
null gets passed to createEmptyBuckets() which dereferences conf directly:
{code}
boolean isCompressed = conf.getCompressed();
TableDesc tableInfo = conf.getTableInfo();
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HIVE-7185) KeyWrapperFactory#TextKeyWrapper#equals() extracts Text incorrectly when isCopy is false
[
https://issues.apache.org/jira/browse/HIVE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-7185:
-
Status: Open (was: Patch Available)
KeyWrapperFactory#TextKeyWrapper#equals() extracts Text incorrectly when
isCopy is false
Key: HIVE-7185
URL: https://issues.apache.org/jira/browse/HIVE-7185
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-7185.patch
{code}
} else {
t1 = soi_new.getPrimitiveWritableObject(key);
t2 = soi_copy.getPrimitiveWritableObject(obj);
{code}
t2 should be assigned soi_new.getPrimitiveWritableObject(obj)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Assigned] (HIVE-7185) KeyWrapperFactory#TextKeyWrapper#equals() extracts Text incorrectly when isCopy is false
[
https://issues.apache.org/jira/browse/HIVE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE reassigned HIVE-7185:
Assignee: SUYEON LEE
KeyWrapperFactory#TextKeyWrapper#equals() extracts Text incorrectly when
isCopy is false
Key: HIVE-7185
URL: https://issues.apache.org/jira/browse/HIVE-7185
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-7185.patch
{code}
} else {
t1 = soi_new.getPrimitiveWritableObject(key);
t2 = soi_copy.getPrimitiveWritableObject(obj);
{code}
t2 should be assigned soi_new.getPrimitiveWritableObject(obj)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HIVE-7185) KeyWrapperFactory#TextKeyWrapper#equals() extracts Text incorrectly when isCopy is false
[
https://issues.apache.org/jira/browse/HIVE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-7185:
-
Status: Patch Available (was: Open)
KeyWrapperFactory#TextKeyWrapper#equals() extracts Text incorrectly when
isCopy is false
Key: HIVE-7185
URL: https://issues.apache.org/jira/browse/HIVE-7185
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Assignee: SUYEON LEE
Priority: Minor
Attachments: HIVE-7185.patch
{code}
} else {
t1 = soi_new.getPrimitiveWritableObject(key);
t2 = soi_copy.getPrimitiveWritableObject(obj);
{code}
t2 should be assigned soi_new.getPrimitiveWritableObject(obj)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-7183) Size of partColumnGrants should be checked in ObjectStore#removeRole()
[
https://issues.apache.org/jira/browse/HIVE-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14027501#comment-14027501
]
SUYEON LEE commented on HIVE-7183:
--
[~swarnim] what does that meaning of non-binding?
do u know how to change this issue's status to 'solved or patch-available'?
Size of partColumnGrants should be checked in ObjectStore#removeRole()
--
Key: HIVE-7183
URL: https://issues.apache.org/jira/browse/HIVE-7183
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Priority: Minor
Attachments: HIVE-7183.patch
Here is related code:
{code}
ListMPartitionColumnPrivilege partColumnGrants =
listPrincipalAllPartitionColumnGrants(
mRol.getRoleName(), PrincipalType.ROLE);
if (tblColumnGrants.size() 0) {
pm.deletePersistentAll(partColumnGrants);
{code}
Size of tblColumnGrants is currently checked.
Size of partColumnGrants should be checked instead.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-7183) Size of partColumnGrants should be checked in ObjectStore#removeRole()
[
https://issues.apache.org/jira/browse/HIVE-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14028614#comment-14028614
]
SUYEON LEE commented on HIVE-7183:
--
[~swarnim] thanks a lot!! it is truly helpful for me.
Size of partColumnGrants should be checked in ObjectStore#removeRole()
--
Key: HIVE-7183
URL: https://issues.apache.org/jira/browse/HIVE-7183
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Priority: Minor
Attachments: HIVE-7183.patch
Here is related code:
{code}
ListMPartitionColumnPrivilege partColumnGrants =
listPrincipalAllPartitionColumnGrants(
mRol.getRoleName(), PrincipalType.ROLE);
if (tblColumnGrants.size() 0) {
pm.deletePersistentAll(partColumnGrants);
{code}
Size of tblColumnGrants is currently checked.
Size of partColumnGrants should be checked instead.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HIVE-7183) Size of partColumnGrants should be checked in ObjectStore#removeRole()
[
https://issues.apache.org/jira/browse/HIVE-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-7183:
-
Attachment: HIVE-7183.patch
Size of partColumnGrants should be checked in ObjectStore#removeRole()
--
Key: HIVE-7183
URL: https://issues.apache.org/jira/browse/HIVE-7183
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Priority: Minor
Attachments: HIVE-7183.patch
Here is related code:
{code}
ListMPartitionColumnPrivilege partColumnGrants =
listPrincipalAllPartitionColumnGrants(
mRol.getRoleName(), PrincipalType.ROLE);
if (tblColumnGrants.size() 0) {
pm.deletePersistentAll(partColumnGrants);
{code}
Size of tblColumnGrants is currently checked.
Size of partColumnGrants should be checked instead.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HIVE-7183) Size of partColumnGrants should be checked in ObjectStore#removeRole()
[
https://issues.apache.org/jira/browse/HIVE-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-7183:
-
Attachment: HIVE-7183.patch.patch
Size of partColumnGrants should be checked in ObjectStore#removeRole()
--
Key: HIVE-7183
URL: https://issues.apache.org/jira/browse/HIVE-7183
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Priority: Minor
Attachments: HIVE-7183.patch
Here is related code:
{code}
ListMPartitionColumnPrivilege partColumnGrants =
listPrincipalAllPartitionColumnGrants(
mRol.getRoleName(), PrincipalType.ROLE);
if (tblColumnGrants.size() 0) {
pm.deletePersistentAll(partColumnGrants);
{code}
Size of tblColumnGrants is currently checked.
Size of partColumnGrants should be checked instead.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HIVE-7183) Size of partColumnGrants should be checked in ObjectStore#removeRole()
[
https://issues.apache.org/jira/browse/HIVE-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SUYEON LEE updated HIVE-7183:
-
Attachment: (was: HIVE-7183.patch.patch)
Size of partColumnGrants should be checked in ObjectStore#removeRole()
--
Key: HIVE-7183
URL: https://issues.apache.org/jira/browse/HIVE-7183
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Priority: Minor
Attachments: HIVE-7183.patch
Here is related code:
{code}
ListMPartitionColumnPrivilege partColumnGrants =
listPrincipalAllPartitionColumnGrants(
mRol.getRoleName(), PrincipalType.ROLE);
if (tblColumnGrants.size() 0) {
pm.deletePersistentAll(partColumnGrants);
{code}
Size of tblColumnGrants is currently checked.
Size of partColumnGrants should be checked instead.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
