[jira] [Comment Edited] (HIVE-7946) CBO: Merge CBO changes to Trunk

2014-09-09 Thread Sergey Shelukhin (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-7946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14127447#comment-14127447
 ] 

Sergey Shelukhin edited comment on HIVE-7946 at 9/9/14 7:36 PM:


stats_noscan_1 and about 10-15 more tests might be fixed by HIVE-6550 (when 
that is in)


was (Author: sershe):
stats_noscan_1 and about 10-15 more tests might be fixed by HIVE-6550

 CBO: Merge CBO changes to Trunk
 ---

 Key: HIVE-7946
 URL: https://issues.apache.org/jira/browse/HIVE-7946
 Project: Hive
  Issue Type: Bug
  Components: CBO
Reporter: Laljo John Pullokkaran
Assignee: Laljo John Pullokkaran
 Attachments: HIVE-7946.1.patch, HIVE-7946.2.patch, HIVE-7946.3.patch, 
 HIVE-7946.4.patch, HIVE-7946.5.patch, HIVE-7946.patch






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (HIVE-7946) CBO: Merge CBO changes to Trunk

2014-09-06 Thread Brock Noland (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-7946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14124559#comment-14124559
 ] 

Brock Noland edited comment on HIVE-7946 at 9/6/14 5:09 PM:


Thank you guys for doing this work! Two questions:

{noformat}
+  @Deprecated
+  public static void todo(String s) {
+  }
{noformat}

huh?

Also I see a ton of variables prefixed with m_. I understand that Hive doesn't 
have a consistent coding style but I think it's fair to say that m_ is not 
common in the codebase. Let's try and not do that going forward.


was (Author: brocknoland):
Thank you guys for doing this work! Two questions:

{noformat}
+  @Deprecated
+  public static void todo(String s) {
+  }
{noformat}

huh?

Also I see a ton of variables prefixed with m_. I understand there is some of 
that Hive doesn't have a consistent coding style but I think it's fair to say 
that m_ is not common in the codebase. Let's try and not do that going forward.

 CBO: Merge CBO changes to Trunk
 ---

 Key: HIVE-7946
 URL: https://issues.apache.org/jira/browse/HIVE-7946
 Project: Hive
  Issue Type: Bug
  Components: CBO
Reporter: Laljo John Pullokkaran
Assignee: Laljo John Pullokkaran
 Attachments: HIVE-7946.1.patch, HIVE-7946.2.patch, HIVE-7946.3.patch, 
 HIVE-7946.patch






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)