[jira] [Commented] (HIVE-2093) inputs are outputs should be populated for create/drop database
[ https://issues.apache.org/jira/browse/HIVE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13017327#comment-13017327 ] jirapos...@reviews.apache.org commented on HIVE-2093: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/566/ --- (Updated 2011-04-08 07:19:12.088932) Review request for hive, Yongqiang He and namit jain. Summary --- Still need to change some old tests' outputs. This addresses bug HIVE-2093. https://issues.apache.org/jira/browse/HIVE-2093 Diffs (updated) - trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1089697 trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1089697 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1089697 trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/ReadEntity.java 1089697 trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/WriteEntity.java 1089697 trunk/ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java 1089697 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1089697 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1089697 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 1089697 trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java 1089697 trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java 1089697 trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ShowLocksDesc.java 1089697 trunk/ql/src/test/queries/clientnegative/authorization_fail_create_db.q PRE-CREATION trunk/ql/src/test/queries/clientnegative/lockneg6.q PRE-CREATION trunk/ql/src/test/queries/clientnegative/lockneg7.q PRE-CREATION trunk/ql/src/test/queries/clientnegative/lockneg8.q PRE-CREATION trunk/ql/src/test/queries/clientnegative/lockneg9.q PRE-CREATION trunk/ql/src/test/queries/clientpositive/database.q 1089697 trunk/ql/src/test/results/clientnegative/authorization_fail_create_db.q.out PRE-CREATION trunk/ql/src/test/results/clientnegative/authorization_fail_drop_db.q.out PRE-CREATION trunk/ql/src/test/results/clientnegative/database_create_already_exists.q.out 1089697 trunk/ql/src/test/results/clientnegative/database_create_invalid_name.q.out 1089697 trunk/ql/src/test/results/clientnegative/database_drop_does_not_exist.q.out 1089697 trunk/ql/src/test/results/clientnegative/database_drop_not_empty.q.out 1089697 trunk/ql/src/test/results/clientnegative/exim_01_nonpart_over_loaded.q.out 1089697 trunk/ql/src/test/results/clientnegative/exim_02_all_part_over_overlap.q.out 1089697 trunk/ql/src/test/results/clientnegative/exim_03_nonpart_noncompat_colschema.q.out 1089697 trunk/ql/src/test/results/clientnegative/exim_04_nonpart_noncompat_colnumber.q.out 1089697 trunk/ql/src/test/results/clientnegative/exim_05_nonpart_noncompat_coltype.q.out 1089697 trunk/ql/src/test/results/clientnegative/exim_06_nonpart_noncompat_storage.q.out 1089697 trunk/ql/src/test/results/clientnegative/exim_07_nonpart_noncompat_ifof.q.out 1089697 trunk/ql/src/test/results/clientnegative/exim_08_nonpart_noncompat_serde.q.out 1089697 trunk/ql/src/test/results/clientnegative/exim_09_nonpart_noncompat_serdeparam.q.out 1089697 trunk/ql/src/test/results/clientnegative/exim_10_nonpart_noncompat_bucketing.q.out 1089697 trunk/ql/src/test/results/clientnegative/exim_11_nonpart_noncompat_sorting.q.out 1089697 trunk/ql/src/test/results/clientnegative/exim_13_nonnative_import.q.out 1089697 trunk/ql/src/test/results/clientnegative/exim_14_nonpart_part.q.out 1089697 trunk/ql/src/test/results/clientnegative/exim_15_part_nonpart.q.out 1089697 trunk/ql/src/test/results/clientnegative/exim_16_part_noncompat_schema.q.out 1089697 trunk/ql/src/test/results/clientnegative/exim_17_part_spec_underspec.q.out 1089697 trunk/ql/src/test/results/clientnegative/exim_18_part_spec_missing.q.out 1089697 trunk/ql/src/test/results/clientnegative/exim_19_external_over_existing.q.out 1089697 trunk/ql/src/test/results/clientnegative/exim_20_managed_location_over_existing.q.out 1089697 trunk/ql/src/test/results/clientnegative/exim_21_part_managed_external.q.out 1089697 trunk/ql/src/test/results/clientnegative/exim_23_import_exist_authfail.q.out 1089697 trunk/ql/src/test/results/clientnegative/exim_24_import_part_authfail.q.out 1089697 trunk/ql/src/test/results/clientnegative/exim_25_import_nonexist_authfail.q.out 1089697 trunk/ql/src/test/results/clientnegative/lockneg6.q.out PRE-CREATION trunk/ql/src/test/results/clientnegative/lockneg7.q.out PRE-CREATION trunk/ql/src/test/results/clientnegative/lockneg8.q.out PRE-CREATION
[jira] [Commented] (HIVE-2093) inputs are outputs should be populated for create/drop database
[ https://issues.apache.org/jira/browse/HIVE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13017034#comment-13017034 ] Namit Jain commented on HIVE-2093: -- The changes to inputs/outputs look good - Yongqiang, can you confirm the authorization changes ? If we are supporting this, we should also support LOCK DATABASE DB_NAME in the same patch. Also, can you add a negative test with LOCK DATABASE .. ? inputs are outputs should be populated for create/drop database --- Key: HIVE-2093 URL: https://issues.apache.org/jira/browse/HIVE-2093 Project: Hive Issue Type: Bug Reporter: Namit Jain Assignee: Siying Dong Attachments: HIVE.2093.1.patch This is needed for many other things: concurrency, authorization etc. to work -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2093) inputs are outputs should be populated for create/drop database
[ https://issues.apache.org/jira/browse/HIVE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13017097#comment-13017097 ] Siying Dong commented on HIVE-2093: --- Namit, do you mean we should add LOCK DATABASE? Looks like we don't have the syntax at all. inputs are outputs should be populated for create/drop database --- Key: HIVE-2093 URL: https://issues.apache.org/jira/browse/HIVE-2093 Project: Hive Issue Type: Bug Reporter: Namit Jain Assignee: Siying Dong Attachments: HIVE.2093.1.patch This is needed for many other things: concurrency, authorization etc. to work -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2093) inputs are outputs should be populated for create/drop database
[ https://issues.apache.org/jira/browse/HIVE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13017115#comment-13017115 ] He Yongqiang commented on HIVE-2093: Siying, can you add cleanup of db/user privilege in QTestUtils? inputs are outputs should be populated for create/drop database --- Key: HIVE-2093 URL: https://issues.apache.org/jira/browse/HIVE-2093 Project: Hive Issue Type: Bug Reporter: Namit Jain Assignee: Siying Dong Attachments: HIVE.2093.1.patch This is needed for many other things: concurrency, authorization etc. to work -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2093) inputs are outputs should be populated for create/drop database
[ https://issues.apache.org/jira/browse/HIVE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13017253#comment-13017253 ] Siying Dong commented on HIVE-2093: --- created review board: https://reviews.apache.org/r/566 inputs are outputs should be populated for create/drop database --- Key: HIVE-2093 URL: https://issues.apache.org/jira/browse/HIVE-2093 Project: Hive Issue Type: Bug Reporter: Namit Jain Assignee: Siying Dong Attachments: HIVE.2093.1.patch, HIVE.2093.2.patch This is needed for many other things: concurrency, authorization etc. to work -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2093) inputs are outputs should be populated for create/drop database
[ https://issues.apache.org/jira/browse/HIVE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13017254#comment-13017254 ] jirapos...@reviews.apache.org commented on HIVE-2093: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/566/ --- Review request for hive, Yongqiang He and namit jain. Summary --- Still need to change some old tests' outputs. This addresses bug HIVE-2093. https://issues.apache.org/jira/browse/HIVE-2093 Diffs - trunk/ql/src/test/results/clientnegative/lockneg8.q.out PRE-CREATION trunk/ql/src/test/results/clientnegative/lockneg9.q.out PRE-CREATION trunk/ql/src/test/results/clientpositive/add_part_exist.q.out 1089697 trunk/ql/src/test/results/clientpositive/alter1.q.out 1089697 trunk/ql/src/test/results/clientnegative/lockneg7.q.out PRE-CREATION trunk/ql/src/test/results/clientnegative/lockneg6.q.out PRE-CREATION trunk/ql/src/test/queries/clientnegative/lockneg9.q PRE-CREATION trunk/ql/src/test/queries/clientpositive/database.q 1089697 trunk/ql/src/test/results/clientnegative/authorization_fail_create_db.q.out PRE-CREATION trunk/ql/src/test/results/clientnegative/authorization_fail_drop_db.q.out PRE-CREATION trunk/ql/src/test/results/clientnegative/database_create_already_exists.q.out 1089697 trunk/ql/src/test/results/clientnegative/database_create_invalid_name.q.out 1089697 trunk/ql/src/test/results/clientnegative/database_drop_does_not_exist.q.out 1089697 trunk/ql/src/test/results/clientnegative/database_drop_not_empty.q.out 1089697 trunk/ql/src/test/queries/clientnegative/authorization_fail_create_db.q PRE-CREATION trunk/ql/src/test/queries/clientnegative/lockneg6.q PRE-CREATION trunk/ql/src/test/queries/clientnegative/lockneg7.q PRE-CREATION trunk/ql/src/test/queries/clientnegative/lockneg8.q PRE-CREATION trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ShowLocksDesc.java 1089697 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1089697 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 1089697 trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java 1089697 trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java 1089697 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1089697 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1089697 trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1089697 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1089697 trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/ReadEntity.java 1089697 trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/WriteEntity.java 1089697 trunk/ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java 1089697 trunk/ql/src/test/results/clientpositive/alter2.q.out 1089697 trunk/ql/src/test/results/clientpositive/alter3.q.out 1089697 trunk/ql/src/test/results/clientpositive/alter4.q.out 1089697 trunk/ql/src/test/results/clientpositive/authorization_5.q.out 1089697 trunk/ql/src/test/results/clientpositive/database.q.out 1089697 Diff: https://reviews.apache.org/r/566/diff Testing --- Thanks, Siying inputs are outputs should be populated for create/drop database --- Key: HIVE-2093 URL: https://issues.apache.org/jira/browse/HIVE-2093 Project: Hive Issue Type: Bug Reporter: Namit Jain Assignee: Siying Dong Attachments: HIVE.2093.1.patch, HIVE.2093.2.patch This is needed for many other things: concurrency, authorization etc. to work -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
