[jira] [Commented] (HIVE-2153) Stats JDBC LIKE queries should escape '_' and '%'

2011-05-12 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13032617#comment-13032617
 ] 

Hudson commented on HIVE-2153:
--

Integrated in Hive-trunk-h0.20 #726 (See 
[https://builds.apache.org/hudson/job/Hive-trunk-h0.20/726/])


 Stats JDBC LIKE queries should escape '_' and '%'
 -

 Key: HIVE-2153
 URL: https://issues.apache.org/jira/browse/HIVE-2153
 Project: Hive
  Issue Type: Bug
Reporter: Ning Zhang
Assignee: Ning Zhang
 Fix For: 0.8.0

 Attachments: HIVE-2153.2.patch, HIVE-2153.patch


 DELETE /* Hive stats aggregation: 
 org.apache.hadoop.hive.ql.stats.jdbc.JDBCStatsAggregator */ FROM 
 PARTITION_STAT_TBL WHERE ID LIKE 
 'hdfs://dfsnode:9000/tmp/hive-root/hive_2011-05-09_04-30-28_586_4184342157898880918/-ext-1/ds=2011-05-08/table_name=dim_page_to_user_suggest_assoc/%'
 It is a prefix query but the '_' in the ID column should be escaped. The same 
 applies to '%' if they appear in ID. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-2153) Stats JDBC LIKE queries should escape '_' and '%'

2011-05-09 Thread jirapos...@reviews.apache.org (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13030943#comment-13030943
 ] 

jirapos...@reviews.apache.org commented on HIVE-2153:
-


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/702/
---

Review request for hive.


Summary
---

Escape '_' and '%' in the LIKE operands. 


This addresses bug HIVE-2153.
https://issues.apache.org/jira/browse/HIVE-2153


Diffs
-

  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1101220 
  
trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsAggregator.java 
1101220 

Diff: https://reviews.apache.org/r/702/diff


Testing
---

passed the stats test suite, also tested it manually on mysql in addition to 
derby. 


Thanks,

Ning



 Stats JDBC LIKE queries should escape '_' and '%'
 -

 Key: HIVE-2153
 URL: https://issues.apache.org/jira/browse/HIVE-2153
 Project: Hive
  Issue Type: Bug
Reporter: Ning Zhang
Assignee: Ning Zhang
 Attachments: HIVE-2153.patch


 DELETE /* Hive stats aggregation: 
 org.apache.hadoop.hive.ql.stats.jdbc.JDBCStatsAggregator */ FROM 
 PARTITION_STAT_TBL WHERE ID LIKE 
 'hdfs://dfsnode:9000/tmp/hive-root/hive_2011-05-09_04-30-28_586_4184342157898880918/-ext-1/ds=2011-05-08/table_name=dim_page_to_user_suggest_assoc/%'
 It is a prefix query but the '_' in the ID column should be escaped. The same 
 applies to '%' if they appear in ID. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-2153) Stats JDBC LIKE queries should escape '_' and '%'

2011-05-09 Thread jirapos...@reviews.apache.org (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13030954#comment-13030954
 ] 

jirapos...@reviews.apache.org commented on HIVE-2153:
-


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/702/
---

(Updated 2011-05-09 23:25:51.497027)


Review request for hive.


Summary
---

Escape '_' and '%' in the LIKE operands. 


This addresses bug HIVE-2153.
https://issues.apache.org/jira/browse/HIVE-2153


Diffs (updated)
-

  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1101220 
  
trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsAggregator.java 
1101220 

Diff: https://reviews.apache.org/r/702/diff


Testing
---

passed the stats test suite, also tested it manually on mysql in addition to 
derby. 


Thanks,

Ning



 Stats JDBC LIKE queries should escape '_' and '%'
 -

 Key: HIVE-2153
 URL: https://issues.apache.org/jira/browse/HIVE-2153
 Project: Hive
  Issue Type: Bug
Reporter: Ning Zhang
Assignee: Ning Zhang
 Attachments: HIVE-2153.2.patch, HIVE-2153.patch


 DELETE /* Hive stats aggregation: 
 org.apache.hadoop.hive.ql.stats.jdbc.JDBCStatsAggregator */ FROM 
 PARTITION_STAT_TBL WHERE ID LIKE 
 'hdfs://dfsnode:9000/tmp/hive-root/hive_2011-05-09_04-30-28_586_4184342157898880918/-ext-1/ds=2011-05-08/table_name=dim_page_to_user_suggest_assoc/%'
 It is a prefix query but the '_' in the ID column should be escaped. The same 
 applies to '%' if they appear in ID. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-2153) Stats JDBC LIKE queries should escape '_' and '%'

2011-05-09 Thread Paul Yang (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13030981#comment-13030981
 ] 

Paul Yang commented on HIVE-2153:
-

+1 Will test and commit

 Stats JDBC LIKE queries should escape '_' and '%'
 -

 Key: HIVE-2153
 URL: https://issues.apache.org/jira/browse/HIVE-2153
 Project: Hive
  Issue Type: Bug
Reporter: Ning Zhang
Assignee: Ning Zhang
 Attachments: HIVE-2153.2.patch, HIVE-2153.patch


 DELETE /* Hive stats aggregation: 
 org.apache.hadoop.hive.ql.stats.jdbc.JDBCStatsAggregator */ FROM 
 PARTITION_STAT_TBL WHERE ID LIKE 
 'hdfs://dfsnode:9000/tmp/hive-root/hive_2011-05-09_04-30-28_586_4184342157898880918/-ext-1/ds=2011-05-08/table_name=dim_page_to_user_suggest_assoc/%'
 It is a prefix query but the '_' in the ID column should be escaped. The same 
 applies to '%' if they appear in ID. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira