[jira] [Commented] (HIVE-2462) make INNER a non-reserved keyword
[ https://issues.apache.org/jira/browse/HIVE-2462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13112860#comment-13112860 ] jirapos...@reviews.apache.org commented on HIVE-2462: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2024/ --- Review request for hive. Summary --- HIVE-2462 This addresses bug HIVE-2462. https://issues.apache.org/jira/browse/HIVE-2462 Diffs - http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1174316 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/innerjoin.q 1174316 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/innerjoin.q.out 1174316 Diff: https://reviews.apache.org/r/2024/diff Testing --- Thanks, John make INNER a non-reserved keyword - Key: HIVE-2462 URL: https://issues.apache.org/jira/browse/HIVE-2462 Project: Hive Issue Type: Improvement Reporter: John Sichi Assignee: John Sichi Fix For: 0.9.0 Attachments: HIVE-2462.1.patch HIVE-2191 introduced the INNER keyword as reserved, which breaks backwards compatibility for queries which were using it as an identifier. This patch addresses that. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2462) make INNER a non-reserved keyword
[ https://issues.apache.org/jira/browse/HIVE-2462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13112861#comment-13112861 ] John Sichi commented on HIVE-2462: -- Not sure whether we want/need this, but if so, here's the patch. make INNER a non-reserved keyword - Key: HIVE-2462 URL: https://issues.apache.org/jira/browse/HIVE-2462 Project: Hive Issue Type: Improvement Reporter: John Sichi Assignee: John Sichi Fix For: 0.9.0 Attachments: HIVE-2462.1.patch HIVE-2191 introduced the INNER keyword as reserved, which breaks backwards compatibility for queries which were using it as an identifier. This patch addresses that. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2462) make INNER a non-reserved keyword
[ https://issues.apache.org/jira/browse/HIVE-2462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13113027#comment-13113027 ] He Yongqiang commented on HIVE-2462: The patch looks good, we should have it. running test make INNER a non-reserved keyword - Key: HIVE-2462 URL: https://issues.apache.org/jira/browse/HIVE-2462 Project: Hive Issue Type: Improvement Reporter: John Sichi Assignee: John Sichi Fix For: 0.9.0 Attachments: HIVE-2462.1.patch HIVE-2191 introduced the INNER keyword as reserved, which breaks backwards compatibility for queries which were using it as an identifier. This patch addresses that. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
