[jira] [Commented] (HIVE-3853) UDF unix_timestamp is deterministic if an argument is given, but it treated as non-deterministic preventing PPD
[ https://issues.apache.org/jira/browse/HIVE-3853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13547785#comment-13547785 ] Hudson commented on HIVE-3853: -- Integrated in Hive-trunk-h0.21 #1902 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1902/]) HIVE-3853 UDF unix_timestamp is deterministic if an argument is given, but it treated as non-deterministic preventing PPD (Navis via namit) (Revision 1430429) Result = SUCCESS namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1430429 Files : * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToUnixTimeStamp.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUnixTimeStamp.java * /hive/trunk/ql/src/test/queries/clientpositive/udf_to_unix_timestamp.q * /hive/trunk/ql/src/test/queries/clientpositive/udf_unix_timestamp.q * /hive/trunk/ql/src/test/results/clientpositive/show_functions.q.out * /hive/trunk/ql/src/test/results/clientpositive/udf5.q.out * /hive/trunk/ql/src/test/results/clientpositive/udf_to_unix_timestamp.q.out * /hive/trunk/ql/src/test/results/clientpositive/udf_unix_timestamp.q.out UDF unix_timestamp is deterministic if an argument is given, but it treated as non-deterministic preventing PPD --- Key: HIVE-3853 URL: https://issues.apache.org/jira/browse/HIVE-3853 Project: Hive Issue Type: Improvement Components: UDF Reporter: Navis Assignee: Navis Priority: Trivial Labels: udf Fix For: 0.11.0 Attachments: HIVE-3853.D7767.1.patch, HIVE-3853.D7767.2.patch unix_timestamp is declared as a non-deterministic function. But if user provides an argument, it makes deterministic result and eligible to PPD. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3853) UDF unix_timestamp is deterministic if an argument is given, but it treated as non-deterministic preventing PPD
[ https://issues.apache.org/jira/browse/HIVE-3853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545816#comment-13545816 ] Phabricator commented on HIVE-3853: --- njain has commented on the revision HIVE-3853 [jira] UDF unix_timestamp is deterministic if an argument is given, but it treated as non-deterministic preventing PPD. This calls for deterministic not being an annotation - by any chance, do you know if the annotation can be overwritten dynamically -- otherwise duplicate function is OK INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToUnixTimestamp.java:52 Can you share the code between this and unix_timestamp ? I mean create a common class,and both the functions can extend that. REVISION DETAIL https://reviews.facebook.net/D7767 To: JIRA, navis Cc: njain UDF unix_timestamp is deterministic if an argument is given, but it treated as non-deterministic preventing PPD --- Key: HIVE-3853 URL: https://issues.apache.org/jira/browse/HIVE-3853 Project: Hive Issue Type: Improvement Components: UDF Reporter: Navis Assignee: Navis Priority: Trivial Labels: udf Attachments: HIVE-3853.D7767.1.patch unix_timestamp is declared as a non-deterministic function. But if user provides an argument, it makes deterministic result and eligible to PPD. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3853) UDF unix_timestamp is deterministic if an argument is given, but it treated as non-deterministic preventing PPD
[ https://issues.apache.org/jira/browse/HIVE-3853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546578#comment-13546578 ] Phabricator commented on HIVE-3853: --- navis has commented on the revision HIVE-3853 [jira] UDF unix_timestamp is deterministic if an argument is given, but it treated as non-deterministic preventing PPD. I've heard annotation information is a part of class definition, which cannot be overwritten in runtime. REVISION DETAIL https://reviews.facebook.net/D7767 To: JIRA, navis Cc: njain UDF unix_timestamp is deterministic if an argument is given, but it treated as non-deterministic preventing PPD --- Key: HIVE-3853 URL: https://issues.apache.org/jira/browse/HIVE-3853 Project: Hive Issue Type: Improvement Components: UDF Reporter: Navis Assignee: Navis Priority: Trivial Labels: udf Attachments: HIVE-3853.D7767.1.patch, HIVE-3853.D7767.2.patch unix_timestamp is declared as a non-deterministic function. But if user provides an argument, it makes deterministic result and eligible to PPD. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3853) UDF unix_timestamp is deterministic if an argument is given, but it treated as non-deterministic preventing PPD
[ https://issues.apache.org/jira/browse/HIVE-3853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546629#comment-13546629 ] Namit Jain commented on HIVE-3853: -- +1 UDF unix_timestamp is deterministic if an argument is given, but it treated as non-deterministic preventing PPD --- Key: HIVE-3853 URL: https://issues.apache.org/jira/browse/HIVE-3853 Project: Hive Issue Type: Improvement Components: UDF Reporter: Navis Assignee: Navis Priority: Trivial Labels: udf Attachments: HIVE-3853.D7767.1.patch, HIVE-3853.D7767.2.patch unix_timestamp is declared as a non-deterministic function. But if user provides an argument, it makes deterministic result and eligible to PPD. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3853) UDF unix_timestamp is deterministic if an argument is given, but it treated as non-deterministic preventing PPD
[ https://issues.apache.org/jira/browse/HIVE-3853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546631#comment-13546631 ] Phabricator commented on HIVE-3853: --- njain has accepted the revision HIVE-3853 [jira] UDF unix_timestamp is deterministic if an argument is given, but it treated as non-deterministic preventing PPD. REVISION DETAIL https://reviews.facebook.net/D7767 BRANCH DPAL-1956 To: JIRA, njain, navis Cc: njain UDF unix_timestamp is deterministic if an argument is given, but it treated as non-deterministic preventing PPD --- Key: HIVE-3853 URL: https://issues.apache.org/jira/browse/HIVE-3853 Project: Hive Issue Type: Improvement Components: UDF Reporter: Navis Assignee: Navis Priority: Trivial Labels: udf Attachments: HIVE-3853.D7767.1.patch, HIVE-3853.D7767.2.patch unix_timestamp is declared as a non-deterministic function. But if user provides an argument, it makes deterministic result and eligible to PPD. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
