[jira] [Commented] (HIVE-4120) Implement decimal encoding for ORC
[ https://issues.apache.org/jira/browse/HIVE-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13629353#comment-13629353 ] Hudson commented on HIVE-4120: -- Integrated in Hive-trunk-h0.21 #2056 (See [https://builds.apache.org/job/Hive-trunk-h0.21/2056/]) HIVE-4120 : Implement decimal encoding for ORC (Owen Omalley via Ashutosh Chauhan) (Revision 1466745) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1466745 Files : * /hive/trunk/common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java * /hive/trunk/ql/src/gen/protobuf/gen-java/org/apache/hadoop/hive/ql/io/orc/OrcProto.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/orc/ColumnStatisticsImpl.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/orc/DecimalColumnStatistics.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcStruct.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/orc/SerializationUtils.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/orc/WriterImpl.java * /hive/trunk/ql/src/protobuf/org/apache/hadoop/hive/ql/io/orc/orc_proto.proto * /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcFile.java * /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestSerializationUtils.java * /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestStringRedBlackTree.java * /hive/trunk/ql/src/test/queries/clientpositive/decimal_4.q * /hive/trunk/ql/src/test/results/clientpositive/decimal_4.q.out > Implement decimal encoding for ORC > -- > > Key: HIVE-4120 > URL: https://issues.apache.org/jira/browse/HIVE-4120 > Project: Hive > Issue Type: New Feature > Components: Serializers/Deserializers >Reporter: Owen O'Malley >Assignee: Owen O'Malley > Fix For: 0.11.0 > > Attachments: h-4120.patch, HIVE-4120.D10047.1.patch, > HIVE-4120.D10047.2.patch, HIVE-4120.D9207.1.patch > > > Currently, ORC does not have an encoder for decimal. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4120) Implement decimal encoding for ORC
[ https://issues.apache.org/jira/browse/HIVE-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13629309#comment-13629309 ] Hudson commented on HIVE-4120: -- Integrated in Hive-trunk-hadoop2 #151 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/151/]) HIVE-4120 : Implement decimal encoding for ORC (Owen Omalley via Ashutosh Chauhan) (Revision 1466745) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1466745 Files : * /hive/trunk/common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java * /hive/trunk/ql/src/gen/protobuf/gen-java/org/apache/hadoop/hive/ql/io/orc/OrcProto.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/orc/ColumnStatisticsImpl.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/orc/DecimalColumnStatistics.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcStruct.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/orc/SerializationUtils.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/orc/WriterImpl.java * /hive/trunk/ql/src/protobuf/org/apache/hadoop/hive/ql/io/orc/orc_proto.proto * /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcFile.java * /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestSerializationUtils.java * /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestStringRedBlackTree.java * /hive/trunk/ql/src/test/queries/clientpositive/decimal_4.q * /hive/trunk/ql/src/test/results/clientpositive/decimal_4.q.out > Implement decimal encoding for ORC > -- > > Key: HIVE-4120 > URL: https://issues.apache.org/jira/browse/HIVE-4120 > Project: Hive > Issue Type: New Feature > Components: Serializers/Deserializers >Reporter: Owen O'Malley >Assignee: Owen O'Malley > Fix For: 0.11.0 > > Attachments: h-4120.patch, HIVE-4120.D10047.1.patch, > HIVE-4120.D10047.2.patch, HIVE-4120.D9207.1.patch > > > Currently, ORC does not have an encoder for decimal. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4120) Implement decimal encoding for ORC
[ https://issues.apache.org/jira/browse/HIVE-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627393#comment-13627393 ] Ashutosh Chauhan commented on HIVE-4120: [~owen.omalley] Latest patch from jira is not applying cleanly. > Implement decimal encoding for ORC > -- > > Key: HIVE-4120 > URL: https://issues.apache.org/jira/browse/HIVE-4120 > Project: Hive > Issue Type: New Feature > Components: Serializers/Deserializers >Reporter: Owen O'Malley >Assignee: Owen O'Malley > Attachments: HIVE-4120.D10047.1.patch, HIVE-4120.D10047.2.patch, > HIVE-4120.D9207.1.patch > > > Currently, ORC does not have an encoder for decimal. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4120) Implement decimal encoding for ORC
[ https://issues.apache.org/jira/browse/HIVE-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625827#comment-13625827 ] Owen O'Malley commented on HIVE-4120: - Added end to end test case > Implement decimal encoding for ORC > -- > > Key: HIVE-4120 > URL: https://issues.apache.org/jira/browse/HIVE-4120 > Project: Hive > Issue Type: New Feature > Components: Serializers/Deserializers >Reporter: Owen O'Malley >Assignee: Owen O'Malley > Attachments: HIVE-4120.D10047.1.patch, HIVE-4120.D9207.1.patch > > > Currently, ORC does not have an encoder for decimal. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4120) Implement decimal encoding for ORC
[ https://issues.apache.org/jira/browse/HIVE-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621065#comment-13621065 ] Ashutosh Chauhan commented on HIVE-4120: Looks good to me too. Agree with Gunther's suggestions. > Implement decimal encoding for ORC > -- > > Key: HIVE-4120 > URL: https://issues.apache.org/jira/browse/HIVE-4120 > Project: Hive > Issue Type: New Feature > Components: Serializers/Deserializers >Reporter: Owen O'Malley >Assignee: Owen O'Malley > Attachments: HIVE-4120.D9207.1.patch > > > Currently, ORC does not have an encoder for decimal. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4120) Implement decimal encoding for ORC
[ https://issues.apache.org/jira/browse/HIVE-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620402#comment-13620402 ] Phabricator commented on HIVE-4120: --- hagleitn has commented on the revision "HIVE-4120 [jira] Implement decimal encoding for ORC". Looks good to me. Only minor comment: It would be nice if there was an end to end test (i.e.: a .q file with an orc + decimal table. INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/io/orc/ColumnStatisticsImpl.java:438 no need to copy the bigdecimal for min, max and sum, they're immutable me thinks. REVISION DETAIL https://reviews.facebook.net/D9207 To: JIRA, omalley Cc: hagleitn > Implement decimal encoding for ORC > -- > > Key: HIVE-4120 > URL: https://issues.apache.org/jira/browse/HIVE-4120 > Project: Hive > Issue Type: New Feature > Components: Serializers/Deserializers >Reporter: Owen O'Malley >Assignee: Owen O'Malley > Attachments: HIVE-4120.D9207.1.patch > > > Currently, ORC does not have an encoder for decimal. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
