[jira] [Commented] (HIVE-4266) Refactor HCatalog code to org.apache.hive.hcatalog
[ https://issues.apache.org/jira/browse/HIVE-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13642988#comment-13642988 ] Ashutosh Chauhan commented on HIVE-4266: [~cwsteinbach] Given Alan's explanation, will you still block 0.11 for this ? Refactor HCatalog code to org.apache.hive.hcatalog -- Key: HIVE-4266 URL: https://issues.apache.org/jira/browse/HIVE-4266 Project: Hive Issue Type: Sub-task Components: HCatalog Affects Versions: 0.11.0 Reporter: Alan Gates Assignee: Alan Gates Priority: Blocker Fix For: 0.11.0 Currently HCatalog code is in packages org.apache.hcatalog. It needs to now move to org.apache.hive.hcatalog. Shell classes/interface need to be created for public facing classes so that user's code does not break. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4266) Refactor HCatalog code to org.apache.hive.hcatalog
[ https://issues.apache.org/jira/browse/HIVE-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13636231#comment-13636231 ] Carl Steinbach commented on HIVE-4266: -- bq. We cannot make this kind of backwards incompatible change for users. Users will not see this as here, run this script against your source tree. They'll see it as they have to go modify, re-test, and re-deploy every application. Aren't these same users going to have to re-test and re-deploy every application when they bump the version number of their hcatalog dependency? bq. We should not make this a blocker for 0.11. I'm 90% of the way through the patch, but it will take a fair amount of testing when I'm done to asure that it works with both org.apache.hcatalog and org.apache.hive.hcatalog. I'm convinced that if we don't do this now it's never going to happen, which is why I think one of the exit criteria for 0.11.0 needs to be either a) providing wrappers and a clearly stated EOL timeline for the org.apache.hcatalog namespace, or b) changing the package names only. Refactor HCatalog code to org.apache.hive.hcatalog -- Key: HIVE-4266 URL: https://issues.apache.org/jira/browse/HIVE-4266 Project: Hive Issue Type: Sub-task Components: HCatalog Affects Versions: 0.11.0 Reporter: Alan Gates Assignee: Alan Gates Priority: Blocker Fix For: 0.11.0 Currently HCatalog code is in packages org.apache.hcatalog. It needs to now move to org.apache.hive.hcatalog. Shell classes/interface need to be created for public facing classes so that user's code does not break. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4266) Refactor HCatalog code to org.apache.hive.hcatalog
[ https://issues.apache.org/jira/browse/HIVE-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13636965#comment-13636965 ] Alan Gates commented on HIVE-4266: -- bq. Aren't these same users going to have to re-test and re-deploy every application when they bump the version number of their hcatalog dependency? In my experience when you install a new Hadoop, Hive, or other tool version it is usually placed on a test/dev cluster for a while and users are given a chance to run on it, and once that proves out it is promoted to the production cluster(s). There isn't usually a step to validate every application and obviously no need to re-deploy applications. In this scenario users can retest on their schedule and decide which applications are not crucial enough to warrant the effort. On the other hand if you tell users, This is not backward compatible, you have to rewrite all your programs and scripts you are forcing them to rewrite, retest, and re-deploy everything before they can deploy the new version. This puts a big barrier to uptake of the new version in their way. I am fine with setting a sunset for these shell classes. Two major releases (ie Hive 0.13 or 0.14 depending on which release they go out with). bq. I'm convinced that if we don't do this now it's never going to happen... Since Ashutosh is managing this release I'll defer to him, but I am concerned about stuffing something this large in at the last minute. I understand that in software deferred is a synonym for when hell freezes over, but I honestly have the patch mostly done. The unit tests are passing. I don't have the javadoc doing the right thing yet and I need to run the system tests against both org.apache.hcatalog and org.apache.hive.hcatalog, which I'm estimating will take me a few days assuming I find a few bugs. Refactor HCatalog code to org.apache.hive.hcatalog -- Key: HIVE-4266 URL: https://issues.apache.org/jira/browse/HIVE-4266 Project: Hive Issue Type: Sub-task Components: HCatalog Affects Versions: 0.11.0 Reporter: Alan Gates Assignee: Alan Gates Priority: Blocker Fix For: 0.11.0 Currently HCatalog code is in packages org.apache.hcatalog. It needs to now move to org.apache.hive.hcatalog. Shell classes/interface need to be created for public facing classes so that user's code does not break. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4266) Refactor HCatalog code to org.apache.hive.hcatalog
[
https://issues.apache.org/jira/browse/HIVE-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13635805#comment-13635805
]
Carl Steinbach commented on HIVE-4266:
--
Marking this a blocker for 0.11.0.
bq. Shell classes/interface need to be created for public facing classes so
that user's code does not break.
I think this will create more problems than it fixes. Permanently supporting
these shell classes will be a long term maintenance burden and headache for all
involved. The other option is to add them temporarily, but what does that
really accomplish?
I think for most folks upgrading to the new namespace should be as simple as
running this command on their source tree:
{noformat}
% perl -p -i.bak -e 's|org\.apache\.hcatalog|org.apache.hive.hcatalog|g' `find
. -name *.java`
{noformat}
Refactor HCatalog code to org.apache.hive.hcatalog
--
Key: HIVE-4266
URL: https://issues.apache.org/jira/browse/HIVE-4266
Project: Hive
Issue Type: Sub-task
Components: HCatalog
Affects Versions: 0.11.0
Reporter: Alan Gates
Assignee: Alan Gates
Priority: Blocker
Fix For: 0.11.0
Currently HCatalog code is in packages org.apache.hcatalog. It needs to now
move to org.apache.hive.hcatalog. Shell classes/interface need to be created
for public facing classes so that user's code does not break.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4266) Refactor HCatalog code to org.apache.hive.hcatalog
[ https://issues.apache.org/jira/browse/HIVE-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13635827#comment-13635827 ] Alan Gates commented on HIVE-4266: -- We cannot make this kind of backwards incompatible change for users. Users will not see this as here, run this script against your source tree. They'll see it as they have to go modify, re-test, and re-deploy every application. We should not make this a blocker for 0.11. I'm 90% of the way through the patch, but it will take a fair amount of testing when I'm done to asure that it works with both org.apache.hcatalog and org.apache.hive.hcatalog. Refactor HCatalog code to org.apache.hive.hcatalog -- Key: HIVE-4266 URL: https://issues.apache.org/jira/browse/HIVE-4266 Project: Hive Issue Type: Sub-task Components: HCatalog Affects Versions: 0.11.0 Reporter: Alan Gates Assignee: Alan Gates Priority: Blocker Fix For: 0.11.0 Currently HCatalog code is in packages org.apache.hcatalog. It needs to now move to org.apache.hive.hcatalog. Shell classes/interface need to be created for public facing classes so that user's code does not break. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
