[jira] [Commented] (HIVE-4302) Fix how RowSchema and RowResolver are set on ReduceSinkOp that precedes PTFOp
[ https://issues.apache.org/jira/browse/HIVE-4302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625049#comment-13625049 ] Hudson commented on HIVE-4302: -- Integrated in Hive-trunk-hadoop2 #144 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/144/]) HIVE-4302 : Fix how RowSchema and RowResolver are set on ReduceSinkOp that precedes PTFOp (Harish Butani via Ashutosh Chauhan) (Revision 1465408) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1465408 Files : * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java * /hive/trunk/ql/src/test/queries/clientpositive/windowing_expressions.q * /hive/trunk/ql/src/test/results/clientpositive/windowing_expressions.q.out > Fix how RowSchema and RowResolver are set on ReduceSinkOp that precedes PTFOp > - > > Key: HIVE-4302 > URL: https://issues.apache.org/jira/browse/HIVE-4302 > Project: Hive > Issue Type: Bug > Components: PTF-Windowing >Reporter: Harish Butani >Assignee: Harish Butani > Fix For: 0.11.0 > > Attachments: HIVE-4302.D10005.1.patch, HIVE-4302.D10005.2.patch > > > Currently the RowSchema and RowResolver for the ReduceSinkOp just point to > the 'input' Op's structures. This causes issues when input Op's structures > are changed during Optimization. See Jira 2340 of a problem. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4302) Fix how RowSchema and RowResolver are set on ReduceSinkOp that precedes PTFOp
[ https://issues.apache.org/jira/browse/HIVE-4302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13624948#comment-13624948 ] Hudson commented on HIVE-4302: -- Integrated in Hive-trunk-h0.21 #2050 (See [https://builds.apache.org/job/Hive-trunk-h0.21/2050/]) HIVE-4302 : Fix how RowSchema and RowResolver are set on ReduceSinkOp that precedes PTFOp (Harish Butani via Ashutosh Chauhan) (Revision 1465408) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1465408 Files : * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java * /hive/trunk/ql/src/test/queries/clientpositive/windowing_expressions.q * /hive/trunk/ql/src/test/results/clientpositive/windowing_expressions.q.out > Fix how RowSchema and RowResolver are set on ReduceSinkOp that precedes PTFOp > - > > Key: HIVE-4302 > URL: https://issues.apache.org/jira/browse/HIVE-4302 > Project: Hive > Issue Type: Bug > Components: PTF-Windowing >Reporter: Harish Butani >Assignee: Harish Butani > Fix For: 0.11.0 > > Attachments: HIVE-4302.D10005.1.patch, HIVE-4302.D10005.2.patch > > > Currently the RowSchema and RowResolver for the ReduceSinkOp just point to > the 'input' Op's structures. This causes issues when input Op's structures > are changed during Optimization. See Jira 2340 of a problem. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4302) Fix how RowSchema and RowResolver are set on ReduceSinkOp that precedes PTFOp
[ https://issues.apache.org/jira/browse/HIVE-4302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13624732#comment-13624732 ] Phabricator commented on HIVE-4302: --- ashutoshc has accepted the revision "HIVE-4302 [jira] Fix how RowSchema and RowResolver are set on ReduceSinkOp that precedes PTFOp". +1 will commit if tests pass. REVISION DETAIL https://reviews.facebook.net/D10005 BRANCH HIVE-4302 ARCANIST PROJECT hive To: JIRA, ashutoshc, hbutani > Fix how RowSchema and RowResolver are set on ReduceSinkOp that precedes PTFOp > - > > Key: HIVE-4302 > URL: https://issues.apache.org/jira/browse/HIVE-4302 > Project: Hive > Issue Type: Bug > Components: PTF-Windowing >Reporter: Harish Butani >Assignee: Harish Butani > Attachments: HIVE-4302.D10005.1.patch, HIVE-4302.D10005.2.patch > > > Currently the RowSchema and RowResolver for the ReduceSinkOp just point to > the 'input' Op's structures. This causes issues when input Op's structures > are changed during Optimization. See Jira 2340 of a problem. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4302) Fix how RowSchema and RowResolver are set on ReduceSinkOp that precedes PTFOp
[ https://issues.apache.org/jira/browse/HIVE-4302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13624589#comment-13624589 ] Phabricator commented on HIVE-4302: --- hbutani has commented on the revision "HIVE-4302 [jira] Fix how RowSchema and RowResolver are set on ReduceSinkOp that precedes PTFOp". Will add the test INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:10543 No this is not about the having clause for windowing. This has to do with the GroupBy RR that can precede window processing. For Having expressions a Aggregation expression is added twice to the RR. This logic is to preserve this. The comment on line 10566 tries to explain what is going on. REVISION DETAIL https://reviews.facebook.net/D10005 BRANCH HIVE-4302 ARCANIST PROJECT hive To: JIRA, ashutoshc, hbutani > Fix how RowSchema and RowResolver are set on ReduceSinkOp that precedes PTFOp > - > > Key: HIVE-4302 > URL: https://issues.apache.org/jira/browse/HIVE-4302 > Project: Hive > Issue Type: Bug > Components: PTF-Windowing >Reporter: Harish Butani >Assignee: Harish Butani > Attachments: HIVE-4302.D10005.1.patch > > > Currently the RowSchema and RowResolver for the ReduceSinkOp just point to > the 'input' Op's structures. This causes issues when input Op's structures > are changed during Optimization. See Jira 2340 of a problem. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4302) Fix how RowSchema and RowResolver are set on ReduceSinkOp that precedes PTFOp
[ https://issues.apache.org/jira/browse/HIVE-4302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13624513#comment-13624513 ] Phabricator commented on HIVE-4302: --- ashutoshc has requested changes to the revision "HIVE-4302 [jira] Fix how RowSchema and RowResolver are set on ReduceSinkOp that precedes PTFOp". Also, it will be good to have a test-case I had in HIVE-2340 hive> create table t1 (a1 int, b1 string); hive> create table t2 (a1 int, b1 string); hive> from (select sum(i) over (), s from over10k) tt insert overwrite table t1 select * insert overwrite table t2 select * ; hive> select * from t1 limit 3; hive> select * from t2 limit 3; INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:10543 Now that we have gotten rid of having support with ptf operator, is this now redundant? ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:10552 If above statement is correct, than we need to update this comment as well. ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:10554 And remove this if block. REVISION DETAIL https://reviews.facebook.net/D10005 BRANCH HIVE-4302 ARCANIST PROJECT hive To: JIRA, ashutoshc, hbutani > Fix how RowSchema and RowResolver are set on ReduceSinkOp that precedes PTFOp > - > > Key: HIVE-4302 > URL: https://issues.apache.org/jira/browse/HIVE-4302 > Project: Hive > Issue Type: Bug > Components: PTF-Windowing >Reporter: Harish Butani >Assignee: Harish Butani > Attachments: HIVE-4302.D10005.1.patch > > > Currently the RowSchema and RowResolver for the ReduceSinkOp just point to > the 'input' Op's structures. This causes issues when input Op's structures > are changed during Optimization. See Jira 2340 of a problem. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4302) Fix how RowSchema and RowResolver are set on ReduceSinkOp that precedes PTFOp
[ https://issues.apache.org/jira/browse/HIVE-4302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13624504#comment-13624504 ] Harish Butani commented on HIVE-4302: - Haven't made the change to ColumnPrunerFactory in the patch as 2340 is not resolved yet. > Fix how RowSchema and RowResolver are set on ReduceSinkOp that precedes PTFOp > - > > Key: HIVE-4302 > URL: https://issues.apache.org/jira/browse/HIVE-4302 > Project: Hive > Issue Type: Bug > Components: PTF-Windowing >Reporter: Harish Butani >Assignee: Harish Butani > Attachments: HIVE-4302.D10005.1.patch > > > Currently the RowSchema and RowResolver for the ReduceSinkOp just point to > the 'input' Op's structures. This causes issues when input Op's structures > are changed during Optimization. See Jira 2340 of a problem. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
