[jira] [Commented] (HIVE-4390) Enable capturing input URI entities for DML statements
[ https://issues.apache.org/jira/browse/HIVE-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13983756#comment-13983756 ] ruiming zhou commented on HIVE-4390: Can we have this patch rebased on trunk ? I am trying to apply this patch to Hive 0.13, it is just so out of synch and just found out this patch was developed for Hive 0.10. Enable capturing input URI entities for DML statements -- Key: HIVE-4390 URL: https://issues.apache.org/jira/browse/HIVE-4390 Project: Hive Issue Type: Improvement Components: Query Processor Affects Versions: 0.10.0 Reporter: Prasad Mujumdar Assignee: Prasad Mujumdar Attachments: HIVE-4390-2.patch The query compiler doesn't capture the files or directories accessed by following statements - * Load data * Export * Import * Alter table/partition set location This is very useful information to access from the hooks for monitoring/auditing etc. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-4390) Enable capturing input URI entities for DML statements
[ https://issues.apache.org/jira/browse/HIVE-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839715#comment-13839715 ] Thejas M Nair commented on HIVE-4390: - I have posted some comments on the review link. The patch needs rebase for trunk. [~brocknoland] It is hard to find out if there are any users for the hooks outside of hive. But I doubt if there are going to be that many users, and it should not be too hard to update their hook code to deal with this change. I think the config flag is useful for any such users, we can keep the config, but enable this by default. Enable capturing input URI entities for DML statements -- Key: HIVE-4390 URL: https://issues.apache.org/jira/browse/HIVE-4390 Project: Hive Issue Type: Improvement Components: Query Processor Affects Versions: 0.10.0 Reporter: Prasad Mujumdar Assignee: Prasad Mujumdar Attachments: HIVE-4390-2.patch The query compiler doesn't capture the files or directories accessed by following statements - * Load data * Export * Import * Alter table/partition set location This is very useful information to access from the hooks for monitoring/auditing etc. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-4390) Enable capturing input URI entities for DML statements
[ https://issues.apache.org/jira/browse/HIVE-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839746#comment-13839746 ] Prasad Mujumdar commented on HIVE-4390: --- [~thejas] Thanks for the feedback. I agree that it's better to turn it on by default. I will change it and rebase the patch. It might be a big test impact as the test output will now include the new entities. Perhaps the majority test can run with the option turned off .. Enable capturing input URI entities for DML statements -- Key: HIVE-4390 URL: https://issues.apache.org/jira/browse/HIVE-4390 Project: Hive Issue Type: Improvement Components: Query Processor Affects Versions: 0.10.0 Reporter: Prasad Mujumdar Assignee: Prasad Mujumdar Attachments: HIVE-4390-2.patch The query compiler doesn't capture the files or directories accessed by following statements - * Load data * Export * Import * Alter table/partition set location This is very useful information to access from the hooks for monitoring/auditing etc. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-4390) Enable capturing input URI entities for DML statements
[ https://issues.apache.org/jira/browse/HIVE-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839751#comment-13839751 ] Thejas M Nair commented on HIVE-4390: - I think it is better to run the tests with the default configs as far as possible. That is what most users would end up using. The big test impact should be fine, it should be easy to verify that only the input part has changed. Enable capturing input URI entities for DML statements -- Key: HIVE-4390 URL: https://issues.apache.org/jira/browse/HIVE-4390 Project: Hive Issue Type: Improvement Components: Query Processor Affects Versions: 0.10.0 Reporter: Prasad Mujumdar Assignee: Prasad Mujumdar Attachments: HIVE-4390-2.patch The query compiler doesn't capture the files or directories accessed by following statements - * Load data * Export * Import * Alter table/partition set location This is very useful information to access from the hooks for monitoring/auditing etc. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-4390) Enable capturing input URI entities for DML statements
[ https://issues.apache.org/jira/browse/HIVE-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13826547#comment-13826547 ] Brock Noland commented on HIVE-4390: Do we have any known hooks that are going to have an issue with these new objects? If not, I think we should remove the configuration option. If we keep the config option I think we should make it a list of things to capture similar to HIVE-5400. Enable capturing input URI entities for DML statements -- Key: HIVE-4390 URL: https://issues.apache.org/jira/browse/HIVE-4390 Project: Hive Issue Type: Improvement Components: Query Processor Affects Versions: 0.10.0 Reporter: Prasad Mujumdar Assignee: Prasad Mujumdar Attachments: HIVE-4390-2.patch The query compiler doesn't capture the files or directories accessed by following statements - * Load data * Export * Import * Alter table/partition set location This is very useful information to access from the hooks for monitoring/auditing etc. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-4390) Enable capturing input URI entities for DML statements
[ https://issues.apache.org/jira/browse/HIVE-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13799454#comment-13799454 ] Brock Noland commented on HIVE-4390: [~prasadm] can you update the patch (if required) and re-post with the correct patch name format? Enable capturing input URI entities for DML statements -- Key: HIVE-4390 URL: https://issues.apache.org/jira/browse/HIVE-4390 Project: Hive Issue Type: Improvement Components: Query Processor Affects Versions: 0.10.0 Reporter: Prasad Mujumdar Assignee: Prasad Mujumdar Attachments: HIVE-4390-2.patch The query compiler doesn't capture the files or directories accessed by following statements - * Load data * Export * Import * Alter table/partition set location This is very useful information to access from the hooks for monitoring/auditing etc. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-4390) Enable capturing input URI entities for DML statements
[ https://issues.apache.org/jira/browse/HIVE-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13675987#comment-13675987 ] Ashutosh Chauhan commented on HIVE-4390: I didn't get the backward compatibility problem (and thus the need of config variable) here. Enable capturing input URI entities for DML statements -- Key: HIVE-4390 URL: https://issues.apache.org/jira/browse/HIVE-4390 Project: Hive Issue Type: Improvement Components: Query Processor Affects Versions: 0.10.0 Reporter: Prasad Mujumdar Assignee: Prasad Mujumdar Attachments: HIVE-4390-2.patch The query compiler doesn't capture the files or directories accessed by following statements - * Load data * Export * Import * Alter table/partition set location This is very useful information to access from the hooks for monitoring/auditing etc. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4390) Enable capturing input URI entities for DML statements
[ https://issues.apache.org/jira/browse/HIVE-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13676600#comment-13676600 ] Prasad Mujumdar commented on HIVE-4390: --- [~ashutoshc] Thanks for taking a look. The patch adds a new type of objects passed to the hooks. This could cause problems for an existing hooks that's not expecting the new type. We can keep this enabled by default, but a config to turn it off would be useful. Enable capturing input URI entities for DML statements -- Key: HIVE-4390 URL: https://issues.apache.org/jira/browse/HIVE-4390 Project: Hive Issue Type: Improvement Components: Query Processor Affects Versions: 0.10.0 Reporter: Prasad Mujumdar Assignee: Prasad Mujumdar Attachments: HIVE-4390-2.patch The query compiler doesn't capture the files or directories accessed by following statements - * Load data * Export * Import * Alter table/partition set location This is very useful information to access from the hooks for monitoring/auditing etc. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
