[jira] [Commented] (HIVE-4393) Make the deleteData flag accessable from DropTable/Partition events
[ https://issues.apache.org/jira/browse/HIVE-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13640578#comment-13640578 ] Hudson commented on HIVE-4393: -- Integrated in Hive-trunk-hadoop2 #173 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/173/]) HIVE-4393 Make the deleteData flag accessable from DropTable/Partition events (Morgan Philips via namit) (Revision 1471220) Result = FAILURE namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1471220 Files : * /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java * /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/DropPartitionEvent.java * /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/DropTableEvent.java * /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/PreDropPartitionEvent.java * /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/PreDropTableEvent.java Make the deleteData flag accessable from DropTable/Partition events --- Key: HIVE-4393 URL: https://issues.apache.org/jira/browse/HIVE-4393 Project: Hive Issue Type: Improvement Components: Metastore Reporter: Morgan Phillips Assignee: Morgan Phillips Priority: Minor Fix For: 0.12.0 Attachments: HIVE-4393.D10443.1.patch, HIVE-4393.D10443.2.patch On occasion, due to some error during a drop, information is removed from the metastore but data, which should have been removed, remains intact on the DFS. In order to log such events via PreEvent and Event listeners a new method 'getDeleteData' should be added to (Pre)DropPartitionEvent and (Pre)DropTableEvent which returns the deleteData flag's value. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4393) Make the deleteData flag accessable from DropTable/Partition events
[ https://issues.apache.org/jira/browse/HIVE-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13639283#comment-13639283 ] Phabricator commented on HIVE-4393: --- njain has accepted the revision HIVE-4393 [jira] Make the deleteData flag accessable from DropTable/Partition events. REVISION DETAIL https://reviews.facebook.net/D10443 BRANCH HIVE-4393 ARCANIST PROJECT hive To: JIRA, kevinwilfong, sindheeraj, njain, Mrrrgn Make the deleteData flag accessable from DropTable/Partition events --- Key: HIVE-4393 URL: https://issues.apache.org/jira/browse/HIVE-4393 Project: Hive Issue Type: Improvement Components: Metastore Reporter: Morgan Phillips Assignee: Morgan Phillips Priority: Minor Attachments: HIVE-4393.D10443.1.patch, HIVE-4393.D10443.2.patch On occasion, due to some error during a drop, information is removed from the metastore but data, which should have been removed, remains intact on the DFS. In order to log such events via PreEvent and Event listeners a new method 'getDeleteData' should be added to (Pre)DropPartitionEvent and (Pre)DropTableEvent which returns the deleteData flag's value. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4393) Make the deleteData flag accessable from DropTable/Partition events
[ https://issues.apache.org/jira/browse/HIVE-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13639284#comment-13639284 ] Namit Jain commented on HIVE-4393: -- +1 Running tests. Make the deleteData flag accessable from DropTable/Partition events --- Key: HIVE-4393 URL: https://issues.apache.org/jira/browse/HIVE-4393 Project: Hive Issue Type: Improvement Components: Metastore Reporter: Morgan Phillips Assignee: Morgan Phillips Priority: Minor Attachments: HIVE-4393.D10443.1.patch, HIVE-4393.D10443.2.patch On occasion, due to some error during a drop, information is removed from the metastore but data, which should have been removed, remains intact on the DFS. In order to log such events via PreEvent and Event listeners a new method 'getDeleteData' should be added to (Pre)DropPartitionEvent and (Pre)DropTableEvent which returns the deleteData flag's value. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4393) Make the deleteData flag accessable from DropTable/Partition events
[ https://issues.apache.org/jira/browse/HIVE-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13640082#comment-13640082 ] Morgan Phillips commented on HIVE-4393: --- Hooray, thanks so much Namit. :) Make the deleteData flag accessable from DropTable/Partition events --- Key: HIVE-4393 URL: https://issues.apache.org/jira/browse/HIVE-4393 Project: Hive Issue Type: Improvement Components: Metastore Reporter: Morgan Phillips Assignee: Morgan Phillips Priority: Minor Fix For: 0.12.0 Attachments: HIVE-4393.D10443.1.patch, HIVE-4393.D10443.2.patch On occasion, due to some error during a drop, information is removed from the metastore but data, which should have been removed, remains intact on the DFS. In order to log such events via PreEvent and Event listeners a new method 'getDeleteData' should be added to (Pre)DropPartitionEvent and (Pre)DropTableEvent which returns the deleteData flag's value. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4393) Make the deleteData flag accessable from DropTable/Partition events
[ https://issues.apache.org/jira/browse/HIVE-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13640102#comment-13640102 ] Hudson commented on HIVE-4393: -- Integrated in Hive-trunk-h0.21 #2076 (See [https://builds.apache.org/job/Hive-trunk-h0.21/2076/]) HIVE-4393 Make the deleteData flag accessable from DropTable/Partition events (Morgan Philips via namit) (Revision 1471220) Result = FAILURE namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1471220 Files : * /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java * /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/DropPartitionEvent.java * /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/DropTableEvent.java * /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/PreDropPartitionEvent.java * /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/PreDropTableEvent.java Make the deleteData flag accessable from DropTable/Partition events --- Key: HIVE-4393 URL: https://issues.apache.org/jira/browse/HIVE-4393 Project: Hive Issue Type: Improvement Components: Metastore Reporter: Morgan Phillips Assignee: Morgan Phillips Priority: Minor Fix For: 0.12.0 Attachments: HIVE-4393.D10443.1.patch, HIVE-4393.D10443.2.patch On occasion, due to some error during a drop, information is removed from the metastore but data, which should have been removed, remains intact on the DFS. In order to log such events via PreEvent and Event listeners a new method 'getDeleteData' should be added to (Pre)DropPartitionEvent and (Pre)DropTableEvent which returns the deleteData flag's value. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4393) Make the deleteData flag accessable from DropTable/Partition events
[ https://issues.apache.org/jira/browse/HIVE-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13637839#comment-13637839 ] Namit Jain commented on HIVE-4393: -- [~mrrrgn], when a patch is ready for review, please mark 'Submit Patch'. Make the deleteData flag accessable from DropTable/Partition events --- Key: HIVE-4393 URL: https://issues.apache.org/jira/browse/HIVE-4393 Project: Hive Issue Type: Improvement Components: Metastore Reporter: Morgan Phillips Assignee: Morgan Phillips Priority: Minor On occasion, due to some error during a drop, information is removed from the metastore but data, which should have been removed, remains intact on the DFS. In order to log such events via PreEvent and Event listeners a new method 'getDeleteData' should be added to (Pre)DropPartitionEvent and (Pre)DropTableEvent which returns the deleteData flag's value. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4393) Make the deleteData flag accessable from DropTable/Partition events
[ https://issues.apache.org/jira/browse/HIVE-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13638041#comment-13638041 ] Morgan Phillips commented on HIVE-4393: --- Because of a commit error, I abandoned my last diff. The new diff is: https://reviews.facebook.net/D10443 Make the deleteData flag accessable from DropTable/Partition events --- Key: HIVE-4393 URL: https://issues.apache.org/jira/browse/HIVE-4393 Project: Hive Issue Type: Improvement Components: Metastore Reporter: Morgan Phillips Assignee: Morgan Phillips Priority: Minor Attachments: HIVE-4393.D10443.1.patch On occasion, due to some error during a drop, information is removed from the metastore but data, which should have been removed, remains intact on the DFS. In order to log such events via PreEvent and Event listeners a new method 'getDeleteData' should be added to (Pre)DropPartitionEvent and (Pre)DropTableEvent which returns the deleteData flag's value. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4393) Make the deleteData flag accessable from DropTable/Partition events
[ https://issues.apache.org/jira/browse/HIVE-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13638746#comment-13638746 ] Namit Jain commented on HIVE-4393: -- Can you address my earlier comments on https://reviews.facebook.net/D10425 ? Make the deleteData flag accessable from DropTable/Partition events --- Key: HIVE-4393 URL: https://issues.apache.org/jira/browse/HIVE-4393 Project: Hive Issue Type: Improvement Components: Metastore Reporter: Morgan Phillips Assignee: Morgan Phillips Priority: Minor Attachments: HIVE-4393.D10443.1.patch On occasion, due to some error during a drop, information is removed from the metastore but data, which should have been removed, remains intact on the DFS. In order to log such events via PreEvent and Event listeners a new method 'getDeleteData' should be added to (Pre)DropPartitionEvent and (Pre)DropTableEvent which returns the deleteData flag's value. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4393) Make the deleteData flag accessable from DropTable/Partition events
[ https://issues.apache.org/jira/browse/HIVE-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13638780#comment-13638780 ] Morgan Phillips commented on HIVE-4393: --- Yes, sorry. To answer your question about how deleteData is related to the description; DFS data is only deleted when partitions are dropped on internal tables with the deleteData flag set. Because I'm only trying to track drop partition events where data should be removed from the DFS I need to have access to the deleteData flag from within the event listeners. Make the deleteData flag accessable from DropTable/Partition events --- Key: HIVE-4393 URL: https://issues.apache.org/jira/browse/HIVE-4393 Project: Hive Issue Type: Improvement Components: Metastore Reporter: Morgan Phillips Assignee: Morgan Phillips Priority: Minor Attachments: HIVE-4393.D10443.1.patch On occasion, due to some error during a drop, information is removed from the metastore but data, which should have been removed, remains intact on the DFS. In order to log such events via PreEvent and Event listeners a new method 'getDeleteData' should be added to (Pre)DropPartitionEvent and (Pre)DropTableEvent which returns the deleteData flag's value. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4393) Make the deleteData flag accessable from DropTable/Partition events
[ https://issues.apache.org/jira/browse/HIVE-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13637779#comment-13637779 ] Morgan Phillips commented on HIVE-4393: --- Is being reviewed at: https://reviews.facebook.net/D10425 Make the deleteData flag accessable from DropTable/Partition events --- Key: HIVE-4393 URL: https://issues.apache.org/jira/browse/HIVE-4393 Project: Hive Issue Type: Improvement Components: Metastore Reporter: Morgan Phillips Assignee: Morgan Phillips Priority: Minor On occasion, due to some error during a drop, information is removed from the metastore but data, which should have been removed, remains intact on the DFS. In order to log such events via PreEvent and Event listeners a new method 'getDeleteData' should be added to (Pre)DropPartitionEvent and (Pre)DropTableEvent which returns the deleteData flag's value. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
