[jira] [Commented] (HIVE-4763) add support for thrift over http transport in HS2
[ https://issues.apache.org/jira/browse/HIVE-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13780249#comment-13780249 ] Hudson commented on HIVE-4763: -- FAILURE: Integrated in Hive-trunk-hadoop2-ptest #117 (See [https://builds.apache.org/job/Hive-trunk-hadoop2-ptest/117/]) HIVE-4763: add support for thrift over http transport in HS2 (Vaibhav Gumashta and MMike Liddell via Thejas Nair) (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1526738) * /hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java * /hive/trunk/conf/hive-default.xml.template * /hive/trunk/eclipse-templates/.classpath * /hive/trunk/ivy/libraries.properties * /hive/trunk/jdbc/ivy.xml * /hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java * /hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveDriver.java * /hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HttpBasicAuthInterceptor.java * /hive/trunk/jdbc/src/java/org/apache/hive/jdbc/Utils.java * /hive/trunk/jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java * /hive/trunk/service/src/java/org/apache/hive/service/cli/thrift/EmbeddedThriftBinaryCLIService.java * /hive/trunk/service/src/java/org/apache/hive/service/cli/thrift/EmbeddedThriftCLIService.java * /hive/trunk/service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java * /hive/trunk/service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java * /hive/trunk/service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java * /hive/trunk/service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java * /hive/trunk/service/src/java/org/apache/hive/service/server/HiveServer2.java * /hive/trunk/service/src/test/org/apache/hive/service/auth/TestPlainSaslHelper.java * /hive/trunk/service/src/test/org/apache/hive/service/cli/CLIServiceTest.java * /hive/trunk/service/src/test/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java * /hive/trunk/service/src/test/org/apache/hive/service/cli/TestEmbeddedThriftCLIService.java * /hive/trunk/service/src/test/org/apache/hive/service/cli/session/TestSessionHooks.java * /hive/trunk/service/src/test/org/apache/hive/service/cli/thrift/TestThriftBinaryCLIService.java * /hive/trunk/service/src/test/org/apache/hive/service/cli/thrift/TestThriftCLIService.java * /hive/trunk/service/src/test/org/apache/hive/service/cli/thrift/TestThriftHttpCLIService.java * /hive/trunk/service/src/test/org/apache/hive/service/cli/thrift/ThriftCLIServiceTest.java add support for thrift over http transport in HS2 - Key: HIVE-4763 URL: https://issues.apache.org/jira/browse/HIVE-4763 Project: Hive Issue Type: Sub-task Components: HiveServer2 Reporter: Thejas M Nair Assignee: Vaibhav Gumashta Fix For: 0.12.0 Attachments: HIVE-4763.1.patch, HIVE-4763.2.patch, HIVE-4763.D12855.1.patch, HIVE-4763.D12951.1.patch, HIVE-4763.D12951.2.patch, HIVE-4763.D12951.2.patch Subtask for adding support for http transport mode for thrift api in hive server2. Support for the different authentication modes will be part of another subtask. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4763) add support for thrift over http transport in HS2
[ https://issues.apache.org/jira/browse/HIVE-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13780376#comment-13780376 ] Hudson commented on HIVE-4763: -- SUCCESS: Integrated in Hive-trunk-hadoop1-ptest #183 (See [https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/183/]) HIVE-4763: add support for thrift over http transport in HS2 (Vaibhav Gumashta and MMike Liddell via Thejas Nair) (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1526738) * /hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java * /hive/trunk/conf/hive-default.xml.template * /hive/trunk/eclipse-templates/.classpath * /hive/trunk/ivy/libraries.properties * /hive/trunk/jdbc/ivy.xml * /hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java * /hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveDriver.java * /hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HttpBasicAuthInterceptor.java * /hive/trunk/jdbc/src/java/org/apache/hive/jdbc/Utils.java * /hive/trunk/jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java * /hive/trunk/service/src/java/org/apache/hive/service/cli/thrift/EmbeddedThriftBinaryCLIService.java * /hive/trunk/service/src/java/org/apache/hive/service/cli/thrift/EmbeddedThriftCLIService.java * /hive/trunk/service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java * /hive/trunk/service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java * /hive/trunk/service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java * /hive/trunk/service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java * /hive/trunk/service/src/java/org/apache/hive/service/server/HiveServer2.java * /hive/trunk/service/src/test/org/apache/hive/service/auth/TestPlainSaslHelper.java * /hive/trunk/service/src/test/org/apache/hive/service/cli/CLIServiceTest.java * /hive/trunk/service/src/test/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java * /hive/trunk/service/src/test/org/apache/hive/service/cli/TestEmbeddedThriftCLIService.java * /hive/trunk/service/src/test/org/apache/hive/service/cli/session/TestSessionHooks.java * /hive/trunk/service/src/test/org/apache/hive/service/cli/thrift/TestThriftBinaryCLIService.java * /hive/trunk/service/src/test/org/apache/hive/service/cli/thrift/TestThriftCLIService.java * /hive/trunk/service/src/test/org/apache/hive/service/cli/thrift/TestThriftHttpCLIService.java * /hive/trunk/service/src/test/org/apache/hive/service/cli/thrift/ThriftCLIServiceTest.java add support for thrift over http transport in HS2 - Key: HIVE-4763 URL: https://issues.apache.org/jira/browse/HIVE-4763 Project: Hive Issue Type: Sub-task Components: HiveServer2 Reporter: Thejas M Nair Assignee: Vaibhav Gumashta Fix For: 0.12.0 Attachments: HIVE-4763.1.patch, HIVE-4763.2.patch, HIVE-4763.D12855.1.patch, HIVE-4763.D12951.1.patch, HIVE-4763.D12951.2.patch, HIVE-4763.D12951.2.patch Subtask for adding support for http transport mode for thrift api in hive server2. Support for the different authentication modes will be part of another subtask. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4763) add support for thrift over http transport in HS2
[ https://issues.apache.org/jira/browse/HIVE-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13779617#comment-13779617 ] Hudson commented on HIVE-4763: -- FAILURE: Integrated in Hive-trunk-hadoop2 #459 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/459/]) HIVE-4763: add support for thrift over http transport in HS2 (Vaibhav Gumashta and MMike Liddell via Thejas Nair) (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1526738) * /hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java * /hive/trunk/conf/hive-default.xml.template * /hive/trunk/eclipse-templates/.classpath * /hive/trunk/ivy/libraries.properties * /hive/trunk/jdbc/ivy.xml * /hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java * /hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveDriver.java * /hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HttpBasicAuthInterceptor.java * /hive/trunk/jdbc/src/java/org/apache/hive/jdbc/Utils.java * /hive/trunk/jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java * /hive/trunk/service/src/java/org/apache/hive/service/cli/thrift/EmbeddedThriftBinaryCLIService.java * /hive/trunk/service/src/java/org/apache/hive/service/cli/thrift/EmbeddedThriftCLIService.java * /hive/trunk/service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java * /hive/trunk/service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java * /hive/trunk/service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java * /hive/trunk/service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java * /hive/trunk/service/src/java/org/apache/hive/service/server/HiveServer2.java * /hive/trunk/service/src/test/org/apache/hive/service/auth/TestPlainSaslHelper.java * /hive/trunk/service/src/test/org/apache/hive/service/cli/CLIServiceTest.java * /hive/trunk/service/src/test/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java * /hive/trunk/service/src/test/org/apache/hive/service/cli/TestEmbeddedThriftCLIService.java * /hive/trunk/service/src/test/org/apache/hive/service/cli/session/TestSessionHooks.java * /hive/trunk/service/src/test/org/apache/hive/service/cli/thrift/TestThriftBinaryCLIService.java * /hive/trunk/service/src/test/org/apache/hive/service/cli/thrift/TestThriftCLIService.java * /hive/trunk/service/src/test/org/apache/hive/service/cli/thrift/TestThriftHttpCLIService.java * /hive/trunk/service/src/test/org/apache/hive/service/cli/thrift/ThriftCLIServiceTest.java add support for thrift over http transport in HS2 - Key: HIVE-4763 URL: https://issues.apache.org/jira/browse/HIVE-4763 Project: Hive Issue Type: Sub-task Components: HiveServer2 Reporter: Thejas M Nair Assignee: Vaibhav Gumashta Fix For: 0.12.0 Attachments: HIVE-4763.1.patch, HIVE-4763.2.patch, HIVE-4763.D12855.1.patch, HIVE-4763.D12951.1.patch, HIVE-4763.D12951.2.patch, HIVE-4763.D12951.2.patch Subtask for adding support for http transport mode for thrift api in hive server2. Support for the different authentication modes will be part of another subtask. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4763) add support for thrift over http transport in HS2
[ https://issues.apache.org/jira/browse/HIVE-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13779610#comment-13779610 ] Hudson commented on HIVE-4763: -- FAILURE: Integrated in Hive-trunk-h0.21 #2361 (See [https://builds.apache.org/job/Hive-trunk-h0.21/2361/]) HIVE-4763: add support for thrift over http transport in HS2 (Vaibhav Gumashta and MMike Liddell via Thejas Nair) (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1526738) * /hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java * /hive/trunk/conf/hive-default.xml.template * /hive/trunk/eclipse-templates/.classpath * /hive/trunk/ivy/libraries.properties * /hive/trunk/jdbc/ivy.xml * /hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java * /hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveDriver.java * /hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HttpBasicAuthInterceptor.java * /hive/trunk/jdbc/src/java/org/apache/hive/jdbc/Utils.java * /hive/trunk/jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java * /hive/trunk/service/src/java/org/apache/hive/service/cli/thrift/EmbeddedThriftBinaryCLIService.java * /hive/trunk/service/src/java/org/apache/hive/service/cli/thrift/EmbeddedThriftCLIService.java * /hive/trunk/service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java * /hive/trunk/service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java * /hive/trunk/service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java * /hive/trunk/service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java * /hive/trunk/service/src/java/org/apache/hive/service/server/HiveServer2.java * /hive/trunk/service/src/test/org/apache/hive/service/auth/TestPlainSaslHelper.java * /hive/trunk/service/src/test/org/apache/hive/service/cli/CLIServiceTest.java * /hive/trunk/service/src/test/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java * /hive/trunk/service/src/test/org/apache/hive/service/cli/TestEmbeddedThriftCLIService.java * /hive/trunk/service/src/test/org/apache/hive/service/cli/session/TestSessionHooks.java * /hive/trunk/service/src/test/org/apache/hive/service/cli/thrift/TestThriftBinaryCLIService.java * /hive/trunk/service/src/test/org/apache/hive/service/cli/thrift/TestThriftCLIService.java * /hive/trunk/service/src/test/org/apache/hive/service/cli/thrift/TestThriftHttpCLIService.java * /hive/trunk/service/src/test/org/apache/hive/service/cli/thrift/ThriftCLIServiceTest.java add support for thrift over http transport in HS2 - Key: HIVE-4763 URL: https://issues.apache.org/jira/browse/HIVE-4763 Project: Hive Issue Type: Sub-task Components: HiveServer2 Reporter: Thejas M Nair Assignee: Vaibhav Gumashta Fix For: 0.12.0 Attachments: HIVE-4763.1.patch, HIVE-4763.2.patch, HIVE-4763.D12855.1.patch, HIVE-4763.D12951.1.patch, HIVE-4763.D12951.2.patch, HIVE-4763.D12951.2.patch Subtask for adding support for http transport mode for thrift api in hive server2. Support for the different authentication modes will be part of another subtask. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4763) add support for thrift over http transport in HS2
[
https://issues.apache.org/jira/browse/HIVE-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13776939#comment-13776939
]
Hive QA commented on HIVE-4763:
---
{color:red}Overall{color}: -1 no tests executed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12604744/HIVE-4763.D12951.1.patch
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/874/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/874/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Tests failed with: NonZeroExitCodeException: Command 'bash
/data/hive-ptest/working/scratch/source-prep.sh' failed with exit status 1 and
output '+ [[ -n '' ]]
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost
-Dhttp.proxyPort=3128'
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost
-Dhttp.proxyPort=3128'
+ cd /data/hive-ptest/working/
+ tee /data/hive-ptest/logs/PreCommit-HIVE-Build-874/source-prep.txt
+ mkdir -p maven ivy
+ [[ svn = \s\v\n ]]
+ [[ -n '' ]]
+ [[ -d apache-svn-trunk-source ]]
+ [[ ! -d apache-svn-trunk-source/.svn ]]
+ [[ ! -d apache-svn-trunk-source ]]
+ cd apache-svn-trunk-source
+ svn revert -R .
Reverted
'serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/primitive/TestPrimitiveObjectInspectorUtils.java'
Reverted
'serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableDateObjectInspector.java'
Reverted
'serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java'
Reverted
'serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaTimestampObjectInspector.java'
Reverted
'serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableTimestampObjectInspector.java'
Reverted
'serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaDateObjectInspector.java'
Reverted 'ql/src/test/results/clientpositive/partition_date.q.out'
Reverted 'ql/src/test/queries/clientpositive/partition_date.q'
Reverted
'ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToDate.java'
++ egrep -v '^X|^Performing status on external'
++ awk '{print $2}'
++ svn status --no-ignore
+ rm -rf build hcatalog/build hcatalog/core/build
hcatalog/storage-handlers/hbase/build hcatalog/server-extensions/build
hcatalog/webhcat/svr/build hcatalog/webhcat/java-client/build
hcatalog/hcatalog-pig-adapter/build common/src/gen
ql/src/test/results/clientpositive/type_conversions_1.q.out
ql/src/test/queries/clientpositive/type_conversions_1.q
+ svn update
Fetching external item into 'hcatalog/src/test/e2e/harness'
External at revision 1526050.
At revision 1526050.
+ patchCommandPath=/data/hive-ptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hive-ptest/working/scratch/build.patch
+ [[ -f /data/hive-ptest/working/scratch/build.patch ]]
+ chmod +x /data/hive-ptest/working/scratch/smart-apply-patch.sh
+ /data/hive-ptest/working/scratch/smart-apply-patch.sh
/data/hive-ptest/working/scratch/build.patch
The patch does not appear to apply with p0 to p2
+ exit 1
'
{noformat}
This message is automatically generated.
add support for thrift over http transport in HS2
-
Key: HIVE-4763
URL: https://issues.apache.org/jira/browse/HIVE-4763
Project: Hive
Issue Type: Sub-task
Components: HiveServer2
Reporter: Thejas M Nair
Assignee: Vaibhav Gumashta
Fix For: 0.12.0
Attachments: HIVE-4763.1.patch, HIVE-4763.2.patch,
HIVE-4763.D12855.1.patch, HIVE-4763.D12951.1.patch
Subtask for adding support for http transport mode for thrift api in hive
server2.
Support for the different authentication modes will be part of another
subtask.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4763) add support for thrift over http transport in HS2
[ https://issues.apache.org/jira/browse/HIVE-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13775699#comment-13775699 ] Vaibhav Gumashta commented on HIVE-4763: [~thejas] Latest feedback incorporated: https://reviews.facebook.net/D12951 add support for thrift over http transport in HS2 - Key: HIVE-4763 URL: https://issues.apache.org/jira/browse/HIVE-4763 Project: Hive Issue Type: Sub-task Components: HiveServer2 Reporter: Thejas M Nair Assignee: Vaibhav Gumashta Fix For: 0.12.0 Attachments: HIVE-4763.1.patch, HIVE-4763.2.patch, HIVE-4763.D12855.1.patch Subtask for adding support for http transport mode for thrift api in hive server2. Support for the different authentication modes will be part of another subtask. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4763) add support for thrift over http transport in HS2
[ https://issues.apache.org/jira/browse/HIVE-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13775957#comment-13775957 ] Thejas M Nair commented on HIVE-4763: - +1 add support for thrift over http transport in HS2 - Key: HIVE-4763 URL: https://issues.apache.org/jira/browse/HIVE-4763 Project: Hive Issue Type: Sub-task Components: HiveServer2 Reporter: Thejas M Nair Assignee: Vaibhav Gumashta Fix For: 0.12.0 Attachments: HIVE-4763.1.patch, HIVE-4763.2.patch, HIVE-4763.D12855.1.patch Subtask for adding support for http transport mode for thrift api in hive server2. Support for the different authentication modes will be part of another subtask. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4763) add support for thrift over http transport in HS2
[ https://issues.apache.org/jira/browse/HIVE-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13774211#comment-13774211 ] Vaibhav Gumashta commented on HIVE-4763: [~cwsteinbach] [~thejas] Uploaded the changes on phabricator: https://reviews.facebook.net/D12951 add support for thrift over http transport in HS2 - Key: HIVE-4763 URL: https://issues.apache.org/jira/browse/HIVE-4763 Project: Hive Issue Type: Sub-task Components: HiveServer2 Reporter: Thejas M Nair Assignee: Vaibhav Gumashta Fix For: 0.12.0 Attachments: HIVE-4763.1.patch, HIVE-4763.2.patch, HIVE-4763.D12855.1.patch Subtask for adding support for http transport mode for thrift api in hive server2. Support for the different authentication modes will be part of another subtask. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4763) add support for thrift over http transport in HS2
[ https://issues.apache.org/jira/browse/HIVE-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13768920#comment-13768920 ] Vaibhav Gumashta commented on HIVE-4763: [~cwsteinbach] [~thejas] I've uploaded another wip patch. Now fixing the test suite changes: OOM exception + reorganizing the test classes. add support for thrift over http transport in HS2 - Key: HIVE-4763 URL: https://issues.apache.org/jira/browse/HIVE-4763 Project: Hive Issue Type: Sub-task Components: HiveServer2 Reporter: Thejas M Nair Assignee: Vaibhav Gumashta Fix For: 0.12.0 Attachments: HIVE-4763.1.patch, HIVE-4763.2.patch, HIVE-4763.D12855.1.patch Subtask for adding support for http transport mode for thrift api in hive server2. Support for the different authentication modes will be part of another subtask. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4763) add support for thrift over http transport in HS2
[ https://issues.apache.org/jira/browse/HIVE-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13768031#comment-13768031 ] Vaibhav Gumashta commented on HIVE-4763: [~cwsteinbach][~thejas] Phab created a new link here: https://reviews.facebook.net/D12951 since previously I had manually uploaded the patch. Incorporates all the changes except: modification to SessionState in previous patch (I am not very clear why it was needed in first place - so keeping it here for feedback) and fixing the OOM test in TestHiveServer2Http and enabling it. For enabling use of both binary and http modes, I'll create a follow up JIRA to give more thought to the design. add support for thrift over http transport in HS2 - Key: HIVE-4763 URL: https://issues.apache.org/jira/browse/HIVE-4763 Project: Hive Issue Type: Sub-task Components: HiveServer2 Reporter: Thejas M Nair Assignee: Vaibhav Gumashta Fix For: 0.12.0 Attachments: HIVE-4763.1.patch, HIVE-4763.2.patch, HIVE-4763.D12855.1.patch Subtask for adding support for http transport mode for thrift api in hive server2. Support for the different authentication modes will be part of another subtask. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4763) add support for thrift over http transport in HS2
[ https://issues.apache.org/jira/browse/HIVE-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13763855#comment-13763855 ] Vaibhav Gumashta commented on HIVE-4763: [~thejas][~mikelid] Manually uploaded the patch to phab for easy review and discussions. add support for thrift over http transport in HS2 - Key: HIVE-4763 URL: https://issues.apache.org/jira/browse/HIVE-4763 Project: Hive Issue Type: Sub-task Components: HiveServer2 Reporter: Thejas M Nair Assignee: Vaibhav Gumashta Fix For: 0.12.0 Attachments: HIVE-4763.1.patch, HIVE-4763.2.patch, HIVE-4763.D12855.1.patch Subtask for adding support for http transport mode for thrift api in hive server2. Support for the different authentication modes will be part of another subtask. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4763) add support for thrift over http transport in HS2
[ https://issues.apache.org/jira/browse/HIVE-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13763959#comment-13763959 ] Phabricator commented on HIVE-4763: --- cwsteinbach has commented on the revision HIVE-4763 [jira] add support for thrift over http transport in HS2. INLINE COMMENTS common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:722 The values should be binary and http, not thrift and http. Also, I think some people are going to want to run in both modes simultaneously, so why not support a comma separated list of values? common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:723 For these properties please use the prefix hive.server2.thrift.http.* jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java:134 Please fix the formatting in this method. jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java:160 Import org.apache.thrift.transport.THttpClient. jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java:135 Include the expected prefix in the error message. jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java:231 static method jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java:239 ditto jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java:251 ditto jdbc/src/java/org/apache/hive/jdbc/HttpBasicAuthInterceptor.java:1 Missing ASF license header. jdbc/src/java/org/apache/hive/jdbc/HttpBasicAuthInterceptor.java:21 Formatting. jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java:1119 Both binary and http depend on top of TCP. This is binary mode. jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java:1126 Doesn't this belong down below in HTTP_URL_PROPERTIES? ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java:234 hiveserver1 http mode? It looks like this patch only adds support for http in HS2. service/src/java/org/apache/hive/service/cli/thrift/HttpServlet.java:1 Missing ASF header. service/src/java/org/apache/hive/service/cli/thrift/HttpServlet.java:25 Multiple formatting issues. service/src/java/org/apache/hive/service/cli/thrift/HttpServlet.java:45 Import the class, or do a static import for the method. service/src/java/org/apache/hive/service/cli/thrift/HttpServlet.java:15 Usually the names of child classes are more specific/specialized than the parent class. Please change the name to something that makes more sense. service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java:408 Please make ThriftCLIService abstract and move this logic into two child classes: ThriftBinaryCLIService and ThriftHttpCLIService. service/src/test/org/apache/hive/service/server/TestHS2HttpInvalidConf.java:1 Formatting service/src/test/org/apache/hive/service/server/TestHiveServer2Http.java:1 Formatting. service/src/test/org/apache/hive/service/server/TestHiveServer2Http.java:99 Please provide a more descriptive name than test. REVISION DETAIL https://reviews.facebook.net/D12855 To: JIRA, vaibhavgumashta Cc: thejas, cwsteinbach add support for thrift over http transport in HS2 - Key: HIVE-4763 URL: https://issues.apache.org/jira/browse/HIVE-4763 Project: Hive Issue Type: Sub-task Components: HiveServer2 Reporter: Thejas M Nair Assignee: Vaibhav Gumashta Fix For: 0.12.0 Attachments: HIVE-4763.1.patch, HIVE-4763.2.patch, HIVE-4763.D12855.1.patch Subtask for adding support for http transport mode for thrift api in hive server2. Support for the different authentication modes will be part of another subtask. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4763) add support for thrift over http transport in HS2
[ https://issues.apache.org/jira/browse/HIVE-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13763962#comment-13763962 ] Phabricator commented on HIVE-4763: --- cwsteinbach has commented on the revision HIVE-4763 [jira] add support for thrift over http transport in HS2. INLINE COMMENTS service/src/test/org/apache/hive/service/server/TestHiveServer2Http.java:138 Please fix this now rather than later. We have no way of knowing whether it's actually this patch that introduced the OOM error. REVISION DETAIL https://reviews.facebook.net/D12855 To: JIRA, vaibhavgumashta Cc: thejas, cwsteinbach add support for thrift over http transport in HS2 - Key: HIVE-4763 URL: https://issues.apache.org/jira/browse/HIVE-4763 Project: Hive Issue Type: Sub-task Components: HiveServer2 Reporter: Thejas M Nair Assignee: Vaibhav Gumashta Fix For: 0.12.0 Attachments: HIVE-4763.1.patch, HIVE-4763.2.patch, HIVE-4763.D12855.1.patch Subtask for adding support for http transport mode for thrift api in hive server2. Support for the different authentication modes will be part of another subtask. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4763) add support for thrift over http transport in HS2
[ https://issues.apache.org/jira/browse/HIVE-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13763966#comment-13763966 ] Vaibhav Gumashta commented on HIVE-4763: [~cwsteinbach] Thanks a lot for the feedback! I have just uploaded the wip till now, done by [~mikelid] and [~thejas]. Your feedback will help a lot in finishing this off. add support for thrift over http transport in HS2 - Key: HIVE-4763 URL: https://issues.apache.org/jira/browse/HIVE-4763 Project: Hive Issue Type: Sub-task Components: HiveServer2 Reporter: Thejas M Nair Assignee: Vaibhav Gumashta Fix For: 0.12.0 Attachments: HIVE-4763.1.patch, HIVE-4763.2.patch, HIVE-4763.D12855.1.patch Subtask for adding support for http transport mode for thrift api in hive server2. Support for the different authentication modes will be part of another subtask. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4763) add support for thrift over http transport in HS2
[ https://issues.apache.org/jira/browse/HIVE-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13763984#comment-13763984 ] Carl Steinbach commented on HIVE-4763: -- Cool. One additional note: the changes to SessionState look very suspect. I think the lazyInitForHttp variable is going to prevent us from running both BINARY and HTTP modes at the same time, and I don't understand why the modifications to SessionState.get() were necessary. add support for thrift over http transport in HS2 - Key: HIVE-4763 URL: https://issues.apache.org/jira/browse/HIVE-4763 Project: Hive Issue Type: Sub-task Components: HiveServer2 Reporter: Thejas M Nair Assignee: Vaibhav Gumashta Fix For: 0.12.0 Attachments: HIVE-4763.1.patch, HIVE-4763.2.patch, HIVE-4763.D12855.1.patch Subtask for adding support for http transport mode for thrift api in hive server2. Support for the different authentication modes will be part of another subtask. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4763) add support for thrift over http transport in HS2
[ https://issues.apache.org/jira/browse/HIVE-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689455#comment-13689455 ] Thejas M Nair commented on HIVE-4763: - Thanks to [~mikelid] for his contributions for this feature. Most of the changes in this patch were contributed by him (I reviewed the changes, added test cases, moved some classes around, added error handling changes). add support for thrift over http transport in HS2 - Key: HIVE-4763 URL: https://issues.apache.org/jira/browse/HIVE-4763 Project: Hive Issue Type: Sub-task Components: HiveServer2 Reporter: Thejas M Nair Assignee: Thejas M Nair Fix For: 0.12.0 Attachments: HIVE-4763.1.patch Subtask for adding support for http transport mode for thrift api in hive server2. Support for the different authentication modes will be part of another subtask. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4763) add support for thrift over http transport in HS2
[ https://issues.apache.org/jira/browse/HIVE-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689510#comment-13689510 ] Carl Steinbach commented on HIVE-4763: -- Quick question: can we make it possible for an HS2 process to support HTTP and binary serialization on different ports at the same time? Seems like we should be able to do this by subclassing ThriftCLIService. add support for thrift over http transport in HS2 - Key: HIVE-4763 URL: https://issues.apache.org/jira/browse/HIVE-4763 Project: Hive Issue Type: Sub-task Components: HiveServer2 Reporter: Thejas M Nair Assignee: Thejas M Nair Fix For: 0.12.0 Attachments: HIVE-4763.1.patch Subtask for adding support for http transport mode for thrift api in hive server2. Support for the different authentication modes will be part of another subtask. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4763) add support for thrift over http transport in HS2
[ https://issues.apache.org/jira/browse/HIVE-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689518#comment-13689518 ] Thejas M Nair commented on HIVE-4763: - Yes, that should be possible. But I am not sure if that is going to be a common use case. The config params introduced in this patch would work with that change as well - there is a separate config param for the http port. We would just need to add support for new value for the server mode, something like thrift+http. add support for thrift over http transport in HS2 - Key: HIVE-4763 URL: https://issues.apache.org/jira/browse/HIVE-4763 Project: Hive Issue Type: Sub-task Components: HiveServer2 Reporter: Thejas M Nair Assignee: Thejas M Nair Fix For: 0.12.0 Attachments: HIVE-4763.1.patch Subtask for adding support for http transport mode for thrift api in hive server2. Support for the different authentication modes will be part of another subtask. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4763) add support for thrift over http transport in HS2
[ https://issues.apache.org/jira/browse/HIVE-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689643#comment-13689643 ] Carl Steinbach commented on HIVE-4763: -- Any idea how http compares to binary performance wise? add support for thrift over http transport in HS2 - Key: HIVE-4763 URL: https://issues.apache.org/jira/browse/HIVE-4763 Project: Hive Issue Type: Sub-task Components: HiveServer2 Reporter: Thejas M Nair Assignee: Thejas M Nair Fix For: 0.12.0 Attachments: HIVE-4763.1.patch Subtask for adding support for http transport mode for thrift api in hive server2. Support for the different authentication modes will be part of another subtask. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4763) add support for thrift over http transport in HS2
[ https://issues.apache.org/jira/browse/HIVE-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689708#comment-13689708 ] Thejas M Nair commented on HIVE-4763: - No, haven't run any performance benchmarks on it yet. add support for thrift over http transport in HS2 - Key: HIVE-4763 URL: https://issues.apache.org/jira/browse/HIVE-4763 Project: Hive Issue Type: Sub-task Components: HiveServer2 Reporter: Thejas M Nair Assignee: Thejas M Nair Fix For: 0.12.0 Attachments: HIVE-4763.1.patch Subtask for adding support for http transport mode for thrift api in hive server2. Support for the different authentication modes will be part of another subtask. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
