[jira] [Commented] (HIVE-5253) Create component to compile and jar dynamic code
[ https://issues.apache.org/jira/browse/HIVE-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13790535#comment-13790535 ] Hudson commented on HIVE-5253: -- FAILURE: Integrated in Hive-trunk-hadoop1-ptest #197 (See [https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/197/]) HIVE-5253: Create component to compile and jar dynamic code (Edward Capriolo via Brock Noland) (brock: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1530394) * /hive/trunk/eclipse-templates/.classpath * /hive/trunk/ivy/libraries.properties * /hive/trunk/ql/ivy.xml * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/processors/CompileProcessor.java * /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/processors/TestCompileProcessor.java Create component to compile and jar dynamic code Key: HIVE-5253 URL: https://issues.apache.org/jira/browse/HIVE-5253 Project: Hive Issue Type: Sub-task Reporter: Edward Capriolo Assignee: Edward Capriolo Fix For: 0.13.0 Attachments: HIVE-5253.10.patch.txt, HIVE-5253.11.patch.txt, HIVE-5253.1.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.8.patch.txt, HIVE-5253.9.patch.txt, HIVE-5253.patch.txt -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5253) Create component to compile and jar dynamic code
[ https://issues.apache.org/jira/browse/HIVE-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13789727#comment-13789727 ] Hudson commented on HIVE-5253: -- FAILURE: Integrated in Hive-trunk-h0.21 #2388 (See [https://builds.apache.org/job/Hive-trunk-h0.21/2388/]) HIVE-5253: Create component to compile and jar dynamic code (Edward Capriolo via Brock Noland) (brock: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1530394) * /hive/trunk/eclipse-templates/.classpath * /hive/trunk/ivy/libraries.properties * /hive/trunk/ql/ivy.xml * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/processors/CompileProcessor.java * /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/processors/TestCompileProcessor.java Create component to compile and jar dynamic code Key: HIVE-5253 URL: https://issues.apache.org/jira/browse/HIVE-5253 Project: Hive Issue Type: Sub-task Reporter: Edward Capriolo Assignee: Edward Capriolo Fix For: 0.13.0 Attachments: HIVE-5253.10.patch.txt, HIVE-5253.11.patch.txt, HIVE-5253.1.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.8.patch.txt, HIVE-5253.9.patch.txt, HIVE-5253.patch.txt -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5253) Create component to compile and jar dynamic code
[ https://issues.apache.org/jira/browse/HIVE-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13789883#comment-13789883 ] Hudson commented on HIVE-5253: -- FAILURE: Integrated in Hive-trunk-hadoop2-ptest #132 (See [https://builds.apache.org/job/Hive-trunk-hadoop2-ptest/132/]) HIVE-5253: Create component to compile and jar dynamic code (Edward Capriolo via Brock Noland) (brock: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1530394) * /hive/trunk/eclipse-templates/.classpath * /hive/trunk/ivy/libraries.properties * /hive/trunk/ql/ivy.xml * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/processors/CompileProcessor.java * /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/processors/TestCompileProcessor.java Create component to compile and jar dynamic code Key: HIVE-5253 URL: https://issues.apache.org/jira/browse/HIVE-5253 Project: Hive Issue Type: Sub-task Reporter: Edward Capriolo Assignee: Edward Capriolo Fix For: 0.13.0 Attachments: HIVE-5253.10.patch.txt, HIVE-5253.11.patch.txt, HIVE-5253.1.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.8.patch.txt, HIVE-5253.9.patch.txt, HIVE-5253.patch.txt -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5253) Create component to compile and jar dynamic code
[ https://issues.apache.org/jira/browse/HIVE-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13790005#comment-13790005 ] Hudson commented on HIVE-5253: -- FAILURE: Integrated in Hive-trunk-hadoop2 #491 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/491/]) HIVE-5253: Create component to compile and jar dynamic code (Edward Capriolo via Brock Noland) (brock: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1530394) * /hive/trunk/eclipse-templates/.classpath * /hive/trunk/ivy/libraries.properties * /hive/trunk/ql/ivy.xml * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/processors/CompileProcessor.java * /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/processors/TestCompileProcessor.java Create component to compile and jar dynamic code Key: HIVE-5253 URL: https://issues.apache.org/jira/browse/HIVE-5253 Project: Hive Issue Type: Sub-task Reporter: Edward Capriolo Assignee: Edward Capriolo Fix For: 0.13.0 Attachments: HIVE-5253.10.patch.txt, HIVE-5253.11.patch.txt, HIVE-5253.1.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.8.patch.txt, HIVE-5253.9.patch.txt, HIVE-5253.patch.txt -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5253) Create component to compile and jar dynamic code
[ https://issues.apache.org/jira/browse/HIVE-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13788208#comment-13788208 ] Edward Capriolo commented on HIVE-5253: --- With no -1's registered there is no blocker. This issue is already a month old. If someone wanted to have a debate over it the time was a month ago. We should not block features for a month over random security debates. There already is pandora's box of 'public static HashMaps', ThreadLocal variables, and other things that if people REALLY want to talk about security they can fix. Create component to compile and jar dynamic code Key: HIVE-5253 URL: https://issues.apache.org/jira/browse/HIVE-5253 Project: Hive Issue Type: Sub-task Reporter: Edward Capriolo Assignee: Edward Capriolo Attachments: HIVE-5253.10.patch.txt, HIVE-5253.11.patch.txt, HIVE-5253.1.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.8.patch.txt, HIVE-5253.9.patch.txt, HIVE-5253.patch.txt -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5253) Create component to compile and jar dynamic code
[ https://issues.apache.org/jira/browse/HIVE-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13788481#comment-13788481 ] Brock Noland commented on HIVE-5253: Hi Edward, yes since there was some concern earlier I thought I'd give people a chance to speak up. I am +1. Create component to compile and jar dynamic code Key: HIVE-5253 URL: https://issues.apache.org/jira/browse/HIVE-5253 Project: Hive Issue Type: Sub-task Reporter: Edward Capriolo Assignee: Edward Capriolo Attachments: HIVE-5253.10.patch.txt, HIVE-5253.11.patch.txt, HIVE-5253.1.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.8.patch.txt, HIVE-5253.9.patch.txt, HIVE-5253.patch.txt -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5253) Create component to compile and jar dynamic code
[ https://issues.apache.org/jira/browse/HIVE-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13787849#comment-13787849 ] Brock Noland commented on HIVE-5253: This looks pretty good. Now that HIVE-5400 is in, are their still concerns about this? Create component to compile and jar dynamic code Key: HIVE-5253 URL: https://issues.apache.org/jira/browse/HIVE-5253 Project: Hive Issue Type: Sub-task Reporter: Edward Capriolo Assignee: Edward Capriolo Attachments: HIVE-5253.10.patch.txt, HIVE-5253.11.patch.txt, HIVE-5253.1.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.8.patch.txt, HIVE-5253.9.patch.txt, HIVE-5253.patch.txt -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5253) Create component to compile and jar dynamic code
[
https://issues.apache.org/jira/browse/HIVE-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13783158#comment-13783158
]
Hive QA commented on HIVE-5253:
---
{color:green}Overall{color}: +1 all checks pass
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12606118/HIVE-5253.11.patch.txt
{color:green}SUCCESS:{color} +1 4078 tests passed
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/982/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/982/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
Create component to compile and jar dynamic code
Key: HIVE-5253
URL: https://issues.apache.org/jira/browse/HIVE-5253
Project: Hive
Issue Type: Sub-task
Reporter: Edward Capriolo
Assignee: Edward Capriolo
Attachments: HIVE-5253.10.patch.txt, HIVE-5253.11.patch.txt,
HIVE-5253.1.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt,
HIVE-5253.3.patch.txt, HIVE-5253.8.patch.txt, HIVE-5253.9.patch.txt,
HIVE-5253.patch.txt
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HIVE-5253) Create component to compile and jar dynamic code
[
https://issues.apache.org/jira/browse/HIVE-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13782039#comment-13782039
]
Brock Noland commented on HIVE-5253:
Hi,
Overall looks great!! Just a few items below:
* It looks like something is wrong with TestCompileProcessor in the patch? Look
how the class appears to be concatenated to itself?
* In parse, if the string does not contain and ending ` endPosition will be -1.
Should we check it's value after the for loop?
* In compile we aren't checking to see that the mkdir method returns true.
very-much nits:
Is this still true? It looks like you are handling escapes in the for loop?
{noformat}
+//TODO Escape handling will be changed in follow on
{noformat}
Missing one space:
{noformat}
+while (command.charAt(startPosition++) != '`' startPosition
command.length()){
{noformat}
Space is not same on both sides of lang:
{noformat}
+ throw new CompileProcessorException(Can not compile +lang+ . Hive can
only compile +GROOVY);
{noformat}
Create component to compile and jar dynamic code
Key: HIVE-5253
URL: https://issues.apache.org/jira/browse/HIVE-5253
Project: Hive
Issue Type: Sub-task
Reporter: Edward Capriolo
Assignee: Edward Capriolo
Attachments: HIVE-5253.10.patch.txt, HIVE-5253.1.patch.txt,
HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt,
HIVE-5253.8.patch.txt, HIVE-5253.9.patch.txt, HIVE-5253.patch.txt
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HIVE-5253) Create component to compile and jar dynamic code
[ https://issues.apache.org/jira/browse/HIVE-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13782159#comment-13782159 ] Ashutosh Chauhan commented on HIVE-5253: I have one concern with this work: Security. This will open up another way of doing code injection in hive script. We already have to deal with this via udfs, transform scripts etc. This is adding one more. [~appodictic] Do you have any recommendation on how security for such script will be dealt with? [~brocknoland] I assume you also worked a bit on Sentry. This will present a problem there also. Will it? cc: [~shreepadma] [~prasadm] Create component to compile and jar dynamic code Key: HIVE-5253 URL: https://issues.apache.org/jira/browse/HIVE-5253 Project: Hive Issue Type: Sub-task Reporter: Edward Capriolo Assignee: Edward Capriolo Attachments: HIVE-5253.10.patch.txt, HIVE-5253.1.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.8.patch.txt, HIVE-5253.9.patch.txt, HIVE-5253.patch.txt -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5253) Create component to compile and jar dynamic code
[ https://issues.apache.org/jira/browse/HIVE-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13782217#comment-13782217 ] Edward Capriolo commented on HIVE-5253: --- On the security front. This is actually no different then letting someone say add jar. When someone run's add jar they are injecting code. Really this patch just removes the manual time consuming manual parts (eclipse, build-jar, copy jar to server). Also on the same front, doesn't pig allow someone to supply jython and jruby udfs? The simple solution is to simply remove the groovy.jar from your hive lib directory, then this would fail :) We should open up a separate issue in the parent, or possibly address security concerns in 'Add ql syntax for inline java code creation'. That is out of scope here this jira is only to build the dynamic functionality, the code is still unreachable because the CompileProcessor is not available from the switch statement in this patch. Create component to compile and jar dynamic code Key: HIVE-5253 URL: https://issues.apache.org/jira/browse/HIVE-5253 Project: Hive Issue Type: Sub-task Reporter: Edward Capriolo Assignee: Edward Capriolo Attachments: HIVE-5253.10.patch.txt, HIVE-5253.1.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.8.patch.txt, HIVE-5253.9.patch.txt, HIVE-5253.patch.txt -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5253) Create component to compile and jar dynamic code
[ https://issues.apache.org/jira/browse/HIVE-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13782220#comment-13782220 ] Brock Noland commented on HIVE-5253: Hey Ashutosh, Upon first look I had the same concern. Then after thinking about it, I don't see how this is different than the TRANSFORM() or normal UDF functionality. That is by default users can execute arbitrary code and this work doesn't change that. From a Sentry perspective, this would have to be disabled due to it's execution model (i.e. executing as the hive user). You did remind me that I forgot one comment I was thinking of. I think we should afford admins who want to disable this functionality the ability to do so. Since such admins might want to disable other commands such as add or dfs, it wouldn't be much trouble to allow them to do this as well. For example we could have a configuration option hive.available.commands (or similar) which specified add,set,delete,reset, etc by default. Then check this value in CommandProcessorFactory. It would probably make sense to add this property to the restrict list. Also regarding my comment above It looks like something is wrong with TestCompileProcessor in the patch? Look how the class appears to be concatenated to itself? I see I was looking at v9 not v10. That item should be ignored. Create component to compile and jar dynamic code Key: HIVE-5253 URL: https://issues.apache.org/jira/browse/HIVE-5253 Project: Hive Issue Type: Sub-task Reporter: Edward Capriolo Assignee: Edward Capriolo Attachments: HIVE-5253.10.patch.txt, HIVE-5253.1.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.8.patch.txt, HIVE-5253.9.patch.txt, HIVE-5253.patch.txt -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5253) Create component to compile and jar dynamic code
[ https://issues.apache.org/jira/browse/HIVE-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13782226#comment-13782226 ] Brock Noland commented on HIVE-5253: bq. We should open up a separate issue in the parent, or possibly address security concerns in 'Add ql syntax for inline java code creation'. That is out of scope here, this jira is only to build the dynamic functionality, the code is still unreachable because the CompileProcessor is not available from the switch statement in this patch. Seems fair, I created HIVE-5400 for my request above. Create component to compile and jar dynamic code Key: HIVE-5253 URL: https://issues.apache.org/jira/browse/HIVE-5253 Project: Hive Issue Type: Sub-task Reporter: Edward Capriolo Assignee: Edward Capriolo Attachments: HIVE-5253.10.patch.txt, HIVE-5253.1.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.8.patch.txt, HIVE-5253.9.patch.txt, HIVE-5253.patch.txt -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5253) Create component to compile and jar dynamic code
[ https://issues.apache.org/jira/browse/HIVE-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13781470#comment-13781470 ] Brock Noland commented on HIVE-5253: Looks like v8 doesn't include the full change? It's only 2KB and doesn't have CompileProcessor? Create component to compile and jar dynamic code Key: HIVE-5253 URL: https://issues.apache.org/jira/browse/HIVE-5253 Project: Hive Issue Type: Sub-task Reporter: Edward Capriolo Assignee: Edward Capriolo Attachments: HIVE-5253.1.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.8.patch.txt, HIVE-5253.patch.txt -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5253) Create component to compile and jar dynamic code
[
https://issues.apache.org/jira/browse/HIVE-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13781558#comment-13781558
]
Hive QA commented on HIVE-5253:
---
{color:green}Overall{color}: +1 all checks pass
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12605826/HIVE-5253.10.patch.txt
{color:green}SUCCESS:{color} +1 3180 tests passed
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/958/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/958/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
Create component to compile and jar dynamic code
Key: HIVE-5253
URL: https://issues.apache.org/jira/browse/HIVE-5253
Project: Hive
Issue Type: Sub-task
Reporter: Edward Capriolo
Assignee: Edward Capriolo
Attachments: HIVE-5253.10.patch.txt, HIVE-5253.1.patch.txt,
HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt,
HIVE-5253.8.patch.txt, HIVE-5253.9.patch.txt, HIVE-5253.patch.txt
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HIVE-5253) Create component to compile and jar dynamic code
[ https://issues.apache.org/jira/browse/HIVE-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13777606#comment-13777606 ] Edward Capriolo commented on HIVE-5253: --- [~brocknoland] Did this not patch? Create component to compile and jar dynamic code Key: HIVE-5253 URL: https://issues.apache.org/jira/browse/HIVE-5253 Project: Hive Issue Type: Sub-task Reporter: Edward Capriolo Assignee: Edward Capriolo Attachments: HIVE-5253.1.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.patch.txt -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-5253) Create component to compile and jar dynamic code
[
https://issues.apache.org/jira/browse/HIVE-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13777667#comment-13777667
]
Brock Noland commented on HIVE-5253:
One of the huge downsides of the current build is that we cannot detect the
difference between something that fails to compile and a check style violation.
Since your patch does not introduce them, it looks like there are violations on
trunk at present. See below.
{noformat}
checkstyle:
[echo] hcatalog
[checkstyle] Running Checkstyle 5.5 on 613 files
[checkstyle]
/data/hive-ptest/working/apache-svn-trunk-source/hcatalog/core/src/main/java/org/apache/hcatalog/common/HCatUtil.java:453:
method def child at indentation level 6 not at correct indentation, 4
[checkstyle]
/data/hive-ptest/working/apache-svn-trunk-source/hcatalog/core/src/main/java/org/apache/hcatalog/common/HCatUtil.java:454:
method def child at indentation level 6 not at correct indentation, 4
[checkstyle]
/data/hive-ptest/working/apache-svn-trunk-source/hcatalog/core/src/main/java/org/apache/hcatalog/common/HCatUtil.java:455:
method def child at indentation level 6 not at correct indentation, 4
[checkstyle]
/data/hive-ptest/working/apache-svn-trunk-source/hcatalog/core/src/main/java/org/apache/hcatalog/common/HCatUtil.java:456:
method call child at indentation level 6 not at correct indentation, 8
[checkstyle]
/data/hive-ptest/working/apache-svn-trunk-source/hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HCatUtil.java:486:
method def child at indentation level 3 not at correct indentation, 4
[checkstyle]
/data/hive-ptest/working/apache-svn-trunk-source/hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HCatUtil.java:487:
method call child at indentation level 3 not at correct indentation, 4
[checkstyle]
/data/hive-ptest/working/apache-svn-trunk-source/hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HCatUtil.java:487:
method def child at indentation level 3 not at correct indentation, 4
[checkstyle]
/data/hive-ptest/working/apache-svn-trunk-source/hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HCatUtil.java:488:
method def child at indentation level 3 not at correct indentation, 4
[for] hcatalog: The following error occurred while executing this line:
[for] /data/hive-ptest/working/apache-svn-trunk-source/build.xml:355: The
following error occurred while executing this line:
[for]
/data/hive-ptest/working/apache-svn-trunk-source/hcatalog/build.xml:127: The
following error occurred while executing this line:
[for]
/data/hive-ptest/working/apache-svn-trunk-source/hcatalog/build-support/ant/checkstyle.xml:32:
Got 8 errors and 0 warnings.
{noformat}
Create component to compile and jar dynamic code
Key: HIVE-5253
URL: https://issues.apache.org/jira/browse/HIVE-5253
Project: Hive
Issue Type: Sub-task
Reporter: Edward Capriolo
Assignee: Edward Capriolo
Attachments: HIVE-5253.1.patch.txt, HIVE-5253.3.patch.txt,
HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.patch.txt
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-5253) Create component to compile and jar dynamic code
[ https://issues.apache.org/jira/browse/HIVE-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13768530#comment-13768530 ] Edward Capriolo commented on HIVE-5253: --- https://reviews.facebook.net/differential/diff/40041/ Create component to compile and jar dynamic code Key: HIVE-5253 URL: https://issues.apache.org/jira/browse/HIVE-5253 Project: Hive Issue Type: Sub-task Reporter: Edward Capriolo Assignee: Edward Capriolo Attachments: HIVE-5253.patch.txt -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-5253) Create component to compile and jar dynamic code
[ https://issues.apache.org/jira/browse/HIVE-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13768010#comment-13768010 ] Edward Capriolo commented on HIVE-5253: --- I am pretty sure this is a bogus error message. Does anyway care to review? Create component to compile and jar dynamic code Key: HIVE-5253 URL: https://issues.apache.org/jira/browse/HIVE-5253 Project: Hive Issue Type: Sub-task Reporter: Edward Capriolo Assignee: Edward Capriolo Attachments: HIVE-5253.patch.txt -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-5253) Create component to compile and jar dynamic code
[ https://issues.apache.org/jira/browse/HIVE-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13768054#comment-13768054 ] Carl Steinbach commented on HIVE-5253: -- Can you post a review request? Thanks. Create component to compile and jar dynamic code Key: HIVE-5253 URL: https://issues.apache.org/jira/browse/HIVE-5253 Project: Hive Issue Type: Sub-task Reporter: Edward Capriolo Assignee: Edward Capriolo Attachments: HIVE-5253.patch.txt -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-5253) Create component to compile and jar dynamic code
[
https://issues.apache.org/jira/browse/HIVE-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767349#comment-13767349
]
Hive QA commented on HIVE-5253:
---
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12602962/HIVE-5253.patch.txt
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 3110 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testNegativeCliDriver_mapreduce_stack_trace_hadoop20
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/725/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/725/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests failed with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
Create component to compile and jar dynamic code
Key: HIVE-5253
URL: https://issues.apache.org/jira/browse/HIVE-5253
Project: Hive
Issue Type: Sub-task
Reporter: Edward Capriolo
Assignee: Edward Capriolo
Attachments: HIVE-5253.patch.txt
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
