[jira] [Commented] (HIVE-5380) Non-default OI constructors should be supported for backwards compatibility
[ https://issues.apache.org/jira/browse/HIVE-5380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13911395#comment-13911395 ] Lefty Leverenz commented on HIVE-5380: -- [~lars_francke] identified the source of the exclamation point prefixes in the Hive SerDe Object Inspector sections of the Developer Guide: old MoinMoin syntax. (See his comment on the SerDes doc: https://cwiki.apache.org/confluence/display/Hive/SerDe?focusedCommentId=39620650#comment-39620650.) So I'm taking them out. Non-default OI constructors should be supported for backwards compatibility --- Key: HIVE-5380 URL: https://issues.apache.org/jira/browse/HIVE-5380 Project: Hive Issue Type: Bug Affects Versions: 0.13.0 Reporter: Brock Noland Assignee: Brock Noland Priority: Minor Fix For: 0.13.0 Attachments: HIVE-5380.patch, HIVE-5380.patch, HIVE-5380.patch In HIVE-5263 we started serializing OI's when cloning the plan. This was a great boost in speed for many queries. In the future we'd like to stop copying the OI's, perhaps in HIVE-4396. Until then Custom Serdes will not work on trunk. This is a fix to allow custom serdes such as the Hive JSon Serde work until we address the fact we don't want to have to copy the OI's. Since this is modifying the byte code, we should recommend that the no-arg constructor be added. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HIVE-5380) Non-default OI constructors should be supported for backwards compatibility
[ https://issues.apache.org/jira/browse/HIVE-5380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13896490#comment-13896490 ] Brock Noland commented on HIVE-5380: Good call... I added it to the Object Inspector section! Non-default OI constructors should be supported for backwards compatibility --- Key: HIVE-5380 URL: https://issues.apache.org/jira/browse/HIVE-5380 Project: Hive Issue Type: Bug Affects Versions: 0.13.0 Reporter: Brock Noland Assignee: Brock Noland Priority: Minor Fix For: 0.13.0 Attachments: HIVE-5380.patch, HIVE-5380.patch, HIVE-5380.patch In HIVE-5263 we started serializing OI's when cloning the plan. This was a great boost in speed for many queries. In the future we'd like to stop copying the OI's, perhaps in HIVE-4396. Until then Custom Serdes will not work on trunk. This is a fix to allow custom serdes such as the Hive JSon Serde work until we address the fact we don't want to have to copy the OI's. Since this is modifying the byte code, we should recommend that the no-arg constructor be added. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HIVE-5380) Non-default OI constructors should be supported for backwards compatibility
[ https://issues.apache.org/jira/browse/HIVE-5380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13897143#comment-13897143 ] Lefty Leverenz commented on HIVE-5380: -- Looks good, thanks [~brocknoland]. Non-default OI constructors should be supported for backwards compatibility --- Key: HIVE-5380 URL: https://issues.apache.org/jira/browse/HIVE-5380 Project: Hive Issue Type: Bug Affects Versions: 0.13.0 Reporter: Brock Noland Assignee: Brock Noland Priority: Minor Fix For: 0.13.0 Attachments: HIVE-5380.patch, HIVE-5380.patch, HIVE-5380.patch In HIVE-5263 we started serializing OI's when cloning the plan. This was a great boost in speed for many queries. In the future we'd like to stop copying the OI's, perhaps in HIVE-4396. Until then Custom Serdes will not work on trunk. This is a fix to allow custom serdes such as the Hive JSon Serde work until we address the fact we don't want to have to copy the OI's. Since this is modifying the byte code, we should recommend that the no-arg constructor be added. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HIVE-5380) Non-default OI constructors should be supported for backwards compatibility
[ https://issues.apache.org/jira/browse/HIVE-5380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13895544#comment-13895544 ] Lefty Leverenz commented on HIVE-5380: -- Does this need to be mentioned in the wiki? If so, here are some possible locations: * [Developer Guide: Object Inspector |https://cwiki.apache.org/confluence/display/Hive/DeveloperGuide#DeveloperGuide-ObjectInspector] -- by the way, would someone please explain what the exclamation points mean in this section and the previous one (Hive SerDe)? * [Developer Guide: how to add a new SerDe |https://cwiki.apache.org/confluence/display/Hive/DeveloperGuide#DeveloperGuide-SerDe-howtoaddanewSerDe] * [Hive Plugins |https://cwiki.apache.org/confluence/display/Hive/HivePlugins] * [SerDe: Additional Notes |https://cwiki.apache.org/confluence/display/Hive/SerDe#SerDe-Additionalnotes] * [Language Manual: Create Table: Row Format, Storage Format, and SerDe |https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-RowFormat,StorageFormat,andSerDe] Non-default OI constructors should be supported for backwards compatibility --- Key: HIVE-5380 URL: https://issues.apache.org/jira/browse/HIVE-5380 Project: Hive Issue Type: Bug Affects Versions: 0.13.0 Reporter: Brock Noland Assignee: Brock Noland Priority: Minor Fix For: 0.13.0 Attachments: HIVE-5380.patch, HIVE-5380.patch, HIVE-5380.patch In HIVE-5263 we started serializing OI's when cloning the plan. This was a great boost in speed for many queries. In the future we'd like to stop copying the OI's, perhaps in HIVE-4396. Until then Custom Serdes will not work on trunk. This is a fix to allow custom serdes such as the Hive JSon Serde work until we address the fact we don't want to have to copy the OI's. Since this is modifying the byte code, we should recommend that the no-arg constructor be added. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HIVE-5380) Non-default OI constructors should be supported for backwards compatibility
[
https://issues.apache.org/jira/browse/HIVE-5380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859745#comment-13859745
]
Hive QA commented on HIVE-5380:
---
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12620965/HIVE-5380.patch
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 4818 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_bucket_num_reducers
{noformat}
Test results:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/778/testReport
Console output:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/778/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12620965
Non-default OI constructors should be supported for backwards compatibility
---
Key: HIVE-5380
URL: https://issues.apache.org/jira/browse/HIVE-5380
Project: Hive
Issue Type: Bug
Affects Versions: 0.13.0
Reporter: Brock Noland
Assignee: Brock Noland
Priority: Minor
Attachments: HIVE-5380.patch, HIVE-5380.patch, HIVE-5380.patch
In HIVE-5263 we started serializing OI's when cloning the plan. This was a
great boost in speed for many queries. In the future we'd like to stop
copying the OI's, perhaps in HIVE-4396.
Until then Custom Serdes will not work on trunk. This is a fix to allow
custom serdes such as the Hive JSon Serde work until we address the fact we
don't want to have to copy the OI's.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HIVE-5380) Non-default OI constructors should be supported for backwards compatibility
[ https://issues.apache.org/jira/browse/HIVE-5380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13850731#comment-13850731 ] Xuefu Zhang commented on HIVE-5380: --- +1 Non-default OI constructors should be supported for backwards compatibility --- Key: HIVE-5380 URL: https://issues.apache.org/jira/browse/HIVE-5380 Project: Hive Issue Type: Bug Affects Versions: 0.13.0 Reporter: Brock Noland Assignee: Brock Noland Priority: Minor Attachments: HIVE-5380.patch, HIVE-5380.patch In HIVE-5263 we started serializing OI's when cloning the plan. This was a great boost in speed for many queries. In the future we'd like to stop copying the OI's, perhaps in HIVE-4396. Until then Custom Serdes will not work on trunk. This is a fix to allow custom serdes such as the Hive JSon Serde work until we address the fact we don't want to have to copy the OI's. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
