[jira] [Commented] (HIVE-5655) Hive incorrecly handles divide-by-zero case
[ https://issues.apache.org/jira/browse/HIVE-5655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13814909#comment-13814909 ] Hive QA commented on HIVE-5655: --- {color:green}Overall{color}: +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12612331/HIVE-5655.3.patch {color:green}SUCCESS:{color} +1 4552 tests passed Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/149/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/149/console Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12612331 Hive incorrecly handles divide-by-zero case --- Key: HIVE-5655 URL: https://issues.apache.org/jira/browse/HIVE-5655 Project: Hive Issue Type: Improvement Components: Types Affects Versions: 0.10.0, 0.11.0, 0.12.0 Reporter: Xuefu Zhang Assignee: Xuefu Zhang Attachments: HIVE-5655.1.patch, HIVE-5655.2.patch, HIVE-5655.3.patch, HIVE-5655.patch Unlike other databases, Hive currently has only one mode (default mode) regarding error handling, in which NULL value is returned. However, in case of divide-by-zero, Hive demonstrated a different behavior. {code} hive select 5/0 from tmp2 limit 1; Total MapReduce jobs = 1 ... Total MapReduce CPU Time Spent: 860 msec OK Infinity {code} The correct behaviour should be Hive returning NULL instead in order to be consistent w.r.t error handling. (BTW, the same situation is handled corrected for decimal type.) MySQL has server modes control the behaviour. By default, NULL is returned. For instance, {code} mysql select 3/0 from dual; +--+ | 3/0 | +--+ | NULL | +--+ 1 row in set (0.00 sec) {code} -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5655) Hive incorrecly handles divide-by-zero case
[ https://issues.apache.org/jira/browse/HIVE-5655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815016#comment-13815016 ] Brock Noland commented on HIVE-5655: +1 Hive incorrecly handles divide-by-zero case --- Key: HIVE-5655 URL: https://issues.apache.org/jira/browse/HIVE-5655 Project: Hive Issue Type: Improvement Components: Types Affects Versions: 0.10.0, 0.11.0, 0.12.0 Reporter: Xuefu Zhang Assignee: Xuefu Zhang Attachments: HIVE-5655.1.patch, HIVE-5655.2.patch, HIVE-5655.3.patch, HIVE-5655.patch Unlike other databases, Hive currently has only one mode (default mode) regarding error handling, in which NULL value is returned. However, in case of divide-by-zero, Hive demonstrated a different behavior. {code} hive select 5/0 from tmp2 limit 1; Total MapReduce jobs = 1 ... Total MapReduce CPU Time Spent: 860 msec OK Infinity {code} The correct behaviour should be Hive returning NULL instead in order to be consistent w.r.t error handling. (BTW, the same situation is handled corrected for decimal type.) MySQL has server modes control the behaviour. By default, NULL is returned. For instance, {code} mysql select 3/0 from dual; +--+ | 3/0 | +--+ | NULL | +--+ 1 row in set (0.00 sec) {code} -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5655) Hive incorrecly handles divide-by-zero case
[ https://issues.apache.org/jira/browse/HIVE-5655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813319#comment-13813319 ] Brock Noland commented on HIVE-5655: Looks like the RB item has not been updated with the latest patch. Can you upload it? Hive incorrecly handles divide-by-zero case --- Key: HIVE-5655 URL: https://issues.apache.org/jira/browse/HIVE-5655 Project: Hive Issue Type: Improvement Components: Types Affects Versions: 0.10.0, 0.11.0, 0.12.0 Reporter: Xuefu Zhang Assignee: Xuefu Zhang Attachments: HIVE-5655.1.patch, HIVE-5655.2.patch, HIVE-5655.patch Unlike other databases, Hive currently has only one mode (default mode) regarding error handling, in which NULL value is returned. However, in case of divide-by-zero, Hive demonstrated a different behavior. {code} hive select 5/0 from tmp2 limit 1; Total MapReduce jobs = 1 ... Total MapReduce CPU Time Spent: 860 msec OK Infinity {code} The correct behaviour should be Hive returning NULL instead in order to be consistent w.r.t error handling. (BTW, the same situation is handled corrected for decimal type.) MySQL has server modes control the behaviour. By default, NULL is returned. For instance, {code} mysql select 3/0 from dual; +--+ | 3/0 | +--+ | NULL | +--+ 1 row in set (0.00 sec) {code} -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5655) Hive incorrecly handles divide-by-zero case
[ https://issues.apache.org/jira/browse/HIVE-5655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809452#comment-13809452 ] Hive QA commented on HIVE-5655: --- {color:green}Overall{color}: +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12610758/HIVE-5655.2.patch {color:green}SUCCESS:{color} +1 4517 tests passed Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/31/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/31/console Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. Hive incorrecly handles divide-by-zero case --- Key: HIVE-5655 URL: https://issues.apache.org/jira/browse/HIVE-5655 Project: Hive Issue Type: Improvement Components: Types Affects Versions: 0.10.0, 0.11.0, 0.12.0 Reporter: Xuefu Zhang Assignee: Xuefu Zhang Attachments: HIVE-5655.1.patch, HIVE-5655.2.patch, HIVE-5655.patch Unlike other databases, Hive currently has only one mode (default mode) regarding error handling, in which NULL value is returned. However, in case of divide-by-zero, Hive demonstrated a different behavior. {code} hive select 5/0 from tmp2 limit 1; Total MapReduce jobs = 1 ... Total MapReduce CPU Time Spent: 860 msec OK Infinity {code} The correct behaviour should be Hive returning NULL instead in order to be consistent w.r.t error handling. (BTW, the same situation is handled corrected for decimal type.) MySQL has server modes control the behaviour. By default, NULL is returned. For instance, {code} mysql select 3/0 from dual; +--+ | 3/0 | +--+ | NULL | +--+ 1 row in set (0.00 sec) {code} -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5655) Hive incorrecly handles divide-by-zero case
[ https://issues.apache.org/jira/browse/HIVE-5655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13807177#comment-13807177 ] Xuefu Zhang commented on HIVE-5655: --- As an update, I'm looking into the HBase test case failure, which I originally thought unrelated. The other test failure is obvious. I just need to generate .out file. Hive incorrecly handles divide-by-zero case --- Key: HIVE-5655 URL: https://issues.apache.org/jira/browse/HIVE-5655 Project: Hive Issue Type: Improvement Components: Types Affects Versions: 0.10.0, 0.11.0, 0.12.0 Reporter: Xuefu Zhang Assignee: Xuefu Zhang Attachments: HIVE-5655.1.patch, HIVE-5655.patch Unlike other databases, Hive currently has only one mode (default mode) regarding error handling, in which NULL value is returned. However, in case of divide-by-zero, Hive demonstrated a different behavior. {code} hive select 5/0 from tmp2 limit 1; Total MapReduce jobs = 1 ... Total MapReduce CPU Time Spent: 860 msec OK Infinity {code} The correct behaviour should be Hive returning NULL instead in order to be consistent w.r.t error handling. (BTW, the same situation is handled corrected for decimal type.) MySQL has server modes control the behaviour. By default, NULL is returned. For instance, {code} mysql select 3/0 from dual; +--+ | 3/0 | +--+ | NULL | +--+ 1 row in set (0.00 sec) {code} -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5655) Hive incorrecly handles divide-by-zero case
[ https://issues.apache.org/jira/browse/HIVE-5655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13806197#comment-13806197 ] Edward Capriolo commented on HIVE-5655: --- +1 . [~xuefuz] We(I) recently committed a new system that runs udf tests through the operator chain. Maybe you want to base your junit test on that. see ./ql/src/test/org/apache/hadoop/hive/ql/testutil/BaseScalarUdfTest.java Hive incorrecly handles divide-by-zero case --- Key: HIVE-5655 URL: https://issues.apache.org/jira/browse/HIVE-5655 Project: Hive Issue Type: Improvement Components: Types Affects Versions: 0.10.0, 0.11.0, 0.12.0 Reporter: Xuefu Zhang Assignee: Xuefu Zhang Attachments: HIVE-5655.1.patch, HIVE-5655.patch Unlike other databases, Hive currently has only one mode (default mode) regarding error handling, in which NULL value is returned. However, in case of divide-by-zero, Hive demonstrated a different behavior. {code} hive select 5/0 from tmp2 limit 1; Total MapReduce jobs = 1 ... Total MapReduce CPU Time Spent: 860 msec OK Infinity {code} The correct behaviour should be Hive returning NULL instead in order to be consistent w.r.t error handling. (BTW, the same situation is handled corrected for decimal type.) MySQL has server modes control the behaviour. By default, NULL is returned. For instance, {code} mysql select 3/0 from dual; +--+ | 3/0 | +--+ | NULL | +--+ 1 row in set (0.00 sec) {code} -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5655) Hive incorrecly handles divide-by-zero case
[ https://issues.apache.org/jira/browse/HIVE-5655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13806209#comment-13806209 ] Hive QA commented on HIVE-5655: --- {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12610460/HIVE-5655.1.patch {color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 4484 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_vectorization_13 org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver_hbase_stats3 {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1256/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1256/console Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests failed with: TestsFailedException: 2 tests failed {noformat} This message is automatically generated. Hive incorrecly handles divide-by-zero case --- Key: HIVE-5655 URL: https://issues.apache.org/jira/browse/HIVE-5655 Project: Hive Issue Type: Improvement Components: Types Affects Versions: 0.10.0, 0.11.0, 0.12.0 Reporter: Xuefu Zhang Assignee: Xuefu Zhang Attachments: HIVE-5655.1.patch, HIVE-5655.patch Unlike other databases, Hive currently has only one mode (default mode) regarding error handling, in which NULL value is returned. However, in case of divide-by-zero, Hive demonstrated a different behavior. {code} hive select 5/0 from tmp2 limit 1; Total MapReduce jobs = 1 ... Total MapReduce CPU Time Spent: 860 msec OK Infinity {code} The correct behaviour should be Hive returning NULL instead in order to be consistent w.r.t error handling. (BTW, the same situation is handled corrected for decimal type.) MySQL has server modes control the behaviour. By default, NULL is returned. For instance, {code} mysql select 3/0 from dual; +--+ | 3/0 | +--+ | NULL | +--+ 1 row in set (0.00 sec) {code} -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5655) Hive incorrecly handles divide-by-zero case
[ https://issues.apache.org/jira/browse/HIVE-5655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13806224#comment-13806224 ] Xuefu Zhang commented on HIVE-5655: --- Thanks, Edward. I knew about your proposal of new way of testing udfs, but didn't realize that you have completed that already. I will take a look. Thank you for the review and bringing this up. Hive incorrecly handles divide-by-zero case --- Key: HIVE-5655 URL: https://issues.apache.org/jira/browse/HIVE-5655 Project: Hive Issue Type: Improvement Components: Types Affects Versions: 0.10.0, 0.11.0, 0.12.0 Reporter: Xuefu Zhang Assignee: Xuefu Zhang Attachments: HIVE-5655.1.patch, HIVE-5655.patch Unlike other databases, Hive currently has only one mode (default mode) regarding error handling, in which NULL value is returned. However, in case of divide-by-zero, Hive demonstrated a different behavior. {code} hive select 5/0 from tmp2 limit 1; Total MapReduce jobs = 1 ... Total MapReduce CPU Time Spent: 860 msec OK Infinity {code} The correct behaviour should be Hive returning NULL instead in order to be consistent w.r.t error handling. (BTW, the same situation is handled corrected for decimal type.) MySQL has server modes control the behaviour. By default, NULL is returned. For instance, {code} mysql select 3/0 from dual; +--+ | 3/0 | +--+ | NULL | +--+ 1 row in set (0.00 sec) {code} -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5655) Hive incorrecly handles divide-by-zero case
[ https://issues.apache.org/jira/browse/HIVE-5655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13806235#comment-13806235 ] Hive QA commented on HIVE-5655: --- {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12610460/HIVE-5655.1.patch {color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 4456 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_vectorization_13 org.apache.hive.hcatalog.listener.TestNotificationListener.testAMQListener {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1258/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1258/console Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests failed with: TestsFailedException: 2 tests failed {noformat} This message is automatically generated. Hive incorrecly handles divide-by-zero case --- Key: HIVE-5655 URL: https://issues.apache.org/jira/browse/HIVE-5655 Project: Hive Issue Type: Improvement Components: Types Affects Versions: 0.10.0, 0.11.0, 0.12.0 Reporter: Xuefu Zhang Assignee: Xuefu Zhang Attachments: HIVE-5655.1.patch, HIVE-5655.patch Unlike other databases, Hive currently has only one mode (default mode) regarding error handling, in which NULL value is returned. However, in case of divide-by-zero, Hive demonstrated a different behavior. {code} hive select 5/0 from tmp2 limit 1; Total MapReduce jobs = 1 ... Total MapReduce CPU Time Spent: 860 msec OK Infinity {code} The correct behaviour should be Hive returning NULL instead in order to be consistent w.r.t error handling. (BTW, the same situation is handled corrected for decimal type.) MySQL has server modes control the behaviour. By default, NULL is returned. For instance, {code} mysql select 3/0 from dual; +--+ | 3/0 | +--+ | NULL | +--+ 1 row in set (0.00 sec) {code} -- This message was sent by Atlassian JIRA (v6.1#6144)